Files
PaperClipAI/ui/src/components/IssueMonitorBanner.tsx
T
DottaandPaperclip 21137db805 fix: make Check now work for retained monitors on blocked tasks (#18061)
## Thinking Path

> - Paperclip lets people manage agents and inspect their work.
> - Task monitors schedule checks of work that is still pending.
> - A task can retain a monitor after it becomes blocked.
> - The UI still offered Check now, but the server rejected the task
status.
> - The UI also claimed that an automatic check would run on the next
tick.
> - This change admits an explicit human check through the normal
execution gates and shows that automatic checks are paused.
> - People can request the check without changing task status, and
skipped checks no longer report success.

## Linked Issues or Issue Description

**What happened?**

A blocked task with a retained monitor showed Check now and an overdue
countdown. Clicking the button failed because manual checks required an
in-progress or in-review task. The endpoint also returned success when
admission skipped a check.

**Expected behavior**

A human can request one check through normal admission. Automatic checks
stay paused while the task is blocked. A check that cannot start reports
a conflict.

**Steps to reproduce**

1. Schedule a monitor on an agent-owned task.
2. Let the task become blocked while it retains the schedule.
3. Open the task and click Check now.

Related: #14909 addresses scheduled-retry promotion. This PR addresses
retained task monitors.

**Paperclip version or commit**

Base: 7f10cc0585.

## What Changed

- Allow a human to check a retained monitor on a blocked task. Keep
agent and automatic checks limited to active task statuses.
- Keep the existing admission path and status guard. Do not change task
status to start a check.
- Return 409 when admission skips the check. Preserve the schedule when
a dependency or recovery hold prevents dispatch. Keep a successful
result when a new schedule replaces the consumed schedule after
admission.
- Show Automatic checks paused in the banner, composer strip and
properties. Hide Check now on backlog and todo tasks. Provider-quota
recovery stays paused on blocked tasks because it uses a direct retry
path; its monitor is retained until the task resumes.
- Add database, process, route and UI regression coverage, a Storybook
state, API metadata, and behavior documentation.

## Verification

- `pnpm -r typecheck` passed.
- `pnpm build` passed.
- Server scheduling, process admission and route suites: 94 tests
passed.
- UI monitor, properties and time-formatting suites: 142 tests passed.
- Additional admission checks passed: an explicit check starts a process
on a blocked task; an unresolved dependency prevents dispatch and
preserves the monitor.
- Token gates, map checks, Storybook catalog checks and 30 map/catalog
tests passed.
- The full local `pnpm test:run` attempt reported 1 timeout among 1,621
chat integration tests: “keeps an ambiguous github text part blocked
across restart and retries only that part and its tail” exceeded 15
seconds. The exact case passed in isolation on the final head (1 passed,
1,620 skipped). The remaining full-run groups were stopped to isolate
that failure. This does not establish a full local pass or explain the
initial timeout. Final-head CI is green, including the full chat lanes
and the successful single server-shard retry.
- Browser inspection passed for the blocked-task banner, composer strip
and properties row. Clicking Check now set both visible buttons to
disabled Checking state. The preview uses isolated fixtures.
- CI server shard 7/12 failed one decision-expiry deadline assertion.
The entire unchanged decision-expiry suite passed locally on the final
head (20/20). The single retry of that shard passed after the first
workflow attempt completed. The initial failure remains recorded here.
Neither that test nor its production path changed before retry; the
cause is not established by a passing retry.
- Greptile reviewed final head ed936f7433
at 5/5. Both prior review threads are resolved.
- The first CI chat job stopped after its runner received a shutdown
signal. The final head completed a fresh CI run.
- The process fixture uses a local no-op adapter. It proves admission
and execution, not a live provider's response. The Storybook state
simulates dispatch.

## Risks

- An explicit human check can start work on a blocked task with no
unresolved execution gate. This is intentional. Dependencies, recovery,
native finalization, ownership, pause and budgets retain their existing
checks.
- Skipped manual checks now return 409 instead of 200. The UI already
displays API errors in context.
- No schema change or migration.

## Model Used

OpenAI Codex, based on GPT-6. The session does not expose a more
specific served model ID or context-window size. Used repository tools,
code execution, and browser inspection.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-10-28 13:01:11 -05:00

348 lines
13 KiB
TypeScript

import { useMemo, useState } from "react";
import { Clock, X } from "lucide-react";
import type { Issue, IssueWorkProduct } from "@paperclipai/shared";
import { Button } from "@/components/ui/button";
import {
AlertDialog,
AlertDialogTrigger,
AlertDialogContent,
AlertDialogHeader,
AlertDialogTitle,
AlertDialogDescription,
AlertDialogFooter,
AlertDialogCancel,
} from "@/components/ui/alert-dialog";
import { InlineBanner } from "@/components/InlineBanner";
import { IssuePullRequestLinks } from "@/components/IssuePullRequestLinks";
import { getIssuePullRequests, pullRequestNeedsReview } from "@/lib/issue-pull-requests";
import { cn } from "@/lib/utils";
import {
areAutomaticMonitorChecksPaused,
canCheckIssueMonitorNow,
deriveMonitorState,
formatMonitorAbsolute,
formatMonitorEta,
useMonitorCountdown,
type DerivedMonitorState,
type MonitorDisplayState,
} from "@/lib/issue-monitor";
/** Matches the `Date | string` inputs accepted by the issue-monitor helpers. */
type MonitorDate = Date | string;
/**
* States in which the waiting-monitor surfaces (top banner + composer strip)
* are shown. `cleared` and `none` hide both surfaces entirely — see
* wireframe 04 (PAP-14557).
*/
const WAITING_STATES: readonly MonitorDisplayState[] = [
"scheduled",
"retrying",
"due-now",
"overdue",
];
export function isWaitingMonitorState(state: MonitorDisplayState): boolean {
return WAITING_STATES.includes(state);
}
export function hasVisibleMonitorSurface(issue: Issue): boolean {
const derived = deriveMonitorState(issue);
return isWaitingMonitorState(derived.state) && derived.nextCheckAt !== null;
}
export interface MonitorSurfaceCopy {
/** Prominent lead for the top banner, e.g. "Waiting on monitor — resumes in 2h 12m". */
bannerTitle: string;
/** Prominent lead for the composer strip, e.g. "Resumes in 2h 12m". */
stripTitle: string;
/** Muted detail line for the banner (absolute time carries a "(your time)" hint). */
bannerMeta: string[];
/** Muted detail line for the composer strip. */
stripMeta: string[];
/** `warning` (amber) once overdue, `info` (blue) while still on schedule. */
tone: "info" | "warning";
workspaceWait?: boolean;
pullRequestReview?: boolean;
automaticChecksPaused?: boolean;
checkUnavailable?: boolean;
}
function capitalize(value: string): string {
return value.length === 0 ? value : `${value.charAt(0).toUpperCase()}${value.slice(1)}`;
}
/**
* Pure copy builder shared by the banner and the composer strip so both
* surfaces render one consistent copy system (see wireframe 04). Kept free of
* hooks/`Date.now()` so it is deterministic under test.
*/
export function buildMonitorSurfaceCopy(
derived: DerivedMonitorState,
now: MonitorDate,
scheduledRetryReason?: string | null,
pendingPullRequestReviews = 0,
issueStatus?: string,
): MonitorSurfaceCopy | null {
if (!isWaitingMonitorState(derived.state) || !derived.nextCheckAt) return null;
if (derived.source === "monitor" && areAutomaticMonitorChecksPaused({ status: issueStatus })) {
const canCheckNow = canCheckIssueMonitorNow({ status: issueStatus }, derived.serviceName);
const hint = canCheckNow
? "This task is blocked. You can ask the agent to check now."
: "Resume this task to continue checking.";
return {
bannerTitle: "Automatic checks paused",
stripTitle: "Automatic checks paused",
bannerMeta: [hint],
stripMeta: [hint],
tone: "info",
automaticChecksPaused: true,
checkUnavailable: !canCheckNow,
};
}
if (derived.source === "scheduled-retry" && scheduledRetryReason === "workspace_busy") {
return {
bannerTitle: "Waiting for workspace",
stripTitle: "Waiting for workspace",
bannerMeta: ["Another task is using this workspace. Work starts automatically when it is available."],
stripMeta: ["Work starts automatically when the workspace is available."],
tone: "info",
workspaceWait: true,
};
}
const eta = formatMonitorEta(derived.nextCheckAt, now); // "in 2h 12m" | "due now" | "overdue by 18m"
const absolute = formatMonitorAbsolute(derived.nextCheckAt, {}, now); // local time, e.g. "Today, 4:08 PM"
if (derived.source === "monitor" && derived.serviceName?.toLowerCase() === "github" && pendingPullRequestReviews > 0) {
return {
bannerTitle: "Pull request review requested",
stripTitle: "Pull request review requested",
bannerMeta: [`Next check ${eta} · ${absolute} (your time)`],
stripMeta: [`Next check ${eta} · ${absolute}`],
tone: derived.state === "overdue" ? "warning" : "info",
pullRequestReview: true,
};
}
if (derived.source === "scheduled-retry" && scheduledRetryReason === "ai_connection_pool_wait") {
return {
bannerTitle: "Pool exhausted",
stripTitle: "Pool exhausted",
bannerMeta: [`Usage recheck ${eta} · ${absolute} (your time)`, "Tasks with a selected account keep it while waiting. Work resumes when usage permits."],
stripMeta: [`Usage recheck ${eta} · ${absolute}`, "Tasks with a selected account keep it while waiting."],
tone: "info",
};
}
const isScheduledRetryOnly = derived.source === "scheduled-retry";
let bannerTitle: string;
let stripTitle: string;
let statusHint: string | null = null;
switch (derived.state) {
case "scheduled":
case "retrying":
bannerTitle = isScheduledRetryOnly ? `Agent resumes ${eta}` : `Waiting on monitor — resumes ${eta}`;
stripTitle = `Resumes ${eta}`;
break;
case "due-now":
bannerTitle = isScheduledRetryOnly ? "Agent retry due now" : "Waiting on monitor — due now";
stripTitle = "Due now";
statusHint = "Checking momentarily…";
break;
case "overdue":
default:
bannerTitle = isScheduledRetryOnly ? `Agent retry ${eta}` : `Waiting on monitor — ${eta}`;
stripTitle = capitalize(eta);
statusHint = "Fires on next tick";
break;
}
const attemptLabel = derived.attemptCount >= 1 ? `Attempt ${derived.attemptCount}` : null;
const serviceLabel = derived.serviceName ? `Watching: ${derived.serviceName}` : null;
const bannerMeta = [statusHint, `${absolute} (your time)`, attemptLabel, serviceLabel].filter(
(piece): piece is string => Boolean(piece),
);
const stripMeta = [statusHint, absolute, attemptLabel, serviceLabel].filter(
(piece): piece is string => Boolean(piece),
);
return {
bannerTitle,
stripTitle,
bannerMeta,
stripMeta,
tone: derived.state === "overdue" ? "warning" : "info",
};
}
function useMonitorSurfaceCopy(issue: Issue, pendingPullRequestReviews: number): MonitorSurfaceCopy | null {
// `nextCheckAt` is stable for a given issue; derive once to seed the ticking
// countdown cadence, then re-derive against the live clock so the surfaces
// roll scheduled → due → overdue on their own.
const nextCheckAt = useMemo(() => {
const derived = deriveMonitorState(issue);
return derived.source === "monitor" && areAutomaticMonitorChecksPaused(issue) ? null : derived.nextCheckAt;
}, [issue]);
const now = useMonitorCountdown(nextCheckAt);
return useMemo(() => buildMonitorSurfaceCopy(deriveMonitorState(issue, now), now, issue.scheduledRetry?.scheduledRetryReason, pendingPullRequestReviews, issue.status), [issue, now, pendingPullRequestReviews]);
}
function CheckNowButton({
onCheckNow,
checkingNow,
reviewRequested = false,
}: {
onCheckNow: () => void;
checkingNow: boolean;
reviewRequested?: boolean;
}) {
return (
<Button
type="button"
variant="outline"
size="sm"
className="shrink-0 shadow-none"
onClick={onCheckNow}
disabled={checkingNow}
>
{checkingNow ? "Checking…" : reviewRequested ? "Check status" : "Check now"}
</Button>
);
}
function CancelMonitorButton({ onCancel }: { onCancel: () => Promise<unknown> }) {
const [open, setOpen] = useState(false);
const [pending, setPending] = useState(false);
const [error, setError] = useState<string | null>(null);
const cancel = async () => {
setPending(true);
setError(null);
try {
await onCancel();
setOpen(false);
} catch (err) {
setError(err instanceof Error ? err.message : "Unable to cancel the monitor. Try again.");
} finally {
setPending(false);
}
};
return (
<AlertDialog open={open} onOpenChange={(next) => { if (!pending) { setOpen(next); setError(null); } }}>
<AlertDialogTrigger asChild>
<Button type="button" variant="ghost" size="icon" className="absolute right-2 top-2" aria-label="Cancel monitor" title="Cancel monitor">
<X className="h-4 w-4" aria-hidden="true" />
</Button>
</AlertDialogTrigger>
<AlertDialogContent>
<AlertDialogHeader>
<AlertDialogTitle>Cancel monitor?</AlertDialogTitle>
<AlertDialogDescription>This removes the scheduled monitor check. The agent will no longer resume from this monitor. You can send a message to continue the task.</AlertDialogDescription>
</AlertDialogHeader>
{error ? <p role="alert" className="text-sm text-destructive">{error}</p> : null}
<AlertDialogFooter>
<AlertDialogCancel disabled={pending}>Keep monitor</AlertDialogCancel>
<Button type="button" variant="destructive" disabled={pending} onClick={() => void cancel()}>{pending ? "Cancelling…" : "Cancel monitor"}</Button>
</AlertDialogFooter>
</AlertDialogContent>
</AlertDialog>
);
}
export interface IssueMonitorSurfaceProps {
issue: Issue;
onCheckNow?: (() => void) | null;
checkingNow?: boolean;
workProducts?: IssueWorkProduct[] | null;
checkError?: string | null;
onCancelMonitor?: (() => Promise<unknown>) | null;
}
/**
* Pinned banner rendered between the issue title and description while a
* monitor is waiting. Replaces the description-area "Monitor scheduled" card
* for the waiting state (PAP-14557 decision 1) — the two never render at once.
*/
export function IssueMonitorBanner({
issue,
onCheckNow = null,
checkingNow = false,
workProducts,
checkError,
onCancelMonitor,
}: IssueMonitorSurfaceProps) {
const reviews = getIssuePullRequests(workProducts).filter(pullRequestNeedsReview);
const copy = useMonitorSurfaceCopy(issue, reviews.length);
if (!copy) return null;
const canCancel = onCancelMonitor && deriveMonitorState(issue).source === "monitor";
return (
<InlineBanner
tone={copy.tone}
icon={Clock}
title={copy.bannerTitle}
className={cn("relative my-3", canCancel && "pr-12")}
actions={onCheckNow && !copy.workspaceWait && !copy.checkUnavailable ? <CheckNowButton onCheckNow={onCheckNow} checkingNow={checkingNow} reviewRequested={copy.pullRequestReview} /> : null}
>
{canCancel ? <CancelMonitorButton key={issue.id} onCancel={onCancelMonitor} /> : null}
<div className="flex flex-col gap-2">
{copy.pullRequestReview ? <IssuePullRequestLinks products={reviews} /> : null}
<span>{copy.bannerMeta.join(" · ")}</span>
{checkError ? <p role="alert">{checkError}</p> : null}
</div>
</InlineBanner>
);
}
/**
* Slim, inline (not sticky) strip anchored directly above the reply composer.
* Mirrors the banner's monitor state and reminds the reader that replying wakes
* the agent early (PAP-14557 decisions 2 + wireframe 02).
*/
export function IssueMonitorComposerStrip({
issue,
onCheckNow = null,
checkingNow = false,
workProducts,
checkError,
className,
}: IssueMonitorSurfaceProps & { className?: string }) {
const reviews = getIssuePullRequests(workProducts).filter(pullRequestNeedsReview);
const copy = useMonitorSurfaceCopy(issue, reviews.length);
if (!copy) return null;
return (
<div
role="note"
data-testid="issue-monitor-composer-strip"
className={cn("rounded-lg border border-border bg-muted/30 px-3 py-2", className)}
>
<div className="flex flex-col gap-2 sm:flex-row sm:items-center sm:justify-between">
<div className="flex min-w-0 items-start gap-2">
<Clock className="mt-0.5 h-4 w-4 shrink-0 text-muted-foreground" aria-hidden="true" />
<div className="flex min-w-0 flex-col gap-2">
<div className="text-sm font-medium text-foreground">{copy.stripTitle}</div>
{copy.pullRequestReview ? <IssuePullRequestLinks products={reviews} /> : null}
<div className="text-xs text-muted-foreground">{copy.stripMeta.join(" · ")}</div>
</div>
</div>
{onCheckNow && !copy.workspaceWait && !copy.checkUnavailable ? <CheckNowButton onCheckNow={onCheckNow} checkingNow={checkingNow} reviewRequested={copy.pullRequestReview} /> : null}
</div>
{!copy.automaticChecksPaused ? (
<p className="mt-1.5 text-xs text-muted-foreground">
{copy.pullRequestReview
? "Review on GitHub, then check status to have the agent verify the result."
: copy.workspaceWait
? "You can keep sending instructions while the agent waits."
: "Sending a reply wakes the agent now — before the scheduled check."}
</p>
) : null}
{checkError ? <p role="alert" className="text-sm text-destructive">{checkError}</p> : null}
</div>
);
}