mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-14 00:26:28 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
89 lines
6.4 KiB
TypeScript
89 lines
6.4 KiB
TypeScript
import type { Locator, Page } from "@playwright/test";
|
|
import type { ChatRun } from "./chat-flow.js";
|
|
|
|
interface Row { id: string; companyId?: string; issueId?: string; authorAgentId?: string | null; createdByRunId?: string | null; name?: string; action?: string; entityType?: string; entityId?: string; agentId?: string | null; actorType?: string; actorId?: string; runId?: string | null }
|
|
export interface RenderedConversationLink {
|
|
threadTestId: "task-chat-thread" | "thread-root"; href: string; source: "reply" | "project-created-card"; conversationId: string; anchorCommentId: string;
|
|
commentId?: string; resourceId?: string; cardLabel?: string; createdByRunId?: string;
|
|
}
|
|
export interface ConversationLinkInput {
|
|
origin: string; companyId: string; companyPrefix?: string | null; sourceId: string; leadId: string;
|
|
comments: Row[]; runs: ChatRun[]; projects: Row[]; activity: Row[];
|
|
}
|
|
export function conversationLinkBindings(input: ConversationLinkInput) {
|
|
const comments = input.comments.filter(row => row.companyId === input.companyId && row.issueId === input.sourceId);
|
|
const replies = comments.filter(row => row.authorAgentId === input.leadId && input.runs.some(run =>
|
|
run.id === row.createdByRunId && run.companyId === input.companyId && run.agentId === input.leadId
|
|
&& ((run as ChatRun & { nativeIssueId?: string }).nativeIssueId ?? run.contextSnapshot?.issueId) === input.sourceId));
|
|
const projects = input.projects.flatMap(project => {
|
|
if (project.companyId !== input.companyId || !project.name) return [];
|
|
const creation = input.activity.find(row => row.companyId === input.companyId && row.action === "project.created"
|
|
&& row.entityType === "project" && row.entityId === project.id && row.actorType === "agent"
|
|
&& row.actorId === input.leadId && row.agentId === input.leadId
|
|
&& replies.some(reply => reply.createdByRunId === row.runId));
|
|
return creation?.runId ? [{ id: project.id, name: project.name, runId: creation.runId }] : [];
|
|
});
|
|
return { origin: input.origin, companyPrefix: input.companyPrefix, sourceId: input.sourceId,
|
|
anchors: comments.map(row => row.id), replies: replies.map(row => row.id), projects };
|
|
}
|
|
export function readConversationDomLinks(input: ReturnType<typeof conversationLinkBindings>): RenderedConversationLink[] {
|
|
const visible = (element: Element) => {
|
|
for (let node: Element | null = element; node; node = node.parentElement) {
|
|
if (node.hasAttribute("hidden") || node.hasAttribute("inert") || node.getAttribute("aria-hidden") === "true") return false;
|
|
const style = window.getComputedStyle(node);
|
|
if (style.display === "none" || ["hidden", "collapse"].includes(style.visibility) || style.opacity === "0") return false;
|
|
}
|
|
return element.getClientRects().length > 0;
|
|
};
|
|
const threadSelector = '[data-testid="task-chat-thread"], [data-testid="thread-root"]';
|
|
const roots = Array.from(document.querySelectorAll(threadSelector)).filter(root => visible(root)
|
|
&& input.anchors.some(id => Array.from(root.querySelectorAll("[id]")).some(node => node.id === `comment-${id}` && node.closest(threadSelector) === root)));
|
|
if (roots.length !== 1) return [];
|
|
const root = roots[0]!;
|
|
const threadTestId = root.getAttribute("data-testid") as RenderedConversationLink["threadTestId"];
|
|
const anchor = input.anchors.find(id => Array.from(root.querySelectorAll("[id]")).some(node => node.id === `comment-${id}`))!;
|
|
const rows: RenderedConversationLink[] = [];
|
|
const sameConversation = (node: Element) => node.closest(threadSelector) === root;
|
|
const companyResource = (href: string) => {
|
|
try {
|
|
const url = new URL(href, input.origin), parts = url.pathname.split("/").filter(Boolean).map(decodeURIComponent);
|
|
const resourceAt = parts.findIndex(part => ["projects", "issues", "goals"].includes(part));
|
|
if (url.origin !== new URL(input.origin).origin) return !(resourceAt === 1 && parts.length === 3);
|
|
return resourceAt < 0 || resourceAt === 1 && parts[0] === input.companyPrefix;
|
|
} catch { return false; }
|
|
};
|
|
for (const id of input.replies) {
|
|
const reply = Array.from(root.querySelectorAll("[id]")).find(node => node.id === `comment-${id}` && sameConversation(node));
|
|
for (const node of reply?.querySelectorAll("a[href]") ?? []) {
|
|
const href = node.getAttribute("href");
|
|
if (href && sameConversation(node) && visible(node) && companyResource(href)) rows.push({ threadTestId, href, source: "reply", conversationId: input.sourceId, anchorCommentId: id, commentId: id });
|
|
}
|
|
}
|
|
for (const project of threadTestId === "task-chat-thread" ? input.projects : []) {
|
|
const label = `Project created: ${project.name}`;
|
|
for (const card of root.querySelectorAll("article[aria-label]")) {
|
|
const item = card.closest('[data-thread-item-kind="project_created"]');
|
|
if (item?.getAttribute("data-thread-anchor") !== `project-created:${project.id}` || card.getAttribute("aria-label") !== label || card.closest('[id^="comment-"]') || !sameConversation(card) || !visible(card)) continue;
|
|
for (const node of card.querySelectorAll("a[href]")) {
|
|
const href = node.getAttribute("href");
|
|
if (!href || !visible(node) || !sameConversation(node)) continue;
|
|
try {
|
|
const url = new URL(href, input.origin), parts = url.pathname.split("/").filter(Boolean).map(decodeURIComponent);
|
|
if (url.origin !== new URL(input.origin).origin || parts.length !== 3 || parts[0] !== input.companyPrefix || parts[1] !== "projects" || parts[2] !== project.id) continue;
|
|
rows.push({ threadTestId, href, source: "project-created-card", conversationId: input.sourceId, anchorCommentId: anchor, resourceId: project.id, cardLabel: label, createdByRunId: project.runId });
|
|
} catch { continue; }
|
|
}
|
|
}
|
|
}
|
|
return rows;
|
|
}
|
|
export async function collectConversationLinks(page: Page, input: ConversationLinkInput) {
|
|
return page.evaluate(readConversationDomLinks, conversationLinkBindings(input));
|
|
}
|
|
export function conversationLinkLocator(page: Page, link: RenderedConversationLink): Locator {
|
|
const thread = page.getByTestId(link.threadTestId).filter({ has: page.locator(`[id=${JSON.stringify(`comment-${link.anchorCommentId}`)}]`) });
|
|
return link.source === "reply"
|
|
? thread.locator(`[id=${JSON.stringify(`comment-${link.commentId}`)}] a[href=${JSON.stringify(link.href)}]`)
|
|
: thread.getByRole("article", { name: link.cardLabel!, exact: true }).locator(`a[href=${JSON.stringify(link.href)}]`);
|
|
}
|