PaperClipAI/ui/src/components/ProjectProperties.concurrency.test.tsx

// @vitest-environment jsdom

import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
import type { Project } from "@paperclipai/shared";
import type { ReactNode } from "react";
import { flushSync } from "react-dom";
import { createRoot, type Root } from "react-dom/client";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { ProjectProperties } from "./ProjectProperties";
import { TooltipProvider } from "@/components/ui/tooltip";
import { queryKeys } from "../lib/queryKeys";

(globalThis as typeof globalThis & { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;

function act(callback: () => void) {
  flushSync(() => {
    callback();
  });
}

const noop = vi.hoisted(() => () => undefined);

vi.mock("../api/projects", () => ({ projectsApi: { createWorkspace: vi.fn(), removeWorkspace: vi.fn(), updateWorkspace: vi.fn() } }));
vi.mock("../api/goals", () => ({ goalsApi: { list: vi.fn().mockResolvedValue([]) } }));
vi.mock("../api/secrets", () => ({ secretsApi: { list: vi.fn().mockResolvedValue([]), listUserSecretDefinitions: vi.fn().mockResolvedValue([]), create: vi.fn() } }));
vi.mock("../api/environments", () => ({ environmentsApi: { list: vi.fn().mockResolvedValue([]) } }));
vi.mock("../api/instanceSettings", () => ({ instanceSettingsApi: { getExperimental: vi.fn().mockResolvedValue({ enableIsolatedWorkspaces: true }) } }));

vi.mock("../context/CompanyContext", () => ({
  useCompany: () => ({ companies: [{ id: "company-1", issuePrefix: "PAP" }], selectedCompanyId: "company-1", setSelectedCompanyId: vi.fn() }),
}));

// Heavy children that are unrelated to this control.
vi.mock("./environment-variables-editor", () => ({ EnvironmentVariablesEditor: () => null }));
vi.mock("./InlineEditor", () => ({ InlineEditor: ({ value }: { value?: ReactNode }) => <div>{value}</div> }));
vi.mock("./PathInstructionsModal", () => ({ ChoosePathButton: () => null }));

function makeProject(overrides: Partial<Project> = {}): Project {
  return {
    id: "project-1",
    urlKey: "project-1",
    name: "Test project",
    description: "",
    status: "in_progress",
    goalIds: [],
    goals: [],
    env: null,
    codebase: { workspaceId: null, repoUrl: null, repoRef: null, defaultRef: null, repoName: null },
    primaryWorkspace: null,
    workspaces: [],
    executionWorkspacePolicy: { enabled: true, defaultMode: "shared_workspace", allowIssueOverride: true },
    ...overrides,
  } as unknown as Project;
}

function primedClient(hiddenSettings: string[] = []) {
  const client = new QueryClient({ defaultOptions: { queries: { retry: false } } });
  client.setQueryData(queryKeys.health, { hiddenSettings });
  client.setQueryData(queryKeys.instance.experimentalSettings, { enableIsolatedWorkspaces: true });
  return client;
}

let container: HTMLDivElement;
let root: Root;

beforeEach(() => {
  container = document.createElement("div");
  document.body.appendChild(container);
  root = createRoot(container);
});

afterEach(() => {
  act(() => root.unmount());
  container.remove();
  vi.clearAllMocks();
});

function render(project: Project, onFieldUpdate: (field: string, data: Record<string, unknown>) => void, hiddenSettings: string[] = []) {
  act(() => {
    root.render(
      <QueryClientProvider client={primedClient(hiddenSettings)}>
        <TooltipProvider>
          <ProjectProperties project={project} onFieldUpdate={onFieldUpdate} getFieldSaveState={() => "idle"} onArchive={noop} />
        </TooltipProvider>
      </QueryClientProvider>,
    );
  });
}

function concurrencySelect(): HTMLSelectElement {
  const el = container.querySelector<HTMLSelectElement>('select[aria-label="Shared workspace concurrency"]');
  if (!el) throw new Error("Shared workspace concurrency select not found");
  return el;
}

describe("ProjectProperties — shared workspace concurrency select", () => {
  it("defaults to Auto when the policy has no sharedWorkspaceConcurrency", () => {
    render(makeProject(), vi.fn());
    expect(concurrencySelect().value).toBe("auto");
    expect(container.textContent).toContain("Concurrent runs on local/SSH runners");
  });

  it("reflects an existing serialize value and shows its helper text", () => {
    render(
      makeProject({
        executionWorkspacePolicy: { enabled: true, defaultMode: "shared_workspace", sharedWorkspaceConcurrency: "serialize" },
      } as Partial<Project>),
      vi.fn(),
    );
    expect(concurrencySelect().value).toBe("serialize");
    expect(container.textContent).toContain("Sandbox runs take turns in the shared project workspace");
    expect(container.textContent).toContain("Local/SSH folders allow concurrent runs");
  });

  it("writes the picked value onto executionWorkspacePolicy when changed", () => {
    const onFieldUpdate = vi.fn();
    render(makeProject(), onFieldUpdate);
    const select = concurrencySelect();
    act(() => {
      const setter = Object.getOwnPropertyDescriptor(window.HTMLSelectElement.prototype, "value")!.set!;
      setter.call(select, "allow");
      select.dispatchEvent(new Event("change", { bubbles: true }));
    });
    expect(onFieldUpdate).toHaveBeenCalledWith(
      "execution_workspace_shared_concurrency",
      expect.objectContaining({
        executionWorkspacePolicy: expect.objectContaining({ sharedWorkspaceConcurrency: "allow" }),
      }),
    );
  });
});

it("hides project isolation controls without rewriting its policy", () => {
  const onFieldUpdate = vi.fn();
  render(makeProject(), onFieldUpdate, ["workspaces.isolation"]);
  expect(container.textContent).not.toContain("Execution Workspaces");
  expect(container.textContent).not.toContain("Enable isolated task checkouts");
  expect(container.querySelector('select[aria-label="Shared workspace concurrency"]')).toBeNull();
  expect(onFieldUpdate).not.toHaveBeenCalled();
});


describe("ProjectProperties — workspace storage selection", () => {
  const inherited = {
    source: "default" as const, pluginId: "provider-one", displayName: "Managed storage", error: null,
    effectivePolicy: { enabled: true, defaultMode: "isolated_workspace" as const, storageProviderPluginId: "provider-one", workspaceStrategy: { type: "git_worktree" as const } },
    providers: [{ id: "provider-one", displayName: "Managed storage", isDefault: true }, { id: "provider-two", displayName: "Alternative", isDefault: false }],
  };
  function storageSelect() { return container.querySelector<HTMLSelectElement>('select[aria-label="Workspace storage provider"]')!; }
  it("displays the inherited default without saving it as an override", () => {
    render(makeProject({ executionWorkspacePolicy: null, workspaceProvider: inherited }), vi.fn());
    expect(storageSelect().value).toBe("inherit");
    expect(container.textContent).toContain("Inherited default: Managed storage");
  });
  it.each(["core", "provider-two", "inherit"])("saves the deliberate %s choice while preserving explicit settings", value => {
    const onFieldUpdate = vi.fn();
    render(makeProject({ executionWorkspacePolicy: { enabled: true, storageProviderPluginId: "provider-one", sharedWorkspaceConcurrency: "serialize" }, workspaceProvider: inherited }), onFieldUpdate);
    act(() => { storageSelect().value = value; storageSelect().dispatchEvent(new Event("change", { bubbles: true })); });
    const policy = { enabled: true, sharedWorkspaceConcurrency: "serialize", ...(value === "inherit" ? {} : { storageProviderPluginId: value === "core" ? null : value }) };
    expect(onFieldUpdate).toHaveBeenCalledWith("workspace_storage_provider", { executionWorkspacePolicy: policy });
  });
  it("does not copy inherited mode, strategy, or provider when another setting changes", () => {
    const onFieldUpdate = vi.fn();
    render(makeProject({ executionWorkspacePolicy: null, workspaceProvider: inherited }), onFieldUpdate);
    act(() => { concurrencySelect().value = "allow"; concurrencySelect().dispatchEvent(new Event("change", { bubbles: true })); });
    expect(onFieldUpdate).toHaveBeenCalledWith("execution_workspace_shared_concurrency", { executionWorkspacePolicy: { enabled: true, sharedWorkspaceConcurrency: "allow" } });
  });
  it("shows default conflicts and keeps the provider control usable", () => {
    render(makeProject({ workspaceProvider: { ...inherited, error: "Select a storage provider in project configuration" } }), vi.fn());
    expect(container.querySelector('[role="alert"]')?.textContent).toContain("Select a storage provider");
    expect(storageSelect().disabled).toBe(false);
  });
});