Files
PaperClipAI/tests/runner-e2e/server-config.test.ts
T
f4337bb5fb test(evals): land the chat catalog eval harness on master (#19614)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The chat-feature evals measure whether agents complete real chat
requests through the product
> - The chat catalog eval harness and its repairs live on the
`chat-eval/master-candidate` branch, not on master
> - Today's work made 139 of 242 chat evals pass in verified single-case
live runs. Each product fix landed on master as its own pull request
> - The eval-side changes (setups, graders, fault seams, evidence
capture) still exist only on the candidate
> - This pull request lands the harness on master. Master stays the
source of truth for product behavior
> - The benefit is one tree: evals run against master commits, and
product fixes reach the evals as soon as they merge

## Linked Issues or Issue Description

Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs
#20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409

**What existing behavior does this improve?**
The chat catalog eval harness and the product it evaluates live on a
long-running branch outside master. Eval fixes do not reach master, so
master-based eval runs use old setups and graders.

**Subsystem affected**
`tests/runner-e2e` chat catalog harness, plus a small set of product
changes that exist only on the candidate.

**Proposed change**
Land the harness on master. Every product fix from this eval work
already merged to master as its own pull request. Conflicts keep
master's product behavior.

## What Changed

- Most of the diff (808 of 851 files) is under `tests/runner-e2e/`:
chat-catalog domains, scenarios, descriptors, the TestOps manifest,
private evidence tooling, and their tests.
- Graders now check saved state, setup literals and rendered or clicked
links. Many keyword and regex checks on free-form replies are removed.
Each changed grader has a bumped `oracleVersion` and calibration tests
(a valid reply, a reworded valid reply, and broken variants that must
fail).
- The shared link helper `hasLink` no longer treats a list link (for
example `/COM/issues?view=mine`) as a link to every task without a URL
key.
- Setup fixes build real state through supported product routes: routine
history, agent grants through the board grant route, budget holds with a
real cap, and a storage-layer archive fault for
`inbox-search.archive-partial-failure`.
- Browser boundary journeys (sign-in, chat-disabled, onboarding) now
write the standard pass evidence files.
- Retargeted cases, approved by the maintainer:
`agent-chat.chat-disabled` (Conference Room gate),
`agents.restore-instructions` (no saved instruction history),
`access.manage-membership` (member permission edits stay board-only).
- The private evidence trusted files (`manual-private-handoff.ts`,
`manual-private-retention.ts`, `manual-private-report-assets.ts`) are
byte-identical to master.
- Product files outside `tests/` (43 files, +1,328 −49) carry
candidate-only changes that master does not yet have. Most are tests.
The main code changes are in `request-human-input.ts`,
`heartbeat-run-summary.ts`, `native-completion-feedback.ts`,
`native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and
`IssueChatLongThreadPerf.tsx`.

## Verification

- `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts
chat-catalog-consistency.test.ts unit-launcher.test.mjs
--testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests
pass.
- `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass.
- `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`:
no change.
- `tsc` for `server` and `tests/runner-e2e`: clean.
- Live single-case verification: 139 of 242 cases passed on paid runs,
and a person read the saved evidence for each. These are single-case
runs, not one full-cohort run.

## Risks

- Large diff. Most of it is test-only, but the 43 non-test files change
product code paths. Review those files first.
- Some graders are now less strict on reply wording. A person must read
replies for meaning on those cases.
- 42 cases need disposable outside accounts (Notion, Slack, GitHub,
Daytona and others) and stay blocked. `access.invite-teammate` stays
failing until local agent isolation lands, because the runner's durable
state keeps a live invite token.
- The paid workflow compares the trusted private-evidence files with
master. They are unchanged, so this risk is low.

## Model Used

Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code
execution, in Claude Code. Subagents used the same model.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-10 08:02:11 -06:00

126 lines
5.4 KiB
TypeScript

import { mkdir, mkdtemp, realpath, readFile, rm, symlink, writeFile } from "node:fs/promises";
import { createServer } from "node:net";
import os from "node:os";
import path from "node:path";
import { afterEach, describe, expect, it } from "vitest";
import { paperclipConfigSchema } from "../../packages/shared/src/config-schema.js";
import {
reserveRunnerE2EDatabasePort,
type LoopbackPortReservation,
} from "./ports.js";
import { createRunnerE2ETemporaryRoot, prepareRunnerE2EServerConfig, prepareSupervisorServerConfig } from "./server-config.js";
import { recordControllerDatabaseOwnership } from "./instance-isolation.js";
const roots: string[] = [];
const reservations: LoopbackPortReservation[] = [];
afterEach(async () => {
await Promise.all(
reservations.splice(0).map((reservation) => reservation.close()),
);
await Promise.all(
roots.splice(0).map((root) => rm(root, { recursive: true, force: true })),
);
});
describe("isolated paid E2E database ports", () => {
it("uses a physical temporary root when the host temp directory has an alias", async () => {
const parent = await realpath(await mkdtemp(path.join(os.tmpdir(), "e2e-temp-alias-")));
roots.push(parent);
const physical = path.join(parent, "physical");
const alias = path.join(parent, "alias");
await mkdir(physical);
await symlink(physical, alias);
const root = await createRunnerE2ETemporaryRoot(alias);
expect(root).toBe(await realpath(root));
expect(path.dirname(root)).toBe(physical);
});
it("keeps parallel database reservations distinct and held until server spawn", async () => {
reservations.push(
...(await Promise.all(
Array.from({ length: 8 }, () => reserveRunnerE2EDatabasePort(3100)),
)),
);
expect(new Set(reservations.map(({ port }) => port)).size).toBe(8);
const contender = createServer();
const error = await new Promise<NodeJS.ErrnoException>((resolve) => {
contender.once("error", resolve);
contender.listen(reservations[0].port, "127.0.0.1");
});
expect(error.code).toBe("EADDRINUSE");
});
it("rejects the HTTP/HMR ports and retains only the selected reservation", async () => {
const closed: number[] = [];
const ports = [3100, 13100, 41000];
const selected = await reserveRunnerE2EDatabasePort(3100, {
openPort: async () => {
const port = ports.shift()!;
return {
port,
close: async () => {
closed.push(port);
},
};
},
});
expect(selected.port).toBe(41000);
expect(closed).toEqual([3100, 13100]);
await selected.close();
expect(closed).toEqual([3100, 13100, 41000]);
});
it("writes a valid private config and preserves its database on restart", async () => {
const temporaryRoot = await mkdtemp(
path.join(os.tmpdir(), "runner-e2e-config-test-"),
);
roots.push(temporaryRoot);
const configPath = path.join(
temporaryRoot,
"paperclip-home",
"instances",
"fixture",
"config.json",
);
const input = { temporaryRoot, configPath, serverPort: 3100 };
const reservation = await prepareRunnerE2EServerConfig(input);
expect(reservation).not.toBeNull();
reservations.push(reservation!);
const encoded = await readFile(configPath, "utf8");
const config = paperclipConfigSchema.parse(JSON.parse(encoded));
expect(config.database.embeddedPostgresPort).toBe(reservation!.port);
expect(config.database.mode).toBe("embedded-postgres");
for (const directory of [
config.database.embeddedPostgresDataDir,
config.database.backup.dir,
config.logging.logDir,
config.storage.localDisk.baseDir,
config.secrets.localEncrypted.keyFilePath,
])
expect(directory.startsWith(`${temporaryRoot}/`)).toBe(true);
expect(config.secrets.strictMode).toBe(true);
expect(await prepareRunnerE2EServerConfig(input)).toBeNull();
expect(await readFile(configPath, "utf8")).toBe(encoded);
});
it("keeps a launcher-owned external database and rejects an unowned one", async () => {
const temporaryRoot = await createRunnerE2ETemporaryRoot();
roots.push(temporaryRoot);
const configPath = path.join(temporaryRoot, "paperclip-home", "instances", "fixture", "config.json");
const input = { temporaryRoot, configPath, serverPort: 3100 };
reservations.push((await prepareRunnerE2EServerConfig(input))!);
const config = JSON.parse(await readFile(configPath, "utf8"));
const name = `runner_e2e_${"a".repeat(32)}`, connectionString = `postgres://fixture@127.0.0.1:5432/${name}`;
config.database = { ...config.database, mode: "postgres", connectionString };
await writeFile(configPath, JSON.stringify(config));
await mkdir(config.database.embeddedPostgresDataDir, { recursive: true });
await expect(prepareSupervisorServerConfig({ ...input, database: {} })).rejects.toThrow("explicit owned lane");
await recordControllerDatabaseOwnership({ configPath, temporaryRoot, dataDirectory: config.database.embeddedPostgresDataDir,
connectionString, externalDatabaseName: name });
await expect(prepareSupervisorServerConfig({ ...input, database: {} })).resolves.toBeNull();
config.database.connectionString = "postgres://fixture@127.0.0.1:5432/postgres";
await writeFile(configPath, JSON.stringify(config));
await expect(prepareSupervisorServerConfig({ ...input, database: {} })).rejects.toThrow("explicit owned lane");
});
});