mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-11 23:36:51 +02:00
## Thinking Path > - Paperclip manages agents that use different model providers and adapters. > - Paperclip must keep agent execution rules clear and predictable. > - The cheap-model profile added a second execution mode across adapters, task recovery, APIs, and the UI. > - That mode increased configuration and recovery complexity. > - This pull request removes the cheap-model profile as a product feature. > - The benefit is one model-selection path for normal work and recovery work. ## Linked Issues or Issue Description **What existing behavior does this improve?** This change simplifies model selection across agent configuration, task execution, recovery, and adapter capabilities. **Current behavior** Paperclip exposes cheap-model profiles in adapter metadata, agent runtime configuration, task overrides, recovery rules, APIs, and the board UI. Recovery work can select a different model profile from the agent's configured model. **Proposed behavior** Paperclip uses the agent's configured model for normal work and recovery work. Status-only recovery stays limited to coordination work. The API rejects legacy model-profile configuration. A migration removes stored model-profile values from existing agent, issue, and historical revision records. **Reason and benefit** One model path reduces configuration, API, UI, and recovery complexity. It also prevents status recovery from becoming a separate product-level model-routing feature. **Breaking changes** This change removes model-profile fields and adapter capability metadata. Existing stored model-profile values are removed by an idempotent migration. The validators reject new legacy profile values with clear errors. ## What Changed - Removed model-profile types, adapter capabilities, API fields, and model selection logic. - Removed cheap-model controls from agent and task UI surfaces. - Kept status-only recovery limited to coordination context while normal continuations use the configured agent model. - Added an idempotent migration that removes stored model-profile values from agents, issues, and configuration revisions without changing issue update timestamps. - Updated tests and product documentation for the single-model behavior. ## Verification - `pnpm check:token-gates` passes. - `pnpm -r typecheck` passes. - `pnpm build` passes. - `pnpm test:run` completed with 5,607 passing tests and 8 environment-sensitive failures in unrelated fixed-port and database-deadlock suites. The same failures repeated in an isolated rerun. CI is the final clean-room result. ## Risks - This is an intentional breaking change for clients that send model-profile fields. - The migration changes legacy agent, issue, and configuration-revision JSON. It is idempotent and preserves unrelated fields and issue update timestamps. - The change is cross-cutting because the removed feature existed in adapters, shared contracts, the server, plugins, and the UI. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex with `gpt-5`. Reasoning and tool use were enabled. The runtime did not expose the context-window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [ ] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
91 lines
3.2 KiB
TypeScript
91 lines
3.2 KiB
TypeScript
/**
|
|
* @fileoverview Frontend API client for external adapter management.
|
|
*/
|
|
|
|
import { api } from "./client";
|
|
|
|
/**
|
|
* The safe scalar login fields the server projects for an adapter that declares
|
|
* an interactive login capability. The projection carries no function member and
|
|
* no secret. The form reads it to pick the login flow and the login panel.
|
|
*/
|
|
export interface AdapterLoginProjection {
|
|
panelMode: "displayed_code" | "submitted_browser_code";
|
|
timeoutPolicy: "caller_bounded" | "fixed";
|
|
}
|
|
|
|
export interface AdapterCapabilities {
|
|
supportsInstructionsBundle: boolean;
|
|
supportsSkills: boolean;
|
|
supportsLocalAgentJwt: boolean;
|
|
requiresMaterializedRuntimeSkills: boolean;
|
|
supportsAcp: boolean;
|
|
/** Present only when the adapter declares an interactive login capability. */
|
|
login?: AdapterLoginProjection;
|
|
}
|
|
|
|
export interface AcpTargetDescriptor {
|
|
agentId: string;
|
|
skillsMode: "ephemeral" | "unsupported";
|
|
prerequisites: {
|
|
nodeRange?: string;
|
|
packages?: string[];
|
|
};
|
|
}
|
|
|
|
export interface AdapterInfo {
|
|
type: string;
|
|
label: string;
|
|
source: "builtin" | "external";
|
|
modelsCount: number;
|
|
loaded: boolean;
|
|
disabled: boolean;
|
|
capabilities: AdapterCapabilities;
|
|
acp?: AcpTargetDescriptor;
|
|
/** Installed version (for external npm adapters) */
|
|
version?: string;
|
|
/** Package name (for external adapters) */
|
|
packageName?: string;
|
|
/** Whether the adapter was installed from a local path (vs npm). */
|
|
isLocalPath?: boolean;
|
|
/** True when an external plugin has replaced a built-in adapter of the same type. */
|
|
overriddenBuiltin?: boolean;
|
|
/** True when the external override for a builtin type is currently paused. */
|
|
overridePaused?: boolean;
|
|
}
|
|
|
|
export interface AdapterInstallResult {
|
|
type: string;
|
|
packageName: string;
|
|
version?: string;
|
|
installedAt: string;
|
|
}
|
|
|
|
export const adaptersApi = {
|
|
/** List all registered adapters (built-in + external). */
|
|
list: () => api.get<AdapterInfo[]>("/adapters"),
|
|
|
|
/** Install an external adapter from npm or a local path. */
|
|
install: (params: { packageName: string; version?: string; isLocalPath?: boolean }) =>
|
|
api.post<AdapterInstallResult>("/adapters/install", params),
|
|
|
|
/** Remove an external adapter by type. */
|
|
remove: (type: string) => api.delete<{ type: string; removed: boolean }>(`/adapters/${type}`),
|
|
|
|
/** Enable or disable an adapter (disabled adapters hidden from agent menus). */
|
|
setDisabled: (type: string, disabled: boolean) =>
|
|
api.patch<{ type: string; disabled: boolean; changed: boolean }>(`/adapters/${type}`, { disabled }),
|
|
|
|
/** Pause or resume an external override of a builtin type. */
|
|
setOverridePaused: (type: string, paused: boolean) =>
|
|
api.patch<{ type: string; paused: boolean; changed: boolean }>(`/adapters/${type}/override`, { paused }),
|
|
|
|
/** Reload an external adapter (bust server + client caches). */
|
|
reload: (type: string) =>
|
|
api.post<{ type: string; version?: string; reloaded: boolean }>(`/adapters/${type}/reload`, {}),
|
|
|
|
/** Reinstall an npm-sourced adapter (pulls latest from registry, then reloads). */
|
|
reinstall: (type: string) =>
|
|
api.post<{ type: string; version?: string; reinstalled: boolean }>(`/adapters/${type}/reinstall`, {}),
|
|
};
|