mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-24 01:41:42 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Governed MCP access spans contracts, runtime enforcement, adapters, UI surfaces, and operator verification > - The parity reference PR #9534 is too large for effective automated or human review > - The feature therefore needs a linear stack whose individual diffs stay below the 100-file review limit > - This pull request is split 4/8 and focuses on gateway runtime, Smoke Lab, plugins, and server wiring > - The benefit is a standalone, testable review boundary while preserving byte-for-byte parity at the top of the stack ## Linked Issues or Issue Description - Related parity reference: #9534 - Problem: The policy core needs runtime execution, endpoint guards, route registration, heartbeat integration, and adapter MCP injection to become operational. - Proposed solution: Adds the remaining server routes/wiring/consumers, runtime tests, adapter-utils MCP contracts, and Claude/Codex injection implementations required by the server layer. - Alternatives considered: keeping #9534 as one 403-file review, or rewriting the feature to manufacture seams; both were rejected in favor of path extraction plus compile-driven boundary moves. - Roadmap alignment: this advances the existing governed MCP/tool-access work already represented by #9534; it does not introduce a separate roadmap initiative. - Stack position: base branch is `pap10341-split/03-server-tool-access`. - Merge policy: merge bottom-up, in order, only after the complete eight-PR stack has been reviewed and the top-of-stack parity gate remains empty. - Requested review: SecurityEngineer for gateway, endpoint guard, token issuance, and runtime wiring; Greptile on every PR. ## What Changed - Adds the remaining server routes/wiring/consumers, runtime tests, adapter-utils MCP contracts, and Claude/Codex injection implementations required by the server layer. - Keeps this PR below 100 changed files and independently typecheckable. - Preserves the final tree from #9534 when combined with the other seven stack levels. ## Verification - `pnpm typecheck` - Changed server test set — 26 files, 382 tests passed - Affected server adapter tests — 38 tests passed after concrete adapter boundary move - Adapter-utils and Codex focused tests — 76 tests passed ## Risks - Remote endpoint validation, token handling, and runtime supervision are security-sensitive and can fail closed or deny legitimate access if misconfigured. - Stack risk: merging out of order can expose incomplete layers; mitigate by following the documented bottom-up merge policy. - Parity risk: later edits to an intermediate branch can drift from #9534; mitigate by re-running the empty top-of-stack diff before merge. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, exact model ID `gpt-5.4`; runtime-managed context window; medium reasoning with repository, shell, Git, GitHub CLI, and code-execution tools enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] Internal references are omitted except the execution-plan link explicitly required for this coordinated split stack - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge ## Stack Coordination - Internal execution plan: [PAP-13874](/PAP/issues/PAP-13874#document-plan) - Parity reference: #9534 - Stack: #9556 → #9557 → #9558 → #9559 → #9560 → #9561 → #9562 → #9563 - Merge bottom-up only after full-stack review and an empty parity diff at #9563. --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
112 lines
2.5 KiB
JavaScript
112 lines
2.5 KiB
JavaScript
const readline = require("node:readline");
|
|
|
|
let nextRequestId = 1;
|
|
const pendingNested = new Map();
|
|
|
|
function send(message) {
|
|
process.stdout.write(`${JSON.stringify(message)}\n`);
|
|
}
|
|
|
|
function sendNestedHostRequest(originalRequest, invocationId) {
|
|
const nestedId = `nested-${nextRequestId++}`;
|
|
const params = originalRequest.params?.params ?? {};
|
|
const mode = params.mode;
|
|
const requestedCompanyId = params.requestedCompanyId;
|
|
const hostMethod = params.hostMethod || "companies.get";
|
|
const nestedParams = hostMethod === "secrets.resolve"
|
|
? {
|
|
companyId: requestedCompanyId,
|
|
secretRef: {
|
|
type: "secret_ref",
|
|
secretId: params.secretId || "11111111-1111-4111-8111-111111111111",
|
|
},
|
|
configPath: params.configPath || "apiKeyRef",
|
|
}
|
|
: {
|
|
companyId: requestedCompanyId,
|
|
};
|
|
const nestedRequest = {
|
|
jsonrpc: "2.0",
|
|
id: nestedId,
|
|
method: hostMethod,
|
|
params: nestedParams,
|
|
};
|
|
|
|
if (mode === "echo") {
|
|
nestedRequest.paperclipInvocationId = invocationId;
|
|
} else if (mode === "unknown") {
|
|
nestedRequest.paperclipInvocationId = "unknown-invocation";
|
|
}
|
|
|
|
pendingNested.set(nestedId, originalRequest.id);
|
|
send(nestedRequest);
|
|
}
|
|
|
|
const rl = readline.createInterface({
|
|
input: process.stdin,
|
|
crlfDelay: Infinity,
|
|
});
|
|
|
|
rl.on("line", (line) => {
|
|
if (!line.trim()) return;
|
|
const message = JSON.parse(line);
|
|
|
|
if (message.id && pendingNested.has(message.id)) {
|
|
const originalId = pendingNested.get(message.id);
|
|
pendingNested.delete(message.id);
|
|
if (message.error) {
|
|
send({
|
|
jsonrpc: "2.0",
|
|
id: originalId,
|
|
error: message.error,
|
|
});
|
|
return;
|
|
}
|
|
|
|
send({
|
|
jsonrpc: "2.0",
|
|
id: originalId,
|
|
result: message.result,
|
|
});
|
|
return;
|
|
}
|
|
|
|
const method = message && typeof message.method === "string" ? message.method : null;
|
|
|
|
if (method === "initialize") {
|
|
send({
|
|
jsonrpc: "2.0",
|
|
id: message.id,
|
|
result: {
|
|
ok: true,
|
|
supportedMethods: ["getData", "performAction"],
|
|
},
|
|
});
|
|
return;
|
|
}
|
|
|
|
if (method === "getData" || method === "performAction") {
|
|
sendNestedHostRequest(message, message.paperclipInvocation?.id);
|
|
return;
|
|
}
|
|
|
|
if (method === "shutdown") {
|
|
send({
|
|
jsonrpc: "2.0",
|
|
id: message.id,
|
|
result: {},
|
|
});
|
|
setImmediate(() => process.exit(0));
|
|
return;
|
|
}
|
|
|
|
send({
|
|
jsonrpc: "2.0",
|
|
id: message.id,
|
|
error: {
|
|
code: -32601,
|
|
message: `Unhandled method: ${method}`,
|
|
},
|
|
});
|
|
});
|