mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-06 20:34:57 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The native runner must support project work, delegation, hiring, and service access. > - Browser tests exposed lost connection access, rejected helper events, and stalled recovery. > - Some eval failures also came from incorrect fixtures and decision controls. > - This pull request fixes those paths and adds eight everyday workflow stories. > - The tests retain observed failures and verify delivered files independently. > - The benefit is repeatable evidence for common user tasks and their remaining gaps. ## Linked Issues or Issue Description Related work: #13404 contains earlier workflow fixes. #13300 and #13470 changed the CI contracts used by the harness security tests. Merged companion: [paperclip-evals#22](https://github.com/paperclipai/paperclip-evals/pull/22). **What happened?** Native ACPX sessions did not receive the assigned connection gateway. Codex helper events could arrive before their spawn receipt and fail thread validation. A parent continuation could take a shared workspace before its child retried. A failed native continuation could leave the task status without a clear recovery blocker. The eval harness also confused tool approvals with new connection requests and could reject a valid delegated download. **Expected behavior** Keep assigned gateway access and its approval checks. Verify helper lineage before accepting helper progress. Let a waiting child proceed before automatic parent recovery. Preserve a failed task's recovery ownership. Grade the actual requested workflow and its delivered files. **Steps to reproduce** Run the everyday workflow suite with the native Codex and Claude profiles. Exercise service approval, connection refusal, delegated project work, and teammate reuse. The commands and case requirements are in `tests/runner-e2e/EVERYDAY-WORKFLOWS.md`. Use `pnpm test:runner-recovery` for controlled crash and replacement cases. ## What Changed - Pass the scoped connection gateway binding through the native ACPX host and sidecar. - Recognize Codex helper lineage from parent metadata and spawn receipts. Verify early helper events with `thread/read`. Keep helper events separate from root completion authority. - Guide agents to use persistent hiring, child tasks, dependency records, and a blocked handoff while waiting for a child. - Defer automatic parent recovery while a child has an active execution path in the same shared workspace. Allow parent recovery when the child needs review. - Record Blocked status and recovery evidence when a failed native continuation needs reconciliation, including existing active or escalated incidents. Preserve their owner and retry budget. - Add eight browser-driven workflow cases. Use real decision controls, explicit child feedback delivery, managed hiring credentials, and independent ZIP checks inside a bounded Docker sandbox. Verify sandbox availability before task creation. Record screenshot SHA-256 at capture. - Keep runner crash probes in controlled recovery tests. Preserve the original failure when cleanup also fails. - Display missing accounting and replay revisions as unavailable. Align harness security assertions with the approved CI changes. - Make the channel-rejection browser fixture bind its file after the send captures its payload. This prevents live refresh from removing the file before the simulated race. ## Verification - Full workspace `pnpm -r typecheck` passed after merging current master. - Runner E2E typecheck passed. Harness unit tests passed: 216/216. - Wake-queue database tests passed: 55/55. The two added existing-incident tests failed before the fix and pass after it. - Docker artifact calibration passed: 12/12. Host-file and host-loopback isolation tests failed before the fix and pass after it. Read-only delivery and output limits are also verified. - Full `pnpm build` passed. Targeted recovery tests passed: 83/83. - The channel-rejection browser test passed five consecutive runs after fixing the fixture race found in CI. - Local general-server (12,351 tests), UI (6,250), CLI (485), and workspace package groups passed. The monolithic run stopped at an unchanged lock-heartbeat fixture race; the isolated workspace group passed on rerun (shared: 747/747). A separate local serialized run passed 97 files before two socket errors in the unchanged issue-list route suite; that suite passed 15/15 on isolated rerun. These local full commands did not finish uninterrupted; the complete CI matrix below covers the remaining suites. - Final head `0fb293733fe307be7e6667ae8f1364077d0c6455`: **34 successful checks, 2 expected skips**, including every server/workspace shard, browser shard, native runner verification, build, and typecheck. [Final CI run](https://github.com/paperclipai/paperclip/actions/runs/34989136700). - Greptile reviewed this exact head at **5/5**; all review threads are resolved. Both Superagent security checks are successful. - ACPX credential-boundary tests passed: 118/118. Superagent accepted the runner/sidecar versus provider-environment trace and cleared its finding. - The latest paid local campaign on source `f6a2fdf7ac2af859826a2ae627ff4125a5478529` passed 22/24 cases: Sol 8/8, Claude 7/8, Mini 7/8. These results predate the merge with current master. - The two remaining failures are in `hire-reuse`: Claude exceeded the attempt deadline during final review; Mini made invalid deliverable tool calls and remained Blocked. - Six Daytona cases were not run because the matching immutable runner image was unavailable. This PR does not claim new remote model results. ## Risks The changes affect connection admission, helper identity, and recovery scheduling. Assigned gateway grants and user approval still govern service calls. The workspace admission gate still exists; the broader folder-sync design is separate work. Provider behavior can still cause the two recorded hiring failures. No database migration is required. Paid cases are opt-in and have bounded attempt deadlines. Project stories now require Docker and the documented pinned Python image on the harness host. ## Model Used OpenAI `gpt-6-astra` performed implementation, diagnosis, and substantive review. OpenAI `gpt-5.6-luna` assisted with verification, PR preparation, and review tracking. Both used repository tools and code execution. Context-window sizes were not recorded. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass (focused checks and isolated reruns; full-run limitations are documented above) - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: OpenAI GPT-5.6 Luna <noreply@openai.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
219 lines
7.3 KiB
TypeScript
219 lines
7.3 KiB
TypeScript
import { createReadStream } from "node:fs";
|
|
import { readdir } from "node:fs/promises";
|
|
import path from "node:path";
|
|
import { redactDiagnosticText } from "../../packages/adapter-utils/src/command-redaction.js";
|
|
|
|
const SECRET_SHAPES = [
|
|
/\bsk-ant-[A-Za-z0-9_-]{16,}\b/g,
|
|
/\bsk-(?:proj-)?[A-Za-z0-9_-]{16,}\b/g,
|
|
/\b(?:openrouter|daytona)[-_]?(?:api)?[-_]?key["'=:\s]+[A-Za-z0-9._-]{12,}\b/gi,
|
|
] as const;
|
|
|
|
const SENSITIVE_JSON_KEY =
|
|
/^(?:api[-_]?key|access[-_]?token|refresh[-_]?token|auth(?:orization)?|bearer|client[-_]?secret|cookie|password|secret|token)$/i;
|
|
|
|
export function normalizedSecrets(values: readonly (string | undefined)[]) {
|
|
return [
|
|
...new Set(
|
|
values
|
|
.map((value) => value?.trim())
|
|
.filter((value): value is string => Boolean(value)),
|
|
),
|
|
].sort((left, right) => right.length - left.length);
|
|
}
|
|
|
|
export function isEphemeralCodexRuntimeAuthFile(
|
|
paperclipHome: string,
|
|
file: string,
|
|
) {
|
|
const relative = path.relative(paperclipHome, file).split(path.sep).join("/");
|
|
return (
|
|
/^instances\/[^/]+\/companies\/[^/]+\/agents\/[^/]+\/codex-home\/auth\.json$/.test(
|
|
relative,
|
|
) ||
|
|
/^instances\/[^/]+\/runtime\/paperclip-runner\/durable-sessions\/[^/]+\/codex-home\/auth\.json$/.test(
|
|
relative,
|
|
) ||
|
|
/^instances\/[^/]+\/runtime\/paperclip-runner\/acpx\/acpx\/[^/]+\/codex-home\/auth\.json$/.test(
|
|
relative,
|
|
)
|
|
);
|
|
}
|
|
|
|
export function redactText(value: string, secrets: readonly string[]) {
|
|
let redacted = redactDiagnosticText(value, "[REDACTED]");
|
|
return redactKnownSecretsAndShapes(redacted, secrets);
|
|
}
|
|
|
|
function redactKnownSecretsAndShapes(
|
|
value: string,
|
|
secrets: readonly string[],
|
|
) {
|
|
let redacted = value;
|
|
for (const secret of normalizedSecrets(secrets))
|
|
redacted = redacted.split(secret).join("[REDACTED]");
|
|
for (const pattern of SECRET_SHAPES)
|
|
redacted = redacted.replace(pattern, "[REDACTED_SECRET_SHAPE]");
|
|
return redacted;
|
|
}
|
|
|
|
function redactStructuredText(value: string, secrets: readonly string[]) {
|
|
const knownSafe = redactKnownSecretsAndShapes(value, secrets);
|
|
if (
|
|
!/(?:Authorization\s*:\s*Bearer|(?:api[-_]?key|token|secret|password)\s*=)/i.test(
|
|
knownSafe,
|
|
)
|
|
) {
|
|
return knownSafe;
|
|
}
|
|
return redactKnownSecretsAndShapes(
|
|
redactDiagnosticText(knownSafe, "[REDACTED]"),
|
|
secrets,
|
|
);
|
|
}
|
|
|
|
export function findSecretLeak(
|
|
value: string | Buffer,
|
|
secrets: readonly string[],
|
|
options: { includeShapes?: boolean } = {},
|
|
): string | null {
|
|
const text = Buffer.isBuffer(value) ? value.toString("utf8") : value;
|
|
for (const secret of normalizedSecrets(secrets)) {
|
|
if (text.includes(secret)) return "exact secret value";
|
|
}
|
|
if (options.includeShapes !== false) {
|
|
for (const pattern of SECRET_SHAPES) {
|
|
pattern.lastIndex = 0;
|
|
if (pattern.test(text)) return "secret-shaped value";
|
|
}
|
|
}
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Scan structured JSON one key/value string at a time. Scanning the serialized
|
|
* document for provider key shapes can join an object key, punctuation, and an
|
|
* unrelated value into a false positive that never existed in the payload.
|
|
*/
|
|
export function findSecretLeakInJsonValues(
|
|
value: unknown,
|
|
secrets: readonly string[],
|
|
options: { includeShapes?: boolean } = {},
|
|
): string | null {
|
|
if (typeof value === "string") return findSecretLeak(value, secrets, options);
|
|
if (Array.isArray(value)) {
|
|
for (const entry of value) {
|
|
const leak = findSecretLeakInJsonValues(entry, secrets, options);
|
|
if (leak) return leak;
|
|
}
|
|
return null;
|
|
}
|
|
if (value && typeof value === "object") {
|
|
for (const [key, entry] of Object.entries(value)) {
|
|
const keyLeak = findSecretLeak(key, secrets, options);
|
|
if (keyLeak) return keyLeak;
|
|
const valueLeak = findSecretLeakInJsonValues(entry, secrets, options);
|
|
if (valueLeak) return valueLeak;
|
|
}
|
|
}
|
|
return null;
|
|
}
|
|
|
|
export function sanitizeJson(
|
|
value: unknown,
|
|
secrets: readonly string[],
|
|
): unknown {
|
|
// Structured values are not shell diagnostics. Applying the command/JWT
|
|
// heuristic here would redact stable dotted identifiers such as our schema
|
|
// name. Exact loaded secrets and well-known provider key shapes are enough.
|
|
if (typeof value === "string") return redactStructuredText(value, secrets);
|
|
if (Array.isArray(value))
|
|
return value.map((entry) => sanitizeJson(entry, secrets));
|
|
if (value && typeof value === "object") {
|
|
return Object.fromEntries(
|
|
Object.entries(value).map(([key, entry]) => [
|
|
key,
|
|
SENSITIVE_JSON_KEY.test(key)
|
|
? "[REDACTED]"
|
|
: sanitizeJson(entry, secrets),
|
|
]),
|
|
);
|
|
}
|
|
return value;
|
|
}
|
|
|
|
export function assertSecretFree(
|
|
value: string | Buffer,
|
|
secrets: readonly string[],
|
|
label: string,
|
|
options: { includeShapes?: boolean } = {},
|
|
) {
|
|
const leak = findSecretLeak(value, secrets, options);
|
|
if (leak) throw new Error(`Secret leak in ${label}: ${leak}`);
|
|
}
|
|
|
|
export function isEphemeralPostgresPidFile(paperclipHome: string, file: string): boolean {
|
|
const relative = path.relative(paperclipHome, file).split(path.sep).join("/");
|
|
return /^instances\/[^/]+\/db\/postmaster\.pid$/.test(relative);
|
|
}
|
|
|
|
export function isEphemeralPostgresScanFile(paperclipHome: string, file: string): boolean {
|
|
const relative = path.relative(paperclipHome, file).split(path.sep).join("/");
|
|
// A relation can be unlinked during PostgreSQL shutdown/checkpoint. Existing
|
|
// files are always scanned; this predicate only permits ENOENT after readdir.
|
|
return isEphemeralPostgresPidFile(paperclipHome, file) ||
|
|
/^instances\/[^/]+\/db\/base\/\d+\/\d+(?:_(?:fsm|vm|init))?(?:\.\d+)?$/.test(relative);
|
|
}
|
|
|
|
export async function findSecretLeakInDirectory(
|
|
root: string,
|
|
secrets: readonly string[],
|
|
options: {
|
|
includeShapes?: boolean;
|
|
ignoreFile?: (file: string) => boolean;
|
|
allowDisappearedFile?: (file: string) => boolean;
|
|
} = {},
|
|
): Promise<{ file: string; reason: string } | null> {
|
|
const overlap = Math.max(
|
|
256,
|
|
...normalizedSecrets(secrets).map((secret) => secret.length + 16),
|
|
);
|
|
const scan = async (
|
|
directory: string,
|
|
): Promise<{
|
|
file: string;
|
|
reason: string;
|
|
} | null> => {
|
|
const entries = await readdir(directory, { withFileTypes: true });
|
|
for (const entry of entries) {
|
|
const file = path.join(directory, entry.name);
|
|
if (entry.isDirectory()) {
|
|
const leak = await scan(file);
|
|
if (leak) return leak;
|
|
} else if (entry.isFile()) {
|
|
if (options.ignoreFile?.(file)) continue;
|
|
let carry = Buffer.alloc(0);
|
|
try {
|
|
for await (const chunk of createReadStream(file)) {
|
|
const data = Buffer.concat([
|
|
carry,
|
|
Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk),
|
|
]);
|
|
const reason = findSecretLeak(data, secrets, options);
|
|
if (reason) return { file, reason };
|
|
carry = data.subarray(Math.max(0, data.length - overlap));
|
|
}
|
|
} catch (error) {
|
|
// PostgreSQL removes its PID file on shutdown, possibly after readdir.
|
|
// Existing contents are still scanned; only the caller's exact
|
|
// transient paths may disappear. Evidence and other I/O errors fail.
|
|
if ((error as NodeJS.ErrnoException)?.code !== "ENOENT" ||
|
|
!options.allowDisappearedFile?.(file)) throw error;
|
|
}
|
|
}
|
|
}
|
|
return null;
|
|
};
|
|
return scan(root);
|
|
}
|