mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 07:12:00 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Before an agent starts, Paperclip prepares the task workspace and runs the project's configured setup commands (for example the workspace provision command) > - When that command fails, the run fails as `setup_failed`, and the task stops with a Retry > - The task page shows only "Failed" and a generic recovery notice. The real error (the command, its exit status and output) is visible only on the run page > - The user cannot see from the task which setting is broken or what to change > - This pull request records a bounded, named cause for a failed setup command and shows it on the task page > - The benefit is that the task names the broken setting and what to change, and classification, retry and recovery stay the same ## Linked Issues or Issue Description **What happened?** The restart-chaos config fault wave CF1 sets a project `workspaceStrategy.provisionCommand` to `bash ./scripts/provision-worktree.sh`, a script that does not exist. The run fails as `setup_failed` with `Execution workspace provision command "bash ./scripts/provision-worktree.sh" failed: bash: ./scripts/provision-worktree.sh: No such file or directory`. The task page shows "Failed" and "Paperclip automatically retried continuation … still has no live execution path". The grader fails the task as `CF1/provision_command:message_only_in_run_detail`. **Expected behavior** The task page names the failed setup step, the configured command, its exit status and a short tail of its output, and says what to change. Retry behavior stays the same. **Steps to reproduce** `node cli/node_modules/tsx/dist/cli.mjs tests/restart-chaos/config-wave.ts --faults CF1 --adapters codex --tasks 2 --concurrency 2 --restarts K1,K2 --seed 204` on `master`. **Paperclip version or commit** `master` at5ab98b0(wave `w-20261110T043929-s204-cf`, tasks t01 and t03). ## What Changed - `WorkspaceCommandExitError` now carries the setup step (`workspace_provision`, `workspace_seed`, `workspace_runtime_provision`), the configured command and the command output. - New `server/src/services/workspace-setup-command-failure.ts`: it builds a bounded, redacted `setupCommandFailure` record (step, command up to 200 characters, exit code, last 300 characters of output). It also recognizes the older message format, so runs recorded before this change still get a name. - `run-completion.ts` adds `setupCommandFailure` to the setup failure `resultJson`. The error code (`setup_failed`) and all retry and recovery fields stay the same. - `TaskInterruptionPresentation.setupFailure` (shared type) is set for `setup_failed` runs. It goes through the same per-run secret redaction and user-name redaction as `workspaceFailure`. - `ExecutionBlockerNotice` shows "Couldn’t set up the task workspace. <command> failed with exit code N: <output>. Fix the command in the project’s workspace settings, then retry." A scheduled transient retry keeps its countdown and only adds the name. - The restart-chaos config wave reads `interruption.setupFailure` as a task-level text for its actionable-message check. ## Verification - Red before, green after (the tests fail with the source changes reverted): - `server/src/__tests__/workspace-runtime.test.ts` — "names a failed project provision command with its exit status and output (CF1)" runs a real git worktree with a missing provision script (exit 127). - `server/src/services/task-interruption-presentation.test.ts` — "setup command failure presentation (CF1)": names the command, keeps `state`/`canRetry`/`userAction` identical, recognizes the older message, keeps a scheduled retry, bounds output and strips credentials from the command. - `ui/src/components/ExecutionBlockerNotice.test.tsx` and `tests/restart-chaos/config-faults.test.ts` cover the notice text and the harness check. - `pnpm --filter @paperclipai/shared typecheck`, `pnpm --filter @paperclipai/server typecheck`, `pnpm --filter @paperclipai/ui typecheck` pass. - Live proof: config wave `w-20261110T083227-s204-cf` (CF1, codex, 2 tasks, K1 and K2, seed 204) on commitae9a4b7: **2/2 pass**. Both tasks show `The project's workspace provision command "bash ./scripts/provision-worktree.sh" failed with exit code 127: bash: ./scripts/provision-worktree.sh: No such file or directory` on the task, rest again after the restart, and finish after the repair and Retry. On `master` the same wave failed both tasks as `message_only_in_run_detail` (`w-20261110T043929-s204-cf`). ## Risks - Low risk. The change adds a presentation field. It does not change the error code, retry, recovery or blocking behavior. - The command and output are user-configured text. They are bounded, passed through `redactSensitiveText`, the run's secret registry and user-name redaction. If redaction fails, the field is omitted, like `workspaceFailure`. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, used through Claude Code with tool use (shell, file edits, test runs). ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude <noreply@anthropic.com>
98 lines
5.7 KiB
TypeScript
98 lines
5.7 KiB
TypeScript
import type { TaskInterruptionPresentation } from "@paperclipai/shared";
|
|
import { redactSensitiveText } from "../redaction.js";
|
|
|
|
/**
|
|
* A configured workspace setup command (a project or service setting) exited
|
|
* non-zero before the agent started. The run keeps its `setup_failed`
|
|
* classification and retry behavior; this bounded record only lets the task
|
|
* page name the setting that broke and what it printed.
|
|
*/
|
|
type SetupCommandFailure = NonNullable<TaskInterruptionPresentation["setupFailure"]>;
|
|
type SetupStep = SetupCommandFailure["step"];
|
|
|
|
const SETUP_STEPS: ReadonlySet<string> = new Set<SetupStep>(["workspace_provision", "workspace_seed", "workspace_runtime_provision"]);
|
|
const MAX_COMMAND_CHARS = 200;
|
|
const MAX_OUTPUT_CHARS = 300;
|
|
const STEP_SETTINGS: Record<SetupStep, string> = {
|
|
workspace_provision: "The project's workspace provision command",
|
|
workspace_seed: "The workspace seed command",
|
|
workspace_runtime_provision: "The runtime provision command",
|
|
};
|
|
// Messages written by workspace-runtime.ts before setup failures carried structured fields.
|
|
// The command is the text between the prefix and the last `" failed`, so quoted and multiline commands parse.
|
|
const LEGACY_MESSAGE = /^(Execution workspace provision|Workspace seed|Runtime provision) command "([\s\S]{1,2000})" failed(?: with exit code (-?\d+)|: ([\s\S]+))$/;
|
|
const LEGACY_STEPS: Record<string, SetupStep> = {
|
|
"Execution workspace provision": "workspace_provision",
|
|
"Workspace seed": "workspace_seed",
|
|
"Runtime provision": "workspace_runtime_provision",
|
|
};
|
|
|
|
/** Whole registered secret values are removed before any truncation, so a cut can never keep a fragment. */
|
|
function withoutSecrets(value: string, secrets: readonly string[]): string {
|
|
for (const secret of [...secrets].sort((left, right) => right.length - left.length)) {
|
|
if (secret.length >= 4) value = value.split(secret).join("[REDACTED]");
|
|
}
|
|
return value;
|
|
}
|
|
|
|
function bounded(value: string, max: number, keep: "head" | "tail", secrets: readonly string[] = []): string {
|
|
const clean = [...redactSensitiveText(withoutSecrets(value, secrets))
|
|
.replace(/[\u0000-\u0008\u000b-\u001f\u007f-\u009f\u202a-\u202e\u2066-\u2069]/g, "").trim()];
|
|
if (clean.length <= max) return clean.join("");
|
|
return keep === "head" ? `${clean.slice(0, max - 1).join("")}…` : `…${clean.slice(clean.length - (max - 1)).join("")}`;
|
|
}
|
|
|
|
function normalize(step: SetupStep, command: string, exitCode: number | null, output: string | null,
|
|
secrets: readonly string[] = [], limits = { command: MAX_COMMAND_CHARS, output: MAX_OUTPUT_CHARS }): SetupCommandFailure | null {
|
|
const safeCommand = bounded(command, limits.command, "head", secrets);
|
|
if (!safeCommand) return null;
|
|
const safeOutput = output ? bounded(output, limits.output, "tail", secrets) || null : null;
|
|
const status = exitCode === null ? "failed" : `failed with exit code ${exitCode}`;
|
|
return {
|
|
step, command: safeCommand, exitCode, output: safeOutput,
|
|
message: `${STEP_SETTINGS[step]} "${safeCommand}" ${status}${safeOutput ? `: ${safeOutput}` : ""}`,
|
|
};
|
|
}
|
|
|
|
/** Bounded, redacted result evidence for a run whose setup command exited non-zero. */
|
|
export function setupCommandFailureResultJson(error: unknown, secrets: readonly string[] = []): { setupCommandFailure: SetupCommandFailure } | Record<string, never> {
|
|
let current: unknown = error;
|
|
for (let depth = 0; depth < 6 && current; depth += 1) {
|
|
// WorkspaceCommandExitError (workspace-runtime.ts), read by shape so this module stays light.
|
|
const value = current as { step?: unknown; command?: unknown; exitCode?: unknown; output?: unknown };
|
|
if (current instanceof Error && typeof value.step === "string" && SETUP_STEPS.has(value.step) && typeof value.command === "string") {
|
|
const failure = normalize(value.step as SetupStep, value.command,
|
|
typeof value.exitCode === "number" && Number.isInteger(value.exitCode) ? value.exitCode : null,
|
|
typeof value.output === "string" ? value.output : null, secrets);
|
|
return failure ? { setupCommandFailure: failure } : {};
|
|
}
|
|
current = current instanceof Error ? current.cause : undefined;
|
|
}
|
|
return {};
|
|
}
|
|
|
|
/** Read the recorded setup-command failure, or recognize one recorded before the structured field existed. */
|
|
export function readSetupCommandFailure(resultJson: Record<string, unknown> | null | undefined, error: unknown): SetupCommandFailure | null {
|
|
const stored = resultJson?.setupCommandFailure;
|
|
if (stored && typeof stored === "object" && !Array.isArray(stored)) {
|
|
const value = stored as Record<string, unknown>;
|
|
if (typeof value.step === "string" && SETUP_STEPS.has(value.step) && typeof value.command === "string") {
|
|
return normalize(value.step as SetupStep, value.command,
|
|
typeof value.exitCode === "number" && Number.isInteger(value.exitCode) ? value.exitCode : null,
|
|
typeof value.output === "string" ? value.output : null);
|
|
}
|
|
}
|
|
if (typeof error !== "string") return null;
|
|
const match = LEGACY_MESSAGE.exec(error.trim());
|
|
if (!match) return null;
|
|
// Older text was never shortened with its run's registered secrets removed, so it stays whole here.
|
|
// The task read removes those secrets first and then shortens it (boundSetupCommandFailure).
|
|
return normalize(LEGACY_STEPS[match[1]!]!, match[2]!, match[3] === undefined ? null : Number(match[3]), match[4] ?? null,
|
|
[], { command: Number.POSITIVE_INFINITY, output: Number.POSITIVE_INFINITY });
|
|
}
|
|
|
|
/** Shorten a projected setup failure after the run's registered secrets were removed from its whole text. */
|
|
export function boundSetupCommandFailure(value: SetupCommandFailure): SetupCommandFailure | null {
|
|
return normalize(value.step, value.command, value.exitCode, value.output);
|
|
}
|