mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-10 03:08:10 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The board UI is the operator surface where users create, assign, monitor, and review work items. > - The product language is moving toward "tasks" for user-facing work items while the internal API and database still use "issues". > - PR #7543 bundled this copy migration with broader information-architecture work, which made the branch too large for Greptile review. > - This pull request peels the Issue-to-Task copy migration into a smaller, independently reviewable change. > - The benefit is clearer user-facing terminology, less agent confusion via the Paperclip skill note, and a smaller PR that Greptile can review. ## Linked Issues or Issue Description Refs #7645 Refs #7543 Refs PAP-10430 This PR was split out of #7543 so the Issue-to-Task copy migration can be reviewed separately and the remaining IA PR can fall under Greptile's file limit. ## What Changed - Preserves Scott Tong's original `PAP-57` copy-only commit, with author and co-author credit intact, to rename user-facing "Issues" copy to "Tasks" across the UI while keeping routes/API/internal symbols as `issue`. - Updates onboarding and release-smoke browser selectors from `Create & Open Issue` to `Create & Open Task`. - Adds a terminology note to `skills/paperclip/SKILL.md` clarifying that task and issue refer to the same Paperclip work item. - Resolves the only cherry-pick conflict by keeping current search artifacts support and changing visible search copy to "tasks". ## Verification - `pnpm --filter @paperclipai/ui build` passed. - `NODE_ENV=test pnpm exec vitest run ui/src/components/IssuesList.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/NewIssueDialog.test.tsx ui/src/pages/IssueDetail.test.tsx` passed: 4 files, 66 tests. - `git diff --check origin/master...HEAD` passed. - Diff is 80 files, below Greptile's 100-file limit. - Before/after UI copy examples: "Issues" -> "Tasks", "New Issue" -> "New Task", "Create & Open Issue" -> "Create & Open Task". ## Risks - Medium copy-risk: this intentionally changes user-facing terminology broadly while keeping internal issue identifiers and routes unchanged. - Some docs and APIs still say `issue`; the skill note clarifies this so agents do not treat task and issue as separate entities. - Browser-level visual validation is expected from CI because this local container is missing usable browser dependencies. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used Scott Tong authored the original `PAP-57` copy migration, assisted by Claude Opus 4.8 and Paperclip agents per the preserved commit metadata. Codex / GPT-5-class coding agent with shell, GitHub CLI, and repository access performed the PR split, conflict resolution, skill note, and verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: scotttong <scott.tong@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
97 lines
3.2 KiB
TypeScript
97 lines
3.2 KiB
TypeScript
import type { ComponentProps } from "react";
|
||
import { renderToStaticMarkup } from "react-dom/server";
|
||
import { describe, expect, it, vi } from "vitest";
|
||
import { IssueRelatedWorkPanel } from "./IssueRelatedWorkPanel";
|
||
|
||
vi.mock("@/lib/router", () => ({
|
||
Link: ({ children, to, ...props }: ComponentProps<"a"> & { to: string }) => <a href={to} {...props}>{children}</a>,
|
||
}));
|
||
|
||
describe("IssueRelatedWorkPanel", () => {
|
||
it("renders outbound and inbound related work with source labels", () => {
|
||
const html = renderToStaticMarkup(
|
||
<IssueRelatedWorkPanel
|
||
relatedWork={{
|
||
outbound: [
|
||
{
|
||
issue: {
|
||
id: "issue-2",
|
||
identifier: "PAP-22",
|
||
title: "Downstream task",
|
||
status: "todo",
|
||
priority: "medium",
|
||
assigneeAgentId: null,
|
||
assigneeUserId: null,
|
||
},
|
||
mentionCount: 2,
|
||
sources: [
|
||
{ kind: "title", sourceRecordId: null, label: "title", matchedText: "PAP-22" },
|
||
{ kind: "document", sourceRecordId: "doc-1", label: "plan", matchedText: "/issues/PAP-22" },
|
||
],
|
||
},
|
||
],
|
||
inbound: [
|
||
{
|
||
issue: {
|
||
id: "issue-3",
|
||
identifier: "PAP-33",
|
||
title: "Upstream task",
|
||
status: "in_progress",
|
||
priority: "high",
|
||
assigneeAgentId: null,
|
||
assigneeUserId: null,
|
||
},
|
||
mentionCount: 1,
|
||
sources: [
|
||
{ kind: "comment", sourceRecordId: "comment-1", label: "comment", matchedText: "PAP-1" },
|
||
],
|
||
},
|
||
],
|
||
}}
|
||
/>,
|
||
);
|
||
|
||
expect(html).toContain("References");
|
||
expect(html).toContain("Referenced by");
|
||
expect(html).toContain("PAP-22");
|
||
expect(html).toContain("PAP-33");
|
||
expect(html).toContain('aria-label="Task PAP-22: Downstream task"');
|
||
expect(html).toContain('aria-label="Task PAP-33: Upstream task"');
|
||
expect(html).toContain("plan");
|
||
expect(html).toContain("comment");
|
||
});
|
||
|
||
it("collapses duplicate source labels into a single chip with a count", () => {
|
||
const html = renderToStaticMarkup(
|
||
<IssueRelatedWorkPanel
|
||
relatedWork={{
|
||
outbound: [],
|
||
inbound: [
|
||
{
|
||
issue: {
|
||
id: "issue-4",
|
||
identifier: "PAP-44",
|
||
title: "Chatty inbound",
|
||
status: "in_progress",
|
||
priority: "medium",
|
||
assigneeAgentId: null,
|
||
assigneeUserId: null,
|
||
},
|
||
mentionCount: 3,
|
||
sources: [
|
||
{ kind: "comment", sourceRecordId: "c1", label: "comment", matchedText: "PAP-44 first" },
|
||
{ kind: "comment", sourceRecordId: "c2", label: "comment", matchedText: "PAP-44 second" },
|
||
{ kind: "comment", sourceRecordId: "c3", label: "comment", matchedText: "PAP-44 third" },
|
||
],
|
||
},
|
||
],
|
||
}}
|
||
/>,
|
||
);
|
||
|
||
const commentMatches = html.match(/>comment</g) ?? [];
|
||
expect(commentMatches).toHaveLength(1);
|
||
expect(html).toContain("×3");
|
||
});
|
||
});
|