mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-23 17:33:51 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Governed MCP access spans contracts, runtime enforcement, adapters, UI surfaces, and operator verification > - The parity reference PR #9534 is too large for effective automated or human review > - The feature therefore needs a linear stack whose individual diffs stay below the 100-file review limit > - This pull request is split 5/8 and focuses on remaining adapters, CLI, plugin examples, and deployment packaging > - The benefit is a standalone, testable review boundary while preserving byte-for-byte parity at the top of the stack ## Linked Issues or Issue Description - Related parity reference: #9534 - Problem: The backend runtime needs packaging, CLI propagation, worktree provisioning, release manifests, and remaining adapter/plugin consumers. - Proposed solution: Adds the remaining runtime/deployment integration after compile-required contracts and concrete MCP injection moved into lower server levels. - Alternatives considered: keeping #9534 as one 403-file review, or rewriting the feature to manufacture seams; both were rejected in favor of path extraction plus compile-driven boundary moves. - Roadmap alignment: this advances the existing governed MCP/tool-access work already represented by #9534; it does not introduce a separate roadmap initiative. - Stack position: base branch is `pap10341-split/04-server-runtime-wiring`. - Merge policy: merge bottom-up, in order, only after the complete eight-PR stack has been reviewed and the top-of-stack parity gate remains empty. - Requested review: QA for CLI, packaging, and worktree behavior; Greptile on every PR. ## What Changed - Adds the remaining runtime/deployment integration after compile-required contracts and concrete MCP injection moved into lower server levels. - Keeps this PR below 100 changed files and independently typecheckable. - Preserves the final tree from #9534 when combined with the other seven stack levels. ## Verification - `pnpm typecheck` - Focused CLI Vitest run — 4 files, 49 tests passed ## Risks - Packaging omissions could make the feature work in source but fail in Docker, worktrees, or release assembly. - Stack risk: merging out of order can expose incomplete layers; mitigate by following the documented bottom-up merge policy. - Parity risk: later edits to an intermediate branch can drift from #9534; mitigate by re-running the empty top-of-stack diff before merge. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, exact model ID `gpt-5.4`; runtime-managed context window; medium reasoning with repository, shell, Git, GitHub CLI, and code-execution tools enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] Internal references are omitted except the execution-plan link explicitly required for this coordinated split stack - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge ## Stack Coordination - Internal execution plan: [PAP-13874](/PAP/issues/PAP-13874#document-plan) - Parity reference: #9534 - Stack: #9556 → #9557 → #9558 → #9559 → #9560 → #9561 → #9562 → #9563 - Merge bottom-up only after full-stack review and an empty parity diff at #9563. --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
211 lines
7.7 KiB
TypeScript
211 lines
7.7 KiB
TypeScript
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { afterEach, beforeEach, describe, expect, it } from "vitest";
|
|
import { onboard } from "../commands/onboard.js";
|
|
import type { PaperclipConfig } from "../config/schema.js";
|
|
|
|
const ORIGINAL_ENV = { ...process.env };
|
|
const ORIGINAL_CWD = process.cwd();
|
|
const ORIGINAL_PATH = process.env.PATH;
|
|
|
|
function createExistingConfigFixture() {
|
|
const root = fs.mkdtempSync(path.join(os.tmpdir(), "paperclip-onboard-"));
|
|
const runtimeRoot = path.join(root, "runtime");
|
|
const configPath = path.join(root, ".paperclip", "config.json");
|
|
const config: PaperclipConfig = {
|
|
$meta: {
|
|
version: 1,
|
|
updatedAt: "2026-03-29T00:00:00.000Z",
|
|
source: "configure",
|
|
},
|
|
database: {
|
|
mode: "embedded-postgres",
|
|
embeddedPostgresDataDir: path.join(runtimeRoot, "db"),
|
|
embeddedPostgresPort: 54329,
|
|
backup: {
|
|
enabled: true,
|
|
intervalMinutes: 60,
|
|
retentionDays: 30,
|
|
dir: path.join(runtimeRoot, "backups"),
|
|
},
|
|
},
|
|
logging: {
|
|
mode: "file",
|
|
logDir: path.join(runtimeRoot, "logs"),
|
|
},
|
|
server: {
|
|
deploymentMode: "local_trusted",
|
|
exposure: "private",
|
|
host: "127.0.0.1",
|
|
port: 3100,
|
|
allowedHostnames: [],
|
|
serveUi: true,
|
|
},
|
|
auth: {
|
|
baseUrlMode: "auto",
|
|
disableSignUp: false,
|
|
},
|
|
telemetry: {
|
|
enabled: true,
|
|
},
|
|
storage: {
|
|
provider: "local_disk",
|
|
localDisk: {
|
|
baseDir: path.join(runtimeRoot, "storage"),
|
|
},
|
|
s3: {
|
|
bucket: "paperclip",
|
|
region: "us-east-1",
|
|
prefix: "",
|
|
forcePathStyle: false,
|
|
},
|
|
},
|
|
secrets: {
|
|
provider: "local_encrypted",
|
|
strictMode: false,
|
|
localEncrypted: {
|
|
keyFilePath: path.join(runtimeRoot, "secrets", "master.key"),
|
|
},
|
|
},
|
|
};
|
|
|
|
fs.mkdirSync(path.dirname(configPath), { recursive: true });
|
|
fs.writeFileSync(configPath, `${JSON.stringify(config, null, 2)}\n`, { mode: 0o600 });
|
|
|
|
return { configPath, configText: fs.readFileSync(configPath, "utf8") };
|
|
}
|
|
|
|
function createFreshConfigPath() {
|
|
const root = fs.mkdtempSync(path.join(os.tmpdir(), "paperclip-onboard-fresh-"));
|
|
return path.join(root, ".paperclip", "config.json");
|
|
}
|
|
|
|
describe("onboard", () => {
|
|
beforeEach(() => {
|
|
process.env = { ...ORIGINAL_ENV };
|
|
delete process.env.PAPERCLIP_AGENT_JWT_SECRET;
|
|
delete process.env.PAPERCLIP_SECRETS_MASTER_KEY;
|
|
delete process.env.PAPERCLIP_SECRETS_MASTER_KEY_FILE;
|
|
delete process.env.PAPERCLIP_DB_BACKUP_DIR;
|
|
delete process.env.PAPERCLIP_DB_BACKUP_ENABLED;
|
|
delete process.env.PAPERCLIP_DB_BACKUP_INTERVAL_MINUTES;
|
|
delete process.env.PAPERCLIP_DB_BACKUP_RETENTION_DAYS;
|
|
delete process.env.PAPERCLIP_STORAGE_PROVIDER;
|
|
delete process.env.PAPERCLIP_STORAGE_LOCAL_DIR;
|
|
delete process.env.PAPERCLIP_SECRETS_PROVIDER;
|
|
delete process.env.PAPERCLIP_SECRETS_STRICT_MODE;
|
|
delete process.env.PAPERCLIP_HOME;
|
|
delete process.env.PAPERCLIP_CONFIG;
|
|
delete process.env.PAPERCLIP_INSTANCE_ID;
|
|
delete process.env.PAPERCLIP_BIND;
|
|
delete process.env.PAPERCLIP_BIND_HOST;
|
|
delete process.env.PAPERCLIP_TAILNET_BIND_HOST;
|
|
delete process.env.HOST;
|
|
});
|
|
|
|
afterEach(() => {
|
|
process.env = { ...ORIGINAL_ENV };
|
|
process.chdir(ORIGINAL_CWD);
|
|
});
|
|
|
|
it("preserves an existing config when rerun without flags", async () => {
|
|
const fixture = createExistingConfigFixture();
|
|
|
|
await onboard({ config: fixture.configPath });
|
|
|
|
expect(fs.readFileSync(fixture.configPath, "utf8")).toBe(fixture.configText);
|
|
expect(fs.existsSync(`${fixture.configPath}.backup`)).toBe(false);
|
|
expect(fs.existsSync(path.join(path.dirname(fixture.configPath), ".env"))).toBe(true);
|
|
});
|
|
|
|
it("preserves an existing config when rerun with --yes", async () => {
|
|
const fixture = createExistingConfigFixture();
|
|
|
|
await onboard({ config: fixture.configPath, yes: true, invokedByRun: true });
|
|
|
|
expect(fs.readFileSync(fixture.configPath, "utf8")).toBe(fixture.configText);
|
|
expect(fs.existsSync(`${fixture.configPath}.backup`)).toBe(false);
|
|
expect(fs.existsSync(path.join(path.dirname(fixture.configPath), ".env"))).toBe(true);
|
|
});
|
|
|
|
it("keeps --yes onboarding on local trusted loopback defaults", async () => {
|
|
const configPath = createFreshConfigPath();
|
|
process.env.HOST = "0.0.0.0";
|
|
process.env.PAPERCLIP_BIND = "lan";
|
|
|
|
await onboard({ config: configPath, yes: true, invokedByRun: true });
|
|
|
|
const raw = JSON.parse(fs.readFileSync(configPath, "utf8")) as PaperclipConfig;
|
|
expect(raw.server.deploymentMode).toBe("local_trusted");
|
|
expect(raw.server.exposure).toBe("private");
|
|
expect(raw.server.bind).toBe("loopback");
|
|
expect(raw.server.host).toBe("127.0.0.1");
|
|
});
|
|
|
|
it("creates instance-root config and data paths for a fresh PAPERCLIP_HOME", async () => {
|
|
const home = fs.mkdtempSync(path.join(os.tmpdir(), "paperclip-onboard-home-"));
|
|
const cwd = fs.mkdtempSync(path.join(os.tmpdir(), "paperclip-onboard-cwd-"));
|
|
process.chdir(cwd);
|
|
process.env.PAPERCLIP_HOME = home;
|
|
|
|
await onboard({ yes: true, invokedByRun: true });
|
|
|
|
const instanceRoot = path.join(home, "instances", "default");
|
|
const configPath = path.join(instanceRoot, "config.json");
|
|
const raw = JSON.parse(fs.readFileSync(configPath, "utf8")) as PaperclipConfig;
|
|
|
|
expect(raw.database.embeddedPostgresDataDir).toBe(path.join(instanceRoot, "db"));
|
|
expect(raw.database.backup.dir).toBe(path.join(instanceRoot, "data", "backups"));
|
|
expect(raw.logging.logDir).toBe(path.join(instanceRoot, "logs"));
|
|
expect(raw.storage.localDisk.baseDir).toBe(path.join(instanceRoot, "data", "storage"));
|
|
expect(raw.secrets.localEncrypted.keyFilePath).toBe(path.join(instanceRoot, "secrets", "master.key"));
|
|
expect(fs.existsSync(path.join(instanceRoot, ".env"))).toBe(true);
|
|
expect(fs.existsSync(path.join(instanceRoot, "secrets", "master.key"))).toBe(true);
|
|
});
|
|
|
|
it("supports authenticated/private quickstart bind presets", async () => {
|
|
const configPath = createFreshConfigPath();
|
|
process.env.PAPERCLIP_TAILNET_BIND_HOST = "100.64.0.8";
|
|
|
|
await onboard({ config: configPath, yes: true, invokedByRun: true, bind: "tailnet" });
|
|
|
|
const raw = JSON.parse(fs.readFileSync(configPath, "utf8")) as PaperclipConfig;
|
|
expect(raw.server.deploymentMode).toBe("authenticated");
|
|
expect(raw.server.exposure).toBe("private");
|
|
expect(raw.server.bind).toBe("tailnet");
|
|
expect(raw.server.host).toBe("100.64.0.8");
|
|
});
|
|
|
|
it("keeps tailnet quickstart on loopback until tailscale is available", async () => {
|
|
const configPath = createFreshConfigPath();
|
|
delete process.env.PAPERCLIP_TAILNET_BIND_HOST;
|
|
process.env.PATH = "";
|
|
|
|
try {
|
|
await onboard({ config: configPath, yes: true, invokedByRun: true, bind: "tailnet" });
|
|
} finally {
|
|
process.env.PATH = ORIGINAL_PATH;
|
|
}
|
|
|
|
const raw = JSON.parse(fs.readFileSync(configPath, "utf8")) as PaperclipConfig;
|
|
expect(raw.server.deploymentMode).toBe("authenticated");
|
|
expect(raw.server.exposure).toBe("private");
|
|
expect(raw.server.bind).toBe("tailnet");
|
|
expect(raw.server.host).toBe("127.0.0.1");
|
|
});
|
|
|
|
it("ignores deployment env overrides during --yes quickstart", async () => {
|
|
const configPath = createFreshConfigPath();
|
|
process.env.PAPERCLIP_DEPLOYMENT_MODE = "authenticated";
|
|
|
|
await onboard({ config: configPath, yes: true, invokedByRun: true });
|
|
|
|
const raw = JSON.parse(fs.readFileSync(configPath, "utf8")) as PaperclipConfig;
|
|
expect(raw.server.deploymentMode).toBe("local_trusted");
|
|
expect(raw.server.exposure).toBe("private");
|
|
expect(raw.server.bind).toBe("loopback");
|
|
expect(raw.server.host).toBe("127.0.0.1");
|
|
});
|
|
});
|