mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-06 23:20:53 +01:00
## Thinking Path > - Paperclip manages agent work and should become idle when it owes no background work. > - The attention feed archives old pending approvals under the existing 90-day policy. > - The server rebuilds the feed on each maintenance tick, even when approval state has not changed. > - Some approvals have never been read, so retention rows alone cannot define the work. > - Approval records and committed eligibility changes define the real deadline and wake triggers. > - This PR gives approval retention its own deadline worker and reuses the existing retention and archive-delivery contracts. > - The approval lane stops idle scans while other attention sources remain separate migration work. ## Linked Issues or Issue Description Stacked on #17490. This PR owns approval retention only. Archive notification delivery is already separated in #17475. Other attention-source retention and remaining recurring server duties remain in the stack inventory. The related-PR search found no overlapping approval-retention worker migration. **What existing behavior does this improve?** Automatic archival of old pending approvals from attention. **Current behavior** The shared maintenance tick builds the attention feed for each active company. That query discovers pending approvals and materializes retention records before checking their age. An unchanged or empty approval source is read repeatedly. **Proposed behavior** Reconstruct eligible approvals at startup. Schedule the earliest approval activity timestamp plus 90 days. Wake after committed changes to approvals, links, issue visibility, company activity, or retention controls. Stop scheduling when no eligible approval remains. Archive records through the existing version checks, audit writes, and notification outbox. **Reason and benefit** Idle approval retention should generate no recurring SQL. Unseen approvals still need eventual archival. A stale candidate must not archive an approval that was resubmitted while the worker waited for its source lock. **Breaking changes** None intended. The archive age, eligibility, keep controls, audit, and notification policy remain. Normal attention reads still include approvals. No Cloud sleep blocker is relaxed. ## What Changed - Restrict tool-review signals to their existing terminal transition owners (approve/reject/cancel). Creation/link/revision/resubmit signal retention only. - Coalesce retention notifications under one thirty-second aggregate read budget. Known deadlines still preempt it; no notification or durable deadline means no scan. - Add a bounded approval-retention worker. It uses the shared deadline coordinator and reads pending approvals directly. - Share first-linked-issue ordering and execution visibility through `approval-visibility.ts`, used by both the feed and worker. Preserve actor-specific read filtering and locked archival rechecks. - Materialize unseen approvals on demand inside manual keep/archive/revive transactions. Use the saved activity timestamp and existing versioned state; retain company scoping and rollback on failure. - Add awaited pre-write signals to approval, budget, tool, link, visibility, company, and retention mutation owners. Preserve outer transaction ownership; keep provider calls outside SQL wrappers. - Narrow retention inputs to the source fields the existing service uses. Signal materialization only for inserted or changed state so unchanged reads converge. - Exclude approval collection from the maintenance feed before its query. Other source kinds remain in that sweep. - Add the pending-only approval deadline index with concurrent, idempotent creation. Keep the five newest migration snapshots. - Add real-Postgres lifecycle tests and startup wiring tests. Enable validated external test databases for existing attention and budget suites. - Document producer coverage, quiet conditions, recovery and remaining scope in `doc/idle-approval-retention.md` and the stack ledger. ## Verification Current test revision: `dd844f4e8cbbf1db681a774dc31cd552301bef48`, followed by docs-only `3efda33812`, which received both 5/5 reviews and passing CI. This candidate normally integrates landed Grok `2adcde162e`. All runtime and acceptance-test sources are byte-identical to that tested/reviewed tree; only four independent Runner E2E accounting files and the ledger differ. Migration 0392 and the parent journal prefix are unchanged. Local checks are reused for their unchanged source; fresh final-head CI and reviews are required against master. This remains the approval-retention duty. - **315 cases pass** across eight complete suites: approval retention/service, attention, decision retention, budgets, tool gateway, server startup and scoped deadlines. All 30 real-PostgreSQL lifecycle cases pass. Server production typecheck and build pass. - **Four regressions failed before repair**: unseen young keep/archive/revive returned 404; the manual keep rollback case could not reach its update. They now pass. A failed keep update leaves no retention row or audit; retry succeeds with one audit. - Both linked-issue orders are checked against the feed: hidden first/visible later is excluded; visible first/hidden later remains eligible. The feed and worker use the same owner query, with actor read filtering preserved. - Generated concurrent/idempotent migration `0392_small_frightful_four.sql` adds only the pending approval index. Every historical parent SQL migration and all 390 parent journal entries are unchanged. Five generated snapshots remain (0388–0392). Schema drift, migration safety/numbering and actual fresh apply/replay on five isolated PostgreSQL databases pass. - Existing precision, transaction, drain/resume, failure fairness and shutdown tests remain. Earlier transaction-stub, budget-import, diagnostic-client and CI failures are recorded in the owning audit and stack ledger; later passes do not erase them. - Three additional real regressions failed before the wake repair: ordinary mutations emitted tool-review signals in both resolution cases, and sequential tenant writes caused repeated global reads. Tests now prove terminal approve/reject/cancel signals and one aggregate reconciliation per thirty-second window with a different company's pending approval retained. The aggregate budget is stricter than a separate per-company budget and matches the old default cadence; known deadlines preempt it. - The initial coalescing fixture expected the concrete pending-work hold to clear before reconciliation; it now preserves that hold and measures SQL. The first broad repair passed 313 cases but failed the existing parked-review cancel case. The original cancel producer is restored; all 315 now pass without weakening assertions. At old head `5991f257bb`, security was action-required and Greptile returned service error `8fb1835c-e564-476b-b802-d5be164ea915`. Fresh repaired-head results are required, not assumed. Commands: server Vitest for `approval-retention-work`, `approvals-service`, `attention-service`, `decision-retention-service`, `budgets-service`, `tool-gateway-service`, `server-startup-feedback-export`, `scoped-deadline-work`; server typecheck/build; DB snapshot drift, migration checks and fresh apply/replay. Fresh exact-head Greptile/Ponytail and CI remain merge gates. No full local repository suite or deployed host suspension/cost claim is made. Earlier stack verification below is historical evidence at the explicitly named revisions, not this head's acceptance: Approved delegated Test-tab calls now evaluate caller and target policies in the existing claim transaction. Real HTTP regressions first showed a missing caller charge and shared-limit self-rejection. All 78 connection-management cases and 92 gateway cases now pass on the owning branch, along with server production typechecking. All 78 connection-management cases also pass at combined tip `d25f830db89c1623bff3547bfc68015c1c66e0cf`. The three new cases cover shared charges, separate charges, rollback on denial, duplicate approval, and rejection of a later authorized call. Intermediate counter/identity fixture failures and a reused-database Slack collision are recorded in [the owning audit](https://github.com/paperclipai/paperclip/blob/20557d2c3dd0949c734eaa8095fd78b9b07d7fd5/doc/idle-approved-tool-recovery.md#delegated-test-tab-admission-after-policy-changes). The earlier combined checks below remain evidence for their stated revisions. Current-head CI and review remain required. Earlier published head: `20557d2c3dd0949c734eaa8095fd78b9b07d7fd5`. This remains a single-duty PR stacked on #17490. - Integrated pinned master `8548173fc9efdc0fa07644fb92dcc0b6851a95e5` with normal merges. Every branch passed generated-schema checks and its target-branch migration-order gate. Existing SQL is unchanged; the 25 stack migrations follow master’s new migration. - Duty-specific producer coverage, lifecycle tests, and earlier failure records: [2026-10-24-recurring-server-sleep-stack.md](https://github.com/paperclipai/paperclip/blob/76a49810c7ff403ae7720bef0d453747bd844731/doc/plans/2026-10-24-recurring-server-sleep-stack.md). - Combined tip `51e6cbe67979b55b340ea9f0f434c5b5c682ccd6`: **355 startup/cancellation/recovery/dispatch/preservation tests**, **75 connection-management tests**, and production server typechecking pass. These combined checks do not mean every intermediate PR independently ran the full repository suite. - Real master-to-stack database upgrade passes: **379 unchanged prior migration receipts plus 25 new migrations**, with the gateway responsibility fixture preserved. - Owning-branch checks: 84 runner installation/settlement cases plus runner typechecking and generated TypeScript/Rust profile agreement; 253 GitHub review workflow cases. Stop-attribution and held-worker readiness regressions failed before their fixes. - Failure accounting: the initial combined run passed 349 cases and failed six idle assertions in a reused preservation database containing old cancelled runs. Repeating the combined command with a fresh preservation database passed. Earlier invalid project selection, merge import/type errors, and the interrupted full local suite are not counted as passing checks. - **Latest-head CI and review remain required.** Prior CI findings include GitHub idle observation, route teardown, attention cleanup, touch-picker E2E, workspace health, and voice-cleanup timing; local passes do not erase those failures. No full local repository-suite, deployed sleep, fleet cost, or live Copilot qualification claim is made. ## Risks - Signals cover the application database owner and its child pools. Independent SQL writers and other active processes need an explicit wake integration. Startup reconstructs committed durable state. - The source row lock prevents stale approval-activity archival. It does not add cross-table serializability for concurrent link, visibility, or company-policy changes. - Newly changed eligibility can wait up to the thirty-second notification window, matching the former default maintenance cadence. Saved deadlines still preempt; no new idle polling is added. - Failed records retain recovery debt. Bounded cursor progress lets later rows proceed without dropping failures. - The shared retention transaction now groups materialization and activity-version updates. Existing attention and retention consumers are tested against PostgreSQL. - Kept, archived, resolved or inactive-company approvals can become quiet, but their supported mutations must retain their wake notifications. - The local scheduler cannot wake stopped compute. This PR neither adds approval deadlines to Cloud's external alarm contract nor claims measured host or database suspension. ## Model Used OpenAI Codex, GPT-6 family, with reasoning and code execution. The exact serving model identifier and context window were not exposed. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
2343 lines
89 KiB
TypeScript
2343 lines
89 KiB
TypeScript
import { resolveExternalTestDatabaseUrl } from "./helpers/external-test-database.js";
|
|
import { createAgentLifecycle } from "../services/agent-lifecycle.js";
|
|
import { randomUUID } from "node:crypto";
|
|
import express from "express";
|
|
import request from "supertest";
|
|
import { eq, sql } from "drizzle-orm";
|
|
import { createDatabaseResponseCapture, installDatabaseResponseCapture } from "@paperclipai/db/response-capture";
|
|
import { afterAll, afterEach, beforeAll, describe, expect, it } from "vitest";
|
|
import {
|
|
activityLog,
|
|
agents,
|
|
approvals,
|
|
assets,
|
|
budgetIncidents,
|
|
budgetPolicies,
|
|
companies,
|
|
createDb,
|
|
decisionQueueItems,
|
|
decisionQueues,
|
|
decisionArchiveNotificationOutbox,
|
|
decisionRetention,
|
|
decisions,
|
|
decisionTriage,
|
|
decisionTriageEvents,
|
|
documents,
|
|
heartbeatRunEvents,
|
|
heartbeatRuns,
|
|
inboxDismissals,
|
|
invites,
|
|
issueApprovals,
|
|
issueAttachments,
|
|
issueDocuments,
|
|
issueRecoveryActions,
|
|
issueRelations,
|
|
issueThreadInteractions,
|
|
issues,
|
|
joinRequests,
|
|
projects,
|
|
projectWorkspaces,
|
|
} from "@paperclipai/db";
|
|
import {
|
|
getEmbeddedPostgresTestSupport,
|
|
startEmbeddedPostgresTestDatabase,
|
|
} from "./helpers/embedded-postgres.js";
|
|
import { errorHandler } from "../middleware/index.js";
|
|
import { attentionRoutes } from "../routes/attention.js";
|
|
import { attentionService } from "../services/attention.js";
|
|
import { listAttentionExhaustedRuns } from "../services/attention-exhausted-runs.js";
|
|
import { agentService } from "../services/agents.js";
|
|
import { ROUTABLE_BLOCKED_ROLLOUT_AT } from "../services/routable-blocked.js";
|
|
|
|
const externalUrl = resolveExternalTestDatabaseUrl("PAPERCLIP_ATTENTION_TEST_DATABASE_URL");
|
|
const embeddedPostgresSupport = externalUrl ? { supported: true, reason: undefined } : await getEmbeddedPostgresTestSupport();
|
|
const describeEmbeddedPostgres = embeddedPostgresSupport.supported ? describe : describe.skip;
|
|
|
|
if (!embeddedPostgresSupport.supported) {
|
|
console.warn(
|
|
`Skipping embedded Postgres attention service tests on this host: ${embeddedPostgresSupport.reason ?? "unsupported environment"}`,
|
|
);
|
|
}
|
|
|
|
describeEmbeddedPostgres("attention service", () => {
|
|
let db!: ReturnType<typeof createDb>;
|
|
let tempDb: Awaited<ReturnType<typeof startEmbeddedPostgresTestDatabase>> | null = null;
|
|
|
|
beforeAll(async () => {
|
|
if (!externalUrl) tempDb = await startEmbeddedPostgresTestDatabase("paperclip-attention-service-");
|
|
db = createDb(externalUrl ?? tempDb!.connectionString);
|
|
}, 30_000);
|
|
|
|
afterEach(async () => {
|
|
await db.delete(inboxDismissals);
|
|
await db.delete(decisionArchiveNotificationOutbox);
|
|
await db.delete(decisionRetention);
|
|
await db.delete(decisionTriageEvents);
|
|
await db.delete(decisionTriage);
|
|
await db.delete(decisionQueueItems);
|
|
await db.delete(decisionQueues);
|
|
await db.delete(decisions);
|
|
await db.delete(issueThreadInteractions);
|
|
await db.delete(issueApprovals);
|
|
await db.delete(issueAttachments);
|
|
await db.delete(issueDocuments);
|
|
await db.delete(heartbeatRunEvents);
|
|
await db.delete(heartbeatRuns);
|
|
await db.delete(budgetIncidents);
|
|
await db.delete(budgetPolicies);
|
|
await db.delete(joinRequests);
|
|
await db.delete(invites);
|
|
await db.delete(issueRecoveryActions);
|
|
await db.delete(issueRelations);
|
|
await db.delete(activityLog);
|
|
await db.delete(approvals);
|
|
await db.delete(issues);
|
|
await db.delete(assets);
|
|
await db.delete(documents);
|
|
await db.delete(projectWorkspaces);
|
|
await db.delete(projects);
|
|
await db.delete(agents);
|
|
await db.delete(companies);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await db?.$client.end({ timeout: 1 });
|
|
await tempDb?.cleanup();
|
|
});
|
|
|
|
async function seedCompany(prefix = "ATN") {
|
|
const companyId = randomUUID();
|
|
const workerId = randomUUID();
|
|
const reviewerId = randomUUID();
|
|
const errorAgentId = randomUUID();
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: `${prefix} Co`,
|
|
issuePrefix: prefix,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
await db.insert(agents).values([
|
|
{
|
|
id: workerId,
|
|
companyId,
|
|
name: "Worker",
|
|
role: "engineer",
|
|
status: "idle",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: reviewerId,
|
|
companyId,
|
|
name: "Reviewer",
|
|
role: "qa",
|
|
status: "idle",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: errorAgentId,
|
|
companyId,
|
|
name: "Broken Agent",
|
|
role: "engineer",
|
|
status: "error",
|
|
errorReason: "adapter config missing",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
]);
|
|
|
|
return { companyId, workerId, reviewerId, errorAgentId, prefix };
|
|
}
|
|
|
|
async function insertIssue(input: {
|
|
companyId: string;
|
|
id?: string;
|
|
identifier: string;
|
|
title: string;
|
|
status: string;
|
|
priority?: string;
|
|
parentId?: string | null;
|
|
assigneeAgentId?: string | null;
|
|
assigneeUserId?: string | null;
|
|
originKind?: string;
|
|
originId?: string | null;
|
|
originFingerprint?: string;
|
|
projectId?: string | null;
|
|
projectWorkspaceId?: string | null;
|
|
executionState?: Record<string, unknown> | null;
|
|
updatedAt?: Date;
|
|
createdAt?: Date;
|
|
unblockDescriptor?: { owner: { userId: string } | "board"; action: string } | null;
|
|
blockedTransitionAt?: Date | null;
|
|
visibility?: "open" | "private";
|
|
privacyRootIssueId?: string | null;
|
|
responsibleUserId?: string | null;
|
|
harnessKind?: string | null;
|
|
reviewPolicy?: "anyone" | "not_creator" | "human_only" | null;
|
|
}) {
|
|
const id = input.id ?? randomUUID();
|
|
await db.insert(issues).values({
|
|
id,
|
|
companyId: input.companyId,
|
|
identifier: input.identifier,
|
|
title: input.title,
|
|
status: input.status,
|
|
priority: input.priority ?? "medium",
|
|
reviewPolicy: input.reviewPolicy ?? null,
|
|
parentId: input.parentId ?? null,
|
|
projectId: input.projectId ?? null,
|
|
projectWorkspaceId: input.projectWorkspaceId ?? null,
|
|
assigneeAgentId: input.assigneeAgentId ?? null,
|
|
assigneeUserId: input.assigneeUserId ?? null,
|
|
originKind: input.originKind ?? "manual",
|
|
originId: input.originId ?? null,
|
|
originFingerprint: input.originFingerprint ?? "default",
|
|
executionState: input.executionState ?? null,
|
|
unblockDescriptor: input.unblockDescriptor ?? null,
|
|
blockedTransitionAt: input.blockedTransitionAt ?? null,
|
|
visibility: input.visibility ?? "open",
|
|
privacyRootIssueId: input.privacyRootIssueId ?? null,
|
|
responsibleUserId: input.responsibleUserId ?? null,
|
|
harnessKind: input.harnessKind ?? null,
|
|
createdAt: input.createdAt,
|
|
updatedAt: input.updatedAt,
|
|
});
|
|
return id;
|
|
}
|
|
|
|
function pendingUserExecutionState(userId = "board-user") {
|
|
return {
|
|
status: "pending",
|
|
currentStageId: null,
|
|
currentStageIndex: null,
|
|
currentStageType: "review",
|
|
currentParticipant: { type: "user", userId },
|
|
returnAssignee: null,
|
|
reviewRequest: null,
|
|
completedStageIds: [],
|
|
lastDecisionId: null,
|
|
lastDecisionOutcome: null,
|
|
monitor: null,
|
|
};
|
|
}
|
|
|
|
function pendingAgentExecutionState(agentId: string) {
|
|
return {
|
|
...pendingUserExecutionState(),
|
|
currentParticipant: { type: "agent", agentId },
|
|
};
|
|
}
|
|
|
|
it("excludes internal harness reviews from items, counts, and decision queues", async () => {
|
|
const { companyId, workerId } = await seedCompany("ATH");
|
|
const harnessIssueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATH-1",
|
|
title: "Internal harness review",
|
|
status: "in_review",
|
|
assigneeAgentId: workerId,
|
|
harnessKind: "skill_test",
|
|
});
|
|
const queueId = randomUUID();
|
|
await db.insert(decisionQueues).values({
|
|
id: queueId,
|
|
companyId,
|
|
key: "internal-review",
|
|
title: "Internal review",
|
|
createdByType: "user",
|
|
createdByUserId: "board-user",
|
|
});
|
|
await db.insert(decisionQueueItems).values({
|
|
companyId,
|
|
queueId,
|
|
sourceKind: "review",
|
|
sourceId: harnessIssueId,
|
|
addedByType: "user",
|
|
addedByUserId: "board-user",
|
|
});
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
|
|
expect(feed.items.some((item) => item.subject.id === harnessIssueId)).toBe(false);
|
|
expect(feed.countsBySourceKind.review ?? 0).toBe(0);
|
|
expect(feed.items.flatMap((item) => item.queues).some((queue) => queue.key === "internal-review")).toBe(false);
|
|
});
|
|
|
|
it("returns ranked decision-only items for every active source and excludes non-human or transient rows", async () => {
|
|
const { companyId, workerId, reviewerId } = await seedCompany("ATN");
|
|
const baseTime = new Date("2026-07-09T12:00:00.000Z");
|
|
const interactionIssueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATN-1",
|
|
title: "Needs interaction",
|
|
status: "in_progress",
|
|
assigneeAgentId: workerId,
|
|
updatedAt: baseTime,
|
|
});
|
|
const recoverySourceIssueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATN-2",
|
|
title: "Needs recovery",
|
|
status: "in_progress",
|
|
assigneeAgentId: workerId,
|
|
updatedAt: baseTime,
|
|
});
|
|
const agentRecoverySourceIssueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATN-21",
|
|
title: "Agent-owned recovery source",
|
|
status: "in_progress",
|
|
assigneeAgentId: workerId,
|
|
updatedAt: baseTime,
|
|
});
|
|
const productivitySourceIssueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATN-3",
|
|
title: "Needs productivity review source",
|
|
status: "in_progress",
|
|
assigneeAgentId: workerId,
|
|
updatedAt: baseTime,
|
|
});
|
|
const agentProductivitySourceIssueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATN-31",
|
|
title: "Agent productivity review source",
|
|
status: "in_progress",
|
|
assigneeAgentId: workerId,
|
|
updatedAt: baseTime,
|
|
});
|
|
const blockerParentId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATN-4",
|
|
title: "Blocked parent",
|
|
status: "blocked",
|
|
blockedTransitionAt: new Date(ROUTABLE_BLOCKED_ROLLOUT_AT.getTime() + 1),
|
|
updatedAt: new Date("2026-07-09T12:04:00.000Z"),
|
|
});
|
|
const blockerLeafId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATN-5",
|
|
title: "Stalled review blocker",
|
|
status: "in_review",
|
|
assigneeAgentId: reviewerId,
|
|
// PAP-16506: the /decisions review card states who may give the verdict,
|
|
// so the subject has to carry the issue's opt-in constraint.
|
|
reviewPolicy: "human_only",
|
|
updatedAt: new Date("2026-07-09T12:05:00.000Z"),
|
|
});
|
|
await db.insert(issueRelations).values({
|
|
companyId,
|
|
issueId: blockerLeafId,
|
|
relatedIssueId: blockerParentId,
|
|
type: "blocks",
|
|
});
|
|
const reviewUserIssueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATN-6",
|
|
title: "Human review",
|
|
status: "in_review",
|
|
executionState: pendingUserExecutionState(),
|
|
updatedAt: new Date("2026-07-09T12:06:00.000Z"),
|
|
});
|
|
await insertIssue({
|
|
companyId,
|
|
identifier: "ATN-7",
|
|
title: "Agent review excluded",
|
|
status: "in_review",
|
|
executionState: pendingAgentExecutionState(reviewerId),
|
|
updatedAt: new Date("2026-07-09T12:07:00.000Z"),
|
|
});
|
|
|
|
const pendingApprovalId = randomUUID();
|
|
await db.insert(approvals).values([
|
|
{
|
|
id: pendingApprovalId,
|
|
companyId,
|
|
type: "hire_agent",
|
|
status: "pending",
|
|
payload: { title: "Hire Designer" },
|
|
createdAt: new Date("2026-07-09T12:01:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:01:00.000Z"),
|
|
},
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
type: "hire_agent",
|
|
status: "revision_requested",
|
|
payload: { title: "Revision requested" },
|
|
createdAt: new Date("2026-07-09T12:02:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:02:00.000Z"),
|
|
},
|
|
]);
|
|
|
|
await db.insert(issueThreadInteractions).values([
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
issueId: interactionIssueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
title: "Pick a launch date",
|
|
payload: { version: 1, questions: [] },
|
|
createdAt: new Date("2026-07-09T12:03:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:03:00.000Z"),
|
|
},
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
issueId: interactionIssueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
addresseeAgentId: reviewerId,
|
|
title: "Ask the reviewer privately",
|
|
payload: { version: 1, questions: [] },
|
|
createdAt: new Date("2026-07-09T12:03:15.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:03:15.000Z"),
|
|
},
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
issueId: interactionIssueId,
|
|
kind: "request_confirmation",
|
|
status: "accepted",
|
|
continuationPolicy: "wake_assignee",
|
|
title: "Already accepted",
|
|
payload: { version: 1, prompt: "Already done" },
|
|
createdAt: new Date("2026-07-09T12:03:30.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:03:30.000Z"),
|
|
},
|
|
]);
|
|
|
|
const inviteId = randomUUID();
|
|
await db.insert(invites).values({
|
|
id: inviteId,
|
|
companyId,
|
|
tokenHash: `hash-${inviteId}`,
|
|
allowedJoinTypes: "both",
|
|
expiresAt: new Date("2026-07-10T00:00:00.000Z"),
|
|
});
|
|
await db.insert(joinRequests).values({
|
|
id: randomUUID(),
|
|
inviteId,
|
|
companyId,
|
|
requestType: "human",
|
|
status: "pending_approval",
|
|
requestIp: "127.0.0.1",
|
|
requestEmailSnapshot: "new@paperclip.test",
|
|
createdAt: new Date("2026-07-09T12:04:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:04:00.000Z"),
|
|
});
|
|
|
|
await db.insert(issueRecoveryActions).values([
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
sourceIssueId: recoverySourceIssueId,
|
|
kind: "missing_disposition",
|
|
status: "escalated",
|
|
ownerType: "board",
|
|
ownerAgentId: null,
|
|
ownerUserId: null,
|
|
cause: "missing_disposition",
|
|
fingerprint: "human-recovery",
|
|
evidence: {},
|
|
nextAction: "Choose the final disposition.",
|
|
createdAt: new Date("2026-07-09T12:05:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:05:00.000Z"),
|
|
},
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
sourceIssueId: agentRecoverySourceIssueId,
|
|
kind: "stranded_assigned_issue",
|
|
status: "active",
|
|
ownerType: "agent",
|
|
ownerAgentId: workerId,
|
|
ownerUserId: null,
|
|
cause: "stranded",
|
|
fingerprint: "agent-recovery",
|
|
evidence: {},
|
|
nextAction: "Agent should self-heal.",
|
|
createdAt: new Date("2026-07-09T12:05:30.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:05:30.000Z"),
|
|
},
|
|
]);
|
|
|
|
await insertIssue({
|
|
companyId,
|
|
identifier: "ATN-8",
|
|
title: "Human productivity review",
|
|
status: "todo",
|
|
priority: "high",
|
|
parentId: productivitySourceIssueId,
|
|
assigneeUserId: "board-user",
|
|
originKind: "issue_productivity_review",
|
|
originId: productivitySourceIssueId,
|
|
originFingerprint: `productivity-review:${productivitySourceIssueId}`,
|
|
updatedAt: new Date("2026-07-09T12:08:00.000Z"),
|
|
});
|
|
await insertIssue({
|
|
companyId,
|
|
identifier: "ATN-9",
|
|
title: "Agent productivity review excluded",
|
|
status: "todo",
|
|
priority: "high",
|
|
parentId: agentProductivitySourceIssueId,
|
|
assigneeAgentId: workerId,
|
|
originKind: "issue_productivity_review",
|
|
originId: agentProductivitySourceIssueId,
|
|
originFingerprint: `productivity-review-agent:${agentProductivitySourceIssueId}`,
|
|
updatedAt: new Date("2026-07-09T12:08:30.000Z"),
|
|
});
|
|
|
|
const exhaustedRunId = randomUUID();
|
|
const transientRunId = randomUUID();
|
|
await db.insert(heartbeatRuns).values([
|
|
{
|
|
id: exhaustedRunId,
|
|
companyId,
|
|
agentId: workerId,
|
|
invocationSource: "automation",
|
|
status: "failed",
|
|
error: "adapter failed",
|
|
errorCode: "adapter_failed",
|
|
contextSnapshot: { issueId: reviewUserIssueId },
|
|
scheduledRetryAttempt: 4,
|
|
scheduledRetryReason: "transient_failure",
|
|
createdAt: new Date("2026-07-09T12:09:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:09:00.000Z"),
|
|
finishedAt: new Date("2026-07-09T12:09:00.000Z"),
|
|
},
|
|
{
|
|
id: transientRunId,
|
|
companyId,
|
|
agentId: reviewerId,
|
|
invocationSource: "automation",
|
|
status: "failed",
|
|
error: "will retry",
|
|
errorCode: "provider_quota",
|
|
contextSnapshot: { issueId: interactionIssueId },
|
|
createdAt: new Date("2026-07-09T12:09:30.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:09:30.000Z"),
|
|
finishedAt: new Date("2026-07-09T12:09:30.000Z"),
|
|
},
|
|
]);
|
|
await db.insert(heartbeatRunEvents).values({
|
|
companyId,
|
|
runId: exhaustedRunId,
|
|
agentId: workerId,
|
|
seq: 1,
|
|
eventType: "lifecycle",
|
|
message: "Bounded retry exhausted after 4 scheduled attempts; no further automatic retry will be queued",
|
|
payload: { retryReason: "transient_failure", maxAttempts: 4 },
|
|
createdAt: new Date("2026-07-09T12:09:01.000Z"),
|
|
});
|
|
|
|
const softPolicy85Id = randomUUID();
|
|
const softPolicy84Id = randomUUID();
|
|
const hardPolicyId = randomUUID();
|
|
await db.insert(budgetPolicies).values([
|
|
{
|
|
id: softPolicy85Id,
|
|
companyId,
|
|
scopeType: "company",
|
|
scopeId: companyId,
|
|
metric: "billed_cents",
|
|
windowKind: "calendar_month_utc",
|
|
amount: 100,
|
|
},
|
|
{
|
|
id: softPolicy84Id,
|
|
companyId,
|
|
scopeType: "company",
|
|
scopeId: companyId,
|
|
metric: "billed_cents",
|
|
windowKind: "lifetime",
|
|
amount: 100,
|
|
},
|
|
{
|
|
id: hardPolicyId,
|
|
companyId,
|
|
scopeType: "agent",
|
|
scopeId: workerId,
|
|
metric: "billed_cents",
|
|
windowKind: "calendar_month_utc",
|
|
amount: 100,
|
|
},
|
|
]);
|
|
await db.insert(budgetIncidents).values([
|
|
{
|
|
companyId,
|
|
policyId: softPolicy85Id,
|
|
scopeType: "company",
|
|
scopeId: companyId,
|
|
metric: "billed_cents",
|
|
windowKind: "calendar_month_utc",
|
|
windowStart: new Date("2026-07-01T00:00:00.000Z"),
|
|
windowEnd: new Date("2026-08-01T00:00:00.000Z"),
|
|
thresholdType: "soft",
|
|
amountLimit: 100,
|
|
amountObserved: 85,
|
|
status: "open",
|
|
createdAt: new Date("2026-07-09T12:10:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:10:00.000Z"),
|
|
},
|
|
{
|
|
companyId,
|
|
policyId: softPolicy84Id,
|
|
scopeType: "company",
|
|
scopeId: companyId,
|
|
metric: "billed_cents",
|
|
windowKind: "lifetime",
|
|
windowStart: new Date("1970-01-01T00:00:00.000Z"),
|
|
windowEnd: new Date("9999-01-01T00:00:00.000Z"),
|
|
thresholdType: "soft",
|
|
amountLimit: 100,
|
|
amountObserved: 84,
|
|
status: "open",
|
|
createdAt: new Date("2026-07-09T12:10:30.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:10:30.000Z"),
|
|
},
|
|
{
|
|
companyId,
|
|
policyId: hardPolicyId,
|
|
scopeType: "agent",
|
|
scopeId: workerId,
|
|
metric: "billed_cents",
|
|
windowKind: "calendar_month_utc",
|
|
windowStart: new Date("2026-07-01T00:00:00.000Z"),
|
|
windowEnd: new Date("2026-08-01T00:00:00.000Z"),
|
|
thresholdType: "hard",
|
|
amountLimit: 100,
|
|
amountObserved: 100,
|
|
status: "open",
|
|
createdAt: new Date("2026-07-09T12:11:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:11:00.000Z"),
|
|
},
|
|
]);
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
|
|
expect(feed.totalCount).toBe(11);
|
|
expect(feed.countsBySourceKind).toMatchObject({
|
|
approval: 1,
|
|
issue_thread_interaction: 1,
|
|
join_request: 1,
|
|
recovery_action: 1,
|
|
productivity_review: 0,
|
|
blocker_attention: 1,
|
|
review: 2,
|
|
failed_run: 1,
|
|
budget_alert: 2,
|
|
agent_error_alert: 1,
|
|
});
|
|
expect(feed.items.map((item) => item.sourceKind)).toEqual(expect.arrayContaining([
|
|
"approval",
|
|
"issue_thread_interaction",
|
|
"join_request",
|
|
"recovery_action",
|
|
"blocker_attention",
|
|
"review",
|
|
"failed_run",
|
|
"budget_alert",
|
|
"agent_error_alert",
|
|
]));
|
|
for (const item of feed.items) {
|
|
expect(item.dedupKey).toBeTruthy();
|
|
expect(item.dismissalKey).toBe(`attention:${item.dedupKey}`);
|
|
expect(item.whyNow).toBeTruthy();
|
|
expect(item.entryRule).toBeTruthy();
|
|
expect(item.exitRule).toBeTruthy();
|
|
expect(item.decisionVerbs.length).toBeGreaterThan(0);
|
|
expect(item.rank).toBeGreaterThan(0);
|
|
}
|
|
expect(feed.items.some((item) => item.subject.title === "Revision requested")).toBe(false);
|
|
expect(feed.items.some((item) => item.sourceKind === "productivity_review")).toBe(false);
|
|
expect(feed.items.some((item) => item.subject.title === "Agent productivity review excluded")).toBe(false);
|
|
const legacyReviews = await db.select().from(issues).where(eq(issues.originKind, "issue_productivity_review"));
|
|
expect(legacyReviews).toHaveLength(2);
|
|
expect(legacyReviews).toEqual(expect.arrayContaining([
|
|
expect.objectContaining({ title: "Human productivity review", status: "todo", assigneeUserId: "board-user", parentId: productivitySourceIssueId }),
|
|
expect.objectContaining({ title: "Agent productivity review excluded", status: "todo", assigneeAgentId: workerId, parentId: agentProductivitySourceIssueId }),
|
|
]));
|
|
expect(feed.items.some((item) => item.subject.title === "Agent review excluded")).toBe(false);
|
|
expect(feed.items.some((item) =>
|
|
item.sourceKind === "failed_run" && item.subject.metadata?.errorCode === "provider_quota"
|
|
)).toBe(false);
|
|
expect(feed.items.find((item) => item.sourceKind === "approval")?.detail).toMatchObject({
|
|
kind: "approval",
|
|
approvalType: "hire_agent",
|
|
summaryExcerpt: "Hire Designer",
|
|
});
|
|
expect(feed.items.find((item) => item.sourceKind === "issue_thread_interaction")?.detail).toMatchObject({
|
|
kind: "questions",
|
|
questionCount: 0,
|
|
});
|
|
expect(feed.items.find((item) => item.sourceKind === "blocker_attention")?.detail).toMatchObject({
|
|
kind: "blocker",
|
|
blockingIssue: null,
|
|
blockedTaskCount: 1,
|
|
});
|
|
expect(feed.items.find((item) => item.sourceKind === "blocker_attention")?.subject.id).toBe(blockerLeafId);
|
|
expect(feed.items.find((item) =>
|
|
item.sourceKind === "review" && item.subject.title === "Stalled review blocker"
|
|
)).toMatchObject({
|
|
whyNow: expect.stringContaining("without a maintained"),
|
|
// A stalled review resolves in-row on the /decisions card (PAP-16080 §4.4).
|
|
inlineResolvable: true,
|
|
subject: expect.objectContaining({
|
|
metadata: expect.objectContaining({
|
|
reviewAttentionState: "stalled",
|
|
reviewPolicy: "human_only",
|
|
}),
|
|
}),
|
|
decisionVerbs: expect.arrayContaining([
|
|
expect.objectContaining({ id: "choose_review_path", label: "Choose review path" }),
|
|
]),
|
|
});
|
|
expect(feed.items.find((item) => item.sourceKind === "failed_run")?.detail).toMatchObject({
|
|
kind: "failed_run",
|
|
agentName: "Worker",
|
|
failureReasonExcerpt: "adapter failed",
|
|
});
|
|
expect(feed.items.find((item) =>
|
|
item.sourceKind === "budget_alert" && item.detail?.kind === "budget" && item.detail.observedPercent === 100
|
|
)).toBeTruthy();
|
|
expect(feed.items.find((item) => item.sourceKind === "agent_error_alert")?.detail).toMatchObject({
|
|
kind: "agent_error",
|
|
agentName: "Broken Agent",
|
|
failureReasonExcerpt: "adapter config missing",
|
|
});
|
|
});
|
|
|
|
it("returns addressed interactions to board attention after addressee pause or termination", async () => {
|
|
const { companyId, reviewerId } = await seedCompany("ATF");
|
|
const pausedReviewerId = randomUUID();
|
|
const terminatedReviewerId = randomUUID();
|
|
await db.insert(agents).values([
|
|
{
|
|
id: pausedReviewerId,
|
|
companyId,
|
|
name: "Paused Reviewer",
|
|
role: "qa",
|
|
status: "active",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
{
|
|
id: terminatedReviewerId,
|
|
companyId,
|
|
name: "Terminated Reviewer",
|
|
role: "qa",
|
|
status: "active",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
},
|
|
]);
|
|
const issueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATF-1",
|
|
title: "Needs a decision",
|
|
status: "in_progress",
|
|
});
|
|
await db.insert(issueThreadInteractions).values([
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
issueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
title: "Board question",
|
|
payload: { version: 1, questions: [] },
|
|
},
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
issueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
addresseeAgentId: reviewerId,
|
|
title: "Active reviewer question",
|
|
payload: { version: 1, questions: [] },
|
|
},
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
issueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
addresseeAgentId: pausedReviewerId,
|
|
title: "Paused reviewer question",
|
|
payload: { version: 1, questions: [] },
|
|
},
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
issueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
addresseeAgentId: terminatedReviewerId,
|
|
title: "Terminated reviewer question",
|
|
payload: { version: 1, questions: [] },
|
|
},
|
|
]);
|
|
|
|
await createAgentLifecycle(db).pauseAgent(pausedReviewerId);
|
|
await createAgentLifecycle(db).terminateAgent(terminatedReviewerId);
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
const interactionTitles = feed.items
|
|
.filter((item) => item.sourceKind === "issue_thread_interaction")
|
|
.map((item) => item.subject.title);
|
|
|
|
expect(interactionTitles).toEqual(expect.arrayContaining([
|
|
"Board question",
|
|
"Paused reviewer question",
|
|
"Terminated reviewer question",
|
|
]));
|
|
expect(interactionTitles).not.toContain("Active reviewer question");
|
|
});
|
|
|
|
// PAP-17287: a collapsed queue row offers Accept/Reject before anything fetches
|
|
// the interaction, so the audience the resolution routes will enforce has to
|
|
// ship with the feed item.
|
|
it("ships the effective resolver audience with each interaction row", async () => {
|
|
const { companyId, workerId, reviewerId } = await seedCompany("ARA");
|
|
const issueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ARA-1",
|
|
title: "Needs a decision",
|
|
status: "in_progress",
|
|
});
|
|
await db.insert(issueThreadInteractions).values([
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
issueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
title: "Open question",
|
|
createdByAgentId: workerId,
|
|
payload: { version: 1, questions: [] },
|
|
},
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
issueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
title: "Creator-excluded question",
|
|
createdByAgentId: workerId,
|
|
requestedResolverPolicy: "not_creator",
|
|
effectiveResolverPolicy: "not_creator",
|
|
resolverPolicyProvenance: "explicit",
|
|
payload: { version: 1, questions: [] },
|
|
},
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
issueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
title: "Capped question",
|
|
createdByAgentId: workerId,
|
|
requestedResolverPolicy: "anyone",
|
|
effectiveResolverPolicy: "human_only",
|
|
effectiveResolverPolicySource: "company_cap",
|
|
payload: { version: 1, questions: [] },
|
|
},
|
|
]);
|
|
// An addressed card only reaches board attention once its addressee cannot
|
|
// act, which is exactly when naming the addressee matters most.
|
|
await db.insert(issueThreadInteractions).values({
|
|
id: randomUUID(),
|
|
companyId,
|
|
issueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
title: "Addressed question",
|
|
createdByAgentId: workerId,
|
|
addresseeAgentId: reviewerId,
|
|
payload: { version: 1, questions: [] },
|
|
});
|
|
await db.insert(issueThreadInteractions).values({
|
|
id: randomUUID(),
|
|
companyId,
|
|
issueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
title: "User-addressed question",
|
|
createdByAgentId: workerId,
|
|
addresseeUserId: "board-user",
|
|
requestedResolverPolicy: "human_only",
|
|
effectiveResolverPolicy: "human_only",
|
|
payload: { version: 1, questions: [] },
|
|
});
|
|
await createAgentLifecycle(db).pauseAgent(reviewerId);
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
const otherUserFeed = await attentionService(db).list(companyId, { userId: "other-user" });
|
|
const audienceByTitle = new Map(feed.items
|
|
.filter((item) => item.sourceKind === "issue_thread_interaction")
|
|
.map((item) => [item.subject.title, item.resolverAudience]));
|
|
|
|
expect(audienceByTitle.get("Open question")).toMatchObject({
|
|
requestedResolverPolicy: "anyone",
|
|
effectiveResolverPolicy: "anyone",
|
|
effectiveResolverPolicySource: "requested",
|
|
addresseeAgentId: null,
|
|
addresseeName: null,
|
|
});
|
|
expect(audienceByTitle.get("Creator-excluded question")).toMatchObject({
|
|
effectiveResolverPolicy: "not_creator",
|
|
createdByAgentId: workerId,
|
|
createdByAgentName: "Worker",
|
|
});
|
|
expect(audienceByTitle.get("Capped question")).toMatchObject({
|
|
requestedResolverPolicy: "anyone",
|
|
effectiveResolverPolicy: "human_only",
|
|
effectiveResolverPolicySource: "company_cap",
|
|
});
|
|
expect(audienceByTitle.get("Addressed question")).toMatchObject({
|
|
addresseeAgentId: reviewerId,
|
|
addresseeName: "Reviewer",
|
|
});
|
|
expect(audienceByTitle.get("User-addressed question")).toMatchObject({
|
|
addresseeUserId: "board-user",
|
|
effectiveResolverPolicy: "human_only",
|
|
});
|
|
expect(otherUserFeed.items.some((item) => item.subject.title === "User-addressed question")).toBe(false);
|
|
// Non-interaction rows carry no resolver policy at all.
|
|
expect(feed.items.find((item) => item.sourceKind !== "issue_thread_interaction")?.resolverAudience)
|
|
.toBeNull();
|
|
});
|
|
|
|
it("reads one compact row per exhausted run despite thousands of historical receipts", async () => {
|
|
const { companyId, workerId, reviewerId } = await seedCompany("MEM");
|
|
const other = await seedCompany("OTH");
|
|
await db.update(agents).set({ status: "terminated" }).where(eq(agents.id, reviewerId));
|
|
const issueId = await insertIssue({
|
|
companyId, identifier: "MEM-1", title: "Failed task", status: "in_progress",
|
|
});
|
|
const taskId = await insertIssue({
|
|
companyId, identifier: "MEM-2", title: "Timed out task", status: "in_progress",
|
|
});
|
|
const [failedId, timedOutId, succeededId, terminatedId, foreignId, noReceiptId] =
|
|
Array.from({ length: 6 }, () => randomUUID());
|
|
const createdAt = new Date("2026-07-09T12:00:00.000Z");
|
|
await db.insert(heartbeatRuns).values([
|
|
{ id: failedId, companyId, agentId: workerId, status: "failed", contextSnapshot: { issueId, prompt: "x".repeat(32_000) } },
|
|
{ id: timedOutId, companyId, agentId: workerId, status: "timed_out", contextSnapshot: { taskId, prompt: "y".repeat(32_000) } },
|
|
{ id: succeededId, companyId, agentId: workerId, status: "succeeded" },
|
|
{ id: terminatedId, companyId, agentId: reviewerId, status: "failed" },
|
|
{ id: foreignId, companyId: other.companyId, agentId: other.workerId, status: "failed" },
|
|
{ id: noReceiptId, companyId, agentId: workerId, status: "failed" },
|
|
].map((run) => ({ ...run, createdAt, updatedAt: createdAt, finishedAt: createdAt })));
|
|
for (let batch = 0; batch < 5; batch += 1) {
|
|
await db.insert(heartbeatRunEvents).values(Array.from({ length: 500 }, (_, index) => ({
|
|
companyId, agentId: workerId, runId: failedId, seq: batch * 500 + index + 1,
|
|
eventType: "lifecycle", message: `Bounded retry exhausted receipt ${batch * 500 + index + 1}`,
|
|
})));
|
|
}
|
|
await db.insert(heartbeatRunEvents).values([
|
|
{ companyId, agentId: workerId, runId: timedOutId, seq: 1, eventType: "lifecycle", message: "Bounded retry exhausted timeout" },
|
|
{ companyId, agentId: workerId, runId: succeededId, seq: 1, eventType: "lifecycle", message: "Bounded retry exhausted success" },
|
|
{ companyId, agentId: reviewerId, runId: terminatedId, seq: 1, eventType: "lifecycle", message: "Bounded retry exhausted terminated" },
|
|
{ companyId: other.companyId, agentId: other.workerId, runId: foreignId, seq: 1, eventType: "lifecycle", message: "Bounded retry exhausted other company" },
|
|
// A newer event must not replace the latest matching, company-scoped receipt.
|
|
{ companyId: other.companyId, agentId: other.workerId, runId: failedId, seq: 2501, eventType: "lifecycle", message: "Bounded retry exhausted foreign receipt" },
|
|
{ companyId, agentId: workerId, runId: failedId, seq: 2502, eventType: "stdout", message: "Bounded retry exhausted quoted output" },
|
|
{ companyId, agentId: workerId, runId: failedId, seq: 2503, eventType: "lifecycle", message: "Unrelated lifecycle event" },
|
|
]);
|
|
|
|
// Assert the database result itself: JavaScript feed deduplication used to
|
|
// hide the thousands of full run contexts already loaded into memory.
|
|
const rows = await listAttentionExhaustedRuns(db, companyId);
|
|
expect(rows).toHaveLength(2);
|
|
expect(rows.find((row) => row.id === failedId)).toMatchObject({
|
|
exhaustionMessage: "Bounded retry exhausted receipt 2500",
|
|
contextSnapshot: { issueId, taskId: null },
|
|
});
|
|
expect(rows.find((row) => row.id === timedOutId)?.contextSnapshot).toEqual({ issueId: null, taskId });
|
|
expect(Buffer.byteLength(JSON.stringify(rows))).toBeLessThan(4096);
|
|
|
|
const feed = await attentionService(db).list(companyId, {
|
|
includeDismissed: true, all: true, allowUnscopedAll: true,
|
|
});
|
|
const failures = feed.items.filter((item) => item.sourceKind === "failed_run");
|
|
expect(failures.map((item) => item.subject.id).sort()).toEqual([failedId, timedOutId].sort());
|
|
expect(failures.find((item) => item.subject.id === timedOutId)?.relatedIssue?.id).toBe(taskId);
|
|
});
|
|
|
|
it("suppresses failed-run attention after a newer run for the same issue", async () => {
|
|
const { companyId, workerId } = await seedCompany("ATN");
|
|
const issueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATN-1",
|
|
title: "Recoverable task",
|
|
status: "in_progress",
|
|
});
|
|
const failedRunId = randomUUID();
|
|
const failedAt = new Date("2026-07-09T12:00:00.000Z");
|
|
|
|
await db.insert(heartbeatRuns).values([
|
|
{
|
|
id: failedRunId,
|
|
companyId,
|
|
agentId: workerId,
|
|
invocationSource: "automation",
|
|
status: "failed",
|
|
error: "adapter failed",
|
|
contextSnapshot: { issueId },
|
|
createdAt: failedAt,
|
|
updatedAt: failedAt,
|
|
finishedAt: failedAt,
|
|
},
|
|
{
|
|
id: randomUUID(),
|
|
companyId,
|
|
agentId: workerId,
|
|
invocationSource: "automation",
|
|
status: "succeeded",
|
|
contextSnapshot: { issueId },
|
|
createdAt: new Date("2026-07-09T12:01:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:01:00.000Z"),
|
|
finishedAt: new Date("2026-07-09T12:01:00.000Z"),
|
|
},
|
|
]);
|
|
await db.insert(heartbeatRunEvents).values({
|
|
companyId,
|
|
runId: failedRunId,
|
|
agentId: workerId,
|
|
seq: 1,
|
|
eventType: "lifecycle",
|
|
message: "Bounded retry exhausted after 4 scheduled attempts; no further automatic retry will be queued",
|
|
createdAt: new Date("2026-07-09T12:00:01.000Z"),
|
|
});
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
|
|
expect(feed.items.filter((item) => item.sourceKind === "failed_run")).toEqual([]);
|
|
});
|
|
|
|
it("hides a failed run only after a newer run of the same agent on the same issue or task", async () => {
|
|
const { companyId, workerId, reviewerId } = await seedCompany("ATK");
|
|
const taskIssueId = await insertIssue({ companyId, identifier: "ATK-1", title: "Task-keyed", status: "in_progress" });
|
|
const issueKeyedId = await insertIssue({ companyId, identifier: "ATK-2", title: "Issue-keyed", status: "in_progress" });
|
|
const otherIssueId = await insertIssue({ companyId, identifier: "ATK-3", title: "Other work", status: "in_progress" });
|
|
const failedAt = new Date("2026-07-09T12:00:00.000Z");
|
|
const laterAt = new Date("2026-07-09T12:01:00.000Z");
|
|
const taskKeyedFailureId = randomUUID();
|
|
const issueKeyedFailureId = randomUUID();
|
|
const unkeyedHiddenFailureId = randomUUID();
|
|
const unkeyedKeptFailureId = randomUUID();
|
|
const failureIds = [taskKeyedFailureId, issueKeyedFailureId, unkeyedHiddenFailureId, unkeyedKeptFailureId];
|
|
const sameMillisecondRunId = randomUUID();
|
|
const run = (id: string, agentId: string, status: string, contextSnapshot: Record<string, unknown>, at: Date) => ({
|
|
id, companyId, agentId, invocationSource: "automation", status, contextSnapshot,
|
|
createdAt: at, updatedAt: at, finishedAt: at, ...(status === "failed" ? { error: "adapter failed" } : {}),
|
|
});
|
|
|
|
await db.insert(heartbeatRuns).values([
|
|
run(taskKeyedFailureId, workerId, "failed", { taskId: taskIssueId }, failedAt),
|
|
run(issueKeyedFailureId, workerId, "failed", { issueId: issueKeyedId }, failedAt),
|
|
run(unkeyedHiddenFailureId, workerId, "failed", {}, failedAt),
|
|
run(unkeyedKeptFailureId, reviewerId, "failed", {}, failedAt),
|
|
run(randomUUID(), workerId, "succeeded", { taskId: taskIssueId }, laterAt),
|
|
run(randomUUID(), workerId, "succeeded", { wakeReason: "timer" }, laterAt),
|
|
run(randomUUID(), reviewerId, "succeeded", { issueId: issueKeyedId }, laterAt),
|
|
run(randomUUID(), reviewerId, "succeeded", { issueId: otherIssueId }, laterAt),
|
|
run(randomUUID(), workerId, "succeeded", { issueId: otherIssueId }, laterAt),
|
|
run(randomUUID(), workerId, "succeeded", { issueId: otherIssueId, taskId: issueKeyedId }, laterAt),
|
|
run(randomUUID(), workerId, "succeeded", { issueId: "", taskId: issueKeyedId }, laterAt),
|
|
run(sameMillisecondRunId, workerId, "succeeded", { issueId: issueKeyedId }, failedAt),
|
|
run(randomUUID(), workerId, "succeeded", { issueId: issueKeyedId }, new Date("2026-07-09T11:59:00.000Z")),
|
|
]);
|
|
await db.execute(sql`update heartbeat_runs set created_at = created_at + interval '400 microseconds'
|
|
where id in (${sql.join(failureIds.map((id) => sql`${id}::uuid`), sql`, `)})`);
|
|
await db.execute(sql`update heartbeat_runs set created_at = created_at + interval '600 microseconds'
|
|
where id = ${sameMillisecondRunId}::uuid`);
|
|
await db.insert(heartbeatRunEvents).values(
|
|
failureIds.map((runId) => ({
|
|
companyId,
|
|
runId,
|
|
agentId: runId === unkeyedKeptFailureId ? reviewerId : workerId,
|
|
seq: 1,
|
|
eventType: "lifecycle",
|
|
message: "Bounded retry exhausted after 4 scheduled attempts; no further automatic retry will be queued",
|
|
createdAt: new Date("2026-07-09T12:00:01.000Z"),
|
|
})),
|
|
);
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
|
|
expect(feed.items.filter((item) => item.sourceKind === "failed_run").map((item) => item.subject.id).sort())
|
|
.toEqual([issueKeyedFailureId, unkeyedKeptFailureId].sort());
|
|
});
|
|
|
|
it("keeps newer-run response size bounded despite unrelated retained history", async () => {
|
|
const { companyId, workerId } = await seedCompany("ATW");
|
|
const issueId = await insertIssue({ companyId, identifier: "ATW-1", title: "Exhausted task", status: "in_progress" });
|
|
const otherIssueId = await insertIssue({ companyId, identifier: "ATW-2", title: "Other task", status: "done" });
|
|
const failedId = randomUUID(), failedAt = new Date("2026-07-09T12:00:00.000Z");
|
|
await db.insert(heartbeatRuns).values({
|
|
id: failedId, companyId, agentId: workerId, status: "failed", contextSnapshot: { issueId },
|
|
createdAt: failedAt, updatedAt: failedAt, finishedAt: failedAt,
|
|
});
|
|
await db.insert(heartbeatRunEvents).values({
|
|
companyId, agentId: workerId, runId: failedId, seq: 1, eventType: "lifecycle",
|
|
message: "Bounded retry exhausted after scheduled attempts",
|
|
});
|
|
for (let batch = 0; batch < 4; batch += 1) {
|
|
await db.insert(heartbeatRuns).values(Array.from({ length: 500 }, (_, index) => ({
|
|
id: randomUUID(), companyId, agentId: workerId, status: "succeeded",
|
|
contextSnapshot: { issueId: otherIssueId, prompt: "x".repeat(8_000) },
|
|
createdAt: new Date(failedAt.getTime() + batch * 500 + index + 1),
|
|
updatedAt: failedAt, finishedAt: failedAt,
|
|
})));
|
|
}
|
|
const events: Array<Record<string, unknown>> = [], now = Date.now();
|
|
const capture = createDatabaseResponseCapture({ start: now - 100, end: now + 59_000 }, event => events.push(event));
|
|
installDatabaseResponseCapture(db, { heartbeatRuns }, capture);
|
|
try {
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
expect(feed.items.filter(item => item.sourceKind === "failed_run").map(item => item.subject.id)).toEqual([failedId]);
|
|
} finally { capture.flush(); }
|
|
const reads = events.filter(event => event.event === "paperclip.db_response_capture.entry.v1"
|
|
&& event.table === "heartbeat_runs" && (event.operation === "select" || event.operation === "execute"));
|
|
expect(reads.reduce((sum, event) => sum + Number(event.calls), 0)).toBeGreaterThan(0);
|
|
expect(reads.reduce((sum, event) => sum + Number(event.rows), 0)).toBeLessThan(64);
|
|
expect(reads.reduce((sum, event) => sum + Number(event.responseValueBytes), 0)).toBeLessThan(4096);
|
|
expect(reads.filter(event => event.operation === "execute")
|
|
.reduce((sum, event) => sum + Number(event.calls), 0)).toBeGreaterThan(0);
|
|
const [remaining] = await db.select({ count: sql<number>`count(*)::int` }).from(heartbeatRuns)
|
|
.where(eq(heartbeatRuns.companyId, companyId));
|
|
expect(remaining?.count).toBe(2001);
|
|
});
|
|
|
|
it("reads keyless history once per agent despite thousands of failures", async () => {
|
|
const { companyId, workerId, reviewerId } = await seedCompany("ATB");
|
|
const failedAt = new Date("2026-07-09T12:00:00.000Z");
|
|
const laterAt = new Date("2026-07-09T12:01:00.000Z");
|
|
const hiddenIds = Array.from({ length: 16_390 }, () => randomUUID());
|
|
const keptIds = Array.from({ length: 10 }, () => randomUUID());
|
|
const failure = (id: string, agentId: string) => ({
|
|
id, companyId, agentId, invocationSource: "automation", status: "failed", error: "adapter failed",
|
|
contextSnapshot: {}, createdAt: failedAt, updatedAt: failedAt, finishedAt: failedAt,
|
|
});
|
|
const failures = hiddenIds.map((id) => failure(id, workerId));
|
|
keptIds.forEach((id, index) => failures.splice(index * 1_700, 0, failure(id, reviewerId)));
|
|
for (let start = 0; start < failures.length; start += 1_000) {
|
|
const chunk = failures.slice(start, start + 1_000);
|
|
await db.insert(heartbeatRuns).values(chunk);
|
|
await db.insert(heartbeatRunEvents).values(chunk.map((run) => ({
|
|
companyId, runId: run.id, agentId: run.agentId, seq: 1, eventType: "lifecycle",
|
|
message: "Bounded retry exhausted after 4 scheduled attempts; no further automatic retry will be queued",
|
|
createdAt: new Date("2026-07-09T12:00:01.000Z"),
|
|
})));
|
|
}
|
|
await db.insert(heartbeatRuns).values({
|
|
id: randomUUID(), companyId, agentId: workerId, invocationSource: "automation", status: "succeeded",
|
|
contextSnapshot: { wakeReason: "timer" }, createdAt: laterAt, updatedAt: laterAt, finishedAt: laterAt,
|
|
});
|
|
|
|
const events: Array<Record<string, unknown>> = [], now = Date.now();
|
|
const capture = createDatabaseResponseCapture({ start: now - 100, end: now + 59_000 }, event => events.push(event));
|
|
installDatabaseResponseCapture(db, { heartbeatRuns }, capture);
|
|
try {
|
|
const feed = await attentionService(db).list(companyId, {
|
|
includeDismissed: true, all: true, allowUnscopedAll: true,
|
|
});
|
|
expect(feed.items.filter((item) => item.sourceKind === "failed_run").map((item) => item.subject.id).sort())
|
|
.toEqual([...keptIds].sort());
|
|
} finally { capture.flush(); }
|
|
const reads = events.filter(event => event.event === "paperclip.db_response_capture.entry.v1"
|
|
&& event.table === "heartbeat_runs" && (event.operation === "select" || event.operation === "execute"));
|
|
expect(reads.reduce((sum, event) => sum + Number(event.calls), 0)).toBeGreaterThan(0);
|
|
expect(reads.reduce((sum, event) => sum + Number(event.calls), 0)).toBeLessThan(4);
|
|
}, 180_000);
|
|
|
|
it("checks more failed runs for a newer run than one statement can bind", async () => {
|
|
const { companyId, workerId, reviewerId } = await seedCompany("ATQ");
|
|
const issueId = await insertIssue({ companyId, identifier: "ATQ-1", title: "Keyed retained failures", status: "in_progress" });
|
|
const failedAt = new Date("2026-07-09T12:00:00.000Z");
|
|
const laterAt = new Date("2026-07-09T12:01:00.000Z");
|
|
const hiddenIds = Array.from({ length: 16_390 }, () => randomUUID());
|
|
const keptIds = Array.from({ length: 10 }, () => randomUUID());
|
|
const failure = (id: string, agentId: string) => ({
|
|
id, companyId, agentId, invocationSource: "automation", status: "failed", error: "adapter failed",
|
|
contextSnapshot: { issueId }, createdAt: failedAt, updatedAt: failedAt, finishedAt: failedAt,
|
|
});
|
|
const failures = hiddenIds.map((id) => failure(id, workerId));
|
|
keptIds.forEach((id, index) => failures.splice(index * 1_700, 0, failure(id, reviewerId)));
|
|
for (let start = 0; start < failures.length; start += 1_000) {
|
|
const chunk = failures.slice(start, start + 1_000);
|
|
await db.insert(heartbeatRuns).values(chunk);
|
|
await db.insert(heartbeatRunEvents).values(chunk.map((run) => ({
|
|
companyId, runId: run.id, agentId: run.agentId, seq: 1, eventType: "lifecycle",
|
|
message: "Bounded retry exhausted after 4 scheduled attempts; no further automatic retry will be queued",
|
|
createdAt: new Date("2026-07-09T12:00:01.000Z"),
|
|
})));
|
|
}
|
|
await db.insert(heartbeatRuns).values({
|
|
id: randomUUID(), companyId, agentId: workerId, invocationSource: "automation", status: "succeeded",
|
|
contextSnapshot: { issueId }, createdAt: laterAt, updatedAt: laterAt, finishedAt: laterAt,
|
|
});
|
|
|
|
const feed = await attentionService(db).list(companyId, {
|
|
includeDismissed: true, all: true, allowUnscopedAll: true,
|
|
});
|
|
expect(feed.items.filter(item => item.sourceKind === "failed_run").map(item => item.subject.id).sort())
|
|
.toEqual([...keptIds].sort());
|
|
}, 180_000);
|
|
|
|
it("enriches interaction details with project, workspace, plan metadata, and images", async () => {
|
|
const { companyId, workerId } = await seedCompany("ATE");
|
|
const projectId = randomUUID();
|
|
const workspaceId = randomUUID();
|
|
const issueId = randomUUID();
|
|
const planDocumentId = randomUUID();
|
|
const planRevisionId = randomUUID();
|
|
const imageAssetIds = [randomUUID(), randomUUID(), randomUUID(), randomUUID()];
|
|
|
|
await db.insert(projects).values({
|
|
id: projectId,
|
|
companyId,
|
|
name: "Attention Project",
|
|
status: "in_progress",
|
|
color: "#0f766e",
|
|
icon: "rocket",
|
|
});
|
|
await db.insert(projectWorkspaces).values({
|
|
id: workspaceId,
|
|
companyId,
|
|
projectId,
|
|
name: "Preview workspace",
|
|
sourceType: "local_path",
|
|
isPrimary: true,
|
|
});
|
|
await insertIssue({
|
|
id: issueId,
|
|
companyId,
|
|
identifier: "ATE-1",
|
|
title: "Approve launch plan",
|
|
status: "in_progress",
|
|
assigneeAgentId: workerId,
|
|
projectId,
|
|
projectWorkspaceId: workspaceId,
|
|
updatedAt: new Date("2026-07-09T12:00:00.000Z"),
|
|
});
|
|
await db.insert(documents).values({
|
|
id: planDocumentId,
|
|
companyId,
|
|
title: "Launch Plan",
|
|
format: "markdown",
|
|
latestBody: "# Summary\n\nThis plan explains the launch checklist, rollout owner, QA gates, and risk controls for the homepage release.",
|
|
latestRevisionId: planRevisionId,
|
|
latestRevisionNumber: 2,
|
|
});
|
|
await db.insert(issueDocuments).values({
|
|
companyId,
|
|
issueId,
|
|
documentId: planDocumentId,
|
|
key: "plan",
|
|
});
|
|
await db.insert(assets).values([
|
|
{ id: imageAssetIds[0], companyId, provider: "local_disk", objectKey: "img-1", contentType: "image/png", byteSize: 10, sha256: "a".repeat(64), originalFilename: "one.png" },
|
|
{ id: imageAssetIds[1], companyId, provider: "local_disk", objectKey: "img-2", contentType: "image/jpeg", byteSize: 10, sha256: "b".repeat(64), originalFilename: "two.jpg" },
|
|
{ id: imageAssetIds[2], companyId, provider: "local_disk", objectKey: "img-3", contentType: "image/gif", byteSize: 10, sha256: "c".repeat(64), originalFilename: "three.gif" },
|
|
{ id: imageAssetIds[3], companyId, provider: "local_disk", objectKey: "img-4", contentType: "image/png", byteSize: 10, sha256: "d".repeat(64), originalFilename: "four.png" },
|
|
]);
|
|
await db.insert(issueAttachments).values(imageAssetIds.map((assetId, index) => ({
|
|
companyId,
|
|
issueId,
|
|
assetId,
|
|
createdAt: new Date(`2026-07-09T12:0${index}:30.000Z`),
|
|
updatedAt: new Date(`2026-07-09T12:0${index}:30.000Z`),
|
|
})));
|
|
|
|
const planInteractionId = randomUUID();
|
|
const questionsInteractionId = randomUUID();
|
|
const tasksInteractionId = randomUUID();
|
|
const checkboxInteractionId = randomUUID();
|
|
const verdictInteractionId = randomUUID();
|
|
await db.insert(issueThreadInteractions).values([
|
|
{
|
|
id: planInteractionId,
|
|
companyId,
|
|
issueId,
|
|
kind: "request_confirmation",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
title: "Approve the plan",
|
|
payload: {
|
|
version: 1,
|
|
prompt: "Approve plan?",
|
|
acceptLabel: "Approve plan",
|
|
rejectLabel: "Request changes",
|
|
target: { type: "issue_document", issueId, key: "plan", revisionId: planRevisionId },
|
|
},
|
|
createdAt: new Date("2026-07-09T12:01:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:01:00.000Z"),
|
|
},
|
|
{
|
|
id: questionsInteractionId,
|
|
companyId,
|
|
issueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
title: "Questions",
|
|
payload: {
|
|
version: 1,
|
|
questions: [
|
|
{ id: "q1", prompt: "Which auth provider should we use?", selectionMode: "single", options: [] },
|
|
{ id: "q2", prompt: "Should we add a fallback?", selectionMode: "single", options: [] },
|
|
],
|
|
},
|
|
createdAt: new Date("2026-07-09T12:02:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:02:00.000Z"),
|
|
},
|
|
{
|
|
id: tasksInteractionId,
|
|
companyId,
|
|
issueId,
|
|
kind: "suggest_tasks",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
title: "Tasks",
|
|
payload: { version: 1, tasks: [{ clientKey: "t1", title: "Build API" }, { clientKey: "t2", title: "Wire UI" }] },
|
|
createdAt: new Date("2026-07-09T12:03:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:03:00.000Z"),
|
|
},
|
|
{
|
|
id: checkboxInteractionId,
|
|
companyId,
|
|
issueId,
|
|
kind: "request_checkbox_confirmation",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
title: "Checkbox",
|
|
payload: { version: 1, prompt: "Select rollout regions", options: [{ id: "us", label: "US" }, { id: "eu", label: "EU" }] },
|
|
createdAt: new Date("2026-07-09T12:04:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:04:00.000Z"),
|
|
},
|
|
{
|
|
id: verdictInteractionId,
|
|
companyId,
|
|
issueId,
|
|
kind: "request_item_verdicts",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
title: "Verdicts",
|
|
payload: { version: 1, prompt: "Approve these screenshots", items: [{ id: "one", label: "One" }, { id: "two", label: "Two" }] },
|
|
createdAt: new Date("2026-07-09T12:05:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:05:00.000Z"),
|
|
},
|
|
]);
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
const interactionItems = feed.items.filter((item) => item.sourceKind === "issue_thread_interaction");
|
|
const detailsByKind = new Map(interactionItems.map((item) => [item.detail?.kind, item]));
|
|
|
|
const planItem = detailsByKind.get("plan_approval");
|
|
expect(planItem?.subject.title).toBe("Plan approval - Approve launch plan");
|
|
expect(planItem?.subject.metadata).toMatchObject({ isPlanTarget: true, targetDocumentKey: "plan" });
|
|
expect(planItem?.decisionVerbs).toEqual([
|
|
expect.objectContaining({ id: "accept", label: "Approve plan" }),
|
|
expect.objectContaining({ id: "reject", label: "Request changes" }),
|
|
]);
|
|
expect(planItem?.project).toMatchObject({
|
|
id: projectId,
|
|
name: "Attention Project",
|
|
color: "#0f766e",
|
|
icon: "rocket",
|
|
});
|
|
expect(planItem?.project?.urlKey).toEqual(expect.any(String));
|
|
expect(planItem?.workspace).toEqual({ id: workspaceId, name: "Preview workspace" });
|
|
expect(planItem?.detail).toMatchObject({
|
|
kind: "plan_approval",
|
|
issueTitle: "Approve launch plan",
|
|
planTitle: "Launch Plan",
|
|
summaryExcerpt: expect.stringContaining("launch checklist"),
|
|
images: imageAssetIds.slice(0, 3).map((assetId) => ({ assetId, alt: expect.any(String) })),
|
|
});
|
|
expect(detailsByKind.get("questions")?.detail).toMatchObject({
|
|
kind: "questions",
|
|
questionCount: 2,
|
|
firstQuestionText: "Which auth provider should we use?",
|
|
});
|
|
expect(detailsByKind.get("suggested_tasks")?.detail).toMatchObject({
|
|
kind: "suggested_tasks",
|
|
taskCount: 2,
|
|
firstTaskTitle: "Build API",
|
|
});
|
|
expect(detailsByKind.get("checkbox_confirmation")?.detail).toMatchObject({
|
|
kind: "checkbox_confirmation",
|
|
optionCount: 2,
|
|
promptExcerpt: "Select rollout regions",
|
|
});
|
|
expect(detailsByKind.get("item_verdicts")?.detail).toMatchObject({
|
|
kind: "item_verdicts",
|
|
itemCount: 2,
|
|
promptExcerpt: "Approve these screenshots",
|
|
});
|
|
});
|
|
|
|
it("shows only the newest pending confirmation per issue and kind", async () => {
|
|
const { companyId, workerId, reviewerId } = await seedCompany("ATC");
|
|
const issueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATC-1",
|
|
title: "Repeated sign-offs",
|
|
status: "in_review",
|
|
assigneeAgentId: workerId,
|
|
});
|
|
const olderConfirmationId = randomUUID();
|
|
const newerConfirmationId = randomUUID();
|
|
const checkboxId = randomUUID();
|
|
await db.insert(issueThreadInteractions).values([
|
|
{
|
|
id: olderConfirmationId,
|
|
companyId,
|
|
issueId,
|
|
kind: "request_confirmation",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
createdByAgentId: workerId,
|
|
title: "Approve V1",
|
|
payload: { version: 1, prompt: "Approve V1?" },
|
|
createdAt: new Date("2026-07-09T12:00:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:10:00.000Z"),
|
|
},
|
|
{
|
|
id: newerConfirmationId,
|
|
companyId,
|
|
issueId,
|
|
kind: "request_confirmation",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
createdByAgentId: reviewerId,
|
|
title: "Approve V2",
|
|
payload: { version: 1, prompt: "Approve V2?" },
|
|
createdAt: new Date("2026-07-09T12:05:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:05:00.000Z"),
|
|
},
|
|
{
|
|
id: checkboxId,
|
|
companyId,
|
|
issueId,
|
|
kind: "request_checkbox_confirmation",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
createdByAgentId: workerId,
|
|
title: "Select rollout",
|
|
payload: { version: 1, prompt: "Select rollout", options: [{ id: "one", label: "One" }] },
|
|
createdAt: new Date("2026-07-09T12:01:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:01:00.000Z"),
|
|
},
|
|
]);
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
const interactionIds = feed.items
|
|
.filter((item) => item.sourceKind === "issue_thread_interaction")
|
|
.map((item) => item.subject.id);
|
|
|
|
expect(interactionIds).toContain(newerConfirmationId);
|
|
expect(interactionIds).toContain(checkboxId);
|
|
expect(interactionIds).not.toContain(olderConfirmationId);
|
|
});
|
|
|
|
it("uses inbox_dismissals with attention-prefixed dedup keys and resurfaces newer activity", async () => {
|
|
const { companyId } = await seedCompany("ATD");
|
|
const approvalId = randomUUID();
|
|
await db.insert(approvals).values({
|
|
id: approvalId,
|
|
companyId,
|
|
type: "hire_agent",
|
|
status: "pending",
|
|
payload: { title: "Hire Writer" },
|
|
createdAt: new Date("2026-07-09T12:00:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:00:00.000Z"),
|
|
});
|
|
await db.insert(inboxDismissals).values({
|
|
companyId,
|
|
userId: "board-user",
|
|
itemKey: `attention:approval:${approvalId}`,
|
|
dismissedAt: new Date("2026-07-09T13:00:00.000Z"),
|
|
});
|
|
|
|
await expect(attentionService(db).list(companyId, { userId: "board-user" }))
|
|
.resolves.toMatchObject({ totalCount: 1 }); // agent_error_alert from seed
|
|
const includeDismissedFeed = await attentionService(db).list(companyId, { userId: "board-user", includeDismissed: true });
|
|
expect(includeDismissedFeed.totalCount).toBe(2);
|
|
expect(includeDismissedFeed.items.find((item) => item.dedupKey === `approval:${approvalId}`)?.dismissal)
|
|
.toMatchObject({ kind: "dismiss", isActive: true, snoozedUntil: null });
|
|
|
|
await db
|
|
.update(approvals)
|
|
.set({ updatedAt: new Date("2026-07-09T14:00:00.000Z") })
|
|
.where(eq(approvals.id, approvalId));
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
expect(feed.items.some((item) => item.dedupKey === `approval:${approvalId}`)).toBe(true);
|
|
});
|
|
|
|
it("delivers a structured human unblock descriptor once per blocked transition", async () => {
|
|
const { companyId } = await seedCompany("ATU");
|
|
const transitionAt = new Date("2026-07-23T18:30:00.000Z");
|
|
const issueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATU-1",
|
|
title: "Needs board action",
|
|
status: "blocked",
|
|
unblockDescriptor: { owner: "board", action: "Approve the exception" },
|
|
blockedTransitionAt: transitionAt,
|
|
});
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
const items = feed.items.filter((item) => item.dedupKey === `blocked-owner:${issueId}:${transitionAt.toISOString()}`);
|
|
|
|
expect(items).toHaveLength(1);
|
|
expect(items[0]).toMatchObject({ sourceKind: "blocker_attention", whyNow: "Approve the exception" });
|
|
});
|
|
|
|
it("keeps legacy blocker attention visible for pre-rollout blocked issues", async () => {
|
|
const { companyId } = await seedCompany("ATP");
|
|
const issueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATP-1",
|
|
title: "Blocked before rollout",
|
|
status: "blocked",
|
|
blockedTransitionAt: new Date(ROUTABLE_BLOCKED_ROLLOUT_AT.getTime() - 1),
|
|
});
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
|
|
expect(feed.items.some((item) => item.dedupKey === `blocker:${issueId}`)).toBe(true);
|
|
});
|
|
|
|
// Regression: both blocker_attention call sites fell back to the blocked
|
|
// task's own identity when no `blocks` relation was loaded, so every such row
|
|
// claimed the task was blocked by itself ("PAP-23 — Blocked by PAP-23").
|
|
it("reports no blocking task rather than a self-reference when the blocker is unknown", async () => {
|
|
const { companyId } = await seedCompany("ATV");
|
|
const issueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATV-1",
|
|
title: "Blocked with no relation",
|
|
status: "blocked",
|
|
blockedTransitionAt: new Date(ROUTABLE_BLOCKED_ROLLOUT_AT.getTime() - 1),
|
|
});
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
const row = feed.items.find((item) => item.dedupKey === `blocker:${issueId}`);
|
|
|
|
expect(row).toBeTruthy();
|
|
expect(row?.detail).toMatchObject({ kind: "blocker", blockingIssue: null });
|
|
expect(row?.dismissalKey).toBe(`attention:blocker:${issueId}`);
|
|
});
|
|
|
|
it("suppresses a blocked dependency row while its blocker is actively progressing", async () => {
|
|
const { companyId } = await seedCompany("ATW");
|
|
const blockedId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATW-1",
|
|
title: "Blocked parent",
|
|
status: "blocked",
|
|
blockedTransitionAt: new Date(ROUTABLE_BLOCKED_ROLLOUT_AT.getTime() - 1),
|
|
});
|
|
const blockerId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATW-2",
|
|
title: "The actual blocker",
|
|
status: "in_progress",
|
|
});
|
|
await db.insert(issueRelations).values({
|
|
companyId,
|
|
issueId: blockerId,
|
|
relatedIssueId: blockedId,
|
|
type: "blocks",
|
|
});
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
expect(feed.items.some((item) => item.sourceKind === "blocker_attention")).toBe(false);
|
|
});
|
|
|
|
it("suppresses a mixed blocker tree when any blocker is live", async () => {
|
|
const { companyId } = await seedCompany("ATL");
|
|
const blockedId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATL-1",
|
|
title: "Blocked rollout",
|
|
status: "blocked",
|
|
});
|
|
const blockerIds = await Promise.all([
|
|
insertIssue({ companyId, identifier: "ATL-2", title: "Live phase one", status: "in_progress" }),
|
|
insertIssue({ companyId, identifier: "ATL-3", title: "Live phase two", status: "in_progress" }),
|
|
insertIssue({ companyId, identifier: "ATL-4", title: "Live phase three", status: "in_progress" }),
|
|
insertIssue({ companyId, identifier: "ATL-5", title: "Stopped phase", status: "todo" }),
|
|
]);
|
|
await db.insert(issueRelations).values(blockerIds.map((issueId) => ({
|
|
companyId,
|
|
issueId,
|
|
relatedIssueId: blockedId,
|
|
type: "blocks" as const,
|
|
})));
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
|
|
expect(feed.items.filter((item) => item.sourceKind === "blocker_attention")).toEqual([]);
|
|
});
|
|
|
|
it("emits one terminal-blocker row with a cycle-safe transitive blocked-work count", async () => {
|
|
const { companyId } = await seedCompany("ATC");
|
|
const terminalId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATC-1",
|
|
title: "Choose migration owner",
|
|
status: "todo",
|
|
});
|
|
const blockedId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATC-2",
|
|
title: "Blocked migration",
|
|
status: "blocked",
|
|
});
|
|
await insertIssue({
|
|
companyId,
|
|
identifier: "ATC-3",
|
|
title: "Open migration child",
|
|
status: "todo",
|
|
parentId: blockedId,
|
|
});
|
|
const transitiveId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATC-4",
|
|
title: "Transitively blocked follow-up",
|
|
status: "todo",
|
|
});
|
|
await insertIssue({
|
|
companyId,
|
|
identifier: "ATC-5",
|
|
title: "Closed child",
|
|
status: "done",
|
|
parentId: blockedId,
|
|
});
|
|
await db.insert(issueRelations).values([
|
|
{ companyId, issueId: terminalId, relatedIssueId: blockedId, type: "blocks" },
|
|
{ companyId, issueId: blockedId, relatedIssueId: transitiveId, type: "blocks" },
|
|
// Corrupt legacy cycles must not inflate or hang the count.
|
|
{ companyId, issueId: transitiveId, relatedIssueId: blockedId, type: "blocks" },
|
|
]);
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
const rows = feed.items.filter((item) => item.sourceKind === "blocker_attention");
|
|
|
|
expect(rows).toHaveLength(1);
|
|
expect(rows[0]).toMatchObject({
|
|
subject: { id: terminalId, identifier: "ATC-1", title: "Choose migration owner" },
|
|
relatedIssue: { id: blockedId },
|
|
whyNow: "Blocks 3 tasks and needs human attention.",
|
|
detail: { kind: "blocker", blockingIssue: null, blockedTaskCount: 3 },
|
|
});
|
|
expect(rows[0]?.subject.id).not.toBe(blockedId);
|
|
});
|
|
|
|
it("orders terminal blockers by blocked-work weight descending", async () => {
|
|
const { companyId } = await seedCompany("ATR");
|
|
const heavyTerminalId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATR-1",
|
|
title: "Heavy blocker",
|
|
status: "todo",
|
|
updatedAt: new Date("2026-07-01T00:00:00.000Z"),
|
|
});
|
|
const lightTerminalId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATR-2",
|
|
title: "Light blocker",
|
|
status: "todo",
|
|
updatedAt: new Date("2026-07-03T00:00:00.000Z"),
|
|
});
|
|
const heavyBlockedId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATR-3",
|
|
title: "Heavy blocked root",
|
|
status: "blocked",
|
|
});
|
|
const lightBlockedId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATR-4",
|
|
title: "Light blocked root",
|
|
status: "blocked",
|
|
});
|
|
await insertIssue({ companyId, identifier: "ATR-5", title: "Heavy child one", status: "todo", parentId: heavyBlockedId });
|
|
await insertIssue({ companyId, identifier: "ATR-6", title: "Heavy child two", status: "todo", parentId: heavyBlockedId });
|
|
await db.insert(issueRelations).values([
|
|
{ companyId, issueId: heavyTerminalId, relatedIssueId: heavyBlockedId, type: "blocks" },
|
|
{ companyId, issueId: lightTerminalId, relatedIssueId: lightBlockedId, type: "blocks" },
|
|
]);
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
const rows = feed.items.filter((item) => item.sourceKind === "blocker_attention");
|
|
|
|
expect(rows.map((item) => item.subject.id)).toEqual([heavyTerminalId, lightTerminalId]);
|
|
expect(rows.map((item) => item.detail?.kind === "blocker" ? item.detail.blockedTaskCount : null)).toEqual([3, 1]);
|
|
});
|
|
|
|
it("does not name the blocked task as its own blocker on a human-owned unblock row", async () => {
|
|
const { companyId } = await seedCompany("ATX");
|
|
const transitionAt = new Date("2026-07-23T18:30:00.000Z");
|
|
const issueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATX-1",
|
|
title: "Needs board action",
|
|
status: "blocked",
|
|
unblockDescriptor: { owner: "board", action: "Approve the exception" },
|
|
blockedTransitionAt: transitionAt,
|
|
});
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
const row = feed.items.find(
|
|
(item) => item.dedupKey === `blocked-owner:${issueId}:${transitionAt.toISOString()}`,
|
|
);
|
|
|
|
expect(row?.detail).toMatchObject({ kind: "blocker", blockingIssue: null });
|
|
});
|
|
|
|
it("does not route pre-rollout human unblock descriptors", async () => {
|
|
const { companyId } = await seedCompany("ATQ");
|
|
const transitionAt = new Date(ROUTABLE_BLOCKED_ROLLOUT_AT.getTime() - 1);
|
|
const issueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATQ-1",
|
|
title: "Human-owned before rollout",
|
|
status: "blocked",
|
|
unblockDescriptor: { owner: "board", action: "Review the issue" },
|
|
blockedTransitionAt: transitionAt,
|
|
});
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
|
|
expect(feed.items.some((item) => item.dedupKey === `blocked-owner:${issueId}:${transitionAt.toISOString()}`)).toBe(false);
|
|
});
|
|
|
|
it("returns one pending approval row when the approval is linked to multiple tasks", async () => {
|
|
const { companyId } = await seedCompany("ATM");
|
|
const approvalId = randomUUID();
|
|
const firstIssueId = "00000000-0000-4000-8000-000000000001";
|
|
const secondIssueId = "00000000-0000-4000-8000-000000000002";
|
|
await insertIssue({ companyId, id: firstIssueId, identifier: "ATM-1", title: "First task", status: "in_progress" });
|
|
await insertIssue({ companyId, id: secondIssueId, identifier: "ATM-2", title: "Second task", status: "in_progress" });
|
|
await db.insert(approvals).values({
|
|
id: approvalId,
|
|
companyId,
|
|
type: "request_board_approval",
|
|
status: "pending",
|
|
payload: { title: "Approve rollout" },
|
|
});
|
|
await db.insert(issueApprovals).values([
|
|
{ companyId, issueId: secondIssueId, approvalId },
|
|
{ companyId, issueId: firstIssueId, approvalId },
|
|
]);
|
|
|
|
const feed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
const approvalItems = feed.items.filter((item) => item.dedupKey === `approval:${approvalId}`);
|
|
|
|
expect(approvalItems).toHaveLength(1);
|
|
expect(approvalItems[0]?.subject.metadata?.issueId).toBe(firstIssueId);
|
|
});
|
|
|
|
it("hides snoozed attention rows until snoozedUntil passes, then returns them unconditionally", async () => {
|
|
const { companyId } = await seedCompany("ATS");
|
|
const approvalId = randomUUID();
|
|
await db.insert(approvals).values({
|
|
id: approvalId,
|
|
companyId,
|
|
type: "hire_agent",
|
|
status: "pending",
|
|
payload: { title: "Hire Researcher" },
|
|
createdAt: new Date("2026-07-09T12:00:00.000Z"),
|
|
updatedAt: new Date("2026-07-09T12:00:00.000Z"),
|
|
});
|
|
await db.insert(inboxDismissals).values({
|
|
companyId,
|
|
userId: "board-user",
|
|
itemKey: `attention:approval:${approvalId}`,
|
|
kind: "snooze",
|
|
dismissedAt: new Date("2099-01-01T00:00:00.000Z"),
|
|
snoozedUntil: new Date("2099-01-02T00:00:00.000Z"),
|
|
});
|
|
|
|
await expect(attentionService(db).list(companyId, { userId: "board-user" }))
|
|
.resolves.toMatchObject({ totalCount: 1 }); // agent_error_alert from seed
|
|
const hiddenFeed = await attentionService(db).list(companyId, { userId: "board-user", includeDismissed: true });
|
|
expect(hiddenFeed.items.find((item) => item.dedupKey === `approval:${approvalId}`)?.dismissal)
|
|
.toMatchObject({ kind: "snooze", isActive: true, snoozedUntil: "2099-01-02T00:00:00.000Z" });
|
|
|
|
await db
|
|
.update(inboxDismissals)
|
|
.set({ snoozedUntil: new Date("2020-01-01T00:00:00.000Z") })
|
|
.where(eq(inboxDismissals.itemKey, `attention:approval:${approvalId}`));
|
|
|
|
const visibleFeed = await attentionService(db).list(companyId, { userId: "board-user" });
|
|
const visibleApproval = visibleFeed.items.find((item) => item.dedupKey === `approval:${approvalId}`);
|
|
expect(visibleApproval?.dismissal).toMatchObject({ kind: "snooze", isActive: false });
|
|
expect(visibleApproval).toBeTruthy();
|
|
});
|
|
|
|
it("enriches, filters, paginates, snoozes, and ranks the decide-now feed", async () => {
|
|
const { companyId, workerId, errorAgentId } = await seedCompany("ATP");
|
|
const now = Date.now();
|
|
const originIssueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATP-1",
|
|
title: "Decision origin",
|
|
status: "in_progress",
|
|
assigneeAgentId: workerId,
|
|
updatedAt: new Date(now - 10 * 60_000),
|
|
});
|
|
const runId = randomUUID();
|
|
await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId,
|
|
agentId: workerId,
|
|
status: "succeeded",
|
|
contextSnapshot: { issueId: originIssueId },
|
|
});
|
|
|
|
const expiringSoonId = randomUUID();
|
|
const expiringLaterId = randomUUID();
|
|
const wheneverId = randomUUID();
|
|
const snoozedId = randomUUID();
|
|
const decisionValues = [
|
|
{ id: expiringSoonId, ruleKey: "release.soon", title: "Expires sooner", updatedAt: new Date(now - 60_000), expiresAt: new Date(now + 60 * 60_000) },
|
|
{ id: expiringLaterId, ruleKey: "release.later", title: "Expires later", updatedAt: new Date(now - 2 * 60_000), expiresAt: new Date(now + 2 * 60 * 60_000) },
|
|
{ id: wheneverId, ruleKey: "release.whenever", title: "Can wait", updatedAt: new Date(now), expiresAt: new Date(now + 30 * 60_000) },
|
|
{ id: snoozedId, ruleKey: "release.snoozed", title: "Snoozed", updatedAt: new Date(now - 3 * 60_000), expiresAt: new Date(now + 15 * 60_000) },
|
|
];
|
|
await db.insert(decisions).values(decisionValues.map((value) => ({
|
|
...value,
|
|
companyId,
|
|
originAgentId: workerId,
|
|
originIssueId,
|
|
originRunId: runId,
|
|
body: value.title,
|
|
options: [],
|
|
status: "open",
|
|
signedSpec: "test",
|
|
targetSnapshots: {},
|
|
createdAt: value.updatedAt,
|
|
})));
|
|
|
|
const queueId = randomUUID();
|
|
await db.insert(decisionQueues).values({
|
|
id: queueId,
|
|
companyId,
|
|
key: "urgent-releases",
|
|
title: "Urgent releases",
|
|
createdByType: "user",
|
|
createdByUserId: "board-user",
|
|
});
|
|
await db.insert(decisionQueueItems).values([expiringSoonId, expiringLaterId].map((sourceId) => ({
|
|
companyId,
|
|
queueId,
|
|
sourceKind: "decision",
|
|
sourceId,
|
|
addedByType: "user",
|
|
addedByUserId: "board-user",
|
|
})));
|
|
await db.insert(decisionTriage).values([
|
|
expiringSoonId,
|
|
expiringLaterId,
|
|
snoozedId,
|
|
].map((sourceId) => ({
|
|
companyId,
|
|
sourceKind: "decision",
|
|
sourceId,
|
|
decideBy: "today",
|
|
setByType: "agent",
|
|
setByAgentId: workerId,
|
|
snoozedUntil: sourceId === snoozedId ? new Date(now + 60 * 60_000) : null,
|
|
})));
|
|
await db.insert(decisionTriage).values({
|
|
companyId,
|
|
sourceKind: "decision",
|
|
sourceId: wheneverId,
|
|
decideBy: "whenever",
|
|
setByType: "agent",
|
|
setByAgentId: workerId,
|
|
});
|
|
|
|
const approvalId = randomUUID();
|
|
await db.insert(approvals).values({
|
|
id: approvalId,
|
|
companyId,
|
|
type: "hire_agent",
|
|
status: "pending",
|
|
payload: { title: "Newer medium-severity approval" },
|
|
createdAt: new Date(now + 5 * 60_000),
|
|
updatedAt: new Date(now + 5 * 60_000),
|
|
});
|
|
await db.update(agents).set({ updatedAt: new Date(now - 5 * 60_000) }).where(eq(agents.id, errorAgentId));
|
|
|
|
const feed = await attentionService(db).list(companyId, {
|
|
userId: "board-user",
|
|
sort: "decide",
|
|
limit: 20,
|
|
});
|
|
// Desk badge = distinct items surfaced today OR with a due decide-by
|
|
// Everything here was seeded ~now, so every visible row
|
|
// counts; the whole page fits under limit:20 so items == rankedItems.
|
|
const startOfUtcDay = Date.UTC(
|
|
new Date(now).getUTCFullYear(),
|
|
new Date(now).getUTCMonth(),
|
|
new Date(now).getUTCDate(),
|
|
);
|
|
const expectedBadge = feed.items.filter(
|
|
(item) => new Date(item.createdAt).getTime() >= startOfUtcDay || item.decideBy === "today",
|
|
).length;
|
|
expect(expectedBadge).toBeGreaterThanOrEqual(2);
|
|
expect(feed.deskBadgeCount).toBe(expectedBadge);
|
|
expect(feed.items.some((item) => item.subject.id === snoozedId)).toBe(false);
|
|
expect(feed.items.slice(0, 3).map((item) => item.subject.id)).toEqual([
|
|
expiringSoonId,
|
|
expiringLaterId,
|
|
wheneverId,
|
|
]);
|
|
const erroredAgentIndex = feed.items.findIndex((item) => item.subject.id === errorAgentId);
|
|
const approvalIndex = feed.items.findIndex((item) => item.subject.id === approvalId);
|
|
expect(erroredAgentIndex).toBeGreaterThan(-1);
|
|
expect(erroredAgentIndex).toBeLessThan(approvalIndex);
|
|
|
|
const enriched = feed.items.find((item) => item.subject.id === expiringSoonId);
|
|
expect(enriched).toMatchObject({
|
|
expiresAt: decisionValues[0]!.expiresAt.toISOString(),
|
|
ruleKey: "release.soon",
|
|
originAgentName: "Worker",
|
|
queues: [{ key: "urgent-releases", title: "Urgent releases" }],
|
|
decideBy: "today",
|
|
decideByAttribution: {
|
|
type: "agent",
|
|
agentId: workerId,
|
|
agentName: "Worker",
|
|
},
|
|
snoozedUntil: null,
|
|
});
|
|
|
|
const firstPage = await attentionService(db).list(companyId, {
|
|
userId: "board-user",
|
|
queue: "urgent-releases",
|
|
sort: "decide",
|
|
limit: 1,
|
|
});
|
|
expect(firstPage).toMatchObject({ totalCount: 2, deskBadgeCount: 2 });
|
|
expect(firstPage.items.map((item) => item.subject.id)).toEqual([expiringSoonId]);
|
|
expect(firstPage.nextCursor).toBeTruthy();
|
|
const secondPage = await attentionService(db).list(companyId, {
|
|
userId: "board-user",
|
|
queue: "urgent-releases",
|
|
sort: "decide",
|
|
limit: 1,
|
|
cursor: firstPage.nextCursor!,
|
|
});
|
|
expect(secondPage.items.map((item) => item.subject.id)).toEqual([expiringLaterId]);
|
|
expect(secondPage.nextCursor).toBeNull();
|
|
|
|
const completeSnapshot = await attentionService(db).list(companyId, {
|
|
userId: "board-user",
|
|
queue: "urgent-releases",
|
|
sort: "decide",
|
|
all: true,
|
|
});
|
|
expect(completeSnapshot.items.map((item) => item.subject.id)).toEqual([expiringSoonId, expiringLaterId]);
|
|
expect(completeSnapshot.nextCursor).toBeNull();
|
|
|
|
const dateFiltered = await attentionService(db).list(companyId, {
|
|
userId: "board-user",
|
|
queue: "urgent-releases",
|
|
activitySince: new Date(now - 90_000).toISOString(),
|
|
activityUntil: new Date(now).toISOString(),
|
|
});
|
|
expect(dateFiltered.items.map((item) => item.subject.id)).toEqual([expiringSoonId]);
|
|
|
|
const withSnoozed = await attentionService(db).list(companyId, {
|
|
userId: "board-user",
|
|
includeDismissed: true,
|
|
limit: 20,
|
|
});
|
|
expect(withSnoozed.items.find((item) => item.subject.id === snoozedId)?.snoozedUntil)
|
|
.toBe(new Date(now + 60 * 60_000).toISOString());
|
|
});
|
|
|
|
it("returns a complete queue snapshot beyond the normal page limit", async () => {
|
|
const { companyId } = await seedCompany("ATS");
|
|
const queueId = randomUUID();
|
|
await db.insert(decisionQueues).values({
|
|
id: queueId,
|
|
companyId,
|
|
key: "bulk-review",
|
|
title: "Bulk review",
|
|
createdByType: "user",
|
|
createdByUserId: "board-user",
|
|
});
|
|
|
|
const approvalRows = Array.from({ length: 101 }, (_, index) => ({
|
|
id: randomUUID(),
|
|
companyId,
|
|
type: "hire_agent",
|
|
status: "pending",
|
|
payload: { title: `Review ${index + 1}` },
|
|
createdAt: new Date(Date.UTC(2026, 7, 2, 12, 0, index)),
|
|
updatedAt: new Date(Date.UTC(2026, 7, 2, 12, 0, index)),
|
|
}));
|
|
await db.insert(approvals).values(approvalRows);
|
|
await db.insert(decisionQueueItems).values(approvalRows.map((approval) => ({
|
|
companyId,
|
|
queueId,
|
|
sourceKind: "approval",
|
|
sourceId: approval.id,
|
|
addedByType: "user",
|
|
addedByUserId: "board-user",
|
|
})));
|
|
|
|
const firstPage = await attentionService(db).list(companyId, {
|
|
userId: "board-user",
|
|
queue: "bulk-review",
|
|
});
|
|
expect(firstPage.items).toHaveLength(50);
|
|
expect(firstPage.nextCursor).toBeTruthy();
|
|
|
|
const completeSnapshot = await attentionService(db).list(companyId, {
|
|
userId: "board-user",
|
|
queue: "bulk-review",
|
|
all: true,
|
|
});
|
|
expect(completeSnapshot.items).toHaveLength(101);
|
|
expect(new Set(completeSnapshot.items.map((item) => item.id)).size).toBe(101);
|
|
expect(completeSnapshot.nextCursor).toBeNull();
|
|
|
|
const internalSnapshot = await attentionService(db).list(companyId, {
|
|
userId: "board-user",
|
|
all: true,
|
|
allowUnscopedAll: true,
|
|
});
|
|
const internalSnapshotIds = new Set(internalSnapshot.items.map((item) => item.subject.id));
|
|
expect(approvalRows.every((approval) => internalSnapshotIds.has(approval.id))).toBe(true);
|
|
expect(internalSnapshot.items.length).toBeGreaterThan(100);
|
|
expect(internalSnapshot.nextCursor).toBeNull();
|
|
|
|
await expect(attentionService(db).list(companyId, { userId: "board-user", all: true }))
|
|
.rejects.toThrow("all requires a queue filter");
|
|
await expect(attentionService(db).list(companyId, {
|
|
userId: "board-user",
|
|
queue: "bulk-review",
|
|
all: true,
|
|
limit: 25,
|
|
})).rejects.toThrow("all cannot be combined with cursor or limit");
|
|
});
|
|
|
|
it("does not apply the open-decision safety limit to complete snapshots", async () => {
|
|
const { companyId, workerId } = await seedCompany("ATC");
|
|
const originIssueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATC-1",
|
|
title: "Decision origin",
|
|
status: "in_progress",
|
|
assigneeAgentId: workerId,
|
|
});
|
|
const runId = randomUUID();
|
|
await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId,
|
|
agentId: workerId,
|
|
status: "succeeded",
|
|
contextSnapshot: { issueId: originIssueId },
|
|
});
|
|
await db.insert(decisions).values(["First decision", "Second decision"].map((title) => ({
|
|
id: randomUUID(),
|
|
companyId,
|
|
originAgentId: workerId,
|
|
originIssueId,
|
|
originRunId: runId,
|
|
title,
|
|
body: title,
|
|
options: [],
|
|
status: "open" as const,
|
|
expiresAt: new Date("2026-08-10T00:00:00.000Z"),
|
|
signedSpec: "test",
|
|
targetSnapshots: {},
|
|
})));
|
|
|
|
const svc = attentionService(db, { openDecisionLimit: 1 });
|
|
const limited = await svc.list(companyId, { userId: "board-user" });
|
|
expect(limited.items.filter((item) => item.sourceKind === "decision")).toHaveLength(1);
|
|
|
|
const complete = await svc.list(companyId, {
|
|
userId: "board-user",
|
|
all: true,
|
|
allowUnscopedAll: true,
|
|
});
|
|
expect(complete.items.filter((item) => item.sourceKind === "decision")).toHaveLength(2);
|
|
expect(complete.nextCursor).toBeNull();
|
|
});
|
|
|
|
it("keeps this-week deadlines in the current UTC week", async () => {
|
|
const { companyId, workerId } = await seedCompany("ATW");
|
|
const now = Date.parse("2026-08-02T12:00:00.000Z"); // Sunday in an ISO Monday-Sunday week.
|
|
const originIssueId = await insertIssue({
|
|
companyId,
|
|
identifier: "ATW-1",
|
|
title: "Decision origin",
|
|
status: "in_progress",
|
|
assigneeAgentId: workerId,
|
|
updatedAt: new Date(now),
|
|
});
|
|
const runId = randomUUID();
|
|
await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId,
|
|
agentId: workerId,
|
|
status: "succeeded",
|
|
contextSnapshot: { issueId: originIssueId },
|
|
});
|
|
|
|
const thisWeekId = randomUUID();
|
|
const nextWeekId = randomUUID();
|
|
await db.insert(decisions).values([
|
|
{ id: thisWeekId, title: "This week", expiresAt: new Date("2026-08-09T12:00:00.000Z") },
|
|
{ id: nextWeekId, title: "Next week", expiresAt: new Date("2026-08-03T12:00:00.000Z") },
|
|
].map((value) => ({
|
|
...value,
|
|
companyId,
|
|
originAgentId: workerId,
|
|
originIssueId,
|
|
originRunId: runId,
|
|
body: value.title,
|
|
options: [],
|
|
status: "open" as const,
|
|
signedSpec: "test",
|
|
targetSnapshots: {},
|
|
createdAt: new Date(now),
|
|
updatedAt: new Date(now),
|
|
})));
|
|
await db.insert(decisionTriage).values([
|
|
{
|
|
companyId,
|
|
sourceKind: "decision",
|
|
sourceId: thisWeekId,
|
|
decideBy: "this_week",
|
|
setByType: "user",
|
|
setByUserId: "board-user",
|
|
},
|
|
{
|
|
companyId,
|
|
sourceKind: "decision",
|
|
sourceId: nextWeekId,
|
|
decideBy: "date",
|
|
decideByDate: "2026-08-03",
|
|
setByType: "user",
|
|
setByUserId: "board-user",
|
|
},
|
|
]);
|
|
|
|
const feed = await attentionService(db, { now: () => now }).list(companyId, {
|
|
userId: "board-user",
|
|
sort: "decide",
|
|
limit: 20,
|
|
});
|
|
const decisionItems = feed.items.filter((item) => item.sourceKind === "decision");
|
|
|
|
expect(decisionItems.map((item) => item.subject.id)).toEqual([thisWeekId, nextWeekId]);
|
|
expect(decisionItems[0]).toMatchObject({
|
|
decideBy: "this_week",
|
|
expiresAt: "2026-08-09T12:00:00.000Z",
|
|
});
|
|
expect(decisionItems[1]).toMatchObject({
|
|
decideBy: "2026-08-03",
|
|
expiresAt: "2026-08-03T12:00:00.000Z",
|
|
});
|
|
});
|
|
|
|
it("serves the route for board users and rejects agent callers", async () => {
|
|
const { companyId } = await seedCompany("ATR");
|
|
|
|
function app(actor: Record<string, unknown>) {
|
|
const testApp = express();
|
|
testApp.use(express.json());
|
|
testApp.use((req, _res, next) => {
|
|
(req as any).actor = actor;
|
|
next();
|
|
});
|
|
testApp.use("/api", attentionRoutes(db));
|
|
testApp.use(errorHandler);
|
|
return testApp;
|
|
}
|
|
|
|
const board = {
|
|
type: "board",
|
|
source: "local_implicit",
|
|
userId: "board-user",
|
|
companyIds: [companyId],
|
|
isInstanceAdmin: false,
|
|
};
|
|
const agent = {
|
|
type: "agent",
|
|
source: "agent_key",
|
|
companyId,
|
|
agentId: randomUUID(),
|
|
runId: null,
|
|
};
|
|
|
|
await request(app(board)).get(`/api/companies/${companyId}/attention`).expect(200);
|
|
const completeFeed = await request(app(board))
|
|
.get(`/api/companies/${companyId}/attention?includeDismissed=true&all=true`)
|
|
.expect(200);
|
|
expect(completeFeed.body.nextCursor).toBeNull();
|
|
await request(app(board))
|
|
.get(`/api/companies/${companyId}/attention?activitySince=yesterday`)
|
|
.expect(400, { error: "activitySince must be an ISO timestamp" });
|
|
await request(app(board))
|
|
.get(`/api/companies/${companyId}/attention?sort=oldest`)
|
|
.expect(400, { error: "sort must be 'activity' or 'decide'" });
|
|
await request(app(agent)).get(`/api/companies/${companyId}/attention`).expect(403);
|
|
});
|
|
|
|
it("omits private issue review items for a non-member board user", async () => {
|
|
const { companyId } = await seedCompany("ATP");
|
|
const privateIssueId = randomUUID();
|
|
await insertIssue({
|
|
id: privateIssueId,
|
|
companyId,
|
|
identifier: "ATP-1",
|
|
title: "Confidential review",
|
|
status: "in_review",
|
|
assigneeUserId: "private-owner",
|
|
executionState: pendingUserExecutionState("private-owner"),
|
|
visibility: "private",
|
|
privacyRootIssueId: privateIssueId,
|
|
responsibleUserId: "private-owner",
|
|
});
|
|
|
|
const actor = {
|
|
type: "board" as const,
|
|
source: "session" as const,
|
|
userId: "non-member",
|
|
companyIds: [companyId],
|
|
isInstanceAdmin: false,
|
|
};
|
|
const feed = await attentionService(db).list(companyId, { userId: actor.userId, actor });
|
|
|
|
expect(feed.items.map((item) => item.subject.title)).not.toContain("Confidential review");
|
|
expect(JSON.stringify(feed)).not.toContain(privateIssueId);
|
|
});
|
|
|
|
it("computes the aging shelf uniformly across approval, interaction, and review sources", async () => {
|
|
const { companyId, workerId } = await seedCompany("AGE");
|
|
const now = Date.parse("2026-08-02T12:00:00.000Z");
|
|
const idleAt = new Date("2026-06-30T12:00:00.000Z");
|
|
const interactionIssueId = await insertIssue({
|
|
companyId,
|
|
identifier: "AGE-1",
|
|
title: "Old questions",
|
|
status: "in_progress",
|
|
assigneeAgentId: workerId,
|
|
createdAt: idleAt,
|
|
updatedAt: idleAt,
|
|
});
|
|
const reviewIssueId = await insertIssue({
|
|
companyId,
|
|
identifier: "AGE-2",
|
|
title: "Old review",
|
|
status: "in_review",
|
|
assigneeUserId: "board-user",
|
|
createdAt: idleAt,
|
|
updatedAt: idleAt,
|
|
});
|
|
const approvalId = randomUUID();
|
|
const queueApprovalId = randomUUID();
|
|
const interactionId = randomUUID();
|
|
const queueIdleAt = new Date("2026-07-18T12:00:00.000Z");
|
|
await db.insert(approvals).values([
|
|
{
|
|
id: approvalId,
|
|
companyId,
|
|
type: "request_board_approval",
|
|
requestedByAgentId: workerId,
|
|
status: "pending",
|
|
payload: { title: "Old approval" },
|
|
createdAt: idleAt,
|
|
updatedAt: idleAt,
|
|
},
|
|
{
|
|
id: queueApprovalId,
|
|
companyId,
|
|
type: "request_board_approval",
|
|
requestedByAgentId: workerId,
|
|
status: "pending",
|
|
payload: { title: "Queue-retained approval" },
|
|
createdAt: queueIdleAt,
|
|
updatedAt: queueIdleAt,
|
|
},
|
|
]);
|
|
await db.insert(issueThreadInteractions).values({
|
|
id: interactionId,
|
|
companyId,
|
|
issueId: interactionIssueId,
|
|
kind: "ask_user_questions",
|
|
status: "pending",
|
|
createdByAgentId: workerId,
|
|
payload: { version: 1, questions: [] },
|
|
createdAt: idleAt,
|
|
updatedAt: idleAt,
|
|
});
|
|
const [queue] = await db.insert(decisionQueues).values({
|
|
companyId,
|
|
key: "fast-aging",
|
|
title: "Fast aging",
|
|
retentionDays: 10,
|
|
createdByType: "system",
|
|
}).returning();
|
|
await db.insert(decisionQueueItems).values({
|
|
companyId,
|
|
queueId: queue!.id,
|
|
sourceKind: "approval",
|
|
sourceId: queueApprovalId,
|
|
addedByType: "system",
|
|
});
|
|
|
|
const feed = await attentionService(db, { now: () => now }).list(companyId, {
|
|
userId: "board-user",
|
|
limit: 100,
|
|
});
|
|
const byKey = new Map(feed.items.map((item) => [`${item.sourceKind}:${item.subject.id}`, item]));
|
|
for (const key of [
|
|
`approval:${approvalId}`,
|
|
`issue_thread_interaction:${interactionId}`,
|
|
`review:${reviewIssueId}`,
|
|
]) {
|
|
expect(byKey.get(key)).toMatchObject({ shelf: true, retentionDays: 30, archivedAt: null });
|
|
}
|
|
expect(byKey.get(`approval:${queueApprovalId}`)).toMatchObject({ shelf: true, retentionDays: 10 });
|
|
});
|
|
});
|