mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-23 00:53:38 +02:00
## Thinking Path > - Paperclip helps people manage AI agents for work. > - Agent adapters connect Paperclip to tools such as the Codex command line tool. > - A sandboxed Codex agent may start without a credential. > - The operator needs a safe sign-in flow that does not expose credentials to the shared package or the sandbox. > - This pull request adds a company-scoped device-login flow with a temporary Daytona sandbox. > - The flow promotes the credential only after readiness checks pass and removes the temporary sandbox after use. > - The result lets an operator sign in to a sandboxed Codex agent from the agent form. ## Linked Issues or Issue Description **Subsystem affected** Cross-cutting (multiple of the above) **Problem or motivation** A Codex adapter that runs in a sandbox cannot authenticate when the company has no pre-provisioned Codex credential. **Proposed solution** Add a company-scoped device-login session. Start a temporary sandbox, run `codex login --device-auth`, stream the code and URL, verify readiness, promote the credential, and delete the sandbox. **Alternatives considered** Pre-provisioning a credential does not support first-time sandbox login. Keeping the credential in the login sandbox does not provide a durable company credential. **Roadmap alignment** This supports the roadmap item for cloud and sandbox agents. **Additional context** The flow uses a five-minute cleanup reaper, compare-and-set status changes, and a PostgreSQL advisory lock to protect promotion and cleanup. ## What Changed - Add the adapter login-session contract, database table, and migration. - Add company-scoped server routes and a service for sandbox device login. - Add credential promotion, readiness checks, and cleanup after login. - Add restart-safe cleanup for abandoned login sandboxes. - Add sandbox login controls to the agent creation and edit forms. - Keep device-login and vendor identifiers out of public shared and adapter UI symbols. ## Verification - `pnpm --filter @paperclipai/adapter-codex-local exec vitest run` passed with 310 tests at the submitted commit. - The server login route, service, and reaper tests passed with 45 tests at the submitted commit. - The agent form render tests passed with 26 tests at the submitted commit. - The public-symbol leak check passed at the submitted commit. - A live Daytona sign-in flow still requires confirmation by a user with a live sandbox. ## Risks The migration adds a new company-scoped table. A promotion or cleanup race could remove a credential or leave a sandbox active, so the service uses claims, compare-and-set transitions, and an advisory lock. The live Daytona flow needs operator confirmation because local tests do not provide a real browser sign-in. ## Model Used OpenAI Codex, GPT-5, tool use and code execution, extended reasoning. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes: #` / `Refs: #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
322 lines
12 KiB
TypeScript
322 lines
12 KiB
TypeScript
import fs from "node:fs/promises";
|
|
import os from "node:os";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import type { AdapterExecutionTarget } from "@paperclipai/adapter-utils/execution-target";
|
|
|
|
const {
|
|
ensureAdapterExecutionTargetDirectory,
|
|
ensureAdapterExecutionTargetCommandResolvable,
|
|
maybeRunSandboxInstallCommand,
|
|
runAdapterExecutionTargetProcess,
|
|
describeAdapterExecutionTarget,
|
|
resolveAdapterExecutionTargetCwd,
|
|
prepareAdapterExecutionTargetRuntime,
|
|
prepareManagedCodexHome,
|
|
restoreWorkspace,
|
|
capturedHomeAssetFiles,
|
|
} = vi.hoisted(() => {
|
|
const restoreWorkspace = vi.fn(async () => {});
|
|
// Records the files staged in the uploaded "home" asset at call time, before
|
|
// the probe's cleanup deletes the temp dir. Lets tests assert the upload is a
|
|
// minimal credentials-only home and not the full managed CODEX_HOME.
|
|
const capturedHomeAssetFiles: { value: string[] | null } = { value: null };
|
|
return {
|
|
capturedHomeAssetFiles,
|
|
ensureAdapterExecutionTargetDirectory: vi.fn(async () => {}),
|
|
ensureAdapterExecutionTargetCommandResolvable: vi.fn(async () => {}),
|
|
maybeRunSandboxInstallCommand: vi.fn(async () => null),
|
|
runAdapterExecutionTargetProcess: vi.fn(async () => ({
|
|
exitCode: 0,
|
|
signal: null,
|
|
timedOut: false,
|
|
stdout: [
|
|
"{\"type\":\"thread.started\",\"thread_id\":\"thread-1\"}",
|
|
"{\"type\":\"item.completed\",\"item\":{\"type\":\"agent_message\",\"text\":\"hello\"}}",
|
|
"{\"type\":\"turn.completed\",\"usage\":{\"input_tokens\":1,\"cached_input_tokens\":0,\"output_tokens\":1}}",
|
|
].join("\n"),
|
|
stderr: "",
|
|
pid: 123,
|
|
startedAt: new Date().toISOString(),
|
|
})),
|
|
describeAdapterExecutionTarget: vi.fn(() => "QA SSH"),
|
|
resolveAdapterExecutionTargetCwd: vi.fn((target, configuredCwd, fallbackCwd) => {
|
|
if (typeof configuredCwd === "string" && configuredCwd.trim().length > 0) return configuredCwd;
|
|
if (target && typeof target === "object" && "remoteCwd" in target && typeof target.remoteCwd === "string") {
|
|
return target.remoteCwd;
|
|
}
|
|
return fallbackCwd;
|
|
}),
|
|
prepareAdapterExecutionTargetRuntime: vi.fn(async (input: { assets?: Array<{ key: string; localDir: string }> }) => {
|
|
const homeAsset = input?.assets?.find((asset) => asset.key === "home");
|
|
if (homeAsset) {
|
|
capturedHomeAssetFiles.value = (await fs.readdir(homeAsset.localDir)).sort();
|
|
}
|
|
return {
|
|
target: null,
|
|
workspaceRemoteDir: "/remote/workspace/.paperclip-runtime/runs/test/workspace",
|
|
runtimeRootDir: "/remote/workspace/.paperclip-runtime/runs/test/workspace/.paperclip-runtime/codex",
|
|
assetDirs: {
|
|
home: "/remote/workspace/.paperclip-runtime/runs/test/workspace/.paperclip-runtime/codex/home",
|
|
},
|
|
restoreWorkspace,
|
|
};
|
|
}),
|
|
prepareManagedCodexHome: vi.fn(async () => {
|
|
// Return a real managed home seeded with credentials so the probe's
|
|
// minimal-home copy step (auth.json/config.toml) has something to read.
|
|
const dir = await fs.mkdtemp(`${os.tmpdir()}/paperclip-managed-codex-home-`);
|
|
await fs.writeFile(`${dir}/auth.json`, JSON.stringify({ OPENAI_API_KEY: "sk-managed" }));
|
|
await fs.writeFile(`${dir}/config.toml`, "model = \"gpt-5\"\n");
|
|
return dir;
|
|
}),
|
|
restoreWorkspace,
|
|
};
|
|
});
|
|
|
|
vi.mock("@paperclipai/adapter-utils/execution-target", async () => {
|
|
const actual = await vi.importActual<typeof import("@paperclipai/adapter-utils/execution-target")>(
|
|
"@paperclipai/adapter-utils/execution-target",
|
|
);
|
|
return {
|
|
...actual,
|
|
ensureAdapterExecutionTargetDirectory,
|
|
ensureAdapterExecutionTargetCommandResolvable,
|
|
maybeRunSandboxInstallCommand,
|
|
runAdapterExecutionTargetProcess,
|
|
describeAdapterExecutionTarget,
|
|
resolveAdapterExecutionTargetCwd,
|
|
prepareAdapterExecutionTargetRuntime,
|
|
};
|
|
});
|
|
|
|
vi.mock("./codex-home.js", async () => {
|
|
const actual = await vi.importActual<typeof import("./codex-home.js")>("./codex-home.js");
|
|
return {
|
|
...actual,
|
|
prepareManagedCodexHome,
|
|
};
|
|
});
|
|
|
|
import { testEnvironment } from "./test.js";
|
|
|
|
describe("codex remote environment diagnostics", () => {
|
|
afterEach(() => {
|
|
vi.clearAllMocks();
|
|
delete process.env.OPENAI_API_KEY;
|
|
});
|
|
|
|
it("stages managed CODEX_HOME in an isolated runtime dir and keeps the probe cwd on the original remote workspace", async () => {
|
|
const remoteTarget: AdapterExecutionTarget = {
|
|
kind: "remote",
|
|
transport: "ssh",
|
|
remoteCwd: "/remote/workspace",
|
|
spec: {
|
|
host: "127.0.0.1",
|
|
port: 22,
|
|
username: "agent",
|
|
privateKey: "PRIVATE KEY",
|
|
knownHosts: "KNOWN HOSTS",
|
|
remoteCwd: "/remote/workspace",
|
|
remoteWorkspacePath: "/remote/workspace",
|
|
strictHostKeyChecking: false,
|
|
},
|
|
};
|
|
|
|
const result = await testEnvironment({
|
|
companyId: "company-1",
|
|
adapterType: "codex_local",
|
|
config: {
|
|
engine: "cli",
|
|
command: "codex",
|
|
},
|
|
executionTarget: remoteTarget,
|
|
environmentName: "QA SSH",
|
|
});
|
|
|
|
expect(result.status).toBe("pass");
|
|
expect(result.checks.some((check) => check.code === "codex_hello_probe_passed")).toBe(true);
|
|
expect(prepareManagedCodexHome).toHaveBeenCalledTimes(1);
|
|
expect(prepareAdapterExecutionTargetRuntime).toHaveBeenCalledTimes(1);
|
|
const runtimeCalls = prepareAdapterExecutionTargetRuntime.mock.calls as unknown as Array<[
|
|
{
|
|
workspaceLocalDir: string;
|
|
target?: { remoteCwd?: string };
|
|
workspaceRemoteDir?: string;
|
|
assets?: Array<{ key: string; localDir: string }>;
|
|
},
|
|
]>;
|
|
const runtimeInput = runtimeCalls[0]?.[0];
|
|
// The probe must upload only a minimal credentials-only home, never the
|
|
// full managed CODEX_HOME (which can be hundreds of MB of session history).
|
|
const homeAsset = runtimeInput?.assets?.find((asset) => asset.key === "home");
|
|
expect(homeAsset?.localDir).toContain(`${os.tmpdir()}/paperclip-codex-probe-home-`);
|
|
expect(capturedHomeAssetFiles.value).toEqual(["auth.json", "config.toml"]);
|
|
expect(runtimeInput?.workspaceLocalDir).toContain(`${os.tmpdir()}/paperclip-codex-envtest-`);
|
|
expect(runtimeInput?.workspaceLocalDir).not.toBe("/remote/workspace");
|
|
expect(await fs.stat(runtimeInput!.workspaceLocalDir).catch(() => null)).toBeNull();
|
|
expect(runtimeInput?.target?.remoteCwd).toBe("/remote/workspace");
|
|
// `workspaceRemoteDir` is the base path passed to the runtime; the
|
|
// helper's per-run subdirectory is appended internally inside
|
|
// `prepareRemoteManagedRuntime`. Pre-building a per-run prefix here
|
|
// would double-nest the run id in the final path.
|
|
expect(runtimeInput?.workspaceRemoteDir).toBe("/remote/workspace");
|
|
expect(runAdapterExecutionTargetProcess).toHaveBeenCalledTimes(1);
|
|
const probeCall = runAdapterExecutionTargetProcess.mock.calls[0] as unknown as
|
|
| [string, { kind: string; remoteCwd: string }, string, string[], { cwd: string; env: Record<string, string> }]
|
|
| undefined;
|
|
expect(probeCall?.[1]).toMatchObject({
|
|
kind: "remote",
|
|
remoteCwd: "/remote/workspace",
|
|
});
|
|
expect(probeCall?.[4]).toMatchObject({
|
|
cwd: "/remote/workspace",
|
|
env: expect.objectContaining({
|
|
CODEX_HOME: "/remote/workspace/.paperclip-runtime/runs/test/workspace/.paperclip-runtime/codex/home",
|
|
}),
|
|
});
|
|
expect(restoreWorkspace).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("avoids /tmp CODEX_HOME for remote API-key hello probes", async () => {
|
|
const remoteTarget: AdapterExecutionTarget = {
|
|
kind: "remote",
|
|
transport: "sandbox",
|
|
providerKey: "cloudflare",
|
|
remoteCwd: "/remote/workspace",
|
|
runner: {
|
|
execute: async () => ({
|
|
exitCode: 0,
|
|
signal: null,
|
|
timedOut: false,
|
|
stdout: "",
|
|
stderr: "",
|
|
pid: null,
|
|
startedAt: new Date().toISOString(),
|
|
}),
|
|
},
|
|
};
|
|
|
|
const result = await testEnvironment({
|
|
companyId: "company-1",
|
|
adapterType: "codex_local",
|
|
config: {
|
|
engine: "cli",
|
|
command: "codex",
|
|
env: {
|
|
OPENAI_API_KEY: "sk-test",
|
|
},
|
|
},
|
|
executionTarget: remoteTarget,
|
|
environmentName: "QA Cloudflare",
|
|
});
|
|
|
|
expect(result.status).toBe("pass");
|
|
const probeCall = runAdapterExecutionTargetProcess.mock.calls[0] as unknown as
|
|
| [string, AdapterExecutionTarget, string, string[], { cwd: string; env: Record<string, string> }]
|
|
| undefined;
|
|
expect(probeCall?.[4].env.CODEX_HOME).toContain("/remote/workspace/.paperclip-runtime/codex/probe-home-codex-envtest-");
|
|
expect(probeCall?.[4].env.CODEX_HOME?.startsWith("/tmp/")).toBe(false);
|
|
expect(probeCall?.[3]).toContain("--skip-git-repo-check");
|
|
});
|
|
|
|
it("emits the canonical adapter_auth_missing check when a sandbox hello probe reports missing auth", async () => {
|
|
// The sandbox has no seedable credentials, so the hello probe returns an
|
|
// authentication-required error. The Test must emit the neutral canonical
|
|
// check code. The user interface reads this code to decide login
|
|
// eligibility; it does not parse the message text or the top-level status.
|
|
prepareManagedCodexHome.mockImplementationOnce(async () => {
|
|
const dir = await fs.mkdtemp(`${os.tmpdir()}/paperclip-managed-codex-home-noauth-`);
|
|
await fs.writeFile(`${dir}/config.toml`, "model = \"gpt-5\"\n");
|
|
return dir;
|
|
});
|
|
runAdapterExecutionTargetProcess.mockResolvedValueOnce({
|
|
exitCode: 1,
|
|
signal: null,
|
|
timedOut: false,
|
|
stdout: "",
|
|
stderr: "Not logged in. Please run `codex login` to authenticate.",
|
|
pid: 321,
|
|
startedAt: new Date().toISOString(),
|
|
});
|
|
|
|
const remoteTarget: AdapterExecutionTarget = {
|
|
kind: "remote",
|
|
transport: "sandbox",
|
|
providerKey: "daytona",
|
|
remoteCwd: "/remote/workspace",
|
|
runner: {
|
|
execute: async () => ({
|
|
exitCode: 0,
|
|
signal: null,
|
|
timedOut: false,
|
|
stdout: "",
|
|
stderr: "",
|
|
pid: null,
|
|
startedAt: new Date().toISOString(),
|
|
}),
|
|
},
|
|
};
|
|
|
|
const result = await testEnvironment({
|
|
companyId: "company-1",
|
|
adapterType: "codex_local",
|
|
config: { engine: "cli", command: "codex" },
|
|
executionTarget: remoteTarget,
|
|
environmentName: "QA Daytona",
|
|
});
|
|
|
|
// A missing-auth probe is a warning, not a failure, so the environment stays
|
|
// testable and the user interface can offer login.
|
|
expect(result.status).toBe("warn");
|
|
expect(result.checks.some((check) => check.code === "adapter_auth_missing")).toBe(true);
|
|
// The descriptive probe check stays, so existing diagnostics keep working.
|
|
expect(result.checks.some((check) => check.code === "codex_hello_probe_auth_required")).toBe(true);
|
|
});
|
|
|
|
it("does not override CODEX_HOME when the host has no credentials to seed", async () => {
|
|
// Custom-image flow: the login lives inside the captured snapshot, and the
|
|
// host has no Codex auth.json. The probe must not upload an empty home or
|
|
// set CODEX_HOME, so Codex falls back to the sandbox's baked-in login.
|
|
prepareManagedCodexHome.mockImplementationOnce(async () => {
|
|
const dir = await fs.mkdtemp(`${os.tmpdir()}/paperclip-managed-codex-home-noauth-`);
|
|
// No auth.json — only a config file.
|
|
await fs.writeFile(`${dir}/config.toml`, "model = \"gpt-5\"\n");
|
|
return dir;
|
|
});
|
|
|
|
const remoteTarget: AdapterExecutionTarget = {
|
|
kind: "remote",
|
|
transport: "sandbox",
|
|
providerKey: "daytona",
|
|
remoteCwd: "/remote/workspace",
|
|
runner: {
|
|
execute: async () => ({
|
|
exitCode: 0,
|
|
signal: null,
|
|
timedOut: false,
|
|
stdout: "",
|
|
stderr: "",
|
|
pid: null,
|
|
startedAt: new Date().toISOString(),
|
|
}),
|
|
},
|
|
};
|
|
|
|
const result = await testEnvironment({
|
|
companyId: "company-1",
|
|
adapterType: "codex_local",
|
|
config: { engine: "cli", command: "codex" },
|
|
executionTarget: remoteTarget,
|
|
environmentName: "QA Daytona",
|
|
});
|
|
|
|
expect(result.status).toBe("pass");
|
|
// No managed-home upload, so the full-runtime staging is skipped entirely.
|
|
expect(prepareAdapterExecutionTargetRuntime).not.toHaveBeenCalled();
|
|
const probeCall = runAdapterExecutionTargetProcess.mock.calls[0] as unknown as
|
|
| [string, AdapterExecutionTarget, string, string[], { cwd: string; env: Record<string, string> }]
|
|
| undefined;
|
|
expect(probeCall?.[4].env.CODEX_HOME).toBeUndefined();
|
|
});
|
|
});
|