mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-27 19:35:13 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Issue interactions give agents and people a structured decision record. > - Resolver routes used different authorization rules. > - Some routes blocked valid agents, including task watchdogs with normal issue access. > - The API did not show who could resolve a pending interaction. > - This pull request gives every interaction kind one resolver policy evaluator. > - The benefit is a clear decision path with consistent governance and company isolation. ## Linked Issues or Issue Description Fixes: #8087 Refs: #7403 Related PR: #11082 proposes board-only confirmation rules. This change keeps human-only review as an explicit policy. **What happened?** Agents could create issue interactions. Some resolver routes still required board access. This left valid agent confirmations pending. Task watchdogs could see the same problem without board identity. **Expected behavior** Every interaction kind must use one resolver policy contract. The contract must support `anyone`, `not_creator`, and `human_only`. It must also apply all normal governance controls. **Steps to reproduce** 1. Create a `request_confirmation` interaction as an agent. 2. Resolve it with another authorized agent. 3. Observe the board-only denial. **Paperclip version or commit** The problem exists on `master` before this change. **Deployment mode** Local development with `pnpm dev`. ## What Changed - Add canonical policies for `anyone`, `not_creator`, and `human_only`. - Use one server evaluator for every interaction kind. - Apply named addressees, company limits, review rules, and task watchdog scope. - Charge cross-issue resolutions to the existing per-run action limit. - Return the effective resolver audience in attention and interaction data. - Show the audience, governance choices, and denial reasons in the board UI. - Add telemetry, API documents, product documents, and regression fixtures. - Add migration provenance for safe legacy behavior. - Make migration `0218` safe for complete replays and partial prior runs. ## Product Rules - An interaction records a response. It does not grant authority for the next action. - `anyone` lets any authorized issue participant respond. - `not_creator` requires a responder other than the interaction creator. - `human_only` requires an authorized person. - A named addressee, company policy, or governed action can narrow the audience. - These controls cannot widen the audience. - A task watchdog uses the same rules as an ordinary agent. - A task watchdog does not receive board authority. - An agent resolution on another issue uses the shared cross-issue action limit. - Legacy pending interactions keep their earlier restrictions. - The UI shows the effective audience and a permanent denial reason. ## Verification - `pnpm --filter @paperclipai/db check:migrations` - `pnpm --filter @paperclipai/db typecheck` - `pnpm exec vitest run packages/db/src/issue-thread-interaction-resolver-policy-migration.test.ts` - The focused PostgreSQL test applies migration `0218` twice. - The test also completes a partial prior run and preserves existing provenance. - The latest GitHub head has 29 successful checks. - The opt-in Storybook visual check skipped as expected. - Greptile reports 5/5 with no open comments. ## Risks - New interaction writes use `anyone` by default. - Callers must select `not_creator` or `human_only` when they need stricter review. - Legacy pending interactions keep the old creator and human restrictions. - Migration `0218` fills only missing provenance fields during recovery. - Cross-issue resolutions can reach the existing action limit. - The shared evaluator affects every interaction kind. - Route, service, database, shared contract, and UI tests cover these rules. > This work matches the Agent Reviews and Approvals direction in `ROADMAP.md`. It does not duplicate a planned item. ## Model Used OpenAI Codex, GPT-5. The runtime does not expose the exact deployment ID or context window. The agent used reasoning, repository tools, shell commands, and test execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either linked public issues or described the issue with the required labels - [x] I have not referenced internal Paperclip issues or links - [x] My branch name describes the change and contains no internal ticket id - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation - [x] I have considered and documented the risks - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open comments - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
148 lines
4.6 KiB
TypeScript
148 lines
4.6 KiB
TypeScript
import { describe, expect, it, vi } from "vitest";
|
|
import {
|
|
trackAgentCreated,
|
|
trackAgentFirstHeartbeat,
|
|
trackAgentTaskCompleted,
|
|
trackInteractionCreated,
|
|
trackInteractionResolved,
|
|
trackInstallCompleted,
|
|
} from "@paperclipai/shared/telemetry";
|
|
import type { EventDimensionsMap, TelemetryClient } from "@paperclipai/shared/telemetry";
|
|
|
|
function createClient(): TelemetryClient {
|
|
return {
|
|
track: vi.fn(),
|
|
hashPrivateRef: vi.fn((value: string) => `hashed:${value}`),
|
|
} as unknown as TelemetryClient;
|
|
}
|
|
|
|
function runtimeValue<T>(value: string): T {
|
|
return value as T;
|
|
}
|
|
|
|
describe("shared telemetry agent events", () => {
|
|
it("includes agent_id for agent.created", () => {
|
|
const client = createClient();
|
|
|
|
trackAgentCreated(client, {
|
|
agentRole: "engineer",
|
|
agentId: "11111111-1111-4111-8111-111111111111",
|
|
});
|
|
|
|
expect(client.track).toHaveBeenCalledWith("agent.created", {
|
|
agent_role: "engineer",
|
|
agent_id: "11111111-1111-4111-8111-111111111111",
|
|
});
|
|
});
|
|
|
|
it("passes an unrecognized agent role through for backend normalization", () => {
|
|
const client = createClient();
|
|
|
|
trackAgentCreated(client, {
|
|
agentRole: runtimeValue<EventDimensionsMap["agent.created"]["agent_role"]>("coder"),
|
|
agentId: "44444444-4444-4444-8444-444444444444",
|
|
});
|
|
|
|
expect(client.track).toHaveBeenCalledWith("agent.created", {
|
|
agent_role: "coder",
|
|
agent_id: "44444444-4444-4444-8444-444444444444",
|
|
});
|
|
});
|
|
|
|
it("includes agent_id for agent.first_heartbeat", () => {
|
|
const client = createClient();
|
|
|
|
trackAgentFirstHeartbeat(client, {
|
|
agentRole: "engineer",
|
|
agentId: "22222222-2222-4222-8222-222222222222",
|
|
});
|
|
|
|
expect(client.track).toHaveBeenCalledWith("agent.first_heartbeat", {
|
|
agent_role: "engineer",
|
|
agent_id: "22222222-2222-4222-8222-222222222222",
|
|
});
|
|
});
|
|
|
|
it("includes agent_id for agent.task_completed", () => {
|
|
const client = createClient();
|
|
|
|
trackAgentTaskCompleted(client, {
|
|
agentRole: "qa",
|
|
agentId: "33333333-3333-4333-8333-333333333333",
|
|
adapterType: "codex_local",
|
|
});
|
|
|
|
expect(client.track).toHaveBeenCalledWith("agent.task_completed", {
|
|
agent_role: "qa",
|
|
agent_id: "33333333-3333-4333-8333-333333333333",
|
|
adapter_type: "codex_local",
|
|
});
|
|
});
|
|
|
|
it("keeps non-agent event dimensions unchanged", () => {
|
|
const client = createClient();
|
|
|
|
trackInstallCompleted(client, { adapterType: "codex_local" });
|
|
|
|
expect(client.track).toHaveBeenCalledWith("install.completed", {
|
|
adapter_type: "codex_local",
|
|
});
|
|
expect(client.track).not.toHaveBeenCalledWith(
|
|
"install.completed",
|
|
expect.objectContaining({ agent_id: expect.any(String) }),
|
|
);
|
|
});
|
|
|
|
it("passes interaction.resolved enum dimensions through for backend normalization", () => {
|
|
const client = createClient();
|
|
|
|
trackInteractionResolved(client, {
|
|
interactionKind: runtimeValue<EventDimensionsMap["interaction.resolved"]["interaction_kind"]>(
|
|
"single_confirmation",
|
|
),
|
|
status: "accepted",
|
|
resolvedByKind: runtimeValue<EventDimensionsMap["interaction.resolved"]["resolved_by_kind"]>("operator"),
|
|
resolutionReason: "accepted",
|
|
createdByKind: "agent",
|
|
creatorAgentRole: runtimeValue<EventDimensionsMap["interaction.resolved"]["creator_agent_role"]>("coder"),
|
|
continuationPolicy: runtimeValue<EventDimensionsMap["interaction.resolved"]["continuation_policy"]>(
|
|
"wake_everyone",
|
|
),
|
|
targetType: "issue_document",
|
|
optionCount: 2,
|
|
selectedOptionCount: 1,
|
|
skippedTaskCount: 3,
|
|
legacyInheritedRestriction: true,
|
|
});
|
|
|
|
expect(client.track).toHaveBeenCalledWith("interaction.resolved", {
|
|
interaction_kind: "single_confirmation",
|
|
status: "accepted",
|
|
resolved_by_kind: "operator",
|
|
resolution_reason: "accepted",
|
|
created_by_kind: "agent",
|
|
creator_agent_role: "coder",
|
|
continuation_policy: "wake_everyone",
|
|
target_type: "issue_document",
|
|
option_count: 2,
|
|
selected_option_count: 1,
|
|
skipped_task_count: 3,
|
|
legacy_inherited_restriction: true,
|
|
});
|
|
});
|
|
|
|
it("emits only enum and boolean dimensions for interaction creation compatibility", () => {
|
|
const client = createClient();
|
|
|
|
trackInteractionCreated(client, {
|
|
interactionKind: "request_confirmation",
|
|
usedDeprecatedResolverPolicyAlias: true,
|
|
});
|
|
|
|
expect(client.track).toHaveBeenCalledWith("interaction.created", {
|
|
interaction_kind: "request_confirmation",
|
|
used_deprecated_resolver_policy_alias: true,
|
|
});
|
|
});
|
|
});
|