mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-14 17:22:00 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
109 lines
8.6 KiB
TypeScript
109 lines
8.6 KiB
TypeScript
import type { ChatCatalogCase, ChatCatalogGrade } from "./chat-catalog-contract.js";
|
|
import type { ChatIssue, ChatRun } from "./chat-flow.js";
|
|
type CancellationCase = Pick<ChatCatalogCase, "runPolicy"> & Partial<Pick<ChatCatalogCase, "scenarioId" | "expectedCancelledWorkerRun">>;
|
|
export function assertExpectedWorkerCancellation(implementation: CancellationCase) {
|
|
const flag = implementation.runPolicy?.kind === "source-settled-with-active-work"
|
|
? implementation.runPolicy.expectedWorkerCancellation : undefined;
|
|
if (flag === undefined ? implementation.expectedCancelledWorkerRun !== undefined
|
|
: flag !== "owned-task-reassignment" || implementation.scenarioId !== "tasks.edit-properties" || typeof implementation.expectedCancelledWorkerRun !== "function")
|
|
throw new Error("Missing or undeclared exact task-reassignment cancellation proof");
|
|
}
|
|
function permitsReassignment(implementation: CancellationCase) {
|
|
return implementation.scenarioId === "tasks.edit-properties" && implementation.runPolicy?.kind === "source-settled-with-active-work"
|
|
&& implementation.runPolicy.expectedWorkerCancellation === "owned-task-reassignment" && typeof implementation.expectedCancelledWorkerRun === "function";
|
|
}
|
|
export function chatCatalogAllowedRunStatuses(implementation: CancellationCase): string[] {
|
|
const policy = implementation.runPolicy;
|
|
return policy?.kind === "terminal-counts" ? Object.keys(policy.terminalStatusCounts)
|
|
: policy?.kind === "source-settled-with-active-work" ? ["queued", "running", "succeeded", ...(permitsReassignment(implementation) ? ["cancelled"] : [])] : ["succeeded"];
|
|
}
|
|
const taskId = (run: ChatRun) => (run as ChatRun & { nativeIssueId?: string }).nativeIssueId ?? run.contextSnapshot?.issueId;
|
|
const record = (value: unknown) => value && typeof value === "object" ? value as Record<string, unknown> : {};
|
|
/** Early polling can defer only the saved, independently held worker, never a source or unrelated cancellation. */
|
|
export function chatCatalogRunStatusAllowed(input: {
|
|
implementation: CancellationCase; run: ChatRun; companyId: string; leadId: string; source?: ChatIssue; observation?: unknown;
|
|
}): boolean {
|
|
const { implementation, run } = input;
|
|
if (run.status !== "cancelled" || !permitsReassignment(implementation)) return chatCatalogAllowedRunStatuses(implementation).includes(run.status);
|
|
const state = record(record(input.observation).state), held = record(state.heldRun), task = record(state.heldTask), worker = record(state.riley);
|
|
return held.id === run.id && held.status === "running" && held.companyId === input.companyId && held.agentId === worker.id
|
|
&& run.companyId === input.companyId && run.agentId === worker.id && run.agentId !== input.leadId
|
|
&& task.companyId === input.companyId && task.assigneeAgentId === worker.id && task.executionRunId === run.id
|
|
&& task.id === taskId(run) && task.id !== input.source?.id && run.errorCode === "issue_reassigned";
|
|
}
|
|
/**
|
|
* A queued run that never started and that the server cancelled because its own
|
|
* non-source task reached a terminal status is a task lifecycle event, not a
|
|
* provider failure. Early polling must not stop on it; the run stays in the
|
|
* ledger, and the run-bound and case checks still grade it.
|
|
*/
|
|
export function chatCatalogNeverStartedTerminalTaskRun(run: ChatRun, source?: ChatIssue): boolean {
|
|
const issueId = taskId(run);
|
|
return run.status === "cancelled" && run.errorCode === "issue_terminal_status" && !run.startedAt
|
|
&& record(run.resultJson).stopReason === "issue_terminal_status"
|
|
&& typeof issueId === "string" && issueId.length > 0 && issueId !== source?.id;
|
|
}
|
|
export function gradeChatCatalogRuns(input: {
|
|
implementation: Pick<ChatCatalogCase, "expectedRunCount" | "minimumRunCount" | "runPolicy"> & CancellationCase;
|
|
companyId: string; leadId: string; source?: ChatIssue; runs: ChatRun[];
|
|
observation?: unknown;
|
|
}): ChatCatalogGrade {
|
|
const { implementation: c, runs, source } = input;
|
|
const checks = [
|
|
{ id: "catalog-bounded-native-runs", passed: runs.length >= (c.minimumRunCount ?? c.expectedRunCount) && runs.length <= c.expectedRunCount
|
|
&& runs.every(run => run.companyId === input.companyId && run.runtimeMode === "native" && chatCatalogAllowedRunStatuses(c).includes(run.status)),
|
|
detail: "Observed provider runs satisfy declared count, company, native runtime and allowed outcome bounds." },
|
|
];
|
|
if (c.expectedCancelledWorkerRun !== undefined || c.runPolicy?.kind === "source-settled-with-active-work" && c.runPolicy.expectedWorkerCancellation !== undefined) {
|
|
let valid = true; try { assertExpectedWorkerCancellation(c); } catch { valid = false; }
|
|
checks.push({ id: "catalog-worker-cancellation-declaration", passed: valid,
|
|
detail: "Only edit-properties may declare the exact independently proved worker reassignment cancellation." });
|
|
}
|
|
if (c.runPolicy?.kind === "terminal-counts") {
|
|
checks.push({ id: "catalog-exact-run-outcomes", passed: Object.entries(c.runPolicy.terminalStatusCounts).every(([status, count]) => runs.filter(run => run.status === status).length === count),
|
|
detail: "The independently observed ledger matches every declared successful/cancelled/failed terminal outcome count." });
|
|
} else if (c.runPolicy?.kind === "source-settled-with-active-work") {
|
|
const sourceRuns = runs.filter(run => taskId(run) === source?.id);
|
|
const workers = runs.filter(run => taskId(run) !== source?.id);
|
|
const cancelled = runs.filter(run => run.status === "cancelled");
|
|
const declared = permitsReassignment(c);
|
|
let expected: ReturnType<NonNullable<ChatCatalogCase["expectedCancelledWorkerRun"]>>;
|
|
try { expected = declared ? c.expectedCancelledWorkerRun!(input.observation) : undefined; } catch { expected = undefined; }
|
|
const actual = expected && workers.find(run => run.id === expected.runId);
|
|
const acknowledgement = actual?.resultJson?.nativeCancellation as Record<string, unknown> | undefined;
|
|
const exact = !!expected && cancelled.length === 1 && cancelled[0]?.id === expected.runId && !!actual
|
|
&& chatCatalogRunStatusAllowed({ ...input, run: actual })
|
|
&& actual.companyId === input.companyId && actual.agentId === expected.workerId && actual.agentId !== input.leadId
|
|
&& taskId(actual) === expected.taskId && expected.taskId !== source?.id && actual.errorCode === "issue_reassigned"
|
|
&& actual.resultJson?.reassignmentStopConfirmed === true
|
|
&& acknowledgement?.schema === "paperclip.native-cancellation.v1" && acknowledgement.runId === actual.id
|
|
&& acknowledgement.issueId === expected.taskId && acknowledgement.companyId === input.companyId
|
|
&& acknowledgement.dispatchState === "acknowledged" && typeof acknowledgement.acknowledgedAt === "string" && Number.isFinite(Date.parse(acknowledgement.acknowledgedAt))
|
|
&& typeof acknowledgement.intentAuditId === "string" && acknowledgement.intentAuditId.length > 0
|
|
&& typeof acknowledgement.acknowledgementAuditId === "string" && acknowledgement.acknowledgementAuditId.length > 0
|
|
&& sourceRuns.some(run => run.id === expected.sourceRunId && run.agentId === input.leadId && run.status === "succeeded");
|
|
checks.push({ id: "catalog-exact-owned-worker-cancellation", passed: cancelled.length === 0 ? expected === undefined : declared && exact,
|
|
detail: "Only the exact independently proved task-reassignment cancellation is accepted; final actor, chronology and saved-state proof remains mandatory in the case callback." });
|
|
checks.push({ id: "catalog-settled-source-separate-work", passed: !!source && source.companyId === input.companyId
|
|
&& source.conversationState === "waiting" && sourceRuns.length > 0 && sourceRuns.every(run => run.agentId === input.leadId && run.status === "succeeded")
|
|
&& workers.every(run => typeof taskId(run) === "string" && run.agentId !== input.leadId)
|
|
&& workers.filter(run => ["queued", "running"].includes(run.status)).length <= c.runPolicy.maximumActiveWorkerRuns,
|
|
detail: "The CEO source is settled; unfinished worker runs are separately task-bound and bounded. The case oracle must additionally bind their exact task and assignee." });
|
|
}
|
|
return { passed: checks.every(check => check.passed), checks };
|
|
}
|
|
|
|
|
|
export type ChatCatalogFinalRunVerifier = (source: ChatIssue | undefined, runs: ChatRun[]) => ChatCatalogGrade;
|
|
|
|
/** Preserve the loaded case's proof callback for a fresh outer ledger read. */
|
|
export function createChatCatalogFinalRunVerifier(input: {
|
|
implementation: Parameters<typeof gradeChatCatalogRuns>[0]["implementation"];
|
|
companyId: string;
|
|
leadId: string;
|
|
observation: unknown;
|
|
}): ChatCatalogFinalRunVerifier {
|
|
assertExpectedWorkerCancellation(input.implementation);
|
|
return (source, runs) => gradeChatCatalogRuns({ ...input, source, runs });
|
|
}
|