mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-20 18:26:40 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Hosted Paperclip Cloud records browser sessions with PostHog session replay > - Replay masked all text and showed only an allowlist of chrome, so most replays showed only stars > - The team cannot see how people use the board, and the allowlist needed a review for each new label > - The owner decided to show text by default and mask only marked customer content, the way PostHog normally works > - This pull request flips the default, removes the allowlist, and marks every surface that can show connected-account content > - The benefit is readable replays, while Google user data and Slack data stay masked ## Linked Issues or Issue Description **Subsystem affected** Hosted Cloud browser analytics: PostHog session replay in the board UI (`ui/src/lib/analytics/`). **Problem or motivation** Replay masked every text node. Only sidebar items and opt-in components showed text. Replays were almost unreadable. Each new label needed an `analyticsChrome` opt-in and an allowlist review. **Proposed solution** Record text as it is. Mask text only inside `ph-mask` (customer content), `ph-no-capture` (secrets, blocked) and editable content. Add `ANALYTICS_MASK_CLASS` to every surface that can show connected-account content (Gmail, Calendar, Drive and Docs, Slack) or other free-form text from agents or customers. **Alternatives considered** Keep "mask all" and grow the allowlist. This needs a review for each label and still hides most of the board. ## What Changed - `privacy.ts`: `ANALYTICS_MASK_TEXT_SELECTOR` is now `.ph-mask, .ph-no-capture, [contenteditable]:not([contenteditable="false"])`. rrweb masks a text node only when its parent or an ancestor matches the selector. Removed `maskReplayText`, `isReplayTextRevealed`, `ANALYTICS_UNMASK_ATTRIBUTE` and `ANALYTICS_UNMASK_PROPS`. - `product-analytics.ts`: removed `maskTextFn`, so rrweb uses its default star masking. `maskAllInputs`, `blockClass`, `maskAttributeFn`, `mask_all_text` and `mask_all_element_attributes` do not change. - Removed the `analyticsChrome` prop from `Button`, `Label`, `TabsTrigger`, `EmptyState` and `SidebarNavItem`, and from all sidebar call sites. - Added `ANALYTICS_MASK_CLASS` to the content element (not the chrome) of these surfaces: - Link preview cards, task quicklook description, external object pills and rows, related-work titles. - Email message cards and email send intents. - Connected account names and email addresses (Browse, Connections, app detail headers, app sidebar, connection choice list, connection access and repair cards), GitHub login and repositories, Slack workspace names, chat channel and linked user labels. - Inbox and decision rows (subject and detail), obligation evidence, Needs You notes and receipts, decision options and result summaries, and the interaction card roots (questions, options, answers, tool action requests, suggested tasks). - Approval payloads, action card input and reason, recovery card headline, evidence and options, run ledger retry detail, interrupt handoff previews. - Run transcripts, run failure details and run events on the agent page. - Search result snippets, toast bodies, voice and call transcripts, case summary, files and fields, attachment previews, artifact previews (text, tables, patches and documents). - Replaced `unmask-allowlist.test.ts` with `replay-masking.test.tsx`. It checks that unmarked chrome records as it is, that each marker masks, that a rendered voice transcript and run transcript mask, that each surface above has the class, and that autocapture records no element text. Updated `privacy.test.ts`, `shared-chrome.test.tsx` and `product-analytics.test.ts`. - Updated `doc/cloud-browser-analytics.md`: new default, marker classes, masked surfaces, and residual risk. ## Verification - `pnpm exec vitest run src/lib/analytics` in `ui/`: 83 tests pass. - Vitest for the 48 test files next to the changed components: 994 tests pass. - `tsc --noEmit -p ui/tsconfig.json`: no new errors (only the existing generated Storybook catalog errors). - `pnpm verify` exits 2 because a doc is a global CI input. Required CI supplies the broad coverage. - Manual: I ran an isolated local instance with a Cloud-like browser analytics config. `PAPERCLIP_POSTHOG_HOST` pointed to a local capture server, not PostHog. I opened a task page in headless Chromium, hovered a GitHub pull request link, and decoded the captured `/s/` replay payloads: - Clear text: sidebar (`New task`, `Chat`, `Tasks`, `Inbox`, `More`), breadcrumb, task title `Quarterly launch checklist`, `REP-1`, the Connectors promo heading and button. - Masked (stars only): the markdown task body, the chat comment, the link preview card (pull request title, author, URL, status), and the company menu. - Marker strings in the body, comment and preview never appeared in clear text in any payload. - The page `<title>` (task title and company name) is in the replay head. This is accepted residual risk. ## Risks - Text that is not marked is now recorded. Task titles, agent names, project names, company names, routine names, artifact and document titles, and activity rows are visible in replays. The owner accepted this. An agent can copy email or Slack text into a task title. - A new surface that shows connected-account content without `ANALYTICS_MASK_CLASS` is recorded until somebody marks it. `replay-masking.test.tsx` and the doc list the marked surfaces. - The masking options in `posthog.init` take precedence over the PostHog project masking settings (posthog-js 1.450), so a dashboard change cannot unmask content. Keep the project settings empty to avoid a console warning. - Some masked areas also mask nearby fixed labels (for example the interaction card buttons). This is safe. - Analytics is off on self-hosted and local installs, so they see no change. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - Claude Opus 5.5 (claude-opus-5-5), Anthropic, with tool use and code execution in Claude Code. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
684 lines
24 KiB
TypeScript
684 lines
24 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act } from "react";
|
|
import type { ComponentProps, ReactNode } from "react";
|
|
import { createRoot, type Root } from "react-dom/client";
|
|
import type { ActivityEvent, Issue, RunLivenessState } from "@paperclipai/shared";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import type { RunForIssue } from "../api/activity";
|
|
import type { ActiveRunForIssue } from "../api/heartbeats";
|
|
import { IssueRunLedgerContent } from "./IssueRunLedger";
|
|
import { replayLeaks } from "@/lib/analytics/replay-recording.test-utils";
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({ children, to, ...props }: { children: ReactNode; to: string } & ComponentProps<"a">) => (
|
|
<a href={to} {...props}>{children}</a>
|
|
),
|
|
}));
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
let container: HTMLDivElement;
|
|
let root: Root;
|
|
|
|
beforeEach(() => {
|
|
vi.useFakeTimers();
|
|
vi.setSystemTime(new Date("2026-04-18T20:00:00.000Z"));
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
});
|
|
|
|
afterEach(() => {
|
|
act(() => root.unmount());
|
|
container.remove();
|
|
vi.useRealTimers();
|
|
});
|
|
|
|
function render(ui: ReactNode) {
|
|
act(() => {
|
|
root.render(ui);
|
|
});
|
|
}
|
|
|
|
function createRun(overrides: Partial<RunForIssue> = {}): RunForIssue {
|
|
return {
|
|
runId: "run-00000000",
|
|
status: "succeeded",
|
|
agentId: "agent-1",
|
|
adapterType: "codex_local",
|
|
startedAt: "2026-04-18T19:58:00.000Z",
|
|
finishedAt: "2026-04-18T19:59:00.000Z",
|
|
createdAt: "2026-04-18T19:58:00.000Z",
|
|
invocationSource: "assignment",
|
|
usageJson: null,
|
|
resultJson: null,
|
|
livenessState: "advanced",
|
|
livenessReason: "Run produced concrete action evidence: 2 activity event(s)",
|
|
continuationAttempt: 0,
|
|
lastUsefulActionAt: "2026-04-18T19:59:00.000Z",
|
|
nextAction: null,
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function createActivity(overrides: Partial<ActivityEvent> = {}): ActivityEvent {
|
|
return {
|
|
id: "activity-1",
|
|
companyId: "company-1",
|
|
actorType: "system",
|
|
actorId: "system",
|
|
action: "issue.updated",
|
|
entityType: "issue",
|
|
entityId: "issue-1",
|
|
agentId: null,
|
|
runId: null,
|
|
details: null,
|
|
createdAt: new Date("2026-04-18T19:57:00.000Z"),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function createIssue(overrides: Partial<Issue> = {}): Issue {
|
|
return {
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Child issue",
|
|
description: null,
|
|
status: "todo",
|
|
priority: "medium",
|
|
reviewPolicy: null,
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
responsibleUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: null,
|
|
issueNumber: null,
|
|
identifier: "PAP-1",
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
createdAt: new Date("2026-04-18T19:00:00.000Z"),
|
|
updatedAt: new Date("2026-04-18T19:00:00.000Z"),
|
|
...overrides,
|
|
workMode: overrides.workMode ?? "standard",
|
|
};
|
|
}
|
|
|
|
function createActiveRun(overrides: Partial<ActiveRunForIssue> = {}): ActiveRunForIssue {
|
|
return {
|
|
id: "run-live-1",
|
|
status: "running",
|
|
invocationSource: "assignment",
|
|
triggerDetail: null,
|
|
startedAt: "2026-04-18T19:58:00.000Z",
|
|
finishedAt: null,
|
|
createdAt: "2026-04-18T19:58:00.000Z",
|
|
agentId: "agent-1",
|
|
agentName: "CodexCoder",
|
|
adapterType: "codex_local",
|
|
outputSilence: {
|
|
lastOutputAt: "2026-04-18T19:00:00.000Z",
|
|
lastOutputSeq: 4,
|
|
lastOutputStream: "stdout",
|
|
silenceStartedAt: "2026-04-18T19:30:00.000Z",
|
|
silenceAgeMs: 45 * 60 * 1000,
|
|
level: "critical",
|
|
suspicionThresholdMs: 10 * 60 * 1000,
|
|
criticalThresholdMs: 30 * 60 * 1000,
|
|
snoozedUntil: null,
|
|
evaluationIssueId: "issue-eval-1",
|
|
evaluationIssueIdentifier: "PAP-404",
|
|
evaluationIssueAssigneeAgentId: "agent-owner",
|
|
},
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function renderLedger(props: Partial<ComponentProps<typeof IssueRunLedgerContent>> = {}) {
|
|
render(
|
|
<IssueRunLedgerContent
|
|
runs={props.runs ?? []}
|
|
liveRuns={props.liveRuns}
|
|
activeRun={props.activeRun}
|
|
issueStatus={props.issueStatus ?? "in_progress"}
|
|
childIssues={props.childIssues ?? []}
|
|
agentMap={props.agentMap ?? new Map([["agent-1", { name: "CodexCoder" }]])}
|
|
activityEvents={props.activityEvents}
|
|
renderActivityEvent={props.renderActivityEvent}
|
|
resolveUserLabel={props.resolveUserLabel}
|
|
pendingWatchdogDecision={props.pendingWatchdogDecision}
|
|
canRecordWatchdogDecisions={props.canRecordWatchdogDecisions}
|
|
watchdogDecisionError={props.watchdogDecisionError}
|
|
onWatchdogDecision={props.onWatchdogDecision}
|
|
/>,
|
|
);
|
|
}
|
|
|
|
describe("IssueRunLedger", () => {
|
|
it("renders every liveness state with exhausted continuation context", () => {
|
|
const states: RunLivenessState[] = [
|
|
"advanced",
|
|
"plan_only",
|
|
"empty_response",
|
|
"blocked",
|
|
"failed",
|
|
"completed",
|
|
"needs_followup",
|
|
];
|
|
|
|
renderLedger({
|
|
runs: states.map((state, index) =>
|
|
createRun({
|
|
runId: `run-${index}0000000`,
|
|
createdAt: `2026-04-18T19:5${index}:00.000Z`,
|
|
livenessState: state,
|
|
livenessReason: state === "needs_followup"
|
|
? "Run produced useful output but no concrete action evidence; continuation attempts exhausted"
|
|
: `state ${state}`,
|
|
continuationAttempt: state === "needs_followup" ? 3 : 0,
|
|
}),
|
|
),
|
|
});
|
|
|
|
expect(container.textContent).toContain("Advanced");
|
|
expect(container.textContent).toContain("Plan only");
|
|
expect(container.textContent).toContain("Empty response");
|
|
expect(container.textContent).toContain("Blocked");
|
|
expect(container.textContent).toContain("Failed");
|
|
expect(container.textContent).toContain("Completed");
|
|
expect(container.textContent).toContain("Needs follow-up");
|
|
expect(container.textContent).toContain("Exhausted");
|
|
expect(container.textContent).toContain("Continuation attempt 3");
|
|
});
|
|
|
|
it("renders historical runs without liveness metadata as unavailable", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
livenessState: null,
|
|
livenessReason: null,
|
|
continuationAttempt: undefined,
|
|
lastUsefulActionAt: null,
|
|
nextAction: null,
|
|
resultJson: null,
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("No liveness data");
|
|
expect(container.textContent).toContain("Stop Unavailable");
|
|
expect(container.textContent).toContain("Last useful action Unavailable");
|
|
});
|
|
|
|
it("interleaves run rows and activity rows by timestamp", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-oldest",
|
|
startedAt: "2026-04-18T19:55:00.000Z",
|
|
createdAt: "2026-04-18T19:55:00.000Z",
|
|
}),
|
|
createRun({
|
|
runId: "run-newest",
|
|
startedAt: "2026-04-18T19:59:00.000Z",
|
|
createdAt: "2026-04-18T19:59:00.000Z",
|
|
}),
|
|
],
|
|
activityEvents: [
|
|
createActivity({
|
|
id: "activity-middle",
|
|
action: "activity-middle",
|
|
createdAt: new Date("2026-04-18T19:57:00.000Z"),
|
|
}),
|
|
],
|
|
renderActivityEvent: (event) => (
|
|
<div data-testid={`activity-${event.id}`}>{event.action}</div>
|
|
),
|
|
});
|
|
|
|
const text = container.textContent ?? "";
|
|
const newestIndex = text.indexOf("run-newe");
|
|
const activityIndex = text.indexOf("activity-middle");
|
|
const oldestIndex = text.indexOf("run-olde");
|
|
|
|
expect(newestIndex).toBeGreaterThanOrEqual(0);
|
|
expect(activityIndex).toBeGreaterThan(newestIndex);
|
|
expect(oldestIndex).toBeGreaterThan(activityIndex);
|
|
});
|
|
|
|
it("shows live runs as pending final checks without missing-data language", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
status: "running",
|
|
finishedAt: null,
|
|
livenessState: null,
|
|
livenessReason: null,
|
|
continuationAttempt: 0,
|
|
lastUsefulActionAt: null,
|
|
nextAction: null,
|
|
resultJson: null,
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("Running now by CodexCoder");
|
|
expect(container.textContent).toContain("Checks after finish");
|
|
expect(container.textContent).toContain("Last useful action No action recorded yet");
|
|
expect(container.textContent).toContain("Stop Still running");
|
|
expect(container.textContent).not.toContain("Liveness pending");
|
|
expect(container.textContent).not.toContain("initial attempt");
|
|
});
|
|
|
|
it("surfaces scheduled retry timing and exhaustion state without opening logs", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-scheduled",
|
|
status: "scheduled_retry",
|
|
finishedAt: null,
|
|
livenessState: null,
|
|
livenessReason: null,
|
|
retryOfRunId: "run-root",
|
|
scheduledRetryAt: "2026-04-18T20:15:00.000Z",
|
|
scheduledRetryAttempt: 2,
|
|
scheduledRetryReason: "transient_failure",
|
|
}),
|
|
createRun({
|
|
runId: "run-exhausted",
|
|
status: "failed",
|
|
createdAt: "2026-04-18T19:57:00.000Z",
|
|
retryOfRunId: "run-root",
|
|
scheduledRetryAttempt: 4,
|
|
scheduledRetryReason: "transient_failure",
|
|
retryExhaustedReason: "Bounded retry exhausted after 4 scheduled attempts; no further automatic retry will be queued",
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("Retry scheduled");
|
|
expect(container.textContent).toContain("Attempt 2");
|
|
expect(container.textContent).toContain("Transient failure");
|
|
expect(container.textContent).toContain("Next retry");
|
|
expect(container.textContent).toContain("Retry exhausted");
|
|
expect(container.textContent).toContain("no further automatic retry will be queued");
|
|
expect(container.textContent).toContain("Manual intervention required");
|
|
expect(replayLeaks("Bounded retry exhausted after 4 scheduled attempts", container)).toEqual({ rendered: true, recorded: false });
|
|
});
|
|
|
|
it("labels max-turn stops and continuation retries without confusing them with per-run turns", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-scheduled-continuation",
|
|
status: "scheduled_retry",
|
|
finishedAt: null,
|
|
livenessState: null,
|
|
livenessReason: null,
|
|
retryOfRunId: "run-max-turns",
|
|
scheduledRetryAt: "2026-04-18T20:15:00.000Z",
|
|
scheduledRetryAttempt: 1,
|
|
scheduledRetryReason: "max_turns_continuation",
|
|
}),
|
|
createRun({
|
|
runId: "run-max-turns",
|
|
resultJson: { stopReason: "max_turns_exhausted" },
|
|
createdAt: "2026-04-18T19:57:00.000Z",
|
|
}),
|
|
createRun({
|
|
runId: "run-continuation-exhausted",
|
|
status: "failed",
|
|
createdAt: "2026-04-18T19:56:00.000Z",
|
|
retryOfRunId: "run-max-turns",
|
|
scheduledRetryAttempt: 3,
|
|
scheduledRetryReason: "max_turns_continuation",
|
|
retryExhaustedReason: "Bounded retry exhausted after 3 scheduled attempts; no further automatic retry will be queued",
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("Continuation scheduled");
|
|
expect(container.textContent).toContain("Max-turn continuation");
|
|
expect(container.textContent).toContain("Next continuation");
|
|
expect(container.textContent).toContain("Stop max turns exhausted");
|
|
expect(container.textContent).toContain("Continuation exhausted");
|
|
});
|
|
|
|
it("shows timeout, cancel, and budget stop reasons without raw logs", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-timeout",
|
|
resultJson: { stopReason: "timeout", timeoutFired: true, effectiveTimeoutSec: 30 },
|
|
}),
|
|
createRun({
|
|
runId: "run-cancel",
|
|
resultJson: { stopReason: "cancelled" },
|
|
createdAt: "2026-04-18T19:57:00.000Z",
|
|
}),
|
|
createRun({
|
|
runId: "run-budget",
|
|
resultJson: { stopReason: "budget_paused" },
|
|
createdAt: "2026-04-18T19:56:00.000Z",
|
|
}),
|
|
createRun({
|
|
runId: "run-background-task",
|
|
resultJson: { stopReason: "unmanaged_background_task_stopped" },
|
|
createdAt: "2026-04-18T19:55:30.000Z",
|
|
}),
|
|
createRun({
|
|
runId: "run-paused",
|
|
resultJson: { stopReason: "paused" },
|
|
createdAt: "2026-04-18T19:55:00.000Z",
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("timeout (30s timeout)");
|
|
expect(container.textContent).toContain("cancelled");
|
|
expect(container.textContent).toContain("budget paused");
|
|
expect(container.textContent).toContain("unmanaged background task stopped");
|
|
expect(container.textContent).toContain("paused by board");
|
|
});
|
|
|
|
it("names the recorded cause of an adapter failure and keeps the plain label for older runs", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-adapter-cause",
|
|
status: "failed",
|
|
errorCode: "adapter_failed",
|
|
failureCause: "40001",
|
|
resultJson: { stopReason: "adapter_failed" },
|
|
}),
|
|
createRun({
|
|
runId: "run-adapter-legacy",
|
|
status: "failed",
|
|
errorCode: "adapter_failed",
|
|
resultJson: { stopReason: "adapter_failed" },
|
|
createdAt: "2026-04-18T19:57:00.000Z",
|
|
}),
|
|
createRun({
|
|
runId: "run-adapter-malformed",
|
|
status: "failed",
|
|
errorCode: "adapter_failed",
|
|
failureCause: "select * from secrets",
|
|
resultJson: { stopReason: "adapter_failed" },
|
|
createdAt: "2026-04-18T19:56:00.000Z",
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("adapter failed (40001)");
|
|
expect(container.textContent?.match(/adapter failed(?! \()/g)).toHaveLength(2);
|
|
expect(container.textContent).not.toContain("secrets");
|
|
});
|
|
|
|
it("surfaces active and completed child issue summaries", () => {
|
|
renderLedger({
|
|
childIssues: [
|
|
createIssue({ id: "child-1", identifier: "PAP-2", title: "Implement worker handoff", status: "in_progress" }),
|
|
createIssue({ id: "child-2", identifier: "PAP-3", title: "Verify final report", status: "done" }),
|
|
createIssue({ id: "child-3", identifier: "PAP-4", title: "Cancelled experiment", status: "cancelled" }),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("Child work");
|
|
expect(container.textContent).toContain("1 active, 1 done, 1 cancelled");
|
|
expect(container.textContent).toContain("PAP-2");
|
|
expect(container.textContent).toContain("Implement worker handoff");
|
|
|
|
renderLedger({
|
|
childIssues: [
|
|
createIssue({ id: "child-2", identifier: "PAP-3", title: "Verify final report", status: "done" }),
|
|
createIssue({ id: "child-3", identifier: "PAP-4", title: "Cancelled experiment", status: "cancelled" }),
|
|
],
|
|
});
|
|
|
|
expect(container.textContent).toContain("all 2 terminal (1 done, 1 cancelled)");
|
|
});
|
|
|
|
it("shows the current execution instruction and clears stale instructions after a recorded successor", () => {
|
|
const execution = {
|
|
phase: "recovery_needed" as const, label: "Stopped", cause: "native_continuation_requires_reconciliation",
|
|
lastConfirmedActivityAt: null, retryAt: null, attempt: 1, maxAttempts: 3,
|
|
recoveryOwner: null, nextAction: "Saved work recovered. Send a message to continue.",
|
|
permittedActions: ["inspect_run"] as const, predecessorRunId: null, successorRunId: null,
|
|
};
|
|
const stopped = createRun({ status: "failed", nextAction: "Repair the retained sandbox.",
|
|
execution: { ...execution, permittedActions: ["inspect_run"] } });
|
|
renderLedger({ runs: [stopped] });
|
|
expect(container.textContent).toContain(execution.nextAction);
|
|
expect(container.textContent).not.toContain("Repair the retained sandbox.");
|
|
renderLedger({ runs: [{ ...stopped, execution: { ...stopped.execution!, phase: "completed",
|
|
label: "Continued in another run", nextAction: null, successorRunId: "successor" } }] });
|
|
expect(container.textContent).not.toContain("Next action:");
|
|
});
|
|
|
|
it("uses wrapping-friendly markup for long next action text", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
nextAction: "Continue investigating this intentionally-long-next-action-token-that-needs-to-wrap-cleanly-on-mobile-and-desktop-without-overlapping-controls.",
|
|
}),
|
|
],
|
|
});
|
|
|
|
const nextAction = [...container.querySelectorAll("span")]
|
|
.find((node) => node.textContent?.includes("intentionally-long-next-action-token"));
|
|
expect(nextAction?.className).toContain("break-words");
|
|
expect(container.textContent).toContain("Next action:");
|
|
});
|
|
|
|
it("shows when older runs are clipped from the ledger", () => {
|
|
renderLedger({
|
|
runs: Array.from({ length: 22 }, (_, index) =>
|
|
createRun({
|
|
runId: `run-${index.toString().padStart(8, "0")}`,
|
|
createdAt: `2026-04-18T19:${String(index).padStart(2, "0")}:00.000Z`,
|
|
}),
|
|
),
|
|
});
|
|
|
|
expect(container.textContent).toContain("2 older items not shown");
|
|
});
|
|
|
|
it("renders legacy evaluation context with watchdog actions and a silence badge", () => {
|
|
const onWatchdogDecision = vi.fn();
|
|
renderLedger({
|
|
runs: [createRun({ runId: "run-live-1", status: "running", finishedAt: null })],
|
|
activeRun: createActiveRun(),
|
|
onWatchdogDecision,
|
|
});
|
|
|
|
expect(container.textContent).toContain("Critical output silence");
|
|
expect(container.textContent).toContain("PAP-404");
|
|
expect(container.textContent).toContain("Critical silence");
|
|
expect(container.textContent).toContain("Paperclip did not create new delegated recovery work");
|
|
const watchdogBanner = Array.from(container.querySelectorAll("p"))
|
|
.find((node) => node.textContent?.includes("Critical output silence"))
|
|
?.closest("div");
|
|
expect(watchdogBanner?.className).toContain("border-red-500/30");
|
|
expect(watchdogBanner?.className).toContain("bg-red-500/10");
|
|
|
|
const continueButton = Array.from(container.querySelectorAll("button")).find(
|
|
(button) => button.textContent?.includes("Continue monitoring"),
|
|
);
|
|
expect(continueButton).not.toBeUndefined();
|
|
act(() => {
|
|
continueButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
expect(onWatchdogDecision).toHaveBeenCalledWith({
|
|
runId: "run-live-1",
|
|
decision: "continue",
|
|
evaluationIssueId: "issue-eval-1",
|
|
});
|
|
});
|
|
|
|
it.each([
|
|
{
|
|
level: "suspicious" as const,
|
|
heading: "Output silence watchdog warning",
|
|
badge: "Output silence",
|
|
},
|
|
{
|
|
level: "critical" as const,
|
|
heading: "Critical output silence",
|
|
badge: "Critical silence",
|
|
},
|
|
])("renders a $level UI-only signal without an evaluation-task link", ({ level, heading, badge }) => {
|
|
const onWatchdogDecision = vi.fn();
|
|
const activeRun = createActiveRun();
|
|
renderLedger({
|
|
runs: [createRun({ runId: activeRun.id, status: "running", finishedAt: null })],
|
|
activeRun: createActiveRun({
|
|
outputSilence: {
|
|
...activeRun.outputSilence!,
|
|
level,
|
|
evaluationIssueId: null,
|
|
evaluationIssueIdentifier: null,
|
|
evaluationIssueAssigneeAgentId: null,
|
|
},
|
|
}),
|
|
onWatchdogDecision,
|
|
});
|
|
|
|
expect(container.textContent).toContain(heading);
|
|
expect(container.textContent).toContain(badge);
|
|
expect(container.textContent).toContain("Paperclip did not create or assign a recovery task");
|
|
expect(container.textContent).not.toContain("PAP-404");
|
|
expect(container.querySelector('a[href^="/issues/"]')).toBeNull();
|
|
expect(container.textContent).toContain("Continue monitoring");
|
|
expect(container.textContent).toContain("Snooze 1h");
|
|
expect(container.textContent).toContain("Mark false positive");
|
|
|
|
const continueButton = Array.from(container.querySelectorAll("button")).find(
|
|
(button) => button.textContent?.includes("Continue monitoring"),
|
|
);
|
|
act(() => {
|
|
continueButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
expect(onWatchdogDecision).toHaveBeenCalledWith({
|
|
runId: "run-live-1",
|
|
decision: "continue",
|
|
evaluationIssueId: null,
|
|
});
|
|
});
|
|
|
|
it("hides watchdog decision actions for known non-owner viewers", () => {
|
|
const onWatchdogDecision = vi.fn();
|
|
renderLedger({
|
|
runs: [createRun({ runId: "run-live-1", status: "running", finishedAt: null })],
|
|
activeRun: createActiveRun(),
|
|
canRecordWatchdogDecisions: false,
|
|
onWatchdogDecision,
|
|
});
|
|
|
|
expect(container.textContent).toContain("Critical output silence");
|
|
expect(container.textContent).toContain("PAP-404");
|
|
expect(container.textContent).not.toContain("Continue monitoring");
|
|
expect(container.textContent).not.toContain("Snooze 1h");
|
|
expect(container.textContent).not.toContain("Mark false positive");
|
|
expect(
|
|
Array.from(container.querySelectorAll("button")).filter((button) =>
|
|
/continue|snooze|false positive/i.test(button.textContent ?? ""),
|
|
),
|
|
).toHaveLength(0);
|
|
expect(onWatchdogDecision).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("surfaces the responsible user a run acts on behalf of", () => {
|
|
renderLedger({
|
|
runs: [createRun({ runId: "run-obo-1", responsibleUserId: "user-2" })],
|
|
resolveUserLabel: (userId) => (userId === "user-2" ? "Ada Lovelace" : null),
|
|
});
|
|
|
|
const chip = container.querySelector('[data-testid="run-on-behalf-of"]');
|
|
expect(chip).not.toBeNull();
|
|
expect(chip?.textContent).toContain("on behalf of");
|
|
expect(chip?.textContent).toContain("Ada Lovelace");
|
|
});
|
|
|
|
it("omits the on-behalf-of chip when the run has no responsible user", () => {
|
|
renderLedger({
|
|
runs: [createRun({ runId: "run-obo-2", responsibleUserId: null })],
|
|
resolveUserLabel: () => "Ada Lovelace",
|
|
});
|
|
|
|
expect(container.querySelector('[data-testid="run-on-behalf-of"]')).toBeNull();
|
|
});
|
|
|
|
it("renders actionable copy for a responsible-user-unauthorized run failure", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-denied-1",
|
|
status: "failed",
|
|
livenessState: "failed",
|
|
responsibleUserId: "user-2",
|
|
errorCode: "RESPONSIBLE_USER_UNAUTHORIZED",
|
|
}),
|
|
],
|
|
resolveUserLabel: () => "Ada Lovelace",
|
|
});
|
|
|
|
const notice = container.querySelector('[data-testid="responsible-user-denial-notice"]');
|
|
expect(notice).not.toBeNull();
|
|
expect(notice?.getAttribute("data-denial-tone")).toBe("unauthorized");
|
|
expect(notice?.textContent).toContain("Ada Lovelace");
|
|
expect(notice?.textContent).toContain("Responsible user not authorized");
|
|
});
|
|
|
|
it("steers the responsible-user-unavailable failure toward marking work blocked", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-denied-2",
|
|
status: "failed",
|
|
livenessState: "failed",
|
|
responsibleUserId: "user-3",
|
|
errorCode: "RESPONSIBLE_USER_UNAVAILABLE",
|
|
}),
|
|
],
|
|
resolveUserLabel: () => "Grace Hopper",
|
|
});
|
|
|
|
const notice = container.querySelector('[data-testid="responsible-user-denial-notice"]');
|
|
expect(notice).not.toBeNull();
|
|
expect(notice?.getAttribute("data-denial-tone")).toBe("unavailable");
|
|
expect(notice?.textContent?.toLowerCase()).toContain("blocked");
|
|
});
|
|
|
|
it("does not render a denial notice for a generic agent failure", () => {
|
|
renderLedger({
|
|
runs: [
|
|
createRun({
|
|
runId: "run-denied-3",
|
|
status: "failed",
|
|
livenessState: "failed",
|
|
errorCode: "budget_blocked",
|
|
}),
|
|
],
|
|
});
|
|
|
|
expect(container.querySelector('[data-testid="responsible-user-denial-notice"]')).toBeNull();
|
|
});
|
|
});
|