Files
PaperClipAI/ui/src/components/new-agent/AgentBasicsDialog.tsx
T
a3313f6944 fix(ui): complete read recovery and enforce query error rendering (#18822)
## Thinking Path

> - Paperclip lets people manage agent work through the board.
> - The board reads task, agent, settings, plugin, and run data from the
server.
> - A deploy can interrupt those reads after content is already visible.
> - Local error branches can replace that content with an error or show
raw codes.
> - This pull request moves the remaining reads to the shared recovery
behavior.
> - The query-error guard prevents new local error patterns from
returning.

## Linked Issues or Issue Description

**What happened?**
Loaded lists, settings, task panels, and manual reads could clear their
content or show errors during a server restart. Some reads also disabled
the shared retry policy.

**Expected behavior**
Keep loaded content during a temporary failure. Show the shared
connection banner. Retry reads after recovery. Replace content after a
real access denial or missing resource, with readable copy.

**Steps to reproduce**
Open a task, settings page, or run log. Return 503 with
`tenant_app_unavailable` from the API. Restore the API and check that
content refreshes. Repeat with 403 and 404 to check the failure state.

Related merged work: Refs #15754, Refs #15772, Refs #17960. This change
covers remaining reads and enforcement. Browser persistence and the
outage browser suite follow separately.

## What Changed

- Repair an existing PostgreSQL deadline fixture at UTC boundaries. A
daily cap defers a heartbeat until both its original interval and the
next UTC day allow it. Keep the counted run in its seeded day and cover
noon, just before midnight and the first second after midnight with
explicit clocks and real PostgreSQL. Production scheduling is unchanged.

- Integrate the saved list, settings, shell, task, and manual-read
recovery changes against current master. Preserve the current task,
Inbox, and run-log structure.
- Add `useResilientFetch` for component-local reads. Preserve loaded
data, cancel stale requests, and retry through the shared connectivity
policy. Keep browser and pairing capabilities in memory.
- Retain run log chunks across stream changes and catch up after
recovery without duplicate chunks or stalled requests.
- Keep genuine authorization and missing-resource failures visible.
Translate known single-word codes such as `forbidden`. Show known skills
and disconnected-app failures before sibling loading states. Keep Retry
bound to its failed request.
- Make the query-error guard enforce by default and run it in the CI
policy job. Document the narrow exceptions and the read recovery
contract.
- Invalidate pending OAuth discovery when the operator leaves setup or
its context changes. Keep reserved-popup cleanup bound to the current
attempt.

## Verification

- Current read head `09d1db29dea` is merge-ready: all 59 check runs are
completed (54 successful, three skipped, two neutral), the legacy Snyk
status is successful, and both required `ci / verify` and `ci / e2e`
gates pass. Greptile Apex reviewed this exact head at 5/5 with no
unresolved threads; the branch has no merge conflicts. The current CI
run is `41748339602`.
- Current read head `09d1db29dea` includes master `683fa4725e9`. The
latest change touches only the existing server deadline test fixture.
Application source remains the previously verified `86376fa751e`
revision: all 60 affected skills/disconnected-app tests and both
application UI typechecks passed, along with token gates and the
enforcing query-error guard. Those UI suites were not repeated for this
test-only repair.
- The fixture repair passes all seven deadline integration cases and the
complete server typecheck, including the server test layer. The old
assertion deterministically fails at 23:59:06.888 UTC; its
one-second-old run also fails the first-second-of-day probe. The
corrected fixture passes noon and both midnight probes. The permanent
three-case coverage uses seeded 2099 clocks.
- Twelve new regressions fail against the previous implementation. Both
skills variants and disconnected-app pages show either request's 403 or
429 while the sibling pauses or remains fetching. Permission failures
stay visible. Retry stays usable for its failed request and recovers
independently. An initial test-fixture query-key typo was corrected
before the passing run. The finding is replied to and resolved. Greptile
reviewed prior application revision `86376fa751e` at 5/5 with no new
actionable findings or unresolved threads. The current test-only head
has now received its own Apex 5/5 review with no unresolved threads, and
its CI is successful as recorded above.
- The preceding OAuth fix passed all 237 setup tests on both application
branches. Its ten regressions prove that Back, Cancel, unmount, or
context changes retire initial discovery without creating a connection,
caching old identities, navigating an abandoned popup, or closing a
newer attempt.
- Earlier master integration `e992f770339` passed all 309 tests across
eight affected Slack, recovery, retry, submission and task files, plus
UI typecheck, token gates, enforcing query-error scan and seven guard
tests. The integration preserves Slack workspace reconnect and shared
recovery, readable execution errors, source-inspection company scoping,
and current submission behavior. Newly inherited retained-file recovery
controls keep cached data through transient failures and hide it after
definitive denial.
- The preceding cache head `97c0bc3966f` passed 1,038 focused
cache/write/editor/account/task/API tests. All 22 built-UI
outage/write/loading cases passed in 4.7 minutes on exact browser head
`b7deaaee5da`, with strict checking of all three specs. The latest
skills/app rendering fix is covered by its affected component suites;
those broader cases were not repeated for this separate read path.
- Historical broader UI, CLI and build results and unresolved aggregate
server/DB/adapter failures remain in the PR discussion. Interrupted CI
runs were audited and recorded separately; they are not counted as
passes. Controlled local outages do not prove hosted authentication or a
real Cloud restart/deploy. Real hosted acceptance remains required after
merge and deployment.

Commands for the latest fix:

```sh
pnpm --filter @paperclipai/ui exec vitest run src/pages/CompanySkills.test.tsx src/pages/apps/AppNotConnected.test.tsx
pnpm --filter @paperclipai/ui typecheck
pnpm check:token-gates
node scripts/check-query-error-rendering.mjs --enforce --summary
```

## Risks

This migration touches many read surfaces. The main risks are initial
loading, request cancellation, retained authorization state, and run-log
paging. The tests cover those states. There are no server, schema,
dependency, or API contract changes. The follow-up browser suite and
hosted deploy acceptance are required before release acceptance.

Recovered commits retain their original authors. If squash-merging,
preserve `Co-Authored-By: Bender (Fable) <bender@agents.paperclip.ing>`
and the Paperclip trailer.

## Model Used

OpenAI `gpt-6.1-sol` through Codex, with xhigh reasoning effort, tool
use, and code execution. The context window size is not exposed. Saved
source commits keep their original authorship.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have described the issue in-PR following the bug report template
- [x] I have not referenced internal/instance-local Paperclip issues or
links
- [x] My branch name describes the change and contains no internal
ticket id
- [x] The affected local tests pass; broader limitations are recorded
above
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: devinfoley <139239+devinfoley@users.noreply.github.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
Co-authored-by: Bender (Fable) <bender@agents.paperclip.ing>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-04 14:07:18 -08:00

366 lines
17 KiB
TypeScript

import { useCompany } from "@/context/CompanyContext";
import { PAPERCLIP_RUNNER_ACPX_PROFILES } from "@paperclipai/adapter-utils";
import { useAgentAppearanceDraft } from "@/hooks/useAgentAppearanceDraft";
import { AdapterMark } from "../AdapterMark";
import { AgentCharacter } from "../AgentCharacter";
import { useEffect, useId, useRef, useState } from "react";
import type { Agent } from "@paperclipai/shared";
import { agentsApi } from "@/api/agents";
import { buildNewAgentRuntimeConfig } from "@/lib/new-agent-runtime-config";
import { useQuery, useQueryClient } from "@tanstack/react-query";
import { ArrowLeft, ArrowRight, Check, ChevronRight } from "lucide-react";
import { adaptersApi } from "@/api/adapters";
import { instanceSettingsApi } from "@/api/instanceSettings";
import { useCloudInstance } from "@/hooks/useCloudInstance";
import { isNewAgentAdapterAllowed } from "@/lib/new-agent-adapters";
import { queryKeys } from "@/lib/queryKeys";
import { getAdapterDisplay } from "@/adapters/adapter-display-registry";
import { cn } from "@/lib/utils";
import { Button } from "../ui/button";
import { Input } from "../ui/input";
import { SelectPopover } from "../ui/select";
import {
Dialog,
DialogContent,
DialogDescription,
DialogTitle,
} from "../ui/dialog";
import { QueryErrorState, useQueryView } from "../QueryView";
export type AgentBasics = {
name: string;
adapterType: string;
runnerProvider: string;
runner: string;
setupAgentId: string;
};
export { AdapterMark } from "../AdapterMark";
function AgentBasicsCharacter() {
const { selectedCompanyId } = useCompany();
const { appearance } = useAgentAppearanceDraft(`${selectedCompanyId}:new-agent`);
return <AgentCharacter appearance={appearance} state="sleepy" muted size={256} className="size-48" trackingScope="page" />;
}
export function AgentBasicsDialog({
open,
onClose,
onContinue,
initialAdapter = "",
initialName = "",
setupAgentId,
onInvite,
}: {
open: boolean;
onClose: () => void;
onContinue: (basics: AgentBasics) => void;
initialAdapter?: string;
initialName?: string;
setupAgentId?: string;
onInvite?: () => void;
}) {
const id = useId();
const { selectedCompanyId: companyId } = useCompany();
const cache = useQueryClient();
const appearanceDraft = useAgentAppearanceDraft(`${companyId}:new-agent`);
const setupId = useRef(setupAgentId ?? crypto.randomUUID());
const saved = useRef<Agent | null>(null);
const busy = useRef(false);
const active = useRef(true);
useEffect(() => { active.current = true; return () => { active.current = false; }; }, []);
const [saving, setSaving] = useState(false);
const [saveError, setSaveError] = useState<string | null>(null);
const cloud = Boolean(useCloudInstance());
const experimental = useQuery({
queryKey: queryKeys.instance.experimentalSettings,
queryFn: instanceSettingsApi.getExperimental,
enabled: open,
});
const [name, setName] = useState(initialName);
const [adapterType, setAdapterType] = useState(initialAdapter);
const [runnerProvider, setRunnerProvider] = useState("codex");
const [step, setStep] = useState<"name" | "adapter">(setupAgentId ? "adapter" : "name");
const adaptersQuery = useQuery({
queryKey: queryKeys.adapters.availability(companyId ?? "none", null),
queryFn: () => adaptersApi.list({ companyId: companyId! }),
enabled: open && Boolean(companyId),
});
const adaptersView = useQueryView(adaptersQuery);
const adapters = adaptersView.data;
const nativeRunner = adapters?.find(adapter => adapter.type === "paperclip_runner" && adapter.loaded && !adapter.disabled && adapter.supportedRunners?.length !== 0);
const copilotAvailable = Boolean(nativeRunner) && PAPERCLIP_RUNNER_ACPX_PROFILES.some(profile => profile.value === "copilot" && profile.qualified);
const kimiAvailable = Boolean(nativeRunner) && experimental.data?.enableNativeRunner === true
&& PAPERCLIP_RUNNER_ACPX_PROFILES.some(profile => profile.value === "kimi" && profile.qualified);
const antigravityQualified = PAPERCLIP_RUNNER_ACPX_PROFILES.some(profile => profile.value === "antigravity" && profile.qualified);
const antigravityCandidate = nativeRunner?.candidateHarnesses?.some(candidate => candidate.agent === "antigravity");
const antigravityAvailable = Boolean(nativeRunner);
const choices = [...(adapters ?? []).filter(
(adapter) =>
adapter.loaded &&
!adapter.disabled &&
adapter.supportedRunners?.length !== 0 &&
adapter.type !== "paperclip_runner" &&
isNewAgentAdapterAllowed(adapter.type, {
cloud,
nativeRunnerEnabled: experimental.data?.enableNativeRunner === true,
}) &&
(!cloud || adapter.type !== "cursor_cloud" || adapter.supportedRunners?.includes("paperclip")) &&
!["process", "http"].includes(adapter.type) &&
!getAdapterDisplay(adapter.type).comingSoon,
), ...(copilotAvailable ? [{ ...nativeRunner!, type: "copilot_runtime" }] : []),
...(antigravityAvailable ? [{ ...nativeRunner!, type: "antigravity_runtime" }] : []),
...(kimiAvailable ? [{ ...nativeRunner!, type: "kimi_runtime" }] : [])];
const experimentalRunnerAvailable = experimental.data?.enableNativeRunner === true
&& adapters?.some(adapter => adapter.type === "paperclip_runner" && adapter.loaded && !adapter.disabled && adapter.supportedRunners?.length !== 0);
const validAdapter = choices.some((adapter) => adapter.type === adapterType)
|| (experimentalRunnerAvailable && adapterType === "paperclip_runner" && (runnerProvider !== "antigravity" || antigravityQualified));
async function submit() {
if (busy.current || !name.trim() || (step === "adapter" && !validAdapter)) return;
busy.current = true;
setSaving(true);
setSaveError(null);
try {
if (!companyId) throw new Error("Select an organization to create an agent.");
let agent = saved.current;
if (!agent && setupAgentId) agent = await agentsApi.get(setupId.current, companyId);
const creatingRecord = !agent;
if (!agent) {
const existing = (await agentsApi.list(companyId)).filter(item => item.id !== setupId.current);
const leader = existing.find(item => item.role === "ceo" && item.status !== "terminated");
const provisionalAdapter = adapters?.some(item => item.type === "process" && item.disabled)
? choices[0]?.type : "process";
if (!provisionalAdapter) throw new Error("No agent adapters are available on this instance.");
// This adapter is provisional; the setup hold prevents execution.
agent = await agentsApi.create(companyId, {
setupId: setupId.current, name: name.trim(), appearance: appearanceDraft.appearance,
role: existing.length ? "general" : "ceo", ...(leader ? { reportsTo: leader.id } : {}),
adapterType: ["copilot_runtime", "antigravity_runtime", "kimi_runtime"].includes(provisionalAdapter) ? "paperclip_runner" : provisionalAdapter,
...(["copilot_runtime", "antigravity_runtime", "kimi_runtime"].includes(provisionalAdapter) ? { adapterConfig: { provider: "acpx", acpxAgent: provisionalAdapter === "copilot_runtime" ? "copilot" : provisionalAdapter === "kimi_runtime" ? "kimi" : "antigravity" } } : {}),
metadata: { setupAdapterPending: true },
runtimeConfig: buildNewAgentRuntimeConfig({ heartbeatEnabled: false }),
});
if (active.current) setName(agent.name);
}
saved.current = agent;
const hostedCursor = cloud && adapterType === "cursor_cloud";
const nextAdapter = hostedCursor || ["openai_dot", "copilot_runtime", "antigravity_runtime", "kimi_runtime"].includes(adapterType) ? "paperclip_runner" : adapterType;
const nextProvider = hostedCursor ? "cursor_cloud" : adapterType === "kimi_runtime" ? "kimi" : adapterType === "antigravity_runtime" ? "antigravity" : adapterType === "copilot_runtime" ? "copilot" : adapterType === "openai_dot" ? "openai_dot" : adapterType === "paperclip_runner" ? runnerProvider : "codex";
const nextRunner = hostedCursor ? "paperclip" as const : "auto" as const;
// Pending providers can show setup while the saved name-only draft stays held.
const pendingAntigravity = nextProvider === "antigravity" && !antigravityQualified;
if (step === "adapter" || (!creatingRecord && agent.name !== name.trim())) {
const { setupAdapterChoice: _previousChoice, ...metadata } = agent.metadata ?? {};
agent = await agentsApi.update(agent.id, {
name: name.trim(),
...(step === "adapter" && pendingAntigravity ? {
metadata: { ...metadata, setupAdapterPending: true,
setupAdapterChoice: { adapterType: nextAdapter, runnerProvider: nextProvider, runner: "auto" } },
} : {}),
...(step === "adapter" && !pendingAntigravity ? {
adapterType: nextAdapter, runner: nextRunner,
adapterConfig: nextAdapter === "paperclip_runner" ? {
provider: ["claude", "grok", "copilot", "antigravity", "kimi"].includes(nextProvider) ? "acpx" : nextProvider,
...(["claude", "grok", "copilot", "antigravity", "kimi"].includes(nextProvider) ? { acpxAgent: nextProvider } : {}),
...(nextProvider === "grok" ? { model: "grok-4.7" } : {}),
} : {},
metadata: { ...metadata, setupAdapterPending: false },
} : {}),
}, companyId);
saved.current = agent;
}
cache.setQueryData(queryKeys.agents.detail(agent.id), agent);
void cache.invalidateQueries({ queryKey: queryKeys.agents.list(companyId) });
if (!active.current) return;
if (step === "name") setStep("adapter");
else onContinue({ name: agent.name, adapterType: nextAdapter, runnerProvider: nextProvider,
runner: nextRunner, setupAgentId: agent.id });
} catch (cause) {
if (active.current) setSaveError(cause instanceof Error ? cause.message : "Could not save agent setup.");
} finally {
busy.current = false;
if (active.current) setSaving(false);
}
}
return (
<Dialog
open={open}
onOpenChange={(value) => {
if (!value) onClose();
}}
>
<DialogContent
className={cn(
"flex max-h-(--sz-calc-18) flex-col gap-0 overflow-hidden p-0 sm:max-w-(--sz-640px)",
step === "name" && "sm:max-w-(--sz-560px)",
)}
>
<div
className="flex items-center gap-2 px-6 py-5 text-xs text-muted-foreground"
aria-label="New agent progress"
>
<span
className={cn(step === "name" && "font-medium text-foreground")}
>
1. Name
</span>
<ChevronRight className="size-3" />
<span
className={cn(step === "adapter" && "font-medium text-foreground")}
>
2. Adapter
</span>
</div>
<form
className="flex min-h-0 flex-col"
onSubmit={(event) => {
event.preventDefault();
void submit();
}}
>
<div className="flex min-h-0 flex-col gap-7 overflow-y-auto px-6 pb-8 sm:px-10">
<div className="flex flex-col items-center gap-4 text-center">
{open && <AgentBasicsCharacter />}
<div className="space-y-2">
<DialogTitle className="text-3xl font-semibold tracking-tight">
{step === "name"
? "Meet your next agent"
: "Choose an adapter"}
</DialogTitle>
<DialogDescription className="text-base">
{step === "name"
? "Start with a name. Make them your own."
: `How should ${name.trim()} work?`}
</DialogDescription>
</div>
</div>
{step === "name" ? (
<div className="space-y-2">
<label htmlFor={id} className="text-sm font-medium">
Agent name
</label>
<Input
id={id}
autoFocus
disabled={saving}
maxLength={100}
placeholder="e.g. Darnold"
value={name}
onChange={(event) => setName(event.target.value)}
className="h-12 text-base"
/>
{onInvite && (
<Button
type="button"
variant="link"
className="px-0 text-muted-foreground"
onClick={onInvite}
>
Invite an external agent
</Button>
)}
</div>
) : (
<fieldset className="space-y-4">
<legend className="sr-only">Adapter</legend>
{adaptersView.kind === "loading" || adaptersView.kind === "reconnecting" ? (
<p role="status" className="text-sm text-muted-foreground">
Loading adapters…
</p>
) : null}
{adaptersView.kind === "error" ? (
<QueryErrorState
size="inline"
error={adaptersView.error}
action="load the adapter list"
onRetry={adaptersView.retry}
retrying={adaptersView.isFetching}
/>
) : null}
<div className={cn("grid grid-cols-2 gap-3", choices.length !== 4 && "sm:grid-cols-3")}>
{choices.map((adapter) => {
const display = getAdapterDisplay(adapter.type);
return (
<label
key={adapter.type}
className="relative cursor-pointer"
>
<input
type="radio"
disabled={saving}
name="new-agent-adapter"
value={adapter.type}
checked={adapterType === adapter.type}
onChange={() => setAdapterType(adapter.type)}
className="peer sr-only"
/>
<span
className={cn(
"flex h-full flex-col items-center gap-2 rounded-lg border px-3 py-4 text-center peer-focus-visible:ring-2 peer-focus-visible:ring-ring hover:bg-accent/40",
adapterType === adapter.type
? "border-foreground/40 bg-accent"
: "border-border bg-card",
)}
>
<AdapterMark type={adapter.type} />
<span className="text-sm font-medium">
{display.label}
</span>
{adapter.type === "antigravity_runtime" && !antigravityQualified && (
<span className="text-xs text-muted-foreground">{antigravityCandidate ? "Candidate" : "Not available yet"}</span>
)}
{adapterType === adapter.type && (
<Check className="absolute right-2 top-2 size-3.5" />
)}
</span>
</label>
);
})}
</div>
{experimentalRunnerAvailable && <details className="space-y-3">
<summary className="cursor-pointer text-sm text-muted-foreground">Advanced</summary>
<div className="space-y-2">
<label className="text-sm text-muted-foreground">Experimental harness</label>
<SelectPopover aria-label="Experimental harness"
value={adapterType === "paperclip_runner" ? runnerProvider : ""}
placeholder="Choose a native harness…"
onValueChange={provider => { setRunnerProvider(provider); setAdapterType("paperclip_runner"); }}
options={[
{ value: "grok", label: "Grok Build (Paperclip Runner)" },
{ value: "opencode", label: "OpenCode (Paperclip Runner)" },
]} />
</div>
</details>}
</fieldset>
)}
</div>
{saveError && <p role="alert" className="px-6 pb-4 text-sm text-destructive">{saveError}</p>}
<div className="flex justify-between gap-4 border-t border-border px-6 py-4">
<Button
type="button"
variant="ghost"
disabled={saving}
onClick={() => (step === "name" ? onClose() : setStep("name"))}
>
{step === "name" ? (
"Cancel"
) : (
<>
<ArrowLeft className="size-4" />
Back
</>
)}
</Button>
<Button
type="submit"
disabled={saving || !name.trim() || (step === "adapter" && !validAdapter)}
>
{saving ? "Saving…" : step === "name" ? "Choose adapter" : "Configure agent"}
<ArrowRight className="size-4" />
</Button>
</div>
</form>
</DialogContent>
</Dialog>
);
}