mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 08:22:20 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Agents need to discover connections, obtain consent, and continue from saved decisions. > - We want to reduce repeated instructions only when measured behavior supports the change. > - The existing decline tasks tell the model not to retry. One provider-decline check can pass without an explanation or an observed service counter. > - This PR adds neutral tasks and stricter saved-evidence checks before any connection instruction reduction. > - Production instructions remain unchanged. The new cells are configured, not live-qualified. ## Linked Issues or Issue Description Refs #15218. Refs #15389. **What existing behavior does this improve?** The Product E2E connection workflow evaluation and its instruction measurement provenance. **Current behavior** Some decline prompts supply the policy they intend to test. The provider-decline workflow does not require a saved post-decision explanation. Its old no-call check can use a missing fixture counter as zero. OpenCode has no connection cases in the original Everyday matrix. **Proposed behavior** Add an explicit-only suite with five connection stories on native Codex, ACPX Claude, and OpenCode. Require an explanation attributed by exact run ID after a saved decline. Observe the provider fixture counter. Preserve the original cases and grades. ## What Changed - Add fifteen configured cells with one attempt, twelve-minute deadlines, and verified 1,000-cent company and agent budget stops. - Remove procedure hints from the three new decline prompts. Keep a user-permitted explanation fallback and the existing positive controls. - Require saved decline state, one decision, unchanged connections, observed zero service calls where applicable, and a post-decision explanation from a successful run on the same task. - Add negative grader calibration and test the actual fixture budget payloads. Exclude the suite from default and generic selection. - Extend the existing full-catalog measurement source manifest with connection descriptions and schemas. Add an audit of fixed text, tool descriptions, returned instructions, and unqualified behavior. - Rebase on master `a6306ba606eb87c89b9ef0344e9fe8e0025580f9` and preserve its new Cursor suites. No production, credential, workflow, or lockfile change. ## Verification - Before rebase: Product E2E support passed 1,424 TypeScript tests and 128 Node checks. Six catalog measurement tests, repository typecheck/build, Product E2E typecheck, and exact fifteen-cell discovery passed. - The full pre-rebase repository test run was stopped when master advanced. Its partial result is not a pass. - After rebase and the review correction: repository build/typecheck, Product E2E typecheck, 1,799 TypeScript support tests (one skipped), 128 Node checks, six measurement tests, and exact fifteen-cell discovery pass. The duplicate local full-suite run was stopped incomplete after about 20 minutes once complete CI passed; no local full-suite pass is claimed. - Review found that the initial grader read `runId` instead of public `createdByRunId`. A regression calibration reproduced both rejection of valid public comments and acceptance of the wrong alias. The fix uses the actual field and binds the evidence type to the shared `IssueComment` contract. A subsequent type-only import path correction passes Product E2E typecheck. - Final source `0de306b9664bfbdebb6709ddb54c95152740d1ad` passes [complete CI](https://github.com/paperclipai/paperclip/actions/runs/37560250545): 51 successful checks and two intentional Storybook skips, plus separate Snyk success. Fresh Greptile review is 5/5 with the single review thread resolved and no new findings. The PR is clean and mergeable. - Local commands: `pnpm build`, `pnpm -r typecheck`, `pnpm test:e2e:runner:unit`, `pnpm test:e2e:runner:typecheck`, and `pnpm test:e2e:runner -- --list --suite native-connection-guidance`. The measurement uses `PAPERCLIP_NATIVE_PROCEDURE_MEASUREMENT=/tmp/connection-measurement.json pnpm exec vitest run --project @paperclipai/server server/src/__tests__/native-procedure-measurement.test.ts`. Validation used pinned pnpm 9.15.4. - No paid provider campaign was started. There is no baseline/candidate behavior result for these new cells. - The audit records 654 UTF-8 bytes of fixed connection guidance. A clean capture at `a04b8c6a452315625014888335d45670a2094fb6` confirms 41 supplied tools, 53,341 normalized bytes at start/resume, 50,949 at compact continuation, and a 48,195-byte authenticated OpenCode MCP catalog. These are byte counts, not tokens, bills, vendor-private prompt sizes, or savings from this PR. ## Risks - This is eval preparation. Passing support tests do not establish live model behavior or qualify an instruction reduction. - The explanation oracle checks attributed saved output. It does not prove cognition or arbitrary prose truthfulness. One saved interaction also does not prove the absence of repeated idempotent tool calls. - Successful new authentication and tool refresh, existing-connection agent grants, independent work while waiting, explicit retry after decline, and blocking when mandatory work remains still need separate coverage. - Notion setup decline does not execute a real Notion service. Positive service approval uses an already installed deterministic service; it does not qualify new connection creation. - The original historical failures remain unchanged. Future comparisons must freeze source, fixture, model, input, and grading controls and retain every actual attempt. ## Model Used OpenAI Codex, GPT-6 family, with reasoning, repository tools, and code execution. The exact serving model ID and context-window size were not exposed in this session; they are not inferred. No model provider was invoked by the eval suite in this PR preparation. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
610 lines
21 KiB
TypeScript
610 lines
21 KiB
TypeScript
import type { IssueComment } from "../../packages/shared/src/types/issue.js";
|
|
|
|
export interface StoryCheck {
|
|
id: string;
|
|
passed: boolean;
|
|
detail: string;
|
|
}
|
|
export interface StoryIssue {
|
|
id: string;
|
|
companyId: string;
|
|
title: string;
|
|
status: string;
|
|
identifier?: string | null;
|
|
description?: string | null;
|
|
createdAt?: string;
|
|
updatedAt?: string;
|
|
assigneeAgentId?: string | null;
|
|
parentId?: string | null;
|
|
projectId?: string | null;
|
|
executionRunId?: string | null;
|
|
scheduledRetry?: unknown;
|
|
activeRecoveryAction?: unknown;
|
|
comments?: StoryComment[];
|
|
interactions?: StoryInteraction[];
|
|
activity?: StoryActivityRecord[];
|
|
wakeDiagnostics?: StoryWakeDiagnostics;
|
|
blockedTransitionAt?: string | null;
|
|
}
|
|
export interface StoryComment extends Partial<Pick<IssueComment, "authorAgentId" | "createdByRunId">> {
|
|
id?: string;
|
|
body?: unknown;
|
|
createdAt?: string;
|
|
}
|
|
export interface StoryActivityRecord {
|
|
action?: string;
|
|
details?: unknown;
|
|
createdAt?: string;
|
|
}
|
|
export interface StoryInteraction {
|
|
id?: string;
|
|
kind?: string;
|
|
issueId?: string | null;
|
|
status?: string;
|
|
continuationPolicy?: string | null;
|
|
resolverPolicy?: string | null;
|
|
effectiveResolverPolicy?: string | null;
|
|
addresseeAgentId?: string | null;
|
|
resolvedByAgentId?: string | null;
|
|
resolvedByRunId?: string | null;
|
|
resolvedAt?: string | null;
|
|
result?: Record<string, unknown> | null;
|
|
payload?: Record<string, unknown> | null;
|
|
createdAt?: string;
|
|
}
|
|
|
|
/** Select the accepted review card for the same child and lead after the initial handoff boundary. */
|
|
export function storyAcceptedAgentReview(
|
|
child: StoryIssue | undefined,
|
|
initialInteractionId: string | undefined,
|
|
leadId: string,
|
|
runs: StoryRun[],
|
|
): StoryInteraction | undefined {
|
|
if (!child?.interactions?.length || !initialInteractionId) return undefined;
|
|
const initial = child.interactions.find(
|
|
(candidate) => candidate.id === initialInteractionId,
|
|
);
|
|
if (!initial) return undefined;
|
|
const initialCreatedAt = Date.parse(initial.createdAt ?? "");
|
|
return child.interactions
|
|
.filter((candidate) => {
|
|
const result = candidate.result;
|
|
const target = candidate.payload?.target as
|
|
| Record<string, unknown>
|
|
| undefined;
|
|
const revisionId = String(target?.revisionId ?? "");
|
|
const reviewRun = runs.find(
|
|
(run) => run.id === candidate.resolvedByRunId,
|
|
);
|
|
return (
|
|
candidate.kind === "request_confirmation" &&
|
|
target?.type === "custom" &&
|
|
target?.key === "native_completion_review" &&
|
|
candidate.issueId === child.id &&
|
|
candidate.addresseeAgentId === leadId &&
|
|
candidate.resolvedByAgentId === leadId &&
|
|
candidate.status === "accepted" &&
|
|
Number.isFinite(initialCreatedAt) &&
|
|
Number.isFinite(Date.parse(candidate.createdAt ?? "")) &&
|
|
Date.parse(candidate.createdAt ?? "") >= initialCreatedAt &&
|
|
result?.version === 1 &&
|
|
result?.outcome === "accepted" &&
|
|
reviewRun?.status === "succeeded" &&
|
|
reviewRun.agentId === leadId &&
|
|
reviewRun.contextSnapshot?.nativeReviewInteractionId === candidate.id &&
|
|
reviewRun.contextSnapshot?.nativeReviewDecisionId === revisionId &&
|
|
revisionId.length > 0
|
|
);
|
|
})
|
|
.sort((a, b) =>
|
|
Date.parse(a.resolvedAt ?? "") - Date.parse(b.resolvedAt ?? ""),
|
|
)[0];
|
|
}
|
|
export interface StoryWakeDiagnosticEvent {
|
|
kind?: string;
|
|
agentId?: string | null;
|
|
reason?: string | null;
|
|
status?: string;
|
|
payload?: Record<string, unknown> | null;
|
|
}
|
|
export interface StoryWakeDiagnostics {
|
|
events?: StoryWakeDiagnosticEvent[];
|
|
blockerDiagnostics?: {
|
|
readiness?: { unresolvedBlockerCount?: number | null } | null;
|
|
blockers?: unknown[];
|
|
};
|
|
}
|
|
export interface StoryRun {
|
|
id: string;
|
|
companyId: string;
|
|
agentId: string;
|
|
status: string;
|
|
runtimeMode?: string;
|
|
runnerInstanceId?: string | null;
|
|
processPid?: number | null;
|
|
processStartedAt?: string | null;
|
|
nativeIssueId?: string | null;
|
|
nativeSessionId?: string | null;
|
|
contextSnapshot?: Record<string, unknown> | null;
|
|
resultJson?: Record<string, unknown> | null;
|
|
usageJson?: Record<string, unknown> | null;
|
|
runnerProfileJson?: Record<string, unknown> | null;
|
|
sessionIdAfter?: string | null;
|
|
startedAt?: string | null;
|
|
finishedAt?: string | null;
|
|
retryOfRunId?: string | null;
|
|
scheduledRetryReason?: string | null;
|
|
runtimeModeResolvedAt?: string | null;
|
|
lastOutputSeq?: number | null;
|
|
errorCode?: string | null;
|
|
error?: string | null;
|
|
}
|
|
|
|
export type StoryArtifactGradeMode = "base" | "separator" | "max-length";
|
|
|
|
/** Select the artifact oracle variant required by each workflow's actual case. */
|
|
export function artifactGradeModeForPhase(
|
|
phase:
|
|
| "hired-delivery"
|
|
| "reused-delivery"
|
|
| "delegated-delivery"
|
|
| "reviewed-delivery"
|
|
| "recovered-delivery",
|
|
): StoryArtifactGradeMode {
|
|
switch (phase) {
|
|
case "hired-delivery":
|
|
case "reviewed-delivery":
|
|
return "base";
|
|
case "reused-delivery":
|
|
return "separator";
|
|
case "delegated-delivery":
|
|
case "recovered-delivery":
|
|
return "max-length";
|
|
}
|
|
}
|
|
|
|
/** A review run is valid only after the lead run has completed. */
|
|
export function storyParentCompletionPrecedesReview(
|
|
parentFinishedAt: string | null | undefined,
|
|
reviewStartedAt: string | null | undefined,
|
|
parentBlocked: boolean,
|
|
): boolean {
|
|
if (reviewStartedAt) {
|
|
return Boolean(
|
|
parentFinishedAt &&
|
|
Date.parse(parentFinishedAt) <= Date.parse(reviewStartedAt),
|
|
);
|
|
}
|
|
return parentBlocked;
|
|
}
|
|
|
|
export const isActiveStoryRun = (run: StoryRun) =>
|
|
["queued", "running", "scheduled_retry"].includes(run.status);
|
|
export function isStoryWorkspaceDeferral(run: StoryRun) {
|
|
const recovery = run.resultJson?.executionRecovery as
|
|
Record<string, unknown> | undefined;
|
|
const startup = run.resultJson?.startupCancellation as
|
|
Record<string, unknown> | undefined;
|
|
const neverStartedRetry =
|
|
run.errorCode === "cancelled" &&
|
|
run.scheduledRetryReason === "workspace_busy" &&
|
|
typeof run.retryOfRunId === "string" &&
|
|
run.retryOfRunId.length > 0 &&
|
|
run.startedAt === null &&
|
|
run.runtimeModeResolvedAt === null &&
|
|
run.lastOutputSeq === 0 &&
|
|
!run.processStartedAt &&
|
|
!run.sessionIdAfter &&
|
|
!run.usageJson &&
|
|
!run.runnerProfileJson?.nativeExecutionInput &&
|
|
typeof startup?.requestedAt === "string" &&
|
|
Number.isFinite(Date.parse(startup.requestedAt));
|
|
return (
|
|
run.status === "cancelled" &&
|
|
((run.errorCode === "workspace_busy" &&
|
|
recovery?.providerWorkStarted === false) ||
|
|
neverStartedRetry) &&
|
|
!run.runnerInstanceId &&
|
|
!run.nativeSessionId &&
|
|
!run.processPid
|
|
);
|
|
}
|
|
/** Exempt the injected stop itself, never a later recovery/provider failure on that run. */
|
|
export function isExpectedStoryInterruption(
|
|
run: StoryRun,
|
|
allowedRunIds: readonly string[],
|
|
): boolean {
|
|
if (!allowedRunIds.includes(run.id)) return false;
|
|
return (
|
|
(run.status === "cancelled" && (!run.errorCode || run.errorCode === "cancelled")) ||
|
|
(run.status === "interrupted" && run.errorCode === "server_shutdown_interrupted") ||
|
|
(run.status === "failed" && run.errorCode === "process_lost")
|
|
);
|
|
}
|
|
|
|
export function storyUnexpectedRunFailure(runs: StoryRun[], allowedRunIds: readonly string[]) {
|
|
return runs.find((run) =>
|
|
["failed", "timed_out", "cancelled", "interrupted"].includes(run.status) &&
|
|
!isStoryWorkspaceDeferral(run) &&
|
|
!isExpectedStoryInterruption(run, allowedRunIds),
|
|
);
|
|
}
|
|
|
|
/** Called after the boundary matcher; reject only with durable proof of the wrong ordering. */
|
|
export function storyUnexercisedReviewBoundary(
|
|
issues: StoryIssue[],
|
|
runs: StoryRun[],
|
|
parentId: string,
|
|
leadId: string,
|
|
): string | undefined {
|
|
if (issues.length === 0 || runs.length === 0) return;
|
|
if (!issues.every((issue) =>
|
|
issue.status === "done" && !issue.scheduledRetry && !issue.activeRecoveryAction,
|
|
)) return;
|
|
if (!runs.every((run) => run.status === "succeeded")) return;
|
|
const child = issues.find((issue) => issue.parentId === parentId);
|
|
const accepted = child?.interactions?.flatMap((interaction) => {
|
|
const review = storyAcceptedAgentReview(child, interaction.id, leadId, runs);
|
|
return review ? [review] : [];
|
|
})[0];
|
|
const reviewRun = accepted && runs.find((run) => run.id === accepted.resolvedByRunId);
|
|
const reviewStartedAt = Date.parse(reviewRun?.startedAt ?? "");
|
|
const parentRuns = runs.filter((run) =>
|
|
run.nativeIssueId === parentId ||
|
|
run.contextSnapshot?.issueId === parentId ||
|
|
run.contextSnapshot?.taskId === parentId,
|
|
);
|
|
// Snapshots are fetched separately. Missing review evidence is not proof that it
|
|
// never happened; wait unless persisted timestamps rule out the required order.
|
|
if (!Number.isFinite(reviewStartedAt) || parentRuns.length === 0) return;
|
|
if (!parentRuns.every((run) => {
|
|
const finishedAt = Date.parse(run.finishedAt ?? "");
|
|
return Number.isFinite(finishedAt) && finishedAt > reviewStartedAt;
|
|
})) return;
|
|
return "Review handoff boundary not exercised: the accepted review started before any parent run finished, so the blocked-parent-before-review ordering was not tested.";
|
|
}
|
|
|
|
export function storyLifecycleChecks(input: {
|
|
issues: StoryIssue[];
|
|
runs: StoryRun[];
|
|
parentId: string;
|
|
leadId: string;
|
|
allowedInterruptedRuns?: string[];
|
|
}): StoryCheck[] {
|
|
const executed = input.runs.filter((r) => !isStoryWorkspaceDeferral(r));
|
|
const allowed = input.allowedInterruptedRuns ?? [];
|
|
const check = (id: string, passed: boolean, detail: string): StoryCheck => ({
|
|
id,
|
|
passed,
|
|
detail,
|
|
});
|
|
return [
|
|
check(
|
|
"tasks-done",
|
|
input.issues.length > 0 && input.issues.every((i) => i.status === "done"),
|
|
"Every story task must reach Done.",
|
|
),
|
|
check(
|
|
"settled",
|
|
!input.runs.some(isActiveStoryRun) &&
|
|
!input.issues.some((i) => i.scheduledRetry || i.activeRecoveryAction),
|
|
"No active runs or scheduled recovery remain.",
|
|
),
|
|
check(
|
|
"native-runtime",
|
|
executed.length > 0 &&
|
|
executed.every(
|
|
(r) => r.runtimeMode === "native" && Boolean(r.runnerInstanceId),
|
|
),
|
|
"All executions must prove native runtime and runner identity.",
|
|
),
|
|
check(
|
|
"successful-runs",
|
|
executed.every((r) => r.status === "succeeded" || isExpectedStoryInterruption(r, allowed)),
|
|
"Only the expected stop or process-loss outcome of an injected interruption is exempt.",
|
|
),
|
|
check(
|
|
"bounded-work",
|
|
input.runs.length <= 12,
|
|
"No more than twelve executions, including child and recovery turns.",
|
|
),
|
|
check(
|
|
"parent-owned-by-lead",
|
|
!executed.some(
|
|
(r) =>
|
|
(r.contextSnapshot?.issueId === input.parentId ||
|
|
r.contextSnapshot?.taskId === input.parentId) &&
|
|
r.agentId !== input.leadId,
|
|
),
|
|
"A mentioned worker must not execute on the parent.",
|
|
),
|
|
];
|
|
}
|
|
|
|
/** A terminal first turn cannot satisfy a later queued request. */
|
|
export function storyRepliesConsumed(
|
|
runs: StoryRun[],
|
|
commentIds: string[],
|
|
): boolean {
|
|
return commentIds.every((id) =>
|
|
runs.some((run) => {
|
|
if (run.status !== "succeeded" || isStoryWorkspaceDeferral(run))
|
|
return false;
|
|
const input = run.runnerProfileJson?.nativeExecutionInput as
|
|
{ task?: { prompt?: string } } | undefined;
|
|
return input?.task?.prompt?.includes(id) === true;
|
|
}),
|
|
);
|
|
}
|
|
|
|
/** A terminal task is only ready for response assertions after its agent reply is visible. */
|
|
export function storyHasAgentReply(
|
|
issue: StoryIssue | undefined,
|
|
agentId: string,
|
|
expectedText: string,
|
|
): boolean {
|
|
return (
|
|
issue?.comments?.some(
|
|
(comment) =>
|
|
comment.authorAgentId === agentId &&
|
|
String(comment.body ?? "").includes(expectedText),
|
|
) ?? false
|
|
);
|
|
}
|
|
|
|
const RUNNABLE_WAKE_STATUSES = new Set([
|
|
"queued",
|
|
"deferred_issue_execution",
|
|
"claimed",
|
|
]);
|
|
|
|
/** A durable wake means an agent still has a recorded next action. */
|
|
export function storyHasPendingAgentWake(
|
|
issue: StoryIssue | undefined,
|
|
agentIds: string | readonly string[],
|
|
): boolean {
|
|
const ids = new Set(typeof agentIds === "string" ? [agentIds] : agentIds);
|
|
return (
|
|
issue?.wakeDiagnostics?.events?.some(
|
|
(event) =>
|
|
event.kind === "wake_request" &&
|
|
event.agentId != null &&
|
|
ids.has(event.agentId) &&
|
|
RUNNABLE_WAKE_STATUSES.has(String(event.status)),
|
|
) ?? false
|
|
);
|
|
}
|
|
|
|
/** Any issue-scoped wake keeps the workflow actionable while it is being dispatched. */
|
|
export function storyHasPendingAgentWork(
|
|
issues: StoryIssue[],
|
|
agentIds: string | readonly string[],
|
|
): boolean {
|
|
return issues.some((issue) => storyHasPendingAgentWake(issue, agentIds));
|
|
}
|
|
|
|
/** A blocked story is stranded only when no issue has a durable continuation wake. */
|
|
export function storyHasStrandedBlockedLeaf(
|
|
issues: StoryIssue[],
|
|
agentIds: string | readonly string[],
|
|
): boolean {
|
|
return (
|
|
issues.some((issue) => issue.status === "blocked") &&
|
|
!storyHasPendingAgentWork(issues, agentIds)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* A completed native review is a durable continuation trigger even when the
|
|
* parent projection has not yet exposed the claimed wake. Keep the existing
|
|
* workflow deadline; its timeout diagnostic identifies a missing continuation.
|
|
*/
|
|
export function storyHasDurableAgentReviewContinuation(
|
|
issues: StoryIssue[],
|
|
parentId: string,
|
|
leadId: string,
|
|
runs: StoryRun[],
|
|
): boolean {
|
|
const parent = issues.find((issue) => issue.id === parentId);
|
|
if (parent?.status !== "blocked") return false;
|
|
const blockedAt = Date.parse(parent.blockedTransitionAt ?? "");
|
|
const terminalWake = parent.wakeDiagnostics?.events?.some(
|
|
(event) =>
|
|
event.kind === "wake_request" &&
|
|
event.agentId === leadId &&
|
|
event.reason === "issue_blockers_resolved" &&
|
|
["completed", "failed", "cancelled"].includes(String(event.status)),
|
|
);
|
|
if (terminalWake) return false;
|
|
return issues.some((child) =>
|
|
child.parentId === parentId &&
|
|
child.status === "done" &&
|
|
(child.interactions?.some((interaction) => {
|
|
const target = interaction.payload?.target as
|
|
| Record<string, unknown>
|
|
| undefined;
|
|
const reviewRun = runs.find((run) => run.id === interaction.resolvedByRunId);
|
|
return (
|
|
interaction.kind === "request_confirmation" &&
|
|
interaction.status === "accepted" &&
|
|
interaction.issueId === child.id &&
|
|
interaction.addresseeAgentId === leadId &&
|
|
interaction.resolvedByAgentId === leadId &&
|
|
interaction.result?.version === 1 &&
|
|
interaction.result?.outcome === "accepted" &&
|
|
Number.isFinite(blockedAt) &&
|
|
Date.parse(interaction.resolvedAt ?? "") >= blockedAt &&
|
|
target?.type === "custom" &&
|
|
target?.key === "native_completion_review" &&
|
|
reviewRun?.status === "succeeded" &&
|
|
reviewRun.agentId === leadId
|
|
);
|
|
}) ?? false),
|
|
);
|
|
}
|
|
|
|
/** Timeout evidence requires a stranded leaf with durable accepted-review evidence. */
|
|
export function storyReviewContinuationTimeoutDetail(
|
|
issues: StoryIssue[],
|
|
parentId: string,
|
|
leadId: string,
|
|
runs: StoryRun[],
|
|
observableAgentIds: string | readonly string[],
|
|
): string | undefined {
|
|
return (
|
|
storyHasStrandedBlockedLeaf(issues, observableAgentIds) &&
|
|
storyHasDurableAgentReviewContinuation(issues, parentId, leadId, runs)
|
|
)
|
|
? "task is Blocked without an active continuation after accepted review"
|
|
: undefined;
|
|
}
|
|
|
|
/** A pending interaction is agent-owned when its wake policy and wake request agree. */
|
|
export function storyHasPendingAgentReview(
|
|
issue: StoryIssue | undefined,
|
|
agentIds: string | readonly string[],
|
|
): boolean {
|
|
return Boolean(
|
|
issue?.interactions?.some((interaction) =>
|
|
storyHasPendingAgentReviewForInteraction(issue, interaction, agentIds),
|
|
),
|
|
);
|
|
}
|
|
|
|
/** Pending review is human-owned only when no matching agent review wake is runnable. */
|
|
export function storyHasPendingHumanInteraction(
|
|
issue: StoryIssue | undefined,
|
|
agentIds: string | readonly string[],
|
|
): boolean {
|
|
const pendingInteraction = issue?.interactions?.some(
|
|
(interaction) =>
|
|
interaction.status === "pending" &&
|
|
!storyHasPendingAgentReviewForInteraction(issue, interaction, agentIds),
|
|
);
|
|
return Boolean(
|
|
pendingInteraction,
|
|
);
|
|
}
|
|
|
|
function storyHasPendingAgentReviewForInteraction(
|
|
issue: StoryIssue | undefined,
|
|
interaction: StoryInteraction,
|
|
agentIds: string | readonly string[],
|
|
): boolean {
|
|
const ids = new Set(typeof agentIds === "string" ? [agentIds] : agentIds);
|
|
if (
|
|
interaction.status !== "pending" ||
|
|
interaction.continuationPolicy !== "wake_assignee" ||
|
|
interaction.resolverPolicy === "human_only" ||
|
|
interaction.effectiveResolverPolicy === "human_only" ||
|
|
!interaction.addresseeAgentId ||
|
|
!ids.has(interaction.addresseeAgentId)
|
|
)
|
|
return false;
|
|
const wakeEvents =
|
|
issue?.wakeDiagnostics?.events?.filter(
|
|
(event) =>
|
|
event.kind === "wake_request" &&
|
|
event.agentId === interaction.addresseeAgentId &&
|
|
RUNNABLE_WAKE_STATUSES.has(String(event.status)),
|
|
) ?? [];
|
|
const explicitlyBound = wakeEvents.some(
|
|
(event) =>
|
|
event.payload?.nativeReviewInteractionId === interaction.id,
|
|
);
|
|
if (explicitlyBound) return true;
|
|
if (
|
|
wakeEvents.some(
|
|
(event) => event.payload?.nativeReviewInteractionId != null,
|
|
)
|
|
)
|
|
return false;
|
|
const sameAgentPendingCards =
|
|
issue?.interactions?.filter(
|
|
(candidate) =>
|
|
candidate.status === "pending" &&
|
|
candidate.continuationPolicy === "wake_assignee" &&
|
|
candidate.resolverPolicy !== "human_only" &&
|
|
candidate.effectiveResolverPolicy !== "human_only" &&
|
|
candidate.addresseeAgentId === interaction.addresseeAgentId,
|
|
).length ?? 0;
|
|
// The public v1 wake projection has no binding payload. With multiple cards
|
|
// for one agent, conservatively refuse to attribute an unbound wake.
|
|
return wakeEvents.length > 0 && sameAgentPendingCards === 1;
|
|
}
|
|
|
|
/** The public blocker projection is durable evidence of a dependency hold. */
|
|
export function storyIssueHasUnresolvedDependency(issue: StoryIssue): boolean {
|
|
const readiness = issue.wakeDiagnostics?.blockerDiagnostics?.readiness;
|
|
return (
|
|
issue.status === "blocked" &&
|
|
((readiness?.unresolvedBlockerCount ?? 0) > 0 ||
|
|
(issue.wakeDiagnostics?.blockerDiagnostics?.blockers?.length ?? 0) > 0)
|
|
);
|
|
}
|
|
|
|
/** Status history remains observable after the scheduler clears the blocker. */
|
|
export function storyIssueHasBlockedTimeline(issue: StoryIssue): boolean {
|
|
return storyIssueHasBlockedTimelineBefore(issue);
|
|
}
|
|
|
|
/** A blocker timeline entry is useful only when it predates the review card. */
|
|
export function storyIssueHasBlockedTimelineBefore(
|
|
issue: StoryIssue,
|
|
before?: string,
|
|
): boolean {
|
|
return Boolean(
|
|
issue.activity?.some((record) => {
|
|
const action = String(record.action ?? "").toLowerCase();
|
|
const details = (record.details ?? {}) as Record<string, unknown>;
|
|
const changes = (details.changes ?? {}) as Record<string, unknown>;
|
|
const statusChange = (changes.status ?? {}) as Record<string, unknown>;
|
|
const recordAt = Date.parse(String(record.createdAt ?? ""));
|
|
const beforeAt = before ? Date.parse(before) : Number.NaN;
|
|
return (
|
|
action === "issue.updated" &&
|
|
Number.isFinite(recordAt) &&
|
|
(!Number.isFinite(beforeAt) || recordAt <= beforeAt) &&
|
|
(details.status === "blocked" ||
|
|
details.toStatus === "blocked" ||
|
|
statusChange.to === "blocked")
|
|
);
|
|
}),
|
|
);
|
|
}
|
|
|
|
/** Native result evidence survives a fast transition past the blocked projection. */
|
|
export function storyRunReportsDependencyBlock(run: StoryRun): boolean {
|
|
const result = run.resultJson?.nativeResult as
|
|
| Record<string, unknown>
|
|
| undefined;
|
|
if (result?.reportedWorkDisposition !== "blocked") return false;
|
|
const blocker = result.blocker as Record<string, unknown> | undefined;
|
|
const reason = String(blocker?.reasonCode ?? "").toLowerCase();
|
|
return reason.includes("depend");
|
|
}
|
|
|
|
export function storyParentFinishedAfterChildren(
|
|
runs: StoryRun[],
|
|
parentId: string,
|
|
leadId: string,
|
|
childIds: string[],
|
|
): boolean {
|
|
const scope = (r: StoryRun) =>
|
|
r.nativeIssueId ?? r.contextSnapshot?.issueId ?? r.contextSnapshot?.taskId;
|
|
const completed = runs.filter(
|
|
(r) => r.status === "succeeded" && !isStoryWorkspaceDeferral(r),
|
|
);
|
|
const children = completed.filter((r) => childIds.includes(String(scope(r))));
|
|
if (!children.length) return false;
|
|
const lastChildFinish = Math.max(
|
|
...children.map((r) => Date.parse(r.finishedAt ?? "")),
|
|
);
|
|
return completed.some(
|
|
(r) =>
|
|
r.agentId === leadId &&
|
|
scope(r) === parentId &&
|
|
Date.parse(r.finishedAt ?? "") >= lastChildFinish,
|
|
);
|
|
}
|