mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-10 12:07:09 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Users connect accounts and choose an agent harness and model. > - The runtime change in #14970 supports custom providers on those connections. > - Normal setup must stay simple while advanced users can choose a compatible gateway. > - Shared connector rows and access controls keep these choices consistent. > - This pull request refines the agent setup UI and adds review stories and repeatable browser qualification. > - The qualification checks real tools and downloaded outputs, not only a successful run status. ## Linked Issues or Issue Description Refs #14970, #37, #13083, #14104, #14565, #12692. The core implementation in #14970 is merged. This branch incorporates its squash commit and targets `master`. Both PRs contain our implementation. #14016 is a reference only and is not a dependency. This PR has 96 changed files. ## What Changed - Complete model-provider connector presentation beside other connectors. Each row uses the existing Connect action and connection list. Tags are stored without category UI. The base PR includes the provider forms and routes. - Show persistent Subscription, API Key, and Advanced choices. Label Advanced as Custom Gateway. Reuse provider logos, connection lists, and permissions controls. Default access to the organization and all agents when permitted; keep narrowing controls under Advanced. - Keep Configure reachable before subscription sign-in, so users can select a supported environment when the default cannot sign in. Testing and saving still require a connection. Show the execution environment in Configure. Preserve the confirmed Connect choice. Editing a method, credential, saved account, or advanced choice requires that current choice to connect before testing or saving. Use matching model and thinking-effort dropdowns and retain connection icons in selected values. - Preserve the new harness model default when switching an existing OpenCode agent to Codex or Claude, and resolve user-selected model names with the effective harness. - Load popular OpenRouter models through the shared connection-model discovery path. Keep explicit model lists and manual model entry available. - Group onboarding, connection setup, agent runtime, management, recovery, and production-component stories under AI Connections / Provider routing. - Add an explicit-only provider-connections browser suite for managed local or existing local/staging targets. Use private browser profiles and credential handoffs. Support human-assisted subscription sign-in without sharing passwords or tokens in reports. - Verify persisted connection identity, runtime probes, tool execution, exact artifact bytes, completion, and context-dependent follow-up. Retain source/model provenance, cost bounds, closed error diagnostics, original failures, and cleanup evidence. - Add Gemini startup-model and skill-root fixes, Grok private-history detection, ACP filesystem regression fixtures, selected-workspace handling for local Hermes, and artifact-helper workspace fallback. - Keep managed Grok runtime homes disposable. Remove host-side transcript retention/restoration because private file modes do not isolate same-user agent processes. Ignore earlier development archives and use a fresh task handoff when history is unavailable. Verify the absence of restored transcripts with a separate same-user process. - Capture stopped-run diagnostics before deleting an attached-company fixture agent. Track creation and owned sign-in receipts; revoke only this attempt's accounts and never adopt a concurrent campaign's newly created account. Preserve failure signals and final status through cleanup. - Require the requested environment in the saved agent and every run, including follow-ups. Reject a forced incompatible target. Keep one cancellation state through startup, every cell, reporting, and teardown for SIGINT, SIGTERM, and SIGHUP. Stop further paid cells after interruption. Document qualification limits. ## Verification - Current head `b3bb3e94d577d43d9965a6b9daba039f599b2e49` includes master `d9f600043`. The security fix in `a758fde31` passes full workspace typecheck, production build, and 119 connection/Grok regressions. The unchanged UI passes all 126 configuration/model-discovery tests and token gates. The final published-guide correction passes Grok adapter typecheck. Earlier head `eebd8225c` passed the complete deterministic runner suite (1,404 Vitest tests and 128 Node tests) and all CI jobs. Current-head CI run `37520147514` passed all 47 jobs, including the full sharded Vitest and browser matrix, production build, and canary dry run. All 55 checks completed: 53 successes and two expected skips. The current-head security scan passed, Greptile is 5/5, and no review threads remain open. - A separate same-user process reproduced reading a restored Grok transcript before the security fix. The regression now finds no transcript. Existing fresh-session fallback and ordinary session metadata behavior pass. - The final account-choice and cleanup fixes pass 85 setup tests and 26 qualification-harness tests. Regressions verify that editing a connection invalidates confirmation, Configure remains reachable before sign-in, diagnostics are captured before fixture deletion, and concurrent campaigns cannot adopt or revoke each other's accounts. UI and E2E typechecks pass. - The Storybook build and actual Chromium production-component stories passed during this change. Review the neighboring AI Connections / Provider routing stories, regular connector rows, three connection modes, model discovery, and the single execution-environment control in Configure. - Cancellation smoke verified authenticated cleanup before browser close for SIGINT, SIGTERM, and SIGHUP. Regressions cover interruption during startup and reporting, missing-file ACP resource errors, and preserved permission denials. Both ACP runtime versions and 54 ACPX/Grok regressions passed. The deterministic connection-intent browser suite passed two tests. - Historical local qualification retained 43 passing API/gateway cells out of 46, with downloaded outputs and follow-up receipts. These attempts span earlier builds; they do not qualify this exact commit or staging. Subscription combinations, Gemini overloads, and the unresolved follow-up failure remain recorded rather than counted as passing. - Use `pnpm test:e2e:runner -- --list --suite provider-connections` to inspect the matrix. Follow `tests/runner-e2e/PROVIDER-CONNECTIONS.md` for credentials, target URL, sign-in assistance, budget, evidence, and cleanup. Paid live tests remain opt-in. ## Risks - The core implementation in #14970 is merged. This PR adds no database migration of its own. - Subscription login needs an interactive provider session. Dedicated accounts and staging qualification remain follow-up work; this PR does not certify every login combination for production. - Managed Grok transcript resume is deferred until provider history has an OS isolation or authorized broker solution. Follow-ups start fresh with Paperclip task context; earlier live Grok results do not qualify this behavior. - Gemini CLI 0.58.0 has an upstream ACP new-file error conversion defect. Live overloads and one unresolved follow-up timeout remain recorded. The stock CLI is unchanged, and those cases are not marked as passing. - Real-provider tests spend credits and use private credential/evidence directories. The launcher requires explicit selection and checks target ownership. It must not attach to a developer's database by accident. - OpenClaw Gateway, Hermes Gateway, Claude Managed, AWS AgentCore, Process, HTTP, and legacy ACPX local remain outside custom provider setup. ## Model Used OpenAI GPT-6 through Codex, with reasoning, repository tools, code execution, and browser testing. The exact deployment model ID and context window size were not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
395 lines
28 KiB
TypeScript
395 lines
28 KiB
TypeScript
import { chromium, type BrowserContext } from "@playwright/test";
|
|
import { execFileSync } from "node:child_process";
|
|
import { randomBytes, createHash } from "node:crypto";
|
|
import { mkdir, mkdtemp, writeFile, rm, readdir, lstat, open } from "node:fs/promises";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { FixtureRegistry } from "./fixture-registry.js";
|
|
import { buildRunnerCampaign } from "./history.js";
|
|
import { renderRunnerE2EDashboard } from "./dashboard.js";
|
|
import { buildRuntimeUsage, summarizeExecutionBilling } from "./billing.js";
|
|
import { stageDashboardBrandAssets } from "./report-assets.js";
|
|
import { classifyFailure } from "./failure-classifier.js";
|
|
import { packageEvidence } from "./evidence.js";
|
|
import { assertSecretFree, sanitizeJson } from "./redaction.js";
|
|
import { connectionCell, connectionHarnesses, connectionModes, connectionScopeGaps, supportsConnection } from "./connection-cases.js";
|
|
import { assertOutsideRepository, ConnectionBlock, ConnectionFailure, loadConnectionConfig, resolveConnectionSecret, resolveConnectionSettings, type ConnectionConfig } from "./connection-config.js";
|
|
import { connectionEvidencePasses, connectionRunDiagnostic, gradeConnectionEvidence, type ConnectionEvidence } from "./connection-evidence.js";
|
|
import { ConnectionApi, connectionDelay, startConnectionTarget, verifyConnectionTarget } from "./connection-target.js";
|
|
import { runConnectionFlow } from "./connection-flow.js";
|
|
import type { MatrixExecution, RunnerE2EResult } from "./types.js";
|
|
|
|
type Row = Record<string, any>;
|
|
|
|
export function connectionCreationReceipt(pathname: string, method: string, companyId: string, loginIds: ReadonlySet<string>, body: unknown): string | undefined {
|
|
const root = `/api/companies/${companyId}/ai-connections`;
|
|
const loginId = pathname.startsWith(`${root}/login/`) ? pathname.slice(`${root}/login/`.length) : undefined;
|
|
const createdHere = method === "POST" && (pathname === root || pathname === `${root}/local`);
|
|
const ownedLogin = method === "GET" && loginId && loginIds.has(loginId);
|
|
if (!createdHere && !ownedLogin) return;
|
|
const id = (body as { connectionId?: unknown } | null)?.connectionId;
|
|
return typeof id === "string" && /^[a-f0-9]{8}-(?:[a-f0-9]{4}-){3}[a-f0-9]{12}$/i.test(id) ? id : undefined;
|
|
}
|
|
|
|
export async function cleanupConnectionCompany(input: {
|
|
api: ConnectionApi; companyId: string; agentName: string;
|
|
attachedCompany: boolean; retainCompany: boolean;
|
|
createdConnectionIds: ReadonlySet<string>;
|
|
evidence: Pick<ConnectionEvidence, "cleanupRetained" | "companyArchived">;
|
|
collectDiagnostics: () => Promise<void>;
|
|
}) {
|
|
const { api, companyId, agentName, evidence } = input;
|
|
const agents = await api.get<Row[]>(`/api/companies/${companyId}/agents`);
|
|
const fixtureAgents = agents.filter(agent => agent.name === agentName);
|
|
try {
|
|
for (const agent of fixtureAgents) {
|
|
await api.patch(`/api/agents/${agent.id}`, { status: "paused" });
|
|
const liveRuns = await api.get<Row[]>(`/api/companies/${companyId}/heartbeat-runs?agentId=${agent.id}&limit=100`);
|
|
for (const run of liveRuns.filter(run => run.agentId === agent.id && ["queued", "running"].includes(run.status))) {
|
|
await api.post(`/api/heartbeat-runs/${run.id}/cancel`);
|
|
}
|
|
}
|
|
} finally {
|
|
// Deleting an attached-company agent also deletes its runs and logs.
|
|
// Capture the stopped runs first, including when cancellation fails.
|
|
await input.collectDiagnostics();
|
|
}
|
|
if (input.retainCompany) { evidence.cleanupRetained = true; return; }
|
|
const connections = (await api.get(`/api/companies/${companyId}/ai-connections`)).connections;
|
|
for (const connection of connections.filter((connection: Row) => input.createdConnectionIds.has(connection.id) && connection.status !== "revoked")) {
|
|
await api.delete(`/api/tool-connections/${connection.id}`);
|
|
}
|
|
if ((await api.get(`/api/companies/${companyId}/ai-connections`)).connections.some((connection: Row) => input.createdConnectionIds.has(connection.id) && connection.status !== "revoked")) {
|
|
throw new ConnectionFailure("connection_revocation_failed");
|
|
}
|
|
if (!input.attachedCompany) { await api.post(`/api/companies/${companyId}/archive`); evidence.companyArchived = true; }
|
|
else for (const agent of fixtureAgents) await api.delete(`/api/agents/${agent.id}`);
|
|
}
|
|
|
|
export async function openConnectionBrowser(config: ConnectionConfig, repositoryRoot: string, origin: string) {
|
|
const temporary = config.browser.freshness === "signed-out" || !config.browser.profileDir;
|
|
const profile = temporary ? await mkdtemp(path.join(os.tmpdir(), "paperclip-qa-browser-")) : path.resolve(config.browser.profileDir!);
|
|
await assertOutsideRepository(profile, repositoryRoot);
|
|
await mkdir(profile, { recursive: true, mode: 0o700 });
|
|
const stat = await lstat(profile);
|
|
if (stat.isSymbolicLink() || !stat.isDirectory() || (stat.mode & 0o077) !== 0) throw new ConnectionBlock("blocked_target", "browser_profile_requires_private_directory");
|
|
const marker = path.join(profile, ".paperclip-provider-qa");
|
|
const entries = await readdir(profile);
|
|
if (entries.length && !entries.includes(path.basename(marker))) throw new ConnectionBlock("blocked_target", "use_a_dedicated_empty_qa_browser_profile");
|
|
if (!entries.length) await writeFile(marker, "Dedicated Paperclip provider QA browser. Contains private authentication state.\n", { mode: 0o600, flag: "wx" });
|
|
const lock = path.join(profile, ".paperclip-qa.lock");
|
|
try { await (await open(lock, "wx", 0o600)).close(); }
|
|
catch { throw new ConnectionBlock("blocked_target", "qa_browser_profile_in_use"); }
|
|
let context: BrowserContext;
|
|
try {
|
|
const browserEnv = Object.fromEntries(["PATH", "HOME", "USER", "LOGNAME", "TMPDIR", "DISPLAY", "WAYLAND_DISPLAY", "XAUTHORITY", "LANG"].flatMap(key => process.env[key] ? [[key, process.env[key]!]] : []));
|
|
context = await chromium.launchPersistentContext(profile, {
|
|
channel: config.browser.channel === "chrome" ? "chrome" : undefined,
|
|
headless: !config.browser.headed, baseURL: origin, viewport: { width: 1440, height: 1000 }, reducedMotion: "reduce",
|
|
env: browserEnv, acceptDownloads: true,
|
|
// Teardown needs this context's authenticated request client to cancel
|
|
// login sessions and revoke fixtures before the browser is closed.
|
|
handleSIGINT: false, handleSIGTERM: false, handleSIGHUP: false,
|
|
// Deliberately use the Playwright library without Test's automatic reporters,
|
|
// traces, HARs, videos, snapshots, assertion call logs, or failure screenshots.
|
|
});
|
|
context.setDefaultTimeout(30_000);
|
|
context.setDefaultNavigationTimeout(30_000);
|
|
} catch {
|
|
await rm(lock, { force: true });
|
|
if (temporary) await rm(profile, { recursive: true, force: true });
|
|
throw new ConnectionBlock("blocked_target", "qa_browser_launch_failed");
|
|
}
|
|
return { context, close: async () => { try { await context.close(); } finally { await rm(lock, { force: true }); if (temporary) await rm(profile, { recursive: true, force: true }); } } };
|
|
}
|
|
|
|
export function safeConnectionFailure(error: unknown, phase: string) {
|
|
if (error instanceof ConnectionBlock) return error.code;
|
|
// Arbitrary Playwright/provider messages can contain filled values and URLs.
|
|
const known = error instanceof ConnectionFailure;
|
|
const frame = error instanceof Error ? error.stack?.match(/connection-(?:flow|target|launch)\.ts:\d+:\d+/)?.[0] : undefined;
|
|
return known ? error.message : `${phase}_failed${frame ? ` (${frame})` : ""}`;
|
|
}
|
|
|
|
function sourceRevision(repositoryRoot: string) {
|
|
const git = (args: string[]) => execFileSync("git", args, { cwd: repositoryRoot, encoding: "utf8", stdio: ["ignore", "pipe", "ignore"] }).trim();
|
|
return { sha: git(["rev-parse", "HEAD"]), ref: `${git(["branch", "--show-current"])}${git(["status", "--porcelain"]) ? " (working tree)" : ""}`, workflowRunUrl: null };
|
|
}
|
|
|
|
async function safeWrite(file: string, value: unknown, secrets: readonly string[]) {
|
|
const text = `${JSON.stringify(sanitizeJson(value, secrets), null, 2)}\n`;
|
|
assertSecretFree(text, secrets, path.basename(file));
|
|
await writeFile(file, text, { mode: 0o600 });
|
|
}
|
|
|
|
async function connectionAttempt(execution: MatrixExecution, config: ConnectionConfig, origin: string, summaryDir: string, repositoryRoot: string, signal: AbortSignal): Promise<RunnerE2EResult> {
|
|
const startedAt = new Date().toISOString();
|
|
const nonce = randomBytes(6).toString("hex");
|
|
const privateDir = await mkdtemp(path.join(os.tmpdir(), "paperclip-connection-proof-"));
|
|
const evidenceDir = path.join(summaryDir, execution.suite.id, execution.profile.id, execution.environment.id, execution.task.id, "attempt-1");
|
|
await mkdir(evidenceDir, { recursive: true, mode: 0o700 });
|
|
const { entry, mode } = connectionCell(execution);
|
|
const evidence: ConnectionEvidence = { version: 1, outcome: "running", phase: "target", assisted: false, authFreshness: config.browser.freshness,
|
|
target: { mode: config.target.mode, origin, commit: null, deploymentMode: null }, entry, method: mode, checkpoints: {}, waits: [] };
|
|
const secrets: string[] = [];
|
|
const checkpoint = async (phase: string) => { evidence.phase = phase; await safeWrite(path.join(summaryDir, "progress.json"), { executionId: execution.id, ...evidence }, secrets); };
|
|
const result: RunnerE2EResult = { schema: "paperclip.runner-e2e.result/v2", executionId: execution.id, suiteId: execution.suite.id, suiteDefinitionHash: execution.suiteDefinitionHash,
|
|
source: sourceRevision(repositoryRoot), attempt: 1, status: "failed", profileId: execution.profile.id, environmentId: execution.environment.id, caseId: execution.task.id,
|
|
provider: execution.profile.provider, model: execution.profile.model, runtimeMode: execution.profile.generation, startedAt, finishedAt: startedAt, durationMs: 0, cleanup: "not_started", providerConnection: evidence };
|
|
let browser: Awaited<ReturnType<typeof openConnectionBrowser>> | undefined;
|
|
let fixtures: Awaited<ReturnType<FixtureRegistry["setupAll"]>> | undefined;
|
|
const observedRuns = new Map<string, Row>();
|
|
const createdConnectionIds = new Set<string>();
|
|
const ownedLoginIds = new Set<string>();
|
|
let fixtureCompanyId: string | undefined;
|
|
let diagnosticApi: ConnectionApi | undefined;
|
|
let diagnosticsCollected = false;
|
|
const collectDiagnostics = async () => {
|
|
if (diagnosticsCollected || !diagnosticApi || !observedRuns.size) return;
|
|
evidence.runDiagnostics = [];
|
|
for (const observed of observedRuns.values()) {
|
|
let run = observed; let log: unknown;
|
|
try { run = await diagnosticApi.get(`/api/heartbeat-runs/${observed.id}`); observedRuns.set(observed.id, run); } catch { /* Keep the last durable observation. */ }
|
|
try { log = await diagnosticApi.get(`/api/heartbeat-runs/${observed.id}/log?limitBytes=2000000`); } catch { /* Mark missing log evidence explicitly. */ }
|
|
evidence.runDiagnostics.push(connectionRunDiagnostic(run, log));
|
|
}
|
|
diagnosticsCollected = true;
|
|
};
|
|
const loginSessions = new Map<string, "DELETE" | "POST">();
|
|
const loginObservers: Promise<void>[] = [];
|
|
let stopped: "test_interrupted" | "cell_deadline_reached" | undefined;
|
|
const stopBrowserActions = () => { for (const page of browser?.context.pages() ?? []) void page.close().catch(() => {}); };
|
|
const interrupt = () => { stopped = "test_interrupted"; stopBrowserActions(); };
|
|
const assertActive = () => { if (stopped) throw new ConnectionBlock("blocked_target", stopped); };
|
|
signal.addEventListener("abort", interrupt, { once: true });
|
|
if (signal.aborted) interrupt();
|
|
const deadlineTimer = setTimeout(() => { stopped = "cell_deadline_reached"; stopBrowserActions(); }, execution.task.attemptTimeoutMs?.[execution.environment.id] ?? 30 * 60_000);
|
|
try {
|
|
assertActive();
|
|
const identity = await verifyConnectionTarget(origin, config);
|
|
Object.assign(evidence.target, identity);
|
|
evidence.checkpoints.target = true;
|
|
assertActive();
|
|
const settings = resolveConnectionSettings(execution, config);
|
|
result.model = settings.model;
|
|
evidence.model = settings.model;
|
|
if (mode === "subscription" && !config.browser.headed) throw new ConnectionBlock("awaiting_user", "subscription_requires_headed_browser");
|
|
// Resolve only the selected credential, and only after validating the target.
|
|
const secret = await resolveConnectionSecret(config, settings.credentialEnv);
|
|
if (secret) secrets.push(secret);
|
|
assertActive();
|
|
browser = await openConnectionBrowser(config, repositoryRoot, origin);
|
|
assertActive();
|
|
const page = browser.context.pages()[0] ?? await browser.context.newPage();
|
|
const api = new ConnectionApi(browser.context.request, origin);
|
|
diagnosticApi = api;
|
|
browser.context.on("response", response => {
|
|
const url = new URL(response.url());
|
|
if (url.origin !== origin || !fixtureCompanyId || !url.pathname.startsWith(`/api/companies/${fixtureCompanyId}/`) || !response.ok()) return;
|
|
const method = response.request().method();
|
|
const local = method === "POST" && /^\/api\/companies\/([a-f0-9-]+)\/ai-connections\/local\/attempts$/.test(url.pathname);
|
|
const cloud = method === "POST" && /^\/api\/companies\/([a-f0-9-]+)\/(?:setup-token-login-sessions|adapters\/[^/]+\/login-sessions)$/.test(url.pathname);
|
|
const root = `/api/companies/${fixtureCompanyId}/ai-connections`;
|
|
const receipt = (method === "POST" && [root, `${root}/local`].includes(url.pathname)) || (method === "GET" && url.pathname.startsWith(`${root}/login/`));
|
|
if (!local && !cloud && !receipt) return;
|
|
loginObservers.push((async () => {
|
|
const body = await response.json();
|
|
if ((local || cloud) && typeof body.sessionId === "string" && /^[a-zA-Z0-9_-]+$/.test(body.sessionId)) {
|
|
ownedLoginIds.add(body.sessionId);
|
|
loginSessions.set(`${url.pathname}/${body.sessionId}${cloud ? "/cancel" : ""}`, local ? "DELETE" : "POST");
|
|
}
|
|
const id = connectionCreationReceipt(url.pathname, method, fixtureCompanyId!, ownedLoginIds, body);
|
|
if (id) createdConnectionIds.add(id);
|
|
})().catch(() => {}));
|
|
});
|
|
const refreshOwnedConnections = async () => {
|
|
if (!fixtureCompanyId) return;
|
|
for (const sessionId of ownedLoginIds) {
|
|
const route = `/api/companies/${fixtureCompanyId}/ai-connections/login/${sessionId}`;
|
|
try {
|
|
const id = connectionCreationReceipt(route, "GET", fixtureCompanyId, ownedLoginIds, await api.get(route));
|
|
if (id) createdConnectionIds.add(id);
|
|
} catch { /* An unfinished or cancelled owned login has no account receipt. */ }
|
|
}
|
|
};
|
|
await page.goto(origin, { waitUntil: "domcontentloaded" });
|
|
try { await api.get("/api/companies"); }
|
|
catch (authError) {
|
|
if (!(authError instanceof ConnectionFailure) || !["api_status_401", "api_status_403"].includes(authError.message)) throw authError;
|
|
if (!config.browser.headed) throw new ConnectionBlock("awaiting_user", "board_login_required");
|
|
evidence.assisted = true;
|
|
evidence.waits.push({ kind: "board_login", startedAt: new Date().toISOString() });
|
|
await checkpoint("awaiting_board_login");
|
|
console.log(`[provider-connections] Sign in to Paperclip at ${origin} in the QA browser; this test resumes automatically.`);
|
|
const deadline = Date.now() + config.browser.loginTimeoutMs;
|
|
let ready = false;
|
|
while (Date.now() < deadline) { assertActive(); try { await api.get("/api/companies"); ready = true; break; } catch { await connectionDelay(1000); } }
|
|
if (!ready) throw new ConnectionBlock("awaiting_user", "board_login_deadline_reached");
|
|
evidence.waits.at(-1)!.finishedAt = new Date().toISOString();
|
|
}
|
|
const registry = new FixtureRegistry();
|
|
const attachedCompany = config.target.mode === "attach" ? config.target.companyId : undefined;
|
|
registry.register<Row>({ id: "connection-company", setup: async () => {
|
|
if (attachedCompany) {
|
|
const company = await api.get(`/api/companies/${attachedCompany}`);
|
|
if (!company.name.startsWith("Connection QA") || (await api.get<Row[]>(`/api/companies/${company.id}/agents`)).some(agent => agent.status !== "terminated") || (await api.get(`/api/companies/${company.id}/ai-connections`)).connections.some((connection: Row) => connection.status !== "revoked")) throw new ConnectionBlock("blocked_target", "attach_requires_empty_dedicated_qa_company");
|
|
fixtureCompanyId = company.id;
|
|
return company;
|
|
}
|
|
const company = await api.post("/api/companies", { name: `Connection QA ${nonce}`, description: "Disposable provider-connections QA fixture", budgetMonthlyCents: config.budgetCents });
|
|
fixtureCompanyId = company.id;
|
|
return company;
|
|
}, teardown: async company => {
|
|
await Promise.all(loginObservers);
|
|
await refreshOwnedConnections();
|
|
for (const [route, method] of loginSessions) {
|
|
try { await api.response(route, method); }
|
|
catch (error) { if (!(error instanceof ConnectionFailure) || error.message !== "api_status_404") throw error; }
|
|
}
|
|
await refreshOwnedConnections();
|
|
// Creation receipts identify this attempt even when concurrent campaigns
|
|
// passed the initial empty-company check at the same time.
|
|
await cleanupConnectionCompany({ api, companyId: company.id, agentName: `Connection QA ${nonce}`,
|
|
attachedCompany: Boolean(attachedCompany), retainCompany: config.retainCompany, createdConnectionIds, evidence, collectDiagnostics });
|
|
} });
|
|
registry.register<Row>({ id: "connection-environment", dependencies: ["connection-company"], setup: async values => {
|
|
const company = values.get("connection-company") as Row;
|
|
const environments = await api.get<Row[]>(`/api/companies/${company.id}/environments`);
|
|
const selectedId = config.target.mode === "attach" ? config.target.environmentId : undefined;
|
|
const environment = selectedId ? environments.find(env => env.id === selectedId) : environments.find(env => env.status === "active" && (execution.environment.id === "local" ? env.driver === "local" : env.driver === "sandbox" && env.config?.provider === "daytona"));
|
|
if (!environment || (execution.environment.id === "local" ? environment.driver !== "local" : environment.config?.provider !== "daytona")) throw new ConnectionBlock("blocked_target", "configured_execution_environment_required");
|
|
if (execution.profile.generation === "native") {
|
|
const experimental = await api.get("/api/instance/settings/experimental");
|
|
if (!experimental.enableNativeRunner) {
|
|
if (config.target.mode === "attach") throw new ConnectionBlock("blocked_target", "native_runner_disabled_on_target");
|
|
await api.patch("/api/instance/settings/experimental", { enableNativeRunner: true });
|
|
}
|
|
}
|
|
return environment;
|
|
} });
|
|
fixtures = await registry.setupAll();
|
|
const company = fixtures.values.get("connection-company") as Row;
|
|
evidence.companyId = company.id;
|
|
const environment = fixtures.values.get("connection-environment") as Row;
|
|
const observed = await runConnectionFlow({ page, api, execution, config, settings, company, environment, secret, nonce, privateDir, evidence, checkpoint, assertActive,
|
|
createdConnectionIds, refreshOwnedConnections, observeRun: run => observedRuns.set(run.id, run) });
|
|
Object.assign(result, observed);
|
|
evidence.outcome = "passed";
|
|
if (!connectionEvidencePasses(evidence)) throw new ConnectionFailure("connection_proof_incomplete");
|
|
// Only the fixture's synthetic task is captured, after authentication.
|
|
const expectedPath = `/${company.issuePrefix}/issues/${observed.issueIdentifier}`;
|
|
const url = new URL(page.url());
|
|
if (url.origin !== origin || url.pathname !== expectedPath) throw new ConnectionFailure("final_screenshot_route_mismatch");
|
|
const screenshot = await page.screenshot({ path: path.join(privateDir, "final-state.png"), fullPage: true });
|
|
result.screenshots = [{ id: "final-state", label: "Verified connection task and follow-up", file: "final-state.png", sha256: createHash("sha256").update(screenshot).digest("hex") }];
|
|
result.status = "passed";
|
|
} catch (caught) {
|
|
const error = stopped ? new ConnectionBlock("blocked_target", stopped) : caught;
|
|
if (error instanceof AggregateError) result.cleanup = "failed";
|
|
evidence.outcome = error instanceof ConnectionBlock ? error.reason : "failed";
|
|
result.failureClass = error instanceof ConnectionBlock ? "permanent_infrastructure" : classifyFailure(error);
|
|
result.error = safeConnectionFailure(error, evidence.phase);
|
|
} finally {
|
|
clearTimeout(deadlineTimer);
|
|
try { await fixtures?.teardown(); if (result.cleanup !== "failed") result.cleanup = "passed"; }
|
|
catch (cleanupError) { result.cleanup = "failed"; result.status = "failed"; result.failureClass = "cleanup_failure"; result.error = `${result.error ? `${result.error}; ` : ""}fixture_cleanup_failed`;
|
|
const causes = cleanupError instanceof AggregateError ? cleanupError.errors : [cleanupError];
|
|
console.log(`[provider-connections] Cleanup: ${causes.map(cause => safeConnectionFailure(cause, "cleanup")).join(", ")}`); }
|
|
// Also preserve evidence when setup or early cleanup failed before the
|
|
// company teardown reached its capture point. Never refetch deleted runs.
|
|
await collectDiagnostics();
|
|
try { await browser?.close(); }
|
|
catch { result.cleanup = "failed"; result.status = "failed"; result.failureClass = "cleanup_failure"; result.error = "qa_browser_cleanup_failed"; }
|
|
result.finishedAt = new Date().toISOString();
|
|
result.durationMs = Date.parse(result.finishedAt) - Date.parse(startedAt);
|
|
result.runIds = [...observedRuns.keys()];
|
|
// Usage is projected to numeric billing below; opaque provider output is never retained.
|
|
const usage = { runs: [...observedRuns.values()].map(run => ({ usage: run.usageJson })) };
|
|
result.runtimeUsage = buildRuntimeUsage({ environmentId: execution.environment.id, runs: [...observedRuns.values()], fallbackFinishedAt: result.finishedAt });
|
|
result.billing = summarizeExecutionBilling({ ...result, usage });
|
|
// UI environment probes may incur cost without heartbeat usage receipts.
|
|
result.billing.complete = false;
|
|
result.billing.llm.costStatus = result.billing.llm.runsWithTokenUsage ? "partial" : "unavailable";
|
|
result.matcherResults = gradeConnectionEvidence(evidence);
|
|
await safeWrite(path.join(privateDir, "result.json"), result, secrets);
|
|
const manifest = await packageEvidence({ privateDir, uploadDir: evidenceDir, secrets, expectPassScreenshot: false });
|
|
if (manifest.leaks.length || manifest.missing.length) { result.status = "failed"; result.failureClass = "secret_leak"; result.error = "evidence_packaging_failed"; evidence.outcome = "failed"; }
|
|
await safeWrite(path.join(evidenceDir, "result.json"), result, secrets);
|
|
await safeWrite(path.join(evidenceDir, "evidence-manifest.json"), manifest, secrets);
|
|
await safeWrite(path.join(summaryDir, "progress.json"), { executionId: execution.id, ...evidence }, secrets);
|
|
await rm(privateDir, { recursive: true, force: true });
|
|
signal.removeEventListener("abort", interrupt);
|
|
}
|
|
return result;
|
|
}
|
|
|
|
export async function runConnectionCampaign(input: { executions: readonly MatrixExecution[]; catalog: readonly MatrixExecution[]; configFile?: string; repositoryRoot: string }) {
|
|
return withConnectionCampaignCancellation(async (signal) => {
|
|
if (input.executions.some(e => e.task.flow !== "provider_connection")) throw new ConnectionFailure("Select provider-connections separately from other suites.");
|
|
const config = await loadConnectionConfig(input.configFile);
|
|
const campaignId = `connections-${new Date().toISOString().replace(/[:.]/g, "-")}-${randomBytes(3).toString("hex")}`;
|
|
const summaryDir = path.join(input.repositoryRoot, "tests/runner-e2e/results", campaignId);
|
|
await mkdir(summaryDir, { recursive: true, mode: 0o700 });
|
|
const results: RunnerE2EResult[] = [];
|
|
let target: Awaited<ReturnType<typeof startConnectionTarget>> | undefined;
|
|
try {
|
|
assertConnectionCampaignActive(signal);
|
|
target = await startConnectionTarget(config, input.executions, input.repositoryRoot, signal);
|
|
assertConnectionCampaignActive(signal);
|
|
console.log(`[provider-connections] ${input.executions.length} selected cells; target ${target.origin}; one browser/account at a time; max ${config.maxRuns} task runs and ${config.budgetCents} cents per fixture. UI probe spend may be unreported.`);
|
|
for (const execution of input.executions) {
|
|
assertConnectionCampaignActive(signal);
|
|
console.log(`[provider-connections] Starting ${execution.id}`);
|
|
const result = await connectionAttempt(execution, config, target.origin, summaryDir, input.repositoryRoot, signal);
|
|
results.push(result);
|
|
console.log(`[provider-connections] ${result.providerConnection!.outcome}: ${execution.id}${result.error ? ` (${result.error})` : ""}`);
|
|
// Every completed/blocked cell is durable before the next login begins.
|
|
await writeConnectionCampaignReport(input, campaignId, summaryDir, results);
|
|
if (signal.aborted || result.error === "test_interrupted" || result.providerConnection!.outcome === "awaiting_user") break;
|
|
}
|
|
} catch (error) {
|
|
if (!signal.aborted) throw error;
|
|
// Preserve completed receipts even if interrupted during server startup or
|
|
// report generation. Cancellation never admits another cell.
|
|
await writeConnectionCampaignReport(input, campaignId, summaryDir, results);
|
|
} finally { await target?.stop(); }
|
|
console.log(`[provider-connections] Report: ${path.join(summaryDir, "dashboard.html")}`);
|
|
if (signal.aborted || results.some(result => result.status !== "passed" || result.cleanup !== "passed")) process.exitCode = 1;
|
|
return summaryDir;
|
|
});
|
|
}
|
|
|
|
function assertConnectionCampaignActive(signal: AbortSignal) {
|
|
if (signal.aborted) throw new ConnectionBlock("blocked_target", "test_interrupted");
|
|
}
|
|
|
|
/** One cancellation state covers configuration, startup, every cell, reports,
|
|
* and owned-target teardown. Repeated signals cannot reset it. */
|
|
export async function withConnectionCampaignCancellation<T>(run: (signal: AbortSignal) => Promise<T>): Promise<T> {
|
|
const controller = new AbortController();
|
|
const interrupt = () => controller.abort();
|
|
const signals = ["SIGINT", "SIGTERM", "SIGHUP"] as const;
|
|
for (const signal of signals) process.on(signal, interrupt);
|
|
try { return await run(controller.signal); }
|
|
finally { for (const signal of signals) process.removeListener(signal, interrupt); }
|
|
}
|
|
|
|
export async function writeConnectionCampaignReport(input: { executions: readonly MatrixExecution[]; catalog: readonly MatrixExecution[] }, campaignId: string, summaryDir: string, results: RunnerE2EResult[]) {
|
|
const generatedAt = new Date().toISOString();
|
|
const expected = input.executions.map(e => e.id);
|
|
const campaign = buildRunnerCampaign({ campaignId, generatedAt, expected, results });
|
|
await safeWrite(path.join(summaryDir, "campaign.json"), campaign, []);
|
|
await safeWrite(path.join(summaryDir, "normalized-results.json"), { ...campaign, results: results.map(result => ({ ...result, evidenceValid: result.failureClass !== "secret_leak", evidenceErrors: result.failureClass === "secret_leak" ? ["evidence_packaging_failed"] : [] })) }, []);
|
|
await stageDashboardBrandAssets(summaryDir);
|
|
await safeWrite(path.join(summaryDir, "connection-coverage.json"), {
|
|
required: input.catalog.filter(e => e.suite.id === "provider-connections").length,
|
|
selected: expected.length, attempted: results.length, passed: results.filter(r => r.status === "passed" && r.cleanup === "passed").length,
|
|
blocked: results.filter(r => ["awaiting_user", "missing_credential", "blocked_target"].includes(r.providerConnection!.outcome)).length,
|
|
targets: [...new Set(results.map(r => r.providerConnection!.target.origin))],
|
|
gaps: [...connectionScopeGaps, ...connectionHarnesses.flatMap(h => connectionModes.filter(mode => !supportsConnection(h, mode)).map(mode => ({ adapter: h.adapter, mode, status: "unsupported" })))],
|
|
}, []);
|
|
const dashboard = renderRunnerE2EDashboard({ title: `Live provider connections · ${campaignId}`, generatedAt, expected, catalog: input.catalog, campaign,
|
|
entries: results.map(result => ({ result, valid: result.failureClass !== "secret_leak", errors: result.failureClass === "secret_leak" ? ["evidence_packaging_failed"] : [], evidenceBaseHref: [result.suiteId, result.profileId, result.environmentId, result.caseId, "attempt-1"].join("/") })) });
|
|
await writeFile(path.join(summaryDir, "dashboard.html"), dashboard, { mode: 0o600 });
|
|
}
|