mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-13 04:02:28 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Agent runs often need provider credentials, API tokens, and other environment-bound secrets. > - Company-level secrets work for shared credentials, but they do not model values that should differ by human operator. > - Without a user-scoped model, a run can dispatch without knowing whether the responsible human has supplied the needed value. > - Paperclip also needs run attribution to make those user-scoped runtime checks deterministic and auditable. > - This pull request adds user-specific secret definitions, per-user values, environment bindings, responsible-user attribution, and runtime resolution gates. > - The benefit is that teams can define the secret once, let each user provide their own value, and block runs before dispatch when required user secrets or active definitions are unavailable. ## Linked Issues or Issue Description Refs #224 Refs #6057 This PR implements user-specific secret support as a core secret-management capability rather than a one-off adapter setting. It is related to existing public work on company secrets UI and runtime secret refs, but is distinct because the value is owned by the responsible user and resolved at run dispatch time. Related PR search before opening found existing secrets work such as #1550, #8256, #8614, #8634, and #8647; none of those add the full user-secret definition/value/runtime gate covered here. ## What Changed - Added user-secret definitions and per-user "My secrets" values, keeping stored values out of access metadata. - Added `user_secret_ref` environment bindings and UI affordances to pick them alongside existing secret refs. - Added responsible-user runtime resolution so user-secret refs resolve against the human responsible for the run. - Added pre-dispatch missing-secret gates so runs fail before adapter dispatch when required user values are absent or definitions are inactive. - Added low-trust allowlist hardening for user-secret runtime access. - Added issue, routine, run, and agent API key responsible-user attribution and fail-closed dispatch behavior when attribution cannot be resolved. - Added denial-copy mapping so responsible-user authorization failures surface as actionable run outcomes instead of opaque setup failures. - Added OpenAPI documentation for the user-secret routes. - Rebases cleanly on current `master`; migrations were renumbered incrementally as `0128_user_specific_secrets`, `0129_agent_api_key_responsible_user`, and `0130_run_responsible_user_invariant` after upstream `0126`/`0127` migrations. - Removed previously committed local design screenshots so the PR contains code/docs/tests only. ## Verification - PASS: PR head `2527febd106bcf3ca264ca0da7fca491084192d6` is based on `paperclipai/paperclip:master`. - PASS: `git diff --check` - PASS: `git diff --name-only public/master...HEAD | rg '^(pnpm-lock\\.yaml|\\.github/workflows/|screenshots/)' || true` produced no files. - PASS: migration journal audit confirmed unique indexes through `130` with tail entries `0126_issue_comment_derived_attribution`, `0127_environment_custom_images_instance_scoped`, `0128_user_specific_secrets`, `0129_agent_api_key_responsible_user`, and `0130_run_responsible_user_invariant`. - PASS: `pnpm --filter @paperclipai/ui typecheck` - PASS: `pnpm --filter @paperclipai/server typecheck` - PASS: `pnpm --filter @paperclipai/server exec vitest run src/__tests__/heartbeat-responsible-user-invariant.test.ts` - PASS: `pnpm --filter @paperclipai/server exec vitest run src/__tests__/heartbeat-active-run-output-watchdog.test.ts src/__tests__/heartbeat-stale-queue-invalidation.test.ts src/__tests__/heartbeat-workspace-finalize-branch.test.ts src/__tests__/issue-monitor-scheduler.test.ts` - PASS: `pnpm --filter @paperclipai/server exec vitest run src/__tests__/heartbeat-comment-wake-batching.test.ts src/__tests__/heartbeat-retry-scheduling.test.ts src/__tests__/heartbeat-accepted-plan-workspace-refresh.test.ts src/__tests__/heartbeat-plugin-environment.test.ts` - PASS: `pnpm --filter @paperclipai/server exec vitest run src/__tests__/low-trust-red-team-routes.test.ts` - PASS: `pnpm --filter @paperclipai/server exec vitest run src/__tests__/secrets-service.test.ts` (55 tests) - PASS: `pnpm vitest run server/src/__tests__/secrets-routes.test.ts server/src/__tests__/secrets-service.test.ts` (89 tests after final Greptile cleanup fixes) - PASS: `pnpm --filter @paperclipai/server exec vitest run src/__tests__/heartbeat-issue-liveness-escalation.test.ts` (17 tests after the final rebase CI fix) - PASS: focused server Vitest batches covering heartbeat recovery, project env, plugin env, routines, low-trust, pipelines, monitors, watchdog, and stale queue paths. - PASS: GitHub checks are green on `2527febd106bcf3ca264ca0da7fca491084192d6`, including Typecheck + Release Registry, Build, General tests, serialized server suites, e2e, Canary Dry Run, verify, security checks, and Greptile Review. - PASS: Greptile Review completed successfully on `2527febd106bcf3ca264ca0da7fca491084192d6` with Confidence Score 5/5, and GraphQL review-thread audit returned zero unresolved non-outdated threads. ## Risks - Runtime behavior now depends on a run having a correct responsible user; missing or incorrect responsibility assignment can block runs before adapter dispatch. - `user_secret_ref` bindings intentionally expose metadata without values, but UI/API callers may need to handle the new binding kind explicitly. - External secret providers and IAM policies are not automatically provisioned by this PR; operators still need to configure provider-side access for non-local vaults. - The PR is broad across db/shared/server/UI/runtime paths, so release validation should include both API and UI secret workflows before merge. - The migration renumbering is intentionally incremental after upstream migrations; the branch migrations use guarded column/table/index/constraint creation so users who tested the older draft numbering should not hit duplicate DDL for the existing objects. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex, GPT-5-based coding agent (`gpt-5`), Codex local adapter with shell/tool use and code execution. Context window and internal reasoning mode are not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
252 lines
9.2 KiB
TypeScript
252 lines
9.2 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { buildAgentMentionHref } from "@paperclipai/shared";
|
|
import {
|
|
bodyHasAgentMention,
|
|
classifyAssigneeHandoff,
|
|
computePauseAffectsSummary,
|
|
computeComposerHandoffPreview,
|
|
describeReassignInterrupt,
|
|
extractAgentMentionIds,
|
|
findPlainAgentNameCandidate,
|
|
isOperatorInterruptedRun,
|
|
resolveRunStatusPresentation,
|
|
type PauseAffectsIssueLike,
|
|
} from "./interrupt-handoff";
|
|
|
|
const QA_ID = "agent-qa-1111";
|
|
const QA_HREF = buildAgentMentionHref(QA_ID, null);
|
|
const qaMention = `[@QA](${QA_HREF})`;
|
|
|
|
describe("isOperatorInterruptedRun", () => {
|
|
it("detects operator interrupts via errorCode", () => {
|
|
expect(isOperatorInterruptedRun(null, "operator_interrupted")).toBe(true);
|
|
});
|
|
|
|
it("detects operator interrupts via resultJson flag", () => {
|
|
expect(isOperatorInterruptedRun({ operatorInterrupted: true })).toBe(true);
|
|
expect(isOperatorInterruptedRun({ interruptionSource: "issue_comment_interrupt" })).toBe(true);
|
|
});
|
|
|
|
it("does not flag ordinary cancels or failures", () => {
|
|
expect(isOperatorInterruptedRun({ stopReason: "cancelled" }, "cancelled")).toBe(false);
|
|
expect(isOperatorInterruptedRun(null, "claude_exit_143")).toBe(false);
|
|
expect(isOperatorInterruptedRun(null)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("resolveRunStatusPresentation", () => {
|
|
it("renders an operator-interrupted cancel as amber 'interrupted'", () => {
|
|
const p = resolveRunStatusPresentation("cancelled", { operatorInterrupted: true });
|
|
expect(p.label).toBe("interrupted");
|
|
expect(p.className).toContain("amber");
|
|
expect(p.srHint).toMatch(/board comment/);
|
|
});
|
|
|
|
it("renders a plain cancel as muted 'cancelled'", () => {
|
|
const p = resolveRunStatusPresentation("cancelled");
|
|
expect(p.label).toBe("cancelled");
|
|
expect(p.className).toContain("muted");
|
|
expect(p.srHint).toBeNull();
|
|
});
|
|
|
|
it("leaves failed/succeeded untouched", () => {
|
|
expect(resolveRunStatusPresentation("failed").className).toContain("red");
|
|
expect(resolveRunStatusPresentation("timed_out").label).toBe("timed out");
|
|
});
|
|
});
|
|
|
|
describe("structured mention vs plain text", () => {
|
|
it("extracts agent ids only from structured agent:// links", () => {
|
|
expect(extractAgentMentionIds(`hey ${qaMention} please look`)).toEqual([QA_ID]);
|
|
expect(bodyHasAgentMention(`hey ${qaMention}`)).toBe(true);
|
|
});
|
|
|
|
it("treats a plain QA name as NOT a mention", () => {
|
|
expect(bodyHasAgentMention("QA you take the screenshot")).toBe(false);
|
|
expect(extractAgentMentionIds("ask QA to confirm")).toEqual([]);
|
|
});
|
|
|
|
it("flags a plain agent-name candidate for the coach", () => {
|
|
const candidate = findPlainAgentNameCandidate("ask QA to confirm", [
|
|
{ agentId: QA_ID, name: "QA" },
|
|
]);
|
|
expect(candidate?.agentId).toBe(QA_ID);
|
|
expect(candidate?.matchedText).toBe("QA");
|
|
});
|
|
|
|
it("does not flag a name that is already a structured chip", () => {
|
|
const candidate = findPlainAgentNameCandidate(`hey ${qaMention} thanks`, [
|
|
{ agentId: QA_ID, name: "QA" },
|
|
]);
|
|
expect(candidate).toBeNull();
|
|
});
|
|
|
|
it("matches by role as well as display name", () => {
|
|
const candidate = findPlainAgentNameCandidate("can the reviewer check this", [
|
|
{ agentId: "agent-x", name: "Casey", role: "reviewer" },
|
|
]);
|
|
expect(candidate?.matchedText).toBe("reviewer");
|
|
});
|
|
});
|
|
|
|
describe("computeComposerHandoffPreview", () => {
|
|
const base = {
|
|
currentAssigneeValue: "agent:claude-1",
|
|
hasActiveRun: true,
|
|
bodyHasAgentMention: false,
|
|
plainNameCandidate: null,
|
|
};
|
|
|
|
it("A. reassign to agent with active run = interrupt + handoff", () => {
|
|
const p = computeComposerHandoffPreview({ ...base, reassignTarget: `agent:${QA_ID}` });
|
|
expect(p.kind).toBe("interrupt_handoff_agent");
|
|
expect(p.chip).toEqual({ kind: "agent", id: QA_ID });
|
|
expect(p.tone).toBe("neutral");
|
|
});
|
|
|
|
it("reassign to agent with no active run = wake", () => {
|
|
const p = computeComposerHandoffPreview({
|
|
...base,
|
|
hasActiveRun: false,
|
|
reassignTarget: `agent:${QA_ID}`,
|
|
});
|
|
expect(p.kind).toBe("wake_agent");
|
|
});
|
|
|
|
it("B. reassign to user = handoff, no agent wake", () => {
|
|
const p = computeComposerHandoffPreview({ ...base, reassignTarget: "user:user-board" });
|
|
expect(p.kind).toBe("user_handoff");
|
|
expect(p.chip).toEqual({ kind: "user", id: "user-board" });
|
|
expect(p.suffix).toMatch(/no agent/i);
|
|
});
|
|
|
|
it("clearing the assignee reads as no agent wake", () => {
|
|
const p = computeComposerHandoffPreview({ ...base, reassignTarget: "__none__" });
|
|
expect(p.kind).toBe("clear_assignee");
|
|
expect(p.text).toMatch(/no agent/i);
|
|
});
|
|
|
|
it("no reassign + structured mention = notify agent", () => {
|
|
const p = computeComposerHandoffPreview({
|
|
...base,
|
|
reassignTarget: base.currentAssigneeValue,
|
|
bodyHasAgentMention: true,
|
|
mentionedAgentId: QA_ID,
|
|
});
|
|
expect(p.kind).toBe("notify_agent");
|
|
expect(p.chip).toEqual({ kind: "agent", id: QA_ID });
|
|
});
|
|
|
|
it("C. no reassign + plain name only = amber warning, no wake", () => {
|
|
const p = computeComposerHandoffPreview({
|
|
...base,
|
|
reassignTarget: base.currentAssigneeValue,
|
|
plainNameCandidate: { agentId: QA_ID, matchedText: "QA" },
|
|
});
|
|
expect(p.kind).toBe("plain_text_only");
|
|
expect(p.tone).toBe("warn");
|
|
expect(p.chip).toBeUndefined();
|
|
});
|
|
|
|
it("nothing notable = hidden preview", () => {
|
|
const p = computeComposerHandoffPreview({
|
|
...base,
|
|
reassignTarget: base.currentAssigneeValue,
|
|
});
|
|
expect(p.kind).toBe("none");
|
|
});
|
|
});
|
|
|
|
describe("classifyAssigneeHandoff", () => {
|
|
it("A. to agent = queued wake", () => {
|
|
const info = classifyAssigneeHandoff({ agentId: QA_ID, userId: null }, { agentName: "QA" });
|
|
expect(info.kind).toBe("agent_wake");
|
|
expect(info.wakeText).toMatch(/queued for QA/);
|
|
});
|
|
|
|
it("agent wake notes attached interrupted run when present", () => {
|
|
const info = classifyAssigneeHandoff(
|
|
{ agentId: QA_ID, userId: null },
|
|
{ agentName: "QA", interruptedRunAttached: true },
|
|
);
|
|
expect(info.wakeText).toMatch(/interrupted run attached/);
|
|
});
|
|
|
|
it("B. to user = no wake, board handoff", () => {
|
|
const info = classifyAssigneeHandoff({ agentId: null, userId: "user-board" });
|
|
expect(info.kind).toBe("user_handoff");
|
|
expect(info.wakeText).toMatch(/not created/);
|
|
});
|
|
|
|
it("C. unassigned = no wake, needs explicit agent", () => {
|
|
const info = classifyAssigneeHandoff({ agentId: null, userId: null });
|
|
expect(info.kind).toBe("unassigned");
|
|
expect(info.wakeText).toMatch(/no agent selected/);
|
|
});
|
|
});
|
|
|
|
describe("describeReassignInterrupt", () => {
|
|
it("names the running agent in the banner and confirm", () => {
|
|
const copy = describeReassignInterrupt({ runningAgentName: "ClaudeCoder" });
|
|
expect(copy.banner).toBe("ClaudeCoder is running — changing the responsible will interrupt this run.");
|
|
expect(copy.confirmAction).toBe("Interrupt & assign");
|
|
expect(copy.cancelAction).toBe("Cancel");
|
|
});
|
|
|
|
it("falls back to a generic subject when no name is known", () => {
|
|
expect(describeReassignInterrupt().banner).toMatch(/^An agent is running/);
|
|
expect(describeReassignInterrupt({ runningAgentName: " " }).banner).toMatch(/^An agent is running/);
|
|
});
|
|
});
|
|
|
|
describe("computePauseAffectsSummary", () => {
|
|
const issue = (over: Partial<PauseAffectsIssueLike>): PauseAffectsIssueLike => ({
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
activeRun: null,
|
|
...over,
|
|
});
|
|
const bucket = (summary: ReturnType<typeof computePauseAffectsSummary>, key: string) =>
|
|
summary.buckets.find((b) => b.key === key)!;
|
|
|
|
it("partitions affected issues into disjoint buckets", () => {
|
|
const summary = computePauseAffectsSummary([
|
|
issue({ assigneeAgentId: "a1", activeRun: { status: "running" } }),
|
|
issue({ assigneeAgentId: "a2", activeRun: { status: "queued" } }),
|
|
issue({ assigneeAgentId: "a3" }),
|
|
issue({ assigneeUserId: "u1" }),
|
|
issue({}),
|
|
]);
|
|
expect(bucket(summary, "live_runs").count).toBe(1);
|
|
expect(bucket(summary, "queued_wakes").count).toBe(1);
|
|
expect(bucket(summary, "agent_owned").count).toBe(1);
|
|
expect(bucket(summary, "human_owned").count).toBe(1);
|
|
expect(bucket(summary, "static").count).toBe(1);
|
|
expect(summary.affectedIssueCount).toBe(5);
|
|
expect(summary.nothingLive).toBe(false);
|
|
});
|
|
|
|
it("ignores skipped issues", () => {
|
|
const summary = computePauseAffectsSummary([
|
|
issue({ assigneeAgentId: "a1", activeRun: { status: "running" }, skipped: true }),
|
|
issue({ assigneeUserId: "u1" }),
|
|
]);
|
|
expect(summary.affectedIssueCount).toBe(1);
|
|
expect(bucket(summary, "live_runs").count).toBe(0);
|
|
expect(bucket(summary, "human_owned").count).toBe(1);
|
|
});
|
|
|
|
it("flags nothingLive when no run is live or queued", () => {
|
|
const summary = computePauseAffectsSummary([issue({ assigneeUserId: "u1" }), issue({})]);
|
|
expect(summary.nothingLive).toBe(true);
|
|
});
|
|
|
|
it("an active run wins over the issue's owner bucket", () => {
|
|
const summary = computePauseAffectsSummary([
|
|
issue({ assigneeAgentId: "a1", activeRun: { status: "running" } }),
|
|
]);
|
|
expect(bucket(summary, "live_runs").count).toBe(1);
|
|
expect(bucket(summary, "agent_owned").count).toBe(0);
|
|
});
|
|
});
|