mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-22 11:54:35 +01:00
> [!NOTE] > Opened by Prospector's automated issue-fix pipeline. A maintainer reviews and decides; nothing here merges on its own. > [!WARNING] > This change crosses a trust boundary. See Risks. ## Thinking Path - Issue #17866 reports a defect in paperclipai/paperclip. - Root cause, as the fixing agent read it: Viewport observation and conversation sizing were tied to the mobile navigation breakpoint. The earlier attempt also retained keyboard state during zoom and excluded classic task threads from keyboard sizing. - This pull request: Keep tablet task composers above the keyboard and release sizing during pinch zoom ## What Changed - `ui/src/components/Layout.tsx`: Retain viewport observation independent of navigation width. - `ui/src/components/Layout.production.tsx`: Apply the same viewport observation to the production layout. - `ui/src/hooks/useMobileVisualViewport.ts`: Clear keyboard state during pinch zoom and handle Safari document panning for classic conversation shells. - `ui/src/pages/IssueDetail.tsx`: Mark desktop-width classic chat pages for keyboard sizing while preserving phone layouts and other tabs. - `ui/src/index.css`: Constrain classic conversation shells during keyboard display, retain main-content scrolling, and keep their sticky composer inside the visible area. - `ui/src/hooks/useMobileVisualViewport.test.tsx`: Reproduce stale keyboard state after zoom and verify recovery. - `ui/src/components/Layout.viewport.test.tsx`: Cover both layouts, both conversation shells, zoom recovery, and document pan correction. - `ui/src/pages/IssueDetail.test.tsx`: Verify classic sizing eligibility at desktop and phone widths. Regression tests, existing thread tests, and typecheck passed. ## Verification - Reproducing test(s), added in this PR: `ui/src/hooks/useMobileVisualViewport.test.tsx`, `ui/src/pages/IssueDetail.test.tsx`, `ui/src/components/Layout.viewport.test.tsx`, `ui/src/components/Layout.test.tsx` - They fail on the base commit and pass with the fix, each twice in a fresh sandbox. - 3 independent attempts wrote 3 reproductions; this fix passes every one of them. - The repository's compile command passes with the fix applied. - 10 existing test file(s) near the change passed. - The full test suite passes except for the 15 file(s) that already fail on the base commit. - Revised in 1 round(s) of automated code review. ## Risks - Written by an automated pipeline, not a person: review it as you would an outside contribution. - Risk tier of the touched paths: 3. - The scope reviewer found it also changes, beyond the report: Enabled hook callers entering zoom after keyboard detection: both Layout variants, hook test hosts, and task-chat-mobile-follow Storybook - The scope reviewer found it also changes, beyond the report: Missing visualViewport or shell; disabled hook; zero, negative, non-finite, or missing viewport height; missing or malformed scale - It crosses a trust boundary. Check each crossing against what the issue asked for, and against who asked: - validation (ui/src/components/Layout.tsx:155): Passing true removes the mobile-width eligibility check for viewport keyboard handling. - validation (ui/src/components/Layout.production.tsx:182): Passing true removes the mobile-width eligibility check in the production layout. - validation (ui/src/hooks/useMobileVisualViewport.ts:12, not asked for by the report): The scroll-reset guard now accepts classic task shells as well as task-chat shells. ## Model Used - codex:gpt-6.1-sol, opus, sonnet (Anthropic Claude, via Claude Code; OpenAI, via the Codex CLI), writing and checking the change in an isolated sandbox. - opus (Anthropic Claude, via Claude Code), reviewing it independently. ## Linked Issues Fixes #17866 A search of paperclipai/paperclip's open and closed pull requests found no other pull request that names #17866. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [ ] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with 'Fixes: #' / 'Closes #' / 'Refs #' OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub '#NNN' / 'github.com/paperclipai/paperclip' URLs) - [ ] My branch name describes the change (e.g. 'docs/...', 'fix/...') and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [ ] I will address all Greptile and reviewer comments before requesting merge <!-- prospector:issue-fix v1 issue=17866 base=f8cb4957dcd9 report=8607f5fafe77c2be --> Co-authored-by: commitperclip[bot] <284812584+commitperclip[bot]@users.noreply.github.com>
52 lines
2.3 KiB
TypeScript
52 lines
2.3 KiB
TypeScript
import { useLayoutEffect, useRef } from "react";
|
|
|
|
/** Size the mobile conversation shell, never translate it with Safari's pan.
|
|
* CSS owns the fixed shell and its flex layout; messages own their scrolling. */
|
|
export function useMobileVisualViewport(enabled: boolean) {
|
|
const ref = useRef<HTMLDivElement>(null);
|
|
useLayoutEffect(() => {
|
|
const shell = ref.current;
|
|
const viewport = window.visualViewport;
|
|
if (!enabled || !shell || !viewport) return;
|
|
const restoreDocumentPosition = () => {
|
|
if (viewport.scale !== 1 || shell.dataset.keyboardOpen !== "true" || !shell.querySelector("[data-task-chat-shell], [data-classic-task-shell]")) return;
|
|
const page = document.scrollingElement ?? document.documentElement;
|
|
if (page.scrollTop !== 0) page.scrollTop = 0;
|
|
};
|
|
const update = () => {
|
|
if (viewport.scale !== 1) {
|
|
delete shell.dataset.keyboardOpen;
|
|
return;
|
|
}
|
|
if (!Number.isFinite(viewport.height) || viewport.height <= 0) return;
|
|
// Read geometry before writing styles, avoiding a forced layout after our
|
|
// own height update. Nothing here subscribes to input or thread updates.
|
|
const keyboardOpen = document.documentElement.clientHeight - viewport.height > 120;
|
|
shell.style.setProperty("--mobile-chat-viewport-height", `${viewport.height}px`);
|
|
// innerHeight can shrink with visualViewport on iOS, so it is not the
|
|
// keyboard-closed baseline. The layout viewport remains stable.
|
|
if (keyboardOpen) {
|
|
shell.dataset.keyboardOpen = "true";
|
|
} else {
|
|
delete shell.dataset.keyboardOpen;
|
|
}
|
|
restoreDocumentPosition();
|
|
};
|
|
update();
|
|
viewport.addEventListener("resize", update);
|
|
window.addEventListener("resize", update);
|
|
// Safari can apply its pre-keyboard focus pan AFTER the resize. The fixed
|
|
// document is not a scroll surface. Listen without capture so scrolls in
|
|
// the message list/editor never reach this fallback.
|
|
document.addEventListener("scroll", restoreDocumentPosition);
|
|
return () => {
|
|
viewport.removeEventListener("resize", update);
|
|
window.removeEventListener("resize", update);
|
|
document.removeEventListener("scroll", restoreDocumentPosition);
|
|
shell.style.removeProperty("--mobile-chat-viewport-height");
|
|
delete shell.dataset.keyboardOpen;
|
|
};
|
|
}, [enabled]);
|
|
return ref;
|
|
}
|