mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-17 10:06:42 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Governed MCP access spans contracts, runtime enforcement, adapters, UI surfaces, and operator verification > - The parity reference PR #9534 is too large for effective automated or human review > - The feature therefore needs a linear stack whose individual diffs stay below the 100-file review limit > - This pull request is split 1/8 and focuses on fixture and demo MCP servers > - The benefit is a standalone, testable review boundary while preserving byte-for-byte parity at the top of the stack ## Linked Issues or Issue Description - Related parity reference: #9534 - Problem: Developers need deterministic local MCP fixtures and visible demo servers without pulling in the governed production runtime. - Proposed solution: Adds the Google Sheets and KV demo MCP packages, fixture catalog/servers, smoke harness, guide, and the root smoke/typecheck registration hunks. - Alternatives considered: keeping #9534 as one 403-file review, or rewriting the feature to manufacture seams; both were rejected in favor of path extraction plus compile-driven boundary moves. - Roadmap alignment: this advances the existing governed MCP/tool-access work already represented by #9534; it does not introduce a separate roadmap initiative. - Stack position: base branch is `master`. - Merge policy: merge bottom-up, in order, only after the complete eight-PR stack has been reviewed and the top-of-stack parity gate remains empty. - Requested review: QA for fixture and smoke coverage; Greptile on every PR. ## What Changed - Adds the Google Sheets and KV demo MCP packages, fixture catalog/servers, smoke harness, guide, and the root smoke/typecheck registration hunks. - Keeps this PR below 100 changed files and independently typecheckable. - Preserves the final tree from #9534 when combined with the other seven stack levels. ## Verification - `pnpm typecheck` - `pnpm --filter @paperclipai/google-sheets-mcp-server test` — 27 tests passed - `pnpm --filter @paperclipai/kv-demo-mcp-server test` — 12 tests passed ## Risks - The new packages add dependencies that are intentionally not committed to `pnpm-lock.yaml`, per repository policy. - Stack risk: merging out of order can expose incomplete layers; mitigate by following the documented bottom-up merge policy. - Parity risk: later edits to an intermediate branch can drift from #9534; mitigate by re-running the empty top-of-stack diff before merge. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, exact model ID `gpt-5.4`; runtime-managed context window; medium reasoning with repository, shell, Git, GitHub CLI, and code-execution tools enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] Internal references are omitted except the execution-plan link explicitly required for this coordinated split stack - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge ## Stack Coordination - Internal execution plan: [PAP-13874](/PAP/issues/PAP-13874#document-plan) - Parity reference: #9534 - Stack: #9556 → #9557 → #9558 → #9559 → #9560 → #9561 → #9562 → #9563 - Merge bottom-up only after full-stack review and an empty parity diff at #9563. --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
267 lines
8.2 KiB
TypeScript
267 lines
8.2 KiB
TypeScript
import { google } from "googleapis";
|
|
import type { GoogleSheetsServiceAccount } from "./config.js";
|
|
|
|
export interface SpreadsheetSummary {
|
|
spreadsheetId: string;
|
|
title: string | null;
|
|
spreadsheetUrl: string | null;
|
|
}
|
|
|
|
export interface SheetTabSummary {
|
|
sheetId: number;
|
|
title: string;
|
|
index: number | null;
|
|
rowCount: number | null;
|
|
columnCount: number | null;
|
|
}
|
|
|
|
export interface SpreadsheetInfo extends SpreadsheetSummary {
|
|
sheets: SheetTabSummary[];
|
|
}
|
|
|
|
export interface ValuesResult {
|
|
spreadsheetId: string;
|
|
range: string;
|
|
values: unknown[][];
|
|
}
|
|
|
|
export interface SearchRowsResult {
|
|
spreadsheetId: string;
|
|
range: string;
|
|
query: string;
|
|
matches: Array<{
|
|
rowIndex: number;
|
|
values: unknown[];
|
|
}>;
|
|
}
|
|
|
|
export interface WriteResult {
|
|
spreadsheetId: string;
|
|
range: string;
|
|
updatedRange?: string | null;
|
|
updatedRows?: number | null;
|
|
updatedCells?: number | null;
|
|
}
|
|
|
|
export interface GoogleSheetsClient {
|
|
listSpreadsheets(spreadsheetIds: string[]): Promise<SpreadsheetSummary[]>;
|
|
getSpreadsheetInfo(spreadsheetId: string): Promise<SpreadsheetInfo>;
|
|
readValues(spreadsheetId: string, range: string): Promise<ValuesResult>;
|
|
searchRows(input: {
|
|
spreadsheetId: string;
|
|
range: string;
|
|
query: string;
|
|
caseSensitive?: boolean;
|
|
maxResults?: number;
|
|
}): Promise<SearchRowsResult>;
|
|
appendRows(input: {
|
|
spreadsheetId: string;
|
|
range: string;
|
|
values: unknown[][];
|
|
valueInputOption: "RAW" | "USER_ENTERED";
|
|
}): Promise<WriteResult>;
|
|
updateValues(input: {
|
|
spreadsheetId: string;
|
|
range: string;
|
|
values: unknown[][];
|
|
valueInputOption: "RAW" | "USER_ENTERED";
|
|
}): Promise<WriteResult>;
|
|
addSheetTab(input: {
|
|
spreadsheetId: string;
|
|
title: string;
|
|
rowCount?: number;
|
|
columnCount?: number;
|
|
}): Promise<{ spreadsheetId: string; sheet: SheetTabSummary }>;
|
|
clearValues(spreadsheetId: string, range: string): Promise<WriteResult>;
|
|
deleteRows(input: {
|
|
spreadsheetId: string;
|
|
sheetId: number;
|
|
startIndex: number;
|
|
endIndex: number;
|
|
}): Promise<{ spreadsheetId: string; sheetId: number; deletedRows: number }>;
|
|
}
|
|
|
|
type SheetsApi = ReturnType<typeof google.sheets>;
|
|
|
|
function normalizeRows(values: unknown): unknown[][] {
|
|
return Array.isArray(values)
|
|
? values.map((row) => Array.isArray(row) ? row : [row])
|
|
: [];
|
|
}
|
|
|
|
function summarizeSpreadsheet(data: Record<string, unknown>, spreadsheetId: string): SpreadsheetSummary {
|
|
const properties = data.properties as Record<string, unknown> | undefined;
|
|
return {
|
|
spreadsheetId: typeof data.spreadsheetId === "string" ? data.spreadsheetId : spreadsheetId,
|
|
title: typeof properties?.title === "string" ? properties.title : null,
|
|
spreadsheetUrl: typeof data.spreadsheetUrl === "string" ? data.spreadsheetUrl : null,
|
|
};
|
|
}
|
|
|
|
function summarizeSheet(raw: unknown): SheetTabSummary {
|
|
const sheet = raw as Record<string, unknown>;
|
|
const properties = sheet.properties as Record<string, unknown> | undefined;
|
|
const gridProperties = properties?.gridProperties as Record<string, unknown> | undefined;
|
|
return {
|
|
sheetId: Number(properties?.sheetId),
|
|
title: typeof properties?.title === "string" ? properties.title : "Untitled",
|
|
index: typeof properties?.index === "number" ? properties.index : null,
|
|
rowCount: typeof gridProperties?.rowCount === "number" ? gridProperties.rowCount : null,
|
|
columnCount: typeof gridProperties?.columnCount === "number" ? gridProperties.columnCount : null,
|
|
};
|
|
}
|
|
|
|
export function createGoogleSheetsClient(serviceAccount: GoogleSheetsServiceAccount): GoogleSheetsClient {
|
|
const auth = new google.auth.GoogleAuth({
|
|
credentials: serviceAccount,
|
|
scopes: ["https://www.googleapis.com/auth/spreadsheets"],
|
|
});
|
|
const sheets: SheetsApi = google.sheets({ version: "v4", auth });
|
|
|
|
async function getSpreadsheet(spreadsheetId: string, fields?: string) {
|
|
const response = await sheets.spreadsheets.get({ spreadsheetId, fields });
|
|
return response.data as Record<string, unknown>;
|
|
}
|
|
|
|
return {
|
|
async listSpreadsheets(spreadsheetIds) {
|
|
return Promise.all(
|
|
spreadsheetIds.map(async (spreadsheetId) =>
|
|
summarizeSpreadsheet(
|
|
await getSpreadsheet(spreadsheetId, "spreadsheetId,spreadsheetUrl,properties.title"),
|
|
spreadsheetId,
|
|
)
|
|
),
|
|
);
|
|
},
|
|
|
|
async getSpreadsheetInfo(spreadsheetId) {
|
|
const data = await getSpreadsheet(
|
|
spreadsheetId,
|
|
"spreadsheetId,spreadsheetUrl,properties.title,sheets.properties(sheetId,title,index,gridProperties(rowCount,columnCount))",
|
|
);
|
|
return {
|
|
...summarizeSpreadsheet(data, spreadsheetId),
|
|
sheets: Array.isArray(data.sheets) ? data.sheets.map(summarizeSheet) : [],
|
|
};
|
|
},
|
|
|
|
async readValues(spreadsheetId, range) {
|
|
const response = await sheets.spreadsheets.values.get({ spreadsheetId, range });
|
|
return {
|
|
spreadsheetId,
|
|
range: String(response.data.range ?? range),
|
|
values: normalizeRows(response.data.values),
|
|
};
|
|
},
|
|
|
|
async searchRows({ spreadsheetId, range, query, caseSensitive = false, maxResults = 50 }) {
|
|
const values = await this.readValues(spreadsheetId, range);
|
|
const needle = caseSensitive ? query : query.toLowerCase();
|
|
const matches = values.values.flatMap((row, rowIndex) => {
|
|
const haystack = row.map((cell) => String(cell ?? "")).join("\t");
|
|
const comparable = caseSensitive ? haystack : haystack.toLowerCase();
|
|
return comparable.includes(needle) ? [{ rowIndex: rowIndex + 1, values: row }] : [];
|
|
});
|
|
return {
|
|
spreadsheetId,
|
|
range: values.range,
|
|
query,
|
|
matches: matches.slice(0, maxResults),
|
|
};
|
|
},
|
|
|
|
async appendRows({ spreadsheetId, range, values, valueInputOption }) {
|
|
const response = await sheets.spreadsheets.values.append({
|
|
spreadsheetId,
|
|
range,
|
|
valueInputOption,
|
|
requestBody: { values },
|
|
});
|
|
return {
|
|
spreadsheetId,
|
|
range,
|
|
updatedRange: response.data.updates?.updatedRange ?? null,
|
|
updatedRows: response.data.updates?.updatedRows ?? null,
|
|
updatedCells: response.data.updates?.updatedCells ?? null,
|
|
};
|
|
},
|
|
|
|
async updateValues({ spreadsheetId, range, values, valueInputOption }) {
|
|
const response = await sheets.spreadsheets.values.update({
|
|
spreadsheetId,
|
|
range,
|
|
valueInputOption,
|
|
requestBody: { values },
|
|
});
|
|
return {
|
|
spreadsheetId,
|
|
range,
|
|
updatedRange: response.data.updatedRange ?? null,
|
|
updatedRows: response.data.updatedRows ?? null,
|
|
updatedCells: response.data.updatedCells ?? null,
|
|
};
|
|
},
|
|
|
|
async addSheetTab({ spreadsheetId, title, rowCount, columnCount }) {
|
|
const response = await sheets.spreadsheets.batchUpdate({
|
|
spreadsheetId,
|
|
requestBody: {
|
|
requests: [{
|
|
addSheet: {
|
|
properties: {
|
|
title,
|
|
gridProperties: {
|
|
...(rowCount === undefined ? {} : { rowCount }),
|
|
...(columnCount === undefined ? {} : { columnCount }),
|
|
},
|
|
},
|
|
},
|
|
}],
|
|
},
|
|
});
|
|
const addedSheet = response.data.replies?.[0]?.addSheet;
|
|
return {
|
|
spreadsheetId,
|
|
sheet: summarizeSheet(addedSheet ?? { properties: { title } }),
|
|
};
|
|
},
|
|
|
|
async clearValues(spreadsheetId, range) {
|
|
const response = await sheets.spreadsheets.values.clear({
|
|
spreadsheetId,
|
|
range,
|
|
requestBody: {},
|
|
});
|
|
return {
|
|
spreadsheetId,
|
|
range,
|
|
updatedRange: response.data.clearedRange ?? null,
|
|
};
|
|
},
|
|
|
|
async deleteRows({ spreadsheetId, sheetId, startIndex, endIndex }) {
|
|
await sheets.spreadsheets.batchUpdate({
|
|
spreadsheetId,
|
|
requestBody: {
|
|
requests: [{
|
|
deleteDimension: {
|
|
range: {
|
|
sheetId,
|
|
dimension: "ROWS",
|
|
startIndex,
|
|
endIndex,
|
|
},
|
|
},
|
|
}],
|
|
},
|
|
});
|
|
return {
|
|
spreadsheetId,
|
|
sheetId,
|
|
deletedRows: endIndex - startIndex,
|
|
};
|
|
},
|
|
};
|
|
}
|