mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - Chat replies, comments and documents render Markdown through
`MarkdownBody`. Task links in that Markdown become company-aware links
> - `parseIssueReferenceFromHref` turned every task link into an
unprefixed `/issues/<id>` path. The router then added the viewer's
active company prefix
> - In chat-eval cohort 4 (`access.other-company`), a reply in company
COM linked `/BIR/issues/BIR-1`. The chat rendered it as
`/COM/issues/BIR-1`, which points into the wrong company
> - This pull request keeps the company that a task link names: an
explicit `/BIR/issues/...` prefix, or an identifier whose prefix belongs
to a known company
> - The benefit is that a link to another company's task opens that
company's task, not a same-numbered task or an error in the current
company
## Linked Issues or Issue Description
**What happened?**
A chat reply in company COM contained `[BIR-1](/BIR/issues/BIR-1)`. The
rendered link pointed to `/COM/issues/BIR-1`.
**Expected behavior**
A task link that names a company keeps that company: `/BIR/issues/BIR-1`
stays `/BIR/issues/BIR-1`. A bare `BIR-1` or `/issues/BIR-1` goes to BIR
when BIR is a company that the viewer knows.
**Steps to reproduce**
1. Have two companies, COM and BIR.
2. In a COM chat or comment, render the Markdown
`[BIR-1](/BIR/issues/BIR-1)`.
3. Inspect the link. Its `href` is `/COM/issues/BIR-1`.
**Paperclip version or commit**
master at f1aef0cb58.
## What Changed
- `ui/src/lib/issue-reference.ts`: a new `issueHref` builds the internal
link. It keeps the company prefix of an explicit `/PREFIX/issues/...`
path. When the path has no prefix, it uses the identifier's prefix if
that prefix is in the known company prefixes. Otherwise the link stays
`/issues/<id>` and resolves in the active company, as before.
- `ui/src/components/MarkdownBody.tsx`: passes the known company
prefixes to the explicit-link path too (the auto-link path already had
them).
- Tests: a red/green unit test with the recorded shape in
`issue-reference.test.ts`, and a rendered test in
`MarkdownBody.test.tsx` (COM and BIR known; explicit, bare and
unprefixed BIR links all render `/BIR/issues/BIR-1`). Existing
expectations that asserted the stripped `/issues/<id>` form now assert
the company-prefixed form.
## Verification
- `cd ui && npx vitest run src/components/MarkdownBody.test.tsx
src/lib/issue-reference.test.ts src/lib/company-routes.test.ts`: 105
tests pass.
- Red/green: with `issue-reference.ts` and `MarkdownBody.tsx` from
`origin/master`, the new tests fail (`/issues/BIR-1` instead of
`/BIR/issues/BIR-1`). With the change, they pass.
- `pnpm check:token-gates` is clean. `tsc -p ui/tsconfig.json` reports
only existing errors in
`ui/storybook/support/feature-map/FeatureOverview.tsx`, which this
change does not touch.
- A paid chat-eval run with this change is linked in a comment below.
## Risks
- Same-company links now carry the explicit prefix (`/COM/issues/COM-1`
instead of `/issues/COM-1` resolved to the same place). The route is the
same.
- An explicit link with a bare identifier as its target (`[x](JIRA-2)`)
is now gated by known company prefixes like auto-linked text. Such a
link to a non-Paperclip key stays an ordinary link.
- Low risk otherwise: no API, data or saved state changes.
## Model Used
- Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, with tool use and code
execution in Claude Code.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1982 lines
87 KiB
TypeScript
1982 lines
87 KiB
TypeScript
// @vitest-environment jsdom
|
||
|
||
import { act as reactAct, type ComponentProps, type ReactNode } from "react";
|
||
import { flushSync } from "react-dom";
|
||
import { createRoot, type Root } from "react-dom/client";
|
||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
||
import type { Agent } from "@paperclipai/shared";
|
||
import { ApiError } from "../api/client";
|
||
import { IssueThreadInteractionCard } from "./IssueThreadInteractionCard";
|
||
import { ThemeProvider } from "../context/ThemeContext";
|
||
import { TooltipProvider } from "./ui/tooltip";
|
||
import {
|
||
pendingAskUserQuestionsInteraction,
|
||
pendingAskUserQuestionsWithFreeTextOption,
|
||
commentExpiredAskUserQuestionsInteraction,
|
||
commentExpiredRequestConfirmationInteraction,
|
||
declinedToolActionInteraction,
|
||
disabledDeclineReasonRequestConfirmationInteraction,
|
||
executedToolActionInteraction,
|
||
expiredToolActionInteraction,
|
||
failedRequestConfirmationInteraction,
|
||
failedToolActionInteraction,
|
||
pendingRequestConfirmationInteraction,
|
||
pendingRequestCheckboxConfirmationInteraction,
|
||
pendingToolActionDestructiveInteraction,
|
||
pendingToolActionWriteInteraction,
|
||
issueThreadInteractionFixtureMeta,
|
||
pendingSecretProposalInteraction,
|
||
pendingConnectionAuthorizationInteraction,
|
||
resolvedConnectionAuthorizationInteraction,
|
||
executedSecretProposalInteraction,
|
||
failedSecretProposalInteraction,
|
||
rejectedSecretProposalInteraction,
|
||
expiredSecretProposalInteraction,
|
||
planApprovalResumeFailedRequestConfirmationInteraction,
|
||
pendingRequestItemVerdictsInteraction,
|
||
pendingSuggestedTasksInteraction,
|
||
runningToolActionInteraction,
|
||
completeRequestItemVerdictsInteraction,
|
||
supersededRequestItemVerdictsInteraction,
|
||
staleTargetRequestConfirmationInteraction,
|
||
rejectedSuggestedTasksInteraction,
|
||
agentAddressedRequestConfirmationInteraction,
|
||
agentResolvedRequestConfirmationInteraction,
|
||
withdrawnRequestConfirmationInteraction,
|
||
issueClosedRequestConfirmationInteraction,
|
||
notCreatorRequestConfirmationInteraction,
|
||
humanOnlyRequestConfirmationInteraction,
|
||
companyCappedRequestConfirmationInteraction,
|
||
legacyRestrictedRequestConfirmationInteraction,
|
||
pendingConnectionIntentInteraction,
|
||
retryConnectionIntentInteraction,
|
||
connectedConnectionIntentInteraction,
|
||
} from "../fixtures/issueThreadInteractionFixtures";
|
||
|
||
let root: Root | null = null;
|
||
let container: HTMLDivElement | null = null;
|
||
|
||
const connectionIntentsApiMocks = vi.hoisted(() => ({
|
||
setupOptions: vi.fn(),
|
||
complete: vi.fn(),
|
||
decline: vi.fn(),
|
||
}));
|
||
|
||
const routerMocks = vi.hoisted(() => ({
|
||
searchParams: new URLSearchParams(),
|
||
readSearchParams: vi.fn(),
|
||
setSearchParams: vi.fn(),
|
||
navigate: vi.fn(),
|
||
setBreadcrumbs: vi.fn(),
|
||
pushToast: vi.fn(),
|
||
}));
|
||
|
||
(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
||
|
||
async function act(callback: () => void | Promise<void>) {
|
||
if (typeof reactAct === "function") {
|
||
await reactAct(callback);
|
||
return;
|
||
}
|
||
|
||
let result: void | Promise<void> = undefined;
|
||
flushSync(() => {
|
||
result = callback();
|
||
});
|
||
await result;
|
||
await new Promise((resolve) => setTimeout(resolve, 0));
|
||
}
|
||
|
||
vi.mock("@/lib/router", () => ({
|
||
useParams: () => ({}),
|
||
useSearchParams: () => {
|
||
routerMocks.readSearchParams();
|
||
return [routerMocks.searchParams, routerMocks.setSearchParams];
|
||
},
|
||
useNavigate: () => routerMocks.navigate,
|
||
Link: ({ to, children, className }: { to: string; children: ReactNode; className?: string }) => (
|
||
<a href={to} className={className}>{children}</a>
|
||
),
|
||
}));
|
||
|
||
vi.mock("@/context/CompanyContext", async (importOriginal) => ({
|
||
...await importOriginal<typeof import("../context/CompanyContext")>(),
|
||
useCompany: () => ({ selectedCompanyId: issueThreadInteractionFixtureMeta.companyId, selectedCompany: null }),
|
||
}));
|
||
vi.mock("@/context/BreadcrumbContext", async (importOriginal) => ({
|
||
...await importOriginal<typeof import("../context/BreadcrumbContext")>(),
|
||
useBreadcrumbs: () => ({ setBreadcrumbs: routerMocks.setBreadcrumbs }),
|
||
}));
|
||
vi.mock("@/context/ToastContext", async (importOriginal) => ({
|
||
...await importOriginal<typeof import("../context/ToastContext")>(),
|
||
useToast: () => ({ pushToast: routerMocks.pushToast }),
|
||
}));
|
||
|
||
vi.mock("@/api/connection-intents", () => ({ connectionIntentsApi: connectionIntentsApiMocks }));
|
||
|
||
vi.mock("./task-chat/TaskChatRichInput", () => ({
|
||
TaskChatRichInput: ({ value, onChange }: { value: string; onChange: (value: string) => void }) => (
|
||
<textarea aria-label="Canonical answer" value={value} onChange={(event) => onChange(event.target.value)} />
|
||
),
|
||
}));
|
||
|
||
function renderCard(
|
||
props: Partial<ComponentProps<typeof IssueThreadInteractionCard>> = {},
|
||
) {
|
||
container = document.createElement("div");
|
||
document.body.appendChild(container);
|
||
root = createRoot(container);
|
||
const queryClient = new QueryClient({
|
||
defaultOptions: { queries: { retry: false }, mutations: { retry: false } },
|
||
});
|
||
|
||
act(() => {
|
||
root?.render(
|
||
<QueryClientProvider client={queryClient}>
|
||
<TooltipProvider>
|
||
<ThemeProvider>
|
||
<IssueThreadInteractionCard
|
||
interaction={pendingAskUserQuestionsInteraction}
|
||
{...props}
|
||
/>
|
||
</ThemeProvider>
|
||
</TooltipProvider>
|
||
</QueryClientProvider>,
|
||
);
|
||
});
|
||
|
||
return container;
|
||
}
|
||
|
||
afterEach(() => {
|
||
if (root) {
|
||
act(() => root?.unmount());
|
||
}
|
||
container?.remove();
|
||
root = null;
|
||
container = null;
|
||
localStorage.clear();
|
||
routerMocks.readSearchParams.mockClear();
|
||
});
|
||
|
||
describe("IssueThreadInteractionCard", () => {
|
||
const canonicalDraftInteraction = {
|
||
...pendingAskUserQuestionsInteraction,
|
||
payload: {
|
||
...pendingAskUserQuestionsInteraction.payload,
|
||
questions: [{ id: "draft", prompt: "Edit draft", required: true, selectionMode: "single" as const, options: [{ id: "draft_text", label: "Write an answer", freeText: true }], allowOther: false }],
|
||
questionSet: {
|
||
schema: "paperclip.question_set.v1" as const,
|
||
questions: [{ id: "draft", prompt: "Edit draft", required: true, answerMode: "text" as const, initialText: " Provider draft\n漢字\\n " }],
|
||
},
|
||
},
|
||
};
|
||
|
||
async function editCanonical(host: HTMLDivElement, value: string) {
|
||
const textarea = host.querySelector<HTMLTextAreaElement>("textarea")!;
|
||
await act(() => {
|
||
Object.getOwnPropertyDescriptor(HTMLTextAreaElement.prototype, "value")!.set!.call(textarea, value);
|
||
textarea.dispatchEvent(new Event("input", { bubbles: true }));
|
||
});
|
||
}
|
||
|
||
it("presents canonical drafts and submits only explicitly edited exact text", async () => {
|
||
const submit = vi.fn();
|
||
const host = renderCard({ interaction: canonicalDraftInteraction, onSubmitInteractionAnswers: submit });
|
||
expect(host.querySelector<HTMLTextAreaElement>("textarea")!.value).toBe(" Provider draft\n漢字\\n ");
|
||
expect(submit).not.toHaveBeenCalled();
|
||
const edited = "\n Operator edit 漢字\\n\n ";
|
||
await editCanonical(host, edited);
|
||
await act(() => Array.from(host.querySelectorAll("button")).find((button) => button.textContent === "Submit answers")!.click());
|
||
expect(submit).toHaveBeenCalledExactlyOnceWith(canonicalDraftInteraction, [{ questionId: "draft", optionIds: [], otherText: edited }]);
|
||
});
|
||
|
||
it("keeps an explicit cleared canonical draft after reopening and requires an answer", async () => {
|
||
const submit = vi.fn();
|
||
const host = renderCard({ interaction: canonicalDraftInteraction, onSubmitInteractionAnswers: submit });
|
||
await editCanonical(host, "");
|
||
await act(() => root!.unmount());
|
||
host.remove();
|
||
const reopened = renderCard({ interaction: canonicalDraftInteraction, onSubmitInteractionAnswers: submit });
|
||
expect(reopened.querySelector<HTMLTextAreaElement>("textarea")!.value).toBe("");
|
||
expect(reopened.querySelector('[role="alert"]')).toBeNull();
|
||
await act(() => Array.from(reopened.querySelectorAll("button")).find((button) => button.textContent === "Submit answers")!.click());
|
||
expect(reopened.textContent).toContain("This question is required.");
|
||
expect(submit).not.toHaveBeenCalled();
|
||
});
|
||
|
||
it("opens the shared connection setup for the addressed user", async () => {
|
||
connectionIntentsApiMocks.setupOptions.mockResolvedValue({ existingConnections: [] });
|
||
const host = renderCard({
|
||
interaction: pendingConnectionIntentInteraction,
|
||
currentUserId: issueThreadInteractionFixtureMeta.currentUserId,
|
||
});
|
||
|
||
expect(host.querySelector('[data-testid="connection-intent-actions"]')).toBeTruthy();
|
||
expect(host.textContent).toContain("Connect");
|
||
expect(host.textContent).toContain("Not now");
|
||
const labels = Array.from(host.querySelectorAll("button")).map((button) => button.textContent?.trim());
|
||
expect(labels).toContain("Connect");
|
||
expect(labels).toContain("Not now");
|
||
expect(host.textContent).toContain("New connections default to all agents");
|
||
expect(host.textContent).toContain("Reusing an account adds access for this agent");
|
||
const loadButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.trim() === "Connect",
|
||
);
|
||
await act(async () => {
|
||
loadButton?.click();
|
||
await Promise.resolve();
|
||
});
|
||
await vi.waitFor(() =>
|
||
expect(connectionIntentsApiMocks.setupOptions).toHaveBeenCalledWith(
|
||
"interaction-connection-intent-default",
|
||
),
|
||
);
|
||
// setupOptions being called precedes React Query publishing its result.
|
||
// Wait for the real setup flow, not just the dialog's loading shell.
|
||
await vi.waitFor(async () => {
|
||
await act(async () => { await new Promise((resolve) => setTimeout(resolve, 0)); });
|
||
const setupDialog = document.body.querySelector('[role="dialog"]');
|
||
expect(setupDialog).toBeTruthy();
|
||
expect(setupDialog?.textContent).not.toContain("Loading connection options");
|
||
expect(routerMocks.readSearchParams).toHaveBeenCalled();
|
||
});
|
||
const dialog = document.body.querySelector('[role="dialog"]');
|
||
expect(dialog).toBeTruthy();
|
||
expect(dialog?.textContent).toContain("Connect Notion");
|
||
expect(dialog?.textContent).toContain("Complete connection setup without leaving this task.");
|
||
});
|
||
|
||
;
|
||
|
||
it("exposes pending question options as selectable radio and checkbox controls", () => {
|
||
const host = renderCard({
|
||
interaction: pendingAskUserQuestionsInteraction,
|
||
onSubmitInteractionAnswers: vi.fn(),
|
||
});
|
||
|
||
expect(host.childElementCount).toBeGreaterThan(0);
|
||
|
||
const singleGroup = host.querySelector('[role="radiogroup"]');
|
||
expect(singleGroup?.getAttribute("aria-labelledby")).toBe(
|
||
"interaction-questions-default-collapse-depth-prompt",
|
||
);
|
||
|
||
const radios = [...host.querySelectorAll('[role="radio"]')];
|
||
expect(radios).toHaveLength(3);
|
||
expect(radios[0]?.getAttribute("aria-checked")).toBe("false");
|
||
|
||
act(() => {
|
||
(radios[0] as HTMLButtonElement).click();
|
||
});
|
||
|
||
expect(radios[0]?.getAttribute("aria-checked")).toBe("true");
|
||
expect(radios[1]?.getAttribute("aria-checked")).toBe("false");
|
||
|
||
const multiGroup = host.querySelector('[role="group"]');
|
||
expect(multiGroup?.getAttribute("aria-labelledby")).toBe(
|
||
"interaction-questions-default-post-submit-summary-prompt",
|
||
);
|
||
expect(host.querySelectorAll('[role="checkbox"]')).toHaveLength(4);
|
||
|
||
const otherOption = radios.find((button) => button.textContent === "Other");
|
||
expect(otherOption?.closest('[role="radiogroup"]')).toBe(singleGroup);
|
||
});
|
||
|
||
it("renders block Markdown in compact question labels without paragraph nesting", () => {
|
||
const question = { ...pendingAskUserQuestionsInteraction.payload.questions[0]!, prompt: "**Which option?**\n\n- First consideration\n- Second consideration" };
|
||
const interaction = { ...pendingAskUserQuestionsInteraction, payload: { ...pendingAskUserQuestionsInteraction.payload, questions: [question] } };
|
||
const host = renderCard({ presentationVariant: "coordinator-decision", interaction });
|
||
const group = host.querySelector('[role="radiogroup"]')!;
|
||
const label = host.querySelector(`#${group.getAttribute("aria-labelledby")}`)!;
|
||
expect(label.querySelector("strong")?.textContent).toBe("Which option?");
|
||
expect(label.querySelectorAll("li")).toHaveLength(2);
|
||
expect(label.querySelector("div")?.closest("p")).toBeNull();
|
||
});
|
||
|
||
it.each(["default", "coordinator-decision"] as const)("treats Other as a radio choice that reveals its text field (%s)", async (presentationVariant) => {
|
||
const question = { ...pendingAskUserQuestionsInteraction.payload.questions[0]!, required: true };
|
||
const interaction = { ...pendingAskUserQuestionsInteraction, payload: { ...pendingAskUserQuestionsInteraction.payload, questions: [question] } };
|
||
const onSubmitInteractionAnswers = vi.fn(async () => undefined);
|
||
const host = renderCard({ presentationVariant, interaction, onSubmitInteractionAnswers });
|
||
const group = host.querySelector('[role="radiogroup"]')!;
|
||
const radios = [...group.querySelectorAll<HTMLButtonElement>('[role="radio"]')];
|
||
const other = radios.find(button => button.textContent === "Other")!;
|
||
expect(other).toBeTruthy();
|
||
expect(host.querySelector("textarea")).toBeNull();
|
||
|
||
await act(async () => radios[0]!.click());
|
||
await act(async () => other.click());
|
||
expect(other.getAttribute("aria-checked")).toBe("true");
|
||
expect(radios[0]!.getAttribute("aria-checked")).toBe("false");
|
||
const input = host.querySelector("textarea")!;
|
||
const submit = [...host.querySelectorAll("button")].find(button => button.textContent?.includes("Send answers"))!;
|
||
expect(input).not.toBeNull();
|
||
expect(submit.disabled).toBe(true);
|
||
await act(async () => {
|
||
Object.getOwnPropertyDescriptor(HTMLTextAreaElement.prototype, "value")!.set!.call(input, "My alternative");
|
||
input.dispatchEvent(new Event("input", { bubbles: true }));
|
||
});
|
||
expect(submit.disabled).toBe(false);
|
||
await act(async () => other.click());
|
||
expect(other.getAttribute("aria-checked")).toBe("true");
|
||
expect(host.querySelector("textarea")?.value).toBe("My alternative");
|
||
await act(async () => radios[0]!.click());
|
||
expect(other.getAttribute("aria-checked")).toBe("false");
|
||
expect(host.querySelector("textarea")).toBeNull();
|
||
await act(async () => submit.click());
|
||
expect(onSubmitInteractionAnswers).toHaveBeenCalledWith(interaction, [{ questionId: question.id, optionIds: [question.options[0]!.id] }]);
|
||
});
|
||
|
||
it("keeps Coordinator decision questions focused while preserving answers and accessible requirements", async () => {
|
||
const onSubmitInteractionAnswers = vi.fn(async () => undefined);
|
||
const host = renderCard({
|
||
presentationVariant: "coordinator-decision",
|
||
interaction: pendingAskUserQuestionsInteraction,
|
||
onSubmitInteractionAnswers,
|
||
});
|
||
expect(host.querySelector('[data-presentation="coordinator-decision"]')?.classList.contains("border")).toBe(false);
|
||
expect(host.querySelector('[data-testid="interaction-status-badge"]')).toBeNull();
|
||
expect(host.textContent).not.toContain("Ask user questions");
|
||
expect(host.textContent).not.toContain("Question 1");
|
||
expect(host.textContent).not.toContain("proposed by");
|
||
const group = host.querySelector('[role="radiogroup"]');
|
||
expect(group?.getAttribute("aria-required")).toBe("true");
|
||
expect(group?.getAttribute("aria-describedby")).toBe("interaction-questions-default-collapse-depth-requirements");
|
||
await act(() => {
|
||
(host.querySelector('[role="radio"]') as HTMLButtonElement).click();
|
||
(host.querySelector('[role="checkbox"]') as HTMLButtonElement).click();
|
||
});
|
||
const submit = [...host.querySelectorAll("button")].find(button => button.textContent === "Send answers")!;
|
||
await act(() => submit.click());
|
||
expect(onSubmitInteractionAnswers).toHaveBeenCalledWith(pendingAskUserQuestionsInteraction, [
|
||
{ questionId: "collapse-depth", optionIds: ["visible-root"] },
|
||
{ questionId: "post-submit-summary", optionIds: ["answers-inline"] },
|
||
]);
|
||
});
|
||
|
||
it("shows a Coordinator card's responder clause when it is addressed elsewhere", () => {
|
||
const interaction = { ...pendingRequestConfirmationInteraction, addresseeAgentId: "agent-nap" };
|
||
const host = renderCard({ presentationVariant: "coordinator-decision", interaction });
|
||
expect(host.querySelector('[data-testid="interaction-audience"]')?.parentElement?.className ?? "").not.toContain("sr-only");
|
||
});
|
||
|
||
it("keeps that clause for screen readers when the card's audience line states it (PAP-767)", () => {
|
||
const interaction = { ...pendingRequestConfirmationInteraction, addresseeAgentId: "agent-nap" };
|
||
const host = renderCard({ presentationVariant: "coordinator-decision", interaction, audienceStated: true });
|
||
expect(host.querySelector('[data-testid="interaction-audience"]')?.parentElement?.className).toContain("sr-only");
|
||
});
|
||
|
||
it("puts a Coordinator confirmation's target and details in its context panel, approve on the right", async () => {
|
||
const onAcceptInteraction = vi.fn(async () => undefined);
|
||
const interaction = { ...pendingRequestConfirmationInteraction, title: "Repeated approval context", summary: "Repeated approval context", payload: { ...pendingRequestConfirmationInteraction.payload, prompt: "Repeated approval context", detailsMarkdown: "Revision proof: sha256-test-proof" } };
|
||
const host = renderCard({ presentationVariant: "coordinator-decision", interaction, onAcceptInteraction });
|
||
expect(host.textContent?.split("Repeated approval context")).toHaveLength(2);
|
||
expect(host.querySelector('[data-testid="interaction-status-badge"]')).toBeNull();
|
||
const panel = host.querySelector("[data-needs-you-panel]")!;
|
||
const documentLink = panel.querySelector('a[href*="#document-"]');
|
||
expect(documentLink?.getAttribute("href")).toContain("revision=11111111-1111-4111-8111-111111111111");
|
||
expect(documentLink?.getAttribute("href")).toContain(`interaction=${interaction.id}`);
|
||
expect(panel.textContent).toContain("Revision proof: sha256-test-proof");
|
||
expect(host.querySelector("details")).toBeNull();
|
||
expect(host.querySelector("[data-decision-prompt]")?.closest("[data-needs-you-panel]")).toBeNull();
|
||
const actions = [...host.querySelectorAll('[data-testid="confirmation-actions"] button')];
|
||
const approve = actions.at(-1)!;
|
||
expect(approve.textContent).toContain(interaction.payload.acceptLabel ?? "Approve plan");
|
||
await act(() => (approve as HTMLButtonElement).click());
|
||
expect(onAcceptInteraction).toHaveBeenCalledWith(interaction);
|
||
});
|
||
|
||
it("renders the Needs You artifact row first in a compact confirmation's panel", () => {
|
||
const host = renderCard({ presentationVariant: "coordinator-decision", interaction: pendingRequestConfirmationInteraction, artifactRow: <div data-testid="artifact-row">Plan</div> });
|
||
const panel = host.querySelector("[data-needs-you-panel]")!;
|
||
expect(panel.firstElementChild?.getAttribute("data-testid")).toBe("artifact-row");
|
||
expect(panel.querySelector('a[href*="#document-"]')).toBeNull();
|
||
});
|
||
|
||
it("retains inline confirmation details in the Classic presentation", () => {
|
||
const host = renderCard({ interaction: {
|
||
...pendingRequestConfirmationInteraction,
|
||
payload: { ...pendingRequestConfirmationInteraction.payload, detailsMarkdown: "Original review context" },
|
||
} });
|
||
expect(host.textContent).toContain("Original review context");
|
||
expect(host.querySelector("details")).toBeNull();
|
||
});
|
||
|
||
it("submits written Other answers for pending questions", async () => {
|
||
const onSubmitInteractionAnswers = vi.fn(async () => undefined);
|
||
const host = renderCard({
|
||
interaction: pendingAskUserQuestionsInteraction,
|
||
onSubmitInteractionAnswers,
|
||
});
|
||
|
||
const otherButtons = Array.from(host.querySelectorAll("button")).filter((button) =>
|
||
button.textContent?.includes("Other"),
|
||
);
|
||
expect(otherButtons.length).toBeGreaterThan(0);
|
||
|
||
await act(async () => {
|
||
otherButtons[0]?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
const textarea = host.querySelector("textarea") as HTMLTextAreaElement | null;
|
||
expect(textarea).toBeTruthy();
|
||
|
||
await act(async () => {
|
||
const valueSetter = Object.getOwnPropertyDescriptor(
|
||
HTMLTextAreaElement.prototype,
|
||
"value",
|
||
)?.set;
|
||
valueSetter?.call(textarea, "Keep only the root item open");
|
||
textarea!.dispatchEvent(new Event("input", { bubbles: true }));
|
||
});
|
||
|
||
const summaryCheckbox = Array.from(host.querySelectorAll('[role="checkbox"]')).find((button) =>
|
||
button.textContent?.includes("Inline answer pills"),
|
||
);
|
||
await act(async () => {
|
||
summaryCheckbox?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
const submitButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Send answers"),
|
||
);
|
||
await act(async () => {
|
||
submitButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
expect(onSubmitInteractionAnswers).toHaveBeenCalledWith(
|
||
expect.objectContaining({ kind: "ask_user_questions" }),
|
||
[
|
||
{
|
||
questionId: "collapse-depth",
|
||
optionIds: [],
|
||
otherText: "Keep only the root item open",
|
||
},
|
||
{
|
||
questionId: "post-submit-summary",
|
||
optionIds: ["answers-inline"],
|
||
},
|
||
],
|
||
);
|
||
});
|
||
|
||
it("reveals an inline field when a free-text option is selected and hides the standalone Other link", async () => {
|
||
const onSubmitInteractionAnswers = vi.fn(async () => undefined);
|
||
const host = renderCard({
|
||
interaction: pendingAskUserQuestionsWithFreeTextOption,
|
||
onSubmitInteractionAnswers,
|
||
});
|
||
|
||
// A first-class free-text option suppresses the built-in "Other" link.
|
||
const otherLink = Array.from(host.querySelectorAll("button")).find(
|
||
(button) => button.textContent === "Other",
|
||
);
|
||
expect(otherLink).toBeUndefined();
|
||
|
||
// No text field until the free-text option is selected.
|
||
expect(host.querySelector("textarea")).toBeNull();
|
||
|
||
const describeOption = Array.from(host.querySelectorAll('[role="radio"]')).find(
|
||
(button) => button.textContent?.includes("I'll describe it"),
|
||
) as HTMLButtonElement | undefined;
|
||
expect(describeOption).toBeTruthy();
|
||
|
||
await act(async () => {
|
||
describeOption?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
expect(describeOption?.getAttribute("aria-checked")).toBe("true");
|
||
const textarea = host.querySelector("textarea") as HTMLTextAreaElement | null;
|
||
expect(textarea).toBeTruthy();
|
||
|
||
await act(async () => {
|
||
const valueSetter = Object.getOwnPropertyDescriptor(
|
||
HTMLTextAreaElement.prototype,
|
||
"value",
|
||
)?.set;
|
||
valueSetter?.call(textarea, "Call it Threads");
|
||
textarea!.dispatchEvent(new Event("input", { bubbles: true }));
|
||
});
|
||
|
||
const submitButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Send answers"),
|
||
);
|
||
await act(async () => {
|
||
submitButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
expect(onSubmitInteractionAnswers).toHaveBeenCalledWith(
|
||
expect.objectContaining({ kind: "ask_user_questions" }),
|
||
[
|
||
{
|
||
questionId: "surface-name",
|
||
optionIds: [],
|
||
otherText: "Call it Threads",
|
||
},
|
||
],
|
||
);
|
||
});
|
||
|
||
it("renders nothing for a degenerate ask_user_questions card", () => {
|
||
// A truly unanswerable question: a prompt with no options and no free-text
|
||
// field, so there is nothing for the user to select or type. Hiding it
|
||
// strands nothing.
|
||
const degenerate = {
|
||
...pendingAskUserQuestionsInteraction,
|
||
id: "interaction-questions-degenerate",
|
||
payload: {
|
||
version: 1 as const,
|
||
title: "Placeholder",
|
||
questions: [
|
||
{
|
||
id: "q1",
|
||
prompt: "Anything?",
|
||
selectionMode: "single" as const,
|
||
options: [],
|
||
},
|
||
],
|
||
},
|
||
};
|
||
|
||
const host = renderCard({
|
||
interaction: degenerate,
|
||
onSubmitInteractionAnswers: vi.fn(),
|
||
});
|
||
|
||
// No card wrapper, no title, no controls — the component returns null.
|
||
expect(host.childElementCount).toBe(0);
|
||
expect(host.textContent).toBe("");
|
||
});
|
||
|
||
;
|
||
|
||
it("keeps a closed native select set closed while preserving direct-question defaults", () => {
|
||
const closed = {
|
||
...pendingAskUserQuestionsInteraction,
|
||
payload: {
|
||
...pendingAskUserQuestionsInteraction.payload,
|
||
questions: pendingAskUserQuestionsInteraction.payload.questions.map((question) => ({
|
||
...question,
|
||
allowOther: false,
|
||
})),
|
||
},
|
||
};
|
||
const host = renderCard({ interaction: closed, onSubmitInteractionAnswers: vi.fn() });
|
||
expect(Array.from(host.querySelectorAll("button")).some((button) => button.textContent === "Other"))
|
||
.toBe(false);
|
||
|
||
act(() => root?.unmount());
|
||
host.remove();
|
||
root = null;
|
||
const legacy = renderCard({
|
||
interaction: pendingAskUserQuestionsInteraction,
|
||
onSubmitInteractionAnswers: vi.fn(),
|
||
});
|
||
expect(Array.from(legacy.querySelectorAll("button")).some((button) => button.textContent === "Other"))
|
||
.toBe(true);
|
||
});
|
||
|
||
it("only shows question cancellation when a cancel handler is wired", () => {
|
||
const withoutHandler = renderCard({
|
||
interaction: pendingAskUserQuestionsInteraction,
|
||
onSubmitInteractionAnswers: vi.fn(),
|
||
});
|
||
expect(withoutHandler.textContent).not.toContain("Cancel question");
|
||
|
||
act(() => root?.unmount());
|
||
withoutHandler.remove();
|
||
root = null;
|
||
|
||
const withHandler = renderCard({
|
||
interaction: pendingAskUserQuestionsInteraction,
|
||
onCancelInteraction: vi.fn(),
|
||
onSubmitInteractionAnswers: vi.fn(),
|
||
});
|
||
expect(withHandler.textContent).toContain("Cancel question");
|
||
});
|
||
|
||
it("renders expired question interactions as resolved and non-actionable", () => {
|
||
const host = renderCard({
|
||
interaction: commentExpiredAskUserQuestionsInteraction,
|
||
onSubmitInteractionAnswers: vi.fn(),
|
||
onCancelInteraction: vi.fn(),
|
||
});
|
||
|
||
expect(host.textContent).toContain("Questions expired by comment");
|
||
expect(host.textContent).toContain("A later board/user comment superseded this question request.");
|
||
expect(host.textContent).not.toContain("Send answers");
|
||
expect(host.textContent).not.toContain("Cancel question");
|
||
|
||
const jumpLink = Array.from(host.querySelectorAll("a")).find((link) =>
|
||
link.textContent?.includes("Jump to comment"),
|
||
);
|
||
expect(jumpLink?.getAttribute("href")).toBe(
|
||
"#comment-22222222-2222-4222-8222-222222222222",
|
||
);
|
||
});
|
||
|
||
it("uses singular copy for expired single-question interactions", () => {
|
||
const [question] = commentExpiredAskUserQuestionsInteraction.payload.questions;
|
||
const host = renderCard({
|
||
interaction: {
|
||
...commentExpiredAskUserQuestionsInteraction,
|
||
payload: {
|
||
...commentExpiredAskUserQuestionsInteraction.payload,
|
||
questions: [question],
|
||
},
|
||
},
|
||
});
|
||
|
||
expect(host.textContent).toContain("Question expired by comment");
|
||
expect(host.textContent).not.toContain("Questions expired by comment");
|
||
});
|
||
|
||
it("renders withdrawn confirmations with the withdraw reason", () => {
|
||
const host = renderCard({
|
||
interaction: {
|
||
...pendingRequestConfirmationInteraction,
|
||
status: "cancelled",
|
||
result: { version: 1, outcome: "withdrawn", reason: "Superseded by the hotfix plan." },
|
||
},
|
||
onAcceptInteraction: vi.fn(),
|
||
onRejectInteraction: vi.fn(),
|
||
});
|
||
|
||
expect(host.textContent).toContain("Withdrawn");
|
||
expect(host.textContent).toContain("Superseded by the hotfix plan.");
|
||
expect(host.textContent).not.toContain("Decline");
|
||
});
|
||
|
||
it("renders confirmations expired by issue closure with dedicated copy", () => {
|
||
const host = renderCard({
|
||
interaction: {
|
||
...pendingRequestConfirmationInteraction,
|
||
status: "expired",
|
||
result: { version: 1, outcome: "issue_closed", reason: null },
|
||
},
|
||
});
|
||
|
||
expect(host.textContent).toContain("Expired · issue closed");
|
||
expect(host.textContent).toContain("This confirmation expired automatically when the issue reached a terminal state.");
|
||
expect(host.textContent).not.toContain("Expired by target change");
|
||
});
|
||
|
||
it("renders withdrawn question interactions with the withdraw reason", () => {
|
||
const host = renderCard({
|
||
interaction: {
|
||
...pendingAskUserQuestionsInteraction,
|
||
status: "cancelled",
|
||
result: {
|
||
version: 1,
|
||
outcome: "withdrawn",
|
||
reason: "Scope was decided on the parent issue.",
|
||
answers: [],
|
||
summaryMarkdown: null,
|
||
},
|
||
},
|
||
});
|
||
|
||
expect(host.textContent).toContain("Questions withdrawn");
|
||
expect(host.textContent).toContain("Scope was decided on the parent issue.");
|
||
expect(host.textContent).not.toContain("Question cancelled");
|
||
});
|
||
|
||
it("renders question interactions expired by issue closure with dedicated copy", () => {
|
||
const host = renderCard({
|
||
interaction: {
|
||
...pendingAskUserQuestionsInteraction,
|
||
status: "expired",
|
||
result: {
|
||
version: 1,
|
||
outcome: "issue_closed",
|
||
reason: null,
|
||
answers: [],
|
||
summaryMarkdown: null,
|
||
},
|
||
},
|
||
});
|
||
|
||
expect(host.textContent).toContain("Questions expired when the issue closed");
|
||
expect(host.textContent).toContain("This question request expired automatically when the issue reached a terminal state.");
|
||
expect(host.textContent).not.toContain("expired by comment");
|
||
});
|
||
|
||
it("makes child tasks explicit in suggested task trees", () => {
|
||
const host = renderCard({
|
||
interaction: pendingSuggestedTasksInteraction,
|
||
});
|
||
|
||
expect(host.textContent).toContain("Child task");
|
||
});
|
||
|
||
it("shows an explicit placeholder when a rejected interaction has no reason", () => {
|
||
const host = renderCard({
|
||
interaction: {
|
||
...rejectedSuggestedTasksInteraction,
|
||
result: { version: 1 },
|
||
},
|
||
});
|
||
|
||
expect(host.textContent).toContain("No reason provided.");
|
||
});
|
||
|
||
it.each([
|
||
["confirmation", "default"],
|
||
["confirmation", "coordinator-decision"],
|
||
["checkbox", "default"],
|
||
["checkbox", "coordinator-decision"],
|
||
] as const)("renders Markdown in %s prompts in the %s view", (kind, presentationVariant) => {
|
||
const interaction = structuredClone(kind === "confirmation"
|
||
? pendingRequestConfirmationInteraction
|
||
: pendingRequestCheckboxConfirmationInteraction);
|
||
interaction.payload.prompt = "Review the [two screenshots](/PAP/issues/PAP-42#document-preview).\n\nSelect **Accept** to keep this design.\n\n- Check `preview.png`\n- Keep the layout\n\n\n\n```mermaid\nflowchart LR\n A --> B\n```";
|
||
const host = renderCard({ interaction, presentationVariant });
|
||
|
||
const link = host.querySelector('a[href="/PAP/issues/PAP-42#document-preview"]');
|
||
expect(link?.textContent).toBe("two screenshots");
|
||
const prompt = link?.closest(".paperclip-markdown");
|
||
expect(prompt?.querySelector("strong")?.textContent).toBe("Accept");
|
||
expect(prompt?.querySelector("code")?.textContent).toBe("preview.png");
|
||
expect(prompt?.querySelector("img")).toBeNull();
|
||
expect(prompt?.querySelectorAll("p")).toHaveLength(3);
|
||
expect(prompt?.querySelector("[data-markdown-image-reference]")?.textContent)
|
||
.toContain("Image: Review image (https://provider.invalid/review.png)");
|
||
expect(prompt?.querySelector("pre code.language-mermaid")?.textContent)
|
||
.toContain("flowchart LR");
|
||
expect(prompt?.querySelector(".paperclip-mermaid")).toBeNull();
|
||
expect(prompt?.querySelectorAll("li")).toHaveLength(2);
|
||
expect(prompt?.textContent).not.toContain("[two screenshots]");
|
||
});
|
||
|
||
it.each([
|
||
["checkbox", false, "coordinator-decision"], ["checkbox", true, "coordinator-decision"],
|
||
["items", false, "coordinator-decision"], ["items", true, "coordinator-decision"],
|
||
["items", false, "default"], ["items", true, "default"],
|
||
] as const)("renders %s Markdown prompts with a separate title %s in %s", (kind, separateTitle, presentationVariant) => {
|
||
const interaction = structuredClone(kind === "checkbox" ? pendingRequestCheckboxConfirmationInteraction : pendingRequestItemVerdictsInteraction);
|
||
interaction.title = separateTitle ? "Review this request" : null;
|
||
interaction.payload.prompt = "Review **carefully** and [read the plan](https://example.com/plan).\n\n- Verify the work\n- Check the result\n\n";
|
||
const host = renderCard({ interaction, presentationVariant });
|
||
const prompt = host.querySelector('a[href="https://example.com/plan"]')?.closest('.paperclip-markdown');
|
||
expect(prompt?.querySelector('strong')?.textContent).toBe('carefully');
|
||
expect(prompt?.querySelectorAll('li')).toHaveLength(2);
|
||
expect(prompt?.querySelector('[data-markdown-image-reference]')).not.toBeNull();
|
||
expect(prompt?.querySelector('img')).toBeNull();
|
||
expect(host.querySelector('h2 .paperclip-markdown')).toBeNull();
|
||
if (presentationVariant === "coordinator-decision") {
|
||
const heading = host.querySelector('[data-decision-prompt]');
|
||
expect(heading?.getAttribute('role')).toBe('heading');
|
||
expect(heading?.getAttribute('aria-level')).toBe('2');
|
||
}
|
||
});
|
||
|
||
it("requires a revision note when the request confirmation payload asks for one", async () => {
|
||
const onRejectInteraction = vi.fn(async () => undefined);
|
||
const host = renderCard({
|
||
interaction: pendingRequestConfirmationInteraction,
|
||
onRejectInteraction,
|
||
});
|
||
|
||
// rejectRequiresReason drops the bare Reject: the only send-back path is Revise…
|
||
expect(Array.from(host.querySelectorAll("button")).some((button) =>
|
||
button.textContent?.trim() === "Reject",
|
||
)).toBe(false);
|
||
const reviseButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Revise"),
|
||
);
|
||
expect(reviseButton).toBeTruthy();
|
||
|
||
await act(async () => {
|
||
reviseButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
const sendButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Send revision"),
|
||
);
|
||
expect(sendButton?.hasAttribute("disabled")).toBe(false);
|
||
|
||
await act(async () => {
|
||
sendButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
expect(host.textContent).toContain("Add a note describing the changes you want.");
|
||
expect(onRejectInteraction).not.toHaveBeenCalled();
|
||
|
||
const textarea = host.querySelector("textarea") as HTMLTextAreaElement | null;
|
||
expect(textarea).toBeTruthy();
|
||
expect(textarea?.getAttribute("aria-invalid")).toBe("true");
|
||
|
||
await act(async () => {
|
||
const valueSetter = Object.getOwnPropertyDescriptor(
|
||
HTMLTextAreaElement.prototype,
|
||
"value",
|
||
)?.set;
|
||
valueSetter?.call(textarea, "Needs a smaller phase split");
|
||
textarea!.dispatchEvent(new Event("input", { bubbles: true }));
|
||
});
|
||
const enabledSendButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Send revision"),
|
||
);
|
||
expect(enabledSendButton?.hasAttribute("disabled")).toBe(false);
|
||
await act(async () => {
|
||
enabledSendButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
expect(onRejectInteraction).toHaveBeenCalledWith(
|
||
expect.objectContaining({ kind: "request_confirmation" }),
|
||
"Needs a smaller phase split",
|
||
);
|
||
});
|
||
|
||
it.each([
|
||
pendingRequestConfirmationInteraction,
|
||
pendingRequestCheckboxConfirmationInteraction,
|
||
pendingSecretProposalInteraction,
|
||
])("keeps $kind approval disabled while preparing without disabling rejection", async (fixture) => {
|
||
const onAcceptInteraction = vi.fn();
|
||
const host = renderCard({
|
||
interaction: { ...fixture, acceptanceBlocker: "workspace_sync_pending" },
|
||
onAcceptInteraction,
|
||
onRejectInteraction: vi.fn(),
|
||
});
|
||
expect(host.querySelector('[role="status"]')?.textContent).toContain("Preparing approval…");
|
||
const approve = host.querySelector<HTMLButtonElement>('[data-testid="confirmation-actions"] button')!;
|
||
expect(approve.disabled).toBe(true);
|
||
await act(() => approve.click());
|
||
expect(onAcceptInteraction).not.toHaveBeenCalled();
|
||
const reject = [...host.querySelectorAll<HTMLButtonElement>("button")].find((button) => ["Reject", "Revise…", "Add reason…"].includes(button.textContent ?? ""));
|
||
expect(reject?.disabled).toBe(false);
|
||
});
|
||
|
||
it("invokes the confirm callback with pending request confirmations", async () => {
|
||
const onAcceptInteraction = vi.fn(async () => undefined);
|
||
const host = renderCard({
|
||
interaction: pendingRequestConfirmationInteraction,
|
||
onAcceptInteraction,
|
||
});
|
||
|
||
const confirmButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Approve plan"),
|
||
);
|
||
expect(confirmButton).toBeTruthy();
|
||
|
||
await act(async () => {
|
||
confirmButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
expect(onAcceptInteraction).toHaveBeenCalledWith(
|
||
expect.objectContaining({ kind: "request_confirmation" }),
|
||
);
|
||
});
|
||
|
||
// PAP-17287: a denial is persistent, so the inline error keeps the server's
|
||
// reason and names who can respond instead of offering a doomed retry.
|
||
it("keeps the server denial reason in an aria-live region when a confirmation is refused", async () => {
|
||
const onAcceptInteraction = vi.fn(async () => {
|
||
throw new ApiError("This issue-thread interaction is human-only", 403, {
|
||
error: "This issue-thread interaction is human-only",
|
||
code: "interaction_human_only",
|
||
});
|
||
});
|
||
const host = renderCard({
|
||
interaction: humanOnlyRequestConfirmationInteraction,
|
||
onAcceptInteraction,
|
||
});
|
||
|
||
const confirmButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Approve"),
|
||
);
|
||
await act(async () => {
|
||
confirmButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
const error = host.querySelector('[data-testid="interaction-action-error"]');
|
||
expect(error?.getAttribute("aria-live")).toBe("assertive");
|
||
expect(error?.textContent).toContain("This issue-thread interaction is human-only.");
|
||
expect(error?.textContent).toContain("Only the board can respond.");
|
||
expect(error?.textContent).not.toMatch(/try again/i);
|
||
// PAP-17289: one live region, not two. `role="alert"` is itself an
|
||
// assertive live region, so nesting it inside this wrapper can announce the
|
||
// same denial twice.
|
||
expect(error?.querySelector('[role="alert"]')).toBeNull();
|
||
expect(host.querySelectorAll('[aria-live], [role="alert"]').length).toBe(1);
|
||
});
|
||
|
||
it("still offers a retry when a resolution fails for a transient reason", async () => {
|
||
const onAcceptInteraction = vi.fn(async () => {
|
||
throw new ApiError("Request failed: 503", 503, null);
|
||
});
|
||
const host = renderCard({
|
||
interaction: pendingRequestConfirmationInteraction,
|
||
onAcceptInteraction,
|
||
});
|
||
|
||
await act(async () => {
|
||
Array.from(host.querySelectorAll("button"))
|
||
.find((button) => button.textContent?.includes("Approve plan"))
|
||
?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
expect(
|
||
host.querySelector('[data-testid="interaction-action-error"]')?.textContent,
|
||
).toBe("Paperclip is temporarily unavailable. Please try again in a moment.");
|
||
});
|
||
|
||
it("surfaces a denied suggested-task acceptance instead of failing silently", async () => {
|
||
const onAcceptInteraction = vi.fn(async () => {
|
||
throw new ApiError("Only the addressed agent or an authorized human may resolve this issue-thread interaction", 403, {
|
||
error: "Only the addressed agent or an authorized human may resolve this issue-thread interaction",
|
||
code: "interaction_addressee_mismatch",
|
||
});
|
||
});
|
||
const host = renderCard({
|
||
interaction: pendingSuggestedTasksInteraction,
|
||
onAcceptInteraction,
|
||
});
|
||
|
||
await act(async () => {
|
||
Array.from(host.querySelectorAll("button"))
|
||
.find((button) => button.textContent?.includes("Accept"))
|
||
?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
const error = host.querySelector('[data-testid="interaction-action-error"]');
|
||
expect(error?.getAttribute("aria-live")).toBe("assertive");
|
||
expect(error?.textContent).toContain("may resolve this issue-thread interaction.");
|
||
});
|
||
|
||
it("surfaces a denied answer submission on a questions card", async () => {
|
||
const onSubmitInteractionAnswers = vi.fn(async () => {
|
||
throw new ApiError("This issue-thread interaction is human-only", 403, {
|
||
error: "This issue-thread interaction is human-only",
|
||
code: "interaction_human_only",
|
||
});
|
||
});
|
||
const host = renderCard({
|
||
interaction: pendingAskUserQuestionsInteraction,
|
||
onSubmitInteractionAnswers,
|
||
});
|
||
|
||
// Answer every question so Submit is enabled, then submit.
|
||
for (const group of ['[role="radio"]', '[role="checkbox"]']) {
|
||
const option = host.querySelector(group);
|
||
await act(async () => {
|
||
(option as HTMLElement | null)?.click();
|
||
});
|
||
}
|
||
const submit = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Send answers"),
|
||
);
|
||
expect(submit?.hasAttribute("disabled")).toBe(false);
|
||
await act(async () => {
|
||
submit?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
expect(
|
||
host.querySelector('[data-testid="interaction-action-error"]')?.textContent,
|
||
).toContain("This issue-thread interaction is human-only.");
|
||
});
|
||
|
||
it("standardizes the bare-reject button to Reject even when the payload carries a legacy rejectLabel", () => {
|
||
const host = renderCard({
|
||
interaction: {
|
||
...pendingRequestConfirmationInteraction,
|
||
payload: {
|
||
...pendingRequestConfirmationInteraction.payload,
|
||
// Onboarding/plan-approval interactions are still seeded with the
|
||
// legacy "Request changes" reject label; it must not leak into the CTA.
|
||
rejectLabel: "Request changes",
|
||
rejectRequiresReason: false,
|
||
},
|
||
},
|
||
onAcceptInteraction: vi.fn(async () => undefined),
|
||
onRejectInteraction: vi.fn(async () => undefined),
|
||
});
|
||
|
||
const labels = Array.from(host.querySelectorAll("button")).map((button) =>
|
||
button.textContent?.trim(),
|
||
);
|
||
|
||
// Canonical plan-approval grammar, right→left: Approve · Revise… · Reject.
|
||
// "Revise…" already carries the send-back-with-notes path, so a distinct
|
||
// "Request changes" word is redundant and must not render.
|
||
expect(labels).toContain("Reject");
|
||
expect(labels).toContain("Revise…");
|
||
expect(labels.some((label) => label?.includes("Approve"))).toBe(true);
|
||
expect(host.textContent).not.toContain("Request changes");
|
||
});
|
||
|
||
it("does not expose continuation wake policy labels in the card header", () => {
|
||
const host = renderCard({
|
||
interaction: {
|
||
...pendingRequestConfirmationInteraction,
|
||
continuationPolicy: "wake_assignee_on_accept",
|
||
},
|
||
});
|
||
|
||
expect(host.textContent).not.toContain("Wakes on confirm");
|
||
expect(host.textContent).not.toContain("Wakes assignee");
|
||
});
|
||
|
||
it("renders request confirmation target links and stale-target expiry", () => {
|
||
const host = renderCard({
|
||
interaction: staleTargetRequestConfirmationInteraction,
|
||
});
|
||
|
||
const targetLinks = host.querySelectorAll("a");
|
||
expect(host.textContent).toContain("Expired by target change");
|
||
expect(host.textContent).toContain("Plan v3");
|
||
expect(host.textContent).toContain("Plan v4");
|
||
expect(targetLinks[0]?.getAttribute("href")).toContain("#document-plan");
|
||
expect(targetLinks[1]?.getAttribute("href")).toContain("#document-plan");
|
||
expect(host.querySelector(".lucide-chevron-right")).not.toBeNull();
|
||
expect(host.textContent).not.toContain("Approve plan");
|
||
});
|
||
|
||
describe("custom request confirmation targets", () => {
|
||
const prKey = (pull: number) => `github:paperclipai/paperclip-desktop:pull:${pull}`;
|
||
const unlabeled = (pull: number) => ({ type: "custom" as const, key: prKey(pull) });
|
||
const labeled = (pull: number) => ({
|
||
...unlabeled(pull),
|
||
label: `PR #${pull}`,
|
||
href: `https://github.com/paperclipai/paperclip-desktop/pull/${pull}`,
|
||
});
|
||
const staleTargetChange = (
|
||
staleTarget: ReturnType<typeof unlabeled>,
|
||
target: ReturnType<typeof unlabeled>,
|
||
) => ({
|
||
...staleTargetRequestConfirmationInteraction,
|
||
payload: { ...staleTargetRequestConfirmationInteraction.payload, target },
|
||
result: { version: 1 as const, outcome: "stale_target" as const, staleTarget },
|
||
});
|
||
|
||
it("hides an unlabeled target key on a pending card", () => {
|
||
const host = renderCard({
|
||
interaction: {
|
||
...pendingRequestConfirmationInteraction,
|
||
payload: { ...pendingRequestConfirmationInteraction.payload, target: unlabeled(16) },
|
||
},
|
||
});
|
||
expect(host.textContent).not.toContain("github:paperclipai");
|
||
});
|
||
|
||
it("links a labeled target on a pending card", () => {
|
||
const host = renderCard({
|
||
interaction: {
|
||
...pendingRequestConfirmationInteraction,
|
||
payload: { ...pendingRequestConfirmationInteraction.payload, target: labeled(16) },
|
||
},
|
||
});
|
||
const link = host.querySelector(
|
||
'a[href="https://github.com/paperclipai/paperclip-desktop/pull/16"]',
|
||
);
|
||
expect(link?.textContent).toContain("PR #16");
|
||
expect(host.textContent).not.toContain("github:paperclipai");
|
||
});
|
||
|
||
it("shows no chips or chevron for an unlabeled stale-target change", () => {
|
||
const host = renderCard({ interaction: staleTargetChange(unlabeled(15), unlabeled(16)) });
|
||
expect(host.textContent).toContain("Expired by target change");
|
||
expect(host.textContent).not.toContain("github:paperclipai");
|
||
expect(host.querySelector(".lucide-chevron-right")).toBeNull();
|
||
});
|
||
|
||
it("links both labeled targets across a stale-target chevron", () => {
|
||
const host = renderCard({ interaction: staleTargetChange(labeled(15), labeled(16)) });
|
||
expect(host.textContent).toContain("PR #15");
|
||
expect(host.textContent).toContain("PR #16");
|
||
expect(host.textContent).not.toContain("github:paperclipai");
|
||
expect(host.querySelector(".lucide-chevron-right")).not.toBeNull();
|
||
});
|
||
|
||
it("drops the chevron when only one side of the stale-target change is labeled", () => {
|
||
const host = renderCard({ interaction: staleTargetChange(unlabeled(15), labeled(16)) });
|
||
expect(host.textContent).toContain("PR #16");
|
||
expect(host.textContent).not.toContain("github:paperclipai");
|
||
expect(host.querySelector(".lucide-chevron-right")).toBeNull();
|
||
});
|
||
});
|
||
|
||
it("renders a jump link for confirmations expired by comment", () => {
|
||
const host = renderCard({
|
||
interaction: commentExpiredRequestConfirmationInteraction,
|
||
});
|
||
|
||
const jumpLink = Array.from(host.querySelectorAll("a")).find((link) =>
|
||
link.textContent?.includes("Jump to comment"),
|
||
);
|
||
|
||
expect(jumpLink?.getAttribute("href")).toBe(
|
||
"#comment-22222222-2222-4222-8222-222222222222",
|
||
);
|
||
});
|
||
|
||
it("declines immediately when decline reasons are disabled", async () => {
|
||
const onRejectInteraction = vi.fn(async () => undefined);
|
||
const host = renderCard({
|
||
interaction: disabledDeclineReasonRequestConfirmationInteraction,
|
||
onRejectInteraction,
|
||
});
|
||
|
||
// The bare-reject button always renders the canonical "Reject", not the
|
||
// payload's "Keep it" — ConfirmationActionRow no longer honors the override.
|
||
const declineButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.trim() === "Reject",
|
||
);
|
||
expect(declineButton).toBeTruthy();
|
||
|
||
await act(async () => {
|
||
declineButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
expect(host.querySelector("textarea")).toBeNull();
|
||
expect(onRejectInteraction).toHaveBeenCalledWith(
|
||
expect.objectContaining({ kind: "request_confirmation" }),
|
||
undefined,
|
||
);
|
||
});
|
||
|
||
it("renders explicit copy for failed request confirmations", () => {
|
||
const host = renderCard({
|
||
interaction: failedRequestConfirmationInteraction,
|
||
});
|
||
|
||
expect(host.textContent).toContain(
|
||
"This request could not be resolved. Try again or create a new request.",
|
||
);
|
||
});
|
||
|
||
it("renders a plan confirmation as a distinct state-coloured plan card", () => {
|
||
const pending = renderCard({ interaction: pendingRequestConfirmationInteraction });
|
||
const pendingShell = pending.firstElementChild as HTMLElement;
|
||
expect(pendingShell.className).toContain("border-violet-500/80");
|
||
expect(pendingShell.className).not.toContain("border-l-");
|
||
expect(pending.textContent).toContain("Plan");
|
||
expect(pending.textContent).toContain("In review");
|
||
// Approve is a neutral CTA (foreground/background), not the blue primary.
|
||
const approve = Array.from(pending.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Approve plan"),
|
||
);
|
||
expect(approve?.className).toContain("bg-foreground");
|
||
expect(approve?.className).not.toContain("bg-primary");
|
||
|
||
act(() => root?.unmount());
|
||
pending.remove();
|
||
root = null;
|
||
|
||
const accepted = renderCard({
|
||
interaction: { ...pendingRequestConfirmationInteraction, status: "accepted" },
|
||
});
|
||
expect((accepted.firstElementChild as HTMLElement).className).toContain("border-green-500/80");
|
||
expect(accepted.textContent).toContain("Approved");
|
||
|
||
act(() => root?.unmount());
|
||
accepted.remove();
|
||
root = null;
|
||
|
||
const resumeFailed = renderCard({
|
||
interaction: planApprovalResumeFailedRequestConfirmationInteraction,
|
||
});
|
||
expect((resumeFailed.firstElementChild as HTMLElement).className).toContain("border-amber-500/70");
|
||
expect(resumeFailed.textContent).toContain("Approved — agent resume failed");
|
||
expect(resumeFailed.textContent).toContain("Agent resume failed");
|
||
expect(resumeFailed.textContent).toContain("Paperclip needs attention before the agent can resume this approved work.");
|
||
expect(resumeFailed.textContent).toContain("adapter_failed");
|
||
|
||
act(() => root?.unmount());
|
||
resumeFailed.remove();
|
||
root = null;
|
||
|
||
const rejected = renderCard({
|
||
interaction: {
|
||
...pendingRequestConfirmationInteraction,
|
||
status: "rejected",
|
||
result: { version: 1, outcome: "rejected", reason: "Tighten the spacing" },
|
||
},
|
||
});
|
||
expect((rejected.firstElementChild as HTMLElement).className).toContain("border-red-500/80");
|
||
expect(rejected.textContent).toContain("Changes requested");
|
||
});
|
||
|
||
it("attaches screenshots to a plan request-changes reason as markdown images", async () => {
|
||
const onRejectInteraction = vi.fn(async () => undefined);
|
||
const onUploadImage = vi.fn(async () => "https://cdn.example/shot.png");
|
||
const host = renderCard({
|
||
interaction: {
|
||
...pendingRequestConfirmationInteraction,
|
||
payload: {
|
||
...pendingRequestConfirmationInteraction.payload,
|
||
rejectRequiresReason: false,
|
||
},
|
||
},
|
||
onRejectInteraction,
|
||
onUploadImage,
|
||
});
|
||
|
||
const reviseButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Revise"),
|
||
);
|
||
await act(async () => {
|
||
reviseButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
const attachButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Attach screenshots"),
|
||
);
|
||
expect(attachButton).toBeTruthy();
|
||
|
||
const fileInput = host.querySelector('input[type="file"]') as HTMLInputElement | null;
|
||
expect(fileInput).toBeTruthy();
|
||
const file = new File(["x"], "bug.png", { type: "image/png" });
|
||
Object.defineProperty(fileInput!, "files", { value: [file], configurable: true });
|
||
Object.defineProperty(fileInput!, "value", {
|
||
value: "C:/fake/bug.png",
|
||
writable: true,
|
||
configurable: true,
|
||
});
|
||
|
||
await act(async () => {
|
||
fileInput!.dispatchEvent(new Event("change", { bubbles: true }));
|
||
});
|
||
expect(onUploadImage).toHaveBeenCalledTimes(1);
|
||
|
||
const sendButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Send revision"),
|
||
);
|
||
await act(async () => {
|
||
sendButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
expect(onRejectInteraction).toHaveBeenCalledWith(
|
||
expect.objectContaining({ kind: "request_confirmation" }),
|
||
"",
|
||
);
|
||
});
|
||
|
||
it("opens a bound attachment directly without experimental panel routing", () => {
|
||
const host = renderCard({ interaction: { ...pendingRequestItemVerdictsInteraction,
|
||
payload: { ...pendingRequestItemVerdictsInteraction.payload, items: [{ id: "file", label: "Reviewed file", target: {
|
||
type: "issue_attachment", attachmentId: "immutable-file", assetId: "asset", sha256: "hash",
|
||
} }] },
|
||
} });
|
||
const link = host.querySelector('a[href="/api/attachments/immutable-file/content"]');
|
||
expect(link?.getAttribute("target")).toBe("_blank");
|
||
});
|
||
|
||
it.each([undefined, "/stale-display-link"])("opens a confirmation's bound attachment in Classic when href is %s", href => {
|
||
const host = renderCard({ interaction: { ...pendingRequestConfirmationInteraction, payload: {
|
||
version: 1, prompt: "Review the attached copy", target: {
|
||
type: "issue_attachment", attachmentId: "immutable-file", assetId: "asset", sha256: "hash", href,
|
||
},
|
||
} } });
|
||
expect(host.querySelector('a[href="/api/attachments/immutable-file/content"]')?.getAttribute("target")).toBe("_blank");
|
||
});
|
||
|
||
it("links a bound review item to its exact document without requiring href", () => {
|
||
const host = renderCard({ interaction: { ...pendingRequestItemVerdictsInteraction,
|
||
payload: { ...pendingRequestItemVerdictsInteraction.payload, items: [{ id: "copy", label: "Reviewed copy", target: {
|
||
type: "issue_document", issueId: "document-owner", key: "copy", revisionId: "reviewed-v1",
|
||
} }] },
|
||
} });
|
||
expect(host.querySelector('a[href*="document-copy&revision=reviewed-v1"]')?.getAttribute("href"))
|
||
.toBe(`/issues/document-owner#document-copy&revision=reviewed-v1&interaction=${pendingRequestItemVerdictsInteraction.id}`);
|
||
});
|
||
|
||
it("submits an approve verdict once a draft is marked and applied", async () => {
|
||
const onSubmitInteractionVerdicts = vi.fn(async () => undefined);
|
||
const host = renderCard({
|
||
interaction: pendingRequestItemVerdictsInteraction,
|
||
onSubmitInteractionVerdicts,
|
||
});
|
||
|
||
const firstItemId = pendingRequestItemVerdictsInteraction.payload.items[0]!.id;
|
||
const approveButton = Array.from(
|
||
host.querySelectorAll<HTMLButtonElement>(`[data-item-id="${firstItemId}"] button[data-verdict="approve"]`),
|
||
)[0];
|
||
expect(approveButton).toBeTruthy();
|
||
// 44px minimum target (a11y).
|
||
expect(approveButton?.className).toContain("min-h-11");
|
||
|
||
await act(async () => {
|
||
approveButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
const applyButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Apply 1 decision"),
|
||
);
|
||
expect(applyButton).toBeTruthy();
|
||
|
||
await act(async () => {
|
||
applyButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
expect(onSubmitInteractionVerdicts).toHaveBeenCalledWith(
|
||
expect.objectContaining({ kind: "request_item_verdicts" }),
|
||
[{ id: firstItemId, verdict: "approve", reason: undefined }],
|
||
);
|
||
});
|
||
|
||
it("blocks apply for a rejected item until a reason is entered", async () => {
|
||
const onSubmitInteractionVerdicts = vi.fn(async () => undefined);
|
||
const host = renderCard({
|
||
interaction: pendingRequestItemVerdictsInteraction,
|
||
onSubmitInteractionVerdicts,
|
||
});
|
||
|
||
const firstItemId = pendingRequestItemVerdictsInteraction.payload.items[0]!.id;
|
||
const rejectButton = Array.from(
|
||
host.querySelectorAll<HTMLButtonElement>(`[data-item-id="${firstItemId}"] button[data-verdict="reject"]`),
|
||
)[0];
|
||
await act(async () => {
|
||
rejectButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
|
||
// Reject reveals a required reason field.
|
||
const reasonField = host.querySelector<HTMLTextAreaElement>(
|
||
`textarea[id="${pendingRequestItemVerdictsInteraction.id}-${firstItemId}-reason"]`,
|
||
);
|
||
expect(reasonField).toBeTruthy();
|
||
|
||
const applyButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Apply 1 decision"),
|
||
);
|
||
// Attempting to apply without a reason does not submit.
|
||
await act(async () => {
|
||
applyButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
expect(onSubmitInteractionVerdicts).not.toHaveBeenCalled();
|
||
expect(host.textContent).toContain("A reason is required to reject this item.");
|
||
});
|
||
|
||
it("renders resolved verdicts as terminal chips with reason echo", () => {
|
||
const host = renderCard({ interaction: completeRequestItemVerdictsInteraction });
|
||
expect(host.textContent).toContain("Approved");
|
||
expect(host.textContent).toContain("Rejected");
|
||
expect(host.textContent).toContain("Tone is off-brand");
|
||
// S5 summary chip.
|
||
expect(host.textContent).toContain("3 approved");
|
||
// No actionable verdict buttons once terminal.
|
||
expect(host.querySelector("button[data-verdict]")).toBeNull();
|
||
});
|
||
|
||
it("shows an already-applied, cannot-revert notice when superseded", () => {
|
||
const host = renderCard({ interaction: supersededRequestItemVerdictsInteraction });
|
||
expect(host.textContent).toContain("expired after a later comment");
|
||
expect(host.textContent).toContain("cannot be");
|
||
expect(host.textContent?.toLowerCase()).toContain("revert");
|
||
});
|
||
});
|
||
|
||
describe("IssueThreadInteractionCard tool-action card", () => {
|
||
it("keeps the request description and decisions primary with optional argument inspection", () => {
|
||
const host = renderCard({ interaction: pendingToolActionWriteInteraction, onAcceptInteraction: vi.fn(), onRejectInteraction: vi.fn() });
|
||
expect(host.textContent).toContain("Add 1 row");
|
||
expect(host.querySelector('[role="img"]')?.getAttribute("aria-label")).toBe("Google Sheets");
|
||
expect(host.textContent).toContain("Approve & run");
|
||
expect(host.textContent).toContain("Decline");
|
||
expect(host.textContent).not.toContain("Append row to spreadsheet");
|
||
expect(host.textContent).not.toContain("Technical details");
|
||
expect(host.textContent).not.toContain("Expires");
|
||
expect(host.textContent).not.toContain("args hash");
|
||
});
|
||
|
||
it("keeps reviewed argument values visible across preview paragraphs", () => {
|
||
const interaction = structuredClone(pendingToolActionWriteInteraction);
|
||
interaction.payload.toolAction!.previewMarkdown = "Add a row.\n\n**Title:** Launch checklist";
|
||
const host = renderCard({ interaction });
|
||
expect(host.textContent).toContain("Launch checklist");
|
||
});
|
||
|
||
it("keeps an approved connection wait actionable without showing execution or another approval", () => {
|
||
const interaction = structuredClone(runningToolActionInteraction);
|
||
interaction.payload.toolAction!.expiresAt = null;
|
||
interaction.result!.toolAction = { version: 1, status: "approved", updatedAt: new Date().toISOString(),
|
||
errorCode: "approved_action_connection_required" };
|
||
const host = renderCard({ interaction });
|
||
expect(host.textContent).toContain("Your approval is saved");
|
||
expect(host.textContent).toContain("Sign-in needed");
|
||
expect(host.textContent).not.toContain("Running");
|
||
expect(host.textContent).not.toContain("Approve & run");
|
||
expect(host.textContent).not.toContain("Expires");
|
||
expect(host.querySelector(`a[href="/apps/${interaction.payload.toolAction!.connectionId}/permissions"]`)?.textContent)
|
||
.toContain("Reconnect");
|
||
});
|
||
|
||
it.each(["default", "coordinator-decision"] as const)("renders the full redacted proposal as plain text before approval (%s)", async (presentationVariant) => {
|
||
const interaction = structuredClone(pendingToolActionWriteInteraction);
|
||
interaction.payload.toolAction!.argumentsSummaryJson = JSON.stringify({ text: '<img src="x" onerror="alert(1)">', apiKey: "[redacted]" });
|
||
const accept = vi.fn();
|
||
const host = renderCard({ interaction, onAcceptInteraction: accept, presentationVariant });
|
||
const details = host.querySelector("details")!;
|
||
expect(details.open).toBe(false);
|
||
await act(async () => details.querySelector("summary")!.click());
|
||
expect(details.open).toBe(true);
|
||
expect(details.querySelector("pre")?.textContent).toBe(interaction.payload.toolAction!.argumentsSummaryJson);
|
||
expect(details.querySelector("img")).toBeNull();
|
||
expect(details.textContent).toContain("[redacted]");
|
||
expect(accept).not.toHaveBeenCalled();
|
||
});
|
||
|
||
it.each([undefined, { secret: "must not render" }, "x".repeat(20_001)])("withholds missing, malformed or oversized proposal details (%#)", summary => {
|
||
const interaction = structuredClone(pendingToolActionWriteInteraction);
|
||
Object.assign(interaction.payload.toolAction!, { argumentsSummaryJson: summary });
|
||
const host = renderCard({ interaction });
|
||
expect(host.querySelector("details")).toBeNull();
|
||
expect(host.textContent).toContain("Request arguments are unavailable.");
|
||
expect(host.textContent).not.toContain("must not render");
|
||
expect(host.querySelector("pre")).toBeNull();
|
||
expect(Array.from(host.querySelectorAll("button")).find(button => button.textContent === "Approve & run")?.disabled).toBe(true);
|
||
});
|
||
|
||
it.each(["argumentsSummaryJson", "argumentsHash"] as const)("rejects oversized whitespace before trimming %s", field => {
|
||
const interaction = structuredClone(pendingToolActionWriteInteraction);
|
||
const oversized = " ".repeat(field === "argumentsSummaryJson" ? 20_001 : 256);
|
||
interaction.payload.toolAction![field] = oversized;
|
||
const trim = String.prototype.trim;
|
||
let oversizedTrimCalls = 0;
|
||
const spy = vi.spyOn(String.prototype, "trim").mockImplementation(function (this: string) {
|
||
if (String(this) === oversized) oversizedTrimCalls++;
|
||
return trim.call(this);
|
||
});
|
||
try {
|
||
const host = renderCard({ interaction });
|
||
expect(host.querySelector("details")).toBeNull();
|
||
expect(host.textContent).toContain("Request arguments are unavailable.");
|
||
expect(oversizedTrimCalls).toBe(0);
|
||
} finally {
|
||
spy.mockRestore();
|
||
}
|
||
});
|
||
|
||
it("keeps the destructive request warning and approval styling", () => {
|
||
const host = renderCard({ interaction: pendingToolActionDestructiveInteraction, onAcceptInteraction: vi.fn(), onRejectInteraction: vi.fn() });
|
||
expect(host.textContent).toContain("cannot be undone");
|
||
const approve = Array.from(host.querySelectorAll("button")).find(button => button.textContent === "Approve & run");
|
||
expect(approve?.getAttribute("data-variant")).toBe("destructive");
|
||
});
|
||
|
||
it("declines in one click without an optional reason form", async () => {
|
||
const reject = vi.fn();
|
||
const host = renderCard({ interaction: pendingToolActionWriteInteraction, onRejectInteraction: reject });
|
||
const decline = Array.from(host.querySelectorAll("button")).find(button => button.textContent === "Decline");
|
||
await act(async () => { decline?.click(); });
|
||
expect(reject).toHaveBeenCalledExactlyOnceWith(pendingToolActionWriteInteraction);
|
||
expect(host.querySelector("textarea")).toBeNull();
|
||
});
|
||
|
||
it("renders the approved-running state with a spinner and no action buttons", () => {
|
||
const host = renderCard({ interaction: runningToolActionInteraction });
|
||
|
||
expect(host.textContent).toContain("Running…");
|
||
expect(host.textContent).toContain("Approved · Running");
|
||
expect(host.textContent).not.toContain("Approve & run");
|
||
expect(host.querySelector(".animate-spin")).toBeTruthy();
|
||
});
|
||
|
||
it("keeps the executed result collapsed and never reads Accepted", () => {
|
||
const host = renderCard({ interaction: executedToolActionInteraction });
|
||
|
||
expect(host.textContent).toContain("Succeeded");
|
||
expect(host.textContent).not.toContain("Row 42 added");
|
||
expect(host.querySelector('button[aria-label="Show result details"]')?.getAttribute("aria-expanded")).toBe("false");
|
||
expect(host.textContent).not.toContain("Accepted");
|
||
const link = Array.from(host.querySelectorAll("a")).find((a) =>
|
||
a.textContent?.includes("View result"),
|
||
);
|
||
expect(link?.getAttribute("href")).toContain("docs.google.com");
|
||
});
|
||
|
||
it("expands stored results as formatted JSON on demand", async () => {
|
||
const interaction = structuredClone(executedToolActionInteraction);
|
||
interaction.result!.toolAction!.resultSummary = '{"pages":["Roadmap","Meeting notes"]}';
|
||
const host = renderCard({ interaction });
|
||
expect(host.textContent).not.toContain("Roadmap");
|
||
const toggle = host.querySelector('button[aria-label="Show result details"]') as HTMLButtonElement;
|
||
await act(async () => toggle.click());
|
||
expect(host.querySelector("pre")?.textContent).toBe(JSON.stringify({ pages: ["Roadmap", "Meeting notes"] }, null, 2));
|
||
expect(toggle.getAttribute("aria-expanded")).toBe("true");
|
||
await act(async () => toggle.click());
|
||
expect(host.textContent).not.toContain("Roadmap");
|
||
});
|
||
|
||
it("distinguishes failed (ran + connector error) from declined (did not run)", () => {
|
||
const failed = renderCard({ interaction: failedToolActionInteraction });
|
||
expect(failed.textContent).toContain("Execution failed");
|
||
expect(failed.textContent).toContain(failedToolActionInteraction.result!.toolAction!.errorMessage);
|
||
|
||
act(() => root?.unmount());
|
||
failed.remove();
|
||
root = null;
|
||
|
||
const declined = renderCard({ interaction: declinedToolActionInteraction });
|
||
expect(declined.textContent).toContain("Declined");
|
||
expect(declined.textContent).toContain("use the CRM sync instead");
|
||
expect(declined.textContent).not.toContain("Approve & run");
|
||
});
|
||
|
||
it("makes a GitHub access failure actionable without offering a futile retry", () => {
|
||
const interaction = { ...failedToolActionInteraction,
|
||
payload: { ...failedToolActionInteraction.payload, toolAction: {
|
||
...failedToolActionInteraction.payload.toolAction!, appDisplayName: "GitHub",
|
||
} },
|
||
result: { ...failedToolActionInteraction.result!, toolAction: {
|
||
...failedToolActionInteraction.result!.toolAction!, errorCode: "github_access_denied",
|
||
errorMessage: "failed to create repository: POST https://api.github.com/user/repos: 403 Resource not accessible by integration []",
|
||
} },
|
||
};
|
||
const host = renderCard({ interaction });
|
||
expect(host.querySelector('[role="alert"]')?.textContent).toContain("GitHub access needed");
|
||
expect(host.textContent).toContain(interaction.result.toolAction.errorMessage);
|
||
expect(host.textContent).toContain("Check the connected account");
|
||
expect(host.textContent).toContain("ask the agent to continue");
|
||
expect(host.querySelector("details")?.hasAttribute("open")).toBe(false);
|
||
const manage = Array.from(host.querySelectorAll("a")).find(link => link.textContent === "Manage GitHub access");
|
||
expect(manage?.getAttribute("href")).toBe(`/apps/${interaction.payload.toolAction.connectionId}/permissions`);
|
||
expect(host.textContent).not.toContain("Retry");
|
||
expect(host.textContent).not.toContain("Approve & run");
|
||
});
|
||
|
||
it("renders the expired state without decision controls", () => {
|
||
const host = renderCard({ interaction: expiredToolActionInteraction });
|
||
|
||
expect(host.textContent).toContain("Expired");
|
||
expect(host.textContent).not.toContain("Approve & run");
|
||
});
|
||
|
||
it("keeps the generic confirmation rendering for cards without a toolAction", () => {
|
||
const host = renderCard({
|
||
interaction: pendingRequestConfirmationInteraction,
|
||
onAcceptInteraction: vi.fn(),
|
||
onRejectInteraction: vi.fn(),
|
||
});
|
||
|
||
// Legacy confirmation keeps its own prompt + labels, no tool-action surface.
|
||
expect(host.textContent).toContain("Approve the plan and let the responsible start implementation?");
|
||
expect(host.textContent).not.toContain("Approve & run");
|
||
expect(host.textContent).not.toContain("Technical details");
|
||
});
|
||
|
||
it("renders the addressee chip without the removed policy badge", () => {
|
||
const host = renderCard({
|
||
interaction: agentAddressedRequestConfirmationInteraction,
|
||
});
|
||
|
||
// PAP-440: the "Agents may resolve" policy badge was pure noise — never rendered.
|
||
expect(host.querySelector('[data-testid="interaction-policy-badge"]')).toBeNull();
|
||
|
||
const addresseeBadge = host.querySelector('[data-testid="interaction-addressee-badge"]');
|
||
expect(addresseeBadge?.textContent).toContain("For ");
|
||
});
|
||
|
||
it("omits the addressee badge for a board-only interaction", () => {
|
||
const host = renderCard({
|
||
interaction: pendingRequestConfirmationInteraction,
|
||
});
|
||
|
||
expect(host.querySelector('[data-testid="interaction-policy-badge"]')).toBeNull();
|
||
expect(host.querySelector('[data-testid="interaction-addressee-badge"]')).toBeNull();
|
||
});
|
||
|
||
it("marks agent resolution with an audit chip in the resolved footer", () => {
|
||
const host = renderCard({
|
||
interaction: agentResolvedRequestConfirmationInteraction,
|
||
});
|
||
|
||
const footer = host.querySelector('[data-testid="interaction-resolved-footer"]');
|
||
expect(footer?.textContent).toContain("Resolved by");
|
||
expect(
|
||
host.querySelector('[data-testid="interaction-resolved-by-agent-chip"]'),
|
||
).not.toBeNull();
|
||
});
|
||
|
||
it("renders a withdrawn footer with the withdrawer, reason, and agent chip", () => {
|
||
const host = renderCard({
|
||
interaction: withdrawnRequestConfirmationInteraction,
|
||
});
|
||
|
||
// Header status reads "Withdrawn", not the raw "Cancelled" status.
|
||
expect(host.textContent).toContain("Withdrawn");
|
||
// Withdrawn is a neutral administrative retraction — it must NOT wear the
|
||
// cancelled/rejected costume (rose/red border + XCircle). The shell is muted
|
||
// (border-border), never a rose/red alarm colour (design review R2).
|
||
const cardRoot = host.querySelector("div.rounded-lg.p-5.shadow-none");
|
||
expect(cardRoot?.className).toContain("border-border");
|
||
expect(cardRoot?.className).not.toMatch(/border-(rose|red)/);
|
||
// The header status icon is MinusCircle ("retracted"), never XCircle ("denied").
|
||
const statusIcon = cardRoot?.querySelector("svg");
|
||
expect(statusIcon?.getAttribute("class")).toContain("lucide-circle-minus");
|
||
expect(statusIcon?.getAttribute("class")).not.toContain("lucide-circle-x");
|
||
const footer = host.querySelector('[data-testid="interaction-withdrawn-footer"]');
|
||
expect(footer?.textContent).toContain("Withdrawn by");
|
||
expect(footer?.textContent).toContain("Plan superseded by a newer revision");
|
||
expect(
|
||
footer?.querySelector('[data-testid="interaction-resolved-by-agent-chip"]'),
|
||
).not.toBeNull();
|
||
// The generic "Resolved by" footer must not double-render.
|
||
expect(host.querySelector('[data-testid="interaction-resolved-footer"]')).toBeNull();
|
||
});
|
||
|
||
it("renders an issue-closed expiry footer for terminal auto-expiry", () => {
|
||
const host = renderCard({
|
||
interaction: issueClosedRequestConfirmationInteraction,
|
||
});
|
||
|
||
// Footer is trimmed to just the audit timestamp — the header status badge
|
||
// already carries the "Expired · issue closed" label, so the footer must
|
||
// not restate it.
|
||
const footer = host.querySelector('[data-testid="interaction-issue-closed-footer"]');
|
||
expect(footer?.textContent).toContain("Apr 20");
|
||
expect(footer?.textContent).not.toContain("Expired when the issue closed");
|
||
// The "Expired · issue closed" label survives exactly once (the header
|
||
// status badge); the duplicate body eyebrow was dropped.
|
||
const label = "Expired · issue closed";
|
||
const occurrences = (host.textContent ?? "").split(label).length - 1;
|
||
expect(occurrences).toBe(1);
|
||
});
|
||
|
||
});
|
||
|
||
describe("IssueThreadInteractionCard secret-proposal card", () => {
|
||
it("renders only safe proposal metadata and exposes accept/reject actions", async () => {
|
||
const onAcceptInteraction = vi.fn(async () => undefined);
|
||
const onRejectInteraction = vi.fn(async () => undefined);
|
||
const host = renderCard({
|
||
interaction: pendingSecretProposalInteraction,
|
||
onAcceptInteraction,
|
||
onRejectInteraction,
|
||
});
|
||
|
||
expect(host.textContent).toContain("Secret binding requested");
|
||
expect(host.textContent).toContain("OpenAI API key");
|
||
expect((host.textContent ?? "").split("OpenAI API key")).toHaveLength(2);
|
||
expect(host.textContent).toContain("access.evals_openai_api_key");
|
||
expect(host.textContent).toContain("EvalsEngineer");
|
||
expect(host.textContent).toContain("Reason given by the agent");
|
||
expect(host.textContent).toContain("evaluation runner needs the existing credential");
|
||
expect(host.textContent).toContain("Expires");
|
||
expect(host.textContent).not.toContain(
|
||
pendingSecretProposalInteraction.payload.secretProposal?.proposalId,
|
||
);
|
||
expect(host.textContent).not.toContain(
|
||
pendingSecretProposalInteraction.payload.secretProposal?.targetAgentId,
|
||
);
|
||
expect(host.textContent?.toLowerCase()).not.toContain("fingerprint");
|
||
|
||
const statusBadge = host.querySelector('[data-testid="interaction-status-badge"]');
|
||
expect(statusBadge?.querySelector(".flex-col")?.textContent).toBe(
|
||
"Secret binding/Awaiting approval",
|
||
);
|
||
expect(statusBadge?.querySelector(".hidden")?.textContent).toBe("/");
|
||
const actions = host.querySelector('[data-testid="confirmation-actions"]');
|
||
expect(actions?.getAttribute("data-mobile-layout")).toBe("stacked");
|
||
expect(actions?.classList.contains("grid-cols-2")).toBe(true);
|
||
const configPath = Array.from(host.querySelectorAll("dd")).find((node) =>
|
||
node.textContent === "access.evals_openai_api_key"
|
||
);
|
||
expect(configPath?.parentElement?.classList.contains("sm:col-span-2")).toBe(true);
|
||
|
||
const approve = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.includes("Approve & bind"),
|
||
);
|
||
await act(async () => {
|
||
approve?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
expect(onAcceptInteraction).toHaveBeenCalledWith(pendingSecretProposalInteraction);
|
||
|
||
const reject = Array.from(host.querySelectorAll("button")).find((button) =>
|
||
button.textContent?.trim() === "Reject",
|
||
);
|
||
await act(async () => {
|
||
reject?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||
});
|
||
expect(onRejectInteraction).toHaveBeenCalledWith(
|
||
pendingSecretProposalInteraction,
|
||
undefined,
|
||
);
|
||
});
|
||
|
||
it("renders an accepted proposal as executed rather than merely accepted", () => {
|
||
const host = renderCard({ interaction: executedSecretProposalInteraction });
|
||
expect(host.textContent).toContain("Executed");
|
||
expect(host.textContent).toContain("Binding created");
|
||
expect(host.textContent).not.toContain("Accepted");
|
||
expect(host.querySelector("button")).toBeNull();
|
||
});
|
||
|
||
it("renders accepted execution failure as visibly FAILED with its error code", () => {
|
||
const host = renderCard({ interaction: failedSecretProposalInteraction });
|
||
expect(host.textContent).toContain("FAILED");
|
||
expect(host.textContent).toContain("binding_snapshot_stale");
|
||
expect(host.textContent).toContain("binding was not created");
|
||
expect(host.textContent).not.toContain("Approve & bind");
|
||
});
|
||
|
||
it("distinguishes rejected and expired proposals as non-executed terminal states", () => {
|
||
const rejected = renderCard({ interaction: rejectedSecretProposalInteraction });
|
||
expect(rejected.textContent).toContain("Rejected");
|
||
expect(rejected.textContent).toContain("The binding was not created");
|
||
expect(rejected.textContent).toContain("project-scoped credential");
|
||
|
||
act(() => root?.unmount());
|
||
rejected.remove();
|
||
root = null;
|
||
|
||
const expired = renderCard({ interaction: expiredSecretProposalInteraction });
|
||
expect(expired.textContent).toContain("Expired");
|
||
expect(expired.textContent).toContain("A fresh proposal is required");
|
||
expect(expired.textContent).not.toContain("Approve & bind");
|
||
});
|
||
});
|
||
|
||
/**
|
||
* Connection authorization has its own card composition (PAP-17796 Surface F,
|
||
* corrected in PAP-17859). It must not fall through to the generic
|
||
* Approve / Revise… / Reject layout: there is nothing to revise, and only the
|
||
* addressed person can answer at all.
|
||
*/
|
||
describe("IssueThreadInteractionCard connection-authorization card", () => {
|
||
const CAROL_LABELS = new Map([
|
||
[issueThreadInteractionFixtureMeta.currentUserId, "Carol"],
|
||
]);
|
||
|
||
function buttonLabels(host: HTMLElement) {
|
||
return Array.from(host.querySelectorAll("button")).map((button) => button.textContent?.trim());
|
||
}
|
||
|
||
it("offers the addressed person Connect plus Not now, and nothing from the generic grammar", () => {
|
||
const host = renderCard({
|
||
interaction: pendingConnectionAuthorizationInteraction,
|
||
currentUserId: issueThreadInteractionFixtureMeta.currentUserId,
|
||
onAcceptInteraction: async () => {},
|
||
onRejectInteraction: async () => {},
|
||
});
|
||
|
||
expect(host.textContent).toContain("Connect your Gmail to continue");
|
||
|
||
// "Action required" rather than the generic kind label: the mechanism is
|
||
// not the point, the blocked work is.
|
||
const statusBadge = host.querySelector('[data-testid="interaction-status-badge"]');
|
||
expect(statusBadge?.textContent).toContain("Action required");
|
||
expect(statusBadge?.textContent).not.toContain("Confirmation");
|
||
|
||
// One title, one body. The generic layout rendered `payload.prompt` too,
|
||
// which is the title verbatim.
|
||
const titles = (host.textContent ?? "").split("Connect your Gmail to continue").length - 1;
|
||
expect(titles).toBe(1);
|
||
const body = host.querySelector('[data-testid="connection-authorization-body"]');
|
||
expect(host.querySelectorAll('[data-testid="connection-authorization-body"]').length).toBe(1);
|
||
expect(body?.textContent).toContain(
|
||
"Outreach Agent needs your Gmail identity for work running as you.",
|
||
);
|
||
expect(body?.textContent).toContain("No one else can complete this step.");
|
||
|
||
// The primary action is a link to the server-minted target, not an accept
|
||
// call: the OAuth callback is what resolves this card.
|
||
const connect = Array.from(host.querySelectorAll("a")).find((anchor) =>
|
||
anchor.textContent?.includes("Connect Gmail"),
|
||
);
|
||
expect(connect?.getAttribute("href")).toBe(
|
||
"https://accounts.google.com/o/oauth2/v2/auth?client_id=paperclip",
|
||
);
|
||
expect(connect?.getAttribute("target")).toBe("_blank");
|
||
|
||
const labels = buttonLabels(host);
|
||
expect(labels).toContain("Not now");
|
||
for (const generic of ["Approve", "Revise…", "Reject", "Send revision"]) {
|
||
expect(labels).not.toContain(generic);
|
||
}
|
||
|
||
// Consent is the addressed person's alone. The card must never imply a
|
||
// teammate can give it for them.
|
||
expect(host.textContent?.toLowerCase()).not.toContain("on behalf of");
|
||
expect(host.textContent?.toLowerCase()).not.toContain("anyone can");
|
||
});
|
||
|
||
it("gives another reader Waiting for Carol and no action controls at all", () => {
|
||
const host = renderCard({
|
||
interaction: pendingConnectionAuthorizationInteraction,
|
||
currentUserId: "user-someone-else",
|
||
userLabelMap: CAROL_LABELS,
|
||
onAcceptInteraction: async () => {},
|
||
onRejectInteraction: async () => {},
|
||
});
|
||
|
||
expect(host.querySelector('[data-testid="connection-authorization-waiting"]')?.textContent)
|
||
.toContain("Waiting for Carol");
|
||
expect(host.querySelector('[data-testid="interaction-status-badge"]')?.textContent)
|
||
.toContain("Waiting for Carol");
|
||
// The server's summary is second-person ("your Gmail identity", "as you")
|
||
// because it addressed one person. A teammate must not be told the agent
|
||
// wants *their* account.
|
||
const body = host.querySelector('[data-testid="connection-authorization-body"]')?.textContent;
|
||
expect(body).toBe(
|
||
"Outreach Agent needs Carol's Gmail identity for work running as them.",
|
||
);
|
||
expect(host.querySelector('[data-testid="connection-authorization-waiting"]')?.textContent)
|
||
.toContain("Only Carol can connect their own Gmail account.");
|
||
|
||
// Omitted, not disabled — and the authorization URL is not even in the DOM
|
||
// for someone who may not use it.
|
||
const labels = buttonLabels(host);
|
||
for (const forbidden of ["Connect Gmail", "Not now", "Approve", "Revise…", "Reject"]) {
|
||
expect(labels).not.toContain(forbidden);
|
||
}
|
||
expect(
|
||
Array.from(host.querySelectorAll("a")).some((a) => a.textContent?.includes("Connect Gmail")),
|
||
).toBe(false);
|
||
expect(host.innerHTML).not.toContain("accounts.google.com");
|
||
});
|
||
|
||
it("resolves to Gmail connected with the resolver and a timestamp", () => {
|
||
const host = renderCard({
|
||
interaction: resolvedConnectionAuthorizationInteraction,
|
||
currentUserId: "user-someone-else",
|
||
userLabelMap: CAROL_LABELS,
|
||
onAcceptInteraction: async () => {},
|
||
onRejectInteraction: async () => {},
|
||
});
|
||
|
||
const statusBadge = host.querySelector('[data-testid="interaction-status-badge"]');
|
||
expect(statusBadge?.textContent).toContain("Gmail connected");
|
||
expect(statusBadge?.textContent).not.toContain("Action required");
|
||
|
||
const connected = host.querySelector('[data-testid="connection-authorization-connected"]');
|
||
expect(connected?.textContent).toContain("Gmail connected");
|
||
expect(connected?.textContent).toContain("Connected by Carol");
|
||
expect(connected?.textContent).toMatch(/on .*2026/);
|
||
expect(host.querySelector('[data-testid="connection-authorization-body"]')?.textContent)
|
||
.toBe("Outreach Agent needed Carol's Gmail identity for work running as them.");
|
||
|
||
// A resolved card never re-offers the spent authorization target.
|
||
expect(host.innerHTML).not.toContain("accounts.google.com");
|
||
expect(buttonLabels(host)).not.toContain("Connect Gmail");
|
||
// The card states its own resolver, so the shared footer must not repeat it.
|
||
expect(host.querySelector('[data-testid="interaction-resolved-footer"]')).toBeNull();
|
||
});
|
||
});
|
||
|
||
describe("IssueThreadInteractionCard connection-intent card", () => {
|
||
const USER_LABELS = new Map([[issueThreadInteractionFixtureMeta.currentUserId, "Carol"]]);
|
||
|
||
;
|
||
|
||
it("shows another viewer only who it is waiting for", () => {
|
||
const host = renderCard({
|
||
interaction: pendingConnectionIntentInteraction,
|
||
currentUserId: "user-someone-else",
|
||
userLabelMap: USER_LABELS,
|
||
});
|
||
expect(host.querySelector('[data-testid="connection-intent-waiting"]')?.textContent)
|
||
.toContain("Waiting for Carol");
|
||
expect(host.querySelector('[data-testid="connection-intent-actions"]')).toBeNull();
|
||
expect(host.querySelectorAll("button")).toHaveLength(0);
|
||
expect(host.innerHTML).not.toContain("authorizationUrl");
|
||
expect(host.textContent).not.toContain("Not now");
|
||
});
|
||
|
||
it("renders retry and connected terminal states without generic confirmation actions", () => {
|
||
const retry = renderCard({
|
||
interaction: retryConnectionIntentInteraction,
|
||
currentUserId: issueThreadInteractionFixtureMeta.currentUserId,
|
||
});
|
||
expect(retry.textContent).toContain("Authorization didn’t finish");
|
||
expect(retry.textContent).toContain("Try again");
|
||
|
||
act(() => root?.unmount());
|
||
retry.remove();
|
||
root = null;
|
||
const connected = renderCard({
|
||
interaction: connectedConnectionIntentInteraction,
|
||
currentUserId: issueThreadInteractionFixtureMeta.currentUserId,
|
||
});
|
||
expect(connected.querySelector('[data-testid="connection-intent-terminal"]')?.textContent)
|
||
.toContain("Notion connected");
|
||
expect(connected.textContent).not.toContain("Approve");
|
||
});
|
||
});
|
||
|
||
describe("IssueThreadInteractionCard resolver audience", () => {
|
||
it("shows an open audience on a pending card created without a restriction", () => {
|
||
const host = renderCard({ interaction: pendingRequestConfirmationInteraction });
|
||
|
||
const audience = host.querySelector('[data-testid="interaction-audience"]');
|
||
expect(audience?.getAttribute("data-audience-policy")).toBe("anyone");
|
||
expect(audience?.getAttribute("data-audience-open")).toBe("true");
|
||
expect(audience?.textContent).toContain("Anyone");
|
||
expect(audience?.textContent).toContain("the board or any agent, including the one that asked");
|
||
// An open card must never read as board-required.
|
||
expect(audience?.textContent).not.toMatch(/only a person on the board/i);
|
||
expect(host.querySelector('[data-testid="interaction-audience-note"]')).toBeNull();
|
||
});
|
||
|
||
it("names the excluded creator for an explicit not_creator card", () => {
|
||
const host = renderCard({
|
||
interaction: notCreatorRequestConfirmationInteraction,
|
||
agentMap: new Map([["agent-codex", { name: "CodexCoder" } as Agent]]),
|
||
});
|
||
|
||
const audience = host.querySelector('[data-testid="interaction-audience"]');
|
||
expect(audience?.getAttribute("data-audience-policy")).toBe("not_creator");
|
||
expect(audience?.getAttribute("data-audience-open")).toBe("false");
|
||
expect(audience?.textContent).toContain("Anyone except creator");
|
||
expect(audience?.textContent).toContain("except CodexCoder can respond");
|
||
});
|
||
|
||
it("keeps human-only ownership copy on a human-only card", () => {
|
||
const host = renderCard({ interaction: humanOnlyRequestConfirmationInteraction });
|
||
|
||
const audience = host.querySelector('[data-testid="interaction-audience"]');
|
||
expect(audience?.getAttribute("data-audience-policy")).toBe("human_only");
|
||
expect(audience?.textContent).toContain("Human only");
|
||
expect(audience?.textContent).toContain("Only a person on the board can respond");
|
||
});
|
||
|
||
it("keeps addressee ownership copy on an agent-addressed card", () => {
|
||
const host = renderCard({
|
||
interaction: agentAddressedRequestConfirmationInteraction,
|
||
agentMap: new Map([["agent-codex", { name: "CodexCoder" } as Agent]]),
|
||
});
|
||
|
||
const audience = host.querySelector('[data-testid="interaction-audience"]');
|
||
expect(audience?.getAttribute("data-audience-open")).toBe("false");
|
||
expect(audience?.textContent).toContain("Addressed");
|
||
expect(audience?.textContent).toContain("Only CodexCoder or a person on the board can respond");
|
||
expect(audience?.textContent).not.toContain("Anyone");
|
||
});
|
||
|
||
it("explains a company cap that narrowed the requested audience", () => {
|
||
const host = renderCard({ interaction: companyCappedRequestConfirmationInteraction });
|
||
|
||
const audience = host.querySelector('[data-testid="interaction-audience"]');
|
||
expect(audience?.getAttribute("data-audience-policy")).toBe("human_only");
|
||
expect(
|
||
host.querySelector('[data-testid="interaction-audience-note"]')?.textContent,
|
||
).toBe("Organization interaction governance narrowed this from Anyone to Human only.");
|
||
});
|
||
|
||
it("explains a legacy card that predates the open default", () => {
|
||
const host = renderCard({ interaction: legacyRestrictedRequestConfirmationInteraction });
|
||
|
||
expect(
|
||
host.querySelector('[data-testid="interaction-audience-note"]')?.textContent,
|
||
).toContain("Created before Anyone became the default");
|
||
});
|
||
|
||
it("omits the audience row once a card is resolved and shows who resolved it", () => {
|
||
const host = renderCard({
|
||
interaction: agentResolvedRequestConfirmationInteraction,
|
||
agentMap: new Map([["agent-codex", { name: "CodexCoder" } as Agent]]),
|
||
});
|
||
|
||
expect(host.querySelector('[data-testid="interaction-audience"]')).toBeNull();
|
||
const footer = host.querySelector('[data-testid="interaction-resolved-footer"]');
|
||
expect(footer?.textContent).toContain("Resolved by");
|
||
expect(footer?.textContent).toContain("CodexCoder");
|
||
expect(
|
||
footer?.querySelector('[data-testid="interaction-resolved-by-agent-chip"]'),
|
||
).not.toBeNull();
|
||
});
|
||
});
|