mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-19 20:44:16 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The left nav is the main way people move between tasks, the inbox, and Agent Chat > - The nav has separate Inbox and Tasks rows that show overlapping work, and Chat is one row among many > - The side panel beside a chat shows the conversation's own artifacts, not the work the agent did > - People want Chat to be easy to find, and they want one place for their task views > - This pull request moves Chat to the top of Work, shows the agent's tasks and artifacts beside each chat, and adds an experimental flag that folds Inbox into Tasks > - The benefit is a shorter nav and a chat view that shows what the agent is working on. Both changes stay off until an operator enables them ## Linked Issues or Issue Description Refs #14706 (the secondary Agent Chat navigation this change builds on) Refs #14848 (reopen the last visited agent chat) **Subsystem affected** UI navigation (left nav, mobile tab bar), Agent Chat side panel, task list and inbox, and the company artifacts API. **Problem or motivation** Inbox and Tasks are two nav rows for overlapping work. Chat sits in the top group with no clear home. The chat rail lists only agents you already talked to, so you cannot see your other teammates there. The side panel beside a chat shows only the conversation's own artifacts. It does not show the tasks and files the agent made. **Proposed solution** With Agent Chat on, Chat leads the Work section and the rail lists every eligible agent. The chat side panel opens on the agent's tasks as cards, and the agent's artifacts are available from +. A new experimental flag, Combined Inbox + Task List, makes Inbox a set of views inside Tasks. **Alternatives considered** Rebuilding the inbox inside the task list. Instead, `/issues` hosts the existing Inbox component for inbox views and the existing task list for status views, so all inbox behaviour stays the same. **Roadmap alignment** Agent Chat (ROADMAP.md, "Agent Chat (including CEO Chat)"). All changes are behind experimental flags that are off by default. ## What Changed - **Agent Chat nav (streamlined shell):** Chat is the first row of Work, not a top-group row. Workspaces leaves the nav while Agent Chat is on. The mobile tab bar is Home · Chat · + · Tasks · Agents. The legacy shell keeps master's top-group Chat row. - **Chat rail:** `AgentConversationsSidebar` lists every eligible agent. The open chat is first, then conversations by recent activity, then the rest of the roster alphabetically. Terminated agents and agents you left are omitted unless you have history with them. The picker still marks only real conversations as "Open chat". - **Chat side panel:** a new default Tasks tab shows one card per task the agent created, was assigned, commented on, or acted on, newest first. It has the task list's filter popover and a sort control. **+ → Artifacts** shows the agent's artifacts as cards. Cards open in a new tab. Agent Chat off keeps the old Artifacts tab. - **Artifacts API:** `GET /api/companies/:companyId/artifacts` accepts `agentId`. The filter applies to documents, work products, and attachments by the agent each result is attributed to. The shared validator and the UI client carry the new parameter, and the OpenAPI entry picks it up from the shared schema. - **Combined Inbox + Task List flag (`enableCombinedInboxTasks`, off by default):** new card in Settings > Experimental. The Inbox row goes away and its badge moves to Tasks. A Views menu on `/issues` covers Mine, Unread, Blocked, Recent, Everything, All, Active, Backlog, and Done. Bare `/issues` opens the last-used view (default Mine). Links that carry `assignee`, `workspace`, `participantAgentId`, or `q` open All so the filter is kept. `/inbox/*` and `/issues/{all,active,backlog,done,recent}` redirect to the matching view. `/inbox/requests` stays its own page. - **Task detail breadcrumb:** the view key now decides the source, so quick-archive still works after a reload from an inbox view. - **Docs:** `doc/PRODUCT.md` and `doc/SPEC.md` describe the chat rail, the chat side panel, and the new flag. ## Verification - `cd ui && npx vitest run --no-file-parallelism src/components/chat src/components/task-side-panel/TaskSidePanel.test.tsx src/components/AgentConversationsSidebar.test.tsx src/components/Sidebar.test.tsx src/components/SidebarCompanyMenu.test.tsx src/components/Layout.test.tsx src/pages/AgentChats.test.tsx src/pages/InstanceExperimentalSettings.test.tsx src/lib/task-views.test.ts src/lib/issueDetailBreadcrumb.test.ts src/pages/Inbox.test.tsx src/pages/Issues.test.tsx src/App.test.tsx src/App.activity-routing.test.tsx src/components/MobileBottomNav.test.tsx src/components/CommandPalette.test.tsx`: 20 files, 356 tests pass. - `cd server && npx vitest run src/__tests__/company-artifacts-service.test.ts`: 13/13 pass, including the new agent-filter test across all three artifact sources. - The new rail test fails against the unmodified rail. - `pnpm check:token-gates`: all gates clean. - Manual: enable Agent Chat in Settings > Experimental. Open Chat. The rail lists all agents. Open a chat. The side panel shows the agent's tasks. Use **+ → Artifacts** to see the agent's artifacts. Then enable Combined Inbox + Task List. The Inbox row goes away, and Tasks shows a Views menu. - Snapshot baselines are intentionally not updated. See `doc/design/DECISION-SHEET.md`, "Per-change snapshot verification demoted to dormant (Jul 13 2026)". ## Risks - With both flags off, the app behaves like master. The only exception is the API: it accepts a new optional query parameter. - With Agent Chat on, the rail can list many agents in a large company. It uses the agent list the app already loads, and search filters it. - The Tasks panel reads at most 200 recently updated tasks per agent and says so when it reaches the limit. The Artifacts panel reads at most 500 of the agent's artifacts. - Combined Inbox + Task List changes what bare `/issues` opens for people who enable it. Deep links with a task filter still open All. ## Model Used - Claude (Anthropic), model ID `claude-opus-5-5`, through Claude Code with tool use (shell, file edit, test runs). Extended thinking was enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: scotttong <squadbot000@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
286 lines
10 KiB
TypeScript
286 lines
10 KiB
TypeScript
import type { Issue } from "@paperclipai/shared";
|
|
import { TASK_VIEW_PARAM, normalizeTaskViewKey, taskView } from "./task-views";
|
|
|
|
type IssueDetailSource = "issues" | "inbox";
|
|
|
|
type IssueDetailBreadcrumb = {
|
|
label: string;
|
|
href: string;
|
|
};
|
|
|
|
export type IssueDetailHeaderSeed = {
|
|
id: string;
|
|
identifier: string | null;
|
|
title: string;
|
|
status: string;
|
|
blockerAttention?: Issue["blockerAttention"];
|
|
priority: string;
|
|
projectId: string | null;
|
|
projectName: string | null;
|
|
originKind?: string;
|
|
originId?: string | null;
|
|
};
|
|
|
|
type IssueDetailHeaderSeedSource = Pick<Issue, "id" | "title"> & {
|
|
identifier?: string | null;
|
|
status: string;
|
|
blockerAttention?: Issue["blockerAttention"];
|
|
priority: string;
|
|
projectId?: string | null;
|
|
project?: { name?: string | null } | null;
|
|
originKind?: string;
|
|
originId?: string | null;
|
|
};
|
|
|
|
type IssueDetailLocationState = {
|
|
issueDetailBreadcrumb?: IssueDetailBreadcrumb;
|
|
issueDetailSource?: IssueDetailSource;
|
|
issueDetailInboxQuickArchiveArmed?: boolean;
|
|
issueDetailHeaderSeed?: IssueDetailHeaderSeed;
|
|
};
|
|
|
|
const ISSUE_DETAIL_SOURCE_QUERY_PARAM = "from";
|
|
const ISSUE_DETAIL_BREADCRUMB_HREF_QUERY_PARAM = "fromHref";
|
|
const ISSUE_DETAIL_STORAGE_KEY_PREFIX = "paperclip:issue-detail-breadcrumb:";
|
|
|
|
function isIssueDetailBreadcrumb(value: unknown): value is IssueDetailBreadcrumb {
|
|
if (typeof value !== "object" || value === null) return false;
|
|
const candidate = value as Partial<IssueDetailBreadcrumb>;
|
|
return typeof candidate.label === "string" && typeof candidate.href === "string";
|
|
}
|
|
|
|
function isIssueDetailSource(value: unknown): value is IssueDetailSource {
|
|
return value === "issues" || value === "inbox";
|
|
}
|
|
|
|
function isIssueDetailHeaderSeed(value: unknown): value is IssueDetailHeaderSeed {
|
|
if (typeof value !== "object" || value === null) return false;
|
|
const candidate = value as Partial<IssueDetailHeaderSeed>;
|
|
const hasOriginKind =
|
|
candidate.originKind === undefined || typeof candidate.originKind === "string";
|
|
const hasOriginId =
|
|
candidate.originId === undefined || candidate.originId === null || typeof candidate.originId === "string";
|
|
const hasBlockerAttention =
|
|
candidate.blockerAttention === undefined
|
|
|| (typeof candidate.blockerAttention === "object" && candidate.blockerAttention !== null);
|
|
return (
|
|
typeof candidate.id === "string"
|
|
&& (candidate.identifier === null || typeof candidate.identifier === "string")
|
|
&& typeof candidate.title === "string"
|
|
&& typeof candidate.status === "string"
|
|
&& hasBlockerAttention
|
|
&& typeof candidate.priority === "string"
|
|
&& (candidate.projectId === null || typeof candidate.projectId === "string")
|
|
&& (candidate.projectName === null || typeof candidate.projectName === "string")
|
|
&& hasOriginKind
|
|
&& hasOriginId
|
|
);
|
|
}
|
|
|
|
function createIssueDetailHeaderSeed(issue: IssueDetailHeaderSeedSource): IssueDetailHeaderSeed {
|
|
return {
|
|
id: issue.id,
|
|
identifier: issue.identifier ?? null,
|
|
title: issue.title,
|
|
status: issue.status,
|
|
blockerAttention: issue.blockerAttention,
|
|
priority: issue.priority,
|
|
projectId: issue.projectId ?? null,
|
|
projectName: issue.project?.name ?? null,
|
|
originKind: issue.originKind,
|
|
originId: issue.originId ?? null,
|
|
};
|
|
}
|
|
|
|
export function withIssueDetailHeaderSeed(state: unknown, issue: IssueDetailHeaderSeedSource): IssueDetailLocationState {
|
|
const headerSeed = createIssueDetailHeaderSeed(issue);
|
|
if (typeof state !== "object" || state === null) {
|
|
return { issueDetailHeaderSeed: headerSeed };
|
|
}
|
|
|
|
return {
|
|
...(state as IssueDetailLocationState),
|
|
issueDetailHeaderSeed: headerSeed,
|
|
};
|
|
}
|
|
|
|
export function readIssueDetailHeaderSeed(state: unknown): IssueDetailHeaderSeed | null {
|
|
if (typeof state !== "object" || state === null) return null;
|
|
const candidate = (state as IssueDetailLocationState).issueDetailHeaderSeed;
|
|
return isIssueDetailHeaderSeed(candidate) ? candidate : null;
|
|
}
|
|
|
|
function readIssueDetailSource(state: unknown): IssueDetailSource | null {
|
|
if (typeof state !== "object" || state === null) return null;
|
|
const source = (state as IssueDetailLocationState).issueDetailSource;
|
|
return isIssueDetailSource(source) ? source : null;
|
|
}
|
|
|
|
function readIssueDetailSourceFromSearch(search?: string): IssueDetailSource | null {
|
|
if (!search) return null;
|
|
const params = new URLSearchParams(search);
|
|
const source = params.get(ISSUE_DETAIL_SOURCE_QUERY_PARAM);
|
|
return isIssueDetailSource(source) ? source : null;
|
|
}
|
|
|
|
function readIssueDetailBreadcrumbHrefFromSearch(search?: string): string | null {
|
|
if (!search) return null;
|
|
const params = new URLSearchParams(search);
|
|
const href = params.get(ISSUE_DETAIL_BREADCRUMB_HREF_QUERY_PARAM);
|
|
return href && href.startsWith("/") ? href : null;
|
|
}
|
|
|
|
export function isInboxBackedTaskViewHref(href: string): boolean {
|
|
const query = href.slice(href.indexOf("?") + 1);
|
|
if (!href.includes("?")) return false;
|
|
const view = new URLSearchParams(query).get(TASK_VIEW_PARAM);
|
|
const key = normalizeTaskViewKey(view);
|
|
return key !== null && taskView(key).surface === "inbox";
|
|
}
|
|
|
|
function inferIssueDetailSource(
|
|
state: Partial<IssueDetailLocationState> | null,
|
|
breadcrumb: IssueDetailBreadcrumb | null,
|
|
): IssueDetailSource | null {
|
|
if (isIssueDetailSource(state?.issueDetailSource)) return state.issueDetailSource;
|
|
if (!breadcrumb) return null;
|
|
if (breadcrumb.href.includes("/inbox")) return "inbox";
|
|
// Since PAP-670 the inbox is a set of views on /issues, so the href alone no
|
|
// longer separates the two sources — the view key does.
|
|
if (isInboxBackedTaskViewHref(breadcrumb.href)) return "inbox";
|
|
if (breadcrumb.label === "Inbox") return "inbox";
|
|
if (breadcrumb.label === "Tasks" || breadcrumb.href.includes("/issues")) return "issues";
|
|
return null;
|
|
}
|
|
|
|
function breadcrumbForSource(source: IssueDetailSource): IssueDetailBreadcrumb {
|
|
if (source === "inbox") return { label: "Inbox", href: "/inbox" };
|
|
return { label: "Tasks", href: "/issues" };
|
|
}
|
|
|
|
export function createIssueDetailLocationState(
|
|
label: string,
|
|
href: string,
|
|
source?: IssueDetailSource,
|
|
): IssueDetailLocationState {
|
|
return {
|
|
issueDetailBreadcrumb: { label, href },
|
|
issueDetailSource: source,
|
|
};
|
|
}
|
|
|
|
export function armIssueDetailInboxQuickArchive(state: unknown): IssueDetailLocationState {
|
|
if (typeof state !== "object" || state === null) {
|
|
return { issueDetailInboxQuickArchiveArmed: true };
|
|
}
|
|
|
|
return {
|
|
...(state as IssueDetailLocationState),
|
|
issueDetailInboxQuickArchiveArmed: true,
|
|
};
|
|
}
|
|
|
|
function readStoredIssueDetailLocationState(issuePathId: string): IssueDetailLocationState | null {
|
|
if (typeof window === "undefined" || !window.sessionStorage) return null;
|
|
|
|
const raw = window.sessionStorage.getItem(`${ISSUE_DETAIL_STORAGE_KEY_PREFIX}${issuePathId}`);
|
|
if (!raw) return null;
|
|
|
|
try {
|
|
const parsed = JSON.parse(raw) as Partial<IssueDetailLocationState>;
|
|
const breadcrumb = isIssueDetailBreadcrumb(parsed.issueDetailBreadcrumb)
|
|
? parsed.issueDetailBreadcrumb
|
|
: null;
|
|
const source = inferIssueDetailSource(parsed, breadcrumb);
|
|
if (!breadcrumb || !source) return null;
|
|
const headerSeed = isIssueDetailHeaderSeed(parsed.issueDetailHeaderSeed)
|
|
? parsed.issueDetailHeaderSeed
|
|
: undefined;
|
|
return {
|
|
issueDetailBreadcrumb: breadcrumb,
|
|
issueDetailSource: source,
|
|
issueDetailInboxQuickArchiveArmed: parsed.issueDetailInboxQuickArchiveArmed === true,
|
|
issueDetailHeaderSeed: headerSeed,
|
|
};
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
function normalizeIssueDetailLocationState(
|
|
state: unknown,
|
|
search?: string,
|
|
): IssueDetailLocationState | null {
|
|
if (typeof state === "object" && state !== null) {
|
|
const candidate = (state as IssueDetailLocationState).issueDetailBreadcrumb;
|
|
if (isIssueDetailBreadcrumb(candidate)) {
|
|
const source = inferIssueDetailSource(state as Partial<IssueDetailLocationState>, candidate);
|
|
if (!source) return null;
|
|
const headerSeed = readIssueDetailHeaderSeed(state) ?? undefined;
|
|
return {
|
|
issueDetailBreadcrumb: candidate,
|
|
issueDetailSource: source,
|
|
issueDetailInboxQuickArchiveArmed:
|
|
(state as IssueDetailLocationState).issueDetailInboxQuickArchiveArmed === true,
|
|
issueDetailHeaderSeed: headerSeed,
|
|
};
|
|
}
|
|
}
|
|
|
|
const source = readIssueDetailSourceFromSearch(search);
|
|
const href = readIssueDetailBreadcrumbHrefFromSearch(search);
|
|
if (!source) return null;
|
|
|
|
return {
|
|
issueDetailBreadcrumb: href ? { ...breadcrumbForSource(source), href } : breadcrumbForSource(source),
|
|
issueDetailSource: source,
|
|
issueDetailInboxQuickArchiveArmed: false,
|
|
};
|
|
}
|
|
|
|
export function rememberIssueDetailLocationState(issuePathId: string, state: unknown, search?: string): void {
|
|
if (typeof window === "undefined" || !window.sessionStorage) return;
|
|
|
|
const normalized = normalizeIssueDetailLocationState(state, search);
|
|
if (!normalized) return;
|
|
|
|
window.sessionStorage.setItem(
|
|
`${ISSUE_DETAIL_STORAGE_KEY_PREFIX}${issuePathId}`,
|
|
JSON.stringify(normalized),
|
|
);
|
|
}
|
|
|
|
export function createIssueDetailPath(issuePathId: string): string {
|
|
return `/issues/${issuePathId}`;
|
|
}
|
|
|
|
export function hasLegacyIssueDetailQuery(search?: string): boolean {
|
|
if (!search) return false;
|
|
const params = new URLSearchParams(search);
|
|
return params.has(ISSUE_DETAIL_SOURCE_QUERY_PARAM) || params.has(ISSUE_DETAIL_BREADCRUMB_HREF_QUERY_PARAM);
|
|
}
|
|
|
|
export function readIssueDetailLocationState(
|
|
issuePathId: string | null | undefined,
|
|
state: unknown,
|
|
search?: string,
|
|
): IssueDetailLocationState | null {
|
|
const normalized = normalizeIssueDetailLocationState(state, search);
|
|
if (normalized) return normalized;
|
|
if (!issuePathId) return null;
|
|
return readStoredIssueDetailLocationState(issuePathId);
|
|
}
|
|
|
|
export function readIssueDetailBreadcrumb(
|
|
issuePathId: string | null | undefined,
|
|
state: unknown,
|
|
search?: string,
|
|
): IssueDetailBreadcrumb | null {
|
|
return readIssueDetailLocationState(issuePathId, state, search)?.issueDetailBreadcrumb ?? null;
|
|
}
|
|
|
|
export function shouldArmIssueDetailInboxQuickArchive(state: unknown): boolean {
|
|
if (typeof state !== "object" || state === null) return false;
|
|
return (state as IssueDetailLocationState).issueDetailInboxQuickArchiveArmed === true;
|
|
}
|