mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-23 09:07:46 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - People rate agent comments and documents to capture feedback. > - Feedback bundles remove credentials and personal information before export. > - The feedback scanner treats ordinary dotted text as JWTs and authentication terms as bearer tokens. > - This pull request checks encoded JWT headers and preserves known authentication terms. > - The benefit is readable feedback context with credential masking kept in place. ## Linked Issues or Issue Description Refs #12309 for the related dotted-identifier false-positive report. This PR fixes the separate feedback scanner. It does not close every case in that report. Related PR: #14318 adds fine-grained GitHub token coverage. It addresses a separate credential form and is not duplicated here. **What happened?** Feedback exports replace `api.openai.com`, dotted filenames, and public schema IDs with a JWT placeholder. They also replace the words after `bearer` in phrases such as “bearer tokens.” Five-part encrypted JWTs are only partly masked. **Expected behavior** Keep public identifiers and authentication terms readable. Mask complete credential tokens. Count only text replacements in the redaction summary. **Steps to reproduce** 1. Pass `api.openai.com` or `Use bearer tokens.` to `sanitizeFeedbackText`. 2. Check that the original text is returned and the redaction counts stay empty. 3. Pass a signed JWT or an encrypted JWT to the same function. 4. Check that the full token is replaced and one JWT replacement is counted. **Paperclip version or commit** Reproduced in the feedback scanner on master at `5e8e992df2b3d71f82091b7bbf29fd482854d9f5`. **Deployment mode** Built from source. The defect is in the shared feedback export service and does not depend on deployment mode. ## What Changed - Use the existing JWT header predicate in the feedback scanner. - Match complete three-part and five-part tokens, including direct-encryption tokens with an empty key segment. Accept short token segments in the predicate. - Preserve the closed set of authentication terms already used by the general scanner, including terms inside closing prose delimiters. - Count only replacements that change the text. - Add tests for readable context, credential masking, nested values, and redaction counts. - Document feedback text redaction. ## Verification - Focused redaction and feedback service tests: 89 tests pass across five suites. - `pnpm --filter @paperclipai/adapter-utils typecheck` passes. Full local typecheck, tests, and build were attempted. The kernel killed compiler and test processes at the sandbox memory limit of 4 GB. Serial retries and a capped Node heap still could not complete the server compiler. CI runs the full repository checks. - `git diff --check` passes. - Latest commit `0eb8d3fb4257bb79e67fab615a8299ef69230ad8`: **55 checks passed**, including full typecheck, tests, build, and E2E; two optional Storybook checks were skipped. [CI evidence](https://github.com/paperclipai/paperclip/actions/runs/38407932875). Both Greptile findings have regression tests and fixes. [Greptile gives this commit 5/5](https://github.com/paperclipai/paperclip/pull/16168#issuecomment-6146917423), with both review threads resolved. ## Risks - This changes the feedback export matching rules. Public dotted text no longer triggers credential masking by shape alone. - Explicit credential assignments, provider keys, structured secret fields, email addresses, and phone numbers remain masked. Tests cover these cases. - Existing feedback snapshots are not rewritten. No schema change or migration is needed. - The encoded-header check remains a heuristic. It is not a full JWT validator. ## Model Used OpenAI Codex, GPT-6, with reasoning, tool use, and code execution. The runtime identifies the model as GPT-6. It does not expose the exact provider deployment ID or context window size. The earlier patch and this PR preparation were AI-assisted. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
197 lines
6.2 KiB
TypeScript
197 lines
6.2 KiB
TypeScript
import { createHash } from "node:crypto";
|
|
import { looksLikeCredentialJwt } from "@paperclipai/adapter-utils/command-redaction";
|
|
import { redactCurrentUserText } from "../log-redaction.js";
|
|
import { sanitizeRecord } from "../redaction.js";
|
|
|
|
export type FeedbackRedactionState = {
|
|
redactedFields: Set<string>;
|
|
truncatedFields: Set<string>;
|
|
omittedFields: Set<string>;
|
|
notes: Set<string>;
|
|
counts: Map<string, number>;
|
|
};
|
|
|
|
type PatternReplacement = string | ((match: string, ...args: string[]) => string);
|
|
|
|
type RedactionPattern = {
|
|
kind: string;
|
|
regex: RegExp;
|
|
replacement: PatternReplacement;
|
|
};
|
|
|
|
const SECRET_ASSIGNMENT_RE =
|
|
/\b(api[-_]?key|access[-_]?token|auth(?:_?token)?|authorization|bearer|secret|passwd|password|credential|jwt|private[-_]?key|cookie|connectionstring)\s*[:=]\s*([^\s,;]+)/gi;
|
|
|
|
const FREE_TEXT_PATTERNS: RedactionPattern[] = [
|
|
{
|
|
kind: "pem_block",
|
|
regex: /-----BEGIN [^-]+-----[\s\S]+?-----END [^-]+-----/g,
|
|
replacement: "[REDACTED_PEM_BLOCK]",
|
|
},
|
|
{
|
|
kind: "secret_assignment",
|
|
regex: SECRET_ASSIGNMENT_RE,
|
|
replacement: (_match, key: string) => `${key}=[REDACTED]`,
|
|
},
|
|
{
|
|
kind: "bearer_token",
|
|
regex: /\bBearer\s+(?!(?:tokens?|authentication|authorization|credentials?|schemes?|flows?)[.,;:!?]?(?:\s|[)\]}]|$))[A-Za-z0-9._~+/-]+=*/gi,
|
|
replacement: "Bearer [REDACTED_TOKEN]",
|
|
},
|
|
{
|
|
kind: "github_token",
|
|
regex: /\bgh[pousr]_[A-Za-z0-9_]{20,}\b/g,
|
|
replacement: "[REDACTED_GITHUB_TOKEN]",
|
|
},
|
|
{
|
|
kind: "provider_api_key",
|
|
regex: /\bsk-(?:ant-)?[A-Za-z0-9_-]{12,}\b/g,
|
|
replacement: "[REDACTED_API_KEY]",
|
|
},
|
|
{
|
|
kind: "jwt",
|
|
regex: /\b[A-Za-z0-9_-]+(?:\.[A-Za-z0-9_-]*\.[A-Za-z0-9_-]+\.[A-Za-z0-9_-]+\.[A-Za-z0-9_-]+|\.[A-Za-z0-9_-]+\.[A-Za-z0-9_-]+)\b/g,
|
|
replacement: (match) => looksLikeCredentialJwt(match) ? "[REDACTED_JWT]" : match,
|
|
},
|
|
{
|
|
kind: "dsn",
|
|
regex: /\b(?:postgres(?:ql)?|mysql|mongodb(?:\+srv)?|redis|amqp|kafka|nats|mssql):\/\/[^\s<>'")]+/gi,
|
|
replacement: "[REDACTED_CONNECTION_STRING]",
|
|
},
|
|
{
|
|
kind: "email",
|
|
regex: /\b[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,}\b/gi,
|
|
replacement: "[REDACTED_EMAIL]",
|
|
},
|
|
{
|
|
kind: "phone",
|
|
regex: /(?<!\w)(?:\+?\d[\d ()-]{7,}\d)(?!\w)/g,
|
|
replacement: "[REDACTED_PHONE]",
|
|
},
|
|
];
|
|
|
|
function isPlainRecord(value: unknown): value is Record<string, unknown> {
|
|
return typeof value === "object" && value !== null && !Array.isArray(value);
|
|
}
|
|
|
|
function increment(state: FeedbackRedactionState, kind: string, count: number) {
|
|
if (count <= 0) return;
|
|
state.counts.set(kind, (state.counts.get(kind) ?? 0) + count);
|
|
}
|
|
|
|
function recordField(state: FeedbackRedactionState, fieldPath: string) {
|
|
if (fieldPath.trim().length === 0) return;
|
|
state.redactedFields.add(fieldPath);
|
|
}
|
|
|
|
function applyPattern(input: string, pattern: RedactionPattern) {
|
|
let matches = 0;
|
|
const output = input.replace(pattern.regex, (match: string, ...args: string[]) => {
|
|
const replacement = typeof pattern.replacement === "function"
|
|
? pattern.replacement(match, ...args)
|
|
: pattern.replacement;
|
|
if (replacement !== match) matches += 1;
|
|
return replacement;
|
|
});
|
|
pattern.regex.lastIndex = 0;
|
|
return { output, matches };
|
|
}
|
|
|
|
export function createFeedbackRedactionState(): FeedbackRedactionState {
|
|
return {
|
|
redactedFields: new Set<string>(),
|
|
truncatedFields: new Set<string>(),
|
|
omittedFields: new Set<string>(),
|
|
notes: new Set<string>(),
|
|
counts: new Map<string, number>(),
|
|
};
|
|
}
|
|
|
|
export function sanitizeFeedbackText(
|
|
input: string,
|
|
state: FeedbackRedactionState,
|
|
fieldPath: string,
|
|
maxLength: number,
|
|
) {
|
|
let output = redactCurrentUserText(input);
|
|
if (output !== input) {
|
|
recordField(state, fieldPath);
|
|
increment(state, "current_user", 1);
|
|
}
|
|
|
|
for (const pattern of FREE_TEXT_PATTERNS) {
|
|
const result = applyPattern(output, pattern);
|
|
if (result.matches > 0) {
|
|
output = result.output;
|
|
recordField(state, fieldPath);
|
|
increment(state, pattern.kind, result.matches);
|
|
}
|
|
}
|
|
|
|
if (output.length > maxLength) {
|
|
output = `${output.slice(0, Math.max(0, maxLength - 1))}...`;
|
|
state.truncatedFields.add(fieldPath);
|
|
}
|
|
|
|
return output;
|
|
}
|
|
|
|
export function sanitizeFeedbackValue(
|
|
value: unknown,
|
|
state: FeedbackRedactionState,
|
|
fieldPath: string,
|
|
maxStringLength: number,
|
|
): unknown {
|
|
if (typeof value === "string") {
|
|
return sanitizeFeedbackText(value, state, fieldPath, maxStringLength);
|
|
}
|
|
if (Array.isArray(value)) {
|
|
return value.map((entry, index) =>
|
|
sanitizeFeedbackValue(entry, state, `${fieldPath}[${index}]`, maxStringLength));
|
|
}
|
|
if (!isPlainRecord(value)) {
|
|
return value;
|
|
}
|
|
|
|
const structurallySanitized = sanitizeRecord(value);
|
|
if (stableStringify(structurallySanitized) !== stableStringify(value)) {
|
|
recordField(state, fieldPath);
|
|
increment(state, "structured_secret", 1);
|
|
}
|
|
|
|
const output: Record<string, unknown> = {};
|
|
for (const [key, entry] of Object.entries(structurallySanitized)) {
|
|
output[key] = sanitizeFeedbackValue(entry, state, `${fieldPath}.${key}`, maxStringLength);
|
|
}
|
|
return output;
|
|
}
|
|
|
|
export function finalizeFeedbackRedactionSummary(state: FeedbackRedactionState) {
|
|
return {
|
|
strategy: "deterministic_feedback_v2",
|
|
redactedFields: Array.from(state.redactedFields).sort(),
|
|
truncatedFields: Array.from(state.truncatedFields).sort(),
|
|
omittedFields: Array.from(state.omittedFields).sort(),
|
|
notes: Array.from(state.notes).sort(),
|
|
counts: Object.fromEntries(Array.from(state.counts.entries()).sort(([left], [right]) => left.localeCompare(right))),
|
|
} satisfies Record<string, unknown>;
|
|
}
|
|
|
|
export function stableStringify(value: unknown): string {
|
|
if (value === null || typeof value !== "object") {
|
|
return JSON.stringify(value);
|
|
}
|
|
if (Array.isArray(value)) {
|
|
return `[${value.map((entry) => stableStringify(entry)).join(",")}]`;
|
|
}
|
|
|
|
const entries = Object.entries(value as Record<string, unknown>)
|
|
.sort(([left], [right]) => left.localeCompare(right))
|
|
.map(([key, entry]) => `${JSON.stringify(key)}:${stableStringify(entry)}`);
|
|
return `{${entries.join(",")}}`;
|
|
}
|
|
|
|
export function sha256Digest(value: unknown) {
|
|
return createHash("sha256").update(stableStringify(value)).digest("hex");
|
|
}
|