mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-17 10:06:42 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Governed MCP access spans contracts, runtime enforcement, adapters, UI surfaces, and operator verification > - The parity reference PR #9534 is too large for effective automated or human review > - The feature therefore needs a linear stack whose individual diffs stay below the 100-file review limit > - This pull request is split 6/8 and focuses on UI API, shared components, and Tools/Profile surfaces > - The benefit is a standalone, testable review boundary while preserving byte-for-byte parity at the top of the stack ## Linked Issues or Issue Description - Related parity reference: #9534 - Problem: Operators need typed clients and administration surfaces that compile independently before navigation exposes them. - Proposed solution: Adds UI APIs, hooks, libraries, shared components, Tools/Profiles pages, and the plugin settings consumer required by the new company-scoped API. - Alternatives considered: keeping #9534 as one 403-file review, or rewriting the feature to manufacture seams; both were rejected in favor of path extraction plus compile-driven boundary moves. - Roadmap alignment: this advances the existing governed MCP/tool-access work already represented by #9534; it does not introduce a separate roadmap initiative. - Stack position: base branch is `pap10341-split/05-runtime-integration`. - Merge policy: merge bottom-up, in order, only after the complete eight-PR stack has been reviewed and the top-of-stack parity gate remains empty. - Requested review: UXDesigner sanity pass on Tools/Profile surfaces; Greptile on every PR. ## What Changed - Adds UI APIs, hooks, libraries, shared components, Tools/Profiles pages, and the plugin settings consumer required by the new company-scoped API. - Keeps this PR below 100 changed files and independently typecheckable. - Preserves the final tree from #9534 when combined with the other seven stack levels. ## Verification - `pnpm typecheck` - `pnpm check:token-gates` — all gates clean - Focused UI Vitest run with `NODE_ENV=test` — 28 files, 183 tests passed ## Risks - Large dead-code UI additions can drift from activation routes; PR 7 supplies the registration layer and top-level parity catches omissions. - Stack risk: merging out of order can expose incomplete layers; mitigate by following the documented bottom-up merge policy. - Parity risk: later edits to an intermediate branch can drift from #9534; mitigate by re-running the empty top-of-stack diff before merge. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, exact model ID `gpt-5.4`; runtime-managed context window; medium reasoning with repository, shell, Git, GitHub CLI, and code-execution tools enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] Internal references are omitted except the execution-plan link explicitly required for this coordinated split stack - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge ## Stack Coordination - Internal execution plan: [PAP-13874](/PAP/issues/PAP-13874#document-plan) - Parity reference: #9534 - Stack: #9556 → #9557 → #9558 → #9559 → #9560 → #9561 → #9562 → #9563 - Merge bottom-up only after full-stack review and an empty parity diff at #9563. ## UI Evidence QA captured these from the live Garden MCP split stack at 1440px and verified clean rendering:    --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
41 lines
1.6 KiB
TypeScript
41 lines
1.6 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { redactUrlSecrets } from "./redact-url-secrets";
|
|
|
|
describe("redactUrlSecrets", () => {
|
|
it("redacts credential-like query parameters while preserving useful URL context", () => {
|
|
expect(
|
|
redactUrlSecrets("https://mcp.zapier.com/api/v1/connect?token=zapier-secret®ion=us"),
|
|
).toBe("https://mcp.zapier.com/api/v1/connect?token=REDACTED®ion=us");
|
|
});
|
|
|
|
it("redacts common credential names case-insensitively", () => {
|
|
expect(
|
|
redactUrlSecrets("https://example.test/mcp?API_KEY=secret&access-token=other&mode=read"),
|
|
).toBe("https://example.test/mcp?API_KEY=REDACTED&access-token=REDACTED&mode=read");
|
|
});
|
|
|
|
it("redacts URL user info and credential-like hash parameters", () => {
|
|
expect(
|
|
redactUrlSecrets("mcp+https://user:password@example.test/connect#access_token=secret&state=safe"),
|
|
).toBe("mcp+https://REDACTED@example.test/connect#access_token=REDACTED&state=REDACTED");
|
|
});
|
|
|
|
it("redacts OAuth callback parameters", () => {
|
|
expect(
|
|
redactUrlSecrets("https://example.test/oauth/callback?code=secret&state=opaque&nonce=once"),
|
|
).toBe("https://example.test/oauth/callback?code=REDACTED&state=REDACTED&nonce=REDACTED");
|
|
});
|
|
|
|
it("falls back to masking secret assignments in non-standard URL text", () => {
|
|
expect(redactUrlSecrets("connect to host?token=secret value")).toBe(
|
|
"connect to host?token=REDACTED value",
|
|
);
|
|
});
|
|
|
|
it("leaves ordinary URLs unchanged", () => {
|
|
expect(redactUrlSecrets("https://example.test/mcp?workspace=paperclip&page=2")).toBe(
|
|
"https://example.test/mcp?workspace=paperclip&page=2",
|
|
);
|
|
});
|
|
});
|