mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-18 15:39:47 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Issues use `in_review` to request a final decision from an authorized writer > - The server rejected an assignee agent that tried to close its own review, even when the issue had no independent-review rule > - This rejection stopped the default agent workflow and did not represent the configured execution-stage rules > - Paperclip needs an open default and explicit issue-level constraints for teams that require an independent or human verdict > - This pull request removes the unconditional rejection and adds `anyone`, `not_creator`, and `human_only` review policies > - The benefit is a working default path with opt-in, authenticated verdict controls ## Linked Issues or Issue Description Refs #10635, #4429, and #10671. The related public work covers execution-stage independence, self-approval fallback behavior, and durable review paths. This change is distinct. It controls who can resolve an issue review verdict. It keeps configured execution stages active. ## What Changed - Added a nullable `review_policy` issue column. Null has the same meaning as `anyone`. The migration does not backfill existing issues. - Added shared create, update, response, and compact issue contracts for `anyone`, `not_creator`, and `human_only`. - Removed the unconditional agent self-approval rejection for `in_review` issues. - Added one reusable verdict-actor check for terminal status changes and pending interaction accept or reject actions. - Used the authenticated principal type for `human_only`. Agent keys and run tokens remain agent principals. - Used the latest transition into `in_review` to identify the requester for `not_creator`. - Added actionable 403 responses that name the policy, the allowed actor, and the next step. - Kept the configured execution-stage transition and signoff behavior. - Added focused contract, helper, status-route, interaction-route, and execution-stage regression tests. - Updated the implementation specification for the new issue field. ## Verification - `pnpm exec vitest run packages/shared/src/validators/issue.test.ts server/src/__tests__/issue-review-policy.test.ts server/src/__tests__/issue-stalled-review-decision-routes.test.ts --reporter=dot` passed: 42 tests. - `pnpm --filter @paperclipai/shared typecheck` passed. - `pnpm --filter @paperclipai/db typecheck` passed, including migration numbering and safety checks. - `pnpm --filter @paperclipai/server typecheck` passed. - `pnpm run typecheck:build-gaps` passed across server, CLI, plugin SDK/examples, plugin wiki, and UI. - `git diff --check origin/master...HEAD` passed. - SecurityEngineer review approved the authenticated-principal checks and accepted policy-relaxation tradeoff with no required changes. - Greptile reviewed the latest head at 5/5 with zero inline comments or follow-ups. - The latest-head GitHub rollup passed build, typecheck, server/workspace tests, serialized suites, canary, e2e, and external security checks. ## Risks - The migration adds one nullable text column. It has no default and no backfill. - `not_creator` reads the latest recorded transition into `in_review`. It denies the verdict when it cannot identify the requester. - Agents can change or relax `reviewPolicy` when they have issue write access. This is intentional for this issue-level control. - Null and `anyone` do not add a database query to the verdict path. - Configured execution-stage checks still run after the issue-level policy check. > This work aligns with the completed "Agent Reviews and Approvals" and "Enforced Outcomes" roadmap items. It does not add a new roadmap capability. ## Model Used - OpenAI Codex, GPT-5. The exact deployment ID and context-window size are not exposed to the agent. The run used reasoning, repository tools, code execution, and GitHub CLI access. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
221 lines
6.6 KiB
TypeScript
221 lines
6.6 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import {
|
|
armIssueDetailInboxQuickArchive,
|
|
createIssueDetailLocationState,
|
|
createIssueDetailPath,
|
|
hasLegacyIssueDetailQuery,
|
|
readIssueDetailHeaderSeed,
|
|
readIssueDetailLocationState,
|
|
readIssueDetailBreadcrumb,
|
|
rememberIssueDetailLocationState,
|
|
shouldArmIssueDetailInboxQuickArchive,
|
|
withIssueDetailHeaderSeed,
|
|
} from "./issueDetailBreadcrumb";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
|
|
const sessionStorageMock = (() => {
|
|
const store = new Map<string, string>();
|
|
return {
|
|
getItem: (key: string) => store.get(key) ?? null,
|
|
setItem: (key: string, value: string) => {
|
|
store.set(key, value);
|
|
},
|
|
clear: () => {
|
|
store.clear();
|
|
},
|
|
};
|
|
})();
|
|
|
|
Object.defineProperty(globalThis, "window", {
|
|
configurable: true,
|
|
value: { sessionStorage: sessionStorageMock },
|
|
});
|
|
|
|
describe("issueDetailBreadcrumb", () => {
|
|
function createIssue(overrides: Partial<Issue> = {}): Issue {
|
|
return {
|
|
id: "11111111-1111-4111-8111-111111111111",
|
|
companyId: "company-1",
|
|
projectId: "project-1",
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Prefilled issue title",
|
|
description: null,
|
|
status: "todo",
|
|
priority: "medium",
|
|
reviewPolicy: null,
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
responsibleUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: null,
|
|
issueNumber: 42,
|
|
identifier: "PAP-42",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionPolicy: null,
|
|
executionState: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
project: {
|
|
id: "project-1",
|
|
companyId: "company-1",
|
|
urlKey: "paperclip-app",
|
|
goalId: null,
|
|
goalIds: [],
|
|
goals: [],
|
|
name: "Paperclip App",
|
|
description: null,
|
|
status: "in_progress",
|
|
leadAgentId: null,
|
|
targetDate: null,
|
|
color: null,
|
|
icon: null,
|
|
env: null,
|
|
pauseReason: null,
|
|
pausedAt: null,
|
|
executionWorkspacePolicy: null,
|
|
codebase: {
|
|
workspaceId: null,
|
|
repoUrl: null,
|
|
repoRef: null,
|
|
defaultRef: null,
|
|
repoName: null,
|
|
localFolder: null,
|
|
managedFolder: "/tmp/paperclip-app",
|
|
effectiveLocalFolder: "/tmp/paperclip-app",
|
|
origin: "local_folder",
|
|
},
|
|
workspaces: [],
|
|
primaryWorkspace: null,
|
|
archivedAt: null,
|
|
createdAt: new Date(),
|
|
updatedAt: new Date(),
|
|
},
|
|
goal: null,
|
|
currentExecutionWorkspace: null,
|
|
workProducts: [],
|
|
mentionedProjects: [],
|
|
myLastTouchAt: null,
|
|
lastExternalCommentAt: null,
|
|
lastActivityAt: null,
|
|
isUnreadForMe: false,
|
|
createdAt: new Date(),
|
|
updatedAt: new Date(),
|
|
...overrides,
|
|
workMode: overrides.workMode ?? "standard",
|
|
};
|
|
}
|
|
|
|
it("returns clean issue detail paths", () => {
|
|
expect(createIssueDetailPath("PAP-465")).toBe("/issues/PAP-465");
|
|
});
|
|
|
|
it("prefers the full breadcrumb from route state", () => {
|
|
const state = createIssueDetailLocationState("Inbox", "/inbox/mine", "inbox");
|
|
|
|
expect(readIssueDetailBreadcrumb("PAP-465", state, "?from=issues")).toEqual({
|
|
label: "Inbox",
|
|
href: "/inbox/mine",
|
|
});
|
|
});
|
|
|
|
it("falls back to the source query param when route state is unavailable", () => {
|
|
expect(readIssueDetailBreadcrumb("PAP-465", null, "?from=inbox")).toEqual({
|
|
label: "Inbox",
|
|
href: "/inbox",
|
|
});
|
|
});
|
|
|
|
it("can detect legacy query-based breadcrumb links", () => {
|
|
expect(hasLegacyIssueDetailQuery("?from=inbox&fromHref=%2Finbox%2Fmine")).toBe(true);
|
|
expect(hasLegacyIssueDetailQuery("?q=test")).toBe(false);
|
|
});
|
|
|
|
it("restores the exact breadcrumb href from the query fallback", () => {
|
|
expect(
|
|
readIssueDetailBreadcrumb("PAP-465", null, "?from=inbox&fromHref=%2FPAP%2Finbox%2Funread"),
|
|
).toEqual({
|
|
label: "Inbox",
|
|
href: "/PAP/inbox/unread",
|
|
});
|
|
});
|
|
|
|
it("reads hidden breadcrumb context from session storage when route state is unavailable", () => {
|
|
const state = createIssueDetailLocationState("Inbox", "/inbox/mine", "inbox");
|
|
sessionStorageMock.clear();
|
|
rememberIssueDetailLocationState("PAP-465", state);
|
|
|
|
expect(
|
|
readIssueDetailLocationState("PAP-465", null),
|
|
).toEqual({
|
|
issueDetailBreadcrumb: { label: "Inbox", href: "/inbox/mine" },
|
|
issueDetailSource: "inbox",
|
|
issueDetailInboxQuickArchiveArmed: false,
|
|
});
|
|
});
|
|
|
|
it("attaches and reads issue header seed data from route state", () => {
|
|
const seededState = withIssueDetailHeaderSeed(
|
|
createIssueDetailLocationState("Issues", "/issues", "issues"),
|
|
createIssue(),
|
|
);
|
|
|
|
expect(readIssueDetailHeaderSeed(seededState)).toEqual({
|
|
id: "11111111-1111-4111-8111-111111111111",
|
|
identifier: "PAP-42",
|
|
title: "Prefilled issue title",
|
|
status: "todo",
|
|
priority: "medium",
|
|
projectId: "project-1",
|
|
projectName: "Paperclip App",
|
|
originKind: "manual",
|
|
originId: null,
|
|
});
|
|
});
|
|
|
|
it("persists issue header seed data when breadcrumb state is remembered", () => {
|
|
const seededState = withIssueDetailHeaderSeed(
|
|
createIssueDetailLocationState("Inbox", "/inbox/mine", "inbox"),
|
|
createIssue(),
|
|
);
|
|
|
|
sessionStorageMock.clear();
|
|
rememberIssueDetailLocationState("PAP-42", seededState);
|
|
|
|
const restoredState = readIssueDetailLocationState("PAP-42", null);
|
|
expect(readIssueDetailHeaderSeed(restoredState)).toEqual({
|
|
id: "11111111-1111-4111-8111-111111111111",
|
|
identifier: "PAP-42",
|
|
title: "Prefilled issue title",
|
|
status: "todo",
|
|
priority: "medium",
|
|
projectId: "project-1",
|
|
projectName: "Paperclip App",
|
|
originKind: "manual",
|
|
originId: null,
|
|
});
|
|
});
|
|
|
|
it("can arm quick archive only for explicit inbox keyboard entry state", () => {
|
|
const state = createIssueDetailLocationState("Inbox", "/inbox/mine", "inbox");
|
|
|
|
expect(shouldArmIssueDetailInboxQuickArchive(state)).toBe(false);
|
|
expect(shouldArmIssueDetailInboxQuickArchive(armIssueDetailInboxQuickArchive(state))).toBe(true);
|
|
});
|
|
});
|