mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-13 13:38:01 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The board UI has been graduating experimental conference-room task experiences into the default issue and onboarding flows > - Several task UI improvements were still coupled to the Conference Room Chat experimental flag even though they are useful outside chat itself > - That coupling meant disabling chat also reverted unrelated defaults such as work-mode labels, task status colors, team creation copy, and the graduated issue thread > - This pull request keeps chat-specific gating scoped to chat while making the graduated task UI the default experience > - The benefit is that operators can use the newer task workflows without needing to enable the separate chat experiment ## Linked Issues or Issue Description No public GitHub issue exists for this exact change. ### Problem or motivation The Conference Room Chat experimental flag was controlling unrelated task UI defaults, which made non-chat workflows regress when chat was disabled. ### Proposed solution Remove that flag from task-thread, work-mode, onboarding, status, and team-creation presentation paths while leaving chat-specific behavior separately gated. ### Alternatives considered Keeping the flag as a broad umbrella until chat graduates would avoid a behavior change, but it keeps unrelated UI improvements hidden behind the wrong capability switch. ### Roadmap alignment Checked `ROADMAP.md`; this is focused graduation/polish for existing UI surfaces rather than a new roadmap-level core feature. Related search: - Searched open PRs and issues for `conference room chat experimental flag`: no matches. - Searched open PRs and issues for `graduated issue thread`: no matches. ## What Changed - Removes Conference Room Chat flag branching from task-thread rendering, work-mode labels, task status colors, and team creation copy. - Makes the onboarding completion path create/reuse an onboarding project, create the first assigned task, and send the user to the dashboard instead of chat. - Deletes the legacy onboarding wizard and classic task-thread files now that the graduated flow is the default. - Updates focused UI tests and affected E2E specs for the default task experience. - Adds a user-visible onboarding error if restored state is missing the company or agent required for launch. ## Verification - `pnpm run preflight:workspace-links && pnpm exec vitest run ui/src/components/NewIssueDialog.test.tsx ui/src/components/OnboardingWizardVariant.test.tsx ui/src/components/RunChatSurface.test.tsx ui/src/components/SidebarCompanyMenu.test.tsx ui/src/components/StatusBadge.test.tsx ui/src/lib/agent-order.test.ts ui/src/lib/onboarding-launch.test.ts ui/src/lib/work-mode-meta.test.ts ui/src/pages/IssueDetail.test.tsx` - `pnpm --filter @paperclipai/ui typecheck` - `npx playwright test --config tests/e2e/playwright.config.ts --list tests/e2e/conference-room-typing-intro.spec.ts tests/e2e/planning-mode-visual-verification.spec.ts` - Attempted targeted Playwright execution locally, but this host is missing Chromium system libraries (`libatk1.0-0t64`, `libatspi2.0-0t64`, `libxcomposite1`, `libxdamage1`, `libxfixes3`, `libxrandr2`, `libgbm1`, `libasound2t64`). CI runs the specs in the proper Actions environment. ## Risks - Medium UI behavior risk: this intentionally changes the default experience for users who have not enabled Conference Room Chat. - Medium onboarding risk: completion now creates/reuses a project and creates the first task instead of only navigating. - Low migration risk: no database schema or migration changes are included. - The PR avoids `pnpm-lock.yaml` and `.github/workflows` changes. ## Model Used OpenAI Codex, GPT-5-class coding model, tool-enabled local repository workflow with shell, git, and test execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
182 lines
5.4 KiB
TypeScript
182 lines
5.4 KiB
TypeScript
import type { Agent } from "@paperclipai/shared";
|
|
|
|
export const AGENT_ORDER_UPDATED_EVENT = "paperclip:agent-order-updated";
|
|
export const AGENT_SORT_MODE_UPDATED_EVENT = "paperclip:agent-sort-mode-updated";
|
|
const AGENT_ORDER_STORAGE_PREFIX = "paperclip.agentOrder";
|
|
const AGENT_SORT_MODE_STORAGE_PREFIX = "paperclip.agentSortMode";
|
|
const ANONYMOUS_USER_ID = "anonymous";
|
|
|
|
export type AgentSidebarSortMode = "top" | "alphabetical" | "recent";
|
|
|
|
type AgentOrderUpdatedDetail = {
|
|
storageKey: string;
|
|
orderedIds: string[];
|
|
};
|
|
|
|
export type AgentSortModeUpdatedDetail = {
|
|
storageKey: string;
|
|
sortMode: AgentSidebarSortMode;
|
|
};
|
|
|
|
function normalizeIdList(value: unknown): string[] {
|
|
if (!Array.isArray(value)) return [];
|
|
return value.filter((item): item is string => typeof item === "string" && item.length > 0);
|
|
}
|
|
|
|
function normalizeSortMode(value: unknown): AgentSidebarSortMode {
|
|
return value === "alphabetical" || value === "recent" || value === "top" ? value : "top";
|
|
}
|
|
|
|
function resolveUserId(userId: string | null | undefined): string {
|
|
if (!userId) return ANONYMOUS_USER_ID;
|
|
const trimmed = userId.trim();
|
|
return trimmed.length > 0 ? trimmed : ANONYMOUS_USER_ID;
|
|
}
|
|
|
|
export function getAgentOrderStorageKey(companyId: string, userId: string | null | undefined): string {
|
|
return `${AGENT_ORDER_STORAGE_PREFIX}:${companyId}:${resolveUserId(userId)}`;
|
|
}
|
|
|
|
export function getAgentSortModeStorageKey(companyId: string, userId: string | null | undefined): string {
|
|
return `${AGENT_SORT_MODE_STORAGE_PREFIX}:${companyId}:${resolveUserId(userId)}`;
|
|
}
|
|
|
|
export function readAgentOrder(storageKey: string): string[] {
|
|
try {
|
|
const raw = localStorage.getItem(storageKey);
|
|
if (!raw) return [];
|
|
return normalizeIdList(JSON.parse(raw));
|
|
} catch {
|
|
return [];
|
|
}
|
|
}
|
|
|
|
export function readAgentSortMode(storageKey: string): AgentSidebarSortMode {
|
|
try {
|
|
return normalizeSortMode(localStorage.getItem(storageKey));
|
|
} catch {
|
|
return "top";
|
|
}
|
|
}
|
|
|
|
export function writeAgentOrder(storageKey: string, orderedIds: string[]) {
|
|
const normalized = normalizeIdList(orderedIds);
|
|
try {
|
|
localStorage.setItem(storageKey, JSON.stringify(normalized));
|
|
} catch {
|
|
// Ignore storage write failures in restricted browser contexts.
|
|
}
|
|
if (typeof window !== "undefined") {
|
|
window.dispatchEvent(
|
|
new CustomEvent<AgentOrderUpdatedDetail>(AGENT_ORDER_UPDATED_EVENT, {
|
|
detail: { storageKey, orderedIds: normalized },
|
|
}),
|
|
);
|
|
}
|
|
}
|
|
|
|
export function writeAgentSortMode(storageKey: string, sortMode: AgentSidebarSortMode) {
|
|
const normalized = normalizeSortMode(sortMode);
|
|
try {
|
|
localStorage.setItem(storageKey, normalized);
|
|
} catch {
|
|
// Ignore storage write failures in restricted browser contexts.
|
|
}
|
|
if (typeof window !== "undefined") {
|
|
window.dispatchEvent(
|
|
new CustomEvent<AgentSortModeUpdatedDetail>(AGENT_SORT_MODE_UPDATED_EVENT, {
|
|
detail: { storageKey, sortMode: normalized },
|
|
}),
|
|
);
|
|
}
|
|
}
|
|
|
|
// Leadership roles surface at the top of each sibling group so the company's
|
|
// lead (typically the freshly-hired CEO) is visible without scrolling the
|
|
// sidebar. Anything outside this list falls back to alphabetical.
|
|
const ROLE_SORT_PRIORITY: Record<string, number> = {
|
|
ceo: 0,
|
|
cto: 1,
|
|
cfo: 2,
|
|
cmo: 3,
|
|
};
|
|
|
|
function rolePriority(agent: Agent): number {
|
|
const role = typeof agent.role === "string" ? agent.role.toLowerCase() : "";
|
|
return ROLE_SORT_PRIORITY[role] ?? Number.MAX_SAFE_INTEGER;
|
|
}
|
|
|
|
export interface AgentSidebarOrderOptions {
|
|
/** Surface leadership roles (CEO/CTO/...) first within each sibling group. */
|
|
leadershipFirst?: boolean;
|
|
}
|
|
|
|
export function sortAgentsByDefaultSidebarOrder(
|
|
agents: Agent[],
|
|
options?: AgentSidebarOrderOptions,
|
|
): Agent[] {
|
|
if (agents.length === 0) return [];
|
|
|
|
const byId = new Map(agents.map((agent) => [agent.id, agent]));
|
|
const childrenOf = new Map<string | null, Agent[]>();
|
|
for (const agent of agents) {
|
|
const parentId = agent.reportsTo && byId.has(agent.reportsTo) ? agent.reportsTo : null;
|
|
const siblings = childrenOf.get(parentId) ?? [];
|
|
siblings.push(agent);
|
|
childrenOf.set(parentId, siblings);
|
|
}
|
|
|
|
const leadershipFirst = options?.leadershipFirst === true;
|
|
for (const siblings of childrenOf.values()) {
|
|
siblings.sort((left, right) => {
|
|
if (leadershipFirst) {
|
|
const priorityDiff = rolePriority(left) - rolePriority(right);
|
|
if (priorityDiff !== 0) return priorityDiff;
|
|
}
|
|
return left.name.localeCompare(right.name);
|
|
});
|
|
}
|
|
|
|
const sorted: Agent[] = [];
|
|
const queue = [...(childrenOf.get(null) ?? [])];
|
|
while (queue.length > 0) {
|
|
const agent = queue.shift();
|
|
if (!agent) continue;
|
|
sorted.push(agent);
|
|
const children = childrenOf.get(agent.id);
|
|
if (children) queue.push(...children);
|
|
}
|
|
|
|
return sorted;
|
|
}
|
|
|
|
export function sortAgentsByStoredOrder(
|
|
agents: Agent[],
|
|
orderedIds: string[],
|
|
options?: AgentSidebarOrderOptions,
|
|
): Agent[] {
|
|
if (agents.length === 0) return [];
|
|
|
|
const defaultSorted = sortAgentsByDefaultSidebarOrder(agents, options);
|
|
if (orderedIds.length === 0) return defaultSorted;
|
|
|
|
const byId = new Map(defaultSorted.map((agent) => [agent.id, agent]));
|
|
const sorted: Agent[] = [];
|
|
|
|
for (const id of orderedIds) {
|
|
const agent = byId.get(id);
|
|
if (!agent) continue;
|
|
sorted.push(agent);
|
|
byId.delete(id);
|
|
}
|
|
|
|
for (const agent of defaultSorted) {
|
|
if (byId.has(agent.id)) {
|
|
sorted.push(agent);
|
|
byId.delete(agent.id);
|
|
}
|
|
}
|
|
|
|
return sorted;
|
|
}
|