mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-17 21:34:48 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Remote agent runs start `paperclip-runnerd` inside a sandbox, such as a Daytona sandbox > - Agent boot time is a measured product constraint, and cold boot on Daytona grew from about 11 s to 25–75 s in restart-chaos waves > - The span that grew is `runner.artifact.prepare`: the controller uploaded its 31 MB `paperclip-runnerd` to every new sandbox > - The controller uploads this file whenever `PAPERCLIP_RUNNER_REMOTE_BINARY_PATH` is set, even when the sandbox image already has the same bytes > - The upload time depends on the sandbox file-upload throughput. That throughput changed from about 1 s to 5–48 s for the same 31 MB, on the same image and with no runner change > - This pull request makes the controller use the image's `paperclip-runnerd` when its SHA-256 equals the configured artifact > - The benefit is a cold boot that does not depend on sandbox upload throughput: about 9–11 s instead of 33–45 s in the same hour ## Linked Issues or Issue Description No issue exists. This describes the bug, following `.github/ISSUE_TEMPLATE/bug_report.yml`. **What happened?** Cold `agent_boot` on Daytona became 2–7 times slower. In restart-chaos waves on master `c5218f5ec4`, the cold boot p50 was about 11 s for claude, about 10 s for codex and 15–25 s for OpenCode. On master `3452639a81` it was 25 s, then 55 s, then 70–78 s for claude and codex over five waves. OpenCode reached 238–265 s. The run spans show that the extra time for every adapter is in `runner.artifact.prepare` (codex example: 42.7 s, before it was 1.2 s). In this span the controller uploads its own 31 MB `paperclip-runnerd` to the new sandbox. `PAPERCLIP_RUNNER_REMOTE_BINARY_PATH` is set, so `mayUsePreinstalledRunnerArtifact` returned `false` and the controller never used the identical `paperclip-runnerd` in the sandbox image. The upload time follows the sandbox upload throughput, which changes over time. None of the 17 commits between the two masters changed this path. **Expected behavior** When the sandbox already has a `paperclip-runnerd` with the same SHA-256 as the configured artifact, the controller links it and does not upload it. Cold boot does not depend on upload throughput. **Steps to reproduce** 1. Set `PAPERCLIP_RUNNER_REMOTE_BINARY_PATH` to the `paperclip-runnerd` from the Daytona runner image. 2. Start a cold agent run in a new Daytona sandbox from that image. 3. Look at the run spans. `runner.artifact.prepare` holds a full upload of the runner (5–48 s in our waves), and there is no `runner.artifact.discover` span. **Paperclip version or commit** `3452639a81` (also current master `6205b24d54`). Image `ghcr.io/paperclipai/paperclip-daytona-runner@sha256:710deab7375a…`. **Agent adapter(s) involved** All remote adapters: claude, codex and OpenCode. ## What Changed - `mayUsePreinstalledRunnerArtifact` accepts a preinstalled `paperclip-runnerd` when an artifact is configured and the controller has that artifact on disk. - In that case the existing SHA-256 check (`runner_remote_preinstalled_artifact_mismatch`) is mandatory. A different, missing, or unreadable image copy still falls back to the upload. - When an artifact is configured, a failed discovery probe counts as "no preinstalled runnerd", so the controller uploads the configured file as before. - Tests: a unit case for the gate, and three cases in the runner wiring test: identical configured artifact (no `syncIn`), mismatched configured artifact (upload), and failed discovery with a configured artifact (upload). - `docs/deploy/environment-variables.md` describes the new behavior. ## Verification - Red/green: `cd server && npx vitest run src/services/native-runtime/native-session-executor.test.ts -t "server-owned replacement artifact|contract-compatible runnerd|configured artifact the controller holds"`. Without the fix 3 tests fail. With the fix 27 pass. - `pnpm verify` passes. - Restart-chaos waves on Daytona, image `710deab7375a`, 6 tasks (2 claude, 2 codex, 2 opencode), A1/K0, run back to back in one hour: | Wave | Fix | claude cold boot p50 | codex | opencode | `runner.artifact.prepare` | | --- | --- | --- | --- | --- | --- | | w-20261117T005138 | no | 38.4 s | 33.2 s | 36.0 s | not recorded | | w-20261117T005627 | yes | 9.5 s | 8.8 s | 10.6 s | 0.5–0.6 s, all runs use the image copy | | w-20261117T005956 | no | 44.1 s | 13.1 s (max 47.1 s) | 45.5 s | 4.9–37.8 s upload | All 18 tasks passed. ## Risks - Low risk. The controller uses the image copy only when its SHA-256 equals the configured artifact, so the runner bytes do not change. Every other case keeps the current upload. - One extra `command -v` probe and one `sha256sum` probe run when an artifact is configured. Each takes about 0.1 s. - Saved run state is not changed. A run saved by the previous release resumes with the same runner identity, because the bytes are the same. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, via Claude Code with tool use (shell, file edit) and extended reasoning. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>