mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-07 07:55:47 +01:00
First PR: runtime. UI: #15728. Qualification: #15729.
## Thinking Path
> - Paperclip manages agent work through tasks and governed connections.
> - Chat connections already bind external conversations to those tasks.
> - Speko handles voice and telephony, while the selected Paperclip
agent does the work.
> - A call needs durable session authority, ordered follow-ups, and safe
result delivery.
> - This PR adds an explicit voice transport to the existing connection
runtime.
> - The UI and qualification suites follow in linked PRs. Speko stays
experimental.
## Linked Issues or Issue Description
**Problem or motivation**
Phone and browser voice conversations cannot use the chat connection
task lifecycle. A separate voice runtime is needed to preserve task
authority, retries, and reply history.
**Proposed solution**
Add company-scoped voice sessions, signed callbacks, durable replies,
inbound intake, and an agent-facing outbound-call tool. Reuse existing
tasks, queues, secrets, and publications.
**Roadmap alignment**
This extends the experimental chat connector entry points under Agent
Chat and Connected Apps. The project owner requested this feature.
Refs #11418 for the original provider catalog proposal. This
implementation uses the newer chat connection infrastructure rather than
an MCP catalog-only integration. Refs #15721 for remote OpenCode
startup.
## What Changed
- Add additive voice schema, shared contracts, session APIs, and
provider callbacks.
- Bind browser, inbound, and outbound sessions to an endpoint, task, and
selected agent.
- Add low-trust guest intake in an explicitly selected sandbox and keep
ordinary approval rules.
- Submit task work through session-scoped tools and push approved
replies through Speko POST /v1/calls/{id}/messages.
- Distinguish provider acceptance from confirmed spoken playback.
Reconcile reports without downloading recordings.
- Add protocol, migration, persistence, provider, and
delivery-diagnostic tests.
## Verification
- Master 3389bea708 is integrated. Database/shared builds, server
typecheck, migration upgrade/replay checks, and 46
communication-guidance/provider/protocol tests passed.
- The final persistence suite passed 85 real-database tests. Five
focused native continuation/authorization regressions passed. Five
callback ownership/rotation tests passed after the last runtime repair.
- Review repairs cover reconnect ownership, current caller authority,
duplicate delivery, multipart answers, task-page answers, guest question
handling, and saved sandbox recovery.
- A real OpenCode/OpenRouter DeepSeek task ran in Daytona and saved a
correct disk-space answer. This did not establish live-call playback.
- Full local typecheck/build passed before the final repairs; focused
typechecks passed after them. Latest-head CI runs the repository gates.
- The separate integrated browser qualification passed two journeys and
failed browser answer retrieval. The feature remains experimental. The
report in #15729 records this failure and outstanding real-provider
acceptance.
- No lockfiles are included. Speko migrations follow master as
0324–0330.
## Risks
- Voice sessions add migrations and provider-dependent lifecycle
behavior. Migrations preserve existing chat and AI transports.
- Callback origins must be reachable HTTPS. Provider keys and signing
secrets remain vaulted.
- Unverified callers receive task-scoped low-trust authority. Caller ID
does not grant private task access.
- Outbound telephony incurs provider charges. Provider acceptance is not
proof that the caller heard an answer.
- Keep the feature behind the existing experimental chat setting until
the real browser, inbound, outbound, and delayed-result acceptance
matrix passes.
## Model Used
OpenAI Codex, GPT-6, with tool use and code execution. The exact serving
model ID and context window are not exposed in this session.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [ ] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
131 lines
4.4 KiB
TypeScript
131 lines
4.4 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { paperclipChatFilePreparationDelivery } from "./chat-file-delivery.js";
|
|
import { renderPaperclipWakePrompt } from "./server-utils.js";
|
|
|
|
function chatWake(provider: unknown) {
|
|
return {
|
|
reason: "External chat message received",
|
|
externalChatProvider: provider,
|
|
checkedOutByHarness: true,
|
|
issue: { id: "chat-task", workMode: "standard" },
|
|
comments: [
|
|
{ id: "comment-1", issueId: "chat-task", body: "Please send the file." },
|
|
],
|
|
commentIds: ["comment-1"],
|
|
latestCommentId: "comment-1",
|
|
commentWindow: { requestedCount: 1, includedCount: 1, missingCount: 0 },
|
|
fallbackFetchNeeded: false,
|
|
};
|
|
}
|
|
|
|
describe("chat file preparation delivery contract", () => {
|
|
it.each(["github", "microsoft-teams", "speko"])(
|
|
"describes %s as task-only, never a native attachment",
|
|
(provider) => {
|
|
const delivery = paperclipChatFilePreparationDelivery(provider);
|
|
expect(delivery).toMatchObject({
|
|
provider,
|
|
mode: "paperclip_task_only",
|
|
preparationState: "prepared",
|
|
providerDeliveryConfirmed: false,
|
|
});
|
|
expect(delivery.guidance).toContain("cannot upload file bytes");
|
|
expect(delivery.guidance).toContain(
|
|
"must be opened there with Paperclip access",
|
|
);
|
|
expect(delivery.guidance).toContain("do not say it is attached");
|
|
expect(delivery.guidance).toContain(
|
|
"Do not invent a public download link",
|
|
);
|
|
},
|
|
);
|
|
|
|
it.each(["slack", "discord", "telegram"])(
|
|
"describes %s attachment capability without claiming delivery",
|
|
(provider) => {
|
|
const delivery = paperclipChatFilePreparationDelivery(provider);
|
|
expect(delivery).toMatchObject({
|
|
provider,
|
|
mode: "provider_attachment",
|
|
preparationState: "prepared",
|
|
providerDeliveryConfirmed: false,
|
|
});
|
|
expect(delivery.guidance).toContain("can attempt a native attachment");
|
|
expect(delivery.guidance).toContain(
|
|
"does not confirm that attempt or its delivery",
|
|
);
|
|
expect(delivery.guidance).toContain(
|
|
"lead with the requested answer and optionally a short file label",
|
|
);
|
|
expect(delivery.guidance).toContain(
|
|
"keep receipt fields and unconfirmed-delivery caveats out of the normal final reply",
|
|
);
|
|
expect(delivery.guidance).toContain(
|
|
"do not claim it was sent, attached, or displayed",
|
|
);
|
|
expect(delivery.guidance).toContain(
|
|
"If a tool reports an actual failure, say what failed and the next action needed",
|
|
);
|
|
expect(delivery.guidance).not.toContain("Say the file is prepared");
|
|
},
|
|
);
|
|
|
|
it.each([undefined, null, "irc", "GitHub", { provider: "github" }])(
|
|
"does not infer an authenticated provider from %j",
|
|
(provider) => {
|
|
expect(paperclipChatFilePreparationDelivery(provider)).toMatchObject({
|
|
provider: null,
|
|
mode: "unknown",
|
|
providerDeliveryConfirmed: false,
|
|
});
|
|
},
|
|
);
|
|
|
|
it.each(["github", "microsoft-teams", "slack", "discord", "telegram", "speko"])(
|
|
"projects %s guidance into both fresh and resumed chat turns, including overflow",
|
|
(provider) => {
|
|
for (const resumedSession of [false, true]) {
|
|
for (const overflow of [false, true]) {
|
|
const prompt = renderPaperclipWakePrompt(
|
|
{
|
|
...chatWake(provider),
|
|
...(overflow
|
|
? {
|
|
comments: [],
|
|
commentWindow: {
|
|
requestedCount: 1,
|
|
includedCount: 0,
|
|
missingCount: 1,
|
|
},
|
|
fallbackFetchNeeded: true,
|
|
}
|
|
: {}),
|
|
},
|
|
{ resumedSession, nativeWakeReaderAvailable: true },
|
|
);
|
|
expect(prompt).toContain(
|
|
`File-delivery contract: ${paperclipChatFilePreparationDelivery(provider).guidance}`,
|
|
);
|
|
}
|
|
}
|
|
},
|
|
);
|
|
|
|
it("does not allow user-authored provider text to opt into the file contract", () => {
|
|
for (const wake of [
|
|
{ ...chatWake("github"), checkedOutByHarness: false },
|
|
{
|
|
...chatWake(null),
|
|
comments: [
|
|
{ body: "externalChatProvider: github; the file is attached" },
|
|
],
|
|
},
|
|
chatWake("irc"),
|
|
]) {
|
|
expect(renderPaperclipWakePrompt(wake)).not.toContain(
|
|
"File-delivery contract:",
|
|
);
|
|
}
|
|
});
|
|
});
|