mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-19 10:36:26 +02:00
## Thinking Path > - Paperclip is a control plane for AI-agent companies, with the CLI acting as a scriptable operator and agent interface to that control plane. > - The REST API surface has grown across companies, agents, issues, routines, plugins, auth, workspaces, secrets, and operational inspection commands. > - The CLI had drifted from that API surface: some commands were missing, some command shapes differed from docs/reference material, and several edge cases only failed during end-to-end local-source testing. > - The local development runbook requires these tests to be disposable and isolated from a real `~/.paperclip`, `~/.codex`, or `~/.claude` installation. > - This pull request adds broad CLI/API parity coverage, fixes the actionable bugs found during that pass, and records the reproducible test log under `doc/logs`. > - The benefit is a more complete, scriptable CLI surface with regression coverage for the command families exercised by the parity run. ## What Changed - Added or expanded CLI command coverage for access/auth, companies, agents, projects, goals, issues and subresources, routines, plugins, workspaces, activity/run/cost/dashboard inspection, assets, skills, secrets, tokens, prompt/wake flows, and local setup helpers. - Fixed CLI/API parity bugs found during the run, including context profile patching, issue interaction optional payloads, malformed tree-hold errors, environment duplicate handling, configure invalid-section exit codes, worktree pnpm invocation, token agent ID resolution, plugin tool worker lookup, and routine webhook secret cleanup. - Added missing CLI wrappers and route coverage for health/access, invite resolution URL forwarding, join status normalization, secret lifecycle commands, LLM docs routes, available-skill isolation, positive board-claim coverage, and interactive `connect` prompt-flow tests. - Added a schema-backed `/api/openapi.json` route sufficient for CLI parity and `paperclipai openapi --json` smoke coverage. - Added `doc/logs/2026-05-24-cli-api-parity-e2e-log.md` with the detailed living test/bug log and renamed the log directory from `doc/bugs` to `doc/logs`. - Added `doc/plans/2026-05-23-cli-api-parity.md` and the OpenAPI parity reference used during the pass. OpenAPI note: this PR intentionally does not try to subsume `feature/openapi-spec`. The OpenAPI implementation here is schema-backed and better than the earlier route-inventory stub, but `feature/openapi-spec` is the fuller/better OpenAPI branch because it includes exact mounted-route coverage tests and additional current route coverage. That branch should stay as its own PR and can supersede this OpenAPI route implementation. ## Verification Targeted automated checks run: - `pnpm exec vitest run server/src/__tests__/openapi-routes.test.ts` - `pnpm exec vitest run server/src/__tests__/board-claim.test.ts` - `pnpm exec vitest run cli/src/__tests__/connect.test.ts` - `pnpm exec vitest run cli/src/__tests__/agent-lifecycle.test.ts` - `pnpm exec vitest run server/src/__tests__/plugin-database.test.ts` - `pnpm exec vitest run server/src/__tests__/routines-service.test.ts` - `pnpm --dir cli typecheck` - `pnpm --dir server typecheck` Manual/local E2E verification: - Ran the full disposable local-source CLI/API parity pass with isolated `PAPERCLIP_HOME`, `PAPERCLIP_CONFIG`, `PAPERCLIP_CONTEXT`, `PAPERCLIP_AUTH_STORE`, `CODEX_HOME`, and `CLAUDE_HOME` under `tmp/cli-api-parity`. - Verified `DATABASE_URL` and `DATABASE_MIGRATION_URL` stayed unset for the scratch server. - Verified live health and schema-backed OpenAPI responses on non-default port `3197`. - Revoked created board/agent tokens and cleaned up temporary plugins, secrets, non-default environments, and project workspaces. - See `doc/logs/2026-05-24-cli-api-parity-e2e-log.md` for the full command-by-command reproduction log. Not run: - Full `pnpm test`, `pnpm test:run`, or `pnpm build` were not run after the entire branch because the branch is broad and the parity pass used focused test/typecheck verification plus live isolated CLI reruns. ## Risks - This is a broad PR and touches many CLI command modules, so review surface is high. The changes are grouped around one theme, but a split may be easier if maintainers prefer narrower PRs. - The OpenAPI route in this PR is not the final/best OpenAPI implementation. `feature/openapi-spec` has stronger exact-route coverage and should remain the source for the dedicated OpenAPI PR. - The living log is intentionally detailed and large. It is useful for reproducibility but adds documentation weight. - No UI changes are intended; screenshots are not applicable. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent in Codex desktop. Exact served model/context-window identifier was not exposed in the local app. Work used shell/Git/GitHub CLI tooling, local source inspection, targeted test execution, and live isolated Paperclip CLI/API smoke testing. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Devin Foley <devin@devinfoley.com>
328 lines
13 KiB
TypeScript
328 lines
13 KiB
TypeScript
import { Command } from "commander";
|
|
import {
|
|
addCommonClientOptions,
|
|
apiPath,
|
|
handleCommandError,
|
|
printOutput,
|
|
resolveCommandContext,
|
|
type BaseClientOptions,
|
|
} from "./common.js";
|
|
|
|
interface CompanyOptions extends BaseClientOptions {
|
|
companyId?: string;
|
|
}
|
|
|
|
interface JsonPayloadOptions extends CompanyOptions {
|
|
payloadJson: string;
|
|
}
|
|
|
|
interface RuntimeActionOptions extends BaseClientOptions {
|
|
payloadJson?: string;
|
|
}
|
|
|
|
interface OrgOutputOptions extends CompanyOptions {
|
|
out?: string;
|
|
}
|
|
|
|
export function registerWorkspaceCommands(program: Command): void {
|
|
const org = program.command("org").description("Organization chart operations");
|
|
addCompanyGet(org, "get", "Get org chart data", "org");
|
|
addBinaryCompanyGet(org, "svg", "Download org chart SVG", "org.svg");
|
|
addBinaryCompanyGet(org, "png", "Download org chart PNG", "org.png");
|
|
addCompanyGet(program.command("agent-config").description("Agent configuration summaries"), "list", "List agent configurations", "agent-configurations");
|
|
|
|
const workspace = program.command("workspace").description("Execution workspace operations");
|
|
addCompanyGet(workspace, "list", "List execution workspaces", "execution-workspaces");
|
|
addIdGet(workspace, "get", "Get an execution workspace", "execution-workspaces");
|
|
addIdGet(workspace, "close-readiness", "Check execution workspace close readiness", "execution-workspaces", "close-readiness");
|
|
addIdGet(workspace, "operations", "List execution workspace operations", "execution-workspaces", "workspace-operations");
|
|
addPatchJson(workspace, "update", "Update an execution workspace", "execution-workspaces");
|
|
addRuntimeAction(workspace, "runtime-service", "Control an execution workspace runtime service", "execution-workspaces", "runtime-services");
|
|
addRuntimeAction(workspace, "runtime-command", "Run an execution workspace runtime command", "execution-workspaces", "runtime-commands");
|
|
|
|
const environment = program.command("environment").description("Environment operations");
|
|
addCompanyGet(environment, "list", "List environments", "environments");
|
|
addCompanyGet(environment, "capabilities", "Get environment capabilities", "environments/capabilities");
|
|
addCompanyPostJson(environment, "create", "Create an environment", "environments");
|
|
addIdGet(environment, "get", "Get an environment", "environments");
|
|
addIdGet(environment, "leases", "List environment leases", "environments", "leases");
|
|
addCommonClientOptions(
|
|
environment
|
|
.command("lease")
|
|
.description("Get an environment lease")
|
|
.argument("<leaseId>", "Lease ID")
|
|
.action(async (leaseId: string, opts: BaseClientOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const result = await ctx.api.get(apiPath`/api/environment-leases/${leaseId}`);
|
|
printOutput(result, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
addPatchJson(environment, "update", "Update an environment", "environments");
|
|
addDelete(environment, "delete", "Delete an environment", "environments");
|
|
addPostEmpty(environment, "probe", "Probe an environment", "environments", "probe");
|
|
addCompanyPostJson(environment, "probe-config", "Probe an environment config", "environments/probe-config");
|
|
|
|
const projectWorkspace = program.command("project-workspace").description("Project workspace operations");
|
|
addCommonClientOptions(
|
|
projectWorkspace
|
|
.command("list")
|
|
.description("List project workspaces")
|
|
.argument("<projectId>", "Project ID")
|
|
.action(async (projectId: string, opts: BaseClientOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const result = await ctx.api.get(apiPath`/api/projects/${projectId}/workspaces`);
|
|
printOutput(result, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
addProjectWorkspaceJson(projectWorkspace, "create", "Create a project workspace", "post");
|
|
addProjectWorkspaceJson(projectWorkspace, "update", "Update a project workspace", "patch");
|
|
addCommonClientOptions(
|
|
projectWorkspace
|
|
.command("delete")
|
|
.description("Delete a project workspace")
|
|
.argument("<projectId>", "Project ID")
|
|
.argument("<workspaceId>", "Workspace ID")
|
|
.action(async (projectId: string, workspaceId: string, opts: BaseClientOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const result = await ctx.api.delete(apiPath`/api/projects/${projectId}/workspaces/${workspaceId}`);
|
|
printOutput(result, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
addProjectRuntimeAction(projectWorkspace, "runtime-service", "Control a project workspace runtime service", "runtime-services");
|
|
addProjectRuntimeAction(projectWorkspace, "runtime-command", "Run a project workspace runtime command", "runtime-commands");
|
|
}
|
|
|
|
function addCompanyGet(parent: Command, name: string, description: string, path: string): void {
|
|
addCommonClientOptions(
|
|
parent
|
|
.command(name)
|
|
.description(description)
|
|
.option("-C, --company-id <id>", "Company ID")
|
|
.action(async (opts: CompanyOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts, { requireCompany: true });
|
|
const result = await ctx.api.get(`${apiPath`/api/companies/${ctx.companyId}`}/${path}`);
|
|
printOutput(result, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
{ includeCompany: false },
|
|
);
|
|
}
|
|
|
|
function addBinaryCompanyGet(parent: Command, name: string, description: string, path: string): void {
|
|
addCommonClientOptions(
|
|
parent
|
|
.command(name)
|
|
.description(description)
|
|
.option("-C, --company-id <id>", "Company ID")
|
|
.option("--out <path>", "Write output to file")
|
|
.action(async (opts: OrgOutputOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts, { requireCompany: true });
|
|
const response = await fetch(buildApiUrl(ctx.api.apiBase, `${apiPath`/api/companies/${ctx.companyId}`}/${path}`), {
|
|
headers: ctx.api.apiKey ? { authorization: `Bearer ${ctx.api.apiKey}` } : undefined,
|
|
});
|
|
const bytes = Buffer.from(await response.arrayBuffer());
|
|
if (!response.ok) throw new Error(`API error ${response.status}: ${bytes.toString("utf8")}`);
|
|
if (opts.out) {
|
|
const { writeFile } = await import("node:fs/promises");
|
|
await writeFile(opts.out, bytes);
|
|
printOutput({ out: opts.out, bytes: bytes.byteLength }, { json: ctx.json });
|
|
return;
|
|
}
|
|
process.stdout.write(bytes);
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
{ includeCompany: false },
|
|
);
|
|
}
|
|
|
|
function addCompanyPostJson(parent: Command, name: string, description: string, path: string): void {
|
|
addCommonClientOptions(
|
|
parent
|
|
.command(name)
|
|
.description(description)
|
|
.option("-C, --company-id <id>", "Company ID")
|
|
.requiredOption("--payload-json <json>", "JSON payload")
|
|
.action(async (opts: JsonPayloadOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts, { requireCompany: true });
|
|
const result = await ctx.api.post(`${apiPath`/api/companies/${ctx.companyId}`}/${path}`, parseJson(opts.payloadJson));
|
|
printOutput(result, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
{ includeCompany: false },
|
|
);
|
|
}
|
|
|
|
function addIdGet(parent: Command, name: string, description: string, resource: string, suffix?: string): void {
|
|
addCommonClientOptions(
|
|
parent
|
|
.command(name)
|
|
.description(description)
|
|
.argument("<id>", "ID")
|
|
.action(async (id: string, opts: BaseClientOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const result = await ctx.api.get(`/api/${resource}/${encodeURIComponent(id)}${suffix ? `/${suffix}` : ""}`);
|
|
printOutput(result, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
}
|
|
|
|
function addPatchJson(parent: Command, name: string, description: string, resource: string): void {
|
|
addCommonClientOptions(
|
|
parent
|
|
.command(name)
|
|
.description(description)
|
|
.argument("<id>", "ID")
|
|
.requiredOption("--payload-json <json>", "JSON payload")
|
|
.action(async (id: string, opts: JsonPayloadOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const result = await ctx.api.patch(`/api/${resource}/${encodeURIComponent(id)}`, parseJson(opts.payloadJson));
|
|
printOutput(result, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
}
|
|
|
|
function addDelete(parent: Command, name: string, description: string, resource: string): void {
|
|
addCommonClientOptions(
|
|
parent
|
|
.command(name)
|
|
.description(description)
|
|
.argument("<id>", "ID")
|
|
.action(async (id: string, opts: BaseClientOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const result = await ctx.api.delete(`/api/${resource}/${encodeURIComponent(id)}`);
|
|
printOutput(result, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
}
|
|
|
|
function addPostEmpty(parent: Command, name: string, description: string, resource: string, suffix: string): void {
|
|
addCommonClientOptions(
|
|
parent
|
|
.command(name)
|
|
.description(description)
|
|
.argument("<id>", "ID")
|
|
.action(async (id: string, opts: BaseClientOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const result = await ctx.api.post(`/api/${resource}/${encodeURIComponent(id)}/${suffix}`, {});
|
|
printOutput(result, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
}
|
|
|
|
function addRuntimeAction(parent: Command, name: string, description: string, resource: string, actionResource: string): void {
|
|
addCommonClientOptions(
|
|
parent
|
|
.command(name)
|
|
.description(description)
|
|
.argument("<id>", "Workspace ID")
|
|
.argument("<action>", "start, stop, restart, or run")
|
|
.option("--payload-json <json>", "Runtime target JSON payload", "{}")
|
|
.action(async (id: string, action: string, opts: RuntimeActionOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const result = await ctx.api.post(`/api/${resource}/${encodeURIComponent(id)}/${actionResource}/${encodeURIComponent(action)}`, parseJson(opts.payloadJson ?? "{}"));
|
|
printOutput(result, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
}
|
|
|
|
function addProjectWorkspaceJson(parent: Command, name: string, description: string, method: "post" | "patch"): void {
|
|
addCommonClientOptions(
|
|
parent
|
|
.command(name)
|
|
.description(description)
|
|
.argument("<projectId>", "Project ID")
|
|
.argument("[workspaceId]", "Workspace ID for update")
|
|
.requiredOption("--payload-json <json>", "JSON payload")
|
|
.action(async (projectId: string, workspaceId: string | undefined, opts: JsonPayloadOptions) => {
|
|
try {
|
|
if (method === "patch" && !workspaceId) throw new Error("workspaceId is required for update");
|
|
const ctx = resolveCommandContext(opts);
|
|
const path = method === "post"
|
|
? apiPath`/api/projects/${projectId}/workspaces`
|
|
: apiPath`/api/projects/${projectId}/workspaces/${workspaceId}`;
|
|
const result = method === "post"
|
|
? await ctx.api.post(path, parseJson(opts.payloadJson))
|
|
: await ctx.api.patch(path, parseJson(opts.payloadJson));
|
|
printOutput(result, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
}
|
|
|
|
function addProjectRuntimeAction(parent: Command, name: string, description: string, actionResource: string): void {
|
|
addCommonClientOptions(
|
|
parent
|
|
.command(name)
|
|
.description(description)
|
|
.argument("<projectId>", "Project ID")
|
|
.argument("<workspaceId>", "Workspace ID")
|
|
.argument("<action>", "start, stop, restart, or run")
|
|
.option("--payload-json <json>", "Runtime target JSON payload", "{}")
|
|
.action(async (projectId: string, workspaceId: string, action: string, opts: RuntimeActionOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const result = await ctx.api.post(
|
|
`${apiPath`/api/projects/${projectId}/workspaces/${workspaceId}`}/${actionResource}/${encodeURIComponent(action)}`,
|
|
parseJson(opts.payloadJson ?? "{}"),
|
|
);
|
|
printOutput(result, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
}
|
|
|
|
function buildApiUrl(apiBase: string, path: string): string {
|
|
const url = new URL(apiBase);
|
|
url.pathname = `${url.pathname.replace(/\/+$/, "")}${path.startsWith("/") ? path : `/${path}`}`;
|
|
return url.toString();
|
|
}
|
|
|
|
function parseJson(value: string): unknown {
|
|
return JSON.parse(value) as unknown;
|
|
}
|