mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 00:05:49 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Governed MCP access spans contracts, runtime enforcement, adapters, UI surfaces, and operator verification > - The parity reference PR #9534 is too large for effective automated or human review > - The feature therefore needs a linear stack whose individual diffs stay below the 100-file review limit > - This pull request is split 6/8 and focuses on UI API, shared components, and Tools/Profile surfaces > - The benefit is a standalone, testable review boundary while preserving byte-for-byte parity at the top of the stack ## Linked Issues or Issue Description - Related parity reference: #9534 - Problem: Operators need typed clients and administration surfaces that compile independently before navigation exposes them. - Proposed solution: Adds UI APIs, hooks, libraries, shared components, Tools/Profiles pages, and the plugin settings consumer required by the new company-scoped API. - Alternatives considered: keeping #9534 as one 403-file review, or rewriting the feature to manufacture seams; both were rejected in favor of path extraction plus compile-driven boundary moves. - Roadmap alignment: this advances the existing governed MCP/tool-access work already represented by #9534; it does not introduce a separate roadmap initiative. - Stack position: base branch is `pap10341-split/05-runtime-integration`. - Merge policy: merge bottom-up, in order, only after the complete eight-PR stack has been reviewed and the top-of-stack parity gate remains empty. - Requested review: UXDesigner sanity pass on Tools/Profile surfaces; Greptile on every PR. ## What Changed - Adds UI APIs, hooks, libraries, shared components, Tools/Profiles pages, and the plugin settings consumer required by the new company-scoped API. - Keeps this PR below 100 changed files and independently typecheckable. - Preserves the final tree from #9534 when combined with the other seven stack levels. ## Verification - `pnpm typecheck` - `pnpm check:token-gates` — all gates clean - Focused UI Vitest run with `NODE_ENV=test` — 28 files, 183 tests passed ## Risks - Large dead-code UI additions can drift from activation routes; PR 7 supplies the registration layer and top-level parity catches omissions. - Stack risk: merging out of order can expose incomplete layers; mitigate by following the documented bottom-up merge policy. - Parity risk: later edits to an intermediate branch can drift from #9534; mitigate by re-running the empty top-of-stack diff before merge. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, exact model ID `gpt-5.4`; runtime-managed context window; medium reasoning with repository, shell, Git, GitHub CLI, and code-execution tools enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] Internal references are omitted except the execution-plan link explicitly required for this coordinated split stack - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge ## Stack Coordination - Internal execution plan: [PAP-13874](/PAP/issues/PAP-13874#document-plan) - Parity reference: #9534 - Stack: #9556 → #9557 → #9558 → #9559 → #9560 → #9561 → #9562 → #9563 - Merge bottom-up only after full-stack review and an empty parity diff at #9563. ## UI Evidence QA captured these from the live Garden MCP split stack at 1440px and verified clean rendering:    --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
60 lines
2.4 KiB
TypeScript
60 lines
2.4 KiB
TypeScript
import type { ToolConnectionInstall } from "@paperclipai/shared";
|
|
|
|
/**
|
|
* Shared "Permitted vs Installed" helpers (Phase 3b, PAP-13618).
|
|
*
|
|
* The one mental model: `installed ⊆ permitted`. **Access** = who may use an
|
|
* app (zero context cost). **Installed** = whose harness actually carries the
|
|
* app's tools on every run (a real per-run context cost). These helpers derive
|
|
* the install state from a connection's `installs` rows and centralize the
|
|
* copy so every surface (app detail, agent Tools tab, connect flow) speaks the
|
|
* same language.
|
|
*/
|
|
|
|
export interface InstallState {
|
|
/** A `company` install row: the app is installed on every agent. */
|
|
onAll: boolean;
|
|
/** Explicit per-agent install rows. */
|
|
agentIds: Set<string>;
|
|
}
|
|
|
|
export function installStateFrom(installs: ToolConnectionInstall[] | undefined): InstallState {
|
|
const agentIds = new Set<string>();
|
|
let onAll = false;
|
|
for (const install of installs ?? []) {
|
|
if (install.targetType === "company") onAll = true;
|
|
else if (install.targetType === "agent") agentIds.add(install.targetId);
|
|
}
|
|
return { onAll, agentIds };
|
|
}
|
|
|
|
/** True when this connection's tools load into the given agent's context. */
|
|
export function isAgentInstalled(state: InstallState, agentId: string): boolean {
|
|
return state.onAll || state.agentIds.has(agentId);
|
|
}
|
|
|
|
/** Serialize an install state back into the PUT payload the API expects. */
|
|
export function installPayload(
|
|
companyId: string,
|
|
state: InstallState,
|
|
): Array<{ targetType: "company" | "agent"; targetId: string }> {
|
|
if (state.onAll) return [{ targetType: "company", targetId: companyId }];
|
|
return [...state.agentIds].map((targetId) => ({ targetType: "agent" as const, targetId }));
|
|
}
|
|
|
|
// --- Copy (verbatim from the PAP-13615 wireframe spec) ---
|
|
|
|
export function installInfoNotice(appName: string): string {
|
|
return `Installing adds ${appName}'s tools to the agent's context on every run — install only where it will actually be used.`;
|
|
}
|
|
|
|
export const INSTALL_ALL_WARNING =
|
|
"Adds context cost to every run of every agent — a deliberate choice. New agents you add later are installed automatically.";
|
|
|
|
export function autoExtendNotice(agentName: string): string {
|
|
return `Installing on ${agentName} will also grant access. A tool can't be installed on an agent that isn't allowed to use it, so we'll add ${agentName} to who can use it. This is logged.`;
|
|
}
|
|
|
|
export const INSTALLED_HINT =
|
|
"Has access — tick to load its tools into this agent's context.";
|