mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-09 16:02:36 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - People enter that work through the workspace, agent conversations, and tasks. > - Coordinator and Agent Chat still require experimental enrollment. > - Task link prefetches do not warm the compact queries used by the default task view. Chat also waits for a request when its navigation list already holds the conversation. > - This pull request makes Coordinator and Agent Chat standard and reuses the reads needed for navigation. > - People can choose Classic workspace in Experimental settings. Cached work can appear while fresh data loads. ## Linked Issues or Issue Description **What existing behavior does this improve?** Workspace selection, Agent Chat availability, and navigation between Chat, Tasks, and task details. **Subsystem affected** Cross-cutting: UI, workspace preferences, instance settings, and the database migration. **Current behavior** People must enable Coordinator and Agent Chat in Experimental settings. Opening a task can repeat requests because prefetch warms the full detail and comment queries, while the default view reads compact task data and a recent comment window. Opening Chat waits for a detail request even when the current person's conversation list contains it. **Proposed behavior** Coordinator is the standard workspace for everyone. Experimental settings offer Classic workspace, off by default. Old Coordinator experiment values do not select Classic. Agent Chat is available to everyone, including instances with an old saved or managed off value. Task link intent warms the queries used by the mounted view. Chat can use the current person's company-scoped conversation list during refresh. **Reason and benefit** People can use the standard workspace without setup. Repeat navigation can show cached content while the server refreshes it. **Breaking changes** Existing Coordinator experiment and Agent Chat off values no longer disable these surfaces. Classic requires an explicit new opt-in. The workspace API keeps its existing response shape and audit checks. The migration retains legacy values and adds a separate Classic preference. Execution permissions, company access, and chat privacy checks still apply. **Additional context** Roadmap check: this graduates existing surfaces and improves their navigation. It does not add a new agent execution capability. Duplicate searches found no open Coordinator workspace PR. Related server cache work, Refs: #17828, addresses compact issue-list invalidation; this PR addresses client navigation queries. ## What Changed - Add a default-off Classic workspace preference. Derive the existing workspace API response from that choice. Keep personal persistence, account isolation, and audited writes in the workspace preference service. - Replace the Coordinator experiment control with Classic workspace. Use Coordinator while preferences load. Update the existing settings examples and navigation recipe. - Retire the Agent Chat experiment control. Ignore old stored and managed off values. Retain the compatibility key and the existing execution and access checks. - Reuse account- and company-scoped chat list data with its original freshness timestamp. - Share compact task and recent-comment query options between prefetch and the task view. Keep full-history prefetch for Classic tasks and expanded history. - Add upgrade, replay, cache, account isolation, and browser switching regressions. Update product, database, development, and roadmap documentation. ## Verification - Targeted preference, settings, migration, cache, and UI regression tests passed during implementation. The cache tests hold refresh requests pending and check that content still renders. They also check account isolation and stale refresh behavior. - A real browser test verified fresh Coordinator defaults, Classic opt-in persistence, and return to Coordinator. It used an isolated source checkout with fresh data on macOS. - Token, migration numbering and safety, map, and Storybook catalog checks pass after the rebase. - Repository typecheck and build pass. Typecheck and token gates also pass after review repairs. The broad local run passed all six chat integration shards (1,931 tests). It then found the host-CLI-dependent recovery fixture described below. Its remaining duplicate work was stopped after the full current-head CI matrix passed; this is not a claim that the broad local command completed green. - Review repairs passed 419 UI/migration fixture tests, 19 Coordinator navigation tests, and all 214 tests in the five affected server suites. The 24 Chat/workspace browser tests pass, including standard Coordinator switching and explicit Classic persistence. - The broader browser repair run passed 85 tests. It retained two failed assertions and skipped five later serial cases. The affected files then passed all 11 tests after the fixes: reopen the desktop panel after reload and open More for Audit and Connectors. This includes the five serial cases that had not run. - The broad local suite exposed a recovery fixture that executed the host Codex CLI during a simulated remote probe. On a host with Codex 0.154.0, model fallback broke its fixed-model assertion. The fake sandbox now reports Codex 0.160.0. All 20 selected recovery/provider compatibility cases pass after the repair. - A CLI company import/export suite timed out during server startup in the second CI run. The port fallback is intentional in that fixture. No root cause was established. That suite passes on the final commit in CI. This records recovery, not a claimed product fix for the earlier timeout. - The first CI run exposed remaining assumptions about the retired flags and Classic UI. The repair commit updates those fixtures and navigation steps. It also restores the missing enabled Cases destination in Coordinator. Earlier local recovery attempts used the wrong fixture notification and advanced fake time during live execution; the corrected tests use the subscribed recovery queue and wall time during execution. - Greptile reviewed commit `98972b030d4505d838427a2fca6b196b8cad6d47` at **5/5** with no new comments. The original finding is resolved. - Current-head CI is green: **56 successful checks**, with three checks skipped by workflow filters. This includes typecheck, build, the complete Vitest matrix, all eight browser shards, Runner verification, release checks, and security checks. [Final CI run](https://github.com/paperclipai/paperclip/actions/runs/42132651414). - Typecheck caught missing `pid` and `startedAt` fields in the simulated command result. The fixture now returns the complete process contract, and the server test-layer typecheck passes. - Storybook catalog alignment was checked. Storybook play tests were not run. Hosted latency and cold bundle loading were not measured. ## Risks - The new default changes the workspace for people who previously left the Coordinator experiment off. They can opt into Classic in Experimental settings. - The additive migration must run before the new server code. It is safe to replay and preserves explicit Classic choices. - Cached content can be stale during background refresh. Existing query invalidation and source timestamps still control freshness. - These changes reduce avoidable loading waits. They do not establish a measured improvement in hosted request latency or initial bundle download time. ## Model Used OpenAI Codex, based on GPT-6, with reasoning, repository tools, code execution, and browser automation. The exact serving revision and context-window size are not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Scott Tong <scott@scottsmbpm5max.lan> Co-authored-by: Paperclip <noreply@paperclip.ing>
688 lines
25 KiB
TypeScript
688 lines
25 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { type ReactNode } from "react";
|
|
import { flushSync } from "react-dom";
|
|
import { createRoot } from "react-dom/client";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { Sidebar } from "./Sidebar";
|
|
import { TooltipProvider } from "@/components/ui/tooltip";
|
|
|
|
vi.mock("@/hooks/useCoordinatorWorkspaceEnabled", () => ({
|
|
useCoordinatorWorkspaceEnabled: () => ({ enabled: false, loaded: true, userId: "viewer" }),
|
|
}));
|
|
|
|
const mockHeartbeatsApi = vi.hoisted(() => ({
|
|
liveRunsForCompany: vi.fn(),
|
|
}));
|
|
|
|
const mockAttentionApi = vi.hoisted(() => ({
|
|
list: vi.fn(),
|
|
}));
|
|
|
|
const mockInstanceSettingsApi = vi.hoisted(() => ({
|
|
getExperimental: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
NavLink: ({ to, children, className, ...props }: {
|
|
to: string;
|
|
children: ReactNode;
|
|
className?: string | ((state: { isActive: boolean }) => string);
|
|
}) => (
|
|
<a
|
|
href={to}
|
|
className={typeof className === "function" ? className({ isActive: false }) : className}
|
|
{...props}
|
|
>
|
|
{children}
|
|
</a>
|
|
),
|
|
}));
|
|
|
|
vi.mock("../context/DialogContext", () => ({
|
|
useDialog: () => ({
|
|
openNewIssue: vi.fn(),
|
|
}),
|
|
useDialogActions: () => ({
|
|
openNewIssue: vi.fn(),
|
|
}),
|
|
}));
|
|
|
|
vi.mock("../context/CompanyContext", () => ({
|
|
useCompany: () => ({
|
|
selectedCompanyId: "company-1",
|
|
selectedCompany: { id: "company-1", issuePrefix: "PAP", name: "Paperclip" },
|
|
}),
|
|
}));
|
|
|
|
const mockSidebar = vi.hoisted(() => ({
|
|
isMobile: false,
|
|
setSidebarOpen: vi.fn(),
|
|
collapsed: false,
|
|
collapseLocked: false,
|
|
peeking: false,
|
|
toggleCollapsed: vi.fn(),
|
|
setCollapsed: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("../context/SidebarContext", () => ({
|
|
useSidebar: () => mockSidebar,
|
|
}));
|
|
|
|
vi.mock("../api/heartbeats", () => ({
|
|
heartbeatsApi: mockHeartbeatsApi,
|
|
}));
|
|
|
|
vi.mock("../api/attention", () => ({
|
|
attentionApi: mockAttentionApi,
|
|
}));
|
|
|
|
vi.mock("../api/instanceSettings", () => ({
|
|
instanceSettingsApi: mockInstanceSettingsApi,
|
|
}));
|
|
|
|
const mockInboxBadge = vi.hoisted(() => ({ inbox: 0, failedRuns: 0 }));
|
|
|
|
vi.mock("../hooks/useInboxBadge", () => ({
|
|
useInboxBadge: () => mockInboxBadge,
|
|
}));
|
|
|
|
vi.mock("@/plugins/slots", () => ({
|
|
PluginSlotOutlet: ({ slotTypes }: { slotTypes: string[] }) => (
|
|
<div data-plugin-slot-types={slotTypes.join(",")}>Plugin slot outlet</div>
|
|
),
|
|
}));
|
|
|
|
vi.mock("@/plugins/launchers", () => ({
|
|
PluginLauncherOutlet: ({ placementZones }: { placementZones: string[] }) => (
|
|
<div data-plugin-launcher-zone={placementZones.join(",")}>Plugin launcher outlet</div>
|
|
),
|
|
}));
|
|
|
|
vi.mock("./SidebarCompanyMenu", () => ({
|
|
SidebarCompanyMenu: () => <div>Company menu</div>,
|
|
}));
|
|
|
|
vi.mock("./SidebarAgents", () => ({
|
|
SidebarAgents: ({ streamlined }: { streamlined?: boolean }) => (
|
|
<div data-testid="sidebar-agents" data-streamlined={String(streamlined)}>
|
|
Active agents
|
|
</div>
|
|
),
|
|
}));
|
|
|
|
vi.mock("./SidebarProjects", () => ({
|
|
SidebarProjects: () => <div data-testid="sidebar-projects">Classic projects</div>,
|
|
}));
|
|
|
|
vi.mock("./SidebarStarredProjects", () => ({
|
|
SidebarStarredProjects: () => <div data-testid="sidebar-starred-projects" />,
|
|
}));
|
|
|
|
// Stubbed so the "no agent names in the primary nav" assertion would catch a
|
|
// regression that mounts the old per-agent chat rows alongside the Chat rail.
|
|
|
|
vi.mock("./SidebarRecentTasks", () => ({
|
|
SidebarRecentTasks: () => <div data-testid="sidebar-recent-tasks">Recent Tasks</div>,
|
|
}));
|
|
|
|
async function flushReact() {
|
|
for (let index = 0; index < 5; index += 1) {
|
|
await Promise.resolve();
|
|
await new Promise((resolve) => window.setTimeout(resolve, 0));
|
|
}
|
|
flushSync(() => {});
|
|
}
|
|
|
|
describe("Sidebar", () => {
|
|
let container: HTMLDivElement;
|
|
|
|
async function renderSidebar() {
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: { queries: { retry: false } },
|
|
});
|
|
|
|
flushSync(() => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<TooltipProvider>
|
|
<Sidebar />
|
|
</TooltipProvider>
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
await flushReact();
|
|
|
|
return root;
|
|
}
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
mockHeartbeatsApi.liveRunsForCompany.mockResolvedValue([]);
|
|
mockAttentionApi.list.mockResolvedValue({ items: [] });
|
|
mockSidebar.isMobile = false;
|
|
mockSidebar.collapsed = false;
|
|
mockSidebar.collapseLocked = false;
|
|
mockSidebar.peeking = false;
|
|
mockInboxBadge.inbox = 0;
|
|
mockInboxBadge.failedRuns = 0;
|
|
});
|
|
|
|
afterEach(() => {
|
|
container.remove();
|
|
document.body.innerHTML = "";
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("keeps the default sidebar edge borderless", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: false });
|
|
const root = await renderSidebar();
|
|
|
|
const sidebar = container.querySelector("aside");
|
|
expect(sidebar?.classList).not.toContain("border-r");
|
|
expect(sidebar?.classList).not.toContain("border-border");
|
|
expect(sidebar?.classList).toContain("primary-sidebar-surface");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("shows Search as a nav item instead of a header icon", async () => {
|
|
// The header's spare width goes to the workspace name (which otherwise
|
|
// truncates at ~78px), so search lives in the nav list — still
|
|
// exactly one pointer affordance, just relocated.
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: false });
|
|
const root = await renderSidebar();
|
|
|
|
expect(container.querySelector('a[aria-label="Open search"]')).toBeNull();
|
|
const navSearchLink = [...container.querySelectorAll("nav a")]
|
|
.find((anchor) => anchor.textContent?.trim() === "Search");
|
|
expect(navSearchLink?.getAttribute("href")).toBe("/search");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("renders plugin sidebar launchers inside the Work section", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({
|
|
enableIsolatedWorkspaces: false,
|
|
enableStreamlinedLeftNavigation: true,
|
|
});
|
|
const root = await renderSidebar();
|
|
|
|
const workSection = [...container.querySelectorAll("nav [data-plugin-launcher-zone]")]
|
|
.find((node) => node.getAttribute("data-plugin-launcher-zone") === "sidebar");
|
|
expect(workSection?.textContent).toContain("Plugin launcher outlet");
|
|
// The Work section is a Collapsible now (one extra wrapper level), so
|
|
// resolve the section root by walking up until the header label appears.
|
|
let workSectionContainer = workSection?.parentElement ?? null;
|
|
while (workSectionContainer && !workSectionContainer.textContent?.includes("Work")) {
|
|
workSectionContainer = workSectionContainer.parentElement;
|
|
}
|
|
expect(workSectionContainer?.textContent).toContain("Work");
|
|
expect(workSectionContainer?.textContent).toContain("Tasks");
|
|
expect(workSectionContainer?.textContent).not.toContain("Goals");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("uses the simplified work navigation with one Agents destination", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({
|
|
enableIsolatedWorkspaces: false,
|
|
enableStreamlinedLeftNavigation: true,
|
|
});
|
|
const root = await renderSidebar();
|
|
|
|
expect(container.textContent).toContain("New Task");
|
|
expect(container.textContent).not.toContain("New Issue");
|
|
|
|
const navLabels = [...container.querySelectorAll("nav a")].map((a) => a.textContent?.trim());
|
|
expect(navLabels).toContain("Tasks");
|
|
expect(navLabels).not.toContain("Issues");
|
|
|
|
const projectsLink = [...container.querySelectorAll("nav a")].find((a) => a.textContent?.trim() === "Projects");
|
|
expect(projectsLink?.getAttribute("href")).toBe("/projects");
|
|
const agentLinks = [...container.querySelectorAll('a[href="/agents"]')];
|
|
expect(agentLinks).toHaveLength(1);
|
|
expect([...container.querySelectorAll('a[href="/activity"]')]).toHaveLength(1);
|
|
expect(navLabels).toContain("Audit");
|
|
expect(navLabels).not.toContain("Settings");
|
|
expect(navLabels).not.toContain("Activity");
|
|
expect(navLabels).not.toContain("Costs");
|
|
expect(container.querySelector('[data-testid="sidebar-recent-tasks"]')).not.toBeNull();
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("keeps the simplified navigation while experimental settings are loading", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockImplementation(() => new Promise(() => {}));
|
|
const root = await renderSidebar();
|
|
|
|
const navLabels = [...container.querySelectorAll("nav a")].map((a) => a.textContent?.trim());
|
|
expect(navLabels).toContain("Projects");
|
|
expect(navLabels).toContain("Agents");
|
|
expect(container.textContent).not.toContain("Organization");
|
|
expect(container.textContent).not.toContain("Workspaces");
|
|
expect([...container.querySelectorAll("nav a")].map((a) => a.textContent?.trim())).not.toContain("Goals");
|
|
expect(container.querySelector('[data-testid="sidebar-goals-placeholder"]')).not.toBeNull();
|
|
expect(container.textContent).not.toContain("Conference Room");
|
|
expect(container.textContent).not.toContain("Pipelines");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("ignores the retired streamlined navigation opt-out", async () => {
|
|
// PAP-12472 retired the experimental opt-out; the streamlined sidebar is the
|
|
// only path, so an old `false` setting no longer restores classic mode.
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({
|
|
enableIsolatedWorkspaces: false,
|
|
enableStreamlinedLeftNavigation: false,
|
|
});
|
|
const root = await renderSidebar();
|
|
|
|
const navLabels = [...container.querySelectorAll("nav a")].map((a) => a.textContent?.trim());
|
|
expect(navLabels).toContain("Tasks");
|
|
// Top-level Projects link + starred children stay, per-project collapsible gone.
|
|
expect(navLabels).toContain("Projects");
|
|
expect(container.querySelector('[data-testid="sidebar-starred-projects"]')).not.toBeNull();
|
|
expect(navLabels).toContain("Agents");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("restores legacy agent and organization navigation when Streamlined UI is off", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({
|
|
enableStreamlinedUi: false,
|
|
enableApps: true,
|
|
});
|
|
const root = await renderSidebar();
|
|
|
|
const labels = [...container.querySelectorAll("nav a")].map((anchor) => anchor.textContent?.trim());
|
|
expect(container.querySelector('[data-testid="sidebar-recent-tasks"]')).toBeNull();
|
|
expect(container.querySelector('[data-testid="sidebar-projects"]')).not.toBeNull();
|
|
expect(container.querySelector('[data-testid="sidebar-agents"]')?.getAttribute("data-streamlined")).toBe("undefined");
|
|
expect(container.textContent).toContain("Organization");
|
|
expect(labels).toEqual(expect.arrayContaining(["Org", "Connectors", "Timeline", "Costs", "Activity", "Settings"]));
|
|
expect(labels).not.toContain("Audit");
|
|
expect(labels).not.toContain("Projects");
|
|
expect(container.querySelector('a[href="/agents"]')).toBeNull();
|
|
expect(container.querySelector("aside")?.classList).toContain("border-r");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("locks the legacy collapse control while a secondary sidebar forces the rail", async () => {
|
|
mockSidebar.collapseLocked = true;
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableStreamlinedUi: false });
|
|
const root = await renderSidebar();
|
|
|
|
expect(container.querySelector('button[aria-label="Collapse sidebar"]')).toBeNull();
|
|
expect(container.querySelector('button[aria-label="Expand sidebar"]')).toBeNull();
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("renders plugin sidebar slots in Work below Workspaces", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: true });
|
|
const root = await renderSidebar();
|
|
|
|
const sidebarSlot = [...container.querySelectorAll("nav [data-plugin-slot-types]")]
|
|
.find((node) => node.getAttribute("data-plugin-slot-types") === "sidebar");
|
|
expect(sidebarSlot?.textContent).toContain("Plugin slot outlet");
|
|
const workSectionContainer = sidebarSlot?.parentElement?.parentElement;
|
|
const workText = workSectionContainer?.textContent ?? "";
|
|
expect(workText).toContain("Work");
|
|
expect(workText).toContain("Workspaces");
|
|
expect(workText.indexOf("Workspaces")).toBeLessThan(workText.indexOf("Plugin slot outlet"));
|
|
|
|
const primaryNavText = container.querySelector("nav > div:first-child")?.textContent ?? "";
|
|
expect(primaryNavText).toContain("Inbox");
|
|
expect(primaryNavText).not.toContain("Plugin slot outlet");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("keeps Chat, Inbox and Workspaces without the combined Tasks experiment", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: true });
|
|
const root = await renderSidebar();
|
|
|
|
expect([...container.querySelectorAll("a")].some((anchor) => anchor.getAttribute("href") === "/chats")).toBe(true);
|
|
expect([...container.querySelectorAll("a")].some((anchor) => anchor.getAttribute("href") === "/inbox")).toBe(true);
|
|
expect([...container.querySelectorAll("a")].some((anchor) => anchor.getAttribute("href") === "/workspaces")).toBe(true);
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
describe("with Agent Chat on (PAP-670)", () => {
|
|
it("leads the Work group with a single Chat row and keeps agent names out of the primary nav", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableAgentChat: true });
|
|
const root = await renderSidebar();
|
|
|
|
const chatLink = [...container.querySelectorAll("a")].find((anchor) => anchor.getAttribute("href") === "/chats");
|
|
expect(chatLink?.textContent).toContain("Chat");
|
|
|
|
const workSection = chatLink?.closest("div")?.parentElement?.parentElement;
|
|
const workText = workSection?.textContent ?? "";
|
|
expect(workText.indexOf("Chat")).toBeLessThan(workText.indexOf("Tasks"));
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("needs nothing else: the Inbox row stays while Combined Inbox + Task List is off", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableAgentChat: true });
|
|
const root = await renderSidebar();
|
|
|
|
expect([...container.querySelectorAll("a")].some((anchor) => anchor.getAttribute("href") === "/chats")).toBe(true);
|
|
expect([...container.querySelectorAll("a")].some((anchor) => anchor.getAttribute("href") === "/inbox")).toBe(true);
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("keeps Workspaces available beside Chat when isolated workspaces are on", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableAgentChat: true, enableIsolatedWorkspaces: true });
|
|
const root = await renderSidebar();
|
|
|
|
expect(container.textContent).toContain("Workspaces");
|
|
expect([...container.querySelectorAll("a")].some((anchor) => anchor.getAttribute("href") === "/workspaces")).toBe(true);
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("keeps Chat in the top group in the legacy shell, which has no Work-group Chat row", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableAgentChat: true, enableStreamlinedUi: false });
|
|
const root = await renderSidebar();
|
|
|
|
const chatLinks = [...container.querySelectorAll("a")].filter((anchor) => anchor.getAttribute("href") === "/chats");
|
|
expect(chatLinks).toHaveLength(1);
|
|
expect(chatLinks[0]?.closest("[class*=\"group/sidebar-section\"]")).toBeNull();
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("with Combined Inbox + Task List on (PAP-670)", () => {
|
|
it("keeps the Inbox row in the legacy shell, which has no merged Tasks page", async () => {
|
|
mockInboxBadge.inbox = 7;
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableCombinedInboxTasks: true, enableStreamlinedUi: false });
|
|
const root = await renderSidebar();
|
|
|
|
const inboxLink = [...container.querySelectorAll("a")].find((anchor) => anchor.getAttribute("href") === "/inbox");
|
|
expect(inboxLink?.textContent).toContain("7");
|
|
const tasksLink = [...container.querySelectorAll("a")].find((anchor) => anchor.getAttribute("href") === "/issues");
|
|
expect(tasksLink?.textContent).not.toContain("7");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("drops the Inbox row and moves its unread badge onto Tasks", async () => {
|
|
mockInboxBadge.inbox = 7;
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableCombinedInboxTasks: true });
|
|
const root = await renderSidebar();
|
|
|
|
expect([...container.querySelectorAll("a")].some((anchor) => anchor.getAttribute("href") === "/inbox")).toBe(false);
|
|
|
|
const tasksLink = [...container.querySelectorAll("a")].find((anchor) => anchor.getAttribute("href") === "/issues");
|
|
expect(tasksLink?.textContent).toContain("Tasks");
|
|
expect(tasksLink?.textContent).toContain("7");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("keeps Chat available despite a retired off value", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableCombinedInboxTasks: true, enableAgentChat: false });
|
|
const root = await renderSidebar();
|
|
|
|
expect([...container.querySelectorAll("a")].some((anchor) => anchor.getAttribute("href") === "/chats")).toBe(true);
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
});
|
|
|
|
it("does not poll attention until Decisions is enabled", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableDecisions: false });
|
|
const root = await renderSidebar();
|
|
|
|
expect(mockAttentionApi.list).not.toHaveBeenCalled();
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("shows Status directly below Decisions in primary navigation", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({
|
|
enableDecisions: true,
|
|
enableStatusCards: true,
|
|
});
|
|
const root = await renderSidebar();
|
|
|
|
const primaryNavLinks = [...container.querySelectorAll("nav > div:first-child a")];
|
|
const decisionsLink = primaryNavLinks.find(
|
|
(anchor) => anchor.textContent?.trim() === "Decisions",
|
|
);
|
|
const statusLink = primaryNavLinks.find((anchor) => anchor.getAttribute("href") === "/status");
|
|
|
|
expect(statusLink?.textContent).toContain("Status");
|
|
expect(statusLink?.textContent).toContain("beta");
|
|
expect(statusLink?.textContent).not.toContain("exp");
|
|
expect(statusLink?.textContent).not.toContain("cards");
|
|
expect(primaryNavLinks.indexOf(statusLink!)).toBe(primaryNavLinks.indexOf(decisionsLink!) + 1);
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("groups and orders the streamlined Work and Org navigation", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({
|
|
enableIsolatedWorkspaces: false,
|
|
enableApps: true,
|
|
});
|
|
const root = await renderSidebar();
|
|
|
|
const sections = [...container.querySelectorAll("nav > div")];
|
|
const workSection = sections.find((section) => section.textContent?.startsWith("Work"));
|
|
const orgSection = sections.find((section) => section.textContent?.startsWith("Org"));
|
|
const labels = (section: Element | undefined) => [...(section?.querySelectorAll("a") ?? [])]
|
|
.map((anchor) => anchor.textContent?.trim());
|
|
|
|
expect(labels(workSection)).toEqual(["Chat", "Tasks", "Projects", "Routines", "Artifacts"]);
|
|
expect(labels(orgSection)).toEqual(["Agents", "Skills", "Connectors", "Audit"]);
|
|
expect(sections.indexOf(workSection!)).toBeLessThan(sections.indexOf(orgSection!));
|
|
expect(
|
|
workSection?.querySelector('a[href="/issues"] svg')?.classList.contains("lucide-circle-check"),
|
|
).toBe(true);
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("hides the Goals nav item by default", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({
|
|
enableIsolatedWorkspaces: false,
|
|
enableGoalsSidebarLink: false,
|
|
});
|
|
const root = await renderSidebar();
|
|
|
|
expect([...container.querySelectorAll("nav a")].map((a) => a.textContent?.trim())).not.toContain("Goals");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("shows the Goals nav item when the experimental setting is enabled", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({
|
|
enableIsolatedWorkspaces: false,
|
|
enableGoalsSidebarLink: true,
|
|
});
|
|
const root = await renderSidebar();
|
|
|
|
const link = [...container.querySelectorAll("a")].find((anchor) => anchor.textContent === "Goals");
|
|
expect(link?.getAttribute("href")).toBe("/goals");
|
|
|
|
const navText = container.querySelector("nav")?.textContent ?? "";
|
|
expect(navText.indexOf("Artifacts")).toBeLessThan(navText.indexOf("Goals"));
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("keeps Timeline out of the global navigation", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: false });
|
|
const root = await renderSidebar();
|
|
|
|
const sections = [...container.querySelectorAll("nav > div")];
|
|
const workSection = sections.find((section) => section.textContent?.startsWith("Work"));
|
|
expect(workSection?.textContent).toContain("Projects");
|
|
expect(workSection?.textContent).not.toContain("Timeline");
|
|
expect(container.querySelector('a[href="/timeline"]')).toBeNull();
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("shows the Conference Room nav item when conference room chat is enabled (PAP-137)", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({
|
|
enableIsolatedWorkspaces: false,
|
|
enableConferenceRoomChat: true,
|
|
});
|
|
const root = await renderSidebar();
|
|
|
|
const link = [...container.querySelectorAll("nav a")].find(
|
|
(anchor) => anchor.textContent?.trim() === "Conference Room",
|
|
);
|
|
expect(link?.getAttribute("href")).toBe("/board-chat");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("hides the Conference Room nav item when conference room chat is off (PAP-137)", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({
|
|
enableIsolatedWorkspaces: false,
|
|
enableConferenceRoomChat: false,
|
|
});
|
|
const root = await renderSidebar();
|
|
|
|
expect(container.textContent).not.toContain("Conference Room");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("always shows Connectors in the Org section", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableApps: false });
|
|
const root = await renderSidebar();
|
|
|
|
const links = [...container.querySelectorAll("a")];
|
|
const link = links.find((anchor) => anchor.textContent === "Connectors");
|
|
expect(link?.getAttribute("href")).toBe("/apps");
|
|
expect(link?.querySelector("svg")?.classList).toContain("lucide-unplug");
|
|
expect(links.findIndex((anchor) => anchor.textContent === "Connectors")).toBeGreaterThan(
|
|
links.findIndex((anchor) => anchor.textContent === "Skills"),
|
|
);
|
|
expect(links.findIndex((anchor) => anchor.textContent === "Connectors")).toBeLessThan(
|
|
links.findIndex((anchor) => anchor.textContent === "Audit"),
|
|
);
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("ignores the retired Pipelines flag in old settings responses", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({
|
|
enableIsolatedWorkspaces: false,
|
|
enablePipelines: true,
|
|
});
|
|
const root = await renderSidebar();
|
|
|
|
expect(container.textContent).not.toContain("Pipelines");
|
|
expect(container.querySelector('a[href="/pipelines"]')).toBeNull();
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("shows the Workspaces link when isolated workspaces are enabled", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: true });
|
|
const root = await renderSidebar();
|
|
|
|
const link = [...container.querySelectorAll("a")].find((anchor) => anchor.textContent === "Workspaces");
|
|
expect(link?.getAttribute("href")).toBe("/workspaces");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("does not render a global navigation collapse affordance", async () => {
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: false });
|
|
const root = await renderSidebar();
|
|
|
|
expect(container.querySelector('button[aria-label="Collapse sidebar"]')).toBeNull();
|
|
expect(container.querySelector('button[aria-label="Expand sidebar"]')).toBeNull();
|
|
expect(container.querySelector('button[aria-label="Keep sidebar expanded"]')).toBeNull();
|
|
expect(container.textContent).toContain("Company menu");
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("hides the collapse affordance on mobile (drawer handles it)", async () => {
|
|
mockSidebar.isMobile = true;
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: false });
|
|
const root = await renderSidebar();
|
|
|
|
expect(container.querySelector('button[aria-label="Collapse sidebar"]')).toBeNull();
|
|
expect(container.querySelector('button[aria-label="Keep sidebar expanded"]')).toBeNull();
|
|
|
|
flushSync(() => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
});
|