mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-26 18:31:34 +01:00
## Thinking Path > - Paperclip manages AI agents that perform work. > - Paperclip Runner connects durable task runs to local provider processes. > - The full-stack paid matrix exposed failures after the runner integrity repair. > - Verified JavaScript entrypoints lost their relative module graph when Linux executed them through descriptor paths. > - Returned provider startup errors also remained pending and became indeterminate after recovery. > - Sparse Codex tool lifecycle events lost the `write_document` identity before task transcript projection. > - This pull request repairs those three boundaries and makes the structured-question fixture deterministic. > - The benefit is repeatable provider startup, exact failure replay, and correct inline Plan placement. ## Linked Issues or Issue Description Refs #12721 and #12700. **What happened?** The paid runner matrix failed ACPX and OpenCode startup before provider session creation. The runner journal then replaced the original startup error with an indeterminate recovery result. Native Codex saved a Plan but rendered it only as a fallback card. A legacy Claude waiting reply could also echo the reserved terminal marker before the answer arrived. **Expected behavior** Verified JavaScript providers must start from immutable descriptor-backed artifacts. Returned startup failures must persist as terminal failed command results. Native tool lifecycle updates must preserve the `write_document` boundary. Pre-answer fixture output must not contain the reserved terminal marker. **Steps to reproduce** 1. Run the local provider cells in the Runner Full-Stack E2E workflow. 2. Observe ACPX and OpenCode fail during `session.open` before provider execution. 3. Observe recovery report `execution_indeterminate` instead of the original startup error. 4. Run the native Codex Plan cell and observe the fallback Plan card after the tool activity row. 5. Run the legacy Claude structured-question resume cell and observe an early marker echo in waiting prose. **Paperclip version or commit** `0f9452101740835ce0b1488a204bf48acd5bafc3` **Deployment mode** Local development with the paid GitHub Actions acceptance workflow. ## What Changed - Bundle the ACPX sidecar and OpenCode proxy as self-contained Node ESM entrypoints before hashing and verified descriptor launch. - Anchor ACPX dynamic provider package resolution at a controller-derived provider-pack root and keep that root out of the provider child environment. - Persist executor-returned startup errors as redacted durable failed command results while retaining indeterminate recovery for true process death. - Coalesce sparse native tool items by stable ID so a late `write_document` name, input, and result reach the transcript boundary once. - Forbid the structured-question fixture from spelling or announcing its reserved terminal marker before the user answers. ## Verification - Rust and TypeScript regression tests cover durable failed replay, true crash ambiguity, bundle closure, package-root derivation, environment filtering, exact Codex tool lifecycle coalescing, and prompt determinism. - Local execution is intentionally limited to formatters and static diff checks. GitHub Actions will run tests, type checks, builds, and security checks. - After ordinary CI is green, scoped paid cells will validate one ACPX launch, one OpenCode launch, native Codex Plan projection, and legacy Claude structured resume before a complete matrix rerun. - Prior failing matrix: https://github.com/paperclipai/paperclip/actions/runs/33682434315 ## Risks - Bundling changes the bytes covered by provider launch hashes. Provider-pack generation already hashes the final built files. - ACPX still loads qualified provider packages dynamically. The controller supplies a normalized package root, while existing version, digest, path, and descriptor checks remain active. - Durable `failed` is terminal. Replays return the same redacted result and do not execute the provider effect twice. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex based on GPT-5 with agentic reasoning, repository inspection, code editing, Git, parallel subagents, and GitHub Actions coordination. The exact deployed snapshot and context-window size are not exposed to this task. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either linked related public work or described the bug in this PR - [x] I have not referenced internal or instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal ticket id - [ ] I have run tests locally and they pass (intentionally deferred to GitHub Actions) - [x] I have added or updated tests where applicable - [x] No documentation change is required for this runtime repair - [x] I have considered and documented the risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
245 lines
7.4 KiB
TypeScript
245 lines
7.4 KiB
TypeScript
export interface ObservableRunState {
|
|
status?: string | null;
|
|
errorCode?: string | null;
|
|
}
|
|
|
|
export interface ObservableRunEvent {
|
|
eventType?: string;
|
|
payload?: Record<string, unknown> | null;
|
|
}
|
|
|
|
export interface ObservableProviderSessionRun {
|
|
id: string;
|
|
sessionIdBefore?: string | null;
|
|
sessionIdAfter?: string | null;
|
|
contextSnapshot?: Record<string, unknown> | null;
|
|
}
|
|
|
|
export interface ObservableMatcherResult {
|
|
matcher: {
|
|
kind?: string;
|
|
expected?: unknown;
|
|
count?: unknown;
|
|
};
|
|
passed: boolean;
|
|
}
|
|
|
|
export interface OpenRouterHelloTerminalVarianceObservation {
|
|
suiteId: string;
|
|
profileId: string;
|
|
taskId: string;
|
|
expectedMarker: string;
|
|
finalRunMessage: string;
|
|
allAgentMessages: string;
|
|
semanticSummary: unknown;
|
|
issueStatus: string;
|
|
runStatuses: readonly string[];
|
|
matcherResults: readonly ObservableMatcherResult[];
|
|
invariantFailures: readonly string[];
|
|
}
|
|
|
|
export function acceptedPlanSessionResetFailures(
|
|
provider: "codex" | "opencode" | "acpx",
|
|
previousSessionId: string | null | undefined,
|
|
current: ObservableProviderSessionRun,
|
|
): string[] | null {
|
|
const context = record(current.contextSnapshot);
|
|
const acceptedPlanReset =
|
|
context.forceFreshSession === true &&
|
|
context.workspaceRefreshReason === "accepted_plan_confirmation" &&
|
|
context.source === "issue.interaction.accept" &&
|
|
context.interactionStatus === "accepted";
|
|
if (!acceptedPlanReset) return null;
|
|
|
|
const failures: string[] = [];
|
|
if (current.sessionIdBefore) {
|
|
failures.push(
|
|
`expected accepted Plan run ${current.id} to start without a prior provider session`,
|
|
);
|
|
}
|
|
if (
|
|
previousSessionId &&
|
|
current.sessionIdAfter &&
|
|
current.sessionIdAfter === previousSessionId
|
|
) {
|
|
failures.push(
|
|
`expected accepted Plan run ${current.id} to rotate the ${provider} provider session`,
|
|
);
|
|
}
|
|
return failures;
|
|
}
|
|
|
|
function record(value: unknown): Record<string, unknown> {
|
|
return value && typeof value === "object" && !Array.isArray(value)
|
|
? (value as Record<string, unknown>)
|
|
: {};
|
|
}
|
|
|
|
export function isNonExecutingReviewFenceRun(run: ObservableRunState) {
|
|
return (
|
|
run.status === "cancelled" &&
|
|
run.errorCode === "issue_continuation_waiting_on_review"
|
|
);
|
|
}
|
|
|
|
function normalizeMessage(value: string) {
|
|
return value
|
|
.replace(/\r\n/g, "\n")
|
|
.replace(/\\_/g, "_")
|
|
.replace(/[ \t]+/g, " ")
|
|
.trim();
|
|
}
|
|
|
|
function countOccurrences(value: string, expected: string) {
|
|
if (!expected) return 0;
|
|
let count = 0;
|
|
let cursor = 0;
|
|
while (cursor <= value.length - expected.length) {
|
|
const index = value.indexOf(expected, cursor);
|
|
if (index < 0) break;
|
|
count += 1;
|
|
cursor = index + expected.length;
|
|
}
|
|
return count;
|
|
}
|
|
|
|
export function isOpenRouterDeepSeekHelloTerminalVariance(
|
|
observation: OpenRouterHelloTerminalVarianceObservation,
|
|
) {
|
|
const marker = normalizeMessage(observation.expectedMarker);
|
|
const finalRunMessage = normalizeMessage(observation.finalRunMessage);
|
|
const allAgentMessages = normalizeMessage(observation.allAgentMessages);
|
|
const failedMatchers = observation.matcherResults.filter(
|
|
(result) => !result.passed,
|
|
);
|
|
const hasExpectedExactFailure = failedMatchers.some(
|
|
(result) =>
|
|
result.matcher.kind === "message_exact" &&
|
|
result.matcher.expected === observation.expectedMarker,
|
|
);
|
|
const hasExpectedOccurrenceFailure = failedMatchers.some(
|
|
(result) =>
|
|
result.matcher.kind === "message_occurrences" &&
|
|
result.matcher.expected === observation.expectedMarker &&
|
|
result.matcher.count === 1,
|
|
);
|
|
|
|
return (
|
|
observation.suiteId === "openrouter-model-breadth" &&
|
|
observation.profileId === "openrouter-deepseek-deepseek-v4-flash-0731" &&
|
|
observation.taskId === "hello-complete" &&
|
|
observation.issueStatus === "done" &&
|
|
observation.runStatuses.length === 1 &&
|
|
observation.runStatuses[0] === "succeeded" &&
|
|
observation.semanticSummary === observation.expectedMarker &&
|
|
finalRunMessage.length > 0 &&
|
|
countOccurrences(finalRunMessage, marker) === 0 &&
|
|
countOccurrences(allAgentMessages, marker) === 0 &&
|
|
observation.invariantFailures.length === 0 &&
|
|
failedMatchers.length === 2 &&
|
|
hasExpectedExactFailure &&
|
|
hasExpectedOccurrenceFailure
|
|
);
|
|
}
|
|
|
|
export function isControlPlaneGovernedResponseWait(
|
|
events: readonly ObservableRunEvent[],
|
|
) {
|
|
const accepted = events.filter(
|
|
(event) => event.eventType === "run.result.accepted",
|
|
);
|
|
if (accepted.length !== 1) return false;
|
|
const envelope = record(accepted[0]?.payload?.prpEvent);
|
|
const result = record(record(envelope.payload).result);
|
|
const continuation = record(result.continuation);
|
|
const idempotencyKey = continuation.idempotencyKey;
|
|
if (
|
|
typeof idempotencyKey !== "string" ||
|
|
!idempotencyKey.startsWith("interaction-response:")
|
|
) {
|
|
return false;
|
|
}
|
|
const interactionId = idempotencyKey.slice("interaction-response:".length);
|
|
if (!interactionId) return false;
|
|
const interactionRef = `interaction:${interactionId}`;
|
|
const hasEvidence =
|
|
Array.isArray(result.evidence) &&
|
|
result.evidence.some((value) => record(value).ref === interactionRef);
|
|
const hasInteractionArtifact =
|
|
Array.isArray(result.artifacts) &&
|
|
result.artifacts.some((value) => {
|
|
const artifact = record(value);
|
|
return (
|
|
artifact.kind === "issue_thread_interaction" &&
|
|
artifact.ref === interactionRef
|
|
);
|
|
});
|
|
return (
|
|
envelope.schema === "paperclip.prp.event.v1" &&
|
|
envelope.eventType === "run.result.accepted" &&
|
|
envelope.sourceKind === "control_plane" &&
|
|
result.schema === "paperclip.run_result.v1" &&
|
|
result.reportedWorkDisposition === "yielded" &&
|
|
continuation.kind === "response_wake" &&
|
|
hasEvidence &&
|
|
hasInteractionArtifact
|
|
);
|
|
}
|
|
|
|
export function providerSessionContinuityFailures(
|
|
provider: "codex" | "opencode",
|
|
runs: readonly ObservableProviderSessionRun[],
|
|
): string[] {
|
|
const failures: string[] = [];
|
|
for (let index = 0; index < runs.length; index += 1) {
|
|
const current = runs[index]!;
|
|
const currentSessionId = current.sessionIdAfter;
|
|
if (!currentSessionId) {
|
|
failures.push(
|
|
`expected ${provider} run ${current.id} to record provider session identity`,
|
|
);
|
|
continue;
|
|
}
|
|
if (index === 0) continue;
|
|
|
|
const previousSessionId = runs[index - 1]?.sessionIdAfter;
|
|
const acceptedPlanResetFailures = acceptedPlanSessionResetFailures(
|
|
provider,
|
|
previousSessionId,
|
|
current,
|
|
);
|
|
if (acceptedPlanResetFailures) {
|
|
failures.push(...acceptedPlanResetFailures);
|
|
continue;
|
|
}
|
|
|
|
if (!previousSessionId || currentSessionId !== previousSessionId) {
|
|
failures.push(
|
|
`expected ${provider} to preserve its provider session for run ${current.id}`,
|
|
);
|
|
continue;
|
|
}
|
|
if (
|
|
current.sessionIdBefore &&
|
|
current.sessionIdBefore !== previousSessionId
|
|
) {
|
|
failures.push(
|
|
`expected ${provider} run ${current.id} to resume provider session ${previousSessionId}`,
|
|
);
|
|
}
|
|
}
|
|
return failures;
|
|
}
|
|
|
|
export function numberedPlanStepCount(body: string | null | undefined) {
|
|
return (body ?? "").split(/\r?\n/).filter((line) => {
|
|
const normalized = line
|
|
.replaceAll("**", "")
|
|
.replaceAll("__", "")
|
|
.replaceAll("`", "");
|
|
return /^\s*(?:#{1,6}\s*)?(?:[-*+]\s*)?(?:step\s+)?\d+(?:[.)]|\s*[-—:])(?:\s|$)/i.test(
|
|
normalized,
|
|
);
|
|
}).length;
|
|
}
|