Files
PaperClipAI/server/src/__tests__/authorization-service.test.ts
T
DottaandClaude Opus 5.5 c0fc7608ee fix(agents): honor an explicit hiring denial on CEO agents (#20041)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The board controls which agents can hire, with the "Can create
agents" permission on each agent
> - A CEO agent with that permission turned off could still hire,
because the CEO role allowed hiring before the server read the saved
permission
> - In chat, a CEO agent asked to hire then created the agent through
the `hire_agent` tool, against the board's policy
> - This pull request makes the saved permission decide, and uses the
CEO role only for old rows that never saved a value
> - It also tells a denied agent that the denial is final and where a
person can act
> - The benefit is that the permissions page and the server now agree,
and the board can trust a hiring denial

## Linked Issues or Issue Description

**What happened**
A board user turned off "Can create agents" for a CEO agent. Then the
user asked the CEO in chat to hire a QA engineer. The CEO called
`hire_agent` (`POST /api/companies/{companyId}/agent-hires`). The server
returned 201 and created the agent. The legacy creator rule allowed any
agent with `role: "ceo"` before it read `permissions.canCreateAgents`.

**Expected behavior**
An explicit `canCreateAgents: false` denies hiring for every role,
including CEO. The agent gets a 403 that says the denial is final, and
it sends the person to the hire form or to its permissions page.

**Steps to reproduce**
1. Create a company with a CEO agent.
2. On the CEO's permissions page, turn off "Can create agents".
3. In chat with the CEO, send "Hire a QA engineer named Morgan."
4. See that a new agent named Morgan exists.

Found by the chat eval case `agents.hire-denied`. Related: #19614 (chat
eval harness).

## What Changed

- `canCreateAgentsLegacy` (authorization) uses the role-aware permission
normalization. A CEO keeps hiring unless the board recorded a hiring
denial.
- New `ceoHiringDeniedBy` record in `permissions` (`{ actorType,
actorId, at }`). `PATCH /agents/:id/permissions` writes it when an
authorized actor saves a CEO's hiring as off (an earlier record is
kept). The page shows the effective value, so a saved off is the board's
choice. Turning the toggle off also removes an explicit `agents:create`
grant. A saved `canCreateAgents: false` restricts a CEO only together
with this record.
- Reads report the effective value. A CEO row with no value, or with an
unrecorded false, shows hiring on. A CEO with a recorded denial shows it
off.
- Create and hire inputs cannot supply the record. Configuration updates
keep an existing record unless they turn hiring on. Company export keeps
a CEO's recorded denial, and import restores it, stamped by the
importing user.
- `PATCH /agents/:id/permissions`: an agent actor needs `agents:create`
to change `canCreateAgents`. A denied CEO cannot restore hiring for
itself or grant it to another agent.
- `assertCanCreateAgentsForCompany` adds a final, actionable sentence to
an agent's `agents:create` denial on hiring routes only (`POST /agents`,
`POST /agent-hires`, the hiring toggle on `PATCH /permissions`).
- `POST /api/companies/:companyId/imports/apply` (CEO-safe import): an
agent import that would create agents needs an `agents:create` decision
before any write. Before, any CEO agent could create agents this way.
Import also removes an existing `agents:create` grant when it restores a
CEO's denial.
- Chat guidance tells the agent to link `/<prefix>/agents/new` and its
own `/permissions` page when it cannot hire.
- Regression tests: authorization (a recorded denial is honored; an
unrecorded false keeps CEO hiring), normalization, route tests (denial
text, self-escalation, the record is written only when a CEO is turned
off), service tests for the permission and configuration write paths,
chat guidance text.

### Why a recorded denial and not a plain false

These normal paths save `canCreateAgents: false` on a CEO without a
board choice:

- The permissions page posts the full object. Before this change, a
legacy CEO row with `{}` was read as false, so saving any other toggle
stored false.
- A company import that updates an existing agent normalizes the
manifest permissions in the "stored" context. A manifest without the
field stores false. Export drops false values, so this is common.
- Low-trust creation stores false. If the trust preset later changes to
standard, the false remains.

These paths store true or nothing for a CEO: onboarding seed
(`requestHire`, create context: true), teams-catalog and import creation
(create context: true; the bundled catalog sets true only for a CTO),
built-in agents (no CEO roles), migrations and seed data (no writes to
this field).

A plain-false rule would remove hiring from those CEOs. With the record,
existing data keeps today's behavior, and no data migration is
necessary.

## Verification

- `cd server && npx vitest run
src/__tests__/agent-permissions-service.test.ts
src/__tests__/authorization-service.test.ts
src/__tests__/agent-permissions-routes.test.ts
src/__tests__/agent-conversations.test.ts` passes (244 tests).
- `teams-catalog-service`, `company-portability` and `built-in-agents`
tests pass (189 tests).
- Red check: the new authorization test fails without the
`authorization.ts` change.
- `npx tsc --noEmit -p server` passes.
- End to end: the chat eval `agents.hire-denied` on the OpenCode runner.
The baseline run (Actions run 42478870236) created Morgan through
`hire_agent`. With this fix (Actions run 42480936881), the agent got the
403, created no agent, and linked the hire form and its permissions
page. The eval clicked the rendered hire-form link.

## Risks

- Behavior change: a CEO whose hiring the board turns off after this
change can no longer hire.
- A CEO that already has a saved false keeps hiring until a board user
turns it off again on the permissions page. The page now shows such a
CEO as on, so the board can see and change it.
- A request that creates a CEO with `canCreateAgents: false` does not
restrict it. The board must turn hiring off on the permissions page.
- A CEO agent whose hiring is denied can no longer import a package that
creates agents. A board user can still import it.
- Other CEO special cases are not hiring routes: `issues.ts` lets a CEO
link approvals to issues, and `agents.ts` gives a CEO task assignment.
`teams-catalog.ts` and `llms.ts` read the normalized permissions, so
they follow the same effective value.
- The denial text is longer. No existing test compares this route's
exact error text.

## Model Used

- Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code
execution in Claude Code.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 20:05:15 -06:00

3124 lines
114 KiB
TypeScript

import { randomUUID } from "node:crypto";
import { and, eq } from "drizzle-orm";
import { afterAll, afterEach, beforeAll, describe, expect, it, vi } from "vitest";
import {
agents,
authUsers,
companies,
companyMemberships,
createDb,
instanceUserRoles,
issueAccessGrants,
issueComments,
issues,
principalPermissionGrants,
projectAccessMembers,
projects,
userInboxAgentPolicies,
} from "@paperclipai/db";
import { LOW_TRUST_REVIEW_PRESET, type PermissionKey } from "@paperclipai/shared";
import {
getEmbeddedPostgresTestSupport,
startEmbeddedPostgresTestDatabase,
} from "./helpers/embedded-postgres.js";
import {
authorizationService,
canActorReadIssuePrivacy,
issuePrivacyMode,
type AuthorizationActor,
} from "../services/authorization.js";
import { logger } from "../middleware/logger.js";
const embeddedPostgresSupport = await getEmbeddedPostgresTestSupport();
const describeEmbeddedPostgres = embeddedPostgresSupport.supported ? describe : describe.skip;
async function createCompany(db: ReturnType<typeof createDb>, label: string) {
return db
.insert(companies)
.values({
name: `Authorization ${label} ${randomUUID()}`,
issuePrefix: `AZ${randomUUID().slice(0, 6).toUpperCase()}`,
})
.returning()
.then((rows) => rows[0]!);
}
async function createAgent(
db: ReturnType<typeof createDb>,
companyId: string,
input: { role?: string; reportsTo?: string | null; permissions?: Record<string, unknown> } = {},
) {
return db
.insert(agents)
.values({
companyId,
name: `Agent ${randomUUID()}`,
role: input.role ?? "engineer",
reportsTo: input.reportsTo ?? null,
permissions: input.permissions ?? {},
adapterType: "process",
adapterConfig: {},
runtimeConfig: {},
})
.returning()
.then((rows) => rows[0]!);
}
async function createProject(
db: ReturnType<typeof createDb>,
companyId: string,
label: string,
visibility: "open" | "private" = "open",
) {
return db
.insert(projects)
.values({
companyId,
name: `Project ${label} ${randomUUID()}`,
visibility,
})
.returning()
.then((rows) => rows[0]!);
}
async function createIssue(
db: ReturnType<typeof createDb>,
companyId: string,
input: {
id?: string;
title?: string;
projectId?: string | null;
parentId?: string | null;
assigneeAgentId?: string | null;
assigneeUserId?: string | null;
createdByUserId?: string | null;
responsibleUserId?: string | null;
visibility?: "open" | "private";
privacyRootIssueId?: string | null;
privacyParentIssueId?: string | null;
originKind?: string | null;
originId?: string | null;
} = {},
) {
return db
.insert(issues)
.values({
id: input.id ?? randomUUID(),
companyId,
title: input.title ?? `Issue ${randomUUID()}`,
status: "todo",
priority: "medium",
projectId: input.projectId ?? null,
parentId: input.parentId ?? null,
assigneeAgentId: input.assigneeAgentId ?? null,
assigneeUserId: input.assigneeUserId ?? null,
createdByUserId: input.createdByUserId ?? null,
responsibleUserId: input.responsibleUserId ?? null,
visibility: input.visibility ?? "open",
privacyRootIssueId: input.privacyRootIssueId ?? null,
privacyParentIssueId: input.privacyParentIssueId ?? null,
originKind: input.originKind ?? "manual",
originId: input.originId ?? null,
})
.returning()
.then((rows) => rows[0]!);
}
async function grantAgentPermission(
db: ReturnType<typeof createDb>,
companyId: string,
agentId: string,
permissionKey: PermissionKey,
scope: Record<string, unknown> | null = null,
) {
await db.insert(companyMemberships).values({
companyId,
principalType: "agent",
principalId: agentId,
status: "active",
membershipRole: "member",
});
await db.insert(principalPermissionGrants).values({
companyId,
principalType: "agent",
principalId: agentId,
permissionKey,
scope,
grantedByUserId: null,
});
}
async function createUser(
db: ReturnType<typeof createDb>,
input: { id?: string; email?: string } = {},
) {
const id = input.id ?? `user-${randomUUID()}`;
await db.insert(authUsers).values({
id,
name: `User ${id}`,
email: input.email ?? `${id}@example.com`,
emailVerified: true,
image: null,
createdAt: new Date(),
updatedAt: new Date(),
});
return id;
}
async function grantUserPermission(
db: ReturnType<typeof createDb>,
companyId: string,
userId: string,
permissionKey: PermissionKey,
scope: Record<string, unknown> | null = null,
) {
await db.insert(companyMemberships).values({
companyId,
principalType: "user",
principalId: userId,
status: "active",
membershipRole: "operator",
});
await db.insert(principalPermissionGrants).values({
companyId,
principalType: "user",
principalId: userId,
permissionKey,
scope,
grantedByUserId: "owner",
});
}
describeEmbeddedPostgres("authorization service", () => {
let db!: ReturnType<typeof createDb>;
let tempDb: Awaited<ReturnType<typeof startEmbeddedPostgresTestDatabase>> | null = null;
it("defaults issue privacy to enforce while retaining explicit rollout overrides", () => {
const previousMode = process.env.PAPERCLIP_ISSUE_PRIVACY_MODE;
try {
delete process.env.PAPERCLIP_ISSUE_PRIVACY_MODE;
expect(issuePrivacyMode()).toBe("enforce");
process.env.PAPERCLIP_ISSUE_PRIVACY_MODE = "shadow";
expect(issuePrivacyMode()).toBe("shadow");
process.env.PAPERCLIP_ISSUE_PRIVACY_MODE = "off";
expect(issuePrivacyMode()).toBe("off");
} finally {
if (previousMode === undefined) delete process.env.PAPERCLIP_ISSUE_PRIVACY_MODE;
else process.env.PAPERCLIP_ISSUE_PRIVACY_MODE = previousMode;
}
});
beforeAll(async () => {
tempDb = await startEmbeddedPostgresTestDatabase("paperclip-authorization-service-");
db = createDb(tempDb.connectionString);
}, 20_000);
afterEach(async () => {
await db.delete(issueComments);
await db.delete(userInboxAgentPolicies);
await db.delete(principalPermissionGrants);
await db.delete(companyMemberships);
await db.delete(instanceUserRoles);
await db.delete(issueAccessGrants);
await db.delete(issues);
await db.delete(agents);
await db.delete(projects);
await db.delete(companies);
await db.delete(authUsers);
});
afterAll(async () => {
await tempDb?.cleanup();
});
it("allows active user role grants and explains the grant source", async () => {
const company = await createCompany(db, "UserGrant");
const userId = `user-${randomUUID()}`;
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: userId,
status: "active",
membershipRole: "operator",
});
await db.insert(principalPermissionGrants).values({
companyId: company.id,
principalType: "user",
principalId: userId,
permissionKey: "tasks:assign",
grantedByUserId: "owner",
});
const decision = await authorizationService(db).decidePrincipalGrant({
companyId: company.id,
principalType: "user",
principalId: userId,
action: "tasks:assign",
permissionKey: "tasks:assign",
});
expect(decision).toMatchObject({
allowed: true,
reason: "allow_explicit_grant",
grant: {
principalType: "user",
principalId: userId,
permissionKey: "tasks:assign",
},
});
expect(decision.explanation).toContain("Allowed by explicit grant tasks:assign");
});
it.each(["agent", "user"] as const)("allows %s read-only grants without configuration write authority", async (principalType) => {
const company = await createCompany(db, "ReadOnlyConfig");
const actorAgent = await createAgent(db, company.id);
const targetAgent = await createAgent(db, company.id);
const userId = await createUser(db);
const actor: AuthorizationActor = principalType === "agent"
? { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_key" }
: { type: "board", userId, source: "session" };
if (principalType === "agent") await grantAgentPermission(db, company.id, actorAgent.id, "agents:read");
else await grantUserPermission(db, company.id, userId, "agents:read");
const authz = authorizationService(db);
const resource = { type: "agent" as const, companyId: company.id, agentId: targetAgent.id };
await expect(authz.decide({ actor, action: "agent_config:read", resource })).resolves.toMatchObject({
allowed: true, grant: { permissionKey: "agents:read" },
});
for (const action of ["agent_config:update", "agent_instructions:update"] as const) {
await expect(authz.decide({ actor, action, resource, scope: { requiresChangeGrant: true } }))
.resolves.toMatchObject({ allowed: false });
}
});
it("restricts configuration reads to the read grant's target scope", async () => {
const company = await createCompany(db, "ScopedReadOnlyConfig");
const actor = await createAgent(db, company.id);
const target = await createAgent(db, company.id);
const other = await createAgent(db, company.id);
await grantAgentPermission(db, company.id, actor.id, "agents:read", { agentIds: [target.id] });
const authz = authorizationService(db);
const read = (targetAgentId: string) => authz.decide({
actor: { type: "agent", companyId: company.id, agentId: actor.id, source: "agent_key" },
action: "agent_config:read",
resource: { type: "agent", companyId: company.id, agentId: targetAgentId },
scope: { targetAgentId },
});
await expect(read(target.id)).resolves.toMatchObject({ allowed: true });
await expect(read(other.id)).resolves.toMatchObject({ allowed: false, reason: "deny_scope" });
await db.delete(principalPermissionGrants).where(eq(principalPermissionGrants.principalId, actor.id));
await expect(read(target.id)).resolves.toMatchObject({ allowed: false, reason: "deny_missing_grant" });
});
it("allows suggest grants to read peer agent configuration", async () => {
const company = await createCompany(db, "AgentReadGrant");
const actorAgent = await createAgent(db, company.id);
const targetAgent = await createAgent(db, company.id);
await grantAgentPermission(db, company.id, actorAgent.id, "agents:suggest-changes");
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_key" },
action: "agent_config:read",
resource: { type: "agent", companyId: company.id, agentId: targetAgent.id },
});
expect(decision).toMatchObject({
allowed: true,
reason: "allow_explicit_grant",
grant: {
principalType: "agent",
principalId: actorAgent.id,
permissionKey: "agents:suggest-changes",
},
});
});
it("reports a scoped legacy read grant denial when no read grant applies", async () => {
const company = await createCompany(db, "AgentReadScopedSuggestGrant");
const actorAgent = await createAgent(db, company.id);
const targetAgent = await createAgent(db, company.id);
await grantAgentPermission(db, company.id, actorAgent.id, "agents:suggest-changes", {
projectId: randomUUID(),
});
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_key" },
action: "agent_config:read",
resource: { type: "agent", companyId: company.id, agentId: targetAgent.id },
});
expect(decision).toMatchObject({
allowed: false,
reason: "deny_scope",
explanation: "Permission agents:suggest-changes does not cover the requested scope.",
});
});
it("enforces direct or consented suggest grants for agent configuration changes", async () => {
const company = await createCompany(db, "AgentChangeGrant");
const directAgent = await createAgent(db, company.id);
const suggestAgent = await createAgent(db, company.id);
const noGrantAgent = await createAgent(db, company.id);
const targetAgent = await createAgent(db, company.id);
await grantAgentPermission(db, company.id, directAgent.id, "agents:configure");
await grantAgentPermission(db, company.id, suggestAgent.id, "agents:suggest-changes");
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "agent",
principalId: noGrantAgent.id,
status: "active",
membershipRole: "member",
});
const authz = authorizationService(db);
await expect(authz.decide({
actor: { type: "agent", agentId: directAgent.id, companyId: company.id, source: "agent_key" },
action: "agent_config:update",
resource: { type: "agent", companyId: company.id, agentId: targetAgent.id },
scope: { requiresChangeGrant: true },
})).resolves.toMatchObject({
allowed: true,
reason: "allow_direct_change",
grant: { permissionKey: "agents:configure" },
});
await expect(authz.decide({
actor: { type: "agent", agentId: suggestAgent.id, companyId: company.id, source: "agent_key" },
action: "agent_config:update",
resource: { type: "agent", companyId: company.id, agentId: targetAgent.id },
scope: { requiresChangeGrant: true },
})).resolves.toMatchObject({
allowed: false,
reason: "deny_missing_consent",
grant: { permissionKey: "agents:suggest-changes" },
});
await expect(authz.decide({
actor: { type: "agent", agentId: suggestAgent.id, companyId: company.id, source: "agent_key" },
action: "agent_config:update",
resource: { type: "agent", companyId: company.id, agentId: targetAgent.id },
scope: { requiresChangeGrant: true, consentedChange: true },
})).resolves.toMatchObject({
allowed: true,
reason: "allow_consented_change",
grant: { permissionKey: "agents:suggest-changes" },
});
await expect(authz.decide({
actor: { type: "agent", agentId: noGrantAgent.id, companyId: company.id, source: "agent_key" },
action: "agent_config:update",
resource: { type: "agent", companyId: company.id, agentId: targetAgent.id },
scope: { requiresChangeGrant: true },
})).resolves.toMatchObject({
allowed: false,
reason: "deny_no_grant",
});
});
it("enforces direct or consented suggest grants for skill configuration changes", async () => {
const company = await createCompany(db, "SkillChangeGrant");
const directAgent = await createAgent(db, company.id);
const suggestAgent = await createAgent(db, company.id);
const noGrantAgent = await createAgent(db, company.id);
await grantAgentPermission(db, company.id, directAgent.id, "skills:create");
await grantAgentPermission(db, company.id, suggestAgent.id, "skills:suggest-changes");
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "agent",
principalId: noGrantAgent.id,
status: "active",
membershipRole: "member",
});
const authz = authorizationService(db);
await expect(authz.decide({
actor: { type: "agent", agentId: directAgent.id, companyId: company.id, source: "agent_key" },
action: "skill_config:update",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({
allowed: true,
reason: "allow_direct_change",
grant: { permissionKey: "skills:create" },
});
await expect(authz.decide({
actor: { type: "agent", agentId: suggestAgent.id, companyId: company.id, source: "agent_key" },
action: "skill_config:update",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({
allowed: false,
reason: "deny_missing_consent",
grant: { permissionKey: "skills:suggest-changes" },
});
await expect(authz.decide({
actor: { type: "agent", agentId: suggestAgent.id, companyId: company.id, source: "agent_key" },
action: "skill_config:update",
resource: { type: "company", companyId: company.id },
scope: { consentedChange: true },
})).resolves.toMatchObject({
allowed: true,
reason: "allow_consented_change",
grant: { permissionKey: "skills:suggest-changes" },
});
await expect(authz.decide({
actor: { type: "agent", agentId: noGrantAgent.id, companyId: company.id, source: "agent_key" },
action: "skill_config:update",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({
allowed: false,
reason: "deny_no_grant",
});
});
it("allows board users with direct skills:create grants to mutate company skills", async () => {
const company = await createCompany(db, "BoardUserSkillGrant");
const userId = await createUser(db);
await grantUserPermission(db, company.id, userId, "skills:create");
const decision = await authorizationService(db).decide({
actor: {
type: "board",
userId,
companyIds: [company.id],
source: "session",
},
action: "skill_config:update",
resource: { type: "company", companyId: company.id },
});
expect(decision).toMatchObject({
allowed: true,
reason: "allow_direct_change",
grant: {
principalType: "user",
principalId: userId,
permissionKey: "skills:create",
},
});
});
it("allows responsible-user JWT agents with direct skills:create grants to mutate company skills", async () => {
const company = await createCompany(db, "ResponsibleUserSkillGrant");
const actorAgent = await createAgent(db, company.id);
const responsibleUserId = await createUser(db);
await grantAgentPermission(db, company.id, actorAgent.id, "skills:create");
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "operator",
});
const decision = await authorizationService(db).decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "skill_config:update",
resource: { type: "company", companyId: company.id },
});
expect(decision).toMatchObject({
allowed: true,
reason: "allow_direct_change",
grant: {
principalType: "agent",
principalId: actorAgent.id,
permissionKey: "skills:create",
},
});
});
it("keeps responsible-user skill mutations denied for viewer memberships", async () => {
const company = await createCompany(db, "ResponsibleUserSkillViewerDenied");
const actorAgent = await createAgent(db, company.id);
const responsibleUserId = await createUser(db);
await grantAgentPermission(db, company.id, actorAgent.id, "skills:create");
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "viewer",
});
const decision = await authorizationService(db).decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "skill_config:update",
resource: { type: "company", companyId: company.id },
});
expect(decision).toMatchObject({
allowed: false,
code: "RESPONSIBLE_USER_UNAUTHORIZED",
});
expect(decision.explanation).toContain(`Responsible user ${responsibleUserId} is not authorized`);
});
it("denies cross-company agent decisions before grant evaluation", async () => {
const sourceCompany = await createCompany(db, "Source");
const targetCompany = await createCompany(db, "Target");
const actorAgent = await createAgent(db, sourceCompany.id);
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: sourceCompany.id, source: "agent_jwt" },
action: "tasks:assign",
resource: { type: "company", companyId: targetCompany.id },
});
expect(decision).toMatchObject({
allowed: false,
reason: "deny_company_boundary",
});
expect(decision.explanation).toContain("Agent key cannot access another company");
});
it("denies cross-company default-open issue writes", async () => {
const sourceCompany = await createCompany(db, "WriteSource");
const targetCompany = await createCompany(db, "WriteTarget");
const actorAgent = await createAgent(db, sourceCompany.id);
const targetIssue = await createIssue(db, targetCompany.id);
const authorization = authorizationService(db);
for (const action of ["issue:comment", "issue:mutate"] as const) {
await expect(authorization.decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: sourceCompany.id,
source: "agent_jwt",
},
action,
resource: {
type: "issue",
companyId: targetCompany.id,
issueId: targetIssue.id,
},
})).resolves.toMatchObject({
allowed: false,
reason: "deny_company_boundary",
});
}
});
it("allows simple-mode task assignment between same-company agents without explicit grants", async () => {
const company = await createCompany(db, "AssignmentDefault");
const actorAgent = await createAgent(db, company.id, { role: "engineer" });
const targetAgent = await createAgent(db, company.id, { role: "engineer" });
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "agent",
principalId: actorAgent.id,
status: "active",
membershipRole: "member",
});
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_key" },
action: "tasks:assign",
resource: { type: "issue", companyId: company.id, assigneeAgentId: targetAgent.id },
scope: { assigneeAgentId: targetAgent.id },
});
expect(decision).toMatchObject({
allowed: true,
reason: "allow_visible_issue_write",
});
expect(decision.explanation).toContain("shared default-open");
});
it("allows standard-trust agents to comment on and update visible peer-owned issues", async () => {
const company = await createCompany(db, "DefaultOpenPeerWrites");
const actorAgent = await createAgent(db, company.id);
const ownerAgent = await createAgent(db, company.id);
const issue = await createIssue(db, company.id, { assigneeAgentId: ownerAgent.id });
const actor = {
type: "agent" as const,
agentId: actorAgent.id,
companyId: company.id,
source: "agent_jwt" as const,
};
const resource = {
type: "issue" as const,
companyId: company.id,
issueId: issue.id,
assigneeAgentId: ownerAgent.id,
status: issue.status,
};
const authorization = authorizationService(db);
for (const action of ["issue:comment", "issue:mutate"] as const) {
await expect(authorization.decide({ actor, action, resource })).resolves.toMatchObject({
allowed: true,
reason: "allow_visible_issue_write",
});
}
});
it("keeps the responsible-user ceiling on every default-open peer write", async () => {
const company = await createCompany(db, "DefaultOpenPeerWriteCeiling");
const actorAgent = await createAgent(db, company.id);
const ownerAgent = await createAgent(db, company.id);
const issue = await createIssue(db, company.id, { assigneeAgentId: ownerAgent.id });
const unavailableUserId = await createUser(db);
const actor = {
type: "agent" as const,
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: unavailableUserId,
source: "agent_jwt" as const,
};
const resource = {
type: "issue" as const,
companyId: company.id,
issueId: issue.id,
assigneeAgentId: ownerAgent.id,
status: issue.status,
};
const authorization = authorizationService(db);
for (const action of ["issue:comment", "issue:mutate"] as const) {
await expect(authorization.decide({ actor, action, resource })).resolves.toMatchObject({
allowed: false,
code: "RESPONSIBLE_USER_UNAVAILABLE",
reason: "deny_missing_membership",
});
}
});
it("structurally keeps default-open comments inside issue visibility", async () => {
const company = await createCompany(db, "CommentReadSubset");
const project = await createProject(db, company.id, "Visible");
const outsideProject = await createProject(db, company.id, "Outside");
const rootIssueId = randomUUID();
const actorAgent = await createAgent(db, company.id, {
permissions: {
trustPreset: LOW_TRUST_REVIEW_PRESET,
authorizationPolicy: {
trustBoundary: {
mode: LOW_TRUST_REVIEW_PRESET,
projectIds: [project.id],
rootIssueId,
},
},
},
});
const ownerAgent = await createAgent(db, company.id);
const visibleIssue = await createIssue(db, company.id, {
id: rootIssueId,
projectId: project.id,
assigneeAgentId: ownerAgent.id,
});
const hiddenIssue = await createIssue(db, company.id, {
projectId: outsideProject.id,
assigneeAgentId: ownerAgent.id,
});
const actor = {
type: "agent" as const,
agentId: actorAgent.id,
companyId: company.id,
source: "agent_key" as const,
};
const authorization = authorizationService(db);
for (const issue of [visibleIssue, hiddenIssue]) {
const resource = {
type: "issue" as const,
companyId: company.id,
issueId: issue.id,
projectId: issue.projectId,
parentIssueId: issue.parentId,
assigneeAgentId: issue.assigneeAgentId,
status: issue.status,
};
const read = await authorization.decide({ actor, action: "issue:read", resource });
const comment = await authorization.decide({ actor, action: "issue:comment", resource });
expect(comment.allowed && !read.allowed).toBe(false);
}
});
it("does not let default-open non-assignee comments mint mention grants", async () => {
const company = await createCompany(db, "DefaultOpenMentionNonTransitive");
const ownerAgent = await createAgent(db, company.id);
const commentingAgent = await createAgent(db, company.id);
const mentionedAgent = await createAgent(db, company.id);
const issue = await createIssue(db, company.id, { assigneeAgentId: ownerAgent.id });
await db.insert(issueComments).values({
companyId: company.id,
issueId: issue.id,
authorAgentId: commentingAgent.id,
body: `[@Mentioned](agent://${mentionedAgent.id}) please take a look`,
});
await expect(authorizationService(db).decide({
actor: {
type: "agent",
agentId: mentionedAgent.id,
companyId: company.id,
source: "agent_jwt",
},
action: "issue:comment",
resource: {
type: "issue",
companyId: company.id,
issueId: issue.id,
assigneeAgentId: ownerAgent.id,
status: issue.status,
},
})).resolves.toMatchObject({
allowed: true,
reason: "allow_visible_issue_write",
});
});
it("denies delegated protected assignment when the responsible user lacks matching authority", async () => {
const company = await createCompany(db, "ResponsibleUserDenied");
const actorAgent = await createAgent(db, company.id, { role: "engineer" });
const ceoAgent = await createAgent(db, company.id, {
role: "ceo",
permissions: {
authorizationPolicy: {
assignmentPolicy: { mode: "protected" },
},
},
});
const responsibleUserId = await createUser(db);
await grantAgentPermission(db, company.id, actorAgent.id, "tasks:assign");
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "operator",
});
const decision = await authorizationService(db).decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "tasks:assign",
resource: { type: "issue", companyId: company.id, assigneeAgentId: ceoAgent.id },
scope: { assigneeAgentId: ceoAgent.id },
});
expect(decision).toMatchObject({
allowed: false,
code: "RESPONSIBLE_USER_UNAUTHORIZED",
});
});
it("allows active non-viewer responsible users to authorize assigned agent issue mutations", async () => {
const company = await createCompany(db, "ResponsibleUserIssueMutation");
const actorAgent = await createAgent(db, company.id, { role: "engineer" });
const issue = await createIssue(db, company.id, {
title: "Assigned issue mutation",
assigneeAgentId: actorAgent.id,
});
const responsibleUserId = await createUser(db);
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "operator",
});
await expect(authorizationService(db).decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "issue:mutate",
resource: {
type: "issue",
companyId: company.id,
issueId: issue.id,
assigneeAgentId: actorAgent.id,
},
})).resolves.toMatchObject({
allowed: true,
reason: "allow_self",
});
});
it("rechecks responsible-user membership on a new request actor after revocation", async () => {
const company = await createCompany(db, "ResponsibleUserRevocation");
const actorAgent = await createAgent(db, company.id, { role: "engineer" });
const issue = await createIssue(db, company.id, {
title: "Assigned issue mutation after revocation",
assigneeAgentId: actorAgent.id,
});
const responsibleUserId = await createUser(db);
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "operator",
});
const authz = authorizationService(db);
const resource = {
type: "issue" as const,
companyId: company.id,
issueId: issue.id,
assigneeAgentId: actorAgent.id,
};
await expect(authz.decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "issue:mutate",
resource,
})).resolves.toMatchObject({ allowed: true });
await db
.update(companyMemberships)
.set({ status: "suspended" })
.where(and(
eq(companyMemberships.companyId, company.id),
eq(companyMemberships.principalType, "user"),
eq(companyMemberships.principalId, responsibleUserId),
));
await expect(authz.decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "issue:mutate",
resource,
})).resolves.toMatchObject({
allowed: false,
code: "RESPONSIBLE_USER_UNAVAILABLE",
});
});
it("keeps responsible-user issue mutations denied for viewer memberships", async () => {
const company = await createCompany(db, "ResponsibleUserIssueViewerDenied");
const actorAgent = await createAgent(db, company.id, { role: "engineer" });
const issue = await createIssue(db, company.id, {
title: "Assigned viewer-denied mutation",
assigneeAgentId: actorAgent.id,
});
const responsibleUserId = await createUser(db);
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "viewer",
});
await expect(authorizationService(db).decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "issue:mutate",
resource: {
type: "issue",
companyId: company.id,
issueId: issue.id,
assigneeAgentId: actorAgent.id,
},
})).resolves.toMatchObject({
allowed: false,
code: "RESPONSIBLE_USER_UNAUTHORIZED",
reason: "deny_unsupported_action",
});
});
it("fails closed when the responsible user is unavailable", async () => {
const company = await createCompany(db, "ResponsibleUserUnavailable");
const actorAgent = await createAgent(db, company.id, { role: "engineer" });
const targetAgent = await createAgent(db, company.id, { role: "engineer" });
const decision = await authorizationService(db).decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: `missing-${randomUUID()}`,
source: "agent_jwt",
},
action: "tasks:assign",
resource: { type: "issue", companyId: company.id, assigneeAgentId: targetAgent.id },
scope: { assigneeAgentId: targetAgent.id },
});
expect(decision).toMatchObject({
allowed: false,
code: "RESPONSIBLE_USER_UNAVAILABLE",
});
});
it("allows delegated protected assignment when both agent and responsible user are authorized", async () => {
const company = await createCompany(db, "ResponsibleUserAllowed");
const actorAgent = await createAgent(db, company.id, { role: "engineer" });
const ceoAgent = await createAgent(db, company.id, {
role: "ceo",
permissions: {
authorizationPolicy: {
assignmentPolicy: { mode: "protected" },
},
},
});
const responsibleUserId = await createUser(db);
await grantAgentPermission(db, company.id, actorAgent.id, "tasks:assign");
await grantUserPermission(db, company.id, responsibleUserId, "tasks:assign");
const decision = await authorizationService(db).decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "tasks:assign",
resource: { type: "issue", companyId: company.id, assigneeAgentId: ceoAgent.id },
scope: { assigneeAgentId: ceoAgent.id },
});
expect(decision).toMatchObject({
allowed: true,
reason: "allow_explicit_grant",
});
});
it("limits low-trust issue reads to the configured project and root issue boundary", async () => {
const company = await createCompany(db, "LowTrustIssueReads");
const project = await createProject(db, company.id, "Allowed");
const otherProject = await createProject(db, company.id, "Denied");
const rootIssueId = randomUUID();
const actorAgent = await createAgent(db, company.id, {
permissions: {
trustPreset: LOW_TRUST_REVIEW_PRESET,
authorizationPolicy: {
trustBoundary: {
mode: LOW_TRUST_REVIEW_PRESET,
projectIds: [project.id],
rootIssueId,
},
},
},
});
const rootIssue = await createIssue(db, company.id, {
id: rootIssueId,
projectId: project.id,
assigneeAgentId: actorAgent.id,
});
const childIssue = await createIssue(db, company.id, {
projectId: project.id,
parentId: rootIssue.id,
});
const unrelatedIssue = await createIssue(db, company.id, {
projectId: otherProject.id,
});
const authorization = authorizationService(db);
const actor = { type: "agent" as const, agentId: actorAgent.id, companyId: company.id, source: "agent_key" as const };
const rootDecision = await authorization.decide({
actor,
action: "issue:read",
resource: {
type: "issue",
companyId: company.id,
issueId: rootIssue.id,
projectId: rootIssue.projectId,
parentIssueId: rootIssue.parentId,
assigneeAgentId: rootIssue.assigneeAgentId,
status: rootIssue.status,
},
});
const childDecision = await authorization.decide({
actor,
action: "issue:read",
resource: {
type: "issue",
companyId: company.id,
issueId: childIssue.id,
projectId: childIssue.projectId,
parentIssueId: childIssue.parentId,
status: childIssue.status,
},
});
const unrelatedDecision = await authorization.decide({
actor,
action: "issue:read",
resource: {
type: "issue",
companyId: company.id,
issueId: unrelatedIssue.id,
projectId: unrelatedIssue.projectId,
parentIssueId: unrelatedIssue.parentId,
status: unrelatedIssue.status,
},
});
expect(rootDecision).toMatchObject({ allowed: true, reason: "allow_low_trust_boundary" });
expect(childDecision).toMatchObject({ allowed: true, reason: "allow_low_trust_boundary" });
expect(unrelatedDecision).toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
});
it("blocks low-trust project, agent, company-wide, and outside-boundary assignment access", async () => {
const company = await createCompany(db, "LowTrustOtherResources");
const project = await createProject(db, company.id, "Allowed");
const otherProject = await createProject(db, company.id, "Denied");
const collaborator = await createAgent(db, company.id);
const higherTrustAgent = await createAgent(db, company.id, { role: "cto" });
const actorAgent = await createAgent(db, company.id, {
permissions: {
trustPreset: LOW_TRUST_REVIEW_PRESET,
authorizationPolicy: {
trustBoundary: {
mode: LOW_TRUST_REVIEW_PRESET,
projectIds: [project.id],
allowedAgentIds: [collaborator.id],
},
},
},
});
const authorization = authorizationService(db);
const actor = { type: "agent" as const, agentId: actorAgent.id, companyId: company.id, source: "agent_key" as const };
await expect(authorization.decide({
actor,
action: "project:read",
resource: { type: "project", companyId: company.id, projectId: project.id },
})).resolves.toMatchObject({ allowed: true, reason: "allow_low_trust_boundary" });
await expect(authorization.decide({
actor,
action: "project:read",
resource: { type: "project", companyId: company.id, projectId: otherProject.id },
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
await expect(authorization.decide({
actor,
action: "agent:read",
resource: { type: "agent", companyId: company.id, agentId: collaborator.id },
})).resolves.toMatchObject({ allowed: true, reason: "allow_low_trust_boundary" });
await expect(authorization.decide({
actor,
action: "agent:read",
resource: { type: "agent", companyId: company.id, agentId: higherTrustAgent.id },
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
await expect(authorization.decide({
actor,
action: "company_scope:read",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
await expect(authorization.decide({
actor,
action: "tasks:assign",
resource: {
type: "issue",
companyId: company.id,
projectId: project.id,
assigneeAgentId: collaborator.id,
},
scope: { projectId: project.id, assigneeAgentId: collaborator.id },
})).resolves.toMatchObject({ allowed: true, reason: "allow_simple_company_member" });
await expect(authorization.decide({
actor,
action: "tasks:assign",
resource: {
type: "issue",
companyId: company.id,
projectId: project.id,
assigneeAgentId: higherTrustAgent.id,
},
scope: { projectId: project.id, assigneeAgentId: higherTrustAgent.id },
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
});
it("blocks low-trust configuration actions before evaluating explicit change grants", async () => {
const company = await createCompany(db, "LowTrustConfigGrants");
const project = await createProject(db, company.id, "Allowed");
const targetAgent = await createAgent(db, company.id);
const actorAgent = await createAgent(db, company.id, {
role: "ceo",
permissions: {
trustPreset: LOW_TRUST_REVIEW_PRESET,
authorizationPolicy: {
trustBoundary: {
mode: LOW_TRUST_REVIEW_PRESET,
companyId: company.id,
projectIds: [project.id],
allowedAgentIds: [targetAgent.id],
},
},
},
});
await grantAgentPermission(db, company.id, actorAgent.id, "agents:configure");
await db.insert(principalPermissionGrants).values({
companyId: company.id,
principalType: "agent",
principalId: actorAgent.id,
permissionKey: "skills:create",
grantedByUserId: null,
});
const authz = authorizationService(db);
const actor = { type: "agent" as const, agentId: actorAgent.id, companyId: company.id, source: "agent_key" as const };
await expect(authz.decide({
actor,
action: "agent:read",
resource: { type: "agent", companyId: company.id, agentId: targetAgent.id },
})).resolves.toMatchObject({ allowed: true, reason: "allow_low_trust_boundary" });
await expect(authz.decide({
actor,
action: "agent_config:read",
resource: { type: "agent", companyId: company.id, agentId: targetAgent.id },
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
await expect(authz.decide({
actor,
action: "agent_config:read",
resource: { type: "agent", companyId: company.id, agentId: actorAgent.id },
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
await expect(authz.decide({
actor,
action: "agent_config:update",
resource: { type: "agent", companyId: company.id, agentId: targetAgent.id },
scope: { requiresChangeGrant: true, consentedChange: true },
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
await expect(authz.decide({
actor,
action: "skill_config:update",
resource: { type: "company", companyId: company.id },
scope: { consentedChange: true },
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
});
it("hard-blocks assignment when the target agent blocks protected assignment", async () => {
const company = await createCompany(db, "ProtectedAssignment");
const actorAgent = await createAgent(db, company.id, { role: "engineer" });
const targetAgent = await createAgent(db, company.id, {
role: "engineer",
permissions: {
authorizationPolicy: {
assignmentPolicy: {
mode: "protected",
},
protectedAgent: {
blockAssignment: true,
blockReason: "Production deployment authority",
},
managedBy: "permissions-extension",
},
},
});
await grantAgentPermission(db, company.id, actorAgent.id, "tasks:assign");
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_key" },
action: "tasks:assign",
resource: { type: "issue", companyId: company.id, assigneeAgentId: targetAgent.id },
scope: { assigneeAgentId: targetAgent.id },
});
expect(decision).toMatchObject({
allowed: false,
reason: "deny_policy_restricted",
});
expect(decision.explanation).toBe(
"Target agent assignment is blocked by protected-agent policy. " +
"A company administrator can remove the assignment block, then retry.",
);
expect(decision.explanation).not.toContain("approval");
});
it("keeps legacy protected-assignment approval flags as hard blocks without approval copy", async () => {
const company = await createCompany(db, "LegacyProtectedAssignment");
const actorAgent = await createAgent(db, company.id, { role: "engineer" });
const targetAgent = await createAgent(db, company.id, {
role: "engineer",
permissions: {
authorizationPolicy: {
assignmentPolicy: {
mode: "protected",
protectedAgentRequiresApproval: true,
},
protectedAgent: {
requiresApproval: true,
},
},
},
});
await grantAgentPermission(db, company.id, actorAgent.id, "tasks:assign");
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_key" },
action: "tasks:assign",
resource: { type: "issue", companyId: company.id, assigneeAgentId: targetAgent.id },
scope: { assigneeAgentId: targetAgent.id },
});
expect(decision).toMatchObject({
allowed: false,
reason: "deny_policy_restricted",
});
expect(decision.explanation).toContain("assignment is blocked");
expect(decision.explanation).toContain("company administrator");
expect(decision.explanation).not.toContain("approval");
});
it("requires an explicit grant before assigning to a private target agent", async () => {
const company = await createCompany(db, "PrivateAssignment");
const actorAgent = await createAgent(db, company.id, { role: "engineer" });
const targetAgent = await createAgent(db, company.id, {
role: "engineer",
permissions: {
authorizationPolicy: {
agentVisibility: {
mode: "private",
hiddenFromDefaultDirectory: true,
},
assignmentPolicy: {
mode: "company_default",
protectedAgentRequiresApproval: false,
},
protectedAgent: {
requiresApproval: false,
},
managedBy: "permissions-extension",
},
},
});
const denied = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_key" },
action: "tasks:assign",
resource: { type: "issue", companyId: company.id, assigneeAgentId: targetAgent.id },
scope: { assigneeAgentId: targetAgent.id },
});
await grantAgentPermission(db, company.id, actorAgent.id, "tasks:assign_scope", {
assigneeAgentId: targetAgent.id,
});
const allowed = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_key" },
action: "tasks:assign",
resource: { type: "issue", companyId: company.id, assigneeAgentId: targetAgent.id },
scope: { assigneeAgentId: targetAgent.id },
});
expect(denied).toMatchObject({
allowed: false,
reason: "deny_policy_restricted",
});
expect(denied.explanation).toContain("private");
expect(allowed).toMatchObject({
allowed: true,
reason: "allow_explicit_grant",
grant: { permissionKey: "tasks:assign_scope" },
});
});
it("allows simple-mode task assignment for active same-company board operators without explicit grants", async () => {
const company = await createCompany(db, "BoardAssignmentDefault");
const userId = `user-${randomUUID()}`;
const targetAgent = await createAgent(db, company.id, { role: "engineer" });
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: userId,
status: "active",
membershipRole: "operator",
});
const decision = await authorizationService(db).decide({
actor: { type: "board", userId, source: "session" },
action: "tasks:assign",
resource: { type: "issue", companyId: company.id, assigneeAgentId: targetAgent.id },
scope: { assigneeAgentId: targetAgent.id },
});
expect(decision).toMatchObject({
allowed: true,
reason: "allow_simple_company_member",
});
});
it("allows null-mapped visibility actions for active same-company board members", async () => {
const company = await createCompany(db, "BoardVisibility");
const userId = `user-${randomUUID()}`;
const project = await createProject(db, company.id, "Visible");
const targetAgent = await createAgent(db, company.id, { role: "engineer" });
const issue = await createIssue(db, company.id, { projectId: project.id });
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: userId,
status: "active",
membershipRole: "member",
});
const authorization = authorizationService(db);
const actor = { type: "board" as const, userId, source: "session" as const };
await expect(authorization.decide({
actor,
action: "agent:read",
resource: { type: "agent", companyId: company.id, agentId: targetAgent.id },
})).resolves.toMatchObject({ allowed: true, reason: "allow_simple_company_member" });
await expect(authorization.decide({
actor,
action: "company_scope:read",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({ allowed: true, reason: "allow_simple_company_member" });
await expect(authorization.decide({
actor,
action: "project:read",
resource: { type: "project", companyId: company.id, projectId: project.id },
})).resolves.toMatchObject({ allowed: true, reason: "allow_simple_company_member" });
await expect(authorization.decide({
actor,
action: "issue:read",
resource: {
type: "issue",
companyId: company.id,
issueId: issue.id,
projectId: issue.projectId,
parentIssueId: issue.parentId,
status: issue.status,
},
})).resolves.toMatchObject({ allowed: true, reason: "allow_simple_company_member" });
await expect(authorization.decide({
actor,
action: "runtime:manage",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({ allowed: true, reason: "allow_simple_company_member" });
await expect(authorization.decide({
actor,
action: "secrets:read",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({ allowed: true, reason: "allow_simple_company_member" });
});
it("allows same-company non-viewer board members to comment and mutate issues assigned to another agent", async () => {
const company = await createCompany(db, "BoardIssueMutation");
const userId = `user-${randomUUID()}`;
const assignee = await createAgent(db, company.id, { role: "engineer" });
const issue = await createIssue(db, company.id, { assigneeAgentId: assignee.id });
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: userId,
status: "active",
membershipRole: "operator",
});
const authorization = authorizationService(db);
const actor = { type: "board" as const, userId, source: "board_key" as const };
const resource = {
type: "issue" as const,
companyId: company.id,
issueId: issue.id,
projectId: issue.projectId,
parentIssueId: issue.parentId,
assigneeAgentId: issue.assigneeAgentId,
assigneeUserId: issue.assigneeUserId,
status: issue.status,
};
await expect(authorization.decide({
actor,
action: "issue:comment",
resource,
})).resolves.toMatchObject({ allowed: true, reason: "allow_simple_company_member" });
await expect(authorization.decide({
actor,
action: "issue:mutate",
resource,
})).resolves.toMatchObject({ allowed: true, reason: "allow_simple_company_member" });
});
it("denies same-company viewer board members issue comment and mutation", async () => {
const company = await createCompany(db, "BoardViewerIssueMutation");
const userId = `user-${randomUUID()}`;
const assignee = await createAgent(db, company.id, { role: "engineer" });
const issue = await createIssue(db, company.id, { assigneeAgentId: assignee.id });
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: userId,
status: "active",
membershipRole: "viewer",
});
const authorization = authorizationService(db);
const actor = { type: "board" as const, userId, source: "board_key" as const };
const resource = {
type: "issue" as const,
companyId: company.id,
issueId: issue.id,
projectId: issue.projectId,
parentIssueId: issue.parentId,
assigneeAgentId: issue.assigneeAgentId,
assigneeUserId: issue.assigneeUserId,
status: issue.status,
};
await expect(authorization.decide({
actor,
action: "issue:comment",
resource,
})).resolves.toMatchObject({ allowed: false, reason: "deny_missing_grant" });
await expect(authorization.decide({
actor,
action: "issue:mutate",
resource,
})).resolves.toMatchObject({ allowed: false, reason: "deny_missing_grant" });
});
it("denies null-mapped visibility actions for board users without an active membership", async () => {
const memberCompany = await createCompany(db, "BoardVisibilityMember");
const otherCompany = await createCompany(db, "BoardVisibilityOther");
const userId = `user-${randomUUID()}`;
const targetAgent = await createAgent(db, otherCompany.id, { role: "engineer" });
const inactiveUserId = `user-${randomUUID()}`;
await db.insert(companyMemberships).values({
companyId: memberCompany.id,
principalType: "user",
principalId: userId,
status: "active",
membershipRole: "member",
});
await db.insert(companyMemberships).values({
companyId: otherCompany.id,
principalType: "user",
principalId: inactiveUserId,
status: "removed",
membershipRole: "member",
});
const authorization = authorizationService(db);
await expect(authorization.decide({
actor: { type: "board", userId, source: "session" },
action: "agent:read",
resource: { type: "agent", companyId: otherCompany.id, agentId: targetAgent.id },
})).resolves.toMatchObject({ allowed: false, reason: "deny_missing_membership" });
await expect(authorization.decide({
actor: { type: "board", userId: inactiveUserId, source: "session" },
action: "company_scope:read",
resource: { type: "company", companyId: otherCompany.id },
})).resolves.toMatchObject({ allowed: false, reason: "deny_missing_membership" });
});
it("allows legacy member roles to wake agents while rejecting incomplete task mutation scope", async () => {
const company = await createCompany(db, "BoardWake");
const userId = `user-${randomUUID()}`;
const targetAgent = await createAgent(db, company.id, { role: "engineer" });
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: userId,
status: "active",
membershipRole: "member",
});
const authorization = authorizationService(db);
await expect(authorization.decide({
actor: { type: "board", userId, source: "session" },
action: "agent:wake",
resource: { type: "agent", companyId: company.id, agentId: targetAgent.id },
})).resolves.toMatchObject({
allowed: true,
reason: "allow_simple_company_member",
});
const issue = await createIssue(db, company.id, { title: "Wake denied issue" });
await expect(authorization.decide({
actor: { type: "board", userId, source: "session" },
action: "issue:mutate",
resource: { type: "issue", companyId: company.id, issueId: issue.id },
})).resolves.toMatchObject({
allowed: false,
reason: "deny_unsupported_action",
});
});
it("allows mentioned agents to read and comment on assigned issues without granting issue mutation", async () => {
const company = await createCompany(db, "MentionCommentAuth");
const allowedProject = await createProject(db, company.id, "MentionAllowed");
const targetProject = await createProject(db, company.id, "MentionTarget");
const ownerAgent = await createAgent(db, company.id, { role: "engineer" });
const mentionedAgent = await createAgent(db, company.id, {
role: "engineer",
permissions: {
trustPreset: LOW_TRUST_REVIEW_PRESET,
authorizationPolicy: {
trustBoundary: {
mode: LOW_TRUST_REVIEW_PRESET,
companyId: company.id,
projectIds: [allowedProject.id],
},
},
},
});
const issue = await createIssue(db, company.id, {
title: "Mention-scoped comment target",
projectId: targetProject.id,
assigneeAgentId: ownerAgent.id,
});
const authorization = authorizationService(db);
const actor = { type: "agent", agentId: mentionedAgent.id, companyId: company.id, source: "agent_key" } as const;
const resource = {
type: "issue",
companyId: company.id,
issueId: issue.id,
projectId: issue.projectId,
assigneeAgentId: ownerAgent.id,
status: issue.status,
} as const;
await expect(authorization.decide({
actor,
action: "issue:comment",
resource,
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
const deletedMention = await db.insert(issueComments).values({
companyId: company.id,
issueId: issue.id,
body: `[@Mentioned Agent](agent://${mentionedAgent.id}) this deleted comment should not count`,
deletedAt: new Date(),
}).returning().then((rows) => rows[0]!);
expect(deletedMention.id).toBeTruthy();
await expect(authorization.decide({
actor,
action: "issue:comment",
resource,
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
await db.insert(issueComments).values({
companyId: company.id,
issueId: issue.id,
body: `[@Mentioned Agent](agent://${mentionedAgent.id}) please respond here`,
authorAgentId: ownerAgent.id,
});
await expect(authorization.decide({
actor,
action: "issue:read",
resource,
})).resolves.toMatchObject({
allowed: true,
reason: "allow_issue_mention_grant",
});
await expect(authorization.decide({
actor,
action: "issue:comment",
resource,
})).resolves.toMatchObject({
allowed: true,
reason: "allow_issue_mention_grant",
});
await expect(authorization.decide({
actor,
action: "issue:mutate",
resource,
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
});
it("allows a mentioned non-assignee to comment when the mention author is the issue assignee", async () => {
const company = await createCompany(db, "MentionCommentAssigneeGrant");
const allowedProject = await createProject(db, company.id, "MentionAssigneeAllowed");
const targetProject = await createProject(db, company.id, "MentionAssigneeTarget");
const assigneeAgent = await createAgent(db, company.id, { role: "coach" });
const mentionedAgent = await createAgent(db, company.id, {
role: "qa",
permissions: {
trustPreset: LOW_TRUST_REVIEW_PRESET,
authorizationPolicy: {
trustBoundary: {
mode: LOW_TRUST_REVIEW_PRESET,
companyId: company.id,
projectIds: [allowedProject.id],
},
},
},
});
const issue = await createIssue(db, company.id, {
title: "Assignee-authored mention reply target",
projectId: targetProject.id,
assigneeAgentId: assigneeAgent.id,
});
await db.insert(issueComments).values({
companyId: company.id,
issueId: issue.id,
authorAgentId: assigneeAgent.id,
authorType: "agent",
body: `[@QA](agent://${mentionedAgent.id}) please reply on this issue.`,
});
await expect(authorizationService(db).decide({
actor: { type: "agent", agentId: mentionedAgent.id, companyId: company.id, source: "agent_key" },
action: "issue:comment",
resource: {
type: "issue",
companyId: company.id,
issueId: issue.id,
projectId: issue.projectId,
assigneeAgentId: assigneeAgent.id,
status: issue.status,
},
})).resolves.toMatchObject({
allowed: true,
reason: "allow_issue_mention_grant",
});
});
it("does not grant mention-scoped issue access from self-authored or unauthorized-author comments", async () => {
const company = await createCompany(db, "MentionCommentDenied");
const allowedProject = await createProject(db, company.id, "MentionDeniedAllowed");
const targetProject = await createProject(db, company.id, "MentionDeniedTarget");
const ownerAgent = await createAgent(db, company.id, { role: "engineer" });
const mentionedAgent = await createAgent(db, company.id, {
role: "engineer",
permissions: {
trustPreset: LOW_TRUST_REVIEW_PRESET,
authorizationPolicy: {
trustBoundary: {
mode: LOW_TRUST_REVIEW_PRESET,
companyId: company.id,
projectIds: [allowedProject.id],
},
},
},
});
const unrelatedAgent = await createAgent(db, company.id, { role: "engineer" });
const issue = await createIssue(db, company.id, {
title: "Mention-scoped comment denial target",
projectId: targetProject.id,
assigneeAgentId: ownerAgent.id,
});
const authorization = authorizationService(db);
const actor = { type: "agent", agentId: mentionedAgent.id, companyId: company.id, source: "agent_key" } as const;
const resource = {
type: "issue",
companyId: company.id,
issueId: issue.id,
projectId: issue.projectId,
assigneeAgentId: ownerAgent.id,
status: issue.status,
} as const;
await db.insert(issueComments).values([
{
companyId: company.id,
issueId: issue.id,
body: `Self mention [@Mentioned Agent](agent://${mentionedAgent.id})`,
authorAgentId: mentionedAgent.id,
},
{
companyId: company.id,
issueId: issue.id,
body: `Unauthorized mention [@Mentioned Agent](agent://${mentionedAgent.id})`,
authorAgentId: unrelatedAgent.id,
},
]);
await expect(authorization.decide({
actor,
action: "issue:read",
resource,
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
await expect(authorization.decide({
actor,
action: "issue:comment",
resource,
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
});
it("allows active board-user comments to create mention-scoped issue grants", async () => {
const company = await createCompany(db, "MentionCommentBoardGrant");
const allowedProject = await createProject(db, company.id, "MentionBoardAllowed");
const targetProject = await createProject(db, company.id, "MentionBoardTarget");
const ownerAgent = await createAgent(db, company.id, { role: "engineer" });
const mentionedAgent = await createAgent(db, company.id, {
role: "engineer",
permissions: {
trustPreset: LOW_TRUST_REVIEW_PRESET,
authorizationPolicy: {
trustBoundary: {
mode: LOW_TRUST_REVIEW_PRESET,
companyId: company.id,
projectIds: [allowedProject.id],
},
},
},
});
const issue = await createIssue(db, company.id, {
title: "Mention-scoped board grant target",
projectId: targetProject.id,
assigneeAgentId: ownerAgent.id,
});
const boardUserId = `user-${randomUUID()}`;
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: boardUserId,
status: "active",
membershipRole: "member",
});
await db.insert(issueComments).values({
companyId: company.id,
issueId: issue.id,
body: `Board mention [@Mentioned Agent](agent://${mentionedAgent.id})`,
authorUserId: boardUserId,
});
const actor = { type: "agent", agentId: mentionedAgent.id, companyId: company.id, source: "agent_key" } as const;
const resource = {
type: "issue",
companyId: company.id,
issueId: issue.id,
projectId: issue.projectId,
assigneeAgentId: ownerAgent.id,
status: issue.status,
} as const;
await expect(authorizationService(db).decide({
actor,
action: "issue:comment",
resource,
})).resolves.toMatchObject({
allowed: true,
reason: "allow_issue_mention_grant",
});
});
it.each(["session", "cloud_tenant"] as const)("allows %s operators to start agents, without granting hiring rights", async (source) => {
const company = await createCompany(db, "wake");
const agent = await createAgent(db, company.id);
const userId = await createUser(db);
await db.insert(companyMemberships).values({ companyId: company.id,
principalType: "user", principalId: userId, status: "active", membershipRole: "operator" });
const auth = authorizationService(db);
const actor = { type: "board" as const, source, userId, companyIds: [company.id] };
const resource = { type: "agent" as const, companyId: company.id, agentId: agent.id };
expect(await auth.decide({ actor, action: "agent:wake", resource })).toMatchObject({ allowed: true });
expect(await auth.decide({ actor, action: "agents:create", resource: { type: "company", companyId: company.id } })).toMatchObject({ allowed: false });
await db.update(companyMemberships).set({ membershipRole: "viewer" }).where(eq(companyMemberships.principalId, userId));
expect(await auth.decide({ actor, action: "agent:wake", resource })).toMatchObject({ allowed: false });
await db.update(companyMemberships).set({ membershipRole: "operator", status: "suspended" }).where(eq(companyMemberships.principalId, userId));
expect(await auth.decide({ actor, action: "agent:wake", resource })).toMatchObject({ allowed: false });
const otherCompany = await createCompany(db, "other-wake");
expect(await auth.decide({ actor, action: "agent:wake", resource: { ...resource, companyId: otherCompany.id } })).toMatchObject({ allowed: false });
});
it.each(["session", "cloud_tenant"] as const)("restricts %s workspace-owner stop confirmation to administrators", async source => {
const company = await createCompany(db, "OwnerStop");
const otherCompany = await createCompany(db, "OtherOwnerStop");
const userId = await createUser(db);
await db.insert(companyMemberships).values({ companyId: company.id,
principalType: "user", principalId: userId, status: "active", membershipRole: "owner" });
const actor = { type: "board" as const, source, userId, companyIds: [company.id] };
const auth = authorizationService(db);
const request = { actor, action: "runtime:confirm_owner_stop" as const,
resource: { type: "company" as const, companyId: company.id } };
for (const membershipRole of ["owner", "admin", "operator", "member", "viewer", null]) {
await db.update(companyMemberships).set({ membershipRole }).where(eq(companyMemberships.principalId, userId));
expect((await auth.decide(request)).allowed, `role ${membershipRole}`).toBe(membershipRole === "owner" || membershipRole === "admin");
}
await db.update(companyMemberships).set({ membershipRole: "admin", status: "suspended" }).where(eq(companyMemberships.principalId, userId));
expect((await auth.decide(request)).allowed).toBe(false);
await db.update(companyMemberships).set({ status: "active" }).where(eq(companyMemberships.principalId, userId));
expect((await auth.decide({ ...request, resource: { type: "company", companyId: otherCompany.id } })).allowed).toBe(false);
});
it("does not allow agent delegation or stale cloud admin rows to confirm an owner stop", async () => {
const company = await createCompany(db, "OwnerStopDelegation");
const userId = await createUser(db);
const agent = await createAgent(db, company.id, { role: "ceo" });
await db.insert(companyMemberships).values({ companyId: company.id,
principalType: "user", principalId: userId, status: "active", membershipRole: "operator" });
await db.insert(instanceUserRoles).values({ userId, role: "instance_admin" });
const auth = authorizationService(db);
const request = { action: "runtime:confirm_owner_stop" as const, resource: { type: "company" as const, companyId: company.id } };
expect((await auth.decide({ ...request, actor: { type: "board", userId, source: "cloud_tenant", isInstanceAdmin: false } })).allowed).toBe(false);
expect((await auth.decide({ ...request, actor: { type: "agent", agentId: agent.id, companyId: company.id, onBehalfOfUserId: userId } })).allowed).toBe(false);
expect((await auth.decide({ ...request, actor: { type: "board", userId, source: "cloud_tenant", isInstanceAdmin: true } })).allowed).toBe(true);
expect((await auth.decide({ ...request, actor: { type: "board", source: "local_implicit" } })).allowed).toBe(true);
});
it("limits viewer members to read-only visibility actions", async () => {
const company = await createCompany(db, "BoardViewerVisibility");
const userId = `user-${randomUUID()}`;
const targetAgent = await createAgent(db, company.id, { role: "engineer" });
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: userId,
status: "active",
membershipRole: "viewer",
});
const authorization = authorizationService(db);
const actor = { type: "board", userId, source: "session" } as const;
await expect(authorization.decide({
actor,
action: "agent:read",
resource: { type: "agent", companyId: company.id, agentId: targetAgent.id },
})).resolves.toMatchObject({ allowed: true, reason: "allow_simple_company_member" });
await expect(authorization.decide({
actor,
action: "company_scope:read",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({ allowed: true, reason: "allow_simple_company_member" });
await expect(authorization.decide({
actor,
action: "runtime:manage",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({ allowed: false, reason: "deny_missing_grant" });
await expect(authorization.decide({
actor,
action: "secrets:read",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({ allowed: false, reason: "deny_missing_grant" });
});
it("denies legacy board assignment context for viewers", async () => {
const company = await createCompany(db, "BoardViewerAssignment");
const userId = `user-${randomUUID()}`;
const targetAgent = await createAgent(db, company.id, { role: "engineer" });
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: userId,
status: "active",
membershipRole: "viewer",
});
const decision = await authorizationService(db).decide({
actor: { type: "board", userId, companyIds: [company.id], source: "session" },
action: "tasks:assign",
resource: { type: "issue", companyId: company.id, assigneeAgentId: targetAgent.id },
scope: { assigneeAgentId: targetAgent.id },
});
expect(decision).toMatchObject({
allowed: false,
reason: "deny_missing_grant",
});
});
it("never elevates cloud_tenant actors through stale instance_admin rows", async () => {
const tenantCompany = await createCompany(db, "CloudTenantStale");
const otherCompany = await createCompany(db, "CloudTenantOther");
const userId = `user-${randomUUID()}`;
const targetAgent = await createAgent(db, otherCompany.id, { role: "engineer" });
await db.insert(companyMemberships).values({
companyId: tenantCompany.id,
principalType: "user",
principalId: userId,
status: "active",
membershipRole: "owner",
});
// Stale grant left behind by a pre-hardening cloud_tenant deployment.
await db.insert(instanceUserRoles).values({ userId, role: "instance_admin" });
const decision = await authorizationService(db).decide({
actor: {
type: "board",
userId,
companyIds: [tenantCompany.id],
isInstanceAdmin: false,
source: "cloud_tenant",
},
action: "tasks:assign",
resource: { type: "issue", companyId: otherCompany.id, assigneeAgentId: targetAgent.id },
scope: { assigneeAgentId: targetAgent.id },
});
expect(decision.allowed).toBe(false);
expect(decision.reason).not.toBe("allow_instance_admin");
// Control: the instanceUserRoles lookup still elevates non-cloud_tenant
// board actors, so the carve-out is scoped to the tenant contract only.
const sessionDecision = await authorizationService(db).decide({
actor: { type: "board", userId, companyIds: [tenantCompany.id], source: "session" },
action: "tasks:assign",
resource: { type: "issue", companyId: otherCompany.id, assigneeAgentId: targetAgent.id },
scope: { assigneeAgentId: targetAgent.id },
});
expect(sessionDecision).toMatchObject({ allowed: true, reason: "allow_instance_admin" });
});
it("trusts the computed isInstanceAdmin flag on cloud_tenant actors", async () => {
// The trusted-header resolver is the only code path that can set
// isInstanceAdmin on a cloud_tenant actor (stack owner +
// enableOwnerInstanceAdmin). The authorization service must honor the
// computed flag without consulting instance_user_roles.
const tenantCompany = await createCompany(db, "CloudTenantOwnerAdmin");
const otherCompany = await createCompany(db, "CloudTenantOwnerAdminOther");
const userId = `user-${randomUUID()}`;
const targetAgent = await createAgent(db, otherCompany.id, { role: "engineer" });
await db.insert(companyMemberships).values({
companyId: tenantCompany.id,
principalType: "user",
principalId: userId,
status: "active",
membershipRole: "owner",
});
// Deliberately NO instanceUserRoles row: elevation is computed, not stored.
const decision = await authorizationService(db).decide({
actor: {
type: "board",
userId,
companyIds: [tenantCompany.id],
isInstanceAdmin: true,
source: "cloud_tenant",
},
action: "tasks:assign",
resource: { type: "issue", companyId: otherCompany.id, assigneeAgentId: targetAgent.id },
scope: { assigneeAgentId: targetAgent.id },
});
expect(decision).toMatchObject({ allowed: true, reason: "allow_instance_admin" });
});
it("denies simple-mode assignment to a target agent from another company", async () => {
const sourceCompany = await createCompany(db, "AssignmentSource");
const targetCompany = await createCompany(db, "AssignmentTarget");
const actorAgent = await createAgent(db, sourceCompany.id, { role: "engineer" });
const targetAgent = await createAgent(db, targetCompany.id, { role: "engineer" });
await db.insert(companyMemberships).values({
companyId: sourceCompany.id,
principalType: "agent",
principalId: actorAgent.id,
status: "active",
membershipRole: "member",
});
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: sourceCompany.id, source: "agent_key" },
action: "tasks:assign",
resource: { type: "issue", companyId: sourceCompany.id, assigneeAgentId: targetAgent.id },
scope: { assigneeAgentId: targetAgent.id },
});
expect(decision).toMatchObject({
allowed: false,
reason: "deny_company_boundary",
});
});
it("preserves legacy CEO agent creator authority", async () => {
const company = await createCompany(db, "Legacy");
const actorAgent = await createAgent(db, company.id, { role: "ceo" });
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_jwt" },
action: "agents:create",
resource: { type: "company", companyId: company.id },
});
expect(decision).toMatchObject({
allowed: true,
reason: "allow_legacy_agent_creator",
});
});
it("honors a board-recorded hiring denial on a CEO instead of the CEO title", async () => {
const company = await createCompany(db, "CeoHireDenied");
const actorAgent = await createAgent(db, company.id, {
role: "ceo",
permissions: { canCreateAgents: false, canCreateSkills: true, ceoHiringDeniedBy: { actorType: "user", actorId: "board-user", at: "2026-11-08T00:00:00.000Z" } },
});
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_jwt" },
action: "agents:create",
resource: { type: "company", companyId: company.id },
});
expect(decision).toMatchObject({
allowed: false,
reason: "deny_missing_grant",
explanation: "Missing permission: agents:create.",
});
});
it("keeps CEO hiring when a false was saved without a board-recorded denial", async () => {
// Stale full-object saves, import updates and the low-trust default can
// all save false on a CEO without the board choosing to restrict it.
const company = await createCompany(db, "CeoUnrecordedFalse");
const actorAgent = await createAgent(db, company.id, {
role: "ceo",
permissions: { canCreateAgents: false, canCreateSkills: true },
});
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_jwt" },
action: "agents:create",
resource: { type: "company", companyId: company.id },
});
expect(decision).toMatchObject({ allowed: true, reason: "allow_legacy_agent_creator" });
});
it("grants hire authority through the persisted new-agent default", async () => {
const company = await createCompany(db, "DefaultHire");
// The service create path persists the create-context default
// (canCreateAgents: true for standard trust); enforcement reads it back.
const actorAgent = await createAgent(db, company.id, {
role: "engineer",
permissions: { canCreateAgents: true, canCreateSkills: true },
});
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_jwt" },
action: "agents:create",
resource: { type: "company", companyId: company.id },
});
expect(decision).toMatchObject({
allowed: true,
reason: "allow_legacy_agent_creator",
});
});
it("keeps legacy rows without an explicit canCreateAgents fail-closed", async () => {
const company = await createCompany(db, "LegacyRowFailClosed");
const actorAgent = await createAgent(db, company.id, { role: "engineer", permissions: {} });
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_jwt" },
action: "agents:create",
resource: { type: "company", companyId: company.id },
});
expect(decision).toMatchObject({
allowed: false,
reason: "deny_missing_grant",
});
});
it("denies agent creation for a low-trust boundary even with explicit canCreateAgents", async () => {
const company = await createCompany(db, "LowTrustHireDenied");
const project = await createProject(db, company.id, "Contained");
const actorAgent = await createAgent(db, company.id, {
permissions: {
canCreateAgents: true,
trustPreset: LOW_TRUST_REVIEW_PRESET,
authorizationPolicy: {
trustBoundary: {
mode: LOW_TRUST_REVIEW_PRESET,
projectIds: [project.id],
},
},
},
});
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_jwt" },
action: "agents:create",
resource: { type: "company", companyId: company.id },
});
expect(decision).toMatchObject({
allowed: false,
reason: "deny_low_trust_boundary",
});
});
it("denies active-checkout management outside the CEO caller company scope", async () => {
const sourceCompany = await createCompany(db, "CheckoutSource");
const targetCompany = await createCompany(db, "CheckoutTarget");
const actorAgent = await createAgent(db, sourceCompany.id, { role: "ceo" });
const targetAgent = await createAgent(db, targetCompany.id, { role: "engineer" });
const decision = await authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: sourceCompany.id, source: "agent_jwt" },
action: "tasks:manage_active_checkouts",
resource: { type: "issue", companyId: targetCompany.id, assigneeAgentId: targetAgent.id },
});
expect(decision).toMatchObject({
allowed: false,
reason: "deny_company_boundary",
});
expect(decision.explanation).toContain("another company");
});
it("allows scoped assignment inside a granted project and denies other projects", async () => {
const company = await createCompany(db, "ProjectScope");
const project = await createProject(db, company.id, "Allowed");
const otherProject = await createProject(db, company.id, "Denied");
const actorAgent = await createAgent(db, company.id);
const targetAgent = await createAgent(db, company.id);
await grantAgentPermission(db, company.id, actorAgent.id, "tasks:assign_scope", {
projectIds: [project.id],
});
const allowed = await authorizationService(db).decidePrincipalGrant({
companyId: company.id,
principalType: "agent",
principalId: actorAgent.id,
action: "tasks:assign",
permissionKey: "tasks:assign_scope",
scope: { projectId: project.id, assigneeAgentId: targetAgent.id },
});
const denied = await authorizationService(db).decidePrincipalGrant({
companyId: company.id,
principalType: "agent",
principalId: actorAgent.id,
action: "tasks:assign",
permissionKey: "tasks:assign_scope",
scope: { projectId: otherProject.id, assigneeAgentId: targetAgent.id },
});
expect(allowed).toMatchObject({
allowed: true,
grant: { permissionKey: "tasks:assign_scope" },
});
expect(denied).toMatchObject({
allowed: false,
reason: "deny_scope",
});
expect(denied.explanation).toContain("does not cover the requested scope");
});
it("treats unknown grant scope metadata as unconstrained", async () => {
const company = await createCompany(db, "UnknownScopeMetadata");
const actorAgent = await createAgent(db, company.id);
const targetAgent = await createAgent(db, company.id);
await grantAgentPermission(db, company.id, actorAgent.id, "tasks:assign_scope", {
note: "CEO-approved",
});
const decision = await authorizationService(db).decidePrincipalGrant({
companyId: company.id,
principalType: "agent",
principalId: actorAgent.id,
action: "tasks:assign",
permissionKey: "tasks:assign_scope",
scope: { assigneeAgentId: targetAgent.id },
});
expect(decision).toMatchObject({
allowed: true,
grant: { permissionKey: "tasks:assign_scope" },
});
});
it("allows scoped assignment to agents inside a managed subtree only", async () => {
const company = await createCompany(db, "SubtreeScope");
const actorAgent = await createAgent(db, company.id);
const managerAgent = await createAgent(db, company.id);
const childAgent = await createAgent(db, company.id, { reportsTo: managerAgent.id });
const grandchildAgent = await createAgent(db, company.id, { reportsTo: childAgent.id });
const outsideAgent = await createAgent(db, company.id);
await grantAgentPermission(db, company.id, actorAgent.id, "tasks:assign_scope", {
managedSubtreeAgentIds: [managerAgent.id],
});
const allowed = await authorizationService(db).decidePrincipalGrant({
companyId: company.id,
principalType: "agent",
principalId: actorAgent.id,
action: "tasks:assign",
permissionKey: "tasks:assign_scope",
scope: { assigneeAgentId: grandchildAgent.id },
});
const denied = await authorizationService(db).decidePrincipalGrant({
companyId: company.id,
principalType: "agent",
principalId: actorAgent.id,
action: "tasks:assign",
permissionKey: "tasks:assign_scope",
scope: { assigneeAgentId: outsideAgent.id },
});
expect(allowed.allowed).toBe(true);
expect(allowed.grant?.permissionKey).toBe("tasks:assign_scope");
expect(denied).toMatchObject({
allowed: false,
reason: "deny_scope",
});
});
it("allows scoped assignment to an explicit target-agent allowlist only", async () => {
const company = await createCompany(db, "AllowlistScope");
const actorAgent = await createAgent(db, company.id);
const allowedTarget = await createAgent(db, company.id);
const deniedTarget = await createAgent(db, company.id);
await grantAgentPermission(db, company.id, actorAgent.id, "tasks:assign_scope", {
assigneeAgentIds: [allowedTarget.id],
});
const allowed = await authorizationService(db).decidePrincipalGrant({
companyId: company.id,
principalType: "agent",
principalId: actorAgent.id,
action: "tasks:assign",
permissionKey: "tasks:assign_scope",
scope: { assigneeAgentId: allowedTarget.id },
});
const denied = await authorizationService(db).decidePrincipalGrant({
companyId: company.id,
principalType: "agent",
principalId: actorAgent.id,
action: "tasks:assign",
permissionKey: "tasks:assign_scope",
scope: { assigneeAgentId: deniedTarget.id },
});
expect(allowed.allowed).toBe(true);
expect(denied.allowed).toBe(false);
});
it("preserves unscoped tasks:assign compatibility for assignment decisions", async () => {
const company = await createCompany(db, "BroadAssign");
const actorAgent = await createAgent(db, company.id);
const targetAgent = await createAgent(db, company.id);
await grantAgentPermission(db, company.id, actorAgent.id, "tasks:assign");
const decision = await authorizationService(db).decidePrincipalGrant({
companyId: company.id,
principalType: "agent",
principalId: actorAgent.id,
action: "tasks:assign",
permissionKey: "tasks:assign",
scope: { assigneeAgentId: targetAgent.id },
});
expect(decision).toMatchObject({
allowed: true,
grant: { permissionKey: "tasks:assign" },
});
});
it("scopes task bridge JWTs away from company-wide reads and unrelated issue writes", async () => {
const company = await createCompany(db, "TaskBridge");
const bridgeAgent = await createAgent(db, company.id);
const targetAgent = await createAgent(db, company.id);
const project = await createProject(db, company.id, "Bridge");
const parentIssue = await createIssue(db, company.id, { projectId: project.id });
const assignedIssue = await createIssue(db, company.id, { assigneeAgentId: bridgeAgent.id });
const keyId = randomUUID();
const bridgeCreatedIssue = await createIssue(db, company.id, {
originKind: "task_bridge",
originId: keyId,
});
const unrelatedIssue = await createIssue(db, company.id);
const actor = {
type: "agent" as const,
agentId: bridgeAgent.id,
companyId: company.id,
source: "agent_jwt" as const,
keyId,
keyScope: {
kind: "task_bridge" as const,
parentIssueId: parentIssue.id,
allowedAssigneeAgentIds: [targetAgent.id],
},
};
const authz = authorizationService(db);
await expect(authz.decide({
actor,
action: "company_scope:read",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({
allowed: false,
reason: "deny_scope",
});
await expect(authz.decide({
actor,
action: "tasks:assign",
resource: {
type: "issue",
companyId: company.id,
parentIssueId: parentIssue.id,
assigneeAgentId: targetAgent.id,
},
})).resolves.toMatchObject({
allowed: true,
});
await expect(authz.decide({
actor,
action: "tasks:assign",
resource: {
type: "issue",
companyId: company.id,
projectId: project.id,
assigneeUserId: randomUUID(),
},
})).resolves.toMatchObject({
allowed: false,
reason: "deny_scope",
});
await expect(authz.decide({
actor,
action: "issue:comment",
resource: {
type: "issue",
companyId: company.id,
issueId: assignedIssue.id,
},
})).resolves.toMatchObject({
allowed: true,
});
await expect(authz.decide({
actor,
action: "issue:mutate",
resource: {
type: "issue",
companyId: company.id,
issueId: bridgeCreatedIssue.id,
},
})).resolves.toMatchObject({
allowed: true,
});
await expect(authz.decide({
actor,
action: "issue:mutate",
resource: {
type: "issue",
companyId: company.id,
issueId: unrelatedIssue.id,
},
})).resolves.toMatchObject({
allowed: false,
reason: "deny_scope",
});
await expect(authz.decide({
actor,
action: "agent_config:read",
resource: {
type: "agent",
companyId: company.id,
agentId: bridgeAgent.id,
},
})).resolves.toMatchObject({
allowed: false,
reason: "deny_scope",
});
});
it("scopes skill-test keys to their own issue only", async () => {
const company = await createCompany(db, "SkillTest");
const skillTestAgent = await createAgent(db, company.id);
const ownIssue = await createIssue(db, company.id, { assigneeAgentId: skillTestAgent.id });
const otherIssue = await createIssue(db, company.id);
const actor = {
type: "agent" as const,
agentId: skillTestAgent.id,
companyId: company.id,
source: "agent_key" as const,
keyScope: {
kind: "skill_test" as const,
issueId: ownIssue.id,
},
};
const authz = authorizationService(db);
for (const action of ["issue:read", "issue:comment", "issue:mutate"] as const) {
await expect(authz.decide({
actor,
action,
resource: {
type: "issue",
companyId: company.id,
issueId: ownIssue.id,
},
})).resolves.toMatchObject({
allowed: true,
});
}
await expect(authz.decide({
actor,
action: "issue:mutate",
resource: {
type: "issue",
companyId: company.id,
issueId: otherIssue.id,
},
})).resolves.toMatchObject({
allowed: false,
reason: "deny_scope",
});
await expect(authz.decide({
actor,
action: "company_scope:read",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({
allowed: false,
reason: "deny_scope",
});
await expect(authz.decide({
actor,
action: "tasks:assign",
resource: {
type: "issue",
companyId: company.id,
parentIssueId: ownIssue.id,
assigneeAgentId: skillTestAgent.id,
},
})).resolves.toMatchObject({
allowed: false,
reason: "deny_scope",
});
});
it("allows responsible-user inbox management by default", async () => {
const company = await createCompany(db, "InboxDefaultOpen");
const actorAgent = await createAgent(db, company.id);
const responsibleUserId = await createUser(db);
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "operator",
});
await expect(authorizationService(db).decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "inbox:manage",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({
allowed: true,
reason: "allow_self",
inboxPolicyMode: "open",
});
});
it("denies responsible-user inbox management when disabled", async () => {
const company = await createCompany(db, "InboxDisabled");
const actorAgent = await createAgent(db, company.id);
const responsibleUserId = await createUser(db);
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "operator",
});
await db.insert(userInboxAgentPolicies).values({
companyId: company.id,
userId: responsibleUserId,
mode: "disabled",
});
await expect(authorizationService(db).decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "inbox:manage",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({ allowed: false, reason: "inbox_management_disabled" });
});
it("enforces responsible-user inbox allowlists", async () => {
const company = await createCompany(db, "InboxAllowlist");
const allowedAgent = await createAgent(db, company.id);
const deniedAgent = await createAgent(db, company.id);
const responsibleUserId = await createUser(db);
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "operator",
});
await db.insert(userInboxAgentPolicies).values({
companyId: company.id,
userId: responsibleUserId,
mode: "allowlist",
allowedAgentIds: [allowedAgent.id],
});
const decideFor = (agentId: string) => authorizationService(db).decide({
actor: {
type: "agent" as const,
agentId,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt" as const,
},
action: "inbox:manage" as const,
resource: { type: "company" as const, companyId: company.id },
});
await expect(decideFor(allowedAgent.id)).resolves.toMatchObject({
allowed: true,
reason: "allow_self",
inboxPolicyMode: "allowlist",
});
await expect(decideFor(deniedAgent.id)).resolves.toMatchObject({
allowed: false,
reason: "inbox_agent_not_allowed",
});
});
it("requires a grant for cross-user inbox management", async () => {
const company = await createCompany(db, "InboxCrossUserDenied");
const actorAgent = await createAgent(db, company.id);
const responsibleUserId = await createUser(db);
const targetUserId = await createUser(db);
await db.insert(companyMemberships).values([
{
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "operator",
},
{
companyId: company.id,
principalType: "user",
principalId: targetUserId,
status: "active",
membershipRole: "operator",
},
]);
await expect(authorizationService(db).decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "inbox:manage",
resource: { type: "company", companyId: company.id },
scope: { userId: targetUserId },
})).resolves.toMatchObject({ allowed: false, reason: "deny_missing_grant" });
});
it("honors a target user's saved inbox policy for cross-user management", async () => {
const company = await createCompany(db, "InboxCrossUserPolicy");
const actorAgent = await createAgent(db, company.id);
const deniedAgent = await createAgent(db, company.id);
const responsibleUserId = await createUser(db);
const allowlistTargetUserId = await createUser(db);
const openTargetUserId = await createUser(db);
await db.insert(companyMemberships).values([
{
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "operator",
},
{
companyId: company.id,
principalType: "user",
principalId: allowlistTargetUserId,
status: "active",
membershipRole: "operator",
},
{
companyId: company.id,
principalType: "user",
principalId: openTargetUserId,
status: "active",
membershipRole: "operator",
},
]);
await db.insert(userInboxAgentPolicies).values([
{
companyId: company.id,
userId: allowlistTargetUserId,
mode: "allowlist",
allowedAgentIds: [actorAgent.id],
},
{
companyId: company.id,
userId: openTargetUserId,
mode: "open",
},
]);
const decideFor = (agentId: string, userId: string) => authorizationService(db).decide({
actor: {
type: "agent" as const,
agentId,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt" as const,
},
action: "inbox:manage" as const,
resource: { type: "company" as const, companyId: company.id },
scope: { userId },
});
await expect(decideFor(actorAgent.id, allowlistTargetUserId)).resolves.toMatchObject({
allowed: true,
reason: "allow_user_inbox_policy",
inboxPolicyMode: "allowlist",
});
await expect(decideFor(deniedAgent.id, allowlistTargetUserId)).resolves.toMatchObject({
allowed: false,
reason: "inbox_agent_not_allowed",
});
await expect(decideFor(actorAgent.id, openTargetUserId)).resolves.toMatchObject({
allowed: true,
reason: "allow_user_inbox_policy",
inboxPolicyMode: "open",
});
});
it("allows cross-user inbox management with an unscoped grant", async () => {
const company = await createCompany(db, "InboxCrossUserGranted");
const actorAgent = await createAgent(db, company.id);
const responsibleUserId = await createUser(db);
const targetUserId = await createUser(db);
await db.insert(companyMemberships).values([
{
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "operator",
},
{
companyId: company.id,
principalType: "user",
principalId: targetUserId,
status: "active",
membershipRole: "operator",
},
]);
await grantAgentPermission(db, company.id, actorAgent.id, "inbox:manage");
await expect(authorizationService(db).decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "inbox:manage",
resource: { type: "company", companyId: company.id },
scope: { userId: targetUserId },
})).resolves.toMatchObject({ allowed: true, reason: "allow_explicit_grant" });
});
it("keeps a default inbox grant within the responsible user's policy", async () => {
const company = await createCompany(db, "InboxDefaultScoped");
const actorAgent = await createAgent(db, company.id);
const responsibleUserId = await createUser(db);
const disabledUserId = await createUser(db);
const disallowedUserId = await createUser(db);
await db.insert(companyMemberships).values(
[responsibleUserId, disabledUserId, disallowedUserId].map((principalId) => ({
companyId: company.id,
principalType: "user" as const,
principalId,
status: "active" as const,
membershipRole: "operator" as const,
})),
);
await db.insert(userInboxAgentPolicies).values([
{ companyId: company.id, userId: disabledUserId, mode: "disabled" },
{ companyId: company.id, userId: disallowedUserId, mode: "allowlist", allowedAgentIds: [] },
]);
await grantAgentPermission(db, company.id, actorAgent.id, "inbox:manage", { responsibleUserOnly: true });
const decideFor = (userId: string) => authorizationService(db).decide({
actor: {
type: "agent" as const,
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt" as const,
},
action: "inbox:manage" as const,
resource: { type: "company" as const, companyId: company.id },
scope: { userId },
});
await expect(decideFor(responsibleUserId)).resolves.toMatchObject({ allowed: true, reason: "allow_self" });
await expect(decideFor(disabledUserId)).resolves.toMatchObject({ allowed: false, reason: "inbox_management_disabled" });
await expect(decideFor(disallowedUserId)).resolves.toMatchObject({ allowed: false, reason: "inbox_agent_not_allowed" });
});
it("enforces user-scoped cross-user inbox grants", async () => {
const company = await createCompany(db, "InboxCrossUserScoped");
const actorAgent = await createAgent(db, company.id);
const responsibleUserId = await createUser(db);
const allowedTargetUserId = await createUser(db);
const deniedTargetUserId = await createUser(db);
await db.insert(companyMemberships).values([
{
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "operator",
},
{
companyId: company.id,
principalType: "user",
principalId: allowedTargetUserId,
status: "active",
membershipRole: "operator",
},
{
companyId: company.id,
principalType: "user",
principalId: deniedTargetUserId,
status: "active",
membershipRole: "operator",
},
]);
await grantAgentPermission(db, company.id, actorAgent.id, "inbox:manage", {
userIds: [allowedTargetUserId],
});
const decideFor = (userId: string) => authorizationService(db).decide({
actor: {
type: "agent" as const,
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt" as const,
},
action: "inbox:manage" as const,
resource: { type: "company" as const, companyId: company.id },
scope: { userId },
});
await expect(decideFor(allowedTargetUserId)).resolves.toMatchObject({
allowed: true,
reason: "allow_explicit_grant",
});
await expect(decideFor(deniedTargetUserId)).resolves.toMatchObject({ allowed: false, reason: "deny_scope" });
});
it("denies inbox management when the target user cannot be resolved", async () => {
const company = await createCompany(db, "InboxUnresolved");
const actorAgent = await createAgent(db, company.id);
await expect(authorizationService(db).decide({
actor: { type: "agent", agentId: actorAgent.id, companyId: company.id, source: "agent_key" },
action: "inbox:manage",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({ allowed: false, reason: "inbox_target_user_unresolved" });
});
it("denies low-trust inbox management", async () => {
const company = await createCompany(db, "InboxLowTrust");
const project = await createProject(db, company.id, "InboxLowTrust");
const responsibleUserId = await createUser(db);
const actorAgent = await createAgent(db, company.id, {
permissions: {
trustPreset: LOW_TRUST_REVIEW_PRESET,
authorizationPolicy: {
trustBoundary: {
mode: LOW_TRUST_REVIEW_PRESET,
companyId: company.id,
projectIds: [project.id],
},
},
},
});
await db.insert(companyMemberships).values({
companyId: company.id,
principalType: "user",
principalId: responsibleUserId,
status: "active",
membershipRole: "operator",
});
await expect(authorizationService(db).decide({
actor: {
type: "agent",
agentId: actorAgent.id,
companyId: company.id,
onBehalfOfUserId: responsibleUserId,
source: "agent_jwt",
},
action: "inbox:manage",
resource: { type: "company", companyId: company.id },
})).resolves.toMatchObject({ allowed: false, reason: "deny_low_trust_boundary" });
});
it("enforces private issue implicit principals, grants, revocation, and subtree inheritance", async () => {
const previousMode = process.env.PAPERCLIP_ISSUE_PRIVACY_MODE;
const previousTtl = process.env.PAPERCLIP_ISSUE_PRIVACY_CACHE_TTL_MS;
process.env.PAPERCLIP_ISSUE_PRIVACY_MODE = "enforce";
process.env.PAPERCLIP_ISSUE_PRIVACY_CACHE_TTL_MS = "5000";
try {
const company = await createCompany(db, "IssuePrivacy");
const ownerId = await createUser(db);
const memberId = await createUser(db);
const granteeId = await createUser(db);
await db.insert(companyMemberships).values([ownerId, memberId, granteeId].map((principalId) => ({
companyId: company.id,
principalType: "user",
principalId,
status: "active",
membershipRole: "operator",
})));
const assignedAgent = await createAgent(db, company.id);
const otherAgent = await createAgent(db, company.id);
const authz = authorizationService(db);
const userActor = (userId: string): AuthorizationActor => ({ type: "board", userId, source: "session" });
const agentActor = (agentId: string): AuthorizationActor => ({
type: "agent",
agentId,
companyId: company.id,
source: "agent_key",
});
const decide = (actor: AuthorizationActor, issue: Awaited<ReturnType<typeof createIssue>>) => authz.decide({
actor,
action: "issue:read",
resource: { type: "issue", companyId: company.id, issueId: issue.id },
});
const openIssue = await createIssue(db, company.id);
await expect(decide(userActor(memberId), openIssue)).resolves.toMatchObject({ allowed: true });
const privateRootId = randomUUID();
const privateRoot = await createIssue(db, company.id, {
id: privateRootId,
visibility: "private",
privacyRootIssueId: privateRootId,
responsibleUserId: ownerId,
assigneeAgentId: assignedAgent.id,
});
await expect(decide(userActor(memberId), privateRoot)).resolves.toMatchObject({
allowed: false,
reason: "deny_issue_private",
});
await expect(decide(agentActor(otherAgent.id), privateRoot)).resolves.toMatchObject({
allowed: false,
reason: "deny_issue_private",
});
await expect(decide(userActor(ownerId), privateRoot)).resolves.toMatchObject({ allowed: true });
await expect(decide(agentActor(assignedAgent.id), privateRoot)).resolves.toMatchObject({ allowed: true });
const grant = await db.insert(issueAccessGrants).values({
issueId: privateRoot.id,
subjectType: "user",
subjectId: granteeId,
source: "explicit",
grantedByUserId: ownerId,
}).returning().then((rows) => rows[0]!);
await expect(decide(userActor(granteeId), privateRoot)).resolves.toMatchObject({ allowed: true });
const child = await createIssue(db, company.id, {
parentId: privateRoot.id,
privacyParentIssueId: privateRoot.id,
visibility: "private",
privacyRootIssueId: privateRoot.id,
});
await expect(decide(userActor(granteeId), child)).resolves.toMatchObject({ allowed: true });
await db.update(issueAccessGrants).set({ revokedAt: new Date() }).where(eq(issueAccessGrants.id, grant.id));
await expect(decide(userActor(granteeId), privateRoot)).resolves.toMatchObject({
allowed: false,
reason: "deny_issue_private",
});
process.env.PAPERCLIP_ISSUE_PRIVACY_MODE = "shadow";
const warn = vi.spyOn(logger, "warn").mockImplementation(() => logger);
await expect(decide(userActor(memberId), privateRoot)).resolves.toMatchObject({ allowed: true });
expect(warn).toHaveBeenCalledWith(
expect.objectContaining({
authzMode: "shadow",
issueId: privateRoot.id,
reason: "deny_issue_private",
}),
"issue privacy would deny read",
);
warn.mockRestore();
} finally {
if (previousMode === undefined) delete process.env.PAPERCLIP_ISSUE_PRIVACY_MODE;
else process.env.PAPERCLIP_ISSUE_PRIVACY_MODE = previousMode;
if (previousTtl === undefined) delete process.env.PAPERCLIP_ISSUE_PRIVACY_CACHE_TTL_MS;
else process.env.PAPERCLIP_ISSUE_PRIVACY_CACHE_TTL_MS = previousTtl;
}
});
it("uses private-project membership as the same issue-read predicate while preserving issue grants", async () => {
const previousMode = process.env.PAPERCLIP_ISSUE_PRIVACY_MODE;
process.env.PAPERCLIP_ISSUE_PRIVACY_MODE = "enforce";
try {
const company = await createCompany(db, "ProjectPrivacy");
const memberId = await createUser(db);
const granteeId = await createUser(db);
const outsiderId = await createUser(db);
await db.insert(companyMemberships).values([memberId, granteeId, outsiderId].map((principalId) => ({
companyId: company.id,
principalType: "user" as const,
principalId,
status: "active",
membershipRole: "operator",
})));
const project = await createProject(db, company.id, "Private", "private");
const memberAgent = await createAgent(db, company.id);
const outsiderAgent = await createAgent(db, company.id);
await db.insert(companyMemberships).values([memberAgent.id, outsiderAgent.id].map((principalId) => ({
companyId: company.id,
principalType: "agent" as const,
principalId,
status: "active",
membershipRole: "member",
})));
await db.insert(projectAccessMembers).values({
companyId: company.id,
projectId: project.id,
subjectType: "user",
subjectId: memberId,
});
await db.insert(projectAccessMembers).values({
companyId: company.id,
projectId: project.id,
subjectType: "agent",
subjectId: memberAgent.id,
});
const issue = await createIssue(db, company.id, { projectId: project.id });
await db.insert(issueAccessGrants).values({
issueId: issue.id,
subjectType: "user",
subjectId: granteeId,
source: "explicit",
grantedByUserId: memberId,
});
const authz = authorizationService(db);
const decideProject = (userId: string) => authz.decide({
actor: { type: "board", userId, source: "session" },
action: "project:read",
resource: { type: "project", companyId: company.id, projectId: project.id },
});
const decideIssue = (userId: string) => authz.decide({
actor: { type: "board", userId, source: "session" },
action: "issue:read",
resource: { type: "issue", companyId: company.id, issueId: issue.id },
});
const decideProjectAsAgent = (agentId: string) => authz.decide({
actor: { type: "agent", agentId, companyId: company.id, source: "agent_key" },
action: "project:read",
resource: { type: "project", companyId: company.id, projectId: project.id },
});
const decideIssueAsAgent = (agentId: string) => authz.decide({
actor: { type: "agent", agentId, companyId: company.id, source: "agent_key" },
action: "issue:read",
resource: { type: "issue", companyId: company.id, issueId: issue.id },
});
await expect(decideProject(memberId)).resolves.toMatchObject({ allowed: true });
await expect(decideProject(outsiderId)).resolves.toMatchObject({
allowed: false,
reason: "deny_project_private",
});
await expect(decideIssue(memberId)).resolves.toMatchObject({ allowed: true });
await expect(decideIssue(granteeId)).resolves.toMatchObject({ allowed: true });
await expect(decideIssue(outsiderId)).resolves.toMatchObject({
allowed: false,
reason: "deny_issue_private",
});
await expect(decideProjectAsAgent(memberAgent.id)).resolves.toMatchObject({ allowed: true });
await expect(decideIssueAsAgent(memberAgent.id)).resolves.toMatchObject({ allowed: true });
await expect(decideProjectAsAgent(outsiderAgent.id)).resolves.toMatchObject({
allowed: false,
reason: "deny_project_private",
});
await expect(decideIssueAsAgent(outsiderAgent.id)).resolves.toMatchObject({
allowed: false,
reason: "deny_issue_private",
});
} finally {
if (previousMode === undefined) delete process.env.PAPERCLIP_ISSUE_PRIVACY_MODE;
else process.env.PAPERCLIP_ISSUE_PRIVACY_MODE = previousMode;
}
});
it("denies secrets proposals for scoped tokens regardless of request source", async () => {
const company = await createCompany(db, "SecretProposalScopes");
const actorAgent = await createAgent(db, company.id);
const resource = { type: "company" as const, companyId: company.id };
const authz = authorizationService(db);
for (const actor of [
{
type: "agent" as const,
agentId: actorAgent.id,
companyId: company.id,
source: "agent_jwt" as const,
keyId: randomUUID(),
keyScope: { kind: "task_bridge" as const, parentIssueId: randomUUID() },
},
{
type: "agent" as const,
agentId: actorAgent.id,
companyId: company.id,
source: "agent_jwt" as const,
keyScope: { kind: "skill_test" as const, issueId: randomUUID() },
},
]) {
await expect(authz.decide({ actor, action: "secrets:propose", resource }))
.resolves.toMatchObject({ allowed: false, reason: "deny_scope" });
}
});
});