mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 16:27:18 +02:00
Third PR: depends on #15728 and #15727. The user has reviewed and authorized merging this experimental feature stack. ## Thinking Path > - Paperclip manages agent work through tasks and governed connections. > - Chat connections already bind external conversations to those tasks. > - Speko handles voice and telephony, while the selected Paperclip agent does the work. > - A call needs durable session authority, ordered follow-ups, and safe result delivery. > - This PR adds repeatable qualification for the Speko voice task integration. > - This PR depends on #15728, which depends on #15727. Speko stays experimental. ## Linked Issues or Issue Description **Problem or motivation** Phone and browser voice conversations cannot use the chat connection task lifecycle. A separate voice runtime is needed to preserve task authority, retries, and reply history. **Proposed solution** Add company-scoped voice sessions, signed callbacks, durable replies, inbound intake, and an agent-facing outbound-call tool. Reuse existing tasks, queues, secrets, and publications. **Roadmap alignment** This extends the experimental chat connector entry points under Agent Chat and Connected Apps. The project owner requested this feature. Refs #11418 for the original provider catalog proposal. This implementation uses the newer chat connection infrastructure rather than an MCP catalog-only integration. Refs #15721 for remote OpenCode startup. ## What Changed - Add a real Paperclip server/database E2E fixture that stubs only external Speko transport and the execution provider. - Add authenticated multi-user and cross-company qualification journeys. - Add Storybook interaction, accessibility, responsive, and visual-suite integration. - Add an E01–E16 runbook, component-to-story inventory, and current redacted qualification report. - Keep historical private call traces out of the PR. Provider proof tools are opt-in. ## Verification - All 21 standalone proof tests and browser client/server syntax checks pass. They cover signatures, redaction, cleanup retry, final audio saves, bounded report transport and late server write ordering. No live calls were placed. - All 27 focused UI/controller regressions, UI typecheck, token gates, and 28 map/catalog structural tests pass. The shared connection cache test covers pause/resume invalidation during the 30-second fresh period. - Storybook builds 157 Speko production-component stories. The complete prior 156-story set passed all 624 checks on UI source249cbc616a. After the final cache repair, all 152 affected page/launcher checks passed across both themes, 390/1200 widths and reduced motion. Real microphone access and external provider requests are blocked. - Hosted Storybook origin isolation and representative narrow-screen stories pass. Provider requests remain blocked. - Source annotations follow the current generated-catalog contract. No generated catalog or lockfile is included. Three inherited GitHub-heading tests passed after master reconciliation. - Commit905bc5da5dhas 55 passing checks, including required verify/E2E gates, and a fresh Greptile 5/5 review with zero unresolved findings. Local fixture success does not establish provider or spoken-playback acceptance. - The separate integrated browser run passed two journeys and failed browser answer retrieval. Real browser/telephone playback and timing acceptance remain outstanding. See the dated qualification report and E01–E16 runbook. Speko stays experimental. ## Risks - Voice sessions add migrations and provider-dependent lifecycle behavior. Migrations preserve existing chat and AI transports. - Callback origins must be reachable HTTPS. Provider keys and signing secrets remain vaulted. - Unverified callers receive task-scoped low-trust authority. Caller ID does not grant private task access. - Outbound telephony incurs provider charges. Provider acceptance is not proof that the caller heard an answer. - Keep the feature behind the existing experimental chat setting until the real browser, inbound, outbound, and delayed-result acceptance matrix passes. ## Model Used OpenAI Codex, GPT-6, with tool use and code execution. The exact serving model ID and context window are not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
67 lines
6.0 KiB
TypeScript
67 lines
6.0 KiB
TypeScript
import { test, expect, type APIRequestContext } from "@playwright/test";
|
|
import { randomBytes, randomUUID } from "node:crypto";
|
|
import { readFile } from "node:fs/promises";
|
|
import { resolve } from "node:path";
|
|
const origin = "http://127.0.0.1:3482";
|
|
|
|
test("E03/E14: real signed-in callers cannot substitute companies, private tasks or another caller; revoked members can hang up", async ({ browser, page }, info) => {
|
|
const memberContext = await browser.newContext(), outsiderContext = await browser.newContext(), anonymousContext = await browser.newContext();
|
|
const request = async (api: APIRequestContext, method: "POST" | "PATCH", path: string, data: unknown) => {
|
|
const response = await api.fetch(`${origin}/api${path}`, { method, headers: { Origin: origin }, data });
|
|
expect(response.ok(), `${method} ${path}: ${response.status()} ${await response.text()}`).toBe(true);
|
|
return response.json();
|
|
};
|
|
const signUp = (api: APIRequestContext, name: string) => request(api, "POST", "/auth/sign-up/email", { name, email: `${randomUUID()}@example.test`, password: randomBytes(24).toString("base64url") });
|
|
try {
|
|
await signUp(page.request, "Voice operator");
|
|
await request(page.request, "POST", "/bootstrap/claim", {});
|
|
const member = await signUp(memberContext.request, "Voice member");
|
|
await signUp(outsiderContext.request, "Other company member");
|
|
const company = await request(page.request, "POST", "/companies", { name: "Private voice company" });
|
|
const other = await request(page.request, "POST", "/companies", { name: "Other voice company" });
|
|
const invite = async (api: APIRequestContext, companyId: string) => {
|
|
const invitation = await request(page.request, "POST", `/companies/${companyId}/invites`, { allowedJoinTypes: "human", humanRole: "operator" });
|
|
const token = new URL(invitation.inviteUrl, origin).pathname.split("/").at(-1);
|
|
await request(api, "POST", `/invites/${token}/accept`, { requestType: "human" });
|
|
};
|
|
await invite(memberContext.request, company.id); await invite(outsiderContext.request, other.id);
|
|
await request(page.request, "PATCH", `/companies/${company.id}`, { requireBoardApprovalForNewAgents: false });
|
|
const agent = await request(page.request, "POST", `/companies/${company.id}/agents`, { name: "Voice worker", role: "general", adapterType: "process", adapterConfig: { command: "fixture" }, runtimeConfig: { heartbeat: { enabled: false, wakeOnDemand: true } } });
|
|
await expect.poll(async () => (await (await page.request.get(`${origin}/api/agents/${agent.id}`)).json()).status).toBe("idle");
|
|
const endpoint = await request(memberContext.request, "POST", `/companies/${company.id}/chat-endpoints`, { provider: "speko", assignedAgentId: agent.id });
|
|
const configured = await request(memberContext.request, "POST", `/chat-endpoints/${endpoint.id}/setup`, { action: "configure", credentials: { apiKey: "fixture-speko-key", agentId: "agent_member", signingSecret: `whsec_${randomBytes(32).toString("base64")}` } });
|
|
expect(configured.setup.step).toBe("test");
|
|
const privateTask = await request(page.request, "POST", `/companies/${company.id}/issues`, { title: "Private task", status: "backlog", assigneeAgentId: agent.id, visibility: "private" });
|
|
const start = (api: APIRequestContext, companyId = company.id, issueId?: string) => api.post(`${origin}/api/companies/${companyId}/voice-sessions`, { headers: { Origin: origin }, data: { endpointId: endpoint.id, ...(issueId ? { issueId } : {}), idempotencyKey: randomUUID() } });
|
|
expect([401, 403]).toContain((await start(anonymousContext.request)).status());
|
|
expect((await start(outsiderContext.request)).status()).toBe(403);
|
|
expect([403, 404]).toContain((await start(memberContext.request, other.id)).status());
|
|
expect([403, 404]).toContain((await start(memberContext.request, company.id, privateTask.id)).status());
|
|
const created = await start(memberContext.request);
|
|
expect(created.status()).toBe(201);
|
|
const { session, media } = await created.json();
|
|
expect(session.callerId).toBeUndefined(); // Private authority metadata is not projected into the browser session.
|
|
expect(media.transportToken).toMatch(/^fixture:/);
|
|
const path = `/api/companies/${company.id}/voice-sessions/${session.id}`;
|
|
expect((await page.request.get(origin + path)).status()).toBe(403);
|
|
expect((await outsiderContext.request.get(origin + path)).status()).toBe(403);
|
|
expect((await memberContext.request.get(origin + path)).status()).toBe(200);
|
|
const { members } = await (await page.request.get(`${origin}/api/companies/${company.id}/members`)).json();
|
|
const membership = members.find((entry: any) => entry.principalId === member.user.id);
|
|
expect(membership).toBeTruthy();
|
|
await request(page.request, "PATCH", `/companies/${company.id}/members/${membership.id}`, { status: "suspended" });
|
|
expect((await memberContext.request.get(origin + path + "/notification")).status()).toBe(403);
|
|
expect((await memberContext.request.get(origin + path)).status()).toBe(403);
|
|
const ended = await request(memberContext.request, "POST", path.replace(/^\/api/, "") + "/end", {});
|
|
expect(ended.state).toBe("ended");
|
|
const { home } = JSON.parse(await readFile(resolve(import.meta.dirname, ".auth-instance.json"), "utf8"));
|
|
await expect.poll(async () => {
|
|
const evidence = JSON.parse(await readFile(resolve(home, "evidence.json"), "utf8"));
|
|
return { sessions: evidence.sessions.length, ended: evidence.sessions[0]?.state, accepted: evidence.tools.length };
|
|
}).toEqual({ sessions: 1, ended: "ended", accepted: 0 });
|
|
await info.attach("authority-results", { body: JSON.stringify({ companyId: company.id, otherCompanyId: other.id, sessionId: session.id, privateTaskId: privateTask.id, denied: ["anonymous", "cross-company", "private-task", "other-caller", "suspended-member"], revokedCallerHangup: "passed" }), contentType: "application/json" });
|
|
} finally {
|
|
await Promise.all([memberContext.close(), outsiderContext.close(), anonymousContext.close()]);
|
|
}
|
|
});
|