Files
PaperClipAI/server/src/services/attention.ts
T
scotttongandPaperclip 71f0c0c99e feat: add opt-in Coordinator workspace for chat, tasks, and decisions (#17983)
<!-- entire-trail-link-start -->
https://entire.com/gh/paperclipai/-/trails/147/changes/paperclip/147
<!-- entire-trail-link-end -->

## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - People coordinate work through conversations, tasks, and requests
for input.
> - These surfaces must share task state and preserve the context of
each decision.
> - The existing workspace makes people switch surfaces to follow that
context.
> - This pull request adds an optional Coordinator workspace with linked
conversations, tasks, documents, and decisions.
> - Each person can enable it in Settings > Experimental and return to
the classic workspace.
> - The benefit is a coherent path from a request to an assigned task
and reviewed work.

## Linked Issues or Issue Description

**Subsystem affected**
UI, server, shared contracts, and database.

**Problem or motivation**
People need a consistent way to start tasks from agent conversations,
answer questions, review work, and return to the source context.
Decisions and task state must agree across these surfaces.

**Proposed solution**
Add a personal, default-off workspace experiment. Keep one conversation
per agent. Add task proposals, compact task and decision cards,
contextual document panels, and a Needs You queue with search, filters,
sorting, grouping, and history.

**Alternatives considered**
Replacing the classic workspace for everyone would remove the opt-out
path. Keeping separate decision state in each surface would create
conflicting answers. This change uses the existing canonical task and
interaction records instead.

**Roadmap alignment**
This supports the existing agent chat, task management, and human review
capabilities. It is an experimental presentation choice. The user
requested this isolated implementation after design review. No Discord
discussion is claimed.

## What Changed

- Add per-person workspace preferences, a default-off setting, and an
additive migration.
- Add Coordinator navigation, pinned destinations, task lists, agent
switching, and contextual panels.
- Link task suggestions and creation to the source conversation. Default
new task ownership to the current agent unless the user specifies
another owner.
- Share pending questions, decision receipts, exact review targets, and
history across tasks, chat, and Needs You.
- Preserve task access, assignment authorization, revision binding, and
required output review gates.
- Add compact document links, relative timestamps, composer controls,
and reduced-motion support for task and decision transitions.
- Add component stories, regression coverage, and capability-map
documentation.

## Verification

- Final head: `4b839aae1e314bd7e8635a766f1d205ff1c03ba6`, based on
master `8bc051245f77a47bee0f8ba45896b8bfa5922e0a`. Verified October 29,
2026 at 00:10 UTC: **MERGEABLE, 56 checks passed, four conditional
skips, no pending or failed checks**. [Current CI
run](https://github.com/paperclipai/paperclip/actions/runs/40790639688)
passed without a rerun on this head.
- Fresh Greptile **5/5**, zero new comments and zero open review
threads; Superagent passed with no suspicious changes.
[Checks](https://github.com/paperclipai/paperclip/pull/17983/checks).
- Local workspace typecheck/build passed after the latest rebase. The
final account-read patch passed UI typecheck/build and all 12 related
preference/settings tests, including a delayed real-client request
across account changes. Earlier scoped checks cover review
deduplication/replay, decision deep links, cross-surface state, access
boundaries, and migration replay.
- Local database/browser rechecks after the latest rebase were limited
by exhausted macOS shared-memory IDs: `initdb` failed before database
creation. The local run passed 31 UI/snapshot tests and skipped 24
database tests; those skips and the blocked local browser start are not
claimed as passes. The independent Linux CI database and browser checks
passed. No running dev database or host setting was changed.
- Upstream migration 0403 is preserved. Preferences and durable review
retry aliases are generated as replay-safe migrations
`0404_tense_silver_sable.sql` and `0405_harsh_avengers.sql`; five newest
snapshots are retained. Every detected conflict was rebased and pushed
before waiting for CI/review, as requested.
- The PR is unmerged. The active master ruleset still requires
code-owner approval for the changed Paperclip skill; no approval or rule
change was performed.

<details>
<summary>Earlier verification failures, integration history, and
evidence</summary>

These entries preserve prior checkpoints and failures; the current
acceptance result is above.

- Focused UI and server checks from the isolated build are recorded in
the implementation plan.
- Browser checks covered the opt-in shell, navigation, task/document
links, and decision card states. No new live provider trial is claimed
for this handoff.
- Current acceptance head: `4b839aae1e314bd7e8635a766f1d205ff1c03ba6`,
rebased onto master `8bc051245` immediately after its GitHub
review-repair migration took 0403. Preferences are generated as
idempotent `0404_tense_silver_sable.sql`, preserving upstream
SQL/journal/snapshot history and five newest snapshots. GitHub reports
MERGEABLE after the immediate lease-protected push. Scott's updated
instruction is to rebase and push every conflict resolution first,
without waiting for CI or Greptile; verification follows the push.
- The final reviewed feature tree was consolidated for repeatable
single-commit rebases. The complete previous commit history remains
reachable through local recovery ref
`codex/coordinator-recovery-before-rebase-20261028` (resolved snapshot
`0e1bbdf4e`). The actual rebase completed, and its tree hash exactly
matches that resolved snapshot. The force-with-lease required the known
remote head `0e6ef7c44`, protecting against concurrent branch changes.
No PR merge or permission/runner setting change occurred. Fresh
CI/review are in progress for the current head.
- `2001132fa` received Greptile 5/5 with one nonblocking account-switch
read finding. Current head detaches path-coalesced preference GETs and
disables HTTP caching, retaining React Query's account-scoped sharing. A
delayed real-client GET regression proves account B can load its saved
choice before account A responds, and A's late response only updates A's
cache. Preference/settings tests 12/12 and UI typecheck passed; its
review thread is resolved. Fresh current-head CI/reviews are pending.
The prior CI chat shard 3 ended with “The operation was canceled” and no
assertion failure ([job
123171595631](https://github.com/paperclipai/paperclip/actions/runs/40789688333/job/123171595631),
`/tmp/pr17983-2001132-chat3.log`); no code/timeout change is attributed
to that cancellation.
- `843e823b4` reached fresh Greptile 5/5 with zero comments/open threads
and Superagent pass. All browser tests including the repaired YAML shard
passed, and 54 checks passed. General server shard 9 ended with “The
operation was canceled” and no failed assertion; its test step was
marked cancelled (job
[123164350893](https://github.com/paperclipai/paperclip/actions/runs/40787501761/job/123164350893),
log `/tmp/pr17983-843e-server9.log`). A single unchanged-head rerun was
started after the workflow completed, but master moved while it ran. A
local nested-clone check timed out in its 30-second database-startup
hook and then failed cleanup before the 20 database cases ran; this is
retained as a local verification limit
(`/tmp/pr17983-843e-nested-clone-check.log`), not claimed as a pass or
proof of the CI cancellation cause.
- Following Scott's instruction, the new conflict was rebased and pushed
immediately without waiting for that rerun. Upstream's
`0403_natural_cerise.sql` is preserved; regenerated preferences and
retry-alias migrations are `0404_tense_silver_sable.sql` and
`0405_harsh_avengers.sql`, replay-safe with five newest snapshots
retained. The YAML helper conflict combines upstream's click and header
behavior with the editor-selection guard and injected regression.
Recovery ref `codex/coordinator-recovery-843e823b4` preserves pre-rebase
work. Current head is MERGEABLE. Full workspace typecheck/build passed;
UI and snapshot checks passed 31 tests, but 24 database tests were
skipped by the local support probe, and the local browser server could
not initialize PostgreSQL. A direct disposable `initdb` diagnostic
established the host limitation: `could not create shared memory
segment: No space left on device` (`shmget`, shared-memory IDs
exhausted, not disk space). No dev database or host setting was changed.
Diagnostics: `/tmp/pr17983-2001132-initdb-probe.log`,
`/tmp/pr17983-2001132-db-probe.log`; checks:
`/tmp/pr17983-2001132-tests.log`, `/tmp/pr17983-2001132-browser.log`,
`/tmp/pr17983-2001132-types.log`, `/tmp/pr17983-2001132-build.log`.
These local skipped/blocked checks are not claimed as passes; fresh CI
on independent runners is in progress.
- `d18f683cd` reached fresh Greptile 5/5 with zero comments/open threads
and Superagent pass, but [E2E shard
7](https://github.com/paperclipai/paperclip/actions/runs/40785966243/job/123159719925)
failed parsing an Advanced YAML clipboard read beginning with “Skip to
Main Content.” The log is retained at `/tmp/pr17983-d18f-e2e7.log`.
Current head hardens the test helper to verify editor focus and
selection, clear stale clipboard content, and require the YAML header at
the start of a fresh copy before parsing. Saved-state assertions and
timeouts are unchanged. All six Advanced YAML browser journeys passed on
a disposable local instance (41.0s); the exact lost-response journey
also passed with a one-time injected surrounding-page copy, verifying
rejection/reacquisition (17.6s). The precise browser focus/clipboard
timing in CI remains unproven; the observed invalid-read path is now
guarded and deterministically exercised. Logs:
`/tmp/pr17983-yaml-clipboard-scope-browser.log`,
`/tmp/pr17983-yaml-clipboard-injected-browser.log`. Fresh current-head
CI and reviews are pending.
- `19e6dcb0b` passed Superagent and Greptile 5/5, with one nonblocking
deep-link finding. Current head preserves attention links using
`?decisionId=`: the requested pending decision is rendered even beyond
the first 40 cards, focused and scrolled into view, then only that
parameter is consumed so later refreshes do not refocus. Other URL
parameters remain. Needs You tests 10/10 and UI typecheck passed; its
review thread is resolved. The preceding post-rebase regression run
passed 45/45 tests. Fresh current-head CI/reviews are pending.
- `6d772b7cc` reached Greptile 5/5 with zero comments/open threads and
Superagent pass. While 32 checks had passed, master moved and caused a
documentation conflict in `maps/feature-map/onboarding.md`. Rebased
immediately, preserving both onboarding paragraphs. The complete
four-commit branch was pushed as `19e6dcb0b` before waiting on
CI/review, per Scott's instruction. A transient Git index lock
interrupted the first continue; the command sequence briefly pushed
intermediate `34e298c07`, then the completed rebase was immediately
pushed. All feature and security/retry fixes are present; local recovery
ref `codex/coordinator-recovery-6d772b7cc` preserves the pre-rebase
history. The only tree differences from that ref are upstream's two
smoke-test files and the combined documentation paragraph. GitHub
reports MERGEABLE. Fresh current-head verification is in progress;
prior-head review results are not current acceptance.
- `21efa3120` passed Superagent but Greptile scored 4/5 for a valid
retry-key persistence bug: an acknowledged duplicate key could reopen a
resolved review. Current head adds an additive, replay-safe
`0404_light_swarm.sql` migration for indexed, task-scoped aliases from
acknowledged retry keys to the canonical interaction. Alias registration
and retry lookup occur under the existing task lock; payload/actor
mismatch still conflicts, and each canonical review permits at most 100
aliases. Original and acknowledged keys replay the terminal result
rather than creating a new gate. Five newest migration snapshots are
retained. Service/routes tests 165/165 passed; final quality review plus
migration replay/snapshot checks 25/25 passed; server typecheck passed.
The P1 thread is resolved in code; fresh current-head reviews and CI are
pending.
- `69c2c7543` passed 55 checks and Greptile 5/5 with no open Greptile
findings, but Superagent check
[123140675812](https://github.com/paperclipai/paperclip/pull/17983/checks?check_run_id=123140675812)
correctly flagged unbounded pending quality-card creation. Current head
fixes that under the existing task-row lock: equivalent requests with
fresh idempotency keys reuse the pending card; conflicting requests for
an unresolved deliverable return the existing interaction ID; pending
cards are capped at ten per task across all reviewers. Distinct outputs
remain independent, and already-answered items in a partially pending
batch can receive a fresh review. Added real-database concurrency,
cross-card duplicate, partial-answer, and hard-cap regressions. Quality
review 22/22 tests and final server typecheck passed; earlier
service/routes 163/163 tests passed before the final partial-answer
refinement. One added assertion initially expected a service HTTP error,
but duplicate keys are rejected earlier by the existing shared schema;
the assertion now verifies that validation. Fresh current-head
CI/reviews are pending; the action-required security result is not
treated as passed.
- `c9c575e5f` completed all 56 checks successfully with four conditional
skips, Greptile 5/5, and Superagent pass. Its two P2 review findings are
fixed in the current head: independently bound quality approvals now
each remain visible in attention; changing/clearing URL-backed
assignee/status filters updates the URL and survives task navigation.
Both review threads are resolved. Regression evidence: attention service
34/34 tests passed, CoordinatorTasks 20/20 passed, UI and server
typechecks and the full workspace build passed on `69c2c7543`. The first
new UI test run caught an assertion racing React Router's transition;
waiting for the navigation before asserting passes without weakening the
navigation/remount checks. These older-head green checks are not claimed
for the new fix commit.
- Preceding `0e6ef7c44` completed all 56 checks successfully with four
conditional skips, fresh Greptile 5/5 and no open findings, and passed
Superagent. A fifth migration-metadata collision arrived before the
final Runner job finished. Those green results are preserved as
prior-head evidence, not current acceptance.
- Previous fully verified migration head:
`0e6ef7c44696a377f35e69521b93587576374bd0`, integrating master
`f8226b051` after the fourth migration-number collision. Master added
terminal GitHub-response migration 0401 while the final native check
ran; upstream 0401 SQL/journal/snapshot is preserved unchanged, and
preferences are generated as idempotent `0402_yielding_blink.sql` on
top. Exactly the five newest snapshots remain. GitHub reports MERGEABLE
after the push. All 1,155 relevant
migration/review/interaction/native-execution/remote-assets tests,
workspace typecheck/build, migration guards and whitespace checks pass.
Fresh exact-head CI/Greptile/Superagent are pending.
- Immediately preceding head `36c67cf03` completed all 56 checks
successfully with four conditional skips, fresh Greptile 5/5 and no open
findings, plus passed Superagent security. No retry was needed for that
head's CI. Master advanced and introduced only a migration-metadata
conflict while its final native check ran, so that green result does not
establish acceptance of the current integration. Four consecutive
collisions (0398, 0399, 0400, 0401) during verification are retained as
concrete integration churn; a brief pause of competing migration merges
was requested, without assuming it happened or changing any repo
setting. The PR has not been merged.
- Prior fully verified head: `36c67cf03`, on the clean `30059c0ed`
integration of master `efd65c112`. The last Greptile P2 is fixed: Needs
attention retains the participant-agent scope through authoritative
server membership queries for each pending task, including historical
participation when another agent currently owns the task. It does not
approximate participation with current assignment or enumerate every
company task. The actual view-switch regression and all 31 focused
task/routing/collection tests, UI typecheck/build, token gates and
whitespace checks pass. Greptile completed a fresh 5/5 review on this
exact head (review 19) with zero new comments and no open review
threads. CI and Superagent remain in progress; no current-head CI
failure has been reported.
- Head `30059c0ed` received Greptile 5/5 with that one nonblocking
participant finding, now fixed. Superagent passed that head.
Current-base integration restored the ephemeral RunsOn fleet after a
superseded workflow retained queued aggregate jobs: normal cancellation
was insufficient; the single force-cancel request was interrupted but
readback confirmed that obsolete run cancelled and current CI began on
the trusted fleet. No cancellation retry or runner/security/workflow
changes were made. Its partial CI was superseded by the necessary
participant fix and is not current acceptance.
- Previous compatibility/base-sync head:
`30059c0ededc0eab4e04e8299a884f36db8b292f`, integrating master
`efd65c112` and the Inbox/workspace compatibility fixes. GitHub reports
MERGEABLE after the push. Coordinator keeps Inbox standalone under More
without rewriting the instance's Combined Inbox preference; opting out
restores that preference. Saved merged-Inbox URLs resolve to their
original owner, task status presets remain usable, and canonical
repeated `workspace` parameters retain scoped, deduplicated pagination
(including Needs attention). All 192 broader
routing/Inbox/sidebar/privacy/review tests and the final 16 task-page
tests pass, as do workspace typecheck/build, token gates and whitespace
checks. The two review threads are resolved. Fresh exact-head CI,
Greptile and Superagent results are pending.
- The preceding `d5b9be5bd` remained mergeable but its CI routing gate
intentionally fell back to GitHub-hosted runners: “stacked base merge
commit does not contain the current base branch.” All 45 downstream jobs
stayed queued. Current master was merged cleanly to refresh the pinned
base; no runner/security settings or workflow logic were changed.
Greptile scored that preceding head 4/5 with the two compatibility
findings fixed here. Its automatic Superagent scan was inconclusive at
checkout; the documented retry was still pending when superseded. Those
results do not establish acceptance of this current head.
- Previous approval/migration head:
`d5b9be5bd3b8d6b0437e42bf48138377f34fa67d`, integrating master
`ba5bba86d` and the stale-output approval correction. GitHub reports
MERGEABLE after the push. The fresh P1 finding is fixed: every submitted
item now validates and locks its bound output inside the resolution
transaction, whether or not it carries a required-quality-review
binding. Real database regressions verify that an advanced document
revision or deleted attachment refuses the entire batch without
recording approvals, and current ordinary output reviews still resolve.
All 272 combined migration/review/interaction tests pass; workspace
typecheck/build passed. Fresh exact-head Greptile and CI are pending.
The automatic Superagent scan ended inconclusive at checkout; one
documented on-demand retry is pending. These are explicit verification
limits, not passed security results. The P1 thread is resolved.
- Master consumed the next migration slot three times during this
verification pass: confirmation recovery took 0398, continuation
recovery took 0399, and GitHub acknowledgement recovery took 0400. Each
upstream SQL/journal/snapshot is preserved unchanged. Preferences are
now generated as idempotent `0401_white_lenny_balinger.sql` from
upstream 0400; exactly five snapshots remain, and replay coverage
locates this migration by table content. This is recorded concurrent
integration churn, not a claim that older green results apply to the
latest base.
- Head `ed3b68da9` fixed the two history/URL findings with 26 focused
regression tests, server/UI typechecks, workspace build and token gates
passing. Greptile then scored that head 4/5 with the stale-output P1
corrected in the current head. Its partial CI is superseded, not counted
as current acceptance.
- Previous filter-fix head: `ed3b68da9`, based on the `8458d39d9` merge
of master `063cfd438`. The two fresh Greptile findings are fixed:
history outcome filters now match recorded per-item verdicts in SQL
before pagination (mixed reviews remain in both applicable outcomes),
and same-page URL assignee changes/back/forward navigation update that
filter without clearing independent filters. All 26 focused
database/navigation/collection tests, server/UI typechecks, workspace
build, token gates and whitespace checks pass. The two review threads
are resolved. Fresh exact-head CI, Greptile and Superagent results are
pending.
- The `8458d39d9` migration integration also passed all 328 targeted
migration/interaction/confirmation tests, workspace typecheck/build and
Superagent security scan. Greptile scored that head 4/5 with the two
functional gaps fixed in the current head; those prior-head checks are
not current acceptance.
- Migration integration head:
`8458d39d9721f4cb312c2390070a0609f8cddd1a`, integrating master
`063cfd43813cabf18417605fb9eefb9aacf95c8d`. GitHub reports MERGEABLE
after the push. Master advanced twice during this conflict-resolution
pass: first its confirmation-recovery migration took 0398, then its
continuation-recovery migration took 0399. Both upstream migrations and
journal entries remain unchanged; Coordinator preferences are now
generated as idempotent `0400_sad_guardian.sql` from upstream's latest
snapshot. Exactly the five newest snapshots remain. The replay
regression now locates the table migration by content instead of
hardcoding a renumbered filename.
- All 328 targeted question/review/confirmation/migration tests passed
again after the second merge. Workspace typecheck/build and fresh
exact-head CI/reviews are in progress. The preceding `0c46f46d6` passed
workspace typecheck/build and Superagent security scan, but was
superseded because master consumed migration 0399 while those checks
ran. That prior-head result is not acceptance of the current head. No
production settings or runner/security permissions were changed, and the
PR has not been merged.
- Previous integration head: `0c46f46d6f2b23417ab872ce3cb6ff2673647287`,
integrating master `287b04d72f1b9fca1412e05435c75b8302ba0710`. GitHub
reports MERGEABLE after the push. The renewed conflicts were
`0398_snapshot.json`, `_journal.json`, and the top imports in
`issue-thread-interactions.ts`. Upstream's `0398` confirmation-recovery
index and journal history are preserved unchanged; Coordinator
preferences were regenerated as idempotent `0399_bouncy_miek.sql`, with
replay coverage updated and exactly the five newest snapshots retained.
Both terminal confirmation notifications and Coordinator task
assignment/required review behavior are preserved.
- All 328 targeted interaction/review/confirmation/migration tests pass,
as do workspace typecheck, map validation and whitespace checks. The
workspace build and fresh exact-head CI/Greptile/Superagent checks are
pending. The first migration-generation attempt hit the sandbox's local
IPC restriction before generating files; the unchanged authorized local
generation completed successfully. Prior-head green checks below do not
establish acceptance of this merge.
- Previous acceptance head: `8b7dcf739ed15afc51351fdfa0e0e5fbc75ab788`,
with master `1aa3a21ac` integrated and GitHub reporting MERGEABLE.
Greptile completed a fresh 5/5 review on this exact head with zero new
actionable findings and no open review threads. The [fresh CI
workflow](https://github.com/paperclipai/paperclip/actions/runs/40752864319)
completed SUCCESS on attempt 2 at 19:40:08 UTC, including all eight E2E
shards. Final completed check set: 55 succeeded, four conditional checks
skipped, zero pending/queued/running checks, and one
neutral/inconclusive Superagent scan. The auxiliary commitperclip review
and isolated native Runner compilation/cache-reuse check both passed.
This is not a claim that Superagent produced a passed security verdict.
GitHub still reports MERGEABLE against current master
`60b8089a44b4eaa37e627adbfdf2f130bda13335`.
- Current-head E2E: all eight shards and the aggregate passed, including
the previously failing YAML browser journey. Serialized server shard 9/9
failed: the protected YAML projection test exceeded its original
15-second timeout; its late update request then reached the next test's
reset mock (the captured payload is the prior test's model/label
update). All 88 tests in that exact unchanged file passed locally in
38.03 seconds, with no timeout or assertion changes. The original
slow-request cause remains unproven. CI failure log:
`/tmp/pr17983-8b7-serialized9.log`; local recovery:
`/tmp/pr17983-adapter-yaml-repro.log`. The single bounded unchanged
shard rerun passed, and the workflow completed SUCCESS. Rerun log:
`/tmp/pr17983-8b7-serialized9-rerun.log`. The initial failure is
retained; a passing retry does not establish its original slow-request
cause.
- Greptile scored preceding head `4873704be` 5/5 with one valid P2:
opened task decision records missed company-scoped live invalidation.
The current head uses the existing company decision prefix for
resolution and effect-completion events, and resets private record
payloads on access changes. Its thread is resolved. All 107 focused
record/live-update tests, UI typecheck/build, token checks and
whitespace checks pass.
- CI on `4873704be` failed E2E shard 7/8 in the Advanced YAML
lost-creation-response journey: its clipboard helper selected page text
starting with “Skip to Main Content” instead of YAML. The exact
unchanged journey passed in a disposable local browser instance (1 test,
17.1 seconds). No assertion, timeout or production behavior was
weakened; the original failure cause remains unproven. Failure log:
`/tmp/pr17983-487-e2e7.log`; local check:
`/tmp/pr17983-agent-yaml-repro.log`. The full unchanged Advanced YAML
browser suite also passed locally (6 tests, 37.8 seconds). Fresh
current-head CI subsequently passed this journey and all other E2E
shards.
- Both the automatic and one supported on-demand Superagent scan on
`4873704be` ended neutral/inconclusive: “Pinned PR scan merge-base
checkout failed or timed out.” These do not count as a passed security
verdict. The current head's automatic scan and one documented on-demand
retry also returned the identical neutral checkout failure, with zero
annotations or further diagnostics. This is an external scanner blocker,
not a passed security verdict. No security settings or permissions were
changed.
- Recorded decision links now render and focus the full source-task
record in both Classic and Coordinator, including recorded choice,
submitted inputs, and the existing effect-result resolver. Fresh
terminal records take precedence over older open-decision cache entries.
Context and account checks keep mismatched or inaccessible records out
of the DOM; no decision-history tab was added to tasks or chat. The
shared company live-run feed now drives live-only filtering, including
ended runs and terminal tasks with stale run entries. All 213 focused
tests, UI typecheck/build, token and whitespace checks pass; the final
focus follow-up passed all 188 task-detail tests and UI typecheck. The
first new navigation test failed because its test host omitted company
context; the host was corrected before the passing run.
- Previous integration head: `375c5e89516705050d94bab99336212841b2e6e1`
merges master `1aa3a21ac` after four additional upstream commits. The
sole conflict was competing imports in `server/src/services/issues.ts`;
both quality-review policy and inbound wake-notice notifications are
preserved. The PR-specific review import now sits beside
execution-policy imports instead of the frequently changing first line.
GitHub mergeability is rechecked after the push.
- On the combined master tree, workspace typecheck/build, all 153
affected UI tests, map validation, and whitespace checks pass. Four
server suites passed 77 tests; the fifth suite's module-import hook
timed out while broad verification was running. Its unchanged isolated
run passed all 41 tests in 7.2 seconds with the original timeout. This
records recovery without claiming the original import-timeout cause is
proven. CI on `375c5e895` passed every substantive job, including all
eight E2E shards and Superagent; Greptile found the two functional gaps
fixed in the current head. A short-lived `669d90876` commit added the
main fixes before the focused navigation follow-up.
- Immediately preceding head `9d9737b49` completed all 56 checks
successfully with four conditional skips, Greptile 5/5 and no open
findings, plus a successful Superagent scan. The signoff E2E shard
passed on its single accepted rerun; its initial cancellation/timing
failure is retained below. Master moved again while those checks ran,
requiring this final integration rather than treating the prior head's
green result as current acceptance.
- Previous head `9d9737b496911a6054d0ea22d1b42b28b115e9ab` includes
master `d30c8f42b842327ee1c18c41a2efd6ba623da5cd`; that head was
subsequently conflicted by moving master. The master merge preserved
durable account-bound writes and Coordinator UX. Workspace
typecheck/build, 416 focused UI tests, and 142 affected comment-route
tests passed. A stable full UI run on preceding head `938ad1665` passed
all 9,833 tests across 836 files; its final full workspace build also
passed.
- Greptile found nested proposal project inheritance and Classic
bound-revision links on `91be74952`. Both were fixed with 142
interaction-route tests, 113 focused UI tests, and UI/server typechecks.
Its next review identified a valid draft-preservation bug in the new
Classic loading UI. Head `9d9737b49` keeps loading/error notices outside
editors and annotations while preserving dirty drafts; 115 focused
review UI tests pass, including pending/failed revision loads and
continued draft editing. All related threads are resolved. Greptile
completed a fresh 5/5 review of
`9d9737b496911a6054d0ea22d1b42b28b115e9ab` with no open findings.
- CI on `938ad1665` exposed an integration regression with the newly
merged durable startup saves: the personal preference gate blocked the
task page before its first session lookup. The guarded title editor now
mounts while that lookup is pending, with presentation-specific tools
still gated. All 216 affected component tests pass. The unchanged
five-test `disconnect-write-recovery.spec.ts` browser suite passes
against a newly launched disposable local-trusted PostgreSQL instance on
port 33219, including the exact failed startup-save journey. No live
provider, hosted authentication or production proof is claimed. The
helper-owned test server exited and the port has no listener. UI
typecheck, built-browser assets, token and whitespace checks pass.
- Initial durable-write merge tests found duplicate imports and unscoped
draft fixtures, fixed before 416 focused tests passed. A sandbox
typecheck could not create its IPC socket; the supported rerun passed.
The first revision-link test used a wrong Return to latest button
assertion, corrected before the 113-test pass. The startup E2E
reproduction initially still failed because an outer shell gate also
blocked the page; the subsequent fix passed all five cases without
changing the test or its timeouts. A focused loading-header assertion
initially used an incorrect fixture title; correcting it preceded the
216-test pass. These failures remain recorded.
- Earlier routing gates fell back to GitHub-hosted runners while master
was moving or conflicted. Superseded queued runs were cancelled, then
the `938ad1665` routing gate explicitly selected the ephemeral RunsOn
fleet. Its CI actively executed and completed most tests; only the
diagnosed startup E2E shard and aggregate failed, alongside the valid
Greptile finding. Auxiliary GitHub-hosted workflows also completed
successfully on earlier heads, so queueing alone is not an
administrative blocker. Fresh [CI on
`9d9737b49`](https://github.com/paperclipai/paperclip/actions/runs/40744012678)
is the acceptance target; the previously failing startup E2E shard now
passes. A different signoff E2E shard failed during executor
resubmission when its fixture run was cancelled as
`issue_continuation_waiting_on_review`. The exact unchanged journey
passed locally (1 test, 46 seconds), and the preceding head with
identical server/signoff code passed that CI shard. This supports a
bounded rerun but does not establish the timing failure's root cause.
After the workflow finished, GitHub accepted one rerun of that failed
shard and its dependent aggregate; both passed, completing all checks on
that head. The failure log is retained at `/tmp/pr17983-9d9737-e2e7.log`
and the local reproduction at `/tmp/pr17983-signoff-repro.log`. No
assertion or timeout was weakened.
- On the first merge, full workspace typecheck/build, all 9,622 UI
tests, 267 tests across seven affected server suites, two migration
checks, map validation, token gates, and the PR diff whitespace check
passed. Greptile then found duplicate local task-search filtering and
lost completed item-review detail. Both are fixed, with 42 passing
focused UI tests and passing UI typecheck/build.
- A subsequent Greptile review found attachment confirmations without
working links and mobile history without a visible host. Confirmation
layouts now derive the authenticated immutable-content endpoint from the
attachment ID, and Needs You uses the existing full-screen mobile sheet.
All 119 focused tests pass, including missing/stale display URLs, both
review layouts, and both mobile history entry buttons. UI
typecheck/build and token checks pass. Full workspace typecheck/build
also pass after the second master merge.
- Greptile gave head 22f69c304 a 5/5 score with one non-blocking
desktop-history reopening finding. Head 6dd52b6d3 fixed it, passed all
nine history tests, UI typecheck/build, token gates, and the full
9,679-test UI suite, then received a fresh 5/5 review with zero open
findings. These are prior-head results; review on the master-sync commit
is pending.
- The chat and workspace CI jobs on head 22f69c304 were interrupted by
runner shutdown signals and cancellation before completing their tests.
Their logs do not report failing assertions. Those interrupted jobs are
not claimed as passes. The new head starts fresh runs.
- The first merge CI had a Slack session-sync idle assertion fail after
an unexpected database read. Its exact isolated reproduction passes, and
the chat CI shard passed on head 618c5a2a3. The original failure's cause
remains undetermined. The broader local reproduction, run concurrently
with full verification, instead encountered 21 timeout failures across
its two test chunks; it is not claimed as a passing full local server
run. A concurrent local UI run had eight failures (seven timeouts and
one delayed autosave assertion). The complete UI run on the final head
passed all 9,679 tests across 830 files with two workers; no test
timeout or assertion was weakened. This establishes recovery without
claiming that every earlier timeout's cause has been proved. An earlier
intermediate UI run also overlapped the second master merge and failed
the newly added Advanced-sidebar expectation, so it is not treated as
stable-tree evidence. The newly merged UI dependencies initially
required refreshing the local install from the upstream package
manifest; the generated local lockfile update is not committed, per
repository policy.
- Superagent returned neutral/inconclusive scans on the preceding heads
because its pinned merge-base checkout failed or timed out. The
available retry endpoint returned 404. These are not successful security
verdicts. The fresh scan on `91be74952` passed (PR scan passed; no
suspicious PR changes detected). The `938ad1665` scan again returned
neutral/inconclusive with the same pinned merge-base checkout error; the
check-suite rerun endpoint returned 404. The fresh `9d9737b49` scan
completed successfully at 18:22 UTC with no suspicious changes detected.
Earlier neutral scans are not counted as successful security verdicts.
- Prior head `57902152ac3218096fca669d33ff18400a2a86ae` passed 9,618 UI
tests across 826 files, received Greptile 5/5 with no open findings, and
completed CI with 56 passes and four conditional skips. These are
historical results, not acceptance of the latest merge commit.
- The first full build found generated capability-contract drift. The
generated outputs were refreshed. Initial sandbox runs could not open
local IPC sockets; verification was rerun with local test access.
- Current master was merged. The workspace preference migration was
regenerated after the existing migration history.
- The UI run first found two outdated expectations: early custom-answer
validation and the document access error copy. Both were corrected, and
the full UI suite then passed.
- The local server run found three failures in unchanged tests. The Muse
test passes with Python 3.13 instead of the host's Python 3.9. The two
workspace tests pass when their test process uses the expected master
default branch. These environment settings do not change application
behavior or global machine settings. The unsharded server run was
stopped after those reproductions; CI supplies the full sharded server
result. No successful full local server run is claimed.
- Skill inventory generation needs an external eval checkout, which is
absent locally. The existing generator functions refreshed only the live
skill inventory and its derived files. The checked-in eval inventory was
preserved. The inventory validation gate passes.
- Greptile found a dropped MCP review requirement, missing per-item
output links, generic item-review summaries, and a history-refresh
failure. The fixes have 32 passing database-backed server tests and
focused rendered-card tests. A follow-up partial-review finding was
corrected by forwarding the canonical mutation status before settling
the card. Attachments open through the authenticated immutable-content
route in both card layouts. The final focused UI set has 117 passing
tests, including these regressions.
- Both browser shards that first failed expected a disabled-chat
message. The copy was restored, and those shards passed in CI on the
next commit. The two journeys also passed locally. One local attempt
first timed out before feature disable while waiting for the provider's
initial message; its isolated reproduction passed. That earlier timing
failure remains recorded and is not presented as an explained
infrastructure failure.
- Serialized server shard 9 first failed during pnpm setup with
ECONNRESET, before dependencies or tests ran. Its single rerun passed
setup and all tests. The build and production runtime boot passed on the
first attempt, but that run's public-install step timed out during Pi
setup. The single build-job rerun passed compilation, runtime boot, and
clean public-install verification. Those setup scripts are unchanged by
this PR. The successful retry establishes recovery; the earlier Pi
timeout's underlying cause remains undetermined. The aggregate CI gate
is green: [workflow
run](https://github.com/paperclipai/paperclip/actions/runs/40637789695).

</details>

## Risks

- This touches shared task, interaction, and completion paths.
Regression tests must cover classic and experimental behavior,
authorization, duplicate answers, and stale review targets.
- The additive preference table must migrate before the setting is used.
The setting defaults off.
- The experiment changes navigation and message presentation. Canonical
task and document records remain the source of truth.
- The initial task brief and saved plan can repeat information. This
change fixes chronology; a broader redundancy policy remains a design
decision.

## Model Used

OpenAI GPT-6 Codex with reasoning and tool-assisted code editing, tests,
and browser verification. Earlier iterations used Codex models in this
task; their exact model IDs are not available in the current context.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used
- [x] I have checked ROADMAP.md
- [x] I have searched GitHub for duplicate or related PRs
- [x] I have described the issue in-PR following the relevant issue
template
- [x] I have not referenced internal/instance-local Paperclip issues or
links
- [x] My branch name describes the change
- [x] I have run relevant tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation
- [x] I have documented risks
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open recommendations or follow-ups
- [x] I will address review comments before requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-10-28 17:20:01 -07:00

2073 lines
83 KiB
TypeScript

import { approvalExecutionIssueCondition, firstApprovalIssueId } from "./approval-visibility.js";
import { and, asc, desc, eq, gt, inArray, isNotNull, isNull, notInArray, or, sql, type SQL } from "drizzle-orm";
import type { Db } from "@paperclipai/db";
import {
agents,
approvals,
assets,
companies,
decisionBundles,
decisionQueueItems,
decisionQueues,
decisionTrainingExamples,
decisionTriage,
decisions,
heartbeatRuns,
inboxDismissals,
invites,
issueApprovals,
issueAttachments,
issueDocuments,
issueRecoveryActions,
issueRelations,
issueThreadInteractions,
issues,
joinRequests,
documents,
projects,
projectWorkspaces,
} from "@paperclipai/db";
import { deriveProjectUrlKey } from "@paperclipai/shared";
import type {
AttentionDecisionVerb,
AttentionFeed,
AttentionFeedQuery,
AttentionDetailImage,
AttentionItem,
AttentionItemDetail,
AttentionProjectRef,
AttentionQueueRef,
AttentionResolverAudience,
AttentionSeverity,
AttentionSortMode,
AttentionSourceKind,
AttentionSubject,
AttentionTriageAttribution,
AttentionWorkspaceRef,
IssueThreadInteractionEffectiveResolverPolicySource,
IssueThreadInteractionResolverPolicyProvenance,
IssueReviewPolicy,
} from "@paperclipai/shared";
import { badRequest } from "../errors.js";
import { listAttentionExhaustedRuns } from "./attention-exhausted-runs.js";
import { budgetService } from "./budgets.js";
import {
BLOCKER_ATTENTION_MAX_DEPTH,
BLOCKER_ATTENTION_MAX_NODES,
issueService,
} from "./issues.js";
import { executionIssueCondition, visibleIssueCondition } from "./issue-visibility.js";
import { parseIssueExecutionState } from "./issue-execution-policy.js";
import { isProspectiveBlockedTransition } from "./routable-blocked.js";
import { issueReadSqlCondition, type AuthorizationActor } from "./authorization.js";
import { evaluateAgentInvokability, type AgentOrgRow } from "./agent-invokability.js";
import { canonicalizeStoredResolverPolicy } from "./issue-thread-interaction-resolution.js";
import { decisionQueueService } from "./decision-queues.js";
import {
decisionRetentionService,
DEFAULT_DECISION_SHELF_DAYS,
} from "./decision-retention.js";
const ATTENTION_SOURCE_KINDS: AttentionSourceKind[] = [
"approval",
"decision",
"issue_thread_interaction",
"join_request",
"recovery_action",
"productivity_review",
"blocker_attention",
"review",
"failed_run",
"budget_alert",
"agent_error_alert",
];
const SEVERITY_RANK: Record<AttentionSeverity, number> = {
critical: 0,
high: 1,
medium: 2,
low: 3,
};
const SOURCE_RANK: Record<AttentionSourceKind, number> = {
failed_run: 0,
recovery_action: 1,
blocker_attention: 2,
budget_alert: 3,
agent_error_alert: 4,
approval: 5,
decision: 6,
issue_thread_interaction: 7,
review: 8,
productivity_review: 9,
join_request: 10,
};
const PENDING_INTERACTION_STATUSES = ["pending"] as const;
const OPEN_RECOVERY_STATUSES = ["active", "escalated"] as const;
const HUMAN_RECOVERY_OWNER_TYPES = ["user", "board"] as const;
const DETAIL_EXCERPT_LENGTH = 160;
const DETAIL_IMAGE_LIMIT = 3;
const OPEN_DECISION_DEFAULT_LIMIT = 500;
const OPEN_DECISION_MAX_LIMIT = 1_000;
const ATTENTION_PAGE_DEFAULT_LIMIT = 50;
const ATTENTION_PAGE_MAX_LIMIT = 100;
const ATTENTION_GRAPH_QUERY_CHUNK_SIZE = 500;
function chunkValues<T>(values: T[], size: number): T[][] {
const chunks: T[][] = [];
for (let index = 0; index < values.length; index += size) chunks.push(values.slice(index, index + size));
return chunks;
}
type IssueSummaryRow = {
id: string;
companyId: string;
identifier: string | null;
title: string;
status: string;
priority: string;
/** Who may give the `in_review` verdict; `null`/absent ≡ "anyone" (PAP-16506). */
reviewPolicy?: IssueReviewPolicy | null;
assigneeAgentId: string | null;
assigneeUserId: string | null;
createdAt: Date;
updatedAt: Date;
project: AttentionProjectRef | null;
workspace: AttentionWorkspaceRef | null;
};
type IssueSubjectRow = Omit<IssueSummaryRow, "project" | "workspace">;
type DismissalState = {
kind: "dismiss" | "snooze";
dismissedAt: Date;
snoozedUntil: Date | null;
};
type PlanDocumentSummary = {
title: string | null;
body: string;
};
type BlockingIssueSummary = {
id: string | null;
identifier: string | null;
title: string | null;
};
type AttentionListOptions = AttentionFeedQuery & {
userId?: string | null;
includeDismissed?: boolean;
actor?: AuthorizationActor;
/** Internal-only escape hatch for callers that need one stable, unpaginated feed snapshot. */
allowUnscopedAll?: boolean;
excludeSources?: readonly AttentionSourceKind[];
};
type AttentionServiceOptions = {
openDecisionLimit?: number;
now?: () => number;
};
function emptyCounts(): Record<AttentionSourceKind, number> {
return Object.fromEntries(ATTENTION_SOURCE_KINDS.map((kind) => [kind, 0])) as Record<AttentionSourceKind, number>;
}
function toIso(value: Date | string | null | undefined): string {
if (!value) return new Date(0).toISOString();
return value instanceof Date ? value.toISOString() : new Date(value).toISOString();
}
function timestamp(value: Date | string | null | undefined): number {
if (!value) return 0;
const time = new Date(value).getTime();
return Number.isFinite(time) ? time : 0;
}
function activeDismissalState(
dismissalByKey: ReadonlyMap<string, DismissalState>,
dismissalKey: string,
activityAt: string,
now: number,
) {
const dismissal = dismissalByKey.get(dismissalKey);
if (!dismissal) return null;
const dismissedAt = toIso(dismissal.dismissedAt);
const snoozedUntil = dismissal.snoozedUntil ? toIso(dismissal.snoozedUntil) : null;
const isActive = dismissal.kind === "snooze"
? dismissal.snoozedUntil != null && timestamp(dismissal.snoozedUntil) > now
: timestamp(dismissal.dismissedAt) >= timestamp(activityAt);
return {
kind: dismissal.kind,
dismissedAt,
snoozedUntil,
isActive,
};
}
function stripMarkdown(value: string) {
return value
.replace(/```[\s\S]*?```/g, " ")
.replace(/`([^`]+)`/g, "$1")
.replace(/!\[[^\]]*\]\([^)]*\)/g, " ")
.replace(/\[([^\]]+)\]\([^)]*\)/g, "$1")
.replace(/^#{1,6}\s+/gm, "")
.replace(/[>*_~#-]+/g, " ")
.replace(/\s+/g, " ")
.trim();
}
function excerpt(value: unknown, maxLength = DETAIL_EXCERPT_LENGTH) {
if (typeof value !== "string") return null;
const cleaned = stripMarkdown(value);
if (!cleaned) return null;
if (cleaned.length <= maxLength) return cleaned;
return `${cleaned.slice(0, Math.max(0, maxLength - 1)).trimEnd()}...`;
}
function readRecord(value: unknown): Record<string, unknown> {
return value && typeof value === "object" && !Array.isArray(value) ? value as Record<string, unknown> : {};
}
function readArray(value: unknown): unknown[] {
return Array.isArray(value) ? value : [];
}
function readString(value: unknown) {
return typeof value === "string" && value.trim() ? value.trim() : null;
}
function isPlanDocumentTarget(payload: Record<string, unknown>) {
const target = readRecord(payload.target);
return target.type === "issue_document" && target.key === "plan";
}
function issueContext(issue: IssueSummaryRow | IssueSubjectRow | null | undefined) {
const summary = issue && "project" in issue ? issue : null;
return {
project: summary?.project ?? null,
workspace: summary?.workspace ?? null,
};
}
function issueImages(imageMap: ReadonlyMap<string, AttentionDetailImage[]>, issueId: string | null | undefined) {
return issueId ? imageMap.get(issueId) ?? [] : [];
}
function genericDetail(summary: unknown, images: AttentionDetailImage[]): AttentionItemDetail {
return { kind: "generic", summaryExcerpt: excerpt(summary), images };
}
function approvalDetail(type: string, payload: Record<string, unknown>): AttentionItemDetail {
return {
kind: "approval",
approvalType: type,
summaryExcerpt: excerpt(payload.summary ?? payload.title ?? payload.recommendedAction),
images: [],
};
}
function interactionDetail(input: {
kind: string;
payload: Record<string, unknown>;
issue: IssueSummaryRow | null;
planDocument: PlanDocumentSummary | null;
images: AttentionDetailImage[];
}): AttentionItemDetail {
if (input.kind === "request_confirmation" && isPlanDocumentTarget(input.payload)) {
return {
kind: "plan_approval",
issueTitle: input.issue?.title ?? null,
planTitle: input.planDocument?.title ?? "Plan",
summaryExcerpt: excerpt(input.planDocument?.body ?? input.payload.detailsMarkdown ?? input.payload.prompt),
images: input.images,
};
}
if (input.kind === "ask_user_questions") {
const questions = readArray(input.payload.questions).map(readRecord);
return {
kind: "questions",
questionCount: questions.length,
firstQuestionText: readString(questions[0]?.prompt),
images: input.images,
};
}
if (input.kind === "suggest_tasks") {
const tasks = readArray(input.payload.tasks).map(readRecord);
return {
kind: "suggested_tasks",
taskCount: tasks.length,
firstTaskTitle: readString(tasks[0]?.title),
images: input.images,
};
}
if (input.kind === "request_checkbox_confirmation") {
return {
kind: "checkbox_confirmation",
optionCount: readArray(input.payload.options).length,
promptExcerpt: excerpt(input.payload.prompt),
images: input.images,
};
}
if (input.kind === "request_item_verdicts") {
return {
kind: "item_verdicts",
itemCount: readArray(input.payload.items).length,
promptExcerpt: excerpt(input.payload.prompt),
images: input.images,
};
}
return {
kind: "confirmation",
promptExcerpt: excerpt(input.payload.prompt ?? input.payload.detailsMarkdown),
isPlanTarget: false,
images: input.images,
};
}
function issueHref(prefix: string, issue: Pick<IssueSubjectRow, "id" | "identifier">) {
return `/${prefix}/issues/${issue.identifier ?? issue.id}`;
}
function issueSubject(prefix: string, issue: IssueSubjectRow): AttentionSubject {
return {
kind: "issue",
id: issue.id,
companyId: issue.companyId,
title: issue.title,
identifier: issue.identifier,
status: issue.status,
href: issueHref(prefix, issue),
metadata: {
priority: issue.priority,
assigneeAgentId: issue.assigneeAgentId,
assigneeUserId: issue.assigneeUserId,
// Only present when the row was selected with the column, so subjects
// built from narrower selects do not claim a policy they never read.
...(issue.reviewPolicy !== undefined ? { reviewPolicy: issue.reviewPolicy } : {}),
},
};
}
function itemId(sourceKind: AttentionSourceKind, dedupKey: string) {
return `${sourceKind}:${dedupKey}`;
}
function decisionVerbs(...verbs: AttentionDecisionVerb[]): AttentionDecisionVerb[] {
return verbs;
}
type CreateAttentionItemInput = Omit<AttentionItem,
| "id"
| "dismissalKey"
| "rank"
| "dismissal"
| "project"
| "workspace"
| "expiresAt"
| "ruleKey"
| "originAgentName"
| "queues"
| "shelf"
| "retentionDays"
| "keep"
| "archivedAt"
| "retentionVersion"
| "decideBy"
| "decideByAttribution"
| "snoozedUntil"
| "detail"
| "trainingExampleId"
> & {
project?: AttentionProjectRef | null;
workspace?: AttentionWorkspaceRef | null;
expiresAt?: string | null;
ruleKey?: string | null;
originAgentName?: string | null;
detail?: AttentionItemDetail | null;
};
function createItem(input: CreateAttentionItemInput): AttentionItem {
return {
...input,
id: itemId(input.sourceKind, input.dedupKey),
dismissalKey: `attention:${input.dedupKey}`,
dismissal: null,
project: input.project ?? null,
workspace: input.workspace ?? null,
expiresAt: input.expiresAt ?? null,
ruleKey: input.ruleKey ?? null,
originAgentName: input.originAgentName ?? null,
queues: [],
shelf: false,
retentionDays: DEFAULT_DECISION_SHELF_DAYS,
keep: false,
archivedAt: null,
retentionVersion: 0,
decideBy: null,
decideByAttribution: null,
snoozedUntil: null,
detail: input.detail ?? null,
trainingExampleId: null,
resolverAudience: input.resolverAudience ?? null,
rank: 0,
};
}
function compareAttentionItems(left: AttentionItem, right: AttentionItem) {
const timeDiff = timestamp(right.activityAt) - timestamp(left.activityAt);
if (timeDiff !== 0) return timeDiff;
const severityDiff = SEVERITY_RANK[left.severity] - SEVERITY_RANK[right.severity];
if (severityDiff !== 0) return severityDiff;
const sourceDiff = SOURCE_RANK[left.sourceKind] - SOURCE_RANK[right.sourceKind];
if (sourceDiff !== 0) return sourceDiff;
return left.dedupKey.localeCompare(right.dedupKey);
}
function blockedTaskCount(item: AttentionItem) {
return item.sourceKind === "blocker_attention"
&& item.detail?.kind === "blocker"
&& typeof item.detail.blockedTaskCount === "number"
? item.detail.blockedTaskCount
: null;
}
/** Preserve the selected desk sort for every row slot while ordering blocker
* rows by the amount of work they hold up. */
function orderBlockedAttentionByWeight(
items: AttentionItem[],
fallback: (left: AttentionItem, right: AttentionItem) => number,
) {
const blockers = items
.filter((item) => blockedTaskCount(item) !== null)
.sort((left, right) => {
const weightDiff = (blockedTaskCount(right) ?? 0) - (blockedTaskCount(left) ?? 0);
return weightDiff !== 0 ? weightDiff : fallback(left, right);
});
if (blockers.length < 2) return items;
let blockerIndex = 0;
return items.map((item) => blockedTaskCount(item) === null ? item : blockers[blockerIndex++]!);
}
function sourceKey(sourceKind: AttentionSourceKind, sourceId: string) {
return `${sourceKind}:${sourceId}`;
}
function itemSourceKey(item: AttentionItem) {
return sourceKey(item.sourceKind, item.subject.id);
}
function readMetadataAgentId(item: AttentionItem) {
const metadata = item.subject.metadata;
const value = metadata?.originAgentId ?? metadata?.createdByAgentId ?? metadata?.requestedByAgentId
?? metadata?.agentId ?? (item.subject.kind === "agent" ? item.subject.id : null);
return typeof value === "string" && value.length > 0 ? value : null;
}
function startOfUtcDay(now: number) {
const value = new Date(now);
return Date.UTC(value.getUTCFullYear(), value.getUTCMonth(), value.getUTCDate());
}
function endOfUtcDay(now: number) {
return startOfUtcDay(now) + 24 * 60 * 60 * 1_000 - 1;
}
function endOfUtcWeek(now: number) {
const start = startOfUtcDay(now);
const weekday = new Date(start).getUTCDay();
// Use an ISO-style Monday-Sunday week. Sunday (0) is already the last
// day of the current week; every other day advances only to that Sunday.
const daysUntilSunday = weekday === 0 ? 0 : 7 - weekday;
return start + (daysUntilSunday + 1) * 24 * 60 * 60 * 1_000 - 1;
}
function decideOrder(item: AttentionItem, now: number): [number, number] {
if (item.decideBy === "today") return [0, endOfUtcDay(now)];
if (item.decideBy === "this_week") return [0, endOfUtcWeek(now)];
if (item.decideBy && /^\d{4}-\d{2}-\d{2}$/.test(item.decideBy)) {
const deadline = Date.parse(`${item.decideBy}T23:59:59.999Z`);
if (Number.isFinite(deadline)) return [0, deadline];
}
if (item.decideBy === "whenever") return [1, Number.MAX_SAFE_INTEGER];
return [2, Number.MAX_SAFE_INTEGER];
}
function isDecideNow(item: AttentionItem, now: number) {
const [bucket, deadline] = decideOrder(item, now);
return bucket === 0 && deadline <= endOfUtcDay(now);
}
/** Surfaced today (arrival). Mirrors `attentionIsNewToday` in `ui/src/lib/attention.ts`. */
function isNewToday(item: AttentionItem, now: number) {
const ts = timestamp(item.createdAt);
return ts > 0 && ts >= startOfUtcDay(now);
}
function compareDecideItems(left: AttentionItem, right: AttentionItem, now: number) {
const [leftBucket, leftDeadline] = decideOrder(left, now);
const [rightBucket, rightDeadline] = decideOrder(right, now);
if (leftBucket !== rightBucket) return leftBucket - rightBucket;
if (leftDeadline !== rightDeadline) return leftDeadline - rightDeadline;
const leftExpiry = left.expiresAt ? timestamp(left.expiresAt) : Number.MAX_SAFE_INTEGER;
const rightExpiry = right.expiresAt ? timestamp(right.expiresAt) : Number.MAX_SAFE_INTEGER;
if (leftExpiry !== rightExpiry) return leftExpiry - rightExpiry;
const severityDiff = SEVERITY_RANK[left.severity] - SEVERITY_RANK[right.severity];
if (severityDiff !== 0) return severityDiff;
return compareAttentionItems(left, right);
}
function encodeCursor(sort: AttentionSortMode, item: AttentionItem) {
return Buffer.from(JSON.stringify({ v: 1, sort, id: item.id }), "utf8").toString("base64url");
}
function decodeCursor(cursor: string, sort: AttentionSortMode) {
try {
const decoded = JSON.parse(Buffer.from(cursor, "base64url").toString("utf8")) as Record<string, unknown>;
if (decoded.v !== 1 || decoded.sort !== sort || typeof decoded.id !== "string" || !decoded.id) {
throw new Error("invalid cursor shape");
}
return decoded.id;
} catch {
throw badRequest("Invalid attention cursor");
}
}
function parseActivityBoundary(value: string | undefined, field: "activitySince" | "activityUntil") {
if (value === undefined) return null;
if (!/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}(?:\.\d{1,3})?(?:Z|[+-]\d{2}:\d{2})$/.test(value)) {
throw badRequest(`${field} must be an ISO timestamp`);
}
const parsed = Date.parse(value);
if (!Number.isFinite(parsed)) throw badRequest(`${field} must be an ISO timestamp`);
return parsed;
}
async function enrichAttentionItems(db: Db, companyId: string, items: AttentionItem[], now: number) {
if (items.length === 0) return items;
const sourceIds = [...new Set(items.map((item) => item.subject.id))];
const queueRows = await db
.select({
sourceKind: decisionQueueItems.sourceKind,
sourceId: decisionQueueItems.sourceId,
key: decisionQueues.key,
title: decisionQueues.title,
retentionDays: decisionQueues.retentionDays,
})
.from(decisionQueueItems)
.innerJoin(decisionQueues, and(
eq(decisionQueueItems.queueId, decisionQueues.id),
eq(decisionQueues.companyId, companyId),
))
.where(and(
eq(decisionQueueItems.companyId, companyId),
inArray(decisionQueueItems.sourceId, sourceIds),
))
.orderBy(asc(decisionQueues.title), asc(decisionQueues.key));
const queuesBySource = new Map<string, AttentionQueueRef[]>();
const retentionDaysBySource = new Map<string, number[]>();
for (const row of queueRows) {
const key = sourceKey(row.sourceKind as AttentionSourceKind, row.sourceId);
const queues = queuesBySource.get(key) ?? [];
queues.push({ key: row.key, title: row.title });
queuesBySource.set(key, queues);
if (row.retentionDays != null) {
const values = retentionDaysBySource.get(key) ?? [];
values.push(row.retentionDays);
retentionDaysBySource.set(key, values);
}
}
const triageRows = await db
.select()
.from(decisionTriage)
.where(and(
eq(decisionTriage.companyId, companyId),
inArray(decisionTriage.sourceId, sourceIds),
));
const triageBySource = new Map(triageRows.map((row) => [
sourceKey(row.sourceKind as AttentionSourceKind, row.sourceId),
row,
]));
const agentIds = [...new Set([
...items.map(readMetadataAgentId),
...triageRows.map((row) => row.setByAgentId),
].filter((value): value is string => Boolean(value)))];
const agentNameById = new Map(agentIds.length === 0 ? [] : await db
.select({ id: agents.id, name: agents.name })
.from(agents)
.where(and(eq(agents.companyId, companyId), inArray(agents.id, agentIds)))
.then((rows) => rows.map((row) => [row.id, row.name] as const)));
const enriched = items.map((item) => {
const triage = triageBySource.get(itemSourceKey(item));
const decideBy = triage?.decideBy === "date" ? triage.decideByDate : triage?.decideBy ?? null;
const decideByAttribution: AttentionTriageAttribution | null = triage ? {
type: triage.setByType as AttentionTriageAttribution["type"],
agentId: triage.setByAgentId ?? null,
agentName: triage.setByAgentId ? agentNameById.get(triage.setByAgentId) ?? null : null,
userId: triage.setByUserId ?? null,
runId: triage.setByRunId ?? null,
responsibleUserId: triage.responsibleUserId ?? null,
updatedAt: toIso(triage.updatedAt),
} : null;
const originAgentId = readMetadataAgentId(item);
return {
...item,
originAgentName: originAgentId ? agentNameById.get(originAgentId) ?? null : null,
queues: queuesBySource.get(itemSourceKey(item)) ?? [],
decideBy,
decideByAttribution,
snoozedUntil: triage?.snoozedUntil ? toIso(triage.snoozedUntil) : null,
};
});
const retentionBySource = await decisionRetentionService(db).syncItems(companyId, enriched);
return enriched.map((item) => {
const key = itemSourceKey(item);
const retention = retentionBySource.get(key);
const overrides = retentionDaysBySource.get(key) ?? [];
const retentionDays = overrides.length > 0 ? Math.min(...overrides) : DEFAULT_DECISION_SHELF_DAYS;
return {
...item,
shelf: timestamp(item.activityAt) <= now - retentionDays * 86_400_000,
retentionDays,
keep: retention?.keep ?? false,
archivedAt: retention?.archivedAt ? toIso(retention.archivedAt) : null,
retentionVersion: retention?.version ?? 0,
};
});
}
function betterDuplicate(left: AttentionItem, right: AttentionItem) {
return compareAttentionItems(left, right) <= 0 ? left : right;
}
function approvalTitle(type: string, payload: Record<string, unknown>) {
const title = typeof payload.title === "string" ? payload.title.trim() : "";
if (title) return title;
const summary = typeof payload.summary === "string" ? payload.summary.trim() : "";
if (summary) return summary;
return type.replaceAll("_", " ");
}
function interactionLabel(kind: string) {
switch (kind) {
case "request_confirmation":
return "Confirmation requested";
case "request_checkbox_confirmation":
return "Selection confirmation requested";
case "ask_user_questions":
return "Questions need answers";
case "suggest_tasks":
return "Suggested tasks need a decision";
case "request_item_verdicts":
return "Item verdicts need a decision";
default:
return "Interaction needs a decision";
}
}
function interactionVerbs(kind: string, payload: Record<string, unknown>) {
if (kind === "ask_user_questions") {
return decisionVerbs({
id: "respond",
label: "Respond",
description: "Submit answers to the pending questions.",
});
}
if (kind === "request_confirmation") {
const acceptLabel = typeof payload.acceptLabel === "string" && payload.acceptLabel.trim()
? payload.acceptLabel.trim()
: "Confirm";
const rejectLabel = typeof payload.rejectLabel === "string" && payload.rejectLabel.trim()
? payload.rejectLabel.trim()
: "Decline";
return decisionVerbs(
{
id: "accept",
label: acceptLabel,
description: "Accept the pending confirmation.",
},
{
id: "reject",
label: rejectLabel,
description: "Decline the pending confirmation.",
},
);
}
return decisionVerbs(
{
id: "accept",
label: "Accept",
description: "Accept the pending interaction.",
},
{
id: "reject",
label: "Reject",
description: "Reject the pending interaction and provide a reason when required.",
},
);
}
/**
* The resolver audience carried by an `issue_thread_interaction` feed row
* (PAP-17287). A collapsed queue row offers Accept/Reject long before anything
* fetches the interaction itself, so the audience the server will enforce has
* to ride along with the item — the queue must never ask for a decision without
* saying whose decision it is.
*
* Facts only. The stored columns are canonicalized through the same helper the
* resolution evaluator uses, so a pre-migration row cannot read as `Anyone`
* here while the API still treats it as `not_creator`.
*/
export function interactionResolverAudience(
row: {
addresseeAgentId: string | null;
addresseeUserId?: string | null;
createdByAgentId: string | null;
requestedResolverPolicy: string;
effectiveResolverPolicy: string;
resolverPolicyProvenance: string | null;
effectiveResolverPolicySource: string | null;
},
agentName: (agentId: string) => string | null,
): AttentionResolverAudience {
const provenance = (row.resolverPolicyProvenance
?? (row.requestedResolverPolicy === "board_only" || row.requestedResolverPolicy === "board_or_agents"
? "legacy_inherited_restriction"
: "inherited")) as IssueThreadInteractionResolverPolicyProvenance;
return {
requestedResolverPolicy: canonicalizeStoredResolverPolicy(row.requestedResolverPolicy, provenance),
effectiveResolverPolicy: canonicalizeStoredResolverPolicy(row.effectiveResolverPolicy, provenance),
effectiveResolverPolicySource:
(row.effectiveResolverPolicySource ?? "requested") as IssueThreadInteractionEffectiveResolverPolicySource,
resolverPolicyProvenance: provenance,
addresseeAgentId: row.addresseeAgentId,
addresseeUserId: row.addresseeUserId ?? null,
addresseeName: row.addresseeAgentId ? agentName(row.addresseeAgentId) : null,
createdByAgentId: row.createdByAgentId,
createdByAgentName: row.createdByAgentId ? agentName(row.createdByAgentId) : null,
};
}
function collapsePendingConfirmationsToNewest<T extends {
id: string;
issueId: string;
kind: string;
createdAt: Date;
payload: unknown;
}>(rows: T[]) {
// Quality gates bind independent outputs; a newer visual approval must not
// hide a still-pending copy approval (or affect its badge count).
const independent = (row: T) => Boolean(row.payload && typeof row.payload === "object" && "qualityReview" in row.payload && row.payload.qualityReview);
const newestByGroup = new Map<string, T>();
for (const row of rows) {
if (row.kind !== "request_confirmation" || independent(row)) continue;
const groupKey = `${row.issueId}:${row.kind}`;
const newest = newestByGroup.get(groupKey);
if (
!newest
|| row.createdAt.getTime() > newest.createdAt.getTime()
|| (row.createdAt.getTime() === newest.createdAt.getTime() && row.id > newest.id)
) {
newestByGroup.set(groupKey, row);
}
}
return rows.filter((row) => (
row.kind !== "request_confirmation"
|| independent(row)
|| newestByGroup.get(`${row.issueId}:${row.kind}`)?.id === row.id
));
}
function budgetObservedPercent(amountObserved: number, amountLimit: number) {
return amountLimit > 0 ? Math.round((amountObserved / amountLimit) * 10_000) / 100 : 0;
}
async function companyPrefix(db: Db, companyId: string) {
const row = await db
.select({ issuePrefix: companies.issuePrefix })
.from(companies)
.where(eq(companies.id, companyId))
.then((rows) => rows[0] ?? null);
return row?.issuePrefix ?? "PAP";
}
async function dismissalByKey(db: Db, companyId: string, userId: string | null | undefined) {
if (!userId) return new Map<string, DismissalState>();
const rows = await db
.select({
itemKey: inboxDismissals.itemKey,
kind: inboxDismissals.kind,
dismissedAt: inboxDismissals.dismissedAt,
snoozedUntil: inboxDismissals.snoozedUntil,
})
.from(inboxDismissals)
.where(and(eq(inboxDismissals.companyId, companyId), eq(inboxDismissals.userId, userId)));
return new Map(rows.map((row) => [row.itemKey, {
kind: row.kind,
dismissedAt: row.dismissedAt,
snoozedUntil: row.snoozedUntil,
}]));
}
async function issueSummaryMap(
db: Db,
companyId: string,
issueIds: Array<string | null | undefined>,
readCondition: SQL<boolean> = sql<boolean>`true`,
includeConversations = false,
) {
const ids = [...new Set(issueIds.filter((value): value is string => Boolean(value)))];
if (ids.length === 0) return new Map<string, IssueSummaryRow>();
const rows = await db
.select({
id: issues.id,
companyId: issues.companyId,
identifier: issues.identifier,
title: issues.title,
status: issues.status,
priority: issues.priority,
reviewPolicy: issues.reviewPolicy,
assigneeAgentId: issues.assigneeAgentId,
assigneeUserId: issues.assigneeUserId,
createdAt: issues.createdAt,
updatedAt: issues.updatedAt,
projectId: projects.id,
projectName: projects.name,
projectColor: projects.color,
projectIcon: projects.icon,
workspaceId: projectWorkspaces.id,
workspaceName: projectWorkspaces.name,
})
.from(issues)
.leftJoin(projects, and(eq(issues.projectId, projects.id), eq(projects.companyId, companyId)))
.leftJoin(projectWorkspaces, and(
eq(issues.projectWorkspaceId, projectWorkspaces.id),
eq(projectWorkspaces.companyId, companyId),
))
.where(and(
eq(issues.companyId, companyId),
inArray(issues.id, ids),
includeConversations
? or(executionIssueCondition(), and(visibleIssueCondition(), isNotNull(issues.conversationAgentId)))
: executionIssueCondition(),
readCondition,
));
return new Map(rows.map((row) => [row.id, {
id: row.id,
companyId: row.companyId,
identifier: row.identifier,
title: row.title,
status: row.status,
priority: row.priority,
reviewPolicy: row.reviewPolicy ?? null,
assigneeAgentId: row.assigneeAgentId,
assigneeUserId: row.assigneeUserId,
createdAt: row.createdAt,
updatedAt: row.updatedAt,
project: row.projectId && row.projectName ? {
id: row.projectId,
name: row.projectName,
urlKey: deriveProjectUrlKey(row.projectName, row.projectId),
color: row.projectColor,
icon: row.projectIcon,
} : null,
workspace: row.workspaceId && row.workspaceName ? {
id: row.workspaceId,
name: row.workspaceName,
} : null,
}]));
}
async function issueImageMap(
db: Db,
companyId: string,
issueIds: Array<string | null | undefined>,
readCondition: SQL<boolean> = sql<boolean>`true`,
) {
const ids = [...new Set(issueIds.filter((value): value is string => Boolean(value)))];
if (ids.length === 0) return new Map<string, AttentionDetailImage[]>();
const rows = await db
.select({
issueId: issueAttachments.issueId,
assetId: issueAttachments.assetId,
originalFilename: assets.originalFilename,
})
.from(issueAttachments)
.innerJoin(assets, eq(issueAttachments.assetId, assets.id))
.innerJoin(issues, and(eq(issueAttachments.issueId, issues.id), eq(issues.companyId, companyId)))
.where(and(
eq(issueAttachments.companyId, companyId),
eq(assets.companyId, companyId),
inArray(issueAttachments.issueId, ids),
sql`${assets.contentType} like 'image/%'`,
readCondition,
))
.orderBy(asc(issueAttachments.issueId), asc(issueAttachments.createdAt), asc(issueAttachments.id));
const map = new Map<string, AttentionDetailImage[]>();
for (const row of rows) {
const images = map.get(row.issueId) ?? [];
if (images.length >= DETAIL_IMAGE_LIMIT) continue;
images.push({ assetId: row.assetId, alt: row.originalFilename ?? null });
map.set(row.issueId, images);
}
return map;
}
async function planDocumentMap(
db: Db,
companyId: string,
issueIds: Array<string | null | undefined>,
readCondition: SQL<boolean> = sql<boolean>`true`,
) {
const ids = [...new Set(issueIds.filter((value): value is string => Boolean(value)))];
if (ids.length === 0) return new Map<string, PlanDocumentSummary>();
const rows = await db
.select({
issueId: issueDocuments.issueId,
title: documents.title,
body: documents.latestBody,
})
.from(issueDocuments)
.innerJoin(documents, eq(issueDocuments.documentId, documents.id))
.innerJoin(issues, and(eq(issueDocuments.issueId, issues.id), eq(issues.companyId, companyId)))
.where(and(
eq(issueDocuments.companyId, companyId),
eq(documents.companyId, companyId),
eq(issueDocuments.key, "plan"),
inArray(issueDocuments.issueId, ids),
readCondition,
));
return new Map(rows.map((row) => [row.issueId, { title: row.title, body: row.body }]));
}
async function blockingIssueMap(
db: Db,
companyId: string,
blockedIssueIds: Array<string | null | undefined>,
readCondition: SQL<boolean> = sql<boolean>`true`,
) {
const ids = [...new Set(blockedIssueIds.filter((value): value is string => Boolean(value)))];
if (ids.length === 0) return new Map<string, BlockingIssueSummary>();
const rows = await db
.select({
blockedIssueId: issueRelations.relatedIssueId,
id: issues.id,
identifier: issues.identifier,
title: issues.title,
})
.from(issueRelations)
.innerJoin(issues, eq(issueRelations.issueId, issues.id))
.where(and(
eq(issueRelations.companyId, companyId),
eq(issues.companyId, companyId),
eq(issueRelations.type, "blocks"),
inArray(issueRelations.relatedIssueId, ids),
isNull(issues.hiddenAt),
readCondition,
))
.orderBy(asc(issueRelations.relatedIssueId), asc(issueRelations.createdAt), asc(issueRelations.id));
const map = new Map<string, BlockingIssueSummary>();
for (const row of rows) {
if (!map.has(row.blockedIssueId)) {
map.set(row.blockedIssueId, { id: row.id, identifier: row.identifier, title: row.title });
}
}
return map;
}
type BlockedWorkEdge = {
fromIssueId: string | null;
issueId: string;
};
/**
* Counts open work held behind each blocker. The walk starts with explicit
* dependents, then follows both further dependency edges and issue children.
* Per-root visited sets make corrupt cycles harmless; the blocker analyzer's
* existing traversal caps bound unusually large graphs.
*/
async function blockedWorkCountMap(db: Db, companyId: string, blockerIssueIds: string[]) {
const rootIds = [...new Set(blockerIssueIds)];
const seenByRoot = new Map(rootIds.map((rootId) => [rootId, new Set<string>()]));
if (rootIds.length === 0) return new Map<string, number>();
const loadEdges = async (fromIssueIds: string[], includeChildren: boolean) => {
const rows: BlockedWorkEdge[] = [];
for (const chunk of chunkValues(fromIssueIds, ATTENTION_GRAPH_QUERY_CHUNK_SIZE)) {
const dependentRowsPromise: Promise<BlockedWorkEdge[]> = db
.select({
fromIssueId: issueRelations.issueId,
issueId: issues.id,
})
.from(issueRelations)
.innerJoin(issues, eq(issueRelations.relatedIssueId, issues.id))
.where(and(
eq(issueRelations.companyId, companyId),
eq(issueRelations.type, "blocks"),
inArray(issueRelations.issueId, chunk),
eq(issues.companyId, companyId),
isNull(issues.hiddenAt),
notInArray(issues.status, ["done", "cancelled"]),
));
const childRowsPromise: Promise<BlockedWorkEdge[]> = includeChildren
? db
.select({
fromIssueId: issues.parentId,
issueId: issues.id,
})
.from(issues)
.where(and(
eq(issues.companyId, companyId),
inArray(issues.parentId, chunk),
isNull(issues.hiddenAt),
notInArray(issues.status, ["done", "cancelled"]),
))
: Promise.resolve([]);
const [dependentRows, childRows] = await Promise.all([dependentRowsPromise, childRowsPromise]);
rows.push(...dependentRows, ...childRows);
}
return rows;
};
let rootsByFrontierId = new Map<string, Set<string>>();
for (const edge of await loadEdges(rootIds, false)) {
if (!edge.fromIssueId || edge.issueId === edge.fromIssueId) continue;
const seen = seenByRoot.get(edge.fromIssueId);
if (!seen || seen.size >= BLOCKER_ATTENTION_MAX_NODES || seen.has(edge.issueId)) continue;
seen.add(edge.issueId);
const roots = rootsByFrontierId.get(edge.issueId) ?? new Set<string>();
roots.add(edge.fromIssueId);
rootsByFrontierId.set(edge.issueId, roots);
}
for (let depth = 1; rootsByFrontierId.size > 0 && depth < BLOCKER_ATTENTION_MAX_DEPTH; depth += 1) {
const nextRootsByFrontierId = new Map<string, Set<string>>();
const edges = await loadEdges([...rootsByFrontierId.keys()], true);
for (const edge of edges) {
if (!edge.fromIssueId) continue;
const roots = rootsByFrontierId.get(edge.fromIssueId);
if (!roots) continue;
for (const rootId of roots) {
if (edge.issueId === rootId) continue;
const seen = seenByRoot.get(rootId);
if (!seen || seen.size >= BLOCKER_ATTENTION_MAX_NODES || seen.has(edge.issueId)) continue;
seen.add(edge.issueId);
const nextRoots = nextRootsByFrontierId.get(edge.issueId) ?? new Set<string>();
nextRoots.add(rootId);
nextRootsByFrontierId.set(edge.issueId, nextRoots);
}
}
rootsByFrontierId = nextRootsByFrontierId;
}
return new Map([...seenByRoot].map(([rootId, seen]) => [rootId, seen.size]));
}
/**
* The task that blocks `issue` — never `issue` itself.
*
* Both blocker_attention call sites used to fall back to the blocked task's own
* identity when no `blocks` relation was loaded, so every such row reported
* "PAP-23 — Blocked by PAP-23". The UI renders that as a real dependency, which
* tells an operator nothing and reads as a bug.
*
* Order: the loaded `blocks` relation, then an identifier sampled by
* blockerAttention, and otherwise nothing — a null lets the row fall back to
* its `whyNow` line, which is honest about not knowing the blocker.
*/
function resolveBlockingIssue(
issue: { id: string; identifier: string | null },
fromRelation: BlockingIssueSummary | undefined,
sampledIdentifier?: string | null,
): BlockingIssueSummary | null {
// A self-referential relation row would be corrupt data; treat it as unknown.
if (fromRelation && fromRelation.id !== issue.id) return fromRelation;
if (sampledIdentifier && sampledIdentifier !== issue.identifier && sampledIdentifier !== issue.id) {
return { id: null, identifier: sampledIdentifier, title: null };
}
return null;
}
function readRunIssueId(contextSnapshot: Record<string, unknown> | null) {
const issueId = contextSnapshot?.issueId ?? contextSnapshot?.taskId;
return typeof issueId === "string" && issueId.length > 0 ? issueId : null;
}
type FailedRunProbe = { id: string; agentId: string; issueId: string | null; createdAt: Date };
const FAILED_RUN_PROBE_BATCH_SIZE = 1000;
async function listFailedRunsWithNewerRun(db: Db, companyId: string, failedRuns: FailedRunProbe[]) {
const withNewerRun = new Set<string>();
const keyed = failedRuns.filter(run => run.issueId !== null);
for (let start = 0; start < keyed.length; start += FAILED_RUN_PROBE_BATCH_SIZE) {
const batch = keyed.slice(start, start + FAILED_RUN_PROBE_BATCH_SIZE);
for (const id of await listFailedRunBatchWithNewerRun(db, companyId, batch)) withNewerRun.add(id);
}
const unkeyed = failedRuns.filter(run => run.issueId === null);
if (unkeyed.length === 0) return withNewerRun;
const agentIds = [...new Set(unkeyed.map(run => run.agentId))];
const oldestCreatedAt = unkeyed.reduce((oldest, run) => run.createdAt < oldest ? run.createdAt : oldest,
unkeyed[0]!.createdAt);
const latestByAgent = new Map<string, Date>();
for (let start = 0; start < agentIds.length; start += FAILED_RUN_PROBE_BATCH_SIZE) {
const rows = await db.select({
agentId: heartbeatRuns.agentId,
createdAt: sql<Date>`max(${heartbeatRuns.createdAt})`.mapWith(heartbeatRuns.createdAt),
}).from(heartbeatRuns).where(and(
eq(heartbeatRuns.companyId, companyId),
inArray(heartbeatRuns.agentId, agentIds.slice(start, start + FAILED_RUN_PROBE_BATCH_SIZE)),
gt(heartbeatRuns.createdAt, oldestCreatedAt),
sql`coalesce(${heartbeatRuns.contextSnapshot} ->> 'issueId', ${heartbeatRuns.contextSnapshot} ->> 'taskId', '') = ''`,
)).groupBy(heartbeatRuns.agentId);
for (const row of rows) latestByAgent.set(row.agentId, row.createdAt);
}
for (const run of unkeyed) {
if ((latestByAgent.get(run.agentId)?.getTime() ?? 0) > run.createdAt.getTime()) withNewerRun.add(run.id);
}
return withNewerRun;
}
async function listFailedRunBatchWithNewerRun(db: Db, companyId: string, failedRuns: FailedRunProbe[]) {
if (failedRuns.length === 0) return [];
const failed = sql.join(
failedRuns.map((run) => sql`(${run.id}::uuid, ${run.agentId}::uuid, ${run.issueId}::text, ${new Date(run.createdAt.getTime() + 1).toISOString()}::timestamptz)`),
sql`, `,
);
const runIssueId = sql`(${heartbeatRuns.contextSnapshot} ->> 'issueId')`;
const runTaskId = sql`(${heartbeatRuns.contextSnapshot} ->> 'taskId')`;
const newerRunExists = (match: SQL) => sql`exists (
select 1 from ${heartbeatRuns}
where ${heartbeatRuns.companyId} = ${companyId}
and ${heartbeatRuns.agentId} = failed.agent_id
and ${heartbeatRuns.createdAt} >= failed.newer_from
and ${match}
)`;
const rows = await db.execute(sql`
select failed.id
from (values ${failed}) as failed (id, agent_id, issue_id, newer_from)
where ${newerRunExists(sql`${runIssueId} = failed.issue_id`)}
or ${newerRunExists(sql`${runTaskId} = failed.issue_id and ${runIssueId} is null`)}
`) as unknown as Array<{ id: string }>;
return rows.map((row) => row.id);
}
export function attentionService(db: Db, serviceOptions: AttentionServiceOptions = {}) {
const openDecisionLimit = Math.min(
Math.max(Math.trunc(serviceOptions.openDecisionLimit ?? OPEN_DECISION_DEFAULT_LIMIT), 1),
OPEN_DECISION_MAX_LIMIT,
);
return {
list: async (companyId: string, options: AttentionListOptions = {}): Promise<AttentionFeed> => {
if (options.all && !options.queue && !options.allowUnscopedAll) {
throw badRequest("all requires a queue filter");
}
const readCondition = options.actor
? await issueReadSqlCondition(db, options.actor)
: sql<boolean>`true`;
const [prefix, dismissals] = await Promise.all([
companyPrefix(db, companyId),
dismissalByKey(db, companyId, options.userId),
]);
const includeDismissed = options.includeDismissed === true;
const now = serviceOptions.now?.() ?? Date.now();
const collected: AttentionItem[] = [];
const add = (item: AttentionItem) => {
const dismissal = activeDismissalState(dismissals, item.dismissalKey, item.activityAt, now);
if (!includeDismissed && dismissal?.isActive) return;
collected.push({ ...item, dismissal });
};
if (!options.excludeSources?.includes("approval")) {
const pendingApprovals = await db
.select({
id: approvals.id,
linkedIssueId: firstApprovalIssueId(),
type: approvals.type,
status: approvals.status,
requestedByAgentId: approvals.requestedByAgentId,
requestedByUserId: approvals.requestedByUserId,
payload: approvals.payload,
createdAt: approvals.createdAt,
updatedAt: approvals.updatedAt,
})
.from(approvals)
.where(and(eq(approvals.companyId, companyId), eq(approvals.status, "pending"), approvalExecutionIssueCondition()))
.orderBy(desc(approvals.updatedAt), desc(approvals.id));
const readableApprovalIssues = await issueSummaryMap(
db,
companyId,
pendingApprovals.map((row) => row.linkedIssueId),
readCondition,
);
for (const approval of pendingApprovals) {
const linkedIssueId = approval.linkedIssueId ?? null;
if (linkedIssueId && !readableApprovalIssues.has(linkedIssueId)) continue;
const dedupKey = `approval:${approval.id}`;
const title = approvalTitle(approval.type, approval.payload);
add(createItem({
companyId,
sourceKind: "approval",
subject: {
kind: "approval",
id: approval.id,
companyId,
title,
identifier: null,
status: approval.status,
href: `/${prefix}/approvals/${approval.id}`,
metadata: {
type: approval.type,
requestedByAgentId: approval.requestedByAgentId,
requestedByUserId: approval.requestedByUserId,
issueId: approval.linkedIssueId ?? null,
},
},
whyNow: "Approval is pending a board decision.",
decisionVerbs: decisionVerbs(
{ id: "approve", label: "Approve", description: "Approve the request." },
{ id: "reject", label: "Reject", description: "Reject the request." },
{ id: "request_revision", label: "Request revision", description: "Send the request back for changes." },
),
inlineResolvable: approval.type !== "request_board_approval",
entryRule: "approvals.status = 'pending'",
exitRule: "Approval leaves pending status.",
dedupKey,
severity: "medium",
activityAt: toIso(approval.updatedAt),
createdAt: toIso(approval.createdAt),
updatedAt: toIso(approval.updatedAt),
relatedIssue: null,
detail: approvalDetail(approval.type, approval.payload),
}));
}
}
const interactionRows = await db
.select({
id: issueThreadInteractions.id,
issueId: issueThreadInteractions.issueId,
kind: issueThreadInteractions.kind,
status: issueThreadInteractions.status,
title: issueThreadInteractions.title,
summary: issueThreadInteractions.summary,
payload: issueThreadInteractions.payload,
addresseeAgentId: issueThreadInteractions.addresseeAgentId,
addresseeUserId: issueThreadInteractions.addresseeUserId,
createdByAgentId: issueThreadInteractions.createdByAgentId,
requestedResolverPolicy: issueThreadInteractions.requestedResolverPolicy,
effectiveResolverPolicy: issueThreadInteractions.effectiveResolverPolicy,
resolverPolicyProvenance: issueThreadInteractions.resolverPolicyProvenance,
effectiveResolverPolicySource: issueThreadInteractions.effectiveResolverPolicySource,
createdAt: issueThreadInteractions.createdAt,
updatedAt: issueThreadInteractions.updatedAt,
})
.from(issueThreadInteractions)
.where(and(
eq(issueThreadInteractions.companyId, companyId),
inArray(issueThreadInteractions.status, [...PENDING_INTERACTION_STATUSES]),
))
.orderBy(desc(issueThreadInteractions.updatedAt), desc(issueThreadInteractions.id));
// Addressee invokability needs the org graph; the audience line also needs
// the creator's name whenever the effective policy excludes it, so a
// creator-excluding row pulls the roster in too (PAP-17287).
const needsCompanyAgents = interactionRows.some((row) =>
row.addresseeAgentId !== null
|| canonicalizeStoredResolverPolicy(row.effectiveResolverPolicy, row.resolverPolicyProvenance) === "not_creator"
);
const companyAgentRows: AgentOrgRow[] = needsCompanyAgents
? await db
.select({
id: agents.id,
companyId: agents.companyId,
name: agents.name,
reportsTo: agents.reportsTo,
status: agents.status,
})
.from(agents)
.where(eq(agents.companyId, companyId))
: [];
const companyAgentMap = new Map(companyAgentRows.map((agent) => [agent.id, agent]));
const boardInteractionRows = interactionRows.filter((row) =>
(row.addresseeAgentId === null ||
!evaluateAgentInvokability(companyAgentMap.get(row.addresseeAgentId), companyAgentRows).invokable)
&& (row.addresseeUserId === null || row.addresseeUserId === options.userId)
);
const visibleInteractionRows = collapsePendingConfirmationsToNewest(boardInteractionRows);
const [interactionIssueMap, interactionImageMap, interactionPlanDocumentMap] = await Promise.all([
// A pending human request remains actionable in a persistent chat even
// though its idle container is intentionally absent from work queues.
issueSummaryMap(db, companyId, visibleInteractionRows.map((row) => row.issueId), readCondition, true),
issueImageMap(db, companyId, visibleInteractionRows.map((row) => row.issueId), readCondition),
planDocumentMap(db, companyId, visibleInteractionRows.map((row) => row.issueId), readCondition),
]);
for (const interaction of visibleInteractionRows) {
const issue = interactionIssueMap.get(interaction.issueId) ?? null;
if (!issue) continue;
const payload = readRecord(interaction.payload);
const detail = interactionDetail({
kind: interaction.kind,
payload,
issue,
planDocument: interactionPlanDocumentMap.get(interaction.issueId) ?? null,
images: issueImages(interactionImageMap, interaction.issueId),
});
const isPlanTarget = detail.kind === "plan_approval";
const dedupKey = `interaction:${interaction.id}`;
add(createItem({
companyId,
sourceKind: "issue_thread_interaction",
subject: {
kind: "interaction",
id: interaction.id,
companyId,
title: isPlanTarget && issue ? `Plan approval - ${issue.title}` : interaction.title ?? interaction.summary ?? interactionLabel(interaction.kind),
identifier: null,
status: interaction.status,
href: issue ? `${issueHref(prefix, issue)}#interaction-${interaction.id}` : null,
metadata: {
kind: interaction.kind,
issueId: interaction.issueId,
createdByAgentId: interaction.createdByAgentId,
isPlanTarget,
targetDocumentKey: isPlanTarget ? "plan" : null,
},
},
whyNow: `${interactionLabel(interaction.kind)} on an issue thread.`,
decisionVerbs: interactionVerbs(interaction.kind, payload),
inlineResolvable: true,
entryRule: "issue_thread_interactions.status = 'pending'",
exitRule: "Interaction resolves, expires, fails, or is cancelled.",
dedupKey,
severity: "medium",
activityAt: toIso(interaction.updatedAt),
createdAt: toIso(interaction.createdAt),
updatedAt: toIso(interaction.updatedAt),
relatedIssue: issue ? issueSubject(prefix, issue) : null,
...issueContext(issue),
detail,
resolverAudience: interactionResolverAudience(
interaction,
(agentId) => companyAgentMap.get(agentId)?.name ?? null,
),
}));
}
const openDecisionQuery = db.select({
id: decisions.id,
bundleId: decisions.bundleId,
originAgentId: decisions.originAgentId,
ruleKey: decisions.ruleKey,
title: decisions.title,
body: decisions.body,
status: decisions.status,
expiresAt: decisions.expiresAt,
originIssueId: decisions.originIssueId,
createdAt: decisions.createdAt,
updatedAt: decisions.updatedAt,
}).from(decisions).where(and(eq(decisions.companyId, companyId), eq(decisions.status, "open")))
.orderBy(desc(decisions.updatedAt), desc(decisions.id));
const openDecisions = options.all
? await openDecisionQuery
: await openDecisionQuery.limit(openDecisionLimit);
// Bundle titles let the feed render a single "Agent proposed N decisions"
// group header over sibling decisions (v1 still decides each independently).
const bundleIds = [...new Set(openDecisions.map((decision) => decision.bundleId).filter((value): value is string => Boolean(value)))];
const bundleTitleMap = new Map<string, string>();
const [decisionIssueMap, bundleRows] = await Promise.all([
issueSummaryMap(db, companyId, openDecisions.map((decision) => decision.originIssueId), readCondition),
bundleIds.length > 0
? db.select({ id: decisionBundles.id, title: decisionBundles.title })
.from(decisionBundles).where(and(eq(decisionBundles.companyId, companyId), inArray(decisionBundles.id, bundleIds)))
: Promise.resolve([]),
]);
for (const row of bundleRows) bundleTitleMap.set(row.id, row.title);
for (const decision of openDecisions) {
const issue = decisionIssueMap.get(decision.originIssueId) ?? null;
if (decision.originIssueId && !issue) continue;
add(createItem({
companyId,
sourceKind: "decision",
subject: { kind: "decision", id: decision.id, companyId, title: decision.title, identifier: null, status: decision.status,
href: `/${prefix}/decisions?decisionId=${decision.id}`,
metadata: { originIssueId: decision.originIssueId, originAgentId: decision.originAgentId, bundleId: decision.bundleId,
bundleTitle: decision.bundleId ? bundleTitleMap.get(decision.bundleId) ?? null : null } },
whyNow: "An agent decision is waiting for a board response.",
decisionVerbs: decisionVerbs({ id: "decide", label: "Review", description: "Review and choose an option." }),
inlineResolvable: true,
entryRule: "decisions.status = 'open'",
exitRule: "Decision is decided, expired, or cancelled.",
dedupKey: `decision:${decision.id}`,
severity: "medium",
expiresAt: decision.expiresAt ? toIso(decision.expiresAt) : null,
ruleKey: decision.ruleKey,
activityAt: toIso(decision.updatedAt),
createdAt: toIso(decision.createdAt),
updatedAt: toIso(decision.updatedAt),
relatedIssue: issue ? issueSubject(prefix, issue) : null,
...issueContext(issue),
detail: { kind: "generic", summaryExcerpt: decision.body.slice(0, DETAIL_EXCERPT_LENGTH), images: [] },
}));
}
if (!options.excludeSources?.includes("join_request")) {
const pendingJoins = await db
.select({
id: joinRequests.id,
requestType: joinRequests.requestType,
status: joinRequests.status,
requestingUserId: joinRequests.requestingUserId,
requestEmailSnapshot: joinRequests.requestEmailSnapshot,
agentName: joinRequests.agentName,
adapterType: joinRequests.adapterType,
createdAt: joinRequests.createdAt,
updatedAt: joinRequests.updatedAt,
})
.from(joinRequests)
.innerJoin(invites, eq(joinRequests.inviteId, invites.id))
.where(and(
eq(joinRequests.companyId, companyId),
eq(invites.companyId, companyId),
eq(joinRequests.status, "pending_approval"),
))
.orderBy(desc(joinRequests.updatedAt), desc(joinRequests.id));
for (const join of pendingJoins) {
const label = join.requestType === "agent"
? join.agentName ?? "Agent join request"
: join.requestEmailSnapshot ?? join.requestingUserId ?? "Human join request";
const dedupKey = `join:${join.id}`;
add(createItem({
companyId,
sourceKind: "join_request",
subject: {
kind: "join_request",
id: join.id,
companyId,
title: label,
identifier: null,
status: join.status,
href: `/${prefix}/settings/access`,
metadata: {
requestType: join.requestType,
requestingUserId: join.requestingUserId,
adapterType: join.adapterType,
},
},
whyNow: "Join request is pending approval.",
decisionVerbs: decisionVerbs(
{ id: "approve", label: "Approve", description: "Approve this join request." },
{ id: "reject", label: "Reject", description: "Reject this join request." },
),
inlineResolvable: true,
entryRule: "join_requests.status = 'pending_approval'",
exitRule: "Join request is approved or rejected.",
dedupKey,
severity: "medium",
activityAt: toIso(join.updatedAt),
createdAt: toIso(join.createdAt),
updatedAt: toIso(join.updatedAt),
relatedIssue: null,
detail: genericDetail(label, []),
}));
}
}
const recoveryRows = await db
.select()
.from(issueRecoveryActions)
.where(and(
eq(issueRecoveryActions.companyId, companyId),
inArray(issueRecoveryActions.status, [...OPEN_RECOVERY_STATUSES]),
inArray(issueRecoveryActions.ownerType, [...HUMAN_RECOVERY_OWNER_TYPES]),
))
.orderBy(desc(issueRecoveryActions.updatedAt), desc(issueRecoveryActions.id));
const [recoveryIssueMap, recoveryImageMap] = await Promise.all([
issueSummaryMap(
db,
companyId,
recoveryRows.flatMap((row) => [row.sourceIssueId, row.recoveryIssueId]),
readCondition,
),
issueImageMap(db, companyId, recoveryRows.map((row) => row.sourceIssueId), readCondition),
]);
for (const recovery of recoveryRows) {
const sourceIssue = recoveryIssueMap.get(recovery.sourceIssueId) ?? null;
if (!sourceIssue) continue;
const recoveryIssue = recovery.recoveryIssueId ? recoveryIssueMap.get(recovery.recoveryIssueId) ?? null : null;
const dedupKey = `recovery:${recovery.kind}:${recovery.sourceIssueId}:${recovery.cause}:${recovery.fingerprint}`;
add(createItem({
companyId,
sourceKind: "recovery_action",
subject: {
kind: "recovery_action",
id: recovery.id,
companyId,
title: recovery.nextAction,
identifier: null,
status: recovery.status,
href: recoveryIssue ? issueHref(prefix, recoveryIssue) : sourceIssue ? issueHref(prefix, sourceIssue) : null,
metadata: {
kind: recovery.kind,
cause: recovery.cause,
ownerType: recovery.ownerType,
ownerUserId: recovery.ownerUserId,
sourceIssueId: recovery.sourceIssueId,
recoveryIssueId: recovery.recoveryIssueId,
},
},
whyNow: recovery.status === "escalated"
? "Recovery action escalated to a human owner."
: "Recovery action is assigned to a human owner.",
decisionVerbs: decisionVerbs(
{ id: "resolve", label: "Resolve", description: "Record the recovery outcome." },
{ id: "reassign", label: "Reassign", description: "Move the recovery to another owner." },
{ id: "cancel", label: "Cancel", description: "Cancel the recovery action." },
),
inlineResolvable: false,
entryRule: "issue_recovery_actions.status in ('active','escalated') and owner_type in ('user','board')",
exitRule: "Recovery action resolves, is cancelled, or moves back to an agent/system owner.",
dedupKey,
severity: recovery.status === "escalated" ? "high" : "medium",
activityAt: toIso(recovery.updatedAt),
createdAt: toIso(recovery.createdAt),
updatedAt: toIso(recovery.updatedAt),
relatedIssue: sourceIssue ? issueSubject(prefix, sourceIssue) : null,
...issueContext(sourceIssue),
detail: genericDetail(recovery.nextAction, issueImages(recoveryImageMap, recovery.sourceIssueId)),
}));
}
const blockedIssues = await issueService(db).list(companyId, { status: "blocked", includeBlockedBy: true, readCondition });
type BlockedAttentionIssue = IssueSubjectRow & {
blockerAttention?: {
state?: string;
sampleStalledBlockerIdentifier?: string | null;
sampleBlockerIdentifier?: string | null;
blockingTreeLive?: boolean;
terminalBlockerIssueId?: string | null;
} | null;
unblockDescriptor?: { owner: { userId: string } | { agentId: string } | "board"; action: string } | null;
blockedTransitionAt?: Date | null;
};
const typedBlockedIssues = blockedIssues as BlockedAttentionIssue[];
const terminalBlockerIssueIds = typedBlockedIssues
.map((issue) => issue.blockerAttention?.terminalBlockerIssueId)
.filter((issueId): issueId is string => Boolean(issueId));
const [blockedIssueSummaries, terminalBlockerSummaries, blockerImageMap, blockingIssues] = await Promise.all([
issueSummaryMap(db, companyId, blockedIssues.map((issue) => issue.id), readCondition),
issueSummaryMap(db, companyId, terminalBlockerIssueIds, readCondition),
issueImageMap(
db,
companyId,
[...blockedIssues.map((issue) => issue.id), ...terminalBlockerIssueIds],
readCondition,
),
blockingIssueMap(db, companyId, blockedIssues.map((issue) => issue.id), readCondition),
]);
const terminalCandidates = new Map<string, {
issue: BlockedAttentionIssue;
issueSummary: IssueSummaryRow | null;
terminalSummary: IssueSummaryRow | IssueSubjectRow;
state: "stalled" | "needs_attention";
}>();
for (const issue of typedBlockedIssues) {
const descriptor = issue.unblockDescriptor;
const humanOwnerMatches = descriptor?.owner === "board"
|| (descriptor?.owner && "userId" in descriptor.owner && descriptor.owner.userId === options.userId);
if (descriptor && humanOwnerMatches && isProspectiveBlockedTransition(issue)) {
const issueSummary = blockedIssueSummaries.get(issue.id) ?? null;
add(createItem({
companyId,
sourceKind: "blocker_attention",
subject: issueSubject(prefix, issueSummary ?? issue),
whyNow: descriptor.action,
decisionVerbs: decisionVerbs(
{ id: "unblock", label: "Unblock", description: descriptor.action },
{ id: "reassign", label: "Reassign", description: "Route this blocked issue to another owner." },
),
inlineResolvable: false,
entryRule: "blocked issue has a human-owned unblockDescriptor",
exitRule: "Issue leaves blocked status.",
dedupKey: `blocked-owner:${issue.id}:${issue.blockedTransitionAt.toISOString()}`,
severity: "high",
activityAt: toIso(issue.blockedTransitionAt),
createdAt: toIso(issue.createdAt),
updatedAt: toIso(issue.updatedAt),
relatedIssue: null,
...issueContext(issueSummary),
detail: {
kind: "blocker",
blockingIssue: resolveBlockingIssue(issue, blockingIssues.get(issue.id)),
images: issueImages(blockerImageMap, issue.id),
},
}));
}
const blockerAttention = issue.blockerAttention;
if (blockerAttention?.state !== "stalled" && blockerAttention?.state !== "needs_attention") continue;
if (blockerAttention.blockingTreeLive) continue;
const issueSummary = blockedIssueSummaries.get(issue.id) ?? null;
const terminalIssueId = blockerAttention.terminalBlockerIssueId ?? issue.id;
const terminalSummary = terminalBlockerSummaries.get(terminalIssueId)
?? (terminalIssueId === issue.id ? issueSummary ?? issue : null);
if (!terminalSummary) continue;
const current = terminalCandidates.get(terminalIssueId);
if (!current || issue.updatedAt > current.issue.updatedAt) {
terminalCandidates.set(terminalIssueId, {
issue,
issueSummary,
terminalSummary,
state: blockerAttention.state,
});
}
}
const blockedWorkCounts = await blockedWorkCountMap(db, companyId, [...terminalCandidates.keys()]);
for (const [terminalIssueId, candidate] of terminalCandidates) {
const blockedTaskCount = blockedWorkCounts.get(terminalIssueId) ?? 0;
const taskLabel = blockedTaskCount === 1 ? "task" : "tasks";
const dedupKey = `blocker:${terminalIssueId}`;
add(createItem({
companyId,
sourceKind: "blocker_attention",
subject: issueSubject(prefix, candidate.terminalSummary),
whyNow: candidate.state === "needs_attention"
? `Blocks ${blockedTaskCount} ${taskLabel} and needs human attention.`
: `Blocks ${blockedTaskCount} ${taskLabel}; choose the next owner or action.`,
decisionVerbs: decisionVerbs(
{ id: "unblock", label: "Unblock", description: "Repair or replace the stalled blocker path." },
{ id: "reassign", label: "Reassign", description: "Assign the stalled blocker to a live owner." },
{ id: "nudge", label: "Nudge", description: "Wake or prompt the current owner." },
),
inlineResolvable: false,
entryRule: `terminal blocker has a non-live blockerAttention.state = '${candidate.state}'`,
exitRule: "The blocking tree becomes live or no open work remains blocked.",
dedupKey,
severity: "high",
activityAt: toIso(candidate.terminalSummary.updatedAt),
createdAt: toIso(candidate.terminalSummary.createdAt),
updatedAt: toIso(candidate.terminalSummary.updatedAt),
relatedIssue: candidate.issueSummary ? issueSubject(prefix, candidate.issueSummary) : null,
...issueContext(candidate.terminalSummary),
detail: {
kind: "blocker",
blockingIssue: null,
blockedTaskCount,
images: issueImages(blockerImageMap, terminalIssueId),
},
}));
}
const reviewRows = await db
.select({
id: issues.id,
companyId: issues.companyId,
identifier: issues.identifier,
title: issues.title,
status: issues.status,
priority: issues.priority,
assigneeAgentId: issues.assigneeAgentId,
assigneeUserId: issues.assigneeUserId,
executionState: issues.executionState,
createdAt: issues.createdAt,
updatedAt: issues.updatedAt,
})
.from(issues)
.where(and(
eq(issues.companyId, companyId),
eq(issues.status, "in_review"),
executionIssueCondition(),
readCondition,
))
.orderBy(desc(issues.updatedAt), desc(issues.id));
const reviewIssueIds = reviewRows.map((row) => row.id);
const pendingReviewApprovalRows = reviewIssueIds.length === 0
? []
: await db
.select({ issueId: issueApprovals.issueId, approvalId: approvals.id })
.from(issueApprovals)
.innerJoin(approvals, eq(issueApprovals.approvalId, approvals.id))
.where(and(
eq(issueApprovals.companyId, companyId),
eq(approvals.companyId, companyId),
inArray(issueApprovals.issueId, reviewIssueIds),
eq(approvals.status, "pending"),
));
const pendingApprovalByIssueId = new Map(pendingReviewApprovalRows.map((row) => [row.issueId, row.approvalId]));
const [reviewAttentionByIssueId, reviewIssueMap, reviewImageMap] = await Promise.all([
issueService(db).listReviewAttention(companyId, reviewRows),
issueSummaryMap(db, companyId, reviewIssueIds, readCondition),
issueImageMap(db, companyId, reviewIssueIds, readCondition),
]);
for (const review of reviewRows) {
const state = parseIssueExecutionState(review.executionState);
const currentParticipant = state?.status === "pending" ? state.currentParticipant : null;
const hasHumanParticipant = currentParticipant?.type === "user";
const pendingApprovalId = pendingApprovalByIssueId.get(review.id) ?? null;
const reviewAttention = reviewAttentionByIssueId.get(review.id);
const stalled = reviewAttention?.state === "stalled";
if (!hasHumanParticipant && !review.assigneeUserId && !pendingApprovalId && !stalled) continue;
const issue = reviewIssueMap.get(review.id);
if (!issue) continue;
const dedupKey = `review:${review.id}`;
// A stalled review carries no interaction/approval/monitor to open, so
// it is resolved in-row with the three review verbs (PAP-16080 §4.4).
// Covered reviews still deep-link — their real action lives elsewhere
// (the pending interaction/approval card, a monitor, a live run).
const reviewSubject = issueSubject(prefix, issue);
add(createItem({
companyId,
sourceKind: "review",
subject: stalled
? { ...reviewSubject, metadata: { ...reviewSubject.metadata, reviewAttentionState: "stalled" } }
: reviewSubject,
whyNow: stalled
? "Issue is in review without a maintained reviewer, interaction, approval, monitor, run, wake, or recovery path."
: pendingApprovalId
? "Issue is in review with a linked pending approval."
: hasHumanParticipant
? "Issue is in review and the current execution participant is a user."
: "Issue is in review and assigned to a user.",
decisionVerbs: stalled
? decisionVerbs(
{ id: "choose_review_path", label: "Choose review path", description: "Add a reviewer or waiting path, return the issue to work, or accept it." },
{ id: "request_changes", label: "Request changes", description: "Return the issue to the assignee with changes requested." },
)
: decisionVerbs(
{ id: "approve", label: "Approve", description: "Approve the review and advance the issue." },
{ id: "request_changes", label: "Request changes", description: "Return the issue to the assignee with changes requested." },
),
inlineResolvable: stalled,
entryRule: stalled
? "issues.status = 'in_review' and reviewAttention.state = 'stalled'."
: "issues.status = 'in_review' and human reviewer, user assignee, or linked pending approval exists.",
exitRule: "Issue leaves in_review or the human review path resolves.",
dedupKey,
severity: stalled ? "high" : "medium",
activityAt: toIso(review.updatedAt),
createdAt: toIso(review.createdAt),
updatedAt: toIso(review.updatedAt),
relatedIssue: null,
...issueContext(issue),
detail: genericDetail(review.title, issueImages(reviewImageMap, review.id)),
}));
}
const failedRows = await listAttentionExhaustedRuns(db, companyId);
const failedIssueIds = failedRows.map((row) => readRunIssueId(row.contextSnapshot));
const [failedIssueMap, failedImageMap, failedRunsWithNewerRun] = await Promise.all([
issueSummaryMap(
db,
companyId,
failedIssueIds,
readCondition,
),
issueImageMap(db, companyId, failedIssueIds, readCondition),
listFailedRunsWithNewerRun(db, companyId, failedRows.map((row, index) => ({
id: row.id,
agentId: row.agentId,
issueId: failedIssueIds[index],
createdAt: row.createdAt,
}))),
]);
for (const run of failedRows) {
const issueId = readRunIssueId(run.contextSnapshot);
if (failedRunsWithNewerRun.has(run.id)) continue;
const issue = issueId ? failedIssueMap.get(issueId) ?? null : null;
if (issueId && !issue) continue;
const dedupKey = `run:${run.id}`;
add(createItem({
companyId,
sourceKind: "failed_run",
subject: {
kind: "run",
id: run.id,
companyId,
title: `${run.agentName} run ${run.status}`,
identifier: null,
status: run.status,
href: `/${prefix}/agents/${run.agentId}/runs/${run.id}`,
metadata: {
agentId: run.agentId,
agentName: run.agentName,
issueId,
errorCode: run.errorCode,
error: run.error,
retryExhaustedReason: run.exhaustionMessage,
},
},
whyNow: "Run failed after automatic retries were exhausted.",
decisionVerbs: decisionVerbs(
{ id: "retry", label: "Retry", description: "Retry the failed run or issue." },
{ id: "reassign", label: "Reassign", description: "Move the work to another owner." },
{ id: "dismiss", label: "Dismiss", description: "Dismiss this failed-run attention row." },
),
inlineResolvable: true,
entryRule: "latest failed/timed_out run has a Bounded retry exhausted lifecycle event.",
exitRule: "A newer run exists for the same issue/agent pair or the row is dismissed.",
dedupKey,
severity: "high",
activityAt: toIso(run.finishedAt ?? run.updatedAt ?? run.createdAt),
createdAt: toIso(run.createdAt),
updatedAt: toIso(run.updatedAt),
relatedIssue: issue ? issueSubject(prefix, issue) : null,
...issueContext(issue),
detail: {
kind: "failed_run",
agentName: run.agentName,
failureReasonExcerpt: excerpt(run.error ?? run.exhaustionMessage ?? run.errorCode),
images: issueImages(failedImageMap, issueId),
},
}));
}
const budgetOverview = await budgetService(db).overview(companyId);
for (const incident of budgetOverview.activeIncidents) {
const observedPercent = budgetObservedPercent(incident.amountObserved, incident.amountLimit);
if (incident.thresholdType !== "hard" && observedPercent < 85) continue;
const dedupKey = `budget:${incident.policyId}:${toIso(incident.windowStart)}:${incident.thresholdType}`;
add(createItem({
companyId,
sourceKind: "budget_alert",
subject: {
kind: "budget_incident",
id: incident.id,
companyId,
title: `${incident.scopeName} budget ${incident.thresholdType === "hard" ? "hard stop" : "warning"}`,
identifier: null,
status: incident.status,
href: `/${prefix}/costs`,
metadata: {
policyId: incident.policyId,
scopeType: incident.scopeType,
scopeId: incident.scopeId,
thresholdType: incident.thresholdType,
amountObserved: incident.amountObserved,
amountLimit: incident.amountLimit,
observedPercent,
approvalId: incident.approvalId,
approvalStatus: incident.approvalStatus,
},
},
whyNow: incident.thresholdType === "hard"
? "Budget hard stop was reached."
: "Budget crossed the 85% warning threshold.",
decisionVerbs: decisionVerbs(
{ id: "raise_budget_and_resume", label: "Raise budget", description: "Raise the budget and resume paused work." },
{ id: "keep_paused", label: "Keep paused", description: "Dismiss or keep the budget stop in place." },
),
inlineResolvable: true,
entryRule: "open budget incident is hard, or soft with observed spend >= 85% of limit.",
exitRule: "Budget incident is resolved or dismissed.",
dedupKey,
severity: incident.thresholdType === "hard" ? "high" : "medium",
activityAt: toIso(incident.updatedAt),
createdAt: toIso(incident.createdAt),
updatedAt: toIso(incident.updatedAt),
relatedIssue: null,
detail: {
kind: "budget",
observedPercent,
amountObserved: incident.amountObserved,
amountLimit: incident.amountLimit,
images: [],
},
}));
}
const erroredAgents = await db
.select({
id: agents.id,
companyId: agents.companyId,
name: agents.name,
role: agents.role,
status: agents.status,
errorReason: agents.errorReason,
createdAt: agents.createdAt,
updatedAt: agents.updatedAt,
})
.from(agents)
.where(and(eq(agents.companyId, companyId), eq(agents.status, "error")))
.orderBy(desc(agents.updatedAt), desc(agents.id));
for (const agent of erroredAgents) {
const dedupKey = `agent_error:${agent.id}`;
add(createItem({
companyId,
sourceKind: "agent_error_alert",
subject: {
kind: "agent",
id: agent.id,
companyId,
title: agent.name,
identifier: null,
status: agent.status,
href: `/${prefix}/agents/${agent.id}`,
metadata: { role: agent.role, errorReason: agent.errorReason },
},
whyNow: "Agent is in error status and needs operator action or dismissal.",
decisionVerbs: decisionVerbs(
{ id: "inspect", label: "Inspect", description: "Inspect the agent error." },
{ id: "dismiss", label: "Dismiss", description: "Dismiss this alert." },
),
inlineResolvable: true,
entryRule: "agents.status = 'error'",
exitRule: "Agent leaves error status or the row is dismissed.",
dedupKey,
severity: "high",
activityAt: toIso(agent.updatedAt),
createdAt: toIso(agent.createdAt),
updatedAt: toIso(agent.updatedAt),
relatedIssue: null,
detail: {
kind: "agent_error",
agentName: agent.name,
failureReasonExcerpt: excerpt(agent.errorReason),
images: [],
},
}));
}
const deduped = new Map<string, AttentionItem>();
for (const item of collected) {
const current = deduped.get(item.dedupKey);
deduped.set(item.dedupKey, current ? betterDuplicate(current, item) : item);
}
const collectedItems = [...deduped.values()].sort(compareAttentionItems);
await decisionQueueService(db).materializeSeededQueues(companyId, collectedItems);
const enrichedItems = await enrichAttentionItems(db, companyId, collectedItems, now);
const activitySince = parseActivityBoundary(options.activitySince, "activitySince");
const activityUntil = parseActivityBoundary(options.activityUntil, "activityUntil");
if (activitySince != null && activityUntil != null && activitySince > activityUntil) {
throw badRequest("activitySince must be before or equal to activityUntil");
}
const queueKey = options.queue?.trim() || null;
const visibleItems = enrichedItems.filter((item) => {
if (options.archived === true ? !item.archivedAt : Boolean(item.archivedAt)) return false;
if (!includeDismissed && item.snoozedUntil && timestamp(item.snoozedUntil) > now) return false;
const activity = timestamp(item.activityAt);
if (activitySince != null && activity < activitySince) return false;
if (activityUntil != null && activity > activityUntil) return false;
if (queueKey && !item.queues.some((queue) => queue.key === queueKey)) return false;
return true;
});
const sort = options.sort ?? "activity";
if (sort !== "activity" && sort !== "decide") throw badRequest("sort must be 'activity' or 'decide'");
const selectedComparator = sort === "decide"
? (left: AttentionItem, right: AttentionItem) => compareDecideItems(left, right, now)
: compareAttentionItems;
const rankedItems = orderBlockedAttentionByWeight(
visibleItems.sort(selectedComparator),
selectedComparator,
)
.map((item, index) => ({ ...item, rank: index + 1 }));
let items: AttentionItem[];
let nextCursor: string | null;
if (options.all) {
if (options.cursor || options.limit !== undefined) {
throw badRequest("all cannot be combined with cursor or limit");
}
items = rankedItems;
nextCursor = null;
} else {
const limit = options.limit ?? ATTENTION_PAGE_DEFAULT_LIMIT;
if (!Number.isInteger(limit) || limit < 1 || limit > ATTENTION_PAGE_MAX_LIMIT) {
throw badRequest(`limit must be an integer between 1 and ${ATTENTION_PAGE_MAX_LIMIT}`);
}
let pageStart = 0;
if (options.cursor) {
const cursorItemId = decodeCursor(options.cursor, sort);
const cursorIndex = rankedItems.findIndex((item) => item.id === cursorItemId);
if (cursorIndex < 0) throw badRequest("Attention cursor no longer matches the filtered feed");
pageStart = cursorIndex + 1;
}
items = rankedItems.slice(pageStart, pageStart + limit);
const hasNextPage = pageStart + items.length < rankedItems.length;
nextCursor = hasNextPage && items.length > 0 ? encodeCursor(sort, items[items.length - 1]!) : null;
}
if (options.userId) {
const trainable: Array<{ sourceKind: "approval" | "interaction"; sourceId: string }> = [];
for (const item of items) {
if (item.sourceKind === "approval") {
trainable.push({ sourceKind: "approval", sourceId: item.subject.id });
}
if (item.sourceKind === "issue_thread_interaction") {
trainable.push({ sourceKind: "interaction", sourceId: item.subject.id });
}
}
if (trainable.length > 0) {
const examples = await db
.select({
id: decisionTrainingExamples.id,
sourceKind: decisionTrainingExamples.sourceKind,
sourceId: decisionTrainingExamples.sourceId,
})
.from(decisionTrainingExamples)
.where(and(
eq(decisionTrainingExamples.companyId, companyId),
eq(decisionTrainingExamples.createdByUserId, options.userId),
inArray(decisionTrainingExamples.sourceId, trainable.map((item) => item.sourceId)),
));
const exampleBySource = new Map(examples.map((row) => [`${row.sourceKind}:${row.sourceId}`, row.id]));
for (const item of items) {
const sourceKind = item.sourceKind === "approval"
? "approval"
: item.sourceKind === "issue_thread_interaction"
? "interaction"
: null;
item.trainingExampleId = sourceKind
? exampleBySource.get(`${sourceKind}:${item.subject.id}`) ?? null
: null;
}
}
}
const countsBySourceKind = emptyCounts();
for (const item of rankedItems) countsBySourceKind[item.sourceKind] += 1;
return {
companyId,
generatedAt: new Date().toISOString(),
totalCount: rankedItems.length,
// Desk badge: distinct items that surfaced
// today OR carry an explicit decide-by deadline due today/past. Counted
// over the full ranked set (pre-pagination) so the sidebar badge stays
// company-wide accurate even on a small first page.
deskBadgeCount: rankedItems.filter((item) => isNewToday(item, now) || isDecideNow(item, now)).length,
nextCursor,
countsBySourceKind,
items,
};
},
};
}