mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-14 08:26:46 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - A company accumulates real state — issues, labels, blockers, documents, work products, monitors, attachments, agents, routines — and people need to move that state between instances: self-hosted to cloud, cloud back to self-hosted, or plain backups > - The experimental, flag-gated Cloud Sync transport (#6548) tried to solve this host-to-host: the source pushed into a receiver over HTTPS with a cross-instance consent/token handshake, which required the destination to be publicly reachable and broke for common self-hosted topologies (plain-HTTP LAN/VPN origins); the receiver half never landed upstream at all > - Meanwhile the portability bundle and the existing export/import pages already move companies offline with none of those networking constraints — but silently dropped labels, blockers, issue documents, work products, monitors, and every attachment > - This pull request removes the host-to-host transport and makes Import/Export the single data-movement path: the pages become first-class company-settings destinations, exports declare exactly what they do not carry, and bundle schemaVersion 6 now carries all of the above, with attachments as content-addressed sha256 blobs verified before a single row is written > - The benefit is a migration and backup flow that works between any two instances with no reachability requirements, no cross-instance auth, and no silent data loss ## Linked Issues or Issue Description - Refs #6548 — the original Cloud Sync sender this PR supersedes and removes. - Related, not duplicates: #1697 (goals in the portability manifest — orthogonal field addition), #954 (an earlier import/export + skill-visibility proposal predating the current portability bundle). - No open issue describes this directly, so in brief (feature-request shape): **Problem** — moving a company between instances silently lost labels (imports with label references actually hard-failed), blocker relations, issue documents, work products, monitor state, and all attachments, and the alternative Cloud Sync transport required the destination to be publicly reachable over HTTPS plus a consent handshake, which failed for typical self-hosted setups. **Desired behavior** — one Import/Export flow in company settings that produces a portable bundle carrying all of that data, tells the operator up front what it cannot carry, imports with automations paused, and offers real one-click activation afterwards. ## What Changed - New export fidelity report (`GET /api/companies/:companyId/export/fidelity`) + an "Export fidelity" panel on the Export page listing anything a bundle will not include (now only: approvals, cost history, activity history) - Imports accept `pauseAutomations`; imported agents and routines land paused, the import result reports created routines, and the Import page ends in an activation panel that actually resumes selected agents/activates routines - Export and Import pages promoted into the company-settings nav; the Cloud Upstream wizard, ux-lab page, and API client removed; the old settings route redirects to Export - Host-to-host transport removed: upstream-sync/receiver-client routes and services, CLI `cloud connect`/`cloud push` + keypair store, the shared upstream transfer contract, and the `enableCloudSync` flag; migration `0196` drops the two experimental `cloud_upstream_*` sender tables - Bundle schemaVersion 6: labels (definitions + per-task names, remapped by name on import), blocker relations (`blockedBy` slugs, cycle-tolerant), issue documents (`tasks/<slug>/documents/<key>.md`), work products (system refs nulled), monitors (notes/scheduledBy restored, imported un-armed) - Attachments travel as content-addressed `blobs/<sha256>` entries (deduped; comment-scoped attachments re-link via comment index); every blob is hash-verified **before any write**, so a corrupted bundle cannot leave a partially imported company; both zip codecs now round-trip extensionless/binary entries byte-exactly; the Import page preflights the inline body limit and offers continue-without-attachments - v5 (and older) bundles still import, with an informational warning; bundles newer than v6 are rejected cleanly - Docs: board-operator import/export guide, CLI README, README/ROADMAP updated ## Verification - `pnpm -r` typechecks (shared, db incl. migration numbering/safety checks, server, ui, cli) and `pnpm check:token-gates` — clean - Vitest: full server + shared sweep 4,888 passed / 1 skipped, with the only 3 failures being pre-existing on `master` (2× heartbeat-workspace-branch-containment, 1× workspace-runtime auto-port; reproduced identically with this change stashed); ui + cli suites green; the embedded-Postgres export-fidelity suite applies the full migration chain including the new `0196` against a fresh database - Live end-to-end on a scratch instance: seeded a company with labels, a blocker pair, an issue document, a work product, a monitor, an agent, a routine, and two binary attachments (one comment-scoped) → export → import into a fresh company → labels remapped to new ids, blocker edge and document restored, monitor un-armed with notes intact, attachments byte-identical (sha256-compared through the API), agents/routines paused → activation panel resumed them; a v5-shaped bundle imported with only the info warning; flipping one byte in a blob made the import 422 with **zero** rows created - Reviewer repro: create a company with a labeled issue + attachment → Settings → Export → download → Settings → Import on another company/instance → watch the preview, apply with "start paused", then activate ## Risks - Migration `0196` drops `cloud_upstream_connections`/`cloud_upstream_runs` — experimental tables behind a default-off flag; their connection/run history is intentionally discarded - Breaking removals are all of experimental, flag-gated surface: `/api/upstream-sync/*` + `/api/cloud-upstreams/*` routes, `paperclipai cloud connect|push`, and the `enableCloudSync` flag (stale keys in stored instance settings parse harmlessly) - Import remains non-atomic on mid-apply errors generally (pre-existing behavior); the new blob verification specifically moved ahead of all writes so tampered bundles cannot create partial state - GitHub-sourced imports do not fetch `blobs/*` and skip attachments with a warning ## Model Used - Claude Fable 5 (`claude-fable-5`, Anthropic), via Claude Code CLI with extended thinking, tool use, and subagent orchestration; implementation and review split across Fable 5 subagents, with live end-to-end verification against a running instance ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
392 lines
13 KiB
TypeScript
392 lines
13 KiB
TypeScript
// @vitest-environment node
|
|
|
|
import { deflateRawSync } from "node:zlib";
|
|
import { describe, expect, it } from "vitest";
|
|
import { createZipArchive, estimateZipArchiveSize, readZipArchive } from "./zip";
|
|
|
|
function readUint16(bytes: Uint8Array, offset: number) {
|
|
return bytes[offset]! | (bytes[offset + 1]! << 8);
|
|
}
|
|
|
|
function readUint32(bytes: Uint8Array, offset: number) {
|
|
return (
|
|
bytes[offset]! |
|
|
(bytes[offset + 1]! << 8) |
|
|
(bytes[offset + 2]! << 16) |
|
|
(bytes[offset + 3]! << 24)
|
|
) >>> 0;
|
|
}
|
|
|
|
function readString(bytes: Uint8Array, offset: number, length: number) {
|
|
return new TextDecoder().decode(bytes.slice(offset, offset + length));
|
|
}
|
|
|
|
function writeUint16(target: Uint8Array, offset: number, value: number) {
|
|
target[offset] = value & 0xff;
|
|
target[offset + 1] = (value >>> 8) & 0xff;
|
|
}
|
|
|
|
function writeUint32(target: Uint8Array, offset: number, value: number) {
|
|
target[offset] = value & 0xff;
|
|
target[offset + 1] = (value >>> 8) & 0xff;
|
|
target[offset + 2] = (value >>> 16) & 0xff;
|
|
target[offset + 3] = (value >>> 24) & 0xff;
|
|
}
|
|
|
|
function crc32(bytes: Uint8Array) {
|
|
let crc = 0xffffffff;
|
|
for (const byte of bytes) {
|
|
crc ^= byte;
|
|
for (let bit = 0; bit < 8; bit += 1) {
|
|
crc = (crc & 1) === 1 ? (crc >>> 1) ^ 0xedb88320 : crc >>> 1;
|
|
}
|
|
}
|
|
return (crc ^ 0xffffffff) >>> 0;
|
|
}
|
|
|
|
function createDeflatedZipArchive(files: Record<string, string>, rootPath: string) {
|
|
const encoder = new TextEncoder();
|
|
const localChunks: Uint8Array[] = [];
|
|
const centralChunks: Uint8Array[] = [];
|
|
let localOffset = 0;
|
|
let entryCount = 0;
|
|
|
|
for (const [relativePath, content] of Object.entries(files).sort(([a], [b]) => a.localeCompare(b))) {
|
|
const fileName = encoder.encode(`${rootPath}/${relativePath}`);
|
|
const rawBody = encoder.encode(content);
|
|
const deflatedBody = new Uint8Array(deflateRawSync(rawBody));
|
|
const checksum = crc32(rawBody);
|
|
|
|
const localHeader = new Uint8Array(30 + fileName.length);
|
|
writeUint32(localHeader, 0, 0x04034b50);
|
|
writeUint16(localHeader, 4, 20);
|
|
writeUint16(localHeader, 6, 0x0800);
|
|
writeUint16(localHeader, 8, 8);
|
|
writeUint32(localHeader, 14, checksum);
|
|
writeUint32(localHeader, 18, deflatedBody.length);
|
|
writeUint32(localHeader, 22, rawBody.length);
|
|
writeUint16(localHeader, 26, fileName.length);
|
|
localHeader.set(fileName, 30);
|
|
|
|
const centralHeader = new Uint8Array(46 + fileName.length);
|
|
writeUint32(centralHeader, 0, 0x02014b50);
|
|
writeUint16(centralHeader, 4, 20);
|
|
writeUint16(centralHeader, 6, 20);
|
|
writeUint16(centralHeader, 8, 0x0800);
|
|
writeUint16(centralHeader, 10, 8);
|
|
writeUint32(centralHeader, 16, checksum);
|
|
writeUint32(centralHeader, 20, deflatedBody.length);
|
|
writeUint32(centralHeader, 24, rawBody.length);
|
|
writeUint16(centralHeader, 28, fileName.length);
|
|
writeUint32(centralHeader, 42, localOffset);
|
|
centralHeader.set(fileName, 46);
|
|
|
|
localChunks.push(localHeader, deflatedBody);
|
|
centralChunks.push(centralHeader);
|
|
localOffset += localHeader.length + deflatedBody.length;
|
|
entryCount += 1;
|
|
}
|
|
|
|
const centralDirectoryLength = centralChunks.reduce((sum, chunk) => sum + chunk.length, 0);
|
|
const archive = new Uint8Array(
|
|
localChunks.reduce((sum, chunk) => sum + chunk.length, 0) + centralDirectoryLength + 22,
|
|
);
|
|
let offset = 0;
|
|
for (const chunk of localChunks) {
|
|
archive.set(chunk, offset);
|
|
offset += chunk.length;
|
|
}
|
|
const centralDirectoryOffset = offset;
|
|
for (const chunk of centralChunks) {
|
|
archive.set(chunk, offset);
|
|
offset += chunk.length;
|
|
}
|
|
writeUint32(archive, offset, 0x06054b50);
|
|
writeUint16(archive, offset + 8, entryCount);
|
|
writeUint16(archive, offset + 10, entryCount);
|
|
writeUint32(archive, offset + 12, centralDirectoryLength);
|
|
writeUint32(archive, offset + 16, centralDirectoryOffset);
|
|
|
|
return archive;
|
|
}
|
|
|
|
function createZipArchiveWithDirectoryEntries(rootPath: string) {
|
|
const encoder = new TextEncoder();
|
|
const entries = [
|
|
{ path: `${rootPath}/`, body: new Uint8Array(0), compressionMethod: 0 },
|
|
{ path: `${rootPath}/agents/`, body: new Uint8Array(0), compressionMethod: 0 },
|
|
{ path: `${rootPath}/agents/ceo/`, body: new Uint8Array(0), compressionMethod: 0 },
|
|
{ path: `${rootPath}/COMPANY.md`, body: encoder.encode("# Company\n"), compressionMethod: 8 },
|
|
{ path: `${rootPath}/agents/ceo/AGENTS.md`, body: encoder.encode("# CEO\n"), compressionMethod: 8 },
|
|
].map((entry) => ({
|
|
...entry,
|
|
data: entry.compressionMethod === 8 ? new Uint8Array(deflateRawSync(entry.body)) : entry.body,
|
|
checksum: crc32(entry.body),
|
|
}));
|
|
|
|
const localChunks: Uint8Array[] = [];
|
|
const centralChunks: Uint8Array[] = [];
|
|
let localOffset = 0;
|
|
|
|
for (const entry of entries) {
|
|
const fileName = encoder.encode(entry.path);
|
|
const localHeader = new Uint8Array(30 + fileName.length);
|
|
writeUint32(localHeader, 0, 0x04034b50);
|
|
writeUint16(localHeader, 4, 20);
|
|
writeUint16(localHeader, 6, 0x0800);
|
|
writeUint16(localHeader, 8, entry.compressionMethod);
|
|
writeUint32(localHeader, 14, entry.checksum);
|
|
writeUint32(localHeader, 18, entry.data.length);
|
|
writeUint32(localHeader, 22, entry.body.length);
|
|
writeUint16(localHeader, 26, fileName.length);
|
|
localHeader.set(fileName, 30);
|
|
|
|
const centralHeader = new Uint8Array(46 + fileName.length);
|
|
writeUint32(centralHeader, 0, 0x02014b50);
|
|
writeUint16(centralHeader, 4, 20);
|
|
writeUint16(centralHeader, 6, 20);
|
|
writeUint16(centralHeader, 8, 0x0800);
|
|
writeUint16(centralHeader, 10, entry.compressionMethod);
|
|
writeUint32(centralHeader, 16, entry.checksum);
|
|
writeUint32(centralHeader, 20, entry.data.length);
|
|
writeUint32(centralHeader, 24, entry.body.length);
|
|
writeUint16(centralHeader, 28, fileName.length);
|
|
writeUint32(centralHeader, 42, localOffset);
|
|
centralHeader.set(fileName, 46);
|
|
|
|
localChunks.push(localHeader, entry.data);
|
|
centralChunks.push(centralHeader);
|
|
localOffset += localHeader.length + entry.data.length;
|
|
}
|
|
|
|
const centralDirectoryLength = centralChunks.reduce((sum, chunk) => sum + chunk.length, 0);
|
|
const archive = new Uint8Array(
|
|
localChunks.reduce((sum, chunk) => sum + chunk.length, 0) + centralDirectoryLength + 22,
|
|
);
|
|
let offset = 0;
|
|
for (const chunk of localChunks) {
|
|
archive.set(chunk, offset);
|
|
offset += chunk.length;
|
|
}
|
|
const centralDirectoryOffset = offset;
|
|
for (const chunk of centralChunks) {
|
|
archive.set(chunk, offset);
|
|
offset += chunk.length;
|
|
}
|
|
writeUint32(archive, offset, 0x06054b50);
|
|
writeUint16(archive, offset + 8, entries.length);
|
|
writeUint16(archive, offset + 10, entries.length);
|
|
writeUint32(archive, offset + 12, centralDirectoryLength);
|
|
writeUint32(archive, offset + 16, centralDirectoryOffset);
|
|
|
|
return archive;
|
|
}
|
|
|
|
describe("createZipArchive", () => {
|
|
it("writes a zip archive with the export root path prefixed into each entry", () => {
|
|
const archive = createZipArchive(
|
|
{
|
|
"COMPANY.md": "# Company\n",
|
|
"agents/ceo/AGENTS.md": "# CEO\n",
|
|
},
|
|
"paperclip-demo",
|
|
);
|
|
|
|
expect(readUint32(archive, 0)).toBe(0x04034b50);
|
|
|
|
const firstNameLength = readUint16(archive, 26);
|
|
const firstBodyLength = readUint32(archive, 18);
|
|
expect(readString(archive, 30, firstNameLength)).toBe("paperclip-demo/agents/ceo/AGENTS.md");
|
|
expect(readString(archive, 30 + firstNameLength, firstBodyLength)).toBe("# CEO\n");
|
|
|
|
const secondOffset = 30 + firstNameLength + firstBodyLength;
|
|
expect(readUint32(archive, secondOffset)).toBe(0x04034b50);
|
|
|
|
const secondNameLength = readUint16(archive, secondOffset + 26);
|
|
const secondBodyLength = readUint32(archive, secondOffset + 18);
|
|
expect(readString(archive, secondOffset + 30, secondNameLength)).toBe("paperclip-demo/COMPANY.md");
|
|
expect(readString(archive, secondOffset + 30 + secondNameLength, secondBodyLength)).toBe("# Company\n");
|
|
|
|
const endOffset = archive.length - 22;
|
|
expect(readUint32(archive, endOffset)).toBe(0x06054b50);
|
|
expect(readUint16(archive, endOffset + 8)).toBe(2);
|
|
expect(readUint16(archive, endOffset + 10)).toBe(2);
|
|
});
|
|
|
|
it("reads a Paperclip zip archive back into rootPath and file contents", async () => {
|
|
const archive = createZipArchive(
|
|
{
|
|
"COMPANY.md": "# Company\n",
|
|
"agents/ceo/AGENTS.md": "# CEO\n",
|
|
".paperclip.yaml": "schema: paperclip/v1\n",
|
|
},
|
|
"paperclip-demo",
|
|
);
|
|
|
|
await expect(readZipArchive(archive)).resolves.toEqual({
|
|
rootPath: "paperclip-demo",
|
|
files: {
|
|
"COMPANY.md": "# Company\n",
|
|
"agents/ceo/AGENTS.md": "# CEO\n",
|
|
".paperclip.yaml": "schema: paperclip/v1\n",
|
|
},
|
|
});
|
|
});
|
|
|
|
it("round-trips binary image files without coercing them to text", async () => {
|
|
const archive = createZipArchive(
|
|
{
|
|
"images/company-logo.png": {
|
|
encoding: "base64",
|
|
data: Buffer.from("png-bytes").toString("base64"),
|
|
contentType: "image/png",
|
|
},
|
|
},
|
|
"paperclip-demo",
|
|
);
|
|
|
|
await expect(readZipArchive(archive)).resolves.toEqual({
|
|
rootPath: "paperclip-demo",
|
|
files: {
|
|
"images/company-logo.png": {
|
|
encoding: "base64",
|
|
data: Buffer.from("png-bytes").toString("base64"),
|
|
contentType: "image/png",
|
|
},
|
|
},
|
|
});
|
|
});
|
|
|
|
it("round-trips extensionless blobs/ entries as base64 octet streams", async () => {
|
|
const bytes = new Uint8Array([0x00, 0x01, 0x80, 0xfe, 0xff]);
|
|
const entry = {
|
|
encoding: "base64" as const,
|
|
data: Buffer.from(bytes).toString("base64"),
|
|
contentType: "application/octet-stream",
|
|
};
|
|
const archive = createZipArchive(
|
|
{
|
|
"COMPANY.md": "# Company\n",
|
|
"blobs/4f2d1c9a": entry,
|
|
},
|
|
"paperclip-demo",
|
|
);
|
|
|
|
await expect(readZipArchive(archive)).resolves.toEqual({
|
|
rootPath: "paperclip-demo",
|
|
files: {
|
|
"COMPANY.md": "# Company\n",
|
|
"blobs/4f2d1c9a": entry,
|
|
},
|
|
});
|
|
});
|
|
|
|
it("falls back to base64 for invalid UTF-8 bytes instead of mangling them", async () => {
|
|
const invalidUtf8 = new Uint8Array([0x68, 0x69, 0xff, 0xfe, 0xc0]);
|
|
const archive = createZipArchive(
|
|
{
|
|
"tasks/pap-1/raw-notes": {
|
|
encoding: "base64",
|
|
data: Buffer.from(invalidUtf8).toString("base64"),
|
|
contentType: null,
|
|
},
|
|
},
|
|
"paperclip-demo",
|
|
);
|
|
|
|
const result = await readZipArchive(archive);
|
|
expect(result.files["tasks/pap-1/raw-notes"]).toEqual({
|
|
encoding: "base64",
|
|
data: Buffer.from(invalidUtf8).toString("base64"),
|
|
contentType: "application/octet-stream",
|
|
});
|
|
});
|
|
|
|
it("reads standard DEFLATE zip archives created outside Paperclip", async () => {
|
|
const archive = createDeflatedZipArchive(
|
|
{
|
|
"COMPANY.md": "# Company\n",
|
|
"agents/ceo/AGENTS.md": "# CEO\n",
|
|
},
|
|
"paperclip-demo",
|
|
);
|
|
|
|
await expect(readZipArchive(archive)).resolves.toEqual({
|
|
rootPath: "paperclip-demo",
|
|
files: {
|
|
"COMPANY.md": "# Company\n",
|
|
"agents/ceo/AGENTS.md": "# CEO\n",
|
|
},
|
|
});
|
|
});
|
|
|
|
it("ignores directory entries from standard zip archives", async () => {
|
|
const archive = createZipArchiveWithDirectoryEntries("paperclip-demo");
|
|
|
|
await expect(readZipArchive(archive)).resolves.toEqual({
|
|
rootPath: "paperclip-demo",
|
|
files: {
|
|
"COMPANY.md": "# Company\n",
|
|
"agents/ceo/AGENTS.md": "# CEO\n",
|
|
},
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("estimateZipArchiveSize", () => {
|
|
it("matches the real archive byte length for mixed text and binary entries", () => {
|
|
const files = {
|
|
"COMPANY.md": "# Company\n",
|
|
"agents/céo/AGENT.md": "# Héllo wörld — 日本語 🚀\n",
|
|
"images/logo.png": {
|
|
encoding: "base64" as const,
|
|
data: Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a, 0x00]).toString("base64"),
|
|
contentType: "image/png",
|
|
},
|
|
"blobs/4f2d1c9a": {
|
|
encoding: "base64" as const,
|
|
data: Buffer.from([0x00, 0x01, 0x80, 0xfe]).toString("base64"),
|
|
contentType: "application/octet-stream",
|
|
},
|
|
"notes/empty.txt": "",
|
|
};
|
|
|
|
expect(estimateZipArchiveSize(files, "paperclip-demo")).toBe(
|
|
createZipArchive(files, "paperclip-demo").byteLength,
|
|
);
|
|
});
|
|
|
|
it("matches the real archive byte length for every base64 padding variant", () => {
|
|
for (const byteCount of [1, 2, 3, 4, 5, 6]) {
|
|
const files = {
|
|
"blobs/blob": {
|
|
encoding: "base64" as const,
|
|
data: Buffer.alloc(byteCount, 0xab).toString("base64"),
|
|
contentType: "application/octet-stream",
|
|
},
|
|
};
|
|
|
|
expect(estimateZipArchiveSize(files, "root")).toBe(
|
|
createZipArchive(files, "root").byteLength,
|
|
);
|
|
}
|
|
});
|
|
|
|
it("mirrors the writer's path normalization for messy paths", () => {
|
|
const files = {
|
|
"agents//ceo\\AGENT.md": "# CEO\n",
|
|
};
|
|
|
|
expect(estimateZipArchiveSize(files, "demo/")).toBe(
|
|
createZipArchive(files, "demo/").byteLength,
|
|
);
|
|
});
|
|
|
|
it("returns the 22-byte end-of-central-directory record for an empty map", () => {
|
|
expect(estimateZipArchiveSize({}, "paperclip-demo")).toBe(22);
|
|
expect(estimateZipArchiveSize({}, "paperclip-demo")).toBe(
|
|
createZipArchive({}, "paperclip-demo").byteLength,
|
|
);
|
|
});
|
|
});
|