mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-22 00:30:19 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - A provider must work through normal installed packages on local and Daytona environments. > - Candidate-only success does not prove that the shipped package contains the manifest and native runtime needed for Daytona. > - The release must preserve saved-token access and task lifecycle guarantees. > - This pull request will qualify Copilot and include the exact-source remote manifest in normal release archives. > - The benefit is a reviewable part of the Copilot production release. ## Linked Issues or Issue Description Refs #15701, #15703 and #15705. Supersedes qualification work in #15563 and the original candidate in #14434. Base: #15705. ## What Changed - Keep Copilot discovery passive during reconnect reconciliation; refresh on explicit opening, account/environment changes and reconnect. - Retain the selected Product cases, permission/continuity evidence and cleanup checks. - Build the Linux provider manifest from the existing pinned Docker stage in the cloud. - Join all four native daemon receipts with that manifest before server packing. - Reject missing or incompatible remote authority during normal release assembly; retain historical workflow compatibility. - Promote the completed profile47 qualification marker, publish the current qualification record and preserve every failed attempt. - Keep one current release checklist and the shipped-canary gates explicit. ## Verification Runtime #15701 is merged at `d855e550ad8d2a267312983f26457aabf5393c3a`. History #15703 is merged at `df80616d98119cbf5abd40549794d9980a5fabf6`. Remaining source [`42bcbd61299655f7e37aabe6bb5f19bba770ad1d`](https://github.com/paperclipai/paperclip/commit/42bcbd61299655f7e37aabe6bb5f19bba770ad1d) contains the four-file authorization repair. The remaining PR trees preserve six nonoverlapping files from the newer public mainline managed-settings fix and the CI-owned lockfile. No unrelated provider is enabled. The security finding is repaired: existing-agent discovery requires `agent_config:update` before connection selection or token resolution. The saved environment is the default. Authorized editors can select a prospective environment. Both denied board-viewer and agent-reader regressions fail on the original source. All49 route tests and server typecheck pass with the fix. Denied requests perform no connection selection, credential resolution or probe. Current-head security scans pass on both remaining PRs; the repaired thread is resolved. Copilot CLI1.0.88 and profile47 retain digest `sha256:55044aa235e88b3fe36ec8a556ee1e3382590870aab907e4462ef7d64af49cea`. The [qualification record](https://github.com/paperclipai/paperclip/blob/42bcbd61299655f7e37aabe6bb5f19bba770ad1d/doc/plans/2026-10-20-copilot-qualification-v47.json) reports20/20 Product cells,154 assertions and7/7 protocol cases,46 assertions against frozen normal installed source `c2616370800f5f6df45246b0890ba35a7cd2faab`. The exact qualification model is `gpt-5.6-luna`. Every passing Product case confirms cleanup. Original failures remain recorded; automatic behavior retries are disabled. The route-only authorization repair changes no bound runtime/profile bytes and does not relabel the frozen campaign. The ordinary installed remote journey passed saved-token selection, model discovery, normal UI save/reopen, metadata-only Test, completed task, accepted receipt and exact19-byte browser download. An open model catalog caused no additional discovery requests during117seconds. Actual installed runtime smokes passed on macOS ARM64, macOS x64 under Rosetta and native Linux x64 on Daytona. Raw token browser entry was not exercised; encrypted connection creation used the normal API. The first Daytona file attempt timed out during delayed semantic dispatch; its precise stalled layer remains unresolved. Independent ordinary remote delivery and the other19 Product cells passed before one instrumented recheck passed8/8 with unchanged source,prompt,assertions and deadlines. No causal latency repair is claimed. Before the authorization repair, all four final PR heads passed required verify/E2E and fresh Greptile5/5 reviews with zero unresolved threads. Current-head CI/review is running for the two repaired heads. Local focused checks retain129 connection,59 runner,72 shared-eval and88 recovery/workspace passes, plus migration safety and token gates. The additive Copilot migration is361; released master history is preserved. [Cloud normal-package run39414239704](https://github.com/paperclipai/paperclip/actions/runs/39414239704) builds the pre-security source4f3f. All four native producers and Linux package assembly pass; the final clean installed consumers are finishing. All18 retained archives match their hashes;37,863 regular files contain zero selected credentials. That package does not contain the later route repair. The actual final published package must include it and pass the local/Daytona live canaries. The frozen Daytona image remains published and independently verified. No separate full-image scan is claimed. Docker builds run in the cloud. **Remaining:** current-head CI/review, setup and qualification merges, final publication, and ordinary local/Daytona canaries against the actual shipped package. The user explicitly authorizes the maintainer review override; CI remains a merge gate. No production deployment is claimed. Provider USD remains unknown and GitHub-attributed. ## Risks An omitted or mismatched image manifest prevents ordinary Daytona startup. Final normal archives must contain the matching image authority and platform daemons. The completed runtime campaign remains bound to its original source; the final UI-only repair needs its own normal-install setup proof. Credit notices are not measured USD receipts. Native steering, native plan mode and detached work remain outside this release. ## Model Used OpenAI Codex, based on GPT-6. The exact serving model ID and context window are not exposed in this task. Used for code changes, review and tool-assisted verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
177 lines
8.4 KiB
TypeScript
177 lines
8.4 KiB
TypeScript
import { spawn, type ChildProcess } from "node:child_process";
|
|
import { expect, it } from "vitest";
|
|
import { createProcessTreeOwner } from "./process-tree-owner.js";
|
|
import { readProcessTable, type ProcessObservation } from "./process-tree.js";
|
|
|
|
function row(pid: number, parentPid: number, processGroupId: number, started = `start-${pid}`, state = "S"): ProcessObservation {
|
|
return { pid, parentPid, processGroupId, started, state, kind: "node" };
|
|
}
|
|
function fixture(initial: ProcessObservation[]) {
|
|
let table = [row(process.pid, 1, 10), ...initial];
|
|
const root = { pid: 100, exitCode: null as number | null, signalCode: null as NodeJS.Signals | null };
|
|
const signals: Array<[number, NodeJS.Signals]> = [];
|
|
const owner = createProcessTreeOwner(root as ChildProcess, {
|
|
readTable: async () => table,
|
|
signalGroup: (pid, signal) => { signals.push([pid, signal]); },
|
|
});
|
|
return { root, owner, signals, replace: (rows: ProcessObservation[]) => { table = [row(process.pid, 1, 10), ...rows]; } };
|
|
}
|
|
|
|
it.skipIf(process.platform === "win32")("revalidates PID/start before signaling and refuses a recycled group", async () => {
|
|
const f = fixture([row(100, process.pid, 100), row(200, 100, 200)]);
|
|
try {
|
|
await f.owner.observe();
|
|
f.replace([row(100, process.pid, 100), row(200, 1, 200, "new-start")]);
|
|
await expect(f.owner.signal("SIGKILL")).rejects.toThrow("identity became uncertain");
|
|
expect(f.signals).toEqual([]);
|
|
} finally { f.owner.stopObserving(); }
|
|
});
|
|
|
|
it.skipIf(process.platform === "win32")("keeps surviving peer identities when a descendant traversal ends at a short-lived child", async () => {
|
|
const f = fixture([row(100, process.pid, 100), row(101, 100, 100), row(200, 100, 200), row(201, 200, 200)]);
|
|
try {
|
|
await f.owner.observe();
|
|
await f.owner.observe();
|
|
f.replace([row(100, process.pid, 100), row(200, 100, 200)]);
|
|
await f.owner.signal("SIGKILL");
|
|
expect(f.signals).toEqual([[200, "SIGKILL"], [100, "SIGKILL"]]);
|
|
} finally { f.owner.stopObserving(); }
|
|
});
|
|
|
|
it.skipIf(process.platform === "win32")("admits replacement group members only through a still-owned ancestor", async () => {
|
|
const f = fixture([row(100, process.pid, 100), row(200, 100, 200)]);
|
|
try {
|
|
await f.owner.observe();
|
|
// The short-lived group leader exited between polls. Its new member is
|
|
// independently owned through the original, still-live controller.
|
|
f.replace([row(100, process.pid, 100), row(300, 100, 200)]);
|
|
await f.owner.signal("SIGKILL");
|
|
expect(f.signals).toEqual([[200, "SIGKILL"], [100, "SIGKILL"]]);
|
|
} finally { f.owner.stopObserving(); }
|
|
});
|
|
|
|
it.skipIf(process.platform === "win32")("keeps surviving peers after the launcher exits without admitting an unobserved group", async () => {
|
|
const f = fixture([row(100, process.pid, 100), row(200, 100, 200), row(201, 200, 200)]);
|
|
try {
|
|
await f.owner.observe();
|
|
f.root.exitCode = 0;
|
|
f.replace([row(200, 1, 200), row(201, 200, 200)]);
|
|
await f.owner.observe();
|
|
f.replace([row(200, 1, 200), row(999, 1, 999)]);
|
|
await f.owner.signal("SIGTERM");
|
|
expect(f.signals).toEqual([[200, "SIGTERM"]]);
|
|
} finally { f.owner.stopObserving(); }
|
|
});
|
|
|
|
it.skipIf(process.platform === "win32")("refuses replacement groups containing any unowned live member", async () => {
|
|
const f = fixture([row(100, process.pid, 100), row(200, 100, 200)]);
|
|
try {
|
|
await f.owner.observe();
|
|
f.replace([row(100, process.pid, 100), row(300, 100, 200), row(400, 1, 200)]);
|
|
await expect(f.owner.signal("SIGKILL")).rejects.toThrow("identity became uncertain");
|
|
expect(f.signals).toEqual([]);
|
|
} finally { f.owner.stopObserving(); }
|
|
});
|
|
|
|
it.skipIf(process.platform === "win32")("does not use a recycled controller as a replacement member's ownership anchor", async () => {
|
|
const f = fixture([row(100, process.pid, 100), row(200, 100, 200)]);
|
|
try {
|
|
await f.owner.observe();
|
|
f.replace([row(100, process.pid, 100, "recycled-controller"), row(300, 100, 200)]);
|
|
await expect(f.owner.signal("SIGKILL")).rejects.toThrow("identity became uncertain");
|
|
expect(f.signals).toEqual([]);
|
|
} finally { f.owner.stopObserving(); }
|
|
});
|
|
|
|
it.skipIf(process.platform === "win32")("retains observed descendants when the root exits and excludes the caller group", async () => {
|
|
const f = fixture([row(100, process.pid, 100), row(200, 100, 200), row(300, 100, 10), row(999, process.pid, 999)]);
|
|
try {
|
|
await f.owner.observe();
|
|
f.root.exitCode = 1;
|
|
f.replace([row(200, 1, 200), row(300, 1, 10), row(999, process.pid, 999)]);
|
|
await f.owner.signal("SIGTERM");
|
|
expect(f.signals).toEqual([[200, "SIGTERM"]]);
|
|
} finally { f.owner.stopObserving(); }
|
|
});
|
|
|
|
it.skipIf(process.platform === "win32")("treats an unreaped zombie as stopped without signaling a replacement", async () => {
|
|
const f = fixture([row(100, process.pid, 100), row(200, 100, 200)]);
|
|
try {
|
|
await f.owner.observe();
|
|
f.root.exitCode = 1;
|
|
f.replace([row(200, 1, 200, "start-200", "Z")]);
|
|
await f.owner.signal("SIGKILL");
|
|
expect(f.owner.liveGroups()).toEqual([]);
|
|
expect(f.signals).toEqual([]);
|
|
} finally { f.owner.stopObserving(); }
|
|
});
|
|
|
|
it.skipIf(process.platform === "win32")("sends launcher grace only to the root while retaining nested groups for escalation", async () => {
|
|
const f = fixture([row(100, process.pid, 100), row(200, 100, 200), row(300, 200, 300)]);
|
|
try {
|
|
await f.owner.observe();
|
|
await f.owner.signal("SIGTERM", f.owner.gracefulRoots());
|
|
expect(f.signals).toEqual([[100, "SIGTERM"]]);
|
|
f.root.exitCode = 1;
|
|
f.replace([row(200, 1, 200), row(300, 200, 300)]);
|
|
await f.owner.observe();
|
|
expect([...f.owner.gracefulRoots()]).toEqual([200]);
|
|
await f.owner.signal("SIGKILL");
|
|
expect(f.signals.slice(1).map(([pid]) => pid).sort()).toEqual([200, 300]);
|
|
} finally { f.owner.stopObserving(); }
|
|
});
|
|
|
|
it.skipIf(process.platform === 'win32')('reselects a vanished owner only when no graceful signal was delivered', async () => {
|
|
let table = [row(process.pid, 1, 10), row(100, process.pid, 100), row(200, 100, 200)];
|
|
const child = { pid: 100, exitCode: null as number | null, signalCode: null };
|
|
const delivered: number[] = [];
|
|
let reads = 0;
|
|
let stopping = false;
|
|
const owner = createProcessTreeOwner(child as ChildProcess, {
|
|
readTable: async () => {
|
|
if (stopping && ++reads === 2) { child.exitCode = 0; table = [row(process.pid, 1, 10), row(200, 1, 200)]; }
|
|
return table;
|
|
},
|
|
signalGroup: (pid, signal) => {
|
|
expect(signal).toBe('SIGTERM');
|
|
if (pid === 100) {
|
|
child.exitCode = 0; table = [row(process.pid, 1, 10), row(200, 1, 200)];
|
|
throw Object.assign(new Error('vanished'), { code: 'ESRCH' });
|
|
}
|
|
delivered.push(pid); table = [row(process.pid, 1, 10)];
|
|
},
|
|
});
|
|
try {
|
|
await owner.observe(); stopping = true;
|
|
const { stopOwnedProcessTree } = await import('./process-tree-owner.js');
|
|
await stopOwnedProcessTree(child as ChildProcess, owner, 150, 100);
|
|
expect(delivered).toEqual([200]);
|
|
} finally { owner.stopObserving(); }
|
|
});
|
|
|
|
|
|
it.skipIf(process.platform === "win32")("rejects an overflowing inspector instead of returning a partial identity table", async () => {
|
|
const inspector = spawn(process.execPath, ["-e", "process.stdout.write('x'.repeat(2 * 1024 * 1024)); setInterval(() => {}, 1000)"], {
|
|
stdio: ["ignore", "pipe", "ignore"],
|
|
});
|
|
const exited = new Promise<void>(resolve => inspector.once("exit", () => resolve()));
|
|
try {
|
|
expect(await readProcessTable(() => inspector)).toBeNull();
|
|
await exited;
|
|
expect(inspector.signalCode).toBe("SIGKILL");
|
|
} finally { if (inspector.exitCode === null && inspector.signalCode === null) inspector.kill("SIGKILL"); }
|
|
});
|
|
|
|
it.skipIf(process.platform === 'win32')('bounds fallback even when the known direct child cannot be killed', async () => {
|
|
const signals: NodeJS.Signals[] = [];
|
|
const child = { pid: 100, exitCode: null, signalCode: null,
|
|
kill: (signal: NodeJS.Signals) => { signals.push(signal); return false; } } as ChildProcess;
|
|
const owner = createProcessTreeOwner(child, { readTable: async () => null,
|
|
signalGroup: () => { throw new Error('must not signal an unobserved group'); } });
|
|
try {
|
|
const { stopOwnedProcessTree } = await import('./process-tree-owner.js');
|
|
await expect(stopOwnedProcessTree(child, owner, 10, 10)).rejects.toThrow('Known direct child remained');
|
|
expect(signals).toEqual(['SIGTERM', 'SIGKILL']);
|
|
} finally { owner.stopObserving(); }
|
|
});
|