mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-01 23:43:16 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Contributors need fast, reliable CI feedback. > - Diff-aware CI selects test files and partitions them into runner jobs. > - Stale cost estimates put several slow suites on the same runner. Broad imports also couple small tests to large modules. > - This PR refreshes test costs, runs independent graph discovery in parallel, and narrows three dependency boundaries. > - Selection safeguards and CODEOWNER-only AWS routing stay in force. ## Linked Issues or Issue Description Refs #18398. This follows the audit of [PR #18427's verification run](https://github.com/paperclipai/paperclip/actions/runs/41169978784). The audit found 403 selected general-server files without timing weights. Three suites measured at 232s, 122s and 116s shared one shard because each received a roughly 2s fallback weight. Local graph discovery across four projects took 43.7s serially and 21.7s with two workers. A reverse-order repeat took 37.7s serially and 22.6s with two workers. Both comparisons produced identical selection results. This is a local measurement, not a claim about production CI speed. ## What Changed - Refresh general-server costs for 1,285 of 1,309 current files and serialized costs for all 163 files from two successful protected-master Cloud readiness runs. Retain prior costs for unmeasured files, including dedicated chat and native-runner suites. - Record passing server file costs, including collection, setup and environment preparation. A weekly hosted workflow validates trusted source runs and opens a timing-only PR. It tests shard coverage, pauses while a refresh PR is open, and never merges automatically. - Discover at most two project graphs concurrently in isolated, heap-limited Node processes. Cache repeated inventory reads within one selection. Worker errors and timeouts retain the full task plan. - Fetch only the merge commit and parents for the selector. A real shallow-clone regression proves the complete diff still includes more than 300 files, renames and deletions. - Share the identical log viewer and run details between both AgentDetail pages. The viewer test imports the shared implementation and runs each of its 13 distinct cases once. - Extract the pure API error class while preserving the API client's public exports. Import delivery work signals through their existing narrow DB export. ## Verification - PASS: `pnpm -r typecheck` and `pnpm build`. - PASS: 284 CI selection, timing, shallow-diff, sharding and routing tests. - PASS: 74 further cache, routing and graph-proof tests. - PASS: 94 targeted UI assertions across the viewer, run invocation, API errors/client and progress helpers. All 76 assertions in the 12 server suites made independently selectable also pass. - PASS: `pnpm check:token-gates`, module-boundary checks, YAML parsing and `git diff --check`. - PASS: [Full PR CI and required `ci / verify` aggregate](https://github.com/paperclipai/paperclip/actions/runs/41206683345), including all 12 general-server shards, all nine serialized shards, workspace groups, chat suites, Runner lanes and build checks. - PASS: [GitHub hosted real-workspace selector and cache/routing qualification](https://github.com/paperclipai/paperclip/actions/runs/41206683205). - PASS: Both Greptile and Paperclip reviews are 5/5 with no actionable findings or inline comments on `7dc65c51b8`. The PR has no merge conflicts. - PASS: The production refresh parser accepted all 107 structured file-cost records from a real successful server CI job, including setup/loading cost. - Local `pnpm test:run` completed all six chat shards successfully. The duplicate monolithic local run was stopped after the complete remote suite passed; it was not completed locally. The focused log-viewer command improved from 18.84s (26 duplicate variant cases) to 8.49s (all 13 distinct behavior cases). The dependency audit confirms 12 server files and the API-error test no longer need conservative always-run retention. Repartitioning the audited PR with the new costs changes the slowest shard from 810s to 591s of summed historical test execution (1,124 of 1,142 files measured). This is a workload simulation, not measured new CI wall time. ## Risks - Two graph processes use more peak memory. Each has a 2 GiB heap limit and a three-minute timeout. Any failure preserves the original task plan. Real workspace qualification runs in GitHub CI. - Historical logs contain test/hook costs only. New reporter records add loading/setup costs after merge. The manifests identify measurement coverage and source runs. These weights change placement, never permission to skip tests. - Runner load adds timing noise. The refresh uses medians and requires at least 90% measurement coverage in each lane. - GitHub may require approval to run checks on a PR created with `GITHUB_TOKEN`. Refreshes remain reviewable and do not merge themselves. - The shared viewer is a mechanical extraction. Both pages retain their existing exports, and the behavior assertions remain covered. AWS runner authorization is unchanged. ## Model Used OpenAI Codex, GPT-6, with repository inspection, reasoning, code execution and GitHub tools. The exact deployment ID and context-window size were not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub references) - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass (focused checks and six chat shards; complete suite passed in CI as detailed above) - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
102 lines
6.1 KiB
JavaScript
102 lines
6.1 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import { spawnSync } from "node:child_process";
|
|
import { mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
import vm from "node:vm";
|
|
import test from "node:test";
|
|
import { planTasks } from "../../.github/scripts/ci-plan.mjs";
|
|
|
|
const workflow = readFileSync(".github/workflows/pr-trusted.yml", "utf8");
|
|
const block = (job) => workflow.split(`\n ${job}:\n`)[1].split(/\n [a-z0-9_]+:\n/)[0];
|
|
const plan = planTasks({ config: JSON.parse(readFileSync("turbo.json", "utf8")),
|
|
lanes: JSON.parse(readFileSync(".github/ci-task-matrix.json", "utf8")), paths: ["ui/src/pages/Inbox.tsx"] });
|
|
const evaluate = (expression, needs, cancelled = false) => vm.runInNewContext(expression, {
|
|
needs, fromJSON: JSON.parse, toJSON: JSON.stringify, always: () => true, cancelled: () => cancelled,
|
|
});
|
|
|
|
test("failed, timed-out, skipped and unavailable selectors leave the original matrix runnable", () => {
|
|
for (const result of ["failure", "cancelled", "skipped", "success"]) {
|
|
const needs = { gate: { result: "success", outputs: { full_ci: "true", plan: JSON.stringify(plan) } },
|
|
test_selection: { result, outputs: { plan: "" } } };
|
|
const job = block("general_tests");
|
|
const condition = job.match(/if: \$\{\{ (.*) \}\}/)[1];
|
|
const matrix = job.match(/matrix: \$\{\{ (.*) \}\}/)[1];
|
|
assert.equal(evaluate(condition, needs), true, result);
|
|
assert.deepEqual(JSON.parse(JSON.stringify(evaluate(matrix, needs))), plan.jobs.general_tests.matrix);
|
|
assert.equal(evaluate(condition, needs, true), false, "cancellation must not start more runners");
|
|
}
|
|
});
|
|
|
|
test("a published selection controls the matrix and the required aggregate", () => {
|
|
const selected = structuredClone(plan);
|
|
selected.testSelection = { version: 1, hash: "test" };
|
|
selected.jobs.general_tests.matrix.include = [selected.jobs.general_tests.matrix.include[0]];
|
|
selected.jobs.general_tests.selected = 1;
|
|
const needs = { gate: { result: "success", outputs: { full_ci: "true", plan: JSON.stringify(plan) } },
|
|
test_selection: { result: "success", outputs: { plan: JSON.stringify(selected) } } };
|
|
const matrix = block("general_tests").match(/matrix: \$\{\{ (.*) \}\}/)[1];
|
|
assert.equal(evaluate(matrix, needs).include.length, 1);
|
|
const aggregate = block("verify");
|
|
const names = aggregate.match(/needs: \[([^\]]+)\]/)[1].split(", ");
|
|
const code = aggregate.split(" node --input-type=module <<'NODE'\n")[1].split("\n NODE")[0]
|
|
.split("\n").map((line) => line.slice(10)).join("\n");
|
|
const results = Object.fromEntries(names.map((name) => [name, { result:
|
|
["gate", "policy", "test_selection"].includes(name) || selected.jobs[name]?.run ? "success" : "skipped" }]));
|
|
const run = () => spawnSync(process.execPath, ["--input-type=module", "-e", code], { encoding: "utf8",
|
|
env: { ...process.env, FULL_CI: "true", CI_PLAN: JSON.stringify(selected), CI_RESULTS: JSON.stringify(results) } });
|
|
assert.equal(run().status, 0);
|
|
for (const job of ["general_tests", "test_selection"]) {
|
|
for (const result of ["failure", "cancelled", "skipped"]) {
|
|
results[job].result = result;
|
|
assert.notEqual(run().status, 0, `${job}: ${result}`);
|
|
}
|
|
results[job].result = "success";
|
|
}
|
|
selected.jobs.general_tests.run = false;
|
|
results.general_tests.result = "skipped";
|
|
assert.equal(run().status, 0, "an explicitly empty selected lane may be skipped");
|
|
assert.ok(aggregate.includes("needs.test_selection.outputs.plan || needs.gate.outputs.plan"));
|
|
});
|
|
|
|
test("publication follows successful upload and manifests are downloaded without ignoring failures", () => {
|
|
const selection = block("test_selection");
|
|
assert.match(selection, /fetch-depth: 2/);
|
|
assert.ok(selection.indexOf("Upload validated selection") < selection.indexOf("Publish the executable plan"));
|
|
assert.match(selection, /timeout-minutes: 5/);
|
|
assert.match(selection, /vars.CI_VITEST_SELECTION == '' \|\| vars.CI_VITEST_SELECTION == 'enabled'/);
|
|
for (const job of ["general_tests", "verify_serialized_server"]) {
|
|
assert.match(block(job), /PAPERCLIP_CI_SELECTION_HASH:.*testSelection.hash/);
|
|
assert.match(block(job), /Download selected test files\n if: matrix.selection\n uses: actions\/download-artifact@/);
|
|
assert.doesNotMatch(block(job), /continue-on-error: true\n.*download-artifact/);
|
|
}
|
|
});
|
|
|
|
test("failed-job retries use the original selector artifact, not the retry attempt", (t) => {
|
|
const directory = mkdtempSync(path.join(tmpdir(), "ci-retry-"));
|
|
t.after(() => rmSync(directory, { recursive: true, force: true }));
|
|
mkdirSync(path.join(directory, ".ci-test-selection"));
|
|
const output = path.join(directory, "output");
|
|
const publication = block("test_selection").split(" - name: Publish the executable plan")[1];
|
|
assert.match(publication, /ARTIFACT_ID: \$\{\{ steps.upload_selection.outputs.artifact-id \}\}/);
|
|
const code = publication.split(" node --input-type=module <<'NODE'\n")[1].split("\n NODE")[0]
|
|
.split("\n").map((line) => line.slice(10)).join("\n");
|
|
const selected = { ...plan, testSelection: { version: 1, hash: "test" } };
|
|
const run = (value, artifactId) => {
|
|
writeFileSync(path.join(directory, ".ci-test-selection/plan.json"), JSON.stringify(value));
|
|
writeFileSync(output, "");
|
|
return spawnSync(process.execPath, ["--input-type=module", "-e", code], {
|
|
cwd: directory, encoding: "utf8", env: { ...process.env, ARTIFACT_ID: artifactId, GITHUB_OUTPUT: output },
|
|
});
|
|
};
|
|
assert.equal(run(selected, "12345").status, 0);
|
|
const savedPlan = readFileSync(output, "utf8").trim().slice("plan=".length);
|
|
for (const job of ["general_tests", "verify_serialized_server"]) {
|
|
const expression = block(job).match(/artifact-ids: \$\{\{ (.*) \}\}/)[1];
|
|
assert.equal(vm.runInNewContext(expression, { fromJSON: JSON.parse, github: { run_attempt: 2 },
|
|
needs: { test_selection: { outputs: { plan: savedPlan } } } }), "12345");
|
|
}
|
|
assert.notEqual(run(selected, "").status, 0, "a selection cannot be published without its uploaded artifact");
|
|
assert.equal(run(plan, "").status, 0, "fallback plans need no selection artifact");
|
|
});
|