Files
PaperClipAI/ui/src/pages/UserProfile.tsx
T
c07e650cd7 feat(ui): single-source design tokens, visual regression suite, and theme retune (#9134)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - Its UI is the operator's daily surface: task lists, boards, budgets,
agent status — all built on shadcn components and Tailwind
> - Visual values (colors, spacing, type sizes, radii) were hardcoded at
~1,600 call sites: the same "small gray label" was 9/10/11px depending
on the file, charts disagreed with chips about status colors, two
toggle-switch implementations coexisted in two greens, and there was no
visual regression coverage
> - This made the UI drift-prone and made any restyle a
hundreds-of-files project, which discourages design iteration
> - This pull request extracts visual values into a single token layer
in `ui/src/index.css`, adds a Storybook visual regression suite backed
by external immutable baseline archives, and then applies a deliberate
retune reviewed change-by-change on screenshot diffs
> - The benefit is that Paperclip's look becomes a config surface:
retheming is a token edit reviewed as a snapshot diff, drift is blocked
by a token gate, and future UI PRs can prove exactly what changed
visually without committing hundreds of PNGs

## Linked Issues or Issue Description

No existing public issue covers this work (searched "design tokens",
"visual regression", "design system" across issues and PRs). Related in
spirit: Refs #8982 (theming a hardcoded panel — a one-off instance of
the same problem class this PR addresses systematically).

**Problem (feature-request form):** UI visual values are hardcoded per
call site with no source of truth and no regression coverage;
consistency depends on reviewer memory, and restyling requires mass file
edits.
**Proposed solution (this PR):** a single token layer + enforcement gate
+ externally stored visual snapshot suite, then an intentional restyle
on top of that foundation.

## What Changed

- **Token extraction (zero visual change, machine-verified during
development):** committed codemods (`scripts/codemod-*.mjs`) moved
~1,600 hardcoded color/type/spacing/radius/shadow/misc values into named
tokens in a non-inline `:root` block of `ui/src/index.css`.
- **Visual regression suite:** `pnpm test:storybook-visual` covers 255
stories × light/dark = 510 Playwright screenshots at `maxDiffPixels: 0`,
plus new primitive-coverage stories and deterministic-render fixes.
- **External visual baselines:** committed PNG snapshots were removed.
`tests/storybook-visual/baseline-manifest.json` pins an immutable
archive URL/hash/size/count, and `scripts/storybook-visual-baseline.mjs`
handles `download`, `verify`, `pack`, and trusted maintainer `upload`
flows.
- **Opt-in visual CI artifacts:** added a `Storybook Visual` workflow
that runs on manual dispatch or PRs labeled `storybook-visual`,
downloads/verifies the baseline, runs Playwright, and uploads Playwright
report/test-result artifacts for review. Normal PR runs do not mutate
baseline objects.
- **Token gate:** `pnpm check:token-gates` — zero hex literals, zero
arbitrary bracket values, zero raw font-sizes in `ui/src/components/**`
and `ui/src/pages/**`, with a documented inline allowlist for legitimate
opt-outs.
- **Theme retune (intentional, snapshot-reviewed):** new base theme
values; radius ladder derived from a single `--radius` knob; micro-type
cluster collapsed to a named ladder (`--text-nano/micro/compact` +
Tailwind `text-xs`/`text-sm`); letter-spacing collapsed to named steps.
- **One status-color vocabulary:** charts, quota/budget bar fills,
RUNNING/live chips, and liveness indicators all use the canonical
`--status-*` hues. Light-mode legibility fixes for red alert surfaces
that used dark-tuned text classes.
- **One switch:** `ToggleSwitch` restyled to the registry capsule form,
second hand-rolled implementation removed, and all call sites unified.
- **Docs:** `DESIGN.md` is the design contract; `doc/design/` holds
audit reports, decision logs, and updated guidance for external baseline
review/update workflows.
- Dead code removed (`agentStatusBadge` duplicate map), byte-identical
contrast constants consolidated, semantic renames
(`--project-seed`/`--project-none`, `--liveness-blue`).

## Verification

- `pnpm check:token-gates` — 3/3 gates CLEAN during the design-system
run
- `pnpm typecheck` && `pnpm --filter @paperclipai/ui build` — green
during the design-system run
- `node --test scripts/__tests__/storybook-visual-baseline.test.mjs` —
pass after external-baseline rework
- `pnpm exec tsc --noEmit --pretty false --module NodeNext
--moduleResolution NodeNext --target ES2022 --types
node,@playwright/test tests/storybook-visual/playwright.config.ts
tests/storybook-visual/storybook-visual.spec.ts` — pass after
external-baseline rework
- `git diff --check origin/pr/9134..HEAD` — pass after external-baseline
rework
- `find tests/storybook-visual -type f -name '*.png' -print | wc -l` —
`0`
- `node scripts/storybook-visual-baseline.mjs verify` — intentionally
fails closed until the first trusted maintainer publishes the baseline
archive and updates `baseline-manifest.json`

## Risks

- **Large but shallow:** the PR still touches many UI files due to
mechanical token extraction and retune work, but committed PNG snapshot
churn has been removed from the branch.
- **Baseline publication required before the visual suite can pass in
clean clones:** the manifest currently has placeholder archive metadata.
A trusted maintainer must publish the first immutable archive, then
update `baseline-manifest.json`.
- **Rendering platform variance:** the external baseline should be
captured in the documented Linux/Chromium environment. Future CI runs
verify against the pinned archive and fail closed on checksum/count
mismatch.
- **Visual CI is opt-in while stabilizing:** add the `storybook-visual`
label or dispatch the workflow manually to produce downloadable
Playwright report/test-result artifacts.
- **Scheduled follow-ups, deliberately out of scope:** Tailwind palette
classes map to semantic tokens in a dedicated pass; card/pill component
consolidation; ESLint ratchet. Tracked in
`doc/design/DECISION-SHEET.md`.

## Model Used

Claude Fable 5 (Anthropic, `claude-fable-5`, Mythos-class tier) with
extended thinking, running in Claude Code with tool use; mechanical
phases delegated to Claude Sonnet subagents. Follow-up external-baseline
rework assisted by OpenAI Codex (`gpt-5` coding agent with repository,
terminal, and GitHub tool use). All bulk rewrites executed via
deterministic, idempotent scripts committed in `scripts/`; intentional
visual changes were human-reviewed on screenshot contact sheets.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run targeted local verification and documented the
intentional baseline-publication failure above
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green *(pending new CI run after this
rework)*
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
*(pending review)*
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code) and
OpenAI Codex

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Dotta <bippadotta@protonmail.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-07-07 16:22:16 -05:00

360 lines
15 KiB
TypeScript

import { useEffect, useMemo } from "react";
import { useQuery } from "@tanstack/react-query";
import { AlertCircle, UserRound } from "lucide-react";
import type { UserProfileDailyPoint, UserProfileWindowStats } from "@paperclipai/shared";
import { Link, useParams } from "@/lib/router";
import { userProfilesApi } from "../api/userProfiles";
import { Avatar, AvatarFallback, AvatarImage } from "../components/ui/avatar";
import { EmptyState } from "../components/EmptyState";
import { PageSkeleton } from "../components/PageSkeleton";
import { IssueStatusBadge } from "../components/StatusBadge";
import { useBreadcrumbs } from "../context/BreadcrumbContext";
import { useCompany } from "../context/CompanyContext";
import { queryKeys } from "../lib/queryKeys";
import {
formatCents,
formatDate,
formatNumber,
formatShortDate,
formatTokens,
issueUrl,
providerDisplayName,
relativeTime,
} from "../lib/utils";
const NO_COMPANY = "__none__";
function initials(name: string | null | undefined) {
const value = name?.trim() || "User";
const parts = value.split(/\s+/).filter(Boolean);
if (parts.length > 1) return `${parts[0]?.[0] ?? ""}${parts[parts.length - 1]?.[0] ?? ""}`.toUpperCase();
return value.slice(0, 2).toUpperCase();
}
function totalTokens(stats: Pick<UserProfileWindowStats, "inputTokens" | "cachedInputTokens" | "outputTokens">) {
return stats.inputTokens + stats.cachedInputTokens + stats.outputTokens;
}
function completionRate(stats: UserProfileWindowStats) {
if (stats.touchedIssues === 0) return "0%";
return `${Math.round((stats.completedIssues / stats.touchedIssues) * 100)}%`;
}
function HeroStat({ label, value, hint }: { label: string; value: string; hint?: string }) {
return (
<div className="min-w-0">
<div className="text-2xl font-semibold tabular-nums sm:text-3xl">{value}</div>
<div className="mt-1 text-(length:--text-micro) font-medium uppercase tracking-wide text-muted-foreground">{label}</div>
{hint ? <div className="mt-0.5 text-xs text-muted-foreground/70">{hint}</div> : null}
</div>
);
}
function WindowColumn({ stats }: { stats: UserProfileWindowStats }) {
const tokens = totalTokens(stats);
return (
<div className="flex min-w-0 flex-col gap-4 border-l border-border pl-5 first:border-l-0 first:pl-0">
<div className="flex items-baseline justify-between gap-3">
<h2 className="text-(length:--text-micro) font-medium uppercase tracking-wide text-muted-foreground">{stats.label}</h2>
<span className="text-(length:--text-micro) text-muted-foreground tabular-nums">{completionRate(stats)} done</span>
</div>
<div className="grid grid-cols-2 gap-x-5 gap-y-3">
<Metric value={formatNumber(stats.touchedIssues)} label="Touched" />
<Metric value={formatNumber(stats.completedIssues)} label="Completed" />
<Metric value={formatNumber(stats.commentCount)} label="Comments" />
<Metric value={formatNumber(stats.activityCount)} label="Actions" />
</div>
<div className="grid grid-cols-2 gap-x-5 gap-y-1.5 pt-3 text-xs tabular-nums text-muted-foreground">
<span>Tokens</span>
<span className="text-right text-foreground">{formatTokens(tokens)}</span>
<span>Spend</span>
<span className="text-right text-foreground">{formatCents(stats.costCents)}</span>
<span>Created</span>
<span className="text-right text-foreground">{formatNumber(stats.createdIssues)}</span>
<span>Open</span>
<span className="text-right text-foreground">{formatNumber(stats.assignedOpenIssues)}</span>
</div>
</div>
);
}
function Metric({ value, label }: { value: string; label: string }) {
return (
<div className="min-w-0">
<div className="truncate text-xl font-semibold tabular-nums">{value}</div>
<div className="mt-0.5 text-(length:--text-micro) text-muted-foreground">{label}</div>
</div>
);
}
function UsageChart({ points }: { points: UserProfileDailyPoint[] }) {
const totals = points.map((point) => totalTokens(point));
const maxTokens = Math.max(1, ...totals);
const maxCompleted = Math.max(1, ...points.map((point) => point.completedIssues));
const totalTokensSum = totals.reduce((sum, value) => sum + value, 0);
return (
<section>
<div className="flex flex-wrap items-baseline justify-between gap-3 border-b border-border pb-3">
<h2 className="text-sm font-semibold">Last 14 days</h2>
<div className="flex items-baseline gap-4 text-xs text-muted-foreground">
<span className="tabular-nums text-foreground">{formatTokens(totalTokensSum)}</span>
<span>tokens total</span>
</div>
</div>
<div className="mt-6 grid grid-cols-(--gtc-57) items-end gap-1.5 sm:gap-2">
{points.map((point) => {
const tokens = totalTokens(point);
const heightPct = tokens === 0 ? 0 : Math.max(2, Math.round((tokens / maxTokens) * 100));
const completedPct = point.completedIssues === 0
? 0
: Math.max(8, Math.round((point.completedIssues / maxCompleted) * 36));
return (
<div key={point.date} className="group flex h-36 flex-col justify-end">
<div
className="w-full bg-foreground/80 transition-opacity group-hover:bg-foreground"
style={{ height: `${heightPct}%`, minHeight: tokens === 0 ? 1 : undefined }}
title={`${formatShortDate(point.date)}: ${formatTokens(tokens)} tokens, ${point.completedIssues} completed`}
/>
{completedPct > 0 ? (
<div
className="mt-1 w-full rounded-full bg-emerald-500/80"
style={{ height: 2, opacity: Math.min(1, 0.35 + completedPct / 100) }}
/>
) : null}
</div>
);
})}
</div>
<div className="mt-2 grid grid-cols-(--gtc-57) gap-1.5 text-(length:--text-nano) tabular-nums text-muted-foreground sm:gap-2">
{points.map((point, index) => (
<div key={point.date} className="text-center">
{index === 0 || index === 6 || index === 13 ? formatShortDate(point.date) : null}
</div>
))}
</div>
<div className="mt-4 flex flex-wrap items-center gap-4 text-(length:--text-nano) uppercase tracking-wide text-muted-foreground">
<span className="inline-flex items-center gap-1.5">
<span className="h-2 w-2 bg-foreground/80" /> tokens / day
</span>
<span className="inline-flex items-center gap-1.5">
<span className="h-(--sz-3px) w-4 rounded-full bg-emerald-500/80" /> completions
</span>
</div>
</section>
);
}
interface UsageRow {
key: string;
label: string;
sublabel: string;
costCents: number;
inputTokens: number;
cachedInputTokens: number;
outputTokens: number;
}
function UsageList({
title,
empty,
rows,
}: {
title: string;
empty: string;
rows: UsageRow[];
}) {
return (
<section>
<div className="flex items-baseline justify-between gap-3 border-b border-border pb-3">
<h2 className="text-sm font-semibold">{title}</h2>
<span className="text-xs text-muted-foreground tabular-nums">{rows.length}</span>
</div>
{rows.length === 0 ? (
<div className="pt-4 text-sm text-muted-foreground">{empty}</div>
) : (
<ul className="divide-y divide-border">
{rows.map((row) => (
<li key={row.key} className="grid gap-2 py-2.5 sm:grid-cols-(--gtc-17) sm:items-center">
<div className="min-w-0">
<div className="truncate text-sm font-medium">{row.label}</div>
<div className="truncate text-xs text-muted-foreground">{row.sublabel}</div>
</div>
<div className="flex items-baseline gap-4 text-xs tabular-nums sm:justify-end">
<span className="text-muted-foreground">{formatTokens(totalTokens(row))}</span>
<span className="font-medium">{formatCents(row.costCents)}</span>
</div>
</li>
))}
</ul>
)}
</section>
);
}
export function UserProfile() {
const { userSlug = "" } = useParams<{ userSlug: string }>();
const { selectedCompanyId } = useCompany();
const { setBreadcrumbs } = useBreadcrumbs();
const companyId = selectedCompanyId ?? NO_COMPANY;
const { data, isLoading, error } = useQuery({
queryKey: queryKeys.userProfile(companyId, userSlug),
queryFn: () => userProfilesApi.get(companyId, userSlug),
enabled: !!selectedCompanyId && !!userSlug,
});
useEffect(() => {
setBreadcrumbs([{ label: "Users" }, { label: data?.user.name ?? userSlug }]);
}, [data?.user.name, setBreadcrumbs, userSlug]);
const allTime = data?.stats.find((entry) => entry.key === "all");
const last7 = data?.stats.find((entry) => entry.key === "last7");
const displayName = data?.user.name?.trim() || data?.user.email?.split("@")[0] || "User";
const agentUsageRows = useMemo<UsageRow[]>(
() =>
(data?.topAgents ?? []).map((row) => ({
key: row.agentId ?? "unknown",
label: row.agentName ?? (row.agentId ? row.agentId.slice(0, 8) : "unknown"),
sublabel: "Task-linked usage",
costCents: row.costCents,
inputTokens: row.inputTokens,
cachedInputTokens: row.cachedInputTokens,
outputTokens: row.outputTokens,
})),
[data?.topAgents],
);
const providerUsageRows = useMemo<UsageRow[]>(
() =>
(data?.topProviders ?? []).map((row) => ({
key: `${row.provider}:${row.biller}:${row.model}`,
label: `${providerDisplayName(row.provider)} / ${row.model}`,
sublabel: `Billed through ${providerDisplayName(row.biller)}`,
costCents: row.costCents,
inputTokens: row.inputTokens,
cachedInputTokens: row.cachedInputTokens,
outputTokens: row.outputTokens,
})),
[data?.topProviders],
);
if (!selectedCompanyId) {
return <EmptyState icon={UserRound} message="Select a company to view user profiles." />;
}
if (isLoading) {
return <PageSkeleton variant="dashboard" />;
}
if (error || !data) {
return <EmptyState icon={AlertCircle} message="User profile not found for this company." />;
}
const allTimeTokens = allTime ? totalTokens(allTime) : 0;
const metaParts = [
data.user.membershipRole ?? "member",
data.user.membershipStatus,
`joined ${formatDate(data.user.joinedAt)}`,
];
return (
<div className="space-y-10 pb-10">
<section className="flex flex-col gap-7 border-b border-border pb-8">
<div className="flex flex-wrap items-center gap-5">
<Avatar className="size-16 border border-border" size="lg">
{data.user.image ? <AvatarImage src={data.user.image} alt={displayName} /> : null}
<AvatarFallback className="text-lg font-semibold">{initials(displayName)}</AvatarFallback>
</Avatar>
<div className="min-w-0 flex-1">
<div className="flex flex-wrap items-baseline gap-x-3 gap-y-1">
<h1 className="truncate text-2xl font-semibold">{displayName}</h1>
<span className="text-sm text-muted-foreground">@{data.user.slug}</span>
</div>
<div className="mt-1.5 flex flex-wrap items-center gap-x-3 gap-y-0.5 text-xs text-muted-foreground">
{data.user.email ? <span className="truncate">{data.user.email}</span> : null}
{data.user.email ? <span aria-hidden>·</span> : null}
<span>{metaParts.join(" · ")}</span>
</div>
</div>
</div>
<div className="grid gap-6 sm:grid-cols-2 lg:grid-cols-4">
<HeroStat label="All-time tokens" value={formatTokens(allTimeTokens)} hint={formatCents(allTime?.costCents ?? 0) + " spent"} />
<HeroStat label="Completed" value={formatNumber(allTime?.completedIssues ?? 0)} hint={allTime ? `${completionRate(allTime)} rate` : undefined} />
<HeroStat label="Open assigned" value={formatNumber(allTime?.assignedOpenIssues ?? 0)} hint={`${formatNumber(allTime?.createdIssues ?? 0)} created`} />
<HeroStat label="7-day actions" value={formatNumber(last7?.activityCount ?? 0)} hint={`${formatNumber(last7?.commentCount ?? 0)} comments`} />
</div>
</section>
<section className="grid gap-8 border-b border-border pb-8 lg:grid-cols-3">
{data.stats.map((entry) => <WindowColumn key={entry.key} stats={entry} />)}
</section>
<UsageChart points={data.daily} />
<div className="grid gap-10 pt-2 xl:grid-cols-2">
<section>
<div className="flex items-baseline justify-between gap-3 border-b border-border pb-3">
<h2 className="text-sm font-semibold">Recent tasks</h2>
<span className="text-xs text-muted-foreground tabular-nums">{data.recentIssues.length}</span>
</div>
{data.recentIssues.length === 0 ? (
<div className="pt-4 text-sm text-muted-foreground">No touched tasks yet.</div>
) : (
<ul className="divide-y divide-border">
{data.recentIssues.map((issue) => (
<li key={issue.id}>
<Link
to={issueUrl(issue)}
className="grid gap-2 py-2.5 transition-colors hover:bg-accent/40 sm:grid-cols-(--gtc-58) sm:items-center"
>
<span className="font-mono text-xs text-muted-foreground">{issue.identifier ?? issue.id.slice(0, 8)}</span>
<span className="truncate text-sm">{issue.title}</span>
<span className="flex items-center gap-3 sm:justify-end">
<IssueStatusBadge status={issue.status} />
<span className="text-xs tabular-nums text-muted-foreground">{relativeTime(issue.updatedAt)}</span>
</span>
</Link>
</li>
))}
</ul>
)}
</section>
<section>
<div className="flex items-baseline justify-between gap-3 border-b border-border pb-3">
<h2 className="text-sm font-semibold">Recent activity</h2>
<span className="text-xs text-muted-foreground tabular-nums">{data.recentActivity.length}</span>
</div>
{data.recentActivity.length === 0 ? (
<div className="pt-4 text-sm text-muted-foreground">No direct user actions recorded yet.</div>
) : (
<ul className="divide-y divide-border">
{data.recentActivity.map((event) => (
<li key={event.id} className="grid gap-2 py-2.5 sm:grid-cols-(--gtc-17) sm:items-center">
<div className="min-w-0">
<div className="truncate text-sm">{event.action.replaceAll("_", " ")}</div>
<div className="truncate text-xs text-muted-foreground">
{event.entityType} · {event.entityId.slice(0, 12)}
</div>
</div>
<span className="text-xs tabular-nums text-muted-foreground sm:justify-self-end">{relativeTime(event.createdAt)}</span>
</li>
))}
</ul>
)}
</section>
</div>
<div className="grid gap-10 xl:grid-cols-2">
<UsageList title="Agent attribution" empty="No issue-linked token usage yet." rows={agentUsageRows} />
<UsageList title="Provider mix" empty="No provider usage attributed yet." rows={providerUsageRows} />
</div>
</div>
);
}