mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - The board UI sidebar has a Recents list of the tasks a person opened
last
> - The Recents list renders from a local snapshot, but its links had no
warm-up. A click waited for the task-detail code and about nine
first-frame reads
> - Task lists (Inbox, Tasks) already warm a task on hover, press and
click, and #20355 added a batched `chat-bootstrap` read that had no UI
consumer
> - The hosted database is CPU-bound, so a fix must add at most one read
per page load and must not compete with the page's own reads
> - This pull request gives Recents the same open-intent prefetch as
task lists, warms the task-detail code, and preloads the top ten recent
tasks with one `chat-bootstrap` request after the page is idle
> - The benefit is that a click on a recent task shows its chat from
cache, without a wait for the API
## Linked Issues or Issue Description
Refs #20355 (server read this PR consumes). Builds on #20389, #20398 and
#20419.
**Is your feature request related to a problem?**
Opening a task from the sidebar's Recents was slower than opening it
from a task list. The Recents links had no prefetch. The task page
waited for its first-frame reads after the click.
**Describe the solution you'd like**
Recents links use the task lists' open-intent prefetch. When the page is
idle, one batched request loads the first frame of the most recent tasks
into the task page's caches.
**Describe alternatives you've considered**
Per-task prefetch of every recent task. That makes up to ten times nine
requests per page load, which the hosted database cannot afford.
**Additional context**
I searched open PRs and remote branches for "chat-bootstrap" and
"instant task opens". The only related work is the server-side branches
that merged as #20355. There is no other in-flight UI consumer of
`chat-bootstrap`.
## What Changed
- `ui/src/hooks/useIssueNavigationPrefetch.ts`: the open-intent handlers
from `IssueLinkQuicklook` move into one hook (light warm on pass-over;
`history: true` on a resting hover or focus, a mouse or pen press, and a
click). `IssueLinkQuicklook` now uses the hook. Its behavior does not
change.
- `ui/src/components/RecentTaskNavItem.tsx`: one Recents link wrapper
that applies the hook. The classic list (`SidebarRecentTasks`), the
Coordinator task rows and `DesignSidebar` use it. `SidebarNavItem`
accepts the handlers through a new optional `linkHandlers` prop.
- Classic Recents links now open `/issues/<identifier>` (Coordinator
already did). The old UUID link remounted the task page after a redirect
to the identifier route.
- `ui/src/hooks/useRecentTaskOpenWarmup.ts`: when Recents shows a task,
it fires the task-detail code warm-up (`useWarmTaskDetailCode`). After
two frames, a visible tab, no fetching queries and an idle callback, it
sends one `issues/chat-bootstrap?ids=` request for the ten most recent
tasks. It skips tasks whose first frame is cached and fresh. It sends no
request for an empty list or a hidden tab. It sends at most one request
per account per page load. Unmount or an account change aborts the
request.
- `ui/src/lib/issueChatBootstrapCache.ts`: `seedIssueChatBootstrap`
writes each field under the keys the task page reads, for the requested
ref, the id and the identifier: core issue, recent comments, comment
input facts (one batch, through the new `seedIssueIdBatch`), recent
activity, the recent run window (through the new shared
`buildRecentIssueRunWindow`), interactions, attachments, live runs and
active run. An explicit `null` active run is stored. A missing field is
not stored. It does not replace data that is as new or newer, data with
a read in flight, or data with a pending invalidation. Keys whose page
merges observed history (comments, activity, runs, input facts) are
filled only when empty. Items for another company are ignored.
- The seed fills the `?view=core` key, not the full detail key.
`seedIssueDetailCache` is not used: the core payload cannot stand in for
the detail read's related data, and seeding it there would suppress that
read.
- `issuesApi.chatBootstrap` client method.
- `tests/perf/collections/recent-task-open.spec.ts` and its README
section.
## Verification
Local disposable instance (`local_trusted`, production UI build,
embedded PostgreSQL, collection fixture plus 12 comments on each of 8
recent tasks, streamlined UI with the Coordinator sidebar). Journey:
open Projects with 8 Recents, wait for network idle plus 3 s, click a
recent task, measure until its latest comment is on screen. Each run
uses a fresh browser context (empty HTTP cache and storage apart from
Recents). Median of 5 runs, same server and fixture for both arms:
| Arm | Click to first chat frame | Idle page API requests |
| --- | --- | --- |
| `master` (b6f4008f9b), loopback | 227 ms (first run: 249 ms) | 24
(range 21–25) |
| This PR, loopback | 134 ms | 22 (range 21–27) |
| `master`, +150 ms on each API response | 455 ms | 19 |
| This PR, +150 ms on each API response | 135 ms | 20 (+1
`chat-bootstrap`) |
With added latency, the first frame no longer depends on API latency.
- `PAPERCLIP_COLLECTION_PERF_BASE_URL=http://127.0.0.1:<port> pnpm exec
playwright test --config tests/perf/collections/playwright.config.ts
recent-task-open.spec.ts recent-task-summaries.spec.ts`: 5 passed. On
`master` the two assertion cases fail (0 `chat-bootstrap` requests; 10
first-frame reads after the click).
- Reads that still follow a click on a preloaded task: full detail (`GET
/issues/:id`), `work-products`, `documents`, `feedback-votes`,
`tree-control/state`, `tree-holds`, `runner-goal`, `browsers`, and the
`read` mark. The `chat-bootstrap` payload does not cover them. None
gates the chat's first frame (the frame shows at 135 ms while every API
response waits 150 ms).
- Unit tests: `RecentTaskNavItem.test.tsx` (intent levels, href),
`useRecentTaskOpenWarmup.test.tsx` (one request for the top ten, code
warm-up, wait for page reads, hidden tab, fresh entries skipped, once
per account, user isolation, abort on unmount),
`issueChatBootstrapCache.test.ts` (each key in the endpoint shape,
`null` versus missing fields, company isolation, no downgrade of newer,
in-flight or invalidated data, merge keys filled only when empty).
- `ui` Vitest: `src/components src/hooks src/lib src/api` 694 files
passed; `src/pages src/App src/context` 188 files passed. `pnpm
check:token-gates`: clean. `pnpm verify` exits 2 because a `tests/` file
is a global CI input; required CI supplies the broad coverage.
## Risks
- Low to medium. One extra read per page load when Recents has tasks
without a fresh cached first frame. The read starts only after the
page's own queries settle, and the server reads at most two tasks at a
time.
- A live event that arrives while the preload is in flight, for a task
with no cached keys, can leave seeded data up to 30 s old until the next
live event or the next open after the stale time. Inbox hover prefetch
has the same window.
- Classic Recents links now use the identifier route instead of the UUID
route. The task page already redirected UUID links to this route.
- `tests/perf/collections` is a manual suite. CI does not run it.
## Model Used
- Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, in Claude Code with
tool use (shell, file edits, browser automation through Playwright).
Standard context window.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [ ] I will address all Greptile and reviewer comments before
requesting merge
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
354 lines
14 KiB
TypeScript
354 lines
14 KiB
TypeScript
import { useState, type FormEvent } from "react";
|
|
import { useQueryClient } from "@tanstack/react-query";
|
|
import { Archive, MoreHorizontal, Pencil, RefreshCw } from "lucide-react";
|
|
import { agentsApi } from "@/api/agents";
|
|
import { issuesApi } from "@/api/issues";
|
|
import { queryKeys } from "@/lib/queryKeys";
|
|
import { useRecentTasks } from "@/hooks/useRecentTasks";
|
|
import { useRecentTaskOpenWarmup } from "@/hooks/useRecentTaskOpenWarmup";
|
|
import { useAccountIdentity } from "@/api/companies-query";
|
|
import { useSidebar } from "@/context/SidebarContext";
|
|
import { useOptionalToastActions } from "@/context/ToastContext";
|
|
import {
|
|
updateRecentTaskSnapshots,
|
|
type RecentTaskEntry,
|
|
} from "@/lib/recent-tasks";
|
|
import { Button } from "@/components/ui/button";
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
DialogDescription,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
} from "@/components/ui/dialog";
|
|
import {
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
DropdownMenuTrigger,
|
|
} from "@/components/ui/dropdown-menu";
|
|
import { Input } from "@/components/ui/input";
|
|
import { StatusIcon } from "./StatusIcon";
|
|
import { SidebarSection } from "./SidebarSection";
|
|
import { RecentTaskNavItem } from "./RecentTaskNavItem";
|
|
import { taskStatusIconProps } from "@/lib/task-status-presentation";
|
|
|
|
const RECENT_TASK_MENU_ITEM_CLASS =
|
|
"h-(--profile-popover-row-height) gap-(--profile-popover-row-gap) rounded-lg px-2.5 py-0 text-(length:--text-compact) font-medium leading-(--profile-popover-label-line-height) focus:bg-accent/50 focus:text-foreground";
|
|
const RESTART_WAKE_RETRY_STORAGE_SUFFIX = ":restart-wake-retry";
|
|
|
|
function restartWakeRetryStorageKey(companyId: string, userId: string | null) {
|
|
// Action retry state must survive changes to the recent-task snapshot format.
|
|
return `paperclip.recentTasks:${companyId}:${userId ?? "__local_board__"}${RESTART_WAKE_RETRY_STORAGE_SUFFIX}`;
|
|
}
|
|
|
|
function readRestartWakeRetryIssueIds(storageKey: string | null) {
|
|
if (!storageKey) return new Set<string>();
|
|
try {
|
|
const parsed = JSON.parse(window.localStorage.getItem(storageKey) ?? "[]") as unknown;
|
|
return new Set(Array.isArray(parsed) ? parsed.filter((value): value is string => typeof value === "string") : []);
|
|
} catch {
|
|
return new Set<string>();
|
|
}
|
|
}
|
|
|
|
function setRestartWakeRetryPending(storageKey: string | null, issueId: string, pending: boolean) {
|
|
if (!storageKey) return;
|
|
const issueIds = readRestartWakeRetryIssueIds(storageKey);
|
|
if (pending) issueIds.add(issueId);
|
|
else issueIds.delete(issueId);
|
|
try {
|
|
if (issueIds.size > 0) window.localStorage.setItem(storageKey, JSON.stringify([...issueIds]));
|
|
else window.localStorage.removeItem(storageKey);
|
|
} catch {
|
|
// Recent Tasks remains usable when browser storage is unavailable.
|
|
}
|
|
}
|
|
|
|
function errorMessage(error: unknown, fallback: string) {
|
|
return error instanceof Error && error.message.trim() ? error.message : fallback;
|
|
}
|
|
|
|
export function SidebarRecentTasks({
|
|
companyId,
|
|
liveIssueIds,
|
|
}: {
|
|
companyId: string | null | undefined;
|
|
liveIssueIds: ReadonlySet<string>;
|
|
}) {
|
|
const { collapsed, peeking } = useSidebar();
|
|
const rail = collapsed && !peeking;
|
|
const { userId, settled } = useAccountIdentity();
|
|
|
|
if (!companyId || !settled) return null;
|
|
|
|
return (
|
|
<RecentTasksList
|
|
key={`${companyId}:${userId ?? "__local_board__"}`}
|
|
companyId={companyId}
|
|
userId={userId}
|
|
liveIssueIds={liveIssueIds}
|
|
rail={rail}
|
|
/>
|
|
);
|
|
}
|
|
|
|
function RecentTasksList({
|
|
companyId,
|
|
userId,
|
|
liveIssueIds,
|
|
rail,
|
|
}: {
|
|
companyId: string;
|
|
userId: string | null;
|
|
liveIssueIds: ReadonlySet<string>;
|
|
rail: boolean;
|
|
}) {
|
|
const { entries, storageKey } = useRecentTasks({ companyId, userId });
|
|
const queryClient = useQueryClient();
|
|
const toastActions = useOptionalToastActions();
|
|
const [renameEntry, setRenameEntry] = useState<RecentTaskEntry | null>(null);
|
|
const [renameValue, setRenameValue] = useState("");
|
|
const [pendingAction, setPendingAction] = useState<"rename" | "archive" | "pause" | null>(null);
|
|
const restartRetryStorageKey = restartWakeRetryStorageKey(companyId, userId);
|
|
useRecentTaskOpenWarmup({ companyId, userId, tasks: entries });
|
|
|
|
if (entries.length === 0) return null;
|
|
|
|
const refreshIssueQueries = async (issueId: string) => {
|
|
await Promise.all([
|
|
queryClient.invalidateQueries({ queryKey: queryKeys.issues.detail(issueId) }),
|
|
queryClient.invalidateQueries({ queryKey: queryKeys.issues.list(companyId) }),
|
|
queryClient.invalidateQueries({ queryKey: queryKeys.issues.activity(issueId) }),
|
|
]);
|
|
};
|
|
|
|
const beginRename = (entry: RecentTaskEntry) => {
|
|
setRenameEntry(entry);
|
|
setRenameValue(entry.title);
|
|
};
|
|
|
|
const submitRename = async (event: FormEvent<HTMLFormElement>) => {
|
|
event.preventDefault();
|
|
const nextTitle = renameValue.trim();
|
|
if (!renameEntry || !nextTitle || nextTitle === renameEntry.title) {
|
|
setRenameEntry(null);
|
|
return;
|
|
}
|
|
|
|
setPendingAction("rename");
|
|
try {
|
|
const updated = await issuesApi.update(renameEntry.id, { title: nextTitle });
|
|
queryClient.setQueryData(queryKeys.issues.detail(renameEntry.id), updated);
|
|
if (storageKey) updateRecentTaskSnapshots(storageKey, companyId, [updated]);
|
|
await refreshIssueQueries(renameEntry.id);
|
|
setRenameEntry(null);
|
|
toastActions?.pushToast({ title: "Task renamed", tone: "success" });
|
|
} catch (error) {
|
|
toastActions?.pushToast({
|
|
title: "Task rename failed",
|
|
body: errorMessage(error, "Unable to rename this task."),
|
|
tone: "error",
|
|
});
|
|
} finally {
|
|
setPendingAction(null);
|
|
}
|
|
};
|
|
|
|
const archiveTask = async (entry: RecentTaskEntry) => {
|
|
setPendingAction("archive");
|
|
try {
|
|
await issuesApi.archiveFromInbox(entry.id);
|
|
await refreshIssueQueries(entry.id);
|
|
await queryClient.invalidateQueries({
|
|
queryKey: queryKeys.sidebarBadges(companyId),
|
|
});
|
|
toastActions?.pushToast({ title: "Task archived from inbox", tone: "success" });
|
|
} catch (error) {
|
|
toastActions?.pushToast({
|
|
title: "Task archive failed",
|
|
body: errorMessage(error, "Unable to archive this task from the inbox."),
|
|
tone: "error",
|
|
});
|
|
} finally {
|
|
setPendingAction(null);
|
|
}
|
|
};
|
|
|
|
const toggleTaskPause = async (entry: RecentTaskEntry) => {
|
|
setPendingAction("pause");
|
|
try {
|
|
const state = await issuesApi.getTreeControlState(entry.id);
|
|
if (state.activePauseHold?.isRoot) {
|
|
const restartIssue = await issuesApi.get(entry.id);
|
|
setRestartWakeRetryPending(restartRetryStorageKey, entry.id, true);
|
|
await issuesApi.releaseTreeHold(entry.id, state.activePauseHold.holdId, {
|
|
reason: "Restarted from Recent Tasks.",
|
|
});
|
|
if (restartIssue.assigneeAgentId) {
|
|
const wakeResult = await agentsApi.wakeup(
|
|
restartIssue.assigneeAgentId,
|
|
{
|
|
source: "assignment",
|
|
triggerDetail: "manual",
|
|
reason: "recent_task_restart",
|
|
payload: { issueId: restartIssue.id },
|
|
},
|
|
restartIssue.companyId,
|
|
);
|
|
if (!("id" in wakeResult)) {
|
|
throw new Error(wakeResult.message ?? "The assignee wake was skipped.");
|
|
}
|
|
}
|
|
setRestartWakeRetryPending(restartRetryStorageKey, entry.id, false);
|
|
toastActions?.pushToast({ title: "Task restarted", tone: "success" });
|
|
} else if (state.activePauseHold) {
|
|
throw new Error("This task is paused by a parent task. Restart it from the pause root.");
|
|
} else if (readRestartWakeRetryIssueIds(restartRetryStorageKey).has(entry.id)) {
|
|
const restartIssue = await issuesApi.get(entry.id);
|
|
if (restartIssue.assigneeAgentId) {
|
|
const wakeResult = await agentsApi.wakeup(
|
|
restartIssue.assigneeAgentId,
|
|
{
|
|
source: "assignment",
|
|
triggerDetail: "manual",
|
|
reason: "recent_task_restart_retry",
|
|
payload: { issueId: restartIssue.id },
|
|
},
|
|
restartIssue.companyId,
|
|
);
|
|
if (!("id" in wakeResult)) {
|
|
throw new Error(wakeResult.message ?? "The assignee wake was skipped.");
|
|
}
|
|
}
|
|
setRestartWakeRetryPending(restartRetryStorageKey, entry.id, false);
|
|
toastActions?.pushToast({ title: "Task restarted", tone: "success" });
|
|
} else {
|
|
await issuesApi.createTreeHold(entry.id, {
|
|
mode: "pause",
|
|
reason: "Paused from Recent Tasks.",
|
|
releasePolicy: { strategy: "manual" },
|
|
});
|
|
toastActions?.pushToast({ title: "Task paused", tone: "success" });
|
|
}
|
|
await queryClient.invalidateQueries({
|
|
queryKey: ["issues", "tree-control-state", entry.id],
|
|
});
|
|
await queryClient.invalidateQueries({ queryKey: queryKeys.issues.summaries(companyId) });
|
|
} catch (error) {
|
|
toastActions?.pushToast({
|
|
title: "Task pause update failed",
|
|
body: errorMessage(error, "Unable to pause or restart this task."),
|
|
tone: "error",
|
|
});
|
|
} finally {
|
|
setPendingAction(null);
|
|
}
|
|
};
|
|
|
|
return (
|
|
<>
|
|
<SidebarSection label="Recent Tasks">
|
|
{entries.map((entry) => (
|
|
<div key={entry.id} className="sidebar-action-row group/recent-task relative">
|
|
<RecentTaskNavItem
|
|
task={entry}
|
|
label={entry.title}
|
|
iconNode={entry.displayStatus === "monitoring" && !liveIssueIds.has(entry.id) ? <StatusIcon {...taskStatusIconProps(entry)} /> : undefined}
|
|
trailing={entry.status === "in_review" && entry.externalConversationState === "waiting"
|
|
? <span className="text-xs text-muted-foreground">Idle</span> : undefined}
|
|
trailingLabel={entry.status === "in_review" && entry.externalConversationState === "waiting" ? "Idle" : undefined}
|
|
className={rail ? undefined : "sidebar-action-link pointer-coarse:pr-8"}
|
|
liveCount={liveIssueIds.has(entry.id) ? 1 : undefined}
|
|
/>
|
|
{!rail ? (
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<Button
|
|
type="button"
|
|
variant="ghost"
|
|
size="icon-xs"
|
|
aria-label={`More actions for ${entry.title}`}
|
|
className="sidebar-action-menu absolute right-2 top-(--pct-50) z-10 -translate-y-(--pct-50) text-muted-foreground pointer-events-none opacity-0 transition-opacity hover:bg-sidebar-accent dark:hover:bg-sidebar-accent hover:text-foreground focus-visible:pointer-events-auto focus-visible:opacity-100 pointer-coarse:pointer-events-auto pointer-coarse:opacity-100 pointer-coarse:before:hidden group-hover/recent-task:pointer-events-auto group-hover/recent-task:opacity-100 group-focus-within/recent-task:pointer-events-auto group-focus-within/recent-task:opacity-100 data-[state=open]:pointer-events-auto data-[state=open]:bg-sidebar-accent data-[state=open]:text-foreground data-[state=open]:opacity-100"
|
|
>
|
|
<MoreHorizontal aria-hidden="true" />
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent
|
|
side="right"
|
|
align="start"
|
|
className="w-(--profile-popover-width) rounded-xl p-1.5 shadow-(--shadow-profile-popover)"
|
|
>
|
|
<DropdownMenuItem
|
|
className={RECENT_TASK_MENU_ITEM_CLASS}
|
|
onSelect={() => beginRename(entry)}
|
|
>
|
|
<Pencil aria-hidden="true" />
|
|
Rename
|
|
</DropdownMenuItem>
|
|
<DropdownMenuItem
|
|
className={RECENT_TASK_MENU_ITEM_CLASS}
|
|
disabled={pendingAction !== null}
|
|
onSelect={() => void archiveTask(entry)}
|
|
>
|
|
<Archive aria-hidden="true" />
|
|
Archive
|
|
</DropdownMenuItem>
|
|
<DropdownMenuItem
|
|
className={RECENT_TASK_MENU_ITEM_CLASS}
|
|
disabled={pendingAction !== null}
|
|
onSelect={() => void toggleTaskPause(entry)}
|
|
>
|
|
<RefreshCw aria-hidden="true" />
|
|
Pause/Restart
|
|
</DropdownMenuItem>
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
) : null}
|
|
</div>
|
|
))}
|
|
</SidebarSection>
|
|
|
|
<Dialog
|
|
open={renameEntry !== null}
|
|
onOpenChange={(open) => {
|
|
if (!open && pendingAction !== "rename") setRenameEntry(null);
|
|
}}
|
|
>
|
|
<DialogContent className="sm:max-w-md">
|
|
<form className="grid gap-4" onSubmit={(event) => void submitRename(event)}>
|
|
<DialogHeader>
|
|
<DialogTitle>Rename task</DialogTitle>
|
|
<DialogDescription>Choose a short, clear name for this task.</DialogDescription>
|
|
</DialogHeader>
|
|
<Input
|
|
autoFocus
|
|
aria-label="Task name"
|
|
value={renameValue}
|
|
disabled={pendingAction === "rename"}
|
|
onChange={(event) => setRenameValue(event.target.value)}
|
|
/>
|
|
<DialogFooter>
|
|
<Button
|
|
type="button"
|
|
variant="outline"
|
|
disabled={pendingAction === "rename"}
|
|
onClick={() => setRenameEntry(null)}
|
|
>
|
|
Cancel
|
|
</Button>
|
|
<Button
|
|
type="submit"
|
|
disabled={pendingAction === "rename" || !renameValue.trim()}
|
|
>
|
|
{pendingAction === "rename" ? "Saving..." : "Save"}
|
|
</Button>
|
|
</DialogFooter>
|
|
</form>
|
|
</DialogContent>
|
|
</Dialog>
|
|
</>
|
|
);
|
|
}
|