mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-30 21:49:18 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Apps and AI Connections store credentials and govern access to agent runtimes. > - Users need a supported saved-token connection and config values that survive save and reopen. > - The release must preserve saved-token access and task lifecycle guarantees. > - This pull request will connect Copilot through the normal Apps and AI Connections path. > - The benefit is a reviewable part of the Copilot production release. ## Linked Issues or Issue Description Refs #15701 and #15703. Supersedes setup work in #15562. Base: #15703. Next: #15706. ## What Changed - Require configuration update authority before Copilot credential-bearing model discovery; default to the saved environment and preserve explicit selection for editors. - Keep Copilot discovery passive during reconnect reconciliation; refresh on explicit opening, account/environment changes and reconnect. - Add GitHub AI token connections with encrypted storage, ownership, grants and audit logging. - Keep repository access separate from Copilot runtime authentication. - Probe the selected environment without sending a model prompt and preserve authenticated model selection through save/reopen. - Keep fresh execution admission consistent with normal Copilot setup; persist task model choices without changing provider or permission policy. - Refresh authenticated models after reconnecting the same saved Copilot account, including recovery from a previous authentication error. - Apply the additive provider-default constraint migration through the normal generated migration workflow. ## Verification Runtime #15701 is merged at `d855e550ad8d2a267312983f26457aabf5393c3a`. History #15703 is merged at `df80616d98119cbf5abd40549794d9980a5fabf6`. Remaining source [`42bcbd61299655f7e37aabe6bb5f19bba770ad1d`](https://github.com/paperclipai/paperclip/commit/42bcbd61299655f7e37aabe6bb5f19bba770ad1d) contains the four-file authorization repair. The remaining PR trees preserve six nonoverlapping files from the newer public mainline managed-settings fix and the CI-owned lockfile. No unrelated provider is enabled. The security finding is repaired: existing-agent discovery requires `agent_config:update` before connection selection or token resolution. The saved environment is the default. Authorized editors can select a prospective environment. Both denied board-viewer and agent-reader regressions fail on the original source. All49 route tests and server typecheck pass with the fix. Denied requests perform no connection selection, credential resolution or probe. Current-head security scans pass on both remaining PRs; the repaired thread is resolved. Copilot CLI1.0.88 and profile47 retain digest `sha256:55044aa235e88b3fe36ec8a556ee1e3382590870aab907e4462ef7d64af49cea`. The [qualification record](https://github.com/paperclipai/paperclip/blob/42bcbd61299655f7e37aabe6bb5f19bba770ad1d/doc/plans/2026-10-20-copilot-qualification-v47.json) reports20/20 Product cells,154 assertions and7/7 protocol cases,46 assertions against frozen normal installed source `c2616370800f5f6df45246b0890ba35a7cd2faab`. The exact qualification model is `gpt-5.6-luna`. Every passing Product case confirms cleanup. Original failures remain recorded; automatic behavior retries are disabled. The route-only authorization repair changes no bound runtime/profile bytes and does not relabel the frozen campaign. The ordinary installed remote journey passed saved-token selection, model discovery, normal UI save/reopen, metadata-only Test, completed task, accepted receipt and exact19-byte browser download. An open model catalog caused no additional discovery requests during117seconds. Actual installed runtime smokes passed on macOS ARM64, macOS x64 under Rosetta and native Linux x64 on Daytona. Raw token browser entry was not exercised; encrypted connection creation used the normal API. The first Daytona file attempt timed out during delayed semantic dispatch; its precise stalled layer remains unresolved. Independent ordinary remote delivery and the other19 Product cells passed before one instrumented recheck passed8/8 with unchanged source,prompt,assertions and deadlines. No causal latency repair is claimed. Before the authorization repair, all four final PR heads passed required verify/E2E and fresh Greptile5/5 reviews with zero unresolved threads. Current-head CI/review is running for the two repaired heads. Local focused checks retain129 connection,59 runner,72 shared-eval and88 recovery/workspace passes, plus migration safety and token gates. The additive Copilot migration is361; released master history is preserved. [Cloud normal-package run39414239704](https://github.com/paperclipai/paperclip/actions/runs/39414239704) builds the pre-security source4f3f. All four native producers and Linux package assembly pass; the final clean installed consumers are finishing. All18 retained archives match their hashes;37,863 regular files contain zero selected credentials. That package does not contain the later route repair. The actual final published package must include it and pass the local/Daytona live canaries. The frozen Daytona image remains published and independently verified. No separate full-image scan is claimed. Docker builds run in the cloud. **Remaining:** current-head CI/review, setup and qualification merges, final publication, and ordinary local/Daytona canaries against the actual shipped package. The user explicitly authorizes the maintainer review override; CI remains a merge gate. No production deployment is claimed. Provider USD remains unknown and GitHub-attributed. ## Risks Bad credentials, missing entitlement, runtime installation and unavailable models must remain distinct failures. A connection must not adopt ambient credentials. The constraint migration changes accepted provider values, with no credential-storage migration. Current-master NewAgent fixture extraction is retained. Copilot cases use that shared support and test both passive discovery and explicit reconnect under the same setup lifecycle. The onboarding retry regression shares the component suite’s saved-connection, authenticated-model, draft, agent-list, hire and render lifecycle fixtures. Keeping it beside the existing onboarding failures makes adoption versus duplicate hire observable under the same lifecycle; this is the concrete cohesion reason for the existing large test file. ## Model Used OpenAI Codex, based on GPT-6. The exact serving model ID and context window are not exposed in this task. Used for code changes, review and tool-assisted verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
673 lines
26 KiB
TypeScript
673 lines
26 KiB
TypeScript
import express from "express";
|
|
import request from "supertest";
|
|
import { afterEach, beforeAll, beforeEach, describe, expect, it } from "vitest";
|
|
import { vi } from "vitest";
|
|
import type { ServerAdapterModule } from "../adapters/index.js";
|
|
|
|
const mockAdapterPluginStore = vi.hoisted(() => ({
|
|
listAdapterPlugins: vi.fn(),
|
|
addAdapterPlugin: vi.fn(),
|
|
removeAdapterPlugin: vi.fn(),
|
|
getAdapterPluginByType: vi.fn(),
|
|
getAdapterPluginsDir: vi.fn(),
|
|
getDisabledAdapterTypes: vi.fn(),
|
|
setAdapterDisabled: vi.fn(),
|
|
}));
|
|
|
|
const mockPluginLoader = vi.hoisted(() => ({
|
|
buildExternalAdapters: vi.fn(),
|
|
loadExternalAdapterPackage: vi.fn(),
|
|
getUiParserSource: vi.fn(),
|
|
getOrExtractUiParserSource: vi.fn(),
|
|
reloadExternalAdapter: vi.fn(),
|
|
}));
|
|
|
|
const overridingConfigSchemaAdapter: ServerAdapterModule = {
|
|
type: "claude_local",
|
|
execute: async () => ({ exitCode: 0, signal: null, timedOut: false }),
|
|
testEnvironment: async () => ({
|
|
adapterType: "claude_local",
|
|
status: "pass",
|
|
checks: [],
|
|
testedAt: new Date(0).toISOString(),
|
|
}),
|
|
getConfigSchema: async () => ({
|
|
version: 1,
|
|
fields: [
|
|
{
|
|
key: "mode",
|
|
type: "text",
|
|
label: "Mode",
|
|
},
|
|
],
|
|
}),
|
|
};
|
|
|
|
let registerServerAdapter: typeof import("../adapters/registry.js").registerServerAdapter;
|
|
let unregisterServerAdapter: typeof import("../adapters/registry.js").unregisterServerAdapter;
|
|
let findServerAdapter: typeof import("../adapters/registry.js").findServerAdapter;
|
|
let findActiveServerAdapter: typeof import("../adapters/registry.js").findActiveServerAdapter;
|
|
let setOverridePaused: typeof import("../adapters/registry.js").setOverridePaused;
|
|
let adapterRoutes: typeof import("../routes/adapters.js").adapterRoutes;
|
|
let errorHandler: typeof import("../middleware/index.js").errorHandler;
|
|
|
|
function registerModuleMocks() {
|
|
vi.doMock("node:child_process", async () => vi.importActual("node:child_process"));
|
|
vi.doMock("../adapters/plugin-loader.js", () => mockPluginLoader);
|
|
vi.doMock("../services/adapter-plugin-store.js", () => mockAdapterPluginStore);
|
|
}
|
|
|
|
function resetAdapterMocks() {
|
|
vi.resetAllMocks();
|
|
mockAdapterPluginStore.listAdapterPlugins.mockReturnValue([]);
|
|
mockAdapterPluginStore.addAdapterPlugin.mockResolvedValue(undefined);
|
|
mockAdapterPluginStore.removeAdapterPlugin.mockReturnValue(false);
|
|
mockAdapterPluginStore.getAdapterPluginByType.mockReturnValue(undefined);
|
|
mockAdapterPluginStore.getAdapterPluginsDir.mockReturnValue("/tmp/paperclip-adapter-routes-test");
|
|
mockAdapterPluginStore.getDisabledAdapterTypes.mockReturnValue([]);
|
|
mockAdapterPluginStore.setAdapterDisabled.mockReturnValue(false);
|
|
mockPluginLoader.buildExternalAdapters.mockResolvedValue([]);
|
|
mockPluginLoader.loadExternalAdapterPackage.mockResolvedValue(null);
|
|
mockPluginLoader.getUiParserSource.mockResolvedValue(null);
|
|
mockPluginLoader.getOrExtractUiParserSource.mockResolvedValue(null);
|
|
mockPluginLoader.reloadExternalAdapter.mockResolvedValue(null);
|
|
}
|
|
|
|
function createApp(
|
|
actorOverrides: Partial<Express.Request["actor"]> = {},
|
|
options: Parameters<typeof adapterRoutes>[0] = {},
|
|
) {
|
|
const app = express();
|
|
app.use(express.json());
|
|
app.use((req, _res, next) => {
|
|
(req as any).actor = {
|
|
type: "board",
|
|
userId: "local-board",
|
|
companyIds: [],
|
|
source: "local_implicit",
|
|
isInstanceAdmin: false,
|
|
...actorOverrides,
|
|
};
|
|
next();
|
|
});
|
|
app.use("/api", adapterRoutes(options));
|
|
app.use(errorHandler);
|
|
return app;
|
|
}
|
|
|
|
describe("adapter routes", () => {
|
|
// Keep the route and middleware on one module graph so HttpError retains
|
|
// its identity. Reset mock state and adapter overrides between tests.
|
|
beforeAll(async () => {
|
|
registerModuleMocks();
|
|
resetAdapterMocks();
|
|
const registry = await import("../adapters/registry.js");
|
|
const routes = await import("../routes/adapters.js");
|
|
const middleware = await import("../middleware/index.js");
|
|
registerServerAdapter = registry.registerServerAdapter;
|
|
unregisterServerAdapter = registry.unregisterServerAdapter;
|
|
findServerAdapter = registry.findServerAdapter;
|
|
findActiveServerAdapter = registry.findActiveServerAdapter;
|
|
setOverridePaused = registry.setOverridePaused;
|
|
adapterRoutes = routes.adapterRoutes;
|
|
errorHandler = middleware.errorHandler;
|
|
});
|
|
|
|
beforeEach(() => {
|
|
resetAdapterMocks();
|
|
setOverridePaused("claude_local", false);
|
|
unregisterServerAdapter("hermes_local");
|
|
unregisterServerAdapter("claude_local");
|
|
registerServerAdapter(overridingConfigSchemaAdapter);
|
|
});
|
|
|
|
afterEach(() => {
|
|
setOverridePaused("claude_local", false);
|
|
unregisterServerAdapter("hermes_local");
|
|
unregisterServerAdapter("claude_local");
|
|
});
|
|
|
|
it("GET /api/adapters includes capabilities object for each adapter", async () => {
|
|
const app = createApp();
|
|
|
|
const res = await request(app).get("/api/adapters");
|
|
expect(res.status).toBe(200);
|
|
const adapters = Array.isArray(res.body) ? res.body : JSON.parse(res.text);
|
|
expect(Array.isArray(adapters)).toBe(true);
|
|
expect(adapters.length).toBeGreaterThan(0);
|
|
|
|
// Every adapter should have a capabilities object
|
|
for (const adapter of adapters) {
|
|
expect(adapter.capabilities).toBeDefined();
|
|
expect(typeof adapter.capabilities.supportsInstructionsBundle).toBe("boolean");
|
|
expect(typeof adapter.capabilities.supportsSkills).toBe("boolean");
|
|
expect(typeof adapter.capabilities.supportsLocalAgentJwt).toBe("boolean");
|
|
expect(typeof adapter.capabilities.requiresMaterializedRuntimeSkills).toBe("boolean");
|
|
expect(typeof adapter.capabilities.supportsAcp).toBe("boolean");
|
|
}
|
|
});
|
|
|
|
it("keeps the shared runner implementation available for Codex without the experimental flag", async () => {
|
|
const disabledResponse = await request(createApp()).get("/api/adapters");
|
|
expect(disabledResponse.status).toBe(200);
|
|
expect(disabledResponse.body.find((adapter: any) => adapter.type === "paperclip_runner"))
|
|
.toMatchObject({ disabled: false });
|
|
|
|
const enabledResponse = await request(createApp({}, {
|
|
getNativeRunnerEnabled: async () => true,
|
|
})).get("/api/adapters");
|
|
expect(enabledResponse.status).toBe(200);
|
|
expect(enabledResponse.body.find((adapter: any) => adapter.type === "paperclip_runner"))
|
|
.toMatchObject({
|
|
disabled: false,
|
|
capabilities: {
|
|
supportsInstructionsBundle: true,
|
|
},
|
|
});
|
|
});
|
|
|
|
it.each([
|
|
[{ driver: "ssh", platform: "linux", architecture: "x64" }, "paperclip"],
|
|
[{ driver: "ssh", platform: "darwin", architecture: "arm64" }, "paperclip"],
|
|
[{ driver: "ssh", platform: "darwin", architecture: "x64" }, "paperclip"],
|
|
[{ driver: "ssh", platform: "linux", architecture: "arm64" }, "paperclip"],
|
|
[{ driver: "ssh", platform: "linux", architecture: "arm" }, "legacy"],
|
|
[{ driver: "local", platform: "win32", architecture: "x64" }, "legacy"],
|
|
[{ driver: "sandbox", platform: "linux", architecture: "arm64", libc: "glibc", glibcVersion: "2.39" }, "paperclip"],
|
|
])("projects the selected environment once for the whole adapter inventory (%s)", async (target, defaultRunner) => {
|
|
const resolveRunnerTarget = vi.fn(async () => target);
|
|
const response = await request(createApp({}, { resolveRunnerTarget })).get("/api/adapters?companyId=company-1&environmentId=selected");
|
|
expect(response.status).toBe(200);
|
|
expect(resolveRunnerTarget).toHaveBeenCalledExactlyOnceWith("company-1", "selected");
|
|
expect(response.body.find((adapter: any) => adapter.type === "codex_local")).toMatchObject({ defaultRunner });
|
|
expect(response.body.find((adapter: any) => adapter.type === "claude_local")).toMatchObject({ defaultRunner: "legacy" });
|
|
});
|
|
|
|
it("uses the company's effective default environment when discovery omits an override", async () => {
|
|
const resolveRunnerTarget = vi.fn(async () => ({ driver: "sandbox" }));
|
|
const response = await request(createApp({}, { resolveRunnerTarget })).get("/api/adapters?companyId=company-1");
|
|
expect(response.status).toBe(200);
|
|
expect(resolveRunnerTarget).toHaveBeenCalledExactlyOnceWith("company-1", undefined);
|
|
expect(response.body.find((adapter: any) => adapter.type === "codex_local")).toMatchObject({ defaultRunner: "legacy" });
|
|
});
|
|
|
|
it("keeps unscoped inventory independent of company target discovery", async () => {
|
|
const resolveRunnerTarget = vi.fn();
|
|
const response = await request(createApp({}, { resolveRunnerTarget })).get("/api/adapters");
|
|
expect(response.status).toBe(200);
|
|
expect(resolveRunnerTarget).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("rejects a foreign company before selecting or probing an environment", async () => {
|
|
const resolveRunnerTarget = vi.fn();
|
|
const response = await request(createApp({ source: "session", companyIds: ["allowed"] }, { resolveRunnerTarget })).get("/api/adapters?companyId=foreign&environmentId=selected");
|
|
expect(response.status).toBe(403);
|
|
expect(resolveRunnerTarget).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.each(["environmentId=selected", "companyId=", "companyId=one&companyId=two", "companyId=one&environmentId="])("rejects malformed discovery scope before resolution (%s)", async query => {
|
|
const resolveRunnerTarget = vi.fn();
|
|
const response = await request(createApp({}, { resolveRunnerTarget })).get(`/api/adapters?${query}`);
|
|
expect(response.status).toBe(400);
|
|
expect(resolveRunnerTarget).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("keeps the shared implementation available for Dot independently, while honoring adapter-admin disabling", async () => {
|
|
const options = { getNativeRunnerEnabled: async () => false, getOpenAiDotEnabled: async () => true };
|
|
const enabled = await request(createApp({}, options)).get("/api/adapters");
|
|
expect(enabled.body.find((adapter: any) => adapter.type === "paperclip_runner")).toMatchObject({ disabled: false });
|
|
mockAdapterPluginStore.getDisabledAdapterTypes.mockReturnValue(["paperclip_runner"]);
|
|
const disabled = await request(createApp({}, options)).get("/api/adapters");
|
|
expect(disabled.body.find((adapter: any) => adapter.type === "paperclip_runner")).toMatchObject({ disabled: true });
|
|
});
|
|
|
|
it("GET /api/adapters returns correct capabilities for built-in adapters", async () => {
|
|
const app = createApp();
|
|
|
|
const res = await request(app).get("/api/adapters");
|
|
expect(res.status).toBe(200);
|
|
|
|
// codex_local has instructions bundle + skills + jwt, no materialized skills
|
|
// (claude_local is overridden by beforeEach, so check codex_local instead)
|
|
const codexLocal = res.body.find((a: any) => a.type === "codex_local");
|
|
expect(codexLocal).toBeDefined();
|
|
expect(codexLocal.capabilities).toMatchObject({
|
|
supportsInstructionsBundle: true,
|
|
supportsSkills: true,
|
|
supportsLocalAgentJwt: true,
|
|
requiresMaterializedRuntimeSkills: false,
|
|
supportsAcp: true,
|
|
});
|
|
expect(codexLocal.acp).toMatchObject({
|
|
agentId: "codex",
|
|
skillsMode: "ephemeral",
|
|
prerequisites: {
|
|
nodeRange: ">=24.11.0",
|
|
packages: ["@agentclientprotocol/codex-acp"],
|
|
},
|
|
});
|
|
|
|
// process adapter should have no local capabilities
|
|
const processAdapter = res.body.find((a: any) => a.type === "process");
|
|
expect(processAdapter).toBeDefined();
|
|
expect(processAdapter.capabilities).toMatchObject({
|
|
supportsInstructionsBundle: false,
|
|
supportsSkills: false,
|
|
supportsLocalAgentJwt: true,
|
|
requiresMaterializedRuntimeSkills: false,
|
|
supportsAcp: false,
|
|
});
|
|
|
|
// cursor adapter should require materialized runtime skills
|
|
const cursorAdapter = res.body.find((a: any) => a.type === "cursor");
|
|
expect(cursorAdapter).toBeDefined();
|
|
expect(cursorAdapter.capabilities.requiresMaterializedRuntimeSkills).toBe(true);
|
|
expect(cursorAdapter.capabilities.supportsInstructionsBundle).toBe(true);
|
|
expect(cursorAdapter.capabilities.supportsAcp).toBe(false);
|
|
|
|
const geminiAdapter = res.body.find((a: any) => a.type === "gemini_local");
|
|
expect(geminiAdapter).toBeDefined();
|
|
expect(geminiAdapter.capabilities).toMatchObject({
|
|
supportsInstructionsBundle: true,
|
|
supportsSkills: true,
|
|
supportsLocalAgentJwt: true,
|
|
requiresMaterializedRuntimeSkills: true,
|
|
supportsAcp: true,
|
|
});
|
|
expect(geminiAdapter.acp).toMatchObject({
|
|
agentId: "gemini",
|
|
skillsMode: "ephemeral",
|
|
prerequisites: {
|
|
nodeRange: ">=24.11.0",
|
|
packages: ["@google/gemini-cli"],
|
|
},
|
|
});
|
|
|
|
const grokAdapter = res.body.find((a: any) => a.type === "grok_local");
|
|
expect(grokAdapter).toBeDefined();
|
|
expect(grokAdapter.capabilities).toMatchObject({
|
|
supportsInstructionsBundle: true,
|
|
supportsSkills: true,
|
|
supportsLocalAgentJwt: true,
|
|
requiresMaterializedRuntimeSkills: true,
|
|
supportsAcp: false,
|
|
});
|
|
|
|
const kimiAdapter = res.body.find((a: any) => a.type === "kimi_local");
|
|
expect(kimiAdapter).toBeDefined();
|
|
expect(kimiAdapter.capabilities).toMatchObject({
|
|
supportsInstructionsBundle: true,
|
|
supportsSkills: true,
|
|
supportsLocalAgentJwt: true,
|
|
requiresMaterializedRuntimeSkills: true,
|
|
supportsAcp: true,
|
|
});
|
|
expect(kimiAdapter.acp).toMatchObject({
|
|
agentId: "kimi",
|
|
skillsMode: "ephemeral",
|
|
prerequisites: {
|
|
nodeRange: ">=20.0.0",
|
|
packages: ["@moonshot-ai/kimi-code"],
|
|
},
|
|
});
|
|
|
|
const hermesLocal = res.body.find((a: any) => a.type === "hermes_local");
|
|
expect(hermesLocal).toBeDefined();
|
|
expect(hermesLocal.source).toBe("builtin");
|
|
expect(hermesLocal.capabilities).toMatchObject({
|
|
supportsInstructionsBundle: true,
|
|
supportsSkills: true,
|
|
supportsLocalAgentJwt: true,
|
|
requiresMaterializedRuntimeSkills: false,
|
|
supportsAcp: false,
|
|
});
|
|
|
|
const hermesGateway = res.body.find((a: any) => a.type === "hermes_gateway");
|
|
expect(hermesGateway).toBeDefined();
|
|
expect(hermesGateway.source).toBe("builtin");
|
|
expect(hermesGateway.capabilities).toMatchObject({
|
|
supportsInstructionsBundle: false,
|
|
supportsSkills: false,
|
|
supportsLocalAgentJwt: false,
|
|
requiresMaterializedRuntimeSkills: false,
|
|
supportsAcp: false,
|
|
});
|
|
});
|
|
|
|
it("GET /api/adapters derives supportsSkills from listSkills/syncSkills presence", async () => {
|
|
const app = createApp();
|
|
|
|
const res = await request(app).get("/api/adapters");
|
|
expect(res.status).toBe(200);
|
|
|
|
// http adapter has no listSkills/syncSkills
|
|
const httpAdapter = res.body.find((a: any) => a.type === "http");
|
|
expect(httpAdapter).toBeDefined();
|
|
expect(httpAdapter.capabilities.supportsSkills).toBe(false);
|
|
|
|
// codex_local has listSkills/syncSkills
|
|
const codexLocal = res.body.find((a: any) => a.type === "codex_local");
|
|
expect(codexLocal).toBeDefined();
|
|
expect(codexLocal.capabilities.supportsSkills).toBe(true);
|
|
|
|
// acpx_local remains registered only as a tombstone for legacy rows.
|
|
const acpxLocal = res.body.find((a: any) => a.type === "acpx_local");
|
|
expect(acpxLocal).toBeDefined();
|
|
expect(acpxLocal.capabilities.supportsSkills).toBe(false);
|
|
});
|
|
|
|
it("uses the active adapter when resolving config schema for a paused builtin override", async () => {
|
|
const app = createApp();
|
|
|
|
const active = await request(app).get("/api/adapters/claude_local/config-schema");
|
|
expect(active.status, JSON.stringify(active.body)).toBe(200);
|
|
expect(active.body).toMatchObject({
|
|
fields: [{ key: "mode" }],
|
|
});
|
|
|
|
const paused = await request(app)
|
|
.patch("/api/adapters/claude_local/override")
|
|
.send({ paused: true });
|
|
expect(paused.status, JSON.stringify(paused.body)).toBe(200);
|
|
|
|
const builtin = await request(app).get("/api/adapters/claude_local/config-schema");
|
|
expect([200, 404], JSON.stringify(builtin.body)).toContain(builtin.status);
|
|
expect(builtin.body).not.toMatchObject({
|
|
fields: [{ key: "mode" }],
|
|
});
|
|
});
|
|
|
|
it("serves an empty tombstone config schema for retired acpx_local", async () => {
|
|
const app = createApp();
|
|
|
|
const res = await request(app).get("/api/adapters/acpx_local/config-schema");
|
|
|
|
expect(res.status, JSON.stringify(res.body)).toBe(200);
|
|
expect(res.body.fields).toEqual([]);
|
|
});
|
|
|
|
it("serves provider-scoped Paperclip Runner configuration fields", async () => {
|
|
const app = createApp();
|
|
|
|
const res = await request(app).get("/api/adapters/paperclip_runner/config-schema");
|
|
|
|
expect(res.status, JSON.stringify(res.body)).toBe(200);
|
|
expect(res.body.fields).toEqual(expect.arrayContaining([
|
|
expect.objectContaining({
|
|
key: "provider",
|
|
options: expect.arrayContaining([
|
|
expect.objectContaining({ value: "codex" }),
|
|
expect.objectContaining({ value: "opencode" }),
|
|
expect.objectContaining({ value: "claude_managed" }),
|
|
expect.objectContaining({ value: "aws_agentcore" }),
|
|
expect.objectContaining({ value: "acpx" }),
|
|
]),
|
|
}),
|
|
expect.objectContaining({
|
|
key: "codexPermissionMode",
|
|
default: "never",
|
|
meta: { visibleWhen: { key: "provider", value: "codex" } },
|
|
}),
|
|
expect.objectContaining({
|
|
key: "opencodePermissionMode",
|
|
default: "allow",
|
|
meta: { visibleWhen: { key: "provider", value: "opencode" } },
|
|
}),
|
|
expect.objectContaining({
|
|
key: "acpxPermissionMode",
|
|
default: "approve-all",
|
|
meta: { visibleWhen: { key: "provider", value: "acpx" } },
|
|
}),
|
|
expect.objectContaining({
|
|
key: "model",
|
|
meta: { visibleWhen: { key: "provider", value: "opencode" } },
|
|
}),
|
|
expect.objectContaining({
|
|
key: "idleTimeoutMs",
|
|
meta: { visibleWhen: { key: "lifecycleMode", value: "warm" } },
|
|
}),
|
|
]));
|
|
const acpxAgent = res.body.fields.find((field: { key?: string }) => field.key === "acpxAgent");
|
|
expect(acpxAgent).toMatchObject({
|
|
type: "select",
|
|
default: "claude",
|
|
meta: { visibleWhen: { key: "provider", value: "acpx" } },
|
|
options: [
|
|
{ value: "claude", label: "Claude" },
|
|
{ value: "grok", label: "Grok Build" },
|
|
{ value: "copilot", label: "GitHub Copilot" },
|
|
],
|
|
});
|
|
expect(JSON.stringify(res.body)).not.toContain("Codex via ACPX");
|
|
});
|
|
|
|
it("serves the built-in claude_local ACP engine config schema", async () => {
|
|
const app = createApp();
|
|
|
|
const paused = await request(app)
|
|
.patch("/api/adapters/claude_local/override")
|
|
.send({ paused: true });
|
|
expect(paused.status, JSON.stringify(paused.body)).toBe(200);
|
|
|
|
const res = await request(app).get("/api/adapters/claude_local/config-schema");
|
|
|
|
expect(res.status, JSON.stringify(res.body)).toBe(200);
|
|
expect(res.body.fields).toEqual(
|
|
expect.arrayContaining([
|
|
expect.objectContaining({
|
|
key: "engine",
|
|
default: "auto",
|
|
options: expect.arrayContaining([
|
|
expect.objectContaining({ value: "auto" }),
|
|
expect.objectContaining({ value: "cli" }),
|
|
expect.objectContaining({ value: "acp" }),
|
|
]),
|
|
}),
|
|
expect.objectContaining({
|
|
key: "agentCommand",
|
|
meta: { visibleWhen: { key: "engine", values: ["acp"] } },
|
|
}),
|
|
expect.objectContaining({
|
|
key: "warmHandleIdleMs",
|
|
default: 0,
|
|
}),
|
|
]),
|
|
);
|
|
});
|
|
|
|
it("serves the built-in codex_local ACP engine config schema", async () => {
|
|
const app = createApp();
|
|
|
|
const res = await request(app).get("/api/adapters/codex_local/config-schema");
|
|
|
|
expect(res.status, JSON.stringify(res.body)).toBe(200);
|
|
expect(res.body.fields).toEqual(
|
|
expect.arrayContaining([
|
|
expect.objectContaining({
|
|
key: "engine",
|
|
default: "auto",
|
|
options: expect.arrayContaining([
|
|
expect.objectContaining({ value: "auto" }),
|
|
expect.objectContaining({ value: "cli" }),
|
|
expect.objectContaining({ value: "acp" }),
|
|
]),
|
|
}),
|
|
expect.objectContaining({
|
|
key: "agentCommand",
|
|
meta: { visibleWhen: { key: "engine", values: ["acp"] } },
|
|
}),
|
|
expect.objectContaining({
|
|
key: "warmHandleIdleMs",
|
|
default: 0,
|
|
}),
|
|
]),
|
|
);
|
|
});
|
|
|
|
it("serves the built-in gemini_local ACP engine config schema", async () => {
|
|
const app = createApp();
|
|
|
|
const res = await request(app).get("/api/adapters/gemini_local/config-schema");
|
|
|
|
expect(res.status, JSON.stringify(res.body)).toBe(200);
|
|
expect(res.body.fields).toEqual(
|
|
expect.arrayContaining([
|
|
expect.objectContaining({
|
|
key: "engine",
|
|
default: "auto",
|
|
options: expect.arrayContaining([
|
|
expect.objectContaining({ value: "auto" }),
|
|
expect.objectContaining({ value: "cli" }),
|
|
expect.objectContaining({ value: "acp" }),
|
|
]),
|
|
}),
|
|
expect.objectContaining({
|
|
key: "agentCommand",
|
|
meta: { visibleWhen: { key: "engine", values: ["acp"] } },
|
|
}),
|
|
expect.objectContaining({
|
|
key: "warmHandleIdleMs",
|
|
default: 0,
|
|
}),
|
|
]),
|
|
);
|
|
});
|
|
|
|
it("serves built-in Hermes config schemas", async () => {
|
|
const app = createApp();
|
|
|
|
const local = await request(app).get("/api/adapters/hermes_local/config-schema");
|
|
expect(local.status, JSON.stringify(local.body)).toBe(200);
|
|
expect(local.body.fields).toEqual(
|
|
expect.arrayContaining([
|
|
expect.objectContaining({ key: "provider" }),
|
|
expect.objectContaining({ key: "timeoutSec" }),
|
|
]),
|
|
);
|
|
|
|
const gateway = await request(app).get("/api/adapters/hermes_gateway/config-schema");
|
|
expect(gateway.status, JSON.stringify(gateway.body)).toBe(200);
|
|
expect(gateway.body.fields).toEqual(
|
|
expect.arrayContaining([
|
|
expect.objectContaining({ key: "apiBaseUrl", required: true }),
|
|
expect.objectContaining({ key: "apiKey", required: true }),
|
|
]),
|
|
);
|
|
});
|
|
|
|
it("GET /api/adapters lists acpx_local only as a model-less tombstone", async () => {
|
|
const app = createApp();
|
|
|
|
const res = await request(app).get("/api/adapters");
|
|
|
|
expect(res.status, JSON.stringify(res.body)).toBe(200);
|
|
const acpxLocal = res.body.find((a: any) => a.type === "acpx_local");
|
|
expect(acpxLocal).toBeDefined();
|
|
expect(acpxLocal.modelsCount).toBe(0);
|
|
});
|
|
|
|
it("rejects signed-in users without org access", async () => {
|
|
const app = createApp({
|
|
userId: "outsider-1",
|
|
source: "session",
|
|
companyIds: [],
|
|
memberships: [],
|
|
isInstanceAdmin: false,
|
|
});
|
|
|
|
const res = await request(app).get("/api/adapters/claude_local/config-schema");
|
|
|
|
expect(res.status, JSON.stringify(res.body)).toBe(403);
|
|
});
|
|
|
|
it("POST /api/adapters/install preserves module-provided sessionManagement (hot-install parity with init-time IIFE)", async () => {
|
|
const HOT_INSTALL_TYPE = "hot_install_session_test";
|
|
const declaredSessionManagement = {
|
|
supportsSessionResume: true,
|
|
nativeContextManagement: "confirmed" as const,
|
|
defaultSessionCompaction: {
|
|
enabled: true,
|
|
maxSessionRuns: 10,
|
|
maxRawInputTokens: 100_000,
|
|
maxSessionAgeHours: 24,
|
|
},
|
|
};
|
|
const externalModule: ServerAdapterModule = {
|
|
type: HOT_INSTALL_TYPE,
|
|
execute: async () => ({ exitCode: 0, signal: null, timedOut: false }),
|
|
testEnvironment: async () => ({
|
|
adapterType: HOT_INSTALL_TYPE,
|
|
status: "pass",
|
|
checks: [],
|
|
testedAt: new Date(0).toISOString(),
|
|
}),
|
|
sessionManagement: declaredSessionManagement,
|
|
};
|
|
mockPluginLoader.loadExternalAdapterPackage.mockResolvedValue(externalModule);
|
|
|
|
const app = createApp({ isInstanceAdmin: true });
|
|
const res = await request(app)
|
|
.post("/api/adapters/install")
|
|
.send({ packageName: "/tmp/fake-hot-install-adapter", isLocalPath: true });
|
|
|
|
expect(res.status, JSON.stringify(res.body)).toBe(201);
|
|
expect(res.body.type).toBe(HOT_INSTALL_TYPE);
|
|
|
|
const registered = findServerAdapter(HOT_INSTALL_TYPE);
|
|
expect(registered).not.toBeNull();
|
|
expect(registered?.sessionManagement).toEqual(declaredSessionManagement);
|
|
|
|
unregisterServerAdapter(HOT_INSTALL_TYPE);
|
|
});
|
|
|
|
it("POST /api/adapters/install allows an external adapter to override a builtin type", async () => {
|
|
const builtin = findServerAdapter("codex_local");
|
|
expect(builtin).not.toBeNull();
|
|
|
|
const externalModule: ServerAdapterModule = {
|
|
type: "codex_local",
|
|
execute: async () => ({ exitCode: 0, signal: null, timedOut: false }),
|
|
testEnvironment: async () => ({
|
|
adapterType: "codex_local",
|
|
status: "pass",
|
|
checks: [],
|
|
testedAt: new Date(0).toISOString(),
|
|
}),
|
|
models: [{ id: "plugin-codex", label: "Plugin Codex" }],
|
|
};
|
|
mockPluginLoader.loadExternalAdapterPackage.mockResolvedValue(externalModule);
|
|
|
|
const app = createApp({ isInstanceAdmin: true });
|
|
const res = await request(app)
|
|
.post("/api/adapters/install")
|
|
.send({ packageName: "/tmp/fake-codex-override", isLocalPath: true });
|
|
|
|
expect(res.status, JSON.stringify(res.body)).toBe(201);
|
|
expect(res.body.type).toBe("codex_local");
|
|
const registeredOverride = findServerAdapter("codex_local");
|
|
expect(registeredOverride).toMatchObject({
|
|
type: "codex_local",
|
|
models: [{ id: "plugin-codex", label: "Plugin Codex" }],
|
|
});
|
|
|
|
setOverridePaused("codex_local", true);
|
|
expect(findActiveServerAdapter("codex_local")).toBe(builtin);
|
|
|
|
mockAdapterPluginStore.getAdapterPluginByType.mockReturnValue({
|
|
type: "codex_local",
|
|
packageName: undefined,
|
|
localPath: "/tmp/fake-codex-override",
|
|
installedAt: new Date(0).toISOString(),
|
|
});
|
|
mockAdapterPluginStore.removeAdapterPlugin.mockReturnValue(true);
|
|
|
|
const removed = await request(app).delete("/api/adapters/codex_local");
|
|
expect(removed.status, JSON.stringify(removed.body)).toBe(200);
|
|
expect(removed.body).toMatchObject({ type: "codex_local", removed: true });
|
|
|
|
unregisterServerAdapter("codex_local");
|
|
expect(findServerAdapter("codex_local")).toBe(builtin);
|
|
setOverridePaused("codex_local", false);
|
|
});
|
|
});
|