mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 16:27:18 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Repo-only project workspaces are materialized by a server-side `git clone`, and isolated `git_worktree` runs refresh their base ref with server-side `git fetch` > - Both operations run outside the agent process with no credentials, so private GitHub repositories can never be cloned or refreshed — agent-scoped credential env bindings do not reach them > - The company secret store already has a well-known GitHub token convention (`GITHUB_TOKEN` / `GH_TOKEN` / `PAPERCLIP_GITHUB_TOKEN`, consumed by the external-object provider for API reads), but nothing server-side consults it for git > - This pull request resolves that token per run and authenticates the managed clone and every base-ref refresh with it through an ephemeral credential helper > - The benefit is that isolated workspaces work on private repositories with one company secret, while public repositories and self-hosted ambient git configuration keep working unchanged ## Linked Issues or Issue Description **Subsystem affected** Server workspace materialization (`server/src/services/heartbeat.ts`) and execution-workspace realization (`server/src/services/workspace-runtime.ts`). **Problem or motivation** A project workspace configured with only a private GitHub `repoUrl` cannot be used for isolated `git_worktree` runs: the managed `git clone` runs with a sanitized, credential-less environment, and plain git cannot consume a bare token env variable without a credential helper. There is no way to give the server a git credential — storing a `GH_TOKEN` company secret has no effect on server-side git, and a credential-less private clone hangs on a terminal prompt until the ten-minute clone timeout. Base-ref refreshes (`git fetch`) during worktree realization have the same gap. **Proposed solution** A `git-credentials` module resolves a token per run — company secret by well-known name (`GITHUB_TOKEN`, `GH_TOKEN`, `PAPERCLIP_GITHUB_TOKEN`), then `GITHUB_TOKEN`/`GH_TOKEN` in the server process environment for self-hosted deployments, then none — and builds a git invocation that authenticates via an inline credential helper. The token travels in an env variable; it never appears in argv, URLs, or on disk. Only `https://github.com` remotes are authenticated; everything else keeps ambient behavior. The provider is a single factory seam so a future brokered credential source can replace it without touching call sites. **Alternatives considered** - A GitHub OAuth "connect your account" flow: heavier product surface, needs app registration and callback custody; out of scope for a server credential and better served by a dedicated connector later. The provider seam keeps that path open. - `gh auth setup-git`: writes helper configuration to disk and requires a global token env; rejected in favor of per-invocation config with no persistent state. - Embedding the token in the clone URL: leaks into argv, error messages, and `.git/config`; rejected. ## What Changed - New `server/src/services/git-credentials.ts`: `createGitRemoteAuthProvider` (memoized per run, one secret resolution and one audit event), `buildGitAuthInvocation` (helper-reset + inline helper, `x-access-token` username, `GIT_TERMINAL_PROMPT=0`), `isGitHubHttpsRemoteUrl` host gating (rejects ssh/GHES/http/other hosts/userinfo URLs), `describeGitAuthFailure`, and the canonical `scrubGitCredentialText`. Secret resolutions pass a `system` consumer access context so they are recorded as secret access events. - `ensureManagedProjectWorkspace` (now exported) accepts an optional auth provider; the clone env spreads the token after `sanitizeRuntimeServiceBaseEnv` (which strips `PAPERCLIP_*`), always sets `GIT_TERMINAL_PROMPT=0`, distinguishes "credential rejected" from "no credential configured — add a GITHUB_TOKEN or GH_TOKEN company secret" in the error, and removes the partially created directory on clone failure so a timeout-killed clone cannot be adopted as a broken checkout by the next run. - `refreshRemoteTrackingBaseRef` (now exported) captures the remote URL it already looked up, asks the provider for an invocation, and attributes failed authenticated fetches to the credential in a scrubbed warning. The optional provider threads through `detectDefaultBranch`, `resolveAuthoritativeBaseRef`, `inspectExecutionWorkspaceBaseDrift`, `realizeExecutionWorkspace`, and `ensurePersistedExecutionWorkspaceAvailable`; heartbeat builds one provider per run for both the anchor-resolution clone path and workspace realization/restore. - `github-external-object-provider.ts` imports the shared secret-name list; `isGitHubDotCom` is exported from `github-fetch.ts`. - Docs: "Private repositories and repo-only project workspaces" section in the execution-workspaces guide, cross-linked from the secrets deploy doc. ## Verification - `cd server && npx vitest run src/__tests__/git-credentials.test.ts` — resolution chain order and precedence, env fallback, memoization, audited access context, host-gating matrix, invocation shape (token absent from argv), scrubber, failure descriptions, and a real-git `git credential fill` round trip that proves the helper executes and answers with the env-carried token (no network). - `cd server && npx vitest run src/__tests__/heartbeat-managed-clone-credentials.test.ts` — clones behave byte-identically with no provider or a null-returning provider (local repos, no network), authenticated-failure errors name the credential, non-auth failures do not mention credentials, partial clone directories are removed, pre-existing non-git directories keep the "Using it as-is" path, and the sanitizer spread order keeps the token env alive. - `cd server && npx vitest run src/__tests__/workspace-runtime.test.ts` — new `refreshRemoteTrackingBaseRef` cases: provider offered the remote URL and null keeps behavior identical; failed authenticated fetch warning names the credential; unauthenticated failure warning stays credential-free. - `pnpm --filter @paperclipai/server typecheck` is clean. - Manual (optional, networked): store a `GH_TOKEN` company secret, configure a repo-only project workspace pointing at a private GitHub repository, run an isolated-workspace issue — the managed clone succeeds and the worktree run proceeds. ## Risks - Every new parameter is optional; with no provider the git invocations are byte-identical to before. Public repos and ambient credential helpers keep working whenever no token resolves. - Precedence change when a token exists: a stored company secret now wins over ambient helpers for `https://github.com` remotes (the helper list is reset for that invocation). The rejected-credential error names the secret so an operator can fix or remove it. - `GIT_TERMINAL_PROMPT=0` on the managed clone is the one always-on change: a credential-less private clone now fails fast with a clear message instead of hanging until the ten-minute timeout (it could only ever "succeed" interactively on a TTY dev server). - The token is scoped to the git process env for one invocation; it is never written to agent env, run context, disk, or logs, and error text is scrubbed of URL userinfo. - No migrations, no image changes (git ships in the image). ## Model Used Claude Fable 5 (`claude-fable-5`, extended thinking, agentic tool use via Claude Code CLI). ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
446 lines
15 KiB
TypeScript
446 lines
15 KiB
TypeScript
import type { Db } from "@paperclipai/db";
|
|
import type { ExternalObjectCanonicalUrl } from "@paperclipai/shared";
|
|
import { DEFAULT_GITHUB_TOKEN_SECRET_NAMES } from "./git-credentials.js";
|
|
import { ghFetch, gitHubApiBase } from "./github-fetch.js";
|
|
import { secretService } from "./secrets.js";
|
|
import type {
|
|
ExternalObjectDetection,
|
|
ExternalObjectDetector,
|
|
ExternalObjectResolver,
|
|
ExternalObjectResolverSnapshot,
|
|
ExternalObjectResolveResult,
|
|
} from "./external-objects.js";
|
|
|
|
type FetchLike = (url: string, init?: RequestInit) => Promise<Response>;
|
|
|
|
export interface GitHubExternalObjectProviderOptions {
|
|
fetch?: FetchLike;
|
|
tokenProvider?: (companyId: string) => Promise<string | null> | string | null;
|
|
secretNames?: readonly string[];
|
|
}
|
|
|
|
interface GitHubObjectIdentity {
|
|
host: string;
|
|
owner: string;
|
|
repo: string;
|
|
number: number;
|
|
objectType: "pull_request" | "issue";
|
|
pathKind: "pull" | "issues";
|
|
}
|
|
|
|
const GITHUB_OBJECT_TTL_SECONDS = 300;
|
|
|
|
function isGitHubHost(host: string) {
|
|
const h = host.toLowerCase();
|
|
return h === "github.com" || h === "www.github.com";
|
|
}
|
|
|
|
function asRecord(value: unknown): Record<string, unknown> | null {
|
|
return value && typeof value === "object" && !Array.isArray(value) ? value as Record<string, unknown> : null;
|
|
}
|
|
|
|
function asString(value: unknown) {
|
|
return typeof value === "string" ? value : null;
|
|
}
|
|
|
|
function asBoolean(value: unknown) {
|
|
return typeof value === "boolean" ? value : null;
|
|
}
|
|
|
|
function asNestedString(record: Record<string, unknown>, key: string, nestedKey: string) {
|
|
const nested = asRecord(record[key]);
|
|
return nested ? asString(nested[nestedKey]) : null;
|
|
}
|
|
|
|
function parseGitHubCanonicalUrl(canonical: ExternalObjectCanonicalUrl): GitHubObjectIdentity | null {
|
|
if (canonical.canonicalIdentity.scheme !== "https") return null;
|
|
const host = canonical.canonicalIdentity.host.toLowerCase();
|
|
if (!isGitHubHost(host)) return null;
|
|
|
|
const parts = canonical.canonicalIdentity.path.split("/").filter(Boolean);
|
|
if (parts.length !== 4) return null;
|
|
const [owner, repo, kind, rawNumber] = parts;
|
|
if (!owner || !repo || !kind || !rawNumber) return null;
|
|
if (!/^[A-Za-z0-9_.-]+$/.test(owner) || !/^[A-Za-z0-9_.-]+$/.test(repo)) return null;
|
|
if (!/^[1-9][0-9]*$/.test(rawNumber)) return null;
|
|
if (kind !== "pull" && kind !== "issues") return null;
|
|
|
|
return {
|
|
host: host === "www.github.com" ? "github.com" : host,
|
|
owner,
|
|
repo,
|
|
number: Number(rawNumber),
|
|
pathKind: kind,
|
|
objectType: kind === "pull" ? "pull_request" : "issue",
|
|
};
|
|
}
|
|
|
|
function parseGitHubObject(object: { externalId: string; sanitizedCanonicalUrl: string | null }): GitHubObjectIdentity | null {
|
|
const match = /^([^/]+)\/([^/]+)#(pull|issues)\/([1-9][0-9]*)$/.exec(object.externalId);
|
|
if (!match) return null;
|
|
let host = "github.com";
|
|
if (object.sanitizedCanonicalUrl) {
|
|
try {
|
|
const url = new URL(object.sanitizedCanonicalUrl);
|
|
if (isGitHubHost(url.hostname)) host = url.hostname === "www.github.com" ? "github.com" : url.hostname;
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
return {
|
|
host,
|
|
owner: match[1]!,
|
|
repo: match[2]!,
|
|
pathKind: match[3] as "pull" | "issues",
|
|
number: Number(match[4]),
|
|
objectType: match[3] === "pull" ? "pull_request" : "issue",
|
|
};
|
|
}
|
|
|
|
function externalIdFor(identity: GitHubObjectIdentity) {
|
|
return `${identity.owner.toLowerCase()}/${identity.repo.toLowerCase()}#${identity.pathKind}/${identity.number}`;
|
|
}
|
|
|
|
function displayTitleFor(identity: GitHubObjectIdentity) {
|
|
return `${identity.owner}/${identity.repo}#${identity.number}`;
|
|
}
|
|
|
|
function displayKeyFor(identity: Pick<GitHubObjectIdentity, "objectType">) {
|
|
return identity.objectType === "pull_request" ? "GitHub Pull Request" : "GitHub Issue";
|
|
}
|
|
|
|
function retryAfterSeconds(response: Response) {
|
|
const retryAfter = response.headers.get("retry-after");
|
|
if (retryAfter && /^[0-9]+$/.test(retryAfter)) return Number(retryAfter);
|
|
|
|
const reset = response.headers.get("x-ratelimit-reset");
|
|
if (reset && /^[0-9]+$/.test(reset)) {
|
|
return Math.max(1, Number(reset) - Math.floor(Date.now() / 1000));
|
|
}
|
|
|
|
return 300;
|
|
}
|
|
|
|
function failureFromGitHubResponse(response: Response): ExternalObjectResolveResult | null {
|
|
if (response.status === 401) {
|
|
return {
|
|
ok: false,
|
|
liveness: "auth_required",
|
|
errorCode: "github_auth_required",
|
|
errorMessage: "GitHub authentication is required to refresh this object.",
|
|
retryAfterSeconds: retryAfterSeconds(response),
|
|
};
|
|
}
|
|
|
|
if (response.status === 403) {
|
|
const rateLimitRemaining = response.headers.get("x-ratelimit-remaining");
|
|
if (rateLimitRemaining === "0") {
|
|
return {
|
|
ok: false,
|
|
liveness: "unreachable",
|
|
errorCode: "github_rate_limited",
|
|
errorMessage: "GitHub rate limit reached while refreshing this object.",
|
|
retryAfterSeconds: retryAfterSeconds(response),
|
|
};
|
|
}
|
|
return {
|
|
ok: false,
|
|
liveness: "auth_required",
|
|
errorCode: "github_forbidden",
|
|
errorMessage: "GitHub rejected the configured credentials for this object.",
|
|
retryAfterSeconds: retryAfterSeconds(response),
|
|
};
|
|
}
|
|
|
|
if (response.status === 429 || response.status >= 500) {
|
|
return {
|
|
ok: false,
|
|
liveness: "unreachable",
|
|
errorCode: response.status === 429 ? "github_rate_limited" : "github_unreachable",
|
|
errorMessage: `GitHub returned HTTP ${response.status} while refreshing this object.`,
|
|
retryAfterSeconds: retryAfterSeconds(response),
|
|
};
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
function notFoundSnapshot(identity: GitHubObjectIdentity, etag: string | null): ExternalObjectResolverSnapshot {
|
|
return {
|
|
displayKey: displayKeyFor(identity),
|
|
iconKey: "github",
|
|
displayTitle: displayTitleFor(identity),
|
|
statusKey: "not_found",
|
|
statusLabel: "Not found",
|
|
statusIconKey: "archive",
|
|
statusCategory: "archived",
|
|
statusTone: "muted",
|
|
isTerminal: true,
|
|
etag,
|
|
ttlSeconds: GITHUB_OBJECT_TTL_SECONDS,
|
|
data: {
|
|
provider: "github",
|
|
owner: identity.owner,
|
|
repo: identity.repo,
|
|
number: identity.number,
|
|
notFound: true,
|
|
},
|
|
};
|
|
}
|
|
|
|
function pullRequestSnapshot(identity: GitHubObjectIdentity, body: Record<string, unknown>, etag: string | null): ExternalObjectResolverSnapshot {
|
|
const title = asString(body.title);
|
|
const state = asString(body.state) ?? "unknown";
|
|
const draft = asBoolean(body.draft) ?? false;
|
|
const merged = (asBoolean(body.merged) ?? false) || Boolean(asString(body.merged_at));
|
|
const authorLogin = asNestedString(body, "user", "login");
|
|
const headRef = asNestedString(body, "head", "ref");
|
|
const baseRef = asNestedString(body, "base", "ref");
|
|
const reviewDecision = asString(body.review_decision);
|
|
|
|
let statusKey = state;
|
|
let statusLabel = state === "open" ? "Open" : state === "closed" ? "Closed" : "Unknown";
|
|
let statusCategory: ExternalObjectResolverSnapshot["statusCategory"] = state === "open" ? "open" : "unknown";
|
|
let statusTone: ExternalObjectResolverSnapshot["statusTone"] = state === "open" ? "info" : "neutral";
|
|
let isTerminal = false;
|
|
|
|
if (merged) {
|
|
statusKey = "merged";
|
|
statusLabel = "Merged";
|
|
statusCategory = "succeeded";
|
|
statusTone = "success";
|
|
isTerminal = true;
|
|
} else if (state === "closed") {
|
|
statusKey = "closed";
|
|
statusLabel = "Closed";
|
|
statusCategory = "closed";
|
|
statusTone = "muted";
|
|
isTerminal = true;
|
|
} else if (draft) {
|
|
statusKey = "draft";
|
|
statusLabel = "Draft";
|
|
statusCategory = "waiting";
|
|
statusTone = "warning";
|
|
}
|
|
|
|
return {
|
|
displayKey: displayKeyFor(identity),
|
|
iconKey: "github",
|
|
displayTitle: title ? `${displayTitleFor(identity)}: ${title}` : displayTitleFor(identity),
|
|
statusKey,
|
|
statusLabel,
|
|
statusIconKey: merged
|
|
? "git-merge"
|
|
: state === "closed"
|
|
? "x-circle"
|
|
: draft
|
|
? "clock"
|
|
: "git-pull-request",
|
|
statusCategory,
|
|
statusTone,
|
|
isTerminal,
|
|
remoteVersion: asString(body.updated_at),
|
|
etag,
|
|
ttlSeconds: GITHUB_OBJECT_TTL_SECONDS,
|
|
data: {
|
|
provider: "github",
|
|
owner: identity.owner,
|
|
repo: identity.repo,
|
|
number: identity.number,
|
|
state,
|
|
merged,
|
|
draft,
|
|
...(authorLogin ? { authorLogin } : {}),
|
|
...(headRef ? { headRef } : {}),
|
|
...(baseRef ? { baseRef } : {}),
|
|
...(reviewDecision ? { reviewDecision } : {}),
|
|
},
|
|
};
|
|
}
|
|
|
|
function issueSnapshot(identity: GitHubObjectIdentity, body: Record<string, unknown>, etag: string | null): ExternalObjectResolverSnapshot {
|
|
const title = asString(body.title);
|
|
const state = asString(body.state) ?? "unknown";
|
|
const stateReason = asString(body.state_reason);
|
|
const authorLogin = asNestedString(body, "user", "login");
|
|
const statusKey = state === "closed" && stateReason ? `closed_${stateReason}` : state;
|
|
const statusLabel = state === "closed"
|
|
? stateReason
|
|
? `Closed: ${stateReason.replace(/_/g, " ")}`
|
|
: "Closed"
|
|
: state === "open"
|
|
? "Open"
|
|
: "Unknown";
|
|
|
|
return {
|
|
displayKey: displayKeyFor(identity),
|
|
iconKey: "github",
|
|
displayTitle: title ? `${displayTitleFor(identity)}: ${title}` : displayTitleFor(identity),
|
|
statusKey,
|
|
statusLabel,
|
|
statusIconKey: state === "closed" ? "circle" : "circle-dot",
|
|
statusCategory: state === "open" ? "open" : state === "closed" ? "closed" : "unknown",
|
|
statusTone: state === "open" ? "info" : state === "closed" ? "muted" : "neutral",
|
|
isTerminal: state === "closed",
|
|
remoteVersion: asString(body.updated_at),
|
|
etag,
|
|
ttlSeconds: GITHUB_OBJECT_TTL_SECONDS,
|
|
data: {
|
|
provider: "github",
|
|
owner: identity.owner,
|
|
repo: identity.repo,
|
|
number: identity.number,
|
|
state,
|
|
...(stateReason ? { stateReason } : {}),
|
|
...(authorLogin ? { authorLogin } : {}),
|
|
},
|
|
};
|
|
}
|
|
|
|
async function safeJson(response: Response) {
|
|
try {
|
|
return asRecord(await response.json());
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
async function defaultTokenProvider(db: Db, companyId: string, secretNames: readonly string[]) {
|
|
const secrets = secretService(db);
|
|
for (const secretName of secretNames) {
|
|
const secret = await secrets.getByName(companyId, secretName);
|
|
if (!secret) continue;
|
|
const token = await secrets.resolveSecretValue(companyId, secret.id, "latest");
|
|
const trimmed = token.trim();
|
|
if (trimmed) return trimmed;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
export function createGitHubExternalObjectProvider(
|
|
db: Db,
|
|
opts: GitHubExternalObjectProviderOptions = {},
|
|
): { detector: ExternalObjectDetector; resolvers: ExternalObjectResolver[] } {
|
|
const fetchImpl = opts.fetch ?? ghFetch;
|
|
const secretNames = opts.secretNames ?? DEFAULT_GITHUB_TOKEN_SECRET_NAMES;
|
|
const tokenProvider = Object.prototype.hasOwnProperty.call(opts, "tokenProvider") && opts.tokenProvider !== undefined
|
|
? opts.tokenProvider
|
|
: ((companyId: string) => defaultTokenProvider(db, companyId, secretNames));
|
|
|
|
const detector: ExternalObjectDetector = {
|
|
key: "github",
|
|
detect({ urls }): ExternalObjectDetection[] {
|
|
return urls.flatMap((canonical) => {
|
|
const identity = parseGitHubCanonicalUrl(canonical);
|
|
if (!identity) return [];
|
|
return [{
|
|
canonical,
|
|
detectorKey: "github",
|
|
providerKey: "github",
|
|
objectType: identity.objectType,
|
|
externalId: externalIdFor(identity),
|
|
displayKey: displayKeyFor(identity),
|
|
iconKey: "github",
|
|
displayTitle: displayTitleFor(identity),
|
|
confidence: "exact",
|
|
}];
|
|
});
|
|
},
|
|
};
|
|
|
|
function resolver(objectType: GitHubObjectIdentity["objectType"]): ExternalObjectResolver {
|
|
return {
|
|
providerKey: "github",
|
|
objectType,
|
|
async resolve({ companyId, object }) {
|
|
const identity = parseGitHubObject(object);
|
|
if (!identity || identity.objectType !== objectType) {
|
|
return {
|
|
ok: false,
|
|
liveness: "unreachable",
|
|
errorCode: "github_invalid_identity",
|
|
errorMessage: "GitHub object identity is invalid.",
|
|
retryAfterSeconds: GITHUB_OBJECT_TTL_SECONDS,
|
|
};
|
|
}
|
|
|
|
let token: string | null = null;
|
|
try {
|
|
token = typeof tokenProvider === "function" ? await tokenProvider(companyId) : tokenProvider;
|
|
} catch {
|
|
return {
|
|
ok: false,
|
|
liveness: "auth_required",
|
|
errorCode: "github_token_unavailable",
|
|
errorMessage: "Configured GitHub credentials could not be resolved.",
|
|
retryAfterSeconds: GITHUB_OBJECT_TTL_SECONDS,
|
|
};
|
|
}
|
|
token = token?.trim() || null;
|
|
const headers: Record<string, string> = {
|
|
accept: "application/vnd.github+json",
|
|
"user-agent": "paperclip-external-object-resolver",
|
|
"x-github-api-version": "2022-11-28",
|
|
};
|
|
if (token) headers.authorization = `Bearer ${token}`;
|
|
|
|
const apiKind = objectType === "pull_request" ? "pulls" : "issues";
|
|
const url = `${gitHubApiBase(identity.host)}/repos/${encodeURIComponent(identity.owner)}/${encodeURIComponent(identity.repo)}/${apiKind}/${identity.number}`;
|
|
|
|
let response: Response;
|
|
try {
|
|
response = await fetchImpl(url, { headers });
|
|
} catch {
|
|
return {
|
|
ok: false,
|
|
liveness: "unreachable",
|
|
errorCode: "github_fetch_failed",
|
|
errorMessage: "GitHub could not be reached while refreshing this object.",
|
|
retryAfterSeconds: GITHUB_OBJECT_TTL_SECONDS,
|
|
};
|
|
}
|
|
|
|
const etag = response.headers.get("etag");
|
|
if (response.status === 404) {
|
|
return { ok: true, snapshot: notFoundSnapshot(identity, etag) };
|
|
}
|
|
|
|
const failure = failureFromGitHubResponse(response);
|
|
if (failure) return failure;
|
|
if (!response.ok) {
|
|
return {
|
|
ok: false,
|
|
liveness: "unreachable",
|
|
errorCode: "github_unexpected_response",
|
|
errorMessage: `GitHub returned HTTP ${response.status} while refreshing this object.`,
|
|
retryAfterSeconds: GITHUB_OBJECT_TTL_SECONDS,
|
|
};
|
|
}
|
|
|
|
const body = await safeJson(response);
|
|
if (!body) {
|
|
return {
|
|
ok: false,
|
|
liveness: "unreachable",
|
|
errorCode: "github_invalid_response",
|
|
errorMessage: "GitHub returned an invalid object response.",
|
|
retryAfterSeconds: GITHUB_OBJECT_TTL_SECONDS,
|
|
};
|
|
}
|
|
|
|
return {
|
|
ok: true,
|
|
snapshot: objectType === "pull_request"
|
|
? pullRequestSnapshot(identity, body, etag)
|
|
: issueSnapshot(identity, body, etag),
|
|
};
|
|
},
|
|
};
|
|
}
|
|
|
|
return {
|
|
detector,
|
|
resolvers: [resolver("pull_request"), resolver("issue")],
|
|
};
|
|
}
|