mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-07 16:35:48 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Governed MCP access spans contracts, runtime enforcement, adapters, UI surfaces, and operator verification > - The parity reference PR #9534 is too large for effective automated or human review > - The feature therefore needs a linear stack whose individual diffs stay below the 100-file review limit > - This pull request is split 6/8 and focuses on UI API, shared components, and Tools/Profile surfaces > - The benefit is a standalone, testable review boundary while preserving byte-for-byte parity at the top of the stack ## Linked Issues or Issue Description - Related parity reference: #9534 - Problem: Operators need typed clients and administration surfaces that compile independently before navigation exposes them. - Proposed solution: Adds UI APIs, hooks, libraries, shared components, Tools/Profiles pages, and the plugin settings consumer required by the new company-scoped API. - Alternatives considered: keeping #9534 as one 403-file review, or rewriting the feature to manufacture seams; both were rejected in favor of path extraction plus compile-driven boundary moves. - Roadmap alignment: this advances the existing governed MCP/tool-access work already represented by #9534; it does not introduce a separate roadmap initiative. - Stack position: base branch is `pap10341-split/05-runtime-integration`. - Merge policy: merge bottom-up, in order, only after the complete eight-PR stack has been reviewed and the top-of-stack parity gate remains empty. - Requested review: UXDesigner sanity pass on Tools/Profile surfaces; Greptile on every PR. ## What Changed - Adds UI APIs, hooks, libraries, shared components, Tools/Profiles pages, and the plugin settings consumer required by the new company-scoped API. - Keeps this PR below 100 changed files and independently typecheckable. - Preserves the final tree from #9534 when combined with the other seven stack levels. ## Verification - `pnpm typecheck` - `pnpm check:token-gates` — all gates clean - Focused UI Vitest run with `NODE_ENV=test` — 28 files, 183 tests passed ## Risks - Large dead-code UI additions can drift from activation routes; PR 7 supplies the registration layer and top-level parity catches omissions. - Stack risk: merging out of order can expose incomplete layers; mitigate by following the documented bottom-up merge policy. - Parity risk: later edits to an intermediate branch can drift from #9534; mitigate by re-running the empty top-of-stack diff before merge. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, exact model ID `gpt-5.4`; runtime-managed context window; medium reasoning with repository, shell, Git, GitHub CLI, and code-execution tools enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] Internal references are omitted except the execution-plan link explicitly required for this coordinated split stack - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge ## Stack Coordination - Internal execution plan: [PAP-13874](/PAP/issues/PAP-13874#document-plan) - Parity reference: #9534 - Stack: #9556 → #9557 → #9558 → #9559 → #9560 → #9561 → #9562 → #9563 - Merge bottom-up only after full-stack review and an empty parity diff at #9563. ## UI Evidence QA captured these from the live Garden MCP split stack at 1440px and verified clean rendering:    --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
142 lines
5.0 KiB
TypeScript
142 lines
5.0 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { createRoot } from "react-dom/client";
|
|
import { flushSync } from "react-dom";
|
|
import type { ReactElement } from "react";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { ActionCard, ActionCardMobile, BindingsTable, shortSha } from "./ActionCard";
|
|
|
|
// EnforcementBanner pulls in a react-query hook; the stale variant only needs
|
|
// its presentational copy, so stub it to keep the test free of a QueryClient.
|
|
vi.mock("@/components/EnforcementBanner", () => ({
|
|
EnforcementBanner: ({ title, body }: { title?: string; body?: string }) => (
|
|
<div data-testid="stale-banner">
|
|
<span>{title}</span>
|
|
<span>{body}</span>
|
|
</div>
|
|
),
|
|
}));
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
let root: ReturnType<typeof createRoot> | null = null;
|
|
let container: HTMLDivElement | null = null;
|
|
|
|
afterEach(() => {
|
|
if (root) flushSync(() => root?.unmount());
|
|
root = null;
|
|
container?.remove();
|
|
container = null;
|
|
});
|
|
|
|
function render(element: ReactElement) {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
flushSync(() => root?.render(element));
|
|
return container;
|
|
}
|
|
|
|
const baseBinding = {
|
|
application: "Slack",
|
|
manifestVersion: "2.4.1",
|
|
connection: "https://slack.com/api",
|
|
catalogSha256: "sha256:9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08",
|
|
payloadSha256: "sha256:2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae",
|
|
};
|
|
|
|
const baseProps = {
|
|
toolName: "slack.post_message",
|
|
risk: "medium" as const,
|
|
isWrite: true,
|
|
binding: baseBinding,
|
|
input: { channel: "#launch", text: "hi" },
|
|
reason: "Write-capable tool.",
|
|
policyNumber: 7,
|
|
expiresInLabel: "expires in 23h 51m",
|
|
};
|
|
|
|
function approveButton(c: HTMLElement): HTMLButtonElement {
|
|
const btn = Array.from(c.querySelectorAll("button")).find((b) => b.textContent?.trim() === "Approve");
|
|
if (!btn) throw new Error("Approve button not found");
|
|
return btn as HTMLButtonElement;
|
|
}
|
|
|
|
describe("ActionCard", () => {
|
|
it("surfaces the signed payload sha256 and expiry (PAP-10400)", () => {
|
|
const c = render(<ActionCard {...baseProps} />);
|
|
expect(c.textContent).toContain(shortSha(baseBinding.payloadSha256));
|
|
expect(c.textContent).toContain("signed");
|
|
expect(c.textContent).toContain("expires in 23h 51m");
|
|
});
|
|
|
|
it("references the policy number in the explanation", () => {
|
|
const c = render(<ActionCard {...baseProps} />);
|
|
expect(c.textContent).toContain("Policy #7");
|
|
});
|
|
|
|
it("enables Approve on the pending variant and fires the handler", () => {
|
|
const onApprove = vi.fn();
|
|
const c = render(<ActionCard {...baseProps} onApprove={onApprove} />);
|
|
const btn = approveButton(c);
|
|
expect(btn.disabled).toBe(false);
|
|
flushSync(() => btn.dispatchEvent(new MouseEvent("click", { bubbles: true })));
|
|
expect(onApprove).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("disables Approve and shows the catalog mismatch on the stale variant", () => {
|
|
const c = render(
|
|
<ActionCard
|
|
{...baseProps}
|
|
variant="stale"
|
|
binding={{
|
|
...baseBinding,
|
|
catalogSha256: "sha256:7d793037a0760186574b0282f2f435e7deadbeefcafef00dba5eba5eba5eba5e",
|
|
previousCatalogSha256: baseBinding.catalogSha256,
|
|
}}
|
|
/>,
|
|
);
|
|
expect(approveButton(c).disabled).toBe(true);
|
|
expect(c.querySelector('[data-testid="stale-banner"]')).not.toBeNull();
|
|
// Previous (now-invalid) hash is struck through next to the current one.
|
|
const struck = c.querySelector(".line-through");
|
|
expect(struck?.textContent).toContain(shortSha(baseBinding.catalogSha256));
|
|
});
|
|
|
|
it("stacks buttons Approve / Deny / Edit & re-sign on mobile with a 70px label column", () => {
|
|
const c = render(<ActionCardMobile {...baseProps} />);
|
|
const labels = c.querySelectorAll("dt");
|
|
expect(labels.length).toBeGreaterThan(0);
|
|
expect((labels[0] as HTMLElement).style.width).toBe("70px");
|
|
|
|
const buttonText = Array.from(c.querySelectorAll("button")).map((b) => b.textContent?.trim());
|
|
const order = buttonText.filter((t) => t === "Approve" || t === "Deny" || t?.startsWith("Edit"));
|
|
expect(order[0]).toBe("Approve");
|
|
expect(order[1]).toBe("Deny");
|
|
expect(order[2]).toContain("Edit");
|
|
});
|
|
});
|
|
|
|
describe("BindingsTable", () => {
|
|
it("renders mono rows with the default 132px label column", () => {
|
|
const c = render(
|
|
<BindingsTable rows={[{ label: "Catalog", value: "sha256:abc", mono: true }]} />,
|
|
);
|
|
const dt = c.querySelector("dt") as HTMLElement;
|
|
expect(dt.style.width).toBe("132px");
|
|
expect(c.querySelector("dd")?.className).toContain("font-mono");
|
|
});
|
|
});
|
|
|
|
describe("shortSha", () => {
|
|
it("truncates a long sha to the review form", () => {
|
|
expect(shortSha("sha256:9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08")).toBe(
|
|
"sha256:9f86d08188…f00a08",
|
|
);
|
|
});
|
|
it("leaves a short sha intact", () => {
|
|
expect(shortSha("sha256:abcd")).toBe("sha256:abcd");
|
|
});
|
|
});
|