mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-30 05:16:50 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Apps and AI Connections store credentials and govern access to agent runtimes. > - Users need a supported saved-token connection and config values that survive save and reopen. > - The release must preserve saved-token access and task lifecycle guarantees. > - This pull request will connect Copilot through the normal Apps and AI Connections path. > - The benefit is a reviewable part of the Copilot production release. ## Linked Issues or Issue Description Refs #15701 and #15703. Supersedes setup work in #15562. Base: #15703. Next: #15706. ## What Changed - Require configuration update authority before Copilot credential-bearing model discovery; default to the saved environment and preserve explicit selection for editors. - Keep Copilot discovery passive during reconnect reconciliation; refresh on explicit opening, account/environment changes and reconnect. - Add GitHub AI token connections with encrypted storage, ownership, grants and audit logging. - Keep repository access separate from Copilot runtime authentication. - Probe the selected environment without sending a model prompt and preserve authenticated model selection through save/reopen. - Keep fresh execution admission consistent with normal Copilot setup; persist task model choices without changing provider or permission policy. - Refresh authenticated models after reconnecting the same saved Copilot account, including recovery from a previous authentication error. - Apply the additive provider-default constraint migration through the normal generated migration workflow. ## Verification Runtime #15701 is merged at `d855e550ad8d2a267312983f26457aabf5393c3a`. History #15703 is merged at `df80616d98119cbf5abd40549794d9980a5fabf6`. Remaining source [`42bcbd61299655f7e37aabe6bb5f19bba770ad1d`](https://github.com/paperclipai/paperclip/commit/42bcbd61299655f7e37aabe6bb5f19bba770ad1d) contains the four-file authorization repair. The remaining PR trees preserve six nonoverlapping files from the newer public mainline managed-settings fix and the CI-owned lockfile. No unrelated provider is enabled. The security finding is repaired: existing-agent discovery requires `agent_config:update` before connection selection or token resolution. The saved environment is the default. Authorized editors can select a prospective environment. Both denied board-viewer and agent-reader regressions fail on the original source. All49 route tests and server typecheck pass with the fix. Denied requests perform no connection selection, credential resolution or probe. Current-head security scans pass on both remaining PRs; the repaired thread is resolved. Copilot CLI1.0.88 and profile47 retain digest `sha256:55044aa235e88b3fe36ec8a556ee1e3382590870aab907e4462ef7d64af49cea`. The [qualification record](https://github.com/paperclipai/paperclip/blob/42bcbd61299655f7e37aabe6bb5f19bba770ad1d/doc/plans/2026-10-20-copilot-qualification-v47.json) reports20/20 Product cells,154 assertions and7/7 protocol cases,46 assertions against frozen normal installed source `c2616370800f5f6df45246b0890ba35a7cd2faab`. The exact qualification model is `gpt-5.6-luna`. Every passing Product case confirms cleanup. Original failures remain recorded; automatic behavior retries are disabled. The route-only authorization repair changes no bound runtime/profile bytes and does not relabel the frozen campaign. The ordinary installed remote journey passed saved-token selection, model discovery, normal UI save/reopen, metadata-only Test, completed task, accepted receipt and exact19-byte browser download. An open model catalog caused no additional discovery requests during117seconds. Actual installed runtime smokes passed on macOS ARM64, macOS x64 under Rosetta and native Linux x64 on Daytona. Raw token browser entry was not exercised; encrypted connection creation used the normal API. The first Daytona file attempt timed out during delayed semantic dispatch; its precise stalled layer remains unresolved. Independent ordinary remote delivery and the other19 Product cells passed before one instrumented recheck passed8/8 with unchanged source,prompt,assertions and deadlines. No causal latency repair is claimed. Before the authorization repair, all four final PR heads passed required verify/E2E and fresh Greptile5/5 reviews with zero unresolved threads. Current-head CI/review is running for the two repaired heads. Local focused checks retain129 connection,59 runner,72 shared-eval and88 recovery/workspace passes, plus migration safety and token gates. The additive Copilot migration is361; released master history is preserved. [Cloud normal-package run39414239704](https://github.com/paperclipai/paperclip/actions/runs/39414239704) builds the pre-security source4f3f. All four native producers and Linux package assembly pass; the final clean installed consumers are finishing. All18 retained archives match their hashes;37,863 regular files contain zero selected credentials. That package does not contain the later route repair. The actual final published package must include it and pass the local/Daytona live canaries. The frozen Daytona image remains published and independently verified. No separate full-image scan is claimed. Docker builds run in the cloud. **Remaining:** current-head CI/review, setup and qualification merges, final publication, and ordinary local/Daytona canaries against the actual shipped package. The user explicitly authorizes the maintainer review override; CI remains a merge gate. No production deployment is claimed. Provider USD remains unknown and GitHub-attributed. ## Risks Bad credentials, missing entitlement, runtime installation and unavailable models must remain distinct failures. A connection must not adopt ambient credentials. The constraint migration changes accepted provider values, with no credential-storage migration. Current-master NewAgent fixture extraction is retained. Copilot cases use that shared support and test both passive discovery and explicit reconnect under the same setup lifecycle. The onboarding retry regression shares the component suite’s saved-connection, authenticated-model, draft, agent-list, hire and render lifecycle fixtures. Keeping it beside the existing onboarding failures makes adoption versus duplicate hire observable under the same lifecycle; this is the concrete cohesion reason for the existing large test file. ## Model Used OpenAI Codex, based on GPT-6. The exact serving model ID and context window are not exposed in this task. Used for code changes, review and tool-assisted verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
408 lines
22 KiB
TypeScript
408 lines
22 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act, useState, type ComponentProps } from "react";
|
|
import { flushSync } from "react-dom";
|
|
import { createRoot } from "react-dom/client";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import type { Agent } from "@paperclipai/shared";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { agentsApi } from "@/api/agents";
|
|
import { ComposerRunSettingsPicker } from "./ComposerRunSettingsPicker";
|
|
import type { ComposerRunSettings } from "./composer-run-settings";
|
|
import { getLastComposerEffort, rememberComposerEffort } from "@/lib/recent-composer-effort";
|
|
import { Dialog, DialogContent, DialogTitle } from "@/components/ui/dialog";
|
|
|
|
const agent = {
|
|
id: "a1", companyId: "company-1", name: "Clippy",
|
|
role: "Engineering Lead",
|
|
adapterType: "codex_local", adapterConfig: { model: "gpt-6-sol" },
|
|
} as unknown as Agent;
|
|
const options = [{ id: "agent:a1", label: "Clippy" }];
|
|
const agents = new Map([[agent.id, agent]]);
|
|
let container: HTMLDivElement | null = null;
|
|
let root: ReturnType<typeof createRoot> | null = null;
|
|
globalThis.ResizeObserver = class {
|
|
observe() {}
|
|
disconnect() {}
|
|
unobserve() {}
|
|
};
|
|
(globalThis as typeof globalThis & { IS_REACT_ACT_ENVIRONMENT: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
async function click(label: string) {
|
|
const button = document.querySelector<HTMLButtonElement>(`button[aria-label="${label}"]`)
|
|
?? [...document.querySelectorAll<HTMLButtonElement>('button[role="option"]')].find((item) => item.textContent?.trim().startsWith(label));
|
|
expect(button).toBeDefined();
|
|
flushSync(() => button!.click());
|
|
await act(async () => { await new Promise((resolve) => setTimeout(resolve, 0)); });
|
|
}
|
|
|
|
function render(onAssigneeChange: (value: string) => void, onSettingsChange: () => void, useCatalog = false, props: Partial<ComponentProps<typeof ComposerRunSettingsPicker>> = {}, insideDialog = false) {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
const picker = <QueryClientProvider client={queryClient}>
|
|
<ComposerRunSettingsPicker companyId="company-1" assigneeValue="agent:a1" currentAssigneeValue="agent:a1"
|
|
options={options} agents={agents} settings={{ model: "gpt-6-sol", effort: "high", fast: true }}
|
|
onAssigneeChange={onAssigneeChange} onSettingsChange={onSettingsChange}
|
|
modelOptionsOverride={useCatalog ? undefined : []} {...props} />
|
|
</QueryClientProvider>;
|
|
flushSync(() => root!.render(insideDialog ? <Dialog defaultOpen><DialogContent aria-describedby={undefined}><DialogTitle>New task</DialogTitle>{picker}</DialogContent></Dialog> : picker));
|
|
return queryClient;
|
|
}
|
|
|
|
beforeEach(() => localStorage.clear());
|
|
afterEach(() => {
|
|
vi.restoreAllMocks();
|
|
flushSync(() => root?.unmount());
|
|
root = null;
|
|
container?.remove();
|
|
container = null;
|
|
});
|
|
|
|
describe("composer assignee picker", () => {
|
|
it.each([false, true])("keeps the trigger stable until the picker closes (mobile: %s)", async (mobile) => {
|
|
function ControlledPicker() {
|
|
const [settings, setSettings] = useState({ model: "gpt-6-sol", effort: "high", fast: false });
|
|
return <ComposerRunSettingsPicker companyId="company-1" assigneeValue="agent:a1" currentAssigneeValue="agent:a1"
|
|
options={options} agents={agents} settings={settings} onSettingsChange={(next) => setSettings(next! as typeof settings)}
|
|
onAssigneeChange={vi.fn()} mobile={mobile} modelOptionsOverride={[{ id: "gpt-6-sol", label: "GPT-6 Sol" }, { id: "gpt-6-astra", label: "GPT-6 Astra" }]} />;
|
|
}
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
const queryClient = new QueryClient();
|
|
flushSync(() => root!.render(<QueryClientProvider client={queryClient}><ControlledPicker /></QueryClientProvider>));
|
|
const label = () => container!.querySelector('[data-testid="task-chat-composer-model-label"]')!.textContent;
|
|
expect(label()).toBe("GPT-6 Sol");
|
|
await click("Select model and effort");
|
|
expect(label()).toBe("Select model");
|
|
const range = document.querySelector<HTMLInputElement>('input[aria-label="Effort"]')!;
|
|
flushSync(() => {
|
|
Object.getOwnPropertyDescriptor(window.HTMLInputElement.prototype, "value")!.set!.call(range, "1");
|
|
range.dispatchEvent(new Event("input", { bubbles: true }));
|
|
});
|
|
expect(range.getAttribute("aria-valuetext")).toBe("Low");
|
|
expect(label()).toBe("Select model");
|
|
expect(container!.querySelector('[aria-label="Select model and effort"]')!.textContent).not.toContain("Low");
|
|
await click("Choose assignee");
|
|
expect(label()).toBe("Select model");
|
|
await click("Clippy");
|
|
expect(label()).toBe("GPT-6 Sol");
|
|
expect(container!.querySelector('[aria-label="Select model and effort"]')!.textContent).toContain("Low");
|
|
await click("Select model and effort");
|
|
await click("Choose exact model");
|
|
await click("GPT-6 Astra");
|
|
expect(label()).toBe("Select model");
|
|
if (mobile) await click("Close picker");
|
|
else {
|
|
await act(async () => {
|
|
document.dispatchEvent(new KeyboardEvent("keydown", { key: "Escape", bubbles: true }));
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
});
|
|
}
|
|
expect(label()).toBe("GPT-6 Astra");
|
|
expect(container!.querySelector('[aria-label="Select model and effort"]')!.textContent).toContain("Low");
|
|
});
|
|
|
|
it.each([
|
|
{ mobile: false, view: "settings" as const },
|
|
{ mobile: false, view: "models" as const },
|
|
{ mobile: false, view: "agents" as const },
|
|
{ mobile: true, view: "settings" as const },
|
|
{ mobile: true, view: "models" as const },
|
|
{ mobile: true, view: "agents" as const },
|
|
])("allows wheel and touch scrolling in a nested $view picker (mobile: $mobile)", async ({ mobile, view }) => {
|
|
render(vi.fn(), vi.fn(), false, { mobile, initialOpen: true, initialView: view }, true);
|
|
await act(async () => { await new Promise((resolve) => setTimeout(resolve, 0)); });
|
|
const list = document.querySelector<HTMLElement>(view === "settings"
|
|
? '[data-testid="composer-run-settings-view"]'
|
|
: `[role="listbox"][aria-label="${view === "models" ? "Models" : "Assignees"}"]`)!;
|
|
expect(list).not.toBeNull();
|
|
list.style.overflowY = "auto";
|
|
Object.defineProperties(list, {
|
|
scrollHeight: { configurable: true, value: 1000 },
|
|
clientHeight: { configurable: true, value: 200 },
|
|
});
|
|
const option = list.querySelector("button")!;
|
|
const wheel = new WheelEvent("wheel", { bubbles: true, cancelable: true, deltaY: 100 });
|
|
option.dispatchEvent(wheel);
|
|
expect(wheel.defaultPrevented).toBe(false);
|
|
const touch = (type: string, y: number) => {
|
|
const event = new Event(type, { bubbles: true, cancelable: true });
|
|
Object.defineProperties(event, {
|
|
touches: { value: [{ clientX: 100, clientY: y }] },
|
|
changedTouches: { value: [{ clientX: 100, clientY: y }] },
|
|
});
|
|
option.dispatchEvent(event);
|
|
return event;
|
|
};
|
|
touch("touchstart", 150);
|
|
expect(touch("touchmove", 100).defaultPrevented).toBe(false);
|
|
const outsideWheel = new WheelEvent("wheel", { bubbles: true, cancelable: true, deltaY: 100 });
|
|
document.body.dispatchEvent(outsideWheel);
|
|
expect(outsideWheel.defaultPrevented).toBe(true);
|
|
});
|
|
|
|
it.each([
|
|
{ adapterType: "claude_local", config: {}, label: "Default" },
|
|
{ adapterType: "claude_local", config: { model: "claude-opus-5" }, label: "Claude Opus 5" },
|
|
{ adapterType: "claude_local", config: { env: { ANTHROPIC_MODEL: "claude-opus-5" } }, label: "Claude Opus 5" },
|
|
{ adapterType: "codex_local", config: {}, label: "Default" },
|
|
])("labels the $adapterType default honestly", ({ adapterType, config, label }) => {
|
|
const defaultAgent = { ...agent, adapterType, adapterConfig: config } as Agent;
|
|
render(vi.fn(), vi.fn(), false, { settings: null, agents: new Map([[agent.id, defaultAgent]]),
|
|
modelOptionsOverride: [{ id: "claude-opus-5", label: "Claude Opus 5" }] });
|
|
expect(container!.querySelector('[data-testid="task-chat-composer-model-label"]')?.textContent).toBe(label);
|
|
});
|
|
|
|
it("does not offer effort levels for an unknown Claude default", async () => {
|
|
const defaultAgent = { ...agent, adapterType: "claude_local", adapterConfig: {} } as Agent;
|
|
render(vi.fn(), vi.fn(), false, { settings: null, agents: new Map([[agent.id, defaultAgent]]),
|
|
modelOptionsOverride: [{ id: "claude-opus-5", label: "Claude Opus 5" }] });
|
|
await click("Select model and effort");
|
|
expect(document.querySelector('[aria-label="Effort"]')).toBeNull();
|
|
});
|
|
|
|
it.each([
|
|
{ remembered: "high", settings: null, overrides: null, restored: "high" },
|
|
{ remembered: "off", settings: null, overrides: null, restored: null },
|
|
{ remembered: "high", settings: { model: null, effort: "low", fast: false }, overrides: null, restored: null },
|
|
{ remembered: "high", settings: null, overrides: { adapterConfig: { modelReasoningEffort: "low" } }, restored: null },
|
|
])("restores compatible history ($remembered) without replacing explicit settings", ({ remembered, settings, overrides, restored }) => {
|
|
rememberComposerEffort("company-1", remembered);
|
|
const onSettingsChange = vi.fn();
|
|
render(vi.fn(), onSettingsChange, false, { settings, overrides });
|
|
if (restored) expect(onSettingsChange).toHaveBeenCalledWith({ model: null, effort: restored, fast: false });
|
|
else expect(onSettingsChange).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("records effort changes and preserves effort when changing to a compatible model", async () => {
|
|
const onSettingsChange = vi.fn();
|
|
render(vi.fn(), onSettingsChange, false, { modelOptionsOverride: [{ id: "gpt-6-astra", label: "GPT-6 Astra" }] });
|
|
await click("Select model and effort");
|
|
const range = document.querySelector<HTMLInputElement>('input[aria-label="Effort"]')!;
|
|
flushSync(() => {
|
|
Object.getOwnPropertyDescriptor(window.HTMLInputElement.prototype, "value")!.set!.call(range, "1");
|
|
range.dispatchEvent(new Event("change", { bubbles: true }));
|
|
range.dispatchEvent(new Event("input", { bubbles: true }));
|
|
});
|
|
expect(getLastComposerEffort("company-1")).toBe("low");
|
|
await click("Choose exact model");
|
|
await click("GPT-6 Astra");
|
|
expect(onSettingsChange).toHaveBeenLastCalledWith({ model: "gpt-6-astra", effort: "high", fast: false });
|
|
await click("Reset to agent default");
|
|
expect(getLastComposerEffort("company-1")).toBeNull();
|
|
});
|
|
it("lets the assignee and model use the available composer width", () => {
|
|
render(vi.fn(), vi.fn());
|
|
const trigger = container!.querySelector<HTMLButtonElement>('[data-testid="task-chat-composer-assignee"]');
|
|
const assignee = trigger!.querySelector('[data-testid="task-chat-composer-assignee-label"]');
|
|
const model = container!.querySelector('[data-testid="task-chat-composer-model-label"]');
|
|
|
|
expect(trigger?.className).toContain("max-w-full");
|
|
expect(trigger?.className).not.toContain("max-w-64");
|
|
expect(assignee?.className).toContain("min-w-0");
|
|
expect(assignee?.className).not.toContain("max-w-24");
|
|
expect(model?.className).toContain("min-w-0");
|
|
expect(assignee?.className).toContain("truncate");
|
|
expect(model?.className).toContain("truncate");
|
|
});
|
|
|
|
it("finds assignees by their displayed role and harness", async () => {
|
|
render(vi.fn(), vi.fn());
|
|
await click("Select assignee");
|
|
const input = document.querySelector<HTMLInputElement>('input[aria-label="Search assignees"]');
|
|
expect(input).not.toBeNull();
|
|
const setValue = Object.getOwnPropertyDescriptor(window.HTMLInputElement.prototype, "value")!.set!;
|
|
for (const query of ["Engineering Lead", "Codex"]) {
|
|
flushSync(() => {
|
|
setValue.call(input, query);
|
|
input!.dispatchEvent(new Event("input", { bubbles: true }));
|
|
});
|
|
expect([...document.querySelectorAll<HTMLButtonElement>('button[role="option"]')]
|
|
.some((option) => option.textContent?.includes("Clippy"))).toBe(true);
|
|
}
|
|
});
|
|
|
|
it("offers the Codex CLI catalog instead of unrelated OpenAI API models", async () => {
|
|
vi.spyOn(agentsApi, "adapterModels").mockResolvedValueOnce([
|
|
{ id: "gpt-6-sol", label: "GPT-6 Sol" },
|
|
{ id: "gpt-5.5", label: "GPT-5.5" },
|
|
]);
|
|
render(vi.fn(), vi.fn(), true);
|
|
await act(async () => { await new Promise((resolve) => setTimeout(resolve, 0)); });
|
|
await click("Select model and effort");
|
|
await click("Choose exact model");
|
|
const options = [...document.querySelectorAll<HTMLButtonElement>('button[role="option"]')]
|
|
.map((item) => item.textContent ?? "");
|
|
expect(options.some((item) => item.includes("gpt-5.5"))).toBe(true);
|
|
expect(options.some((item) => item.includes("gpt-6-sol"))).toBe(true);
|
|
expect(options.some((item) => item.includes("gpt-image"))).toBe(false);
|
|
expect(options.some((item) => item.includes("text-embedding"))).toBe(false);
|
|
expect(document.body.textContent).not.toContain("Loading models…");
|
|
});
|
|
|
|
it("shows an instance-declared Codex model list instead of bundled alternatives", async () => {
|
|
const loadModels = vi.spyOn(agentsApi, "adapterModels").mockResolvedValueOnce([
|
|
{ id: "private-codex", label: "Private Codex" },
|
|
]);
|
|
render(vi.fn(), vi.fn(), true);
|
|
await act(async () => { await new Promise((resolve) => setTimeout(resolve, 0)); });
|
|
expect(loadModels).toHaveBeenCalledWith("company-1", "codex_local", {
|
|
environmentId: null,
|
|
provider: undefined,
|
|
});
|
|
await click("Select model and effort");
|
|
await click("Choose exact model");
|
|
const choices = [...document.querySelectorAll<HTMLButtonElement>('button[role="option"]')]
|
|
.map((item) => item.textContent ?? "");
|
|
expect(choices.some((item) => item.includes("Private Codex"))).toBe(true);
|
|
expect(choices.some((item) => item.includes("GPT-6 Sol"))).toBe(false);
|
|
});
|
|
|
|
it("keeps Copilot discovery passive during reconnect reconciliation and refreshes on opening", async () => {
|
|
const copilot = { ...agent, adapterType: "paperclip_runner", defaultEnvironmentId: "daytona-1",
|
|
adapterConfig: { provider: "acpx", acpxAgent: "copilot", model: "gpt-5.6-luna" } } as Agent;
|
|
const loadModels = vi.spyOn(agentsApi, "adapterModels")
|
|
.mockResolvedValueOnce([{ id: "gpt-5.6-luna", label: "Copilot Luna" }])
|
|
.mockResolvedValue([{ id: "gpt-5.6-luna", label: "Updated Copilot Luna" }]);
|
|
const client = render(vi.fn(), vi.fn(), true, { agents: new Map([[agent.id, copilot]]), settings: null });
|
|
await act(async () => { await new Promise((resolve) => setTimeout(resolve, 0)); });
|
|
expect(loadModels).not.toHaveBeenCalled();
|
|
await act(async () => { await client.invalidateQueries({ type: "active" }, { cancelRefetch: false }); });
|
|
expect(loadModels).not.toHaveBeenCalled();
|
|
await click("Select model and effort");
|
|
expect(loadModels).toHaveBeenCalledTimes(1);
|
|
await act(async () => { await client.invalidateQueries({ type: "active" }, { cancelRefetch: false }); });
|
|
expect(loadModels).toHaveBeenCalledTimes(1);
|
|
await act(async () => {
|
|
document.dispatchEvent(new KeyboardEvent("keydown", { key: "Escape", bubbles: true }));
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
});
|
|
await click("Select model and effort");
|
|
expect(loadModels).toHaveBeenCalledTimes(2);
|
|
await click("Choose exact model");
|
|
expect(document.body.textContent).toContain("Updated Copilot Luna");
|
|
});
|
|
|
|
it("discovers Copilot task models with the assignee connection and environment", async () => {
|
|
const binding = { provider: "github", method: "api_key", mode: "shared", connectionId: "11111111-1111-4111-8111-111111111111", grantId: "33333333-3333-4333-8333-333333333333" } as const;
|
|
const copilot = { ...agent, adapterType: "paperclip_runner", defaultEnvironmentId: "daytona-1",
|
|
adapterConfig: { provider: "acpx", acpxAgent: "copilot", model: "gpt-5.6-luna" },
|
|
runtimeConfig: { aiConnection: binding } } as Agent;
|
|
const loadModels = vi.spyOn(agentsApi, "adapterModels").mockResolvedValueOnce([
|
|
{ id: "gpt-5.6-luna", label: "Copilot Luna" },
|
|
]);
|
|
render(vi.fn(), vi.fn(), true, { agents: new Map([[agent.id, copilot]]), settings: null });
|
|
await act(async () => { await new Promise((resolve) => setTimeout(resolve, 0)); });
|
|
expect(loadModels).not.toHaveBeenCalled();
|
|
await click("Select model and effort");
|
|
expect(loadModels).toHaveBeenCalledWith("company-1", "paperclip_runner", {
|
|
environmentId: "daytona-1", provider: "acpx", poolId: undefined,
|
|
acpxAgent: "copilot", agentId: agent.id, aiConnection: binding,
|
|
});
|
|
await click("Choose exact model");
|
|
expect(document.body.textContent).toContain("Copilot Luna");
|
|
expect(document.body.textContent).not.toContain("Claude Sonnet");
|
|
});
|
|
|
|
it("preserves settings when the selected assignee is chosen again", async () => {
|
|
const onAssigneeChange = vi.fn();
|
|
const onSettingsChange = vi.fn();
|
|
render(onAssigneeChange, onSettingsChange);
|
|
await click("Select assignee");
|
|
await click("Clippy");
|
|
expect(onAssigneeChange).not.toHaveBeenCalled();
|
|
expect(onSettingsChange).not.toHaveBeenCalled();
|
|
expect(document.querySelector('[role="listbox"]')).toBeNull();
|
|
});
|
|
|
|
it("offers No assignee and clears settings when selected", async () => {
|
|
const onAssigneeChange = vi.fn();
|
|
const onSettingsChange = vi.fn();
|
|
render(onAssigneeChange, onSettingsChange);
|
|
await click("Select assignee");
|
|
await click("No assignee");
|
|
expect(onAssigneeChange).toHaveBeenCalledWith("");
|
|
expect(onSettingsChange).toHaveBeenCalledWith(null);
|
|
expect(document.querySelector('[role="listbox"]')).toBeNull();
|
|
});
|
|
|
|
it.each(["", "user:me"])("hides model and effort for %s and opens assignees in one click", async (assigneeValue) => {
|
|
const loadModels = vi.spyOn(agentsApi, "adapterModels");
|
|
render(vi.fn(), vi.fn(), true, {
|
|
assigneeValue,
|
|
currentAssigneeValue: assigneeValue,
|
|
options: [...options, { id: "user:me", label: "Me" }],
|
|
});
|
|
expect(container!.querySelector('[data-testid="task-chat-composer-model-label"]')).toBeNull();
|
|
expect(container!.querySelector('[aria-label="Select model and effort"]')).toBeNull();
|
|
expect(container!.textContent).not.toContain("Harness default");
|
|
expect(container!.textContent).not.toContain("High");
|
|
await click("Select assignee");
|
|
expect(document.querySelector('[aria-label="Search assignees"]')).not.toBeNull();
|
|
expect(document.querySelector('[aria-label="Effort"]')).toBeNull();
|
|
expect(document.querySelector('[aria-label="Choose exact model"]')).toBeNull();
|
|
expect(document.body.textContent).not.toContain("Choose an agent");
|
|
expect(loadModels).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.each([false, true])("hides unsupported Muse settings without loading a catalog (mobile: %s)", async (mobile) => {
|
|
const loadModels = vi.spyOn(agentsApi, "adapterModels").mockResolvedValue([]);
|
|
const onSettingsChange = vi.fn();
|
|
const muse = { ...agent, adapterType: "paperclip_runner", adapterConfig: { provider: "muse", model: "old-model" } } as Agent;
|
|
rememberComposerEffort("company-1", "high");
|
|
render(vi.fn(), onSettingsChange, true, { mobile, settings: null, agents: new Map([[muse.id, muse]]) });
|
|
expect(container!.querySelector('[aria-label="Select model and effort"]')).toBeNull();
|
|
expect(container!.querySelector('[data-testid="task-chat-composer-model-label"]')).toBeNull();
|
|
await click("Select assignee");
|
|
expect(document.querySelector('[aria-label="Search assignees"]')).not.toBeNull();
|
|
expect(document.querySelector('[aria-label="Choose exact model"]')).toBeNull();
|
|
expect(document.querySelector('[aria-label="Effort"]')).toBeNull();
|
|
expect(loadModels).not.toHaveBeenCalled();
|
|
expect(onSettingsChange).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.each([false, true])("removes an open model menu when the same agent switches to Muse (mobile: %s)", async (mobile) => {
|
|
const onSettingsChange = vi.fn();
|
|
function ControlledPicker() {
|
|
const [muse, setMuse] = useState(false);
|
|
const [settings, setSettings] = useState<ComposerRunSettings | null>({ model: "gpt-6-sol", effort: "high", fast: true });
|
|
const selectedAgent = muse
|
|
? { ...agent, adapterType: "paperclip_runner", adapterConfig: { provider: "muse" } } as Agent
|
|
: agent;
|
|
return <>
|
|
<button type="button" aria-label="Switch to Muse" onClick={() => setMuse(true)}>Switch to Muse</button>
|
|
<ComposerRunSettingsPicker companyId="company-1" assigneeValue="agent:a1" currentAssigneeValue="agent:a1"
|
|
options={options} agents={new Map([[agent.id, selectedAgent]])} settings={settings}
|
|
onSettingsChange={(next) => { onSettingsChange(next); setSettings(next); }} onAssigneeChange={vi.fn()} mobile={mobile}
|
|
modelOptionsOverride={[{ id: "gpt-6-sol", label: "GPT-6 Sol" }]} />
|
|
</>;
|
|
}
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
flushSync(() => root!.render(<QueryClientProvider client={new QueryClient()}><ControlledPicker /></QueryClientProvider>));
|
|
await click("Select model and effort");
|
|
await click("Choose exact model");
|
|
expect(document.querySelector('[aria-label="Search or paste a model ID"]')).not.toBeNull();
|
|
await click("Switch to Muse");
|
|
expect(container!.querySelector('[aria-label="Select model and effort"]')).toBeNull();
|
|
expect(document.querySelector('[aria-label="Search or paste a model ID"]')).toBeNull();
|
|
expect(document.querySelector('[aria-label="Choose exact model"]')).toBeNull();
|
|
expect(document.querySelector('[aria-label="Effort"]')).toBeNull();
|
|
expect(document.querySelector('[data-testid="model-unavailable"]')?.textContent).toContain("Muse chooses its model and effort");
|
|
expect(onSettingsChange).toHaveBeenCalledOnce();
|
|
expect(onSettingsChange).toHaveBeenCalledWith(null);
|
|
});
|
|
|
|
it("opens the assignee list directly on mobile", async () => {
|
|
render(vi.fn(), vi.fn(), false, { mobile: true });
|
|
await click("Select assignee");
|
|
expect(document.querySelector('[data-testid="composer-mobile-dialog"]')).not.toBeNull();
|
|
expect(document.querySelector('[aria-label="Search assignees"]')).not.toBeNull();
|
|
expect(document.querySelector('[aria-label="Choose exact model"]')).toBeNull();
|
|
});
|
|
});
|