mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-06 14:02:36 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Native agents use assigned connection tools through a governed gateway. > - OpenCode received the gateway catalog directly, outside the bounded server tool projection. > - A large catalog can exceed a provider grammar compiler's capacity even when it fits the transport limits. > - Synthetic requests reproduced the Fireworks grammar timeout on the configured DeepSeek model. > - This pull request gives OpenCode two assigned-tool discovery and call schemas through the existing server relay. > - The gateway keeps the same grants, validation, approvals, revocation, and audit rules. ## Linked Issues or Issue Description **What happened?** A native OpenCode run could fail during provider grammar compilation before its first assigned-tool call. OpenCode advertised the full assigned gateway catalog. A synthetic catalog of 741 tool schemas reproduced `Grammar processing took too much time` on Fireworks through OpenRouter with `deepseek/deepseek-v4.1-flash-1017`. The same model and backend accepted a compact two-tool discovery/call catalog. This reproduces the mechanism; it does not replay a historical private request. **Expected behavior** Assigned-tool discovery must keep provider grammar size bounded. Every call must retain the run's original gateway binding and permissions. **Steps to reproduce** 1. Give a native OpenCode run a large assigned connection catalog. 2. Use a provider that compiles tool schemas into a constrained output grammar. 3. Observe the full catalog in the provider tool surface before this change. 4. After this change, observe only `paperclip_search_assigned_tools` and `paperclip_call_assigned_tool` for assigned tools. Discover and call a permitted tool through its pinned alias. **Paperclip version or commit** Source checkout based on current `master`. **Deployment mode** Native local or sandbox execution with OpenCode 1.18.34. Related work: Refs #14258 (discovery paging), #16678 (local adapter MCP launch), and #17688 (gateway capability advertisement). This change covers native OpenCode catalog projection. ## What Changed - Route native OpenCode assigned tools through the existing server-owned authenticated relay. - Use bounded discovery/call schemas for OpenCode, including small catalogs. Preserve transport capacity checks. - Keep assigned gateway credentials on the controller. Ignore gateway and credential values in tool arguments. - Preserve exact declared MCP operation names through admission and driver dispatch. Resolve transport prefixes only against the closed catalog. Reject unknown or shortened names. - Refresh former OpenCode direct-catalog and shortened-name checkpoints. Keep the existing fingerprints for other providers. - Add local and remote wiring, catalog capacity, alias, scope, work-mode, approval, and revocation tests. - Allow the native test files to use a validated dedicated external test database when embedded PostgreSQL is unavailable. - Document the assigned-tool execution contract. - Bound OpenCode discovery pages to 32 KiB and large-schema chunks to 16K characters. Keep other harness budgets unchanged. - Test medium pages and escaped large schemas through the actual HTTP MCP bridge on the explicit Runner testing surface. ## Verification - Red before the catalog fix: OpenCode did not create the server relay, and forced compact delivery advertised 1 or 741 direct schemas. - Red before the alias repair: HTTP MCP changed declared operation names, and the driver sent `search_assigned_tools` instead of the authorized `paperclip_search_assigned_tools`. - Current repair tests: 112 OpenCode/proxy tests pass, plus one actual Rust/proxy/HTTP MCP regression. Two checkpoint regressions fail with the former scoped revision and pass with the new revision. Other providers keep their prior fingerprints. - The combined QA candidate with this exact PR head passes all 916 native tests and all 113 transport tests on supported Node 24.22. An earlier Node 26.4/macOS run passed the 113 assertions but had an uncaught networking error. That non-clean run remains recorded; its stack matches [the upstream Undici defect](https://github.com/nodejs/undici/issues/5544). No production workaround or error suppression was added. - `pnpm -r typecheck`, `pnpm build`, and `git diff --check` pass on `bc41ba72be2195eabeb0d7727227ee0cd02e8532`. The maps structural check passes. - The local `pnpm test:run` attempt stopped after host embedded PostgreSQL initialization failures. The relevant database suites pass with isolated PostgreSQL 18. All repository CI gates, including aggregate `ci / verify`, pass on the current head. - Synthetic live provider comparison: 741 invented schemas produced the exact Fireworks grammar timeout in 20.9 seconds. Two compact invented schemas produced a discovery call in 585 ms on the same model and backend. - The first hosted QA attempt exposed the alias failure described above. On the patched source, a real local Rust runner → proxy → OpenCode 1.18.34 → exact DeepSeek smoke completed discovery, one synthetic gateway read, and `paperclip_finish`, then emitted `turn/completed`. It used the production compact projection and unchanged Rust allowlist. - Two earlier local smoke attempts exposed missing terminal authority and completion-contract fields in the smoke harness. Those failures remain recorded. The corrected ordinary bindings produced the clean result. - Fresh Greptile: 5/5 on `bc41ba72be2195eabeb0d7727227ee0cd02e8532`, with no new actionable findings or unresolved threads. - Hosted QA publication and lifecycle acceptance remain pending. The separate deployed-agent `Paperclip Review` check is also pending; it follows a task that failed on the earlier deployed runtime. - Local OpenCode/OpenRouter acceptance at `bc41ba72`: 530 synthetic tools were authorized and installed. A simple model-ID reply completed in 17.3 seconds with no app calls. A discovery task completed in 37.6 seconds, used the search/call relay, made one upstream call, and returned the exact synthetic value. This is local source acceptance, not a staging sandbox timing comparison. - The large-result review finding has a failing-before/passing-after HTTP MCP regression. Five medium schemas now page without invalid JSON. A large schema with escaped text reconstructs exactly through bounded chunks. All 35 assigned-tool tests and the server typecheck pass after this follow-up. - Final head `d84ce4856a6e65a35ad5fb8b561492598b525f4e`: all CI gates pass. Greptile and Paperclip Review both rate the change 5/5. No review threads remain open. The final full build, server typecheck, and 35 assigned-tool tests pass locally. ## Risks - OpenCode uses discovery before it calls an assigned tool, including for small catalogs. This can add a model turn. - An existing OpenCode provider checkpoint rotates once because it retains the former tool declarations. Paperclip task history remains available. - The historical filtered catalog was not captured. The synthetic comparison proves the failure mechanism, not the exact cardinality of an earlier private request. - No model, provider route, permission, or automatic retry policy changes. ## Model Used The bounded-result follow-up also used OpenAI Codex (GPT-6 family). The exact backend model ID and context-window size were not exposed for that session. It used reasoning, code execution, and tool use. OpenAI `gpt-6.1-sol` in Codex, with reasoning, tool use, code execution, and source inspection. The runtime does not expose the context-window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
585 lines
21 KiB
TypeScript
585 lines
21 KiB
TypeScript
import { createHash, randomUUID } from "node:crypto";
|
|
import { isDeepStrictEqual } from "node:util";
|
|
import { and, desc, eq, inArray, ne } from "drizzle-orm";
|
|
import { heartbeatRunEvents, heartbeatRuns, type Db } from "@paperclipai/db";
|
|
import type {
|
|
NativeExecutionInput,
|
|
PersistedNativeSession,
|
|
} from "../../vendor/paperclip-runner/index.js";
|
|
import { canonicalNativeRuntimeContextDigest, parseNativeExecutionInput } from "../../vendor/paperclip-runner/index.js";
|
|
|
|
export type NativeToolExecutionTargetKind = "local" | "remote";
|
|
|
|
/** Fence live ACPX owners when shared runtime semantics change, even if the
|
|
* underlying native executable/profile did not change. Undefined preserves
|
|
* the existing configuration digest for other provider transports.
|
|
*/
|
|
export function nativeRuntimeContractForProvider(
|
|
provider: NativeExecutionInput["provider"],
|
|
): string | undefined {
|
|
return provider.kind === "acpx" ? "paperclip.acpx-runtime-contract.v1" : undefined;
|
|
}
|
|
|
|
/**
|
|
* Persisted provider threads retain their dynamic-tool declarations. This
|
|
* fingerprint is part of checkpoint compatibility and must change whenever
|
|
* the server-authorized native tool definitions or advertisement policy
|
|
* changes. The execution target remains part of compatibility because local and
|
|
* remote files use different server-bound readers.
|
|
*/
|
|
export function nativeToolContractFingerprintForTarget(
|
|
executionTargetKind: NativeToolExecutionTargetKind,
|
|
providerKind?: NativeExecutionInput["provider"]["kind"],
|
|
): string {
|
|
return `sha256:${createHash("sha256")
|
|
.update(
|
|
JSON.stringify({
|
|
schema: "paperclip.native-tool-contract.v17",
|
|
executionTargetKind,
|
|
advertisementPolicy: {
|
|
// Direct provider threads retain declarations from thread/start.
|
|
// Keep this explicit so changing a tool from conditional to stable
|
|
// advertisement rotates checkpoints even when its schema is unchanged.
|
|
readCurrentWakeComments: "always_advertised_binding_gated.v1",
|
|
historicalChatAttachments:
|
|
"always_advertised_conversation_binding_gated.v1",
|
|
registerDeliverable: "verified_local_or_remote_workspace.v2",
|
|
readChatAttachment: "always_advertised_run_scope_local_staging.v1",
|
|
structuredHumanInput:
|
|
"always_advertised_run_issue_agent_binding_gated_current_task_description.v2",
|
|
semanticCompletion: "finish_accessible_deliverable_evidence.v4",
|
|
...(providerKind === "opencode"
|
|
? { opencodeAssignedMcpTools: "server_gateway_prp_on_demand_exact_names.v2" }
|
|
: {}),
|
|
connectorTools: "assigned_resources_and_pinned_skill_bundle.v1",
|
|
chatTaskTools: "durable_task_binding_and_accepted_origin.v1",
|
|
githubResponses: "bound_working_comment_progress_and_final.v1",
|
|
githubInstructionSkills: "trusted_configuration_native_selection.v1",
|
|
...(executionTargetKind === "remote"
|
|
? { assignedMcpTools: "codex_server_gateway_prp_relay.v1" }
|
|
: {}),
|
|
},
|
|
tools: [
|
|
{ name: "register_deliverable", version: 2 },
|
|
{
|
|
name: "read_current_wake_comments",
|
|
semanticContract: "paperclip.server-current-wake-comments.v1",
|
|
version: 1,
|
|
},
|
|
{
|
|
name: "list_chat_attachments",
|
|
semanticContract: "paperclip.server-chat-attachment-reuse.v1",
|
|
version: 1,
|
|
},
|
|
{
|
|
name: "reuse_chat_attachment",
|
|
semanticContract: "paperclip.server-chat-attachment-reuse.v1",
|
|
version: 1,
|
|
},
|
|
{
|
|
name: "read_chat_attachment",
|
|
semanticContract: "paperclip.server-chat-attachment-read.v1",
|
|
version: 1,
|
|
},
|
|
{ name: "request_human_input", version: 1 },
|
|
],
|
|
}),
|
|
)
|
|
.digest("hex")}`;
|
|
}
|
|
|
|
/** Default local-target fingerprint retained for callers and test fixtures. */
|
|
export const NATIVE_TOOL_CONTRACT_FINGERPRINT =
|
|
nativeToolContractFingerprintForTarget("local");
|
|
|
|
function record(value: unknown): Record<string, unknown> {
|
|
return typeof value === "object" && value !== null && !Array.isArray(value)
|
|
? (value as Record<string, unknown>)
|
|
: {};
|
|
}
|
|
|
|
export function isNativeSessionId(value: unknown): value is string {
|
|
return (
|
|
typeof value === "string" &&
|
|
/^[0-9a-f]{8}-[0-9a-f]{4}-[1-5][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i.test(
|
|
value,
|
|
)
|
|
);
|
|
}
|
|
|
|
const LEGACY_RETRY_SOURCE_TERMINAL_STATUSES = new Set([
|
|
"succeeded",
|
|
"interrupted",
|
|
"failed",
|
|
"cancelled",
|
|
"timed_out",
|
|
]);
|
|
|
|
export type NativeSessionBootstrapState = {
|
|
processPid: number | null;
|
|
processGroupId: number | null;
|
|
processStartedAt: Date | null;
|
|
runnerProfileJson: unknown;
|
|
};
|
|
|
|
export function isUnusedNativeSessionBootstrap(
|
|
run: NativeSessionBootstrapState,
|
|
hasProviderEvents: boolean,
|
|
): boolean {
|
|
return (
|
|
run.processPid === null &&
|
|
run.processGroupId === null &&
|
|
run.processStartedAt === null &&
|
|
record(run.runnerProfileJson).sessionCheckpoint == null &&
|
|
!hasProviderEvents
|
|
);
|
|
}
|
|
|
|
/** Newest-first rows for one exact task/session; never skip provider progress. */
|
|
export function selectNativeSessionResumeRun<
|
|
T extends NativeSessionBootstrapState & {
|
|
id: string;
|
|
companyId: string;
|
|
agentId: string;
|
|
nativeIssueId: string | null;
|
|
nativeSessionId: string | null;
|
|
runtimeMode: string | null;
|
|
status: string;
|
|
createdAt: Date;
|
|
},
|
|
>(input: {
|
|
runs: readonly T[];
|
|
companyId: string;
|
|
agentId: string;
|
|
issueId: string;
|
|
normalizedSessionId: string;
|
|
currentRunId: string;
|
|
beforeCreatedAt: Date;
|
|
providerEvidenceRunIds: ReadonlySet<string>;
|
|
}): T | null {
|
|
for (const run of input.runs) {
|
|
if (
|
|
run.id === input.currentRunId ||
|
|
run.companyId !== input.companyId ||
|
|
run.agentId !== input.agentId ||
|
|
run.nativeIssueId !== input.issueId ||
|
|
run.nativeSessionId !== input.normalizedSessionId
|
|
)
|
|
continue;
|
|
if (
|
|
run.runtimeMode !== "native" ||
|
|
!LEGACY_RETRY_SOURCE_TERMINAL_STATUSES.has(run.status)
|
|
)
|
|
return null;
|
|
// Even an incompatible checkpoint is a progress barrier. The caller must
|
|
// reject it or start a fresh session, not fall back to an older checkpoint.
|
|
if (record(run.runnerProfileJson).sessionCheckpoint != null)
|
|
return run.createdAt > input.beforeCreatedAt ? null : run;
|
|
if (
|
|
!isUnusedNativeSessionBootstrap(
|
|
run,
|
|
input.providerEvidenceRunIds.has(run.id),
|
|
)
|
|
)
|
|
return null;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
export async function nativeSessionProviderEvidence(
|
|
db: Pick<Db, "select">,
|
|
runIds: string[],
|
|
): Promise<Set<string>> {
|
|
if (!runIds.length) return new Set();
|
|
const rows = await db
|
|
.select({ runId: heartbeatRunEvents.runId })
|
|
.from(heartbeatRunEvents)
|
|
.where(
|
|
and(
|
|
inArray(heartbeatRunEvents.runId, runIds),
|
|
inArray(heartbeatRunEvents.eventType, [
|
|
"harness.ready",
|
|
"session.started",
|
|
"session.resumed",
|
|
"session.updated",
|
|
"turn.started",
|
|
"provider.event",
|
|
"provider.rpc_result",
|
|
]),
|
|
),
|
|
)
|
|
.groupBy(heartbeatRunEvents.runId);
|
|
return new Set(rows.map((row) => row.runId));
|
|
}
|
|
|
|
export async function findNativeSessionResumeRun(
|
|
db: Db,
|
|
input: {
|
|
companyId: string;
|
|
agentId: string;
|
|
issueId: string;
|
|
normalizedSessionId: string;
|
|
currentRunId: string;
|
|
beforeCreatedAt: Date;
|
|
},
|
|
) {
|
|
if (!isNativeSessionId(input.normalizedSessionId)) return null;
|
|
const runs = await db
|
|
.select({
|
|
id: heartbeatRuns.id,
|
|
companyId: heartbeatRuns.companyId,
|
|
agentId: heartbeatRuns.agentId,
|
|
runnerInstanceId: heartbeatRuns.runnerInstanceId,
|
|
nativeSessionId: heartbeatRuns.nativeSessionId,
|
|
nativeIssueId: heartbeatRuns.nativeIssueId,
|
|
runtimeMode: heartbeatRuns.runtimeMode,
|
|
status: heartbeatRuns.status,
|
|
createdAt: heartbeatRuns.createdAt,
|
|
processPid: heartbeatRuns.processPid,
|
|
processGroupId: heartbeatRuns.processGroupId,
|
|
processStartedAt: heartbeatRuns.processStartedAt,
|
|
runnerProfileJson: heartbeatRuns.runnerProfileJson,
|
|
contextSnapshot: heartbeatRuns.contextSnapshot,
|
|
})
|
|
.from(heartbeatRuns)
|
|
.where(
|
|
and(
|
|
ne(heartbeatRuns.id, input.currentRunId),
|
|
eq(heartbeatRuns.companyId, input.companyId),
|
|
eq(heartbeatRuns.agentId, input.agentId),
|
|
eq(heartbeatRuns.nativeIssueId, input.issueId),
|
|
eq(heartbeatRuns.nativeSessionId, input.normalizedSessionId),
|
|
),
|
|
)
|
|
.orderBy(desc(heartbeatRuns.createdAt), desc(heartbeatRuns.id))
|
|
.limit(32);
|
|
return selectNativeSessionResumeRun({
|
|
...input,
|
|
runs,
|
|
providerEvidenceRunIds: await nativeSessionProviderEvidence(
|
|
db,
|
|
runs.map((run) => run.id),
|
|
),
|
|
});
|
|
}
|
|
|
|
/** A preassigned session id may rotate only before immutable native admission. */
|
|
export function nativeSessionIdForBootstrapPersistence(input: {
|
|
run: NativeSessionBootstrapState & { nativeSessionId: string | null };
|
|
selectedSessionId: string;
|
|
hasProviderEvents: boolean;
|
|
}): string {
|
|
if (input.run.nativeSessionId === input.selectedSessionId)
|
|
return input.selectedSessionId;
|
|
if (
|
|
record(input.run.runnerProfileJson).nativeExecutionInput !== undefined ||
|
|
!isUnusedNativeSessionBootstrap(input.run, input.hasProviderEvents)
|
|
) {
|
|
throw new Error("native_session_bootstrap_identity_conflict");
|
|
}
|
|
return input.selectedSessionId;
|
|
}
|
|
|
|
/** Caller holds the run row lock; recheck authority after waiting for that lock. */
|
|
export async function prepareNativeSessionBootstrapPersistence(
|
|
db: Pick<Db, "select">,
|
|
input: {
|
|
run: NativeSessionBootstrapState & {
|
|
id: string;
|
|
nativeSessionId: string | null;
|
|
};
|
|
selectedSessionId: string;
|
|
execution: NativeExecutionInput;
|
|
restoringCheckpoint: boolean;
|
|
},
|
|
) {
|
|
const hasProviderEvents = (
|
|
await nativeSessionProviderEvidence(db, [input.run.id])
|
|
).has(input.run.id);
|
|
const profile = record(input.run.runnerProfileJson);
|
|
if (
|
|
profile.nativeExecutionInput !== undefined &&
|
|
!isDeepStrictEqual(
|
|
parseNativeExecutionInput(profile.nativeExecutionInput),
|
|
input.execution,
|
|
)
|
|
) {
|
|
throw new Error("native_execution_input_persisted_binding_mismatch");
|
|
}
|
|
if (
|
|
input.restoringCheckpoint &&
|
|
!isUnusedNativeSessionBootstrap(input.run, hasProviderEvents)
|
|
) {
|
|
throw new Error("native_session_bootstrap_identity_conflict");
|
|
}
|
|
return nativeSessionIdForBootstrapPersistence({
|
|
...input,
|
|
hasProviderEvents,
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Legacy compatibility is deliberately narrower than ordinary task-session
|
|
* continuation: only a replacement row that never acquired any native process
|
|
* or provider authority may be rebound to a terminal native source. The exact
|
|
* checkpoint/session/workspace/provider binding is validated separately by
|
|
* rebindNativeSessionCheckpoint.
|
|
*/
|
|
export function isUnusedLegacyNativeRetryReplacement(input: {
|
|
replacement: {
|
|
processPid: number | null;
|
|
processGroupId: number | null;
|
|
processStartedAt: Date | null;
|
|
runnerProfileJson: unknown;
|
|
};
|
|
source: {
|
|
runtimeMode: string | null;
|
|
status: string;
|
|
nativeSessionId: string | null;
|
|
} | null;
|
|
hasProviderEvents: boolean;
|
|
}): boolean {
|
|
return Boolean(
|
|
input.source?.runtimeMode === "native" &&
|
|
LEGACY_RETRY_SOURCE_TERMINAL_STATUSES.has(input.source.status) &&
|
|
isNativeSessionId(input.source.nativeSessionId) &&
|
|
isUnusedNativeSessionBootstrap(input.replacement, input.hasProviderEvents),
|
|
);
|
|
}
|
|
|
|
function sameProvider(
|
|
previous: NativeExecutionInput["provider"],
|
|
current: NativeExecutionInput["provider"],
|
|
): boolean {
|
|
return JSON.stringify(previous) === JSON.stringify(current);
|
|
}
|
|
|
|
function nativeCheckpointWorkspaceScope(
|
|
execution: NativeExecutionInput,
|
|
owningRunId: string,
|
|
) {
|
|
// Projectless work uses each heartbeat run id as a placeholder workspace id.
|
|
// Continuity is safe only when both sides independently prove that shape and
|
|
// their complete immutable workspace descriptors match. A real managed
|
|
// workspace instead binds continuity to its durable workspace row id.
|
|
return execution.binding.executionWorkspaceId === owningRunId
|
|
? {
|
|
kind: "transient" as const,
|
|
cwd: execution.workspace.cwd,
|
|
repoUrl: execution.workspace.repoUrl,
|
|
repoRef: execution.workspace.repoRef,
|
|
branchName: execution.workspace.branchName,
|
|
}
|
|
: {
|
|
kind: "managed" as const,
|
|
id: execution.binding.executionWorkspaceId,
|
|
};
|
|
}
|
|
|
|
function sameWorkspaceScope(input: {
|
|
previousExecution: NativeExecutionInput;
|
|
previousRunId: string;
|
|
currentExecution: NativeExecutionInput;
|
|
}): boolean {
|
|
return (
|
|
JSON.stringify(
|
|
nativeCheckpointWorkspaceScope(
|
|
input.previousExecution,
|
|
input.previousRunId,
|
|
),
|
|
) ===
|
|
JSON.stringify(
|
|
nativeCheckpointWorkspaceScope(
|
|
input.currentExecution,
|
|
input.currentExecution.binding.runId,
|
|
),
|
|
)
|
|
);
|
|
}
|
|
|
|
/** A resume delta is valid only if the provider checkpoint really can be used. */
|
|
export function buildNativeExecutionWithCheckpoint(input: {
|
|
previousRun:
|
|
Parameters<typeof rebindNativeSessionCheckpoint>[0]["previousRun"] | null;
|
|
normalizedSessionId: string;
|
|
executionTargetKind?: NativeToolExecutionTargetKind;
|
|
toolRefreshOnResume?: boolean;
|
|
refreshTools?: boolean;
|
|
buildExecution: (options: {
|
|
normalizedSessionId: string;
|
|
resumedSession: boolean;
|
|
}) => NativeExecutionInput;
|
|
}): {
|
|
execution: NativeExecutionInput;
|
|
checkpoint: PersistedNativeSession | null;
|
|
normalizedSessionId: string;
|
|
} {
|
|
const execution = input.buildExecution({
|
|
normalizedSessionId: input.normalizedSessionId,
|
|
resumedSession: input.previousRun !== null,
|
|
});
|
|
// A presentation-only upgrade must not rotate a healthy provider session or
|
|
// lose a durable goal. Keep its v4/v5 format until that session naturally ends.
|
|
// All ordinary identity, workspace, provider, tool and recovery checks still apply.
|
|
if (input.previousRun && (execution.schema === "paperclip.native-execution-input.v4" || execution.schema === "paperclip.native-execution-input.v5")) {
|
|
const previousSchema = record(record(input.previousRun.runnerProfileJson).nativeExecutionInput).schema;
|
|
if ((previousSchema === "paperclip.native-execution-input.v4" || previousSchema === "paperclip.native-execution-input.v5") && previousSchema !== execution.schema) {
|
|
const { completionSources: _sources, ...common } = execution as typeof execution & { completionSources?: unknown };
|
|
const retainedFormat = parseNativeExecutionInput({ ...common, schema: previousSchema });
|
|
const retainedCheckpoint = rebindNativeSessionCheckpoint({
|
|
previousRun: input.previousRun,
|
|
currentExecution: retainedFormat,
|
|
executionTargetKind: input.executionTargetKind,
|
|
toolRefreshOnResume: input.toolRefreshOnResume,
|
|
refreshTools: input.refreshTools,
|
|
});
|
|
if (retainedCheckpoint) return { execution: retainedFormat, checkpoint: retainedCheckpoint, normalizedSessionId: input.normalizedSessionId };
|
|
}
|
|
}
|
|
const checkpoint = input.previousRun
|
|
? rebindNativeSessionCheckpoint({
|
|
previousRun: input.previousRun,
|
|
currentExecution: execution,
|
|
executionTargetKind: input.executionTargetKind,
|
|
toolRefreshOnResume: input.toolRefreshOnResume,
|
|
refreshTools: input.refreshTools,
|
|
})
|
|
: null;
|
|
if (checkpoint)
|
|
return {
|
|
execution,
|
|
checkpoint,
|
|
normalizedSessionId: input.normalizedSessionId,
|
|
};
|
|
// Rebuild both task context and wake instructions. Merely rotating the ID
|
|
// leaves a fresh provider with a compact delta and missing task context.
|
|
const normalizedSessionId = randomUUID();
|
|
return {
|
|
execution: input.buildExecution({
|
|
normalizedSessionId,
|
|
resumedSession: false,
|
|
}),
|
|
checkpoint: null,
|
|
normalizedSessionId,
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Rebind a completed prior run's provider checkpoint to a new heartbeat run.
|
|
* The provider/driver session identity is retained, while every per-turn and
|
|
* per-event field is reset so the new run starts one clean turn via resume.
|
|
*/
|
|
export function rebindNativeSessionCheckpoint(input: {
|
|
previousRun: {
|
|
id: string;
|
|
companyId: string;
|
|
agentId: string;
|
|
nativeSessionId: string | null;
|
|
runnerProfileJson: unknown;
|
|
};
|
|
currentExecution: NativeExecutionInput;
|
|
executionTargetKind?: NativeToolExecutionTargetKind;
|
|
toolRefreshOnResume?: boolean;
|
|
refreshTools?: boolean;
|
|
}): PersistedNativeSession | null {
|
|
if (input.refreshTools && input.toolRefreshOnResume !== true) return null;
|
|
const previousProfile = record(input.previousRun.runnerProfileJson);
|
|
if (
|
|
previousProfile.nativeToolContractFingerprint !==
|
|
nativeToolContractFingerprintForTarget(input.executionTargetKind ?? "local", input.currentExecution.provider.kind)
|
|
) {
|
|
return null;
|
|
}
|
|
const rawCheckpoint = record(previousProfile.sessionCheckpoint);
|
|
const checkpointIdentity = record(rawCheckpoint.identity);
|
|
const current = input.currentExecution;
|
|
const normalizedSessionId = current.session.normalizedSessionId;
|
|
if (
|
|
!isNativeSessionId(normalizedSessionId) ||
|
|
input.previousRun.companyId !== current.binding.companyId ||
|
|
input.previousRun.agentId !== current.binding.agentId ||
|
|
input.previousRun.nativeSessionId !== normalizedSessionId ||
|
|
typeof rawCheckpoint.sessionId !== "string" ||
|
|
checkpointIdentity.runId !== input.previousRun.id ||
|
|
checkpointIdentity.companyId !== current.binding.companyId ||
|
|
checkpointIdentity.issueId !== current.binding.issueId ||
|
|
checkpointIdentity.agentId !== current.binding.agentId ||
|
|
checkpointIdentity.sessionId !== normalizedSessionId
|
|
)
|
|
return null;
|
|
|
|
let previousExecution: NativeExecutionInput;
|
|
try {
|
|
previousExecution = parseNativeExecutionInput(
|
|
previousProfile.nativeExecutionInput,
|
|
);
|
|
} catch {
|
|
return null;
|
|
}
|
|
if (
|
|
previousExecution.binding.runId !== input.previousRun.id ||
|
|
previousExecution.binding.companyId !== current.binding.companyId ||
|
|
previousExecution.binding.issueId !== current.binding.issueId ||
|
|
previousExecution.binding.agentId !== current.binding.agentId ||
|
|
previousExecution.session.normalizedSessionId !== normalizedSessionId ||
|
|
previousExecution.session.driverKind !== current.session.driverKind ||
|
|
!sameWorkspaceScope({
|
|
previousExecution,
|
|
previousRunId: input.previousRun.id,
|
|
currentExecution: current,
|
|
}) ||
|
|
previousExecution.task.workMode !== current.task.workMode ||
|
|
("executionMode" in previousExecution
|
|
? previousExecution.executionMode
|
|
: "default") !==
|
|
("executionMode" in current ? current.executionMode : "default") ||
|
|
!sameProvider(previousExecution.provider, current.provider) ||
|
|
previousExecution.schema !== current.schema ||
|
|
("homeMode" in previousExecution ? previousExecution.homeMode : "isolated") !== ("homeMode" in current ? current.homeMode : "isolated") ||
|
|
("runtimeContext" in previousExecution &&
|
|
"runtimeContext" in current &&
|
|
previousExecution.runtimeContext.aggregateDigest !== current.runtimeContext.aggregateDigest &&
|
|
!(input.toolRefreshOnResume === true &&
|
|
canonicalNativeRuntimeContextDigest({
|
|
...previousExecution.runtimeContext,
|
|
mcp: current.runtimeContext.mcp,
|
|
}) === current.runtimeContext.aggregateDigest))
|
|
)
|
|
return null;
|
|
|
|
const priorSemanticResult = record(rawCheckpoint.semanticResult);
|
|
const priorContinuation = record(priorSemanticResult.continuation);
|
|
const rawGoal = rawCheckpoint.goal;
|
|
const hasUnfinishedGoal =
|
|
rawGoal !== null &&
|
|
rawGoal !== undefined &&
|
|
record(rawGoal).status !== "complete";
|
|
const providerRecoveryPolicy = hasUnfinishedGoal
|
|
? ("same_session_only" as const)
|
|
: !input.refreshTools && priorSemanticResult.reportedWorkDisposition === "yielded" &&
|
|
priorContinuation.kind === "response_wake"
|
|
? ("allow_replacement_after_governed_wait" as const)
|
|
: ("allow_replacement_after_resume_failure" as const);
|
|
|
|
return {
|
|
...(structuredClone(rawCheckpoint) as unknown as PersistedNativeSession),
|
|
identity: {
|
|
runId: current.binding.runId,
|
|
sessionId: normalizedSessionId,
|
|
companyId: current.binding.companyId,
|
|
issueId: current.binding.issueId,
|
|
agentId: current.binding.agentId,
|
|
},
|
|
cursor: null,
|
|
semanticResult: null,
|
|
terminal: null,
|
|
activeTurnId: null,
|
|
terminalTurns: [],
|
|
pendingRuntimeRequests: [],
|
|
// Settlement evidence belongs to the prior heartbeat run, even when the
|
|
// provider session is reused for the user's response.
|
|
governedWait: undefined,
|
|
providerRecoveryPolicy,
|
|
};
|
|
}
|