mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-16 20:12:20 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat eval catalog checks real chat journeys against saved product state > - Full cohort 12 (OpenCode with `openrouter/deepseek/deepseek-v4.1-flash-1017`) failed three cases where the agent did the correct thing > - In each case the harness, not the product, broke the journey: it left a page too early, could not answer a choice card, or pressed keys faster than the drag library listens > - A harness that breaks the journey cannot measure the product > - This pull request makes the harness act like a person in these three journeys, counts a verified card choice as a human action, and keeps each check able to fail a broken product > - The benefit is that these three cases measure the product again ## Linked Issues or Issue Description **What happened?** In full cohort 12, three cases failed for harness reasons: - `agents.choose-primary`: the CEO answered correctly. The harness clicked the crown and confirmed. Then it waited for "My primary agent" with `.first()`. The sidebar already showed the CEO's crown, so this wait passed at once. The harness then navigated away before the browser sent `PUT /primary-agent/me`. The server log has no PUT. The read-back still showed the CEO. - `tasks.ambiguous-task`: the CEO changed nothing and asked a correct question card. The card linked both tasks and offered "COM-1 (Launch project)", "COM-2 (Experiments project)" and "Both tasks". The harness could only answer with a text box or an "Other" option. It threw "The linked question has no supported explicit clarification input". - `steering.edit-queued-message`: the person's edit saved (PATCH 200). The keyboard reorder (Space, ArrowUp, Space) sent no `PUT /queued-comments/order` in 2 gestures. Cohort 9 had the same failure. **Expected behavior** Each journey completes as a person does it, and the oracle grades the saved result. **Steps to reproduce** 1. Use master `f7ddab8e94`. 2. Run the Runner Full-Stack E2E workflow with `all=false` and the three case ids `chat-features.runner-opencode.local.<case>`. 3. Read each case's `playwright.log` and `server.log`. **Additional context** - Primary agent: the crown fills at once (optimistic update) and the save starts on confirm. The mutation lives in the app-level `PrimaryAgentProvider`, so in-app navigation does not cancel it. In the failed run the confirm and the full-page `goto` happened within the same second, and the PUT never reached the server. Only a full page load in the first milliseconds can lose the save. A person cannot do that in practice, so this is not a product bug. No UI change. - Keyboard reorder: dnd-kit's `KeyboardSensor` starts the drag on Space, adds its keydown listener in a `setTimeout`, and `sortableKeyboardCoordinates` ignores arrows until the rows are measured on a later render. Keys pressed back to back can arrive before this. In the production Storybook story (headless Chromium), back-to-back `locator.press` moved the item in 6 of 8 tries. Keys about 150 ms apart moved it 5 of 5 times, also after an Edit and Save. With the drag-start wait and a paint between keys it moved 16 of 16 times, also at 6x CPU throttle. The keyboard reorder works for people, so this is not a product bug. No UI change. ## What Changed - `runtime-primary.ts`: wait for the browser's own `PUT /primary-agent/me` that names Morgan, require 2xx, and poll the read-back until Morgan is primary before leaving the page. Look for the "My primary agent" crown only in the header that holds Morgan's avatar. Add `isPrimarySaveRequest`. Oracle `runtime-primary.v6`. - `chat-linked-question.ts` / `internal-tasks.ts`: add `chosenTaskOption`. It finds the one option of the bound saved question that names the Launch task's identifier (a setup literal) and no other candidate's. It uses the option id for the rendered DOM id and the payload's submit label. It does not read option wording. The harness selects that option, checks `aria-checked`, submits, and waits for the `respond` POST. The old text and "Other" paths stay for other cards. The checks that nothing changes before the answer and that only COM-1 changes after it are unchanged. - `chat-catalog-contract.ts` / `internal-tasks.ts`: a chosen option saves no comment, so the flow counted only one human action and failed `catalog-original-human-query`. `tasks.ambiguous-task` now joins the cases that may count a bound UI answer. The case declares `expectedHumanQuestionAnswer` only after the harness answered through the choice, and names the chosen question and option. The flow then verifies the answered card independently: answered by this person, exactly the Launch option and no typed text, one audit event, and one continuation run after it. Oracle `internal.ambiguous-task.v8`. - `chat-catalog-contract.ts`: `chatCatalogHumanQuestionPolicies` takes the answering person and mirrors the server's user rule in `evaluateIssueThreadInteractionResolverAudience`. `anyone` and `human_only` admit the person. `not_creator` admits a person who did not create the card. With no resolver (a pending card) `not_creator` stays rejected, so other callers keep their behavior. For the ambiguous-task choice, an unaddressed card is accepted, as the server allows. - `runtime-queue.ts`: `keyboardMoveQueuedMessageUp` waits for the handle's `aria-pressed="true"` after Space. It lets the page paint before ArrowUp and before the closing Space. It records whether each gesture started a drag. Oracle `edit-queued-message.structural.v7`. - No scenario YAML changed, so the TestOps manifest needs no entry. ## Verification - `npx vitest run --config tests/runner-e2e/vitest.config.ts` for `chat-linked-question.test.ts`, `chat-catalog-consistency.test.ts`, `runtime-primary.test.ts`, `runtime-queue.test.ts`, `internal.test.ts`, `external-company-secret.test.ts`, `external-personal-secret.test.ts`, `turn-response-card.test.ts`, `runtime-task-coordination.test.ts`: pass. - Red/green: the two new keyboard tests fail on the old `keyboardMoveQueuedMessageUp` and pass on the new one. The resolver-policy test fails on the old `chatCatalogHumanQuestionPolicies` (`not_creator` answered by a person who is not the creator) and passes on the new one; `not_creator` answered by its creator and a pending card stay rejected. The choice-accounting test fails on the old allow list. - `chosenTaskOption` tests use the cohort 12 card shape, a reworded card, and cards with no single choice (both, duplicate, neither, `COM-10`, a different card). - `npx tsc -p tests/runner-e2e/tsconfig.json --noEmit`: pass. `node --test tests/runner-e2e/chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - Paid narrow run 1 (commit `33399f8370`): https://github.com/paperclipai/paperclip/actions/runs/43446445525. `agents.choose-primary` passed (browser `PUT /primary-agent/me` 200). `steering.edit-queued-message` passed (browser `PUT /queued-comments/order` 200). `tasks.ambiguous-task` selected COM-1 (`respond` 200, only COM-1 became high) but failed `catalog-original-human-query`, because the flow did not count the choice. Later commits fix that. - Paid narrow run 2 (`c90c2aa26a`) was cancelled by run 3 before its case finished. - Paid narrow run 3 (`tasks.ambiguous-task` only, final verifier `fee3bbd453`): https://github.com/paperclipai/paperclip/actions/runs/43452010284 ## Risks - Low risk. Test harness only. - The ambiguous-task harness now answers through a structured choice when one exists. If the agent asks a card with no option that names only the Launch task, the old text and "Other" paths still apply. - `chatCatalogHumanQuestionPolicies` accepts `not_creator` only when a resolver is passed. Callers that check pending cards pass none, so their behavior is unchanged. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, via Claude Code with tool use and code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
117 lines
10 KiB
TypeScript
117 lines
10 KiB
TypeScript
// @vitest-environment jsdom
|
|
import { afterEach, beforeEach, expect, it, vi } from "vitest";
|
|
import { chosenTaskOption, linkedQuestionBinding, readLinkedQuestionDom } from "./chat-linked-question.js";
|
|
import { valid, dom, type Input } from "./chat-linked-question.test-fixture.js";
|
|
|
|
beforeEach(() => { document.body.innerHTML = dom(); vi.spyOn(Element.prototype, "getClientRects").mockReturnValue([{ width: 20, height: 20 }] as unknown as DOMRectList); });
|
|
afterEach(() => vi.restoreAllMocks());
|
|
const collect = (input = valid()) => { const bound = linkedQuestionBinding(input); return bound && readLinkedQuestionDom(bound); };
|
|
it("collects an actual production question takeover's two visible saved-task links with no ordinary reply", () => {
|
|
expect(document.querySelectorAll('[id^="comment-"] a')).toHaveLength(0);
|
|
const evidence = collect();
|
|
expect(evidence?.links).toEqual(["/RUN/issues/RUN-1", "/RUN/issues/experiment-task"]);
|
|
expect(evidence?.text).toBe("Which Landing page task should be High priority?");
|
|
expect(evidence).toMatchObject({ interactionId: "question", questionId: "which-task", anchorCommentId: "human", sourceRunId: "run", leadId: "ceo" });
|
|
});
|
|
it("keeps supported unprefixed issue hrefs with exact saved identities and current company page binding", () => {
|
|
const input = valid();
|
|
input.interactions[0]!.payload.questionSet!.description = "Choose [Launch](/issues/launch-task) or [Experiments](/issues/experiment-task).";
|
|
const anchors = document.querySelectorAll("a");
|
|
anchors[0]!.setAttribute("href", "/issues/launch-task"); anchors[1]!.setAttribute("href", "/issues/experiment-task");
|
|
expect(collect(input)?.links).toEqual(["/issues/launch-task", "/issues/experiment-task"]);
|
|
for (const pageUrl of ["https://fixture.test/OTHER/chats/ceo", "https://foreign.test/RUN/chats/ceo", "https://fixture.test/chats/ceo"]) {
|
|
input.pageUrl = pageUrl; expect(collect(input)).toBeUndefined();
|
|
}
|
|
});
|
|
it.each([
|
|
"Choose [Launch][launch] or [Experiments][experiments].\n\n[launch]: /RUN/issues/RUN-1\n[experiments]: /RUN/issues/experiment-task",
|
|
"Choose [Launch](/RUN/issues/RUN-1) or [Experiments](/RUN/issues/experiment-task). Context: [Launch project](/RUN/projects/launch).",
|
|
])("reads actual rendered task hrefs without a second Markdown spelling or context policy: %s", description => {
|
|
const input = valid(); input.interactions[0]!.payload.questionSet!.description = description;
|
|
document.querySelector('[aria-label="Question context"]')!.insertAdjacentHTML("beforeend", '<a href="/RUN/projects/launch">Launch project</a><a href="https://docs.example.test/context">Context</a>');
|
|
expect(collect(input)?.links).toEqual(["/RUN/issues/RUN-1", "/RUN/issues/experiment-task"]);
|
|
});
|
|
it.each([
|
|
["wrong company", (v: Input) => { v.interactions[0]!.companyId = "foreign"; }],
|
|
["wrong conversation", (v: Input) => { v.interactions[0]!.issueId = "other-source"; }],
|
|
["wrong CEO", (v: Input) => { v.interactions[0]!.createdByAgentId = "another-agent"; }],
|
|
["human-created card", (v: Input) => { v.interactions[0]!.createdByUserId = "person"; }],
|
|
["wrong run", (v: Input) => { v.interactions[0]!.sourceRunId = "old-run"; }],
|
|
["stale card", (v: Input) => { v.interactions[0]!.createdAt = "2026-10-27T12:00:00Z"; }],
|
|
["future card", (v: Input) => { v.interactions[0]!.createdAt = "2026-10-29T12:00:00Z"; }],
|
|
["resolved card", (v: Input) => { v.interactions[0]!.status = "accepted"; }],
|
|
["dismissed card", (v: Input) => { v.interactions[0]!.dismissedAt = "2026-10-28T12:00:40Z"; }],
|
|
["wrong addressed person", (v: Input) => { v.interactions[0]!.addresseeUserId = "other"; }],
|
|
["agent addressed", (v: Input) => { v.interactions[0]!.addresseeAgentId = "ceo"; }],
|
|
["invalid resolver", (v: Input) => { v.interactions[0]!.effectiveResolverPolicy = "invalid" as never; }],
|
|
["wrong origin question", (v: Input) => { v.interactions[0]!.originCommentIds = ["old-human"]; }],
|
|
["foreign origin comment", (v: Input) => { v.interactions[0]!.originCommentIds!.push("foreign-comment"); }],
|
|
["wrong source comment", (v: Input) => { v.interactions[0]!.sourceCommentId = "other-human"; }],
|
|
["missing create action", (v: Input) => { v.observation.activity = []; }],
|
|
["wrong create actor", (v: Input) => { v.observation.activity[0]!.actorId = "other"; }],
|
|
["wrong create company", (v: Input) => { v.observation.activity[0]!.companyId = "foreign"; }],
|
|
["wrong action run", (v: Input) => { Object.assign(v.observation.activity[0]!, { runId: "old-run" }); }],
|
|
["wrong action resource kind", (v: Input) => { Object.assign(v.observation.activity[0]!, { entityType: "project" }); }],
|
|
["wrong action question", (v: Input) => { v.observation.activity[0]!.details!.interactionId = "other"; }],
|
|
["wrong action kind", (v: Input) => { v.observation.activity[0]!.details!.interactionKind = "request_confirmation"; }],
|
|
["legacy run", (v: Input) => { v.observation.runs[0]!.runtimeMode = "legacy"; }],
|
|
["unrelated run issue", (v: Input) => { v.observation.runs[0]!.contextSnapshot = { issueId: "other" }; }],
|
|
["foreign saved task", (v: Input) => { v.tasks[0]!.companyId = "foreign"; }],
|
|
["wrong actual task", (v: Input) => { v.observation.tasks[0]!.id = "other"; }],
|
|
["duplicate saved task", (v: Input) => { v.tasks[1] = v.tasks[0]!; }],
|
|
["old human request", (v: Input) => { v.comments[0]!.body = "another query"; }],
|
|
["nonhuman original request", (v: Input) => { v.comments[0]!.authorAgentId = "ceo"; }],
|
|
["missing linked context", (v: Input) => { v.interactions[0]!.payload.questionSet!.description = ""; }],
|
|
["another native action", (v: Input) => { v.interactions.push(structuredClone(v.interactions[0]!)); }],
|
|
] as const)("rejects %s metadata rather than any question-card presence", (_, change) => {
|
|
const input = valid(); change(input); expect(collect(input)).toBeUndefined();
|
|
});
|
|
it.each([
|
|
["foreign company", "/OTHER/issues/RUN-1"], ["foreign origin", "https://foreign.test/RUN/issues/RUN-1"], ["wrong task", "/RUN/issues/wrong"],
|
|
["task search", "/RUN/issues?search=RUN-1"], ["fragment", "/RUN/issues/RUN-1#unrelated"],
|
|
] as const)("rejects %s saved question link", (_, href) => {
|
|
const input = valid(); input.interactions[0]!.payload.questionSet!.description = input.interactions[0]!.payload.questionSet!.description!.replace("/RUN/issues/RUN-1", href);
|
|
document.querySelector("a")!.setAttribute("href", href);
|
|
expect(collect(input)).toBeUndefined();
|
|
});
|
|
const domNegatives: Array<[string, () => void]> = [
|
|
["missing exact interaction", () => document.querySelector("button")!.id = "interaction-other"],
|
|
["wrong visible question", () => document.querySelector("p")!.textContent = "Another question?"],
|
|
["wrong question binding", () => document.querySelector("p")!.id = "question-other-prompt"],
|
|
["hidden takeover", () => document.querySelector("section")!.hidden = true],
|
|
["hidden prompt", () => document.querySelector("p")!.setAttribute("aria-hidden", "true")],
|
|
["hidden linked task", () => document.querySelector("a")!.setAttribute("style", "display:none")],
|
|
["no actual context links", () => document.querySelectorAll("a").forEach(node => node.remove())],
|
|
["wrong DOM link", () => document.querySelector("a")!.setAttribute("href", "/RUN/issues/wrong")],
|
|
["sidebar link only", () => document.body.append(document.querySelector("a")!)],
|
|
["unrelated conversation", () => document.querySelector("main")!.querySelector("#comment-human")!.remove()],
|
|
["ambiguous conversation", () => document.body.insertAdjacentHTML("beforeend", dom())],
|
|
["unrelated takeover", () => document.querySelector("section")!.setAttribute("data-testid", "another-takeover")],
|
|
];
|
|
it.each(domNegatives)("rejects %s DOM evidence", (_, change) => {
|
|
change();
|
|
expect(collect()).toBeUndefined();
|
|
});
|
|
it("selects the saved choice that offers only the Launch task, by option id and task identifier", () => {
|
|
const launch = { id: "launch-task", identifier: "COM-1" }, experiments = { id: "experiment-task", identifier: "COM-2" };
|
|
// The card shape cohort 12's agent asked: one choice per task plus a choice naming both.
|
|
const card = (options: Array<{ id: string; label: string; description?: string }>, extra: Record<string, unknown> = {}) => [{
|
|
id: "question", kind: "ask_user_questions",
|
|
payload: { version: 1, questions: [], questionSet: { schema: "paperclip.question_set.v1", ...extra,
|
|
questions: [{ id: "which-task", prompt: "Which landing-page task should become high priority?", required: true, answerMode: "single_select", options }] } },
|
|
}] as unknown as Parameters<typeof chosenTaskOption>[0];
|
|
const evidence = { interactionId: "question", questionId: "which-task" };
|
|
const offered = [{ id: "com-1", label: "COM-1 (Launch project)" }, { id: "com-2", label: "COM-2 (Experiments project)" }, { id: "both", label: "Both tasks" }];
|
|
expect(chosenTaskOption(card(offered), evidence, launch, [launch, experiments]))
|
|
.toEqual({ optionId: "com-1", domId: "question-which-task-com-1", submitLabel: "Submit answers" });
|
|
// Wording does not matter; the identifier may sit in the description, and a custom submit label is used.
|
|
expect(chosenTaskOption(card([{ id: "b", label: "Experiments one", description: "COM-2" }, { id: "a", label: "The other one", description: "COM-1" }], { submitLabel: "Choose" }),
|
|
evidence, launch, [launch, experiments])).toEqual({ optionId: "a", domId: "question-which-task-a", submitLabel: "Choose" });
|
|
// No single unambiguous choice: an option naming both tasks, duplicates, or neither.
|
|
expect(chosenTaskOption(card([{ id: "both", label: "COM-1 and COM-2" }]), evidence, launch, [launch, experiments])).toBeUndefined();
|
|
expect(chosenTaskOption(card([{ id: "x", label: "COM-1" }, { id: "y", label: "COM-1 again" }]), evidence, launch, [launch, experiments])).toBeUndefined();
|
|
expect(chosenTaskOption(card([{ id: "x", label: "Launch" }, { id: "y", label: "Experiments" }]), evidence, launch, [launch, experiments])).toBeUndefined();
|
|
expect(chosenTaskOption(card([{ id: "x", label: "COM-10" }]), evidence, launch, [launch, experiments])).toBeUndefined();
|
|
expect(chosenTaskOption(card(offered), { ...evidence, interactionId: "other" }, launch, [launch, experiments])).toBeUndefined();
|
|
});
|