Files
PaperClipAI/ui/src/components/task-chat/TaskChatQueuedMessages.test.tsx
T
DottaandClaude Opus 5.5 4aed3056db feat(ui): steer a queued follow-up into the live turn after a 5 s edit window (#19970)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - When a person comments on a task while the agent works, the comment
waits in a queue until the current run ends, and only the next run reads
it
> - Measured locally, a comment posted during a Codex tool call waited
54–68 s for a reply (median 64 s)
> - Codex and Pi can take a message into the live turn ("Steer"), but
today the person must click Steer on each queued message
> - Restart recovery now delivers a steered message that a restart
interrupted (#19962), so steering is safe to do automatically
> - This pull request steers a queued follow-up into the live turn on
its own after a 5-second window in which the person can edit or cancel
it
> - The benefit is a faster reply to mid-turn comments on Codex and Pi,
with no new decision for the person

## Linked Issues or Issue Description

**Feature**
Send a queued follow-up into the running turn automatically when the
runner supports steering.

**Problem**
A follow-up comment posted during a running turn waits for the whole
turn to end and for a new run to start. Steering is available for Codex
and Pi, but only as a manual button on each queued message.

**Proposed behavior**
After a 5-second edit window, the queued message is steered into the
live turn. During the window the row shows "Sending in Xs" with Edit and
Cancel. If steering is unavailable, the message stays queued as before.
Claude, OpenCode and Cursor keep the queue. Steer and Interrupt stay
available as buttons.

Refs #19962

## What Changed

- `queued-message-auto-steer.ts`: one constant,
`QUEUED_MESSAGE_AUTO_STEER_DELAY_MS = 5_000`, a deadline helper and an
eligibility check. A message steers automatically only when all of these
are true:
- steering is available for the queue, and it is a `paperclip_runner_v1`
queue with a queue id and a target run;
  - the person can edit the message;
- it is not an interaction response or a response that requires a fresh
session;
- it is not optimistic, cancelled, already attempted, or open in the
editor.
- `TaskChatQueuedMessages`: countdown row "Sending in Xs" with Edit and
Cancel in place of Steer and the "…" menu. The deadline is `max(message
changed, first eligible) + delay`, so an old queued message does not
send the moment its turn becomes steerable, and an edit restarts the
window. When the deadline passes, the row uses the existing Steer
action, so the server path, idempotency and fallback stay the same.
Cancel returns the row to the normal Steer button. The countdown is
announced once to screen readers, not on every tick.
- `TaskChatThread` turns it on with the constant and passes the message
being edited, so an open edit never sends. The prop stays off by default
for other callers.
- Storybook: `AutoSteerCountdown` (with a play test for Cancel) and
`AutoSteerCountdownMobile` in "Composer / Steering and queued messages".
- Restart chaos TTFT driver: a `midturn` phase measures comment-to-reply
for a comment posted during a 40-second tool call, with `--midturn-mode
queue|steer` and `--midturn-fault K1|K2|K6`. It records the reply count,
so exactly-once delivery is checked.

## Verification

- `pnpm --filter @paperclipai/ui vitest run
src/components/task-chat/TaskChatQueuedMessages.test.tsx
src/components/TaskChatThread.test.tsx`: 434 passed. Seven new
auto-steer tests use fake timers: countdown and send, Cancel, Edit
restarts the window, an open edit never sends, ineligible queues stay
manual, no instant send for an old message, one attempt per revision.
They fail with the trigger disabled.
- `node scripts/check-token-gates.mjs`: clean.
- Storybook in the browser, desktop and mobile: the first row counts
down and steers ("Message steered into the active turn."). The cancelled
row shows the normal Steer button. On mobile the text truncates and the
row fits.
- Mid-turn latency, local, Codex, comment during a 40-second tool call:
queue 54–68 s (median 64 s), steer 47–61 s (median 50 s). The steer was
acknowledged in 0.8–0.9 s. The remaining time is the tool call and the
model, not the hand-off.
- Restart chaos, Codex, steer mode, faults K1, K2 and K6, 2 samples
each, on #19962 plus this branch: 6 of 6 messages acknowledged, still
unread at the fault, recovered, and answered exactly once (before
#19962: 0 of 6).

## Risks

- A message now leaves the queue after 5 seconds unless the person edits
or cancels it. The window and the countdown make this visible, and
steering is only automatic where the provider supports it.
- Pi: a steer the model already read before a restart can arrive again
after recovery, because Pi reports no read evidence (see #19962).
Automatic steering makes this a little more likely.
- If steering fails, the message stays queued and is delivered by the
next run, as today.
- UI only and a test harness. No schema, API or server change.

## Model Used

- Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, via Claude Code with
tool use (shell, file editing, browser checks, test execution).

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 22:59:44 -06:00

600 lines
26 KiB
TypeScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
// @vitest-environment jsdom
import { act, type ComponentProps } from "react";
import { flushSync } from "react-dom";
import { createRoot, type Root } from "react-dom/client";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import type { IssueQueuedCommentQueue } from "@paperclipai/shared";
import {
reorderQueuedMessageEntries,
TaskChatQueuedMessages,
} from "./TaskChatQueuedMessages";
function deferred<T>() {
let resolve!: (value: T) => void;
let reject!: (error: Error) => void;
const promise = new Promise<T>((innerResolve, innerReject) => {
resolve = innerResolve;
reject = innerReject;
});
return { promise, resolve, reject };
}
const queue: IssueQueuedCommentQueue = {
issueId: "issue-1",
queueId: "wake-1",
state: "deferred",
targetRunId: "run-1",
revision: "rev-1",
protocol: "paperclip_runner_v1",
steeringDisposition: "available",
entries: ["First queued message", "Second queued message"].map(
(body, position) => ({
comment: {
id: `comment-${position + 1}`,
companyId: "company-1",
issueId: "issue-1",
authorType: "user",
authorAgentId: null,
authorUserId: "user-1",
body,
presentation: null,
metadata: null,
createdAt: new Date(),
updatedAt: new Date(),
},
position,
canEdit: true,
canDiscard: true,
}),
),
};
describe("TaskChatQueuedMessages", () => {
let container: HTMLDivElement;
let root: Root;
beforeEach(() => {
container = document.createElement("div");
document.body.appendChild(container);
root = createRoot(container);
});
afterEach(() => {
flushSync(() => root.unmount());
container.remove();
});
function render(
overrides: Partial<ComponentProps<typeof TaskChatQueuedMessages>> = {},
) {
const props = {
queue,
onEdit: vi.fn(),
onReorder: vi.fn().mockResolvedValue(undefined),
onSteer: vi.fn().mockResolvedValue(undefined),
onDiscard: vi.fn().mockResolvedValue(undefined),
...overrides,
};
flushSync(() => root.render(<TaskChatQueuedMessages {...props} />));
return props;
}
it("keeps saved input visible without duplicating the task status", () => {
const message = "Waiting for the previous environment to stop. Your message will start automatically.";
render({ queue: { ...queue, executionWait: { reason: "remote_cleanup", message } } });
expect(container.textContent).not.toContain(message);
expect(container.textContent).toContain("First queued message");
render();
expect(container.textContent).not.toContain(message);
});
it("renders each queued message once as a compact one-line row", () => {
render();
const pane = container.querySelector(
'[data-testid="task-chat-queued-messages"]',
);
expect(pane?.classList).toContain("mx-3");
expect(pane?.classList).toContain("rounded-b-none");
expect(pane?.classList).toContain("border-b-0");
expect(pane?.classList).toContain("-mb-px");
expect(
container.querySelectorAll('[data-testid^="task-chat-queued-message-"]'),
).toHaveLength(2);
expect(container.textContent).toContain("First queued message");
expect(container.textContent).toContain("Second queued message");
});
it.each(["legacy", "native", "native-plan"] as const)("shows a read-only response and sends it only on click for %s", async (runtime) => {
const entry = { ...queue.entries[0], canEdit: false, canDiscard: false,
comment: { ...queue.entries[0].comment, body: 'Accepted: Build the app\n\n{"revision": "v1"}' },
source: { kind: "interaction" as const, interactionId: "confirmation-1", interactionKind: "request_confirmation",
requiresFreshSession: runtime === "native-plan" } };
const props = render({ queue: { ...queue, entries: [entry],
protocol: runtime === "legacy" ? "legacy" : "paperclip_runner_v1" },
onInterrupt: vi.fn().mockResolvedValue(undefined) });
expect(props.onSteer).not.toHaveBeenCalled();
expect(props.onInterrupt).not.toHaveBeenCalled();
expect(container.textContent).toContain("Accepted: Build the app");
expect(container.textContent).not.toContain('"revision"');
expect(container.querySelector<HTMLButtonElement>('[aria-label^="Reorder"]')?.disabled).toBe(true);
expect(container.querySelector<HTMLButtonElement>('[data-testid^="task-chat-queued-discard-"]')?.disabled).toBe(true);
expect(reorderQueuedMessageEntries([entry, queue.entries[1]], "comment-1", "comment-2")).toBeNull();
const action = runtime === "native" ? "steer" : "interrupt";
await act(async () => { container.querySelector<HTMLButtonElement>(`[data-testid="task-chat-queued-${action}-comment-1"]`)!.click(); });
if (action === "steer") expect(props.onSteer).toHaveBeenCalledWith("comment-1", "rev-1");
else expect(props.onInterrupt).toHaveBeenCalledOnce();
});
it("shows a declined connection request as readable text, never its raw JSON receipt (BUG-08)", () => {
const receipt = JSON.stringify({ interactionId: "slack-1", kind: "connection_intent", status: "rejected",
payload: { serviceSlug: "slack", serviceName: "Slack" }, result: { outcome: "declined" } }, null, 2);
const entry = { ...queue.entries[0], canEdit: false, canDiscard: false,
comment: { ...queue.entries[0].comment, id: "slack-1", body: `Rejected: Connect Slack\n\n${receipt}` },
source: { kind: "interaction" as const, interactionId: "slack-1", interactionKind: "connection_intent",
summary: "Declined: Slack connection" } };
render({ queue: { ...queue, entries: [entry], steeringDisposition: "temporarily_unavailable" } });
const row = container.querySelector('[data-testid="task-chat-queued-message-slack-1"]')!;
const hoverAndLabels = [...row.querySelectorAll("[title], [aria-label]")]
.flatMap((element) => [element.getAttribute("title"), element.getAttribute("aria-label")])
.filter((text): text is string => Boolean(text));
expect(hoverAndLabels.length).toBeGreaterThan(0);
for (const text of hoverAndLabels) {
expect(text).not.toContain("{");
expect(text).not.toContain("interactionId");
}
expect(row.textContent).toContain("Declined: Slack connection");
expect(row.querySelector('[title="Declined: Slack connection"]')).not.toBeNull();
});
it("reorders the complete queue and rewrites contiguous positions", () => {
const next = reorderQueuedMessageEntries(
queue.entries,
"comment-2",
"comment-1",
);
expect(next?.map((entry) => entry.comment.id)).toEqual([
"comment-2",
"comment-1",
]);
expect(next?.map((entry) => entry.position)).toEqual([0, 1]);
});
it("removes the selected steering row before the provider acknowledges it", async () => {
const acknowledgement = deferred<void>();
const props = render({
onSteer: vi.fn().mockReturnValue(acknowledgement.promise),
});
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-steer-comment-1"]',
)
?.click();
await Promise.resolve();
});
expect(props.onSteer).toHaveBeenCalledWith("comment-1", "rev-1");
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-1"]',
),
).toBeNull();
expect(container.textContent).toContain("Steering queued message.");
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-2"]',
),
).not.toBeNull();
await act(async () => {
render({ ...props, queue: { ...queue, entries: [...queue.entries] } });
});
expect(container.querySelector('[data-testid="task-chat-queued-message-comment-1"]')).toBeNull();
await act(async () => {
acknowledgement.resolve();
await acknowledgement.promise;
});
});
it("clears the entire interrupt queue immediately and restores it inline on failure", async () => {
let rejectInterrupt!: (error: Error) => void;
const interrupted = new Promise<void>((_, reject) => { rejectInterrupt = reject; });
const props = render({ queue: { ...queue, protocol: "legacy", steeringDisposition: "unsupported" },
onInterrupt: vi.fn().mockReturnValue(interrupted) });
await act(async () => {
container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-interrupt-comment-1"]')!.click();
});
expect(props.onInterrupt).toHaveBeenCalledOnce();
expect(container.querySelector('[data-testid="task-chat-queued-messages"]')).toBeNull();
await act(async () => { rejectInterrupt(new Error("Connection lost")); await interrupted.catch(() => undefined); });
expect(container.querySelectorAll('[data-testid^="task-chat-queued-message-"]')).toHaveLength(2);
expect(container.textContent).toContain("Couldn’t interrupt. Message is still queued.");
});
it.each(["steer", "interrupt"] as const)("shows a delivery error even when the queue becomes empty while %s is pending", async action => {
const delivery = deferred<void>();
const props = render({ queue: { ...queue, protocol: action === "interrupt" ? "legacy" : "paperclip_runner_v1" },
onSteer: vi.fn().mockReturnValue(delivery.promise), onInterrupt: vi.fn().mockReturnValue(delivery.promise) });
await act(async () => { container.querySelector<HTMLButtonElement>(`[data-testid="task-chat-queued-${action}-comment-1"]`)!.click(); });
await act(async () => { render({ ...props, queue: { ...props.queue, revision: "empty-poll", entries: [] } }); });
await act(async () => { delivery.reject(new Error("Connection lost")); await delivery.promise.catch(() => undefined); });
const error = action === "steer" ? "Couldn’t steer." : "Couldn’t interrupt.";
expect([...container.querySelectorAll('[role="status"]')].some(status => status.textContent?.includes(error))).toBe(true);
expect(container.querySelector('[data-testid="task-chat-queued-message-comment-1"]')).toBeNull();
});
it("does not restore a message discarded elsewhere while steering was pending", async () => {
let rejectSteer!: (error: Error) => void;
const delivery = new Promise<void>((_, reject) => { rejectSteer = reject; });
const props = render({ onSteer: vi.fn().mockReturnValue(delivery) });
await act(async () => { container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-steer-comment-1"]')!.click(); });
await act(async () => { render({ ...props, queue: { ...queue, revision: "rev-2", entries: [queue.entries[1]] } }); });
await act(async () => { rejectSteer(new Error("Queue changed")); await delivery.catch(() => undefined); });
expect(container.querySelector('[data-testid="task-chat-queued-message-comment-1"]')).toBeNull();
expect(container.querySelector('[data-testid="task-chat-queued-message-comment-2"]')).not.toBeNull();
expect(container.textContent).toContain("Couldn’t steer.");
});
it("keeps a row queued when steering fails and announces the retryable state", async () => {
render({
onSteer: vi.fn().mockRejectedValue(new Error("steering_timeout")),
});
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-steer-comment-1"]',
)
?.click();
});
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-1"]',
),
).not.toBeNull();
expect(container.textContent).toContain(
"Couldn’t steer. Message is still queued.",
);
});
it("disables steering when the provider does not advertise it", () => {
render({ queue: { ...queue, steeringDisposition: "unsupported" } });
expect(
container.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-steer-comment-1"]',
)?.disabled,
).toBe(true);
});
it.each(["temporarily_unavailable", "unsupported"] as const)(
"offers an explicit interrupt fallback when native steering is %s",
async (steeringDisposition) => {
const props = render({
queue: { ...queue, steeringDisposition },
onInterrupt: vi.fn().mockResolvedValue(undefined),
});
const interrupt = container.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-interrupt-comment-1"]',
);
expect(interrupt).not.toBeNull();
expect(interrupt!.disabled).toBe(false);
expect(interrupt!.textContent).toContain("Interrupt");
await act(async () => { interrupt!.click(); });
expect(props.onInterrupt).toHaveBeenCalledOnce();
expect(props.onSteer).not.toHaveBeenCalled();
expect(container.querySelector('[data-testid="task-chat-queued-messages"]')).toBeNull();
},
);
it("keeps same-turn steering when the provider is available, even with an interrupt callback", async () => {
const props = render({ onInterrupt: vi.fn().mockResolvedValue(undefined) });
expect(container.querySelector('[data-testid="task-chat-queued-interrupt-comment-1"]')).toBeNull();
await act(async () => {
container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-steer-comment-1"]')!.click();
});
expect(props.onSteer).toHaveBeenCalledWith("comment-1", "rev-1");
expect(props.onInterrupt).not.toHaveBeenCalled();
});
it("waits for authoritative discard acknowledgement before removing the row", async () => {
const acknowledgement = deferred<void>();
render({ onDiscard: vi.fn().mockReturnValue(acknowledgement.promise) });
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-discard-comment-1"]',
)
?.click();
await Promise.resolve();
});
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-1"]',
),
).not.toBeNull();
expect(container.textContent).not.toContain("Queued message discarded.");
await act(async () => {
acknowledgement.resolve();
await acknowledgement.promise;
});
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-1"]',
),
).toBeNull();
expect(container.textContent).toContain("Queued message discarded.");
});
it("keeps a too-late discard visible with an explicit error", async () => {
render({
onDiscard: vi.fn().mockRejectedValue({
body: { details: { code: "queued_comment_already_dispatching" } },
}),
});
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-discard-comment-1"]',
)
?.click();
});
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-1"]',
),
).not.toBeNull();
expect(container.textContent).toContain(
"Too late to discard: this message is already being sent.",
);
});
it("shows stale revisions without announcing a discard", async () => {
render({
onDiscard: vi.fn().mockRejectedValue({
body: { details: { code: "queued_comment_revision_conflict" } },
}),
});
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-discard-comment-1"]',
)
?.click();
});
expect(container.textContent).toContain(
"The queue changed in another session. Review it and try again.",
);
expect(container.textContent).not.toContain("Queued message discarded.");
});
it("does not expose queue controls before a real queue id is acknowledged", () => {
const props = render({ queue: { ...queue, queueId: null, state: null } });
const discard = container.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-discard-comment-1"]',
);
expect(discard?.disabled).toBe(true);
discard?.click();
expect(props.onDiscard).not.toHaveBeenCalled();
});
it("can discard a local optimistic row before the queue id is acknowledged", async () => {
const optimisticQueue = {
...queue,
queueId: null,
state: "deferred" as const,
entries: [
{
...queue.entries[0],
comment: {
...queue.entries[0].comment,
id: "optimistic-local-1",
},
},
],
};
const props = render({ queue: optimisticQueue });
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-discard-optimistic-local-1"]',
)
?.click();
});
expect(props.onDiscard).toHaveBeenCalledWith("optimistic-local-1", "rev-1");
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-optimistic-local-1"]',
),
).toBeNull();
});
it("delivers legacy queued messages to a live target", async () => {
const targetRunId = "run-1";
const onInterrupt = vi.fn().mockResolvedValue(undefined);
render({
queue: {
...queue,
targetRunId,
protocol: "legacy",
steeringDisposition: "unsupported",
},
onInterrupt,
});
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-interrupt-comment-1"]',
)
?.click();
});
expect(onInterrupt).toHaveBeenCalledOnce();
expect(
container.querySelector(
'[data-testid="task-chat-queued-steer-comment-1"]',
),
).toBeNull();
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-1"]',
),
).toBeNull();
});
it("keeps deferred sends visible and explains their current wait", async () => {
const saved = { ...queue, targetRunId: null, executionWait: { reason: "decision_pending", message: "Resolve the pending approval before sending." } };
const onInterrupt = vi.fn().mockResolvedValue(saved);
render({ queue: saved, onInterrupt });
await act(async () => { container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-interrupt-comment-1"]')!.click(); });
expect(container.textContent).toContain("First queued message");
expect(container.textContent).toContain(saved.executionWait.message);
expect(container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-interrupt-comment-1"]')?.disabled).toBe(false);
});
it("clears a deferred wait message when a refreshed queue finishes sending", async () => {
const saved = { ...queue, targetRunId: null, executionWait: { reason: "decision_pending", message: "Resolve the pending approval before sending." } };
render({ queue: saved, onInterrupt: vi.fn().mockResolvedValue(saved) });
await act(async () => { container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-interrupt-comment-1"]')!.click(); });
expect(container.textContent).toContain(saved.executionWait.message);
render({ queue: { ...saved, queueId: null, entries: [], state: null, executionWait: null } });
await act(async () => {});
expect(container.textContent).not.toContain(saved.executionWait.message);
expect(container.querySelector('[data-testid="task-chat-queued-messages"]')).toBeNull();
});
it.each(["legacy", "paperclip_runner_v1"] as const)("sends a saved %s queue explicitly after Stop", async (protocol) => {
const onInterrupt = vi.fn().mockResolvedValue(undefined);
render({ queue: { ...queue, targetRunId: null, protocol, steeringDisposition: "temporarily_unavailable" }, onInterrupt });
expect(onInterrupt).not.toHaveBeenCalled();
const send = container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-interrupt-comment-1"]');
expect(send?.textContent).toBe("Send");
expect(send?.getAttribute("aria-label")).toBe("Send queued messages");
expect(send?.disabled).toBe(false);
await act(async () => { send!.click(); });
expect(onInterrupt).toHaveBeenCalledOnce();
expect(container.querySelector('[data-testid="task-chat-queued-steer-comment-1"]')).toBeNull();
});
describe("automatic steering", () => {
const delay = 5_000;
const fresh = (overrides: Partial<IssueQueuedCommentQueue> = {}): IssueQueuedCommentQueue => {
const at = new Date(Date.now());
return { ...queue, ...overrides, entries: queue.entries.slice(0, 1).map(entry => ({
...entry, comment: { ...entry.comment, createdAt: at, updatedAt: at } })) };
};
const advance = async (ms: number) => { await act(async () => { vi.advanceTimersByTime(ms); await Promise.resolve(); }); };
const countdown = () => container.querySelector('[data-testid="task-chat-queued-auto-steer-comment-1"]');
beforeEach(() => { vi.useFakeTimers({ now: new Date("2026-11-07T12:00:00Z") }); });
afterEach(() => { vi.useRealTimers(); });
it("shows a countdown with Edit and Cancel, then steers into the live turn", async () => {
const props = render({ queue: fresh(), autoSteerDelayMs: delay });
expect(countdown()?.textContent).toContain("Sending in 5s");
expect(container.querySelector('[data-testid="task-chat-queued-steer-comment-1"]')).toBeNull();
await advance(2_100);
expect(countdown()?.textContent).toContain("Sending in 3s");
expect(props.onSteer).not.toHaveBeenCalled();
await advance(3_000);
expect(props.onSteer).toHaveBeenCalledOnce();
expect(props.onSteer).toHaveBeenCalledWith("comment-1", "rev-1");
});
it("gives a saved edit a full window while another row's countdown keeps the clock running", async () => {
const start = Date.now();
const twoRows: IssueQueuedCommentQueue = { ...queue, entries: queue.entries.slice(0, 2).map((entry, index) => {
const at = new Date(start + index * 4_000);
return { ...entry, comment: { ...entry.comment, createdAt: at, updatedAt: at } };
}) };
// comment-1 counts down first; the person opens it for editing at 1 s.
const props = render({ queue: twoRows, autoSteerDelayMs: delay });
await advance(1_000);
await act(async () => { render({ ...props, editingCommentId: "comment-1" }); });
// comment-2 counts down to start + 9 s and keeps the clock ticking past
// comment-1's old deadline.
await advance(5_000);
expect(props.onSteer).not.toHaveBeenCalled();
const saved = { ...twoRows, revision: "rev-2", entries: twoRows.entries.map((entry, index) => index === 0
? { ...entry, comment: { ...entry.comment, body: "Edited", updatedAt: new Date(Date.now()) } } : entry) };
await act(async () => { render({ ...props, queue: saved, editingCommentId: null }); });
await advance(500);
expect(props.onSteer).not.toHaveBeenCalledWith("comment-1", expect.anything());
expect(countdown()?.textContent).toContain("Sending in");
await advance(5_000);
expect(props.onSteer).toHaveBeenCalledWith("comment-1", "rev-2");
});
it("keeps a cancelled message in the queue with its explicit Steer button", async () => {
const props = render({ queue: fresh(), autoSteerDelayMs: delay });
await act(async () => {
container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-auto-steer-cancel-comment-1"]')?.click();
await Promise.resolve();
});
await advance(10_000);
expect(props.onSteer).not.toHaveBeenCalled();
expect(countdown()).toBeNull();
expect(container.querySelector('[data-testid="task-chat-queued-steer-comment-1"]')).not.toBeNull();
});
it("waits while the message is being edited and restarts from the saved revision", async () => {
const queued = fresh();
const props = render({ queue: queued, autoSteerDelayMs: delay });
await act(async () => {
container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-auto-steer-edit-comment-1"]')?.click();
await Promise.resolve();
});
expect(props.onEdit).toHaveBeenCalledWith("comment-1");
render({ ...props, editingCommentId: "comment-1" });
await advance(10_000);
expect(props.onSteer).not.toHaveBeenCalled();
// The save changes the comment; its countdown starts again from that change.
const saved = { ...queued, revision: "rev-2", entries: queued.entries.map(entry => ({
...entry, comment: { ...entry.comment, body: "Edited", updatedAt: new Date(Date.now()) } })) };
await act(async () => { render({ ...props, queue: saved, editingCommentId: null }); });
expect(countdown()?.textContent).toContain("Sending in 5s");
await advance(5_100);
expect(props.onSteer).toHaveBeenCalledWith("comment-1", "rev-2");
});
it("keeps the ordinary queue while steering is unavailable or unsupported", async () => {
for (const steeringDisposition of ["temporarily_unavailable", "unsupported"] as const) {
const props = render({ queue: fresh({ steeringDisposition }), autoSteerDelayMs: delay });
expect(countdown()).toBeNull();
await advance(10_000);
expect(props.onSteer).not.toHaveBeenCalled();
}
});
it("tries each message revision once, then leaves it queued after a failure", async () => {
const props = render({ queue: fresh(), autoSteerDelayMs: delay, onSteer: vi.fn().mockRejectedValue(new Error("rejected")) });
await advance(5_100);
await advance(10_000);
expect(props.onSteer).toHaveBeenCalledOnce();
expect(container.textContent).toContain("Couldn’t steer. Message is still queued.");
expect(countdown()).toBeNull();
});
it("never sends someone else’s message or a saved card response automatically", async () => {
const notMine = fresh();
notMine.entries = notMine.entries.map(entry => ({ ...entry, canEdit: false }));
const card = fresh();
card.entries = card.entries.map(entry => ({ ...entry, source: { kind: "interaction", summary: "Approved" } as never }));
for (const candidate of [notMine, card]) {
const props = render({ queue: candidate, autoSteerDelayMs: delay });
await advance(10_000);
expect(props.onSteer).not.toHaveBeenCalled();
}
});
it("stays off unless the caller enables it", async () => {
const props = render({ queue: fresh() });
expect(countdown()).toBeNull();
await advance(10_000);
expect(props.onSteer).not.toHaveBeenCalled();
});
});
});