Files
PaperClipAI/server/src/__tests__/external-object-refresh-work.test.ts
T
Nicky LeachandClaude Opus 5.5 11ac90e31f fix(build): typecheck server/src/__tests__ and fix every type error (#18739)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The server has about 1,100 test and helper files in
`server/src/__tests__`
> - `server/tsconfig.json` excludes that directory, Vitest does not
check types, and no script runs the tsconfig in that directory
> - So a test can call a function with the wrong arguments and still
pass, and no tool reports it
> - This gap hid 2,168 real type errors, and some of them hid tests that
did not test what they claim
> - This pull request fixes all of these errors and adds the directory
to the server layers from paperclipai/paperclip#18737
> - The benefit is that a type error in a server test now fails the
typecheck, with no baseline and no backlog

## Linked Issues or Issue Description

Refs paperclipai/paperclip#18737, which is merged and added the server
layers. Refs paperclipai/paperclip#18738, which is merged and checks the
test projects outside `pnpm -r`, so it is not a duplicate. Refs
paperclipai/paperclip#18137, which records that this directory has no
check.

**What happened?**

No tool checked the types of 1,074 of the 1,101 files in
`server/src/__tests__`. I searched `package.json`, the workflows, and
all tsconfig files. 27 files are in the program of another tsconfig, and
these 27 have 0 errors. 11 of the 27 are in
`helpers/maintenance/tsconfig.json`. No script ran that project when I
measured this. paperclipai/paperclip#18738 now runs it.

**Expected behavior**

The server typecheck checks these files, and a type error fails the
check.

**Steps to reproduce**

1. On the base commit, run `tsc -p server/src/__tests__/tsconfig.json
--noEmit`. It reports 6,536 errors and needs 12.3 GiB.
2. Add a type error to any file in `server/src/__tests__`.
3. Run `pnpm --filter @paperclipai/server typecheck`. It passes.

**Paperclip version or commit**

I measured the error breakdown below on commit `8dfd632452`, with
TypeScript 7.0.2. The branch now includes master up to
paperclipai/paperclip#18865.

**Deployment mode**

Not applicable. This issue applies to development and CI. No production
source file in the server changes.

### Error breakdown

Each row adds one change to the row above.

| Step | Total errors | Change | Cause |
| --- | --- | --- | --- |
| Config as committed | 6,536 | | |
| Add `src/types/*.d.ts` | 4,447 | -2,089 | Config. The Express request
types were missing. |
| Set `rootDir` to the repository root | 2,436 | -2,011 | Config. |
| Set `allowImportingTsExtensions` | 2,181 | -255 | Config. Vitest
accepts `.ts` imports. |
| Add `ES2024.Promise` to `lib` | 2,138 | -43 | Config. Node 24 has
`Promise.withResolvers`. |
| Set `allowJs` for `.mjs` imports | 2,148 | +10 | Config. It removes 8
`TS7016` errors and shows new real errors. |
| Set `declaration` to false | 2,142 | -6 | Config. Tests emit nothing.
|
| Count only files in `server/src` | 2,058 | -84 | Other packages: 53
Daytona, 29 Runner test, 2 UI. |

So 4,478 of the 6,536 errors (69%) came from config or scope, and 2,058
are real type errors in 314 files. The 29 Runner test errors are also
real, which gives 2,087 errors. Tests that master added after this
measurement had 81 more errors, so this pull request fixes 2,168 errors.

This table classifies the first 2,058 errors.

| Kind of real error | Errors |
| --- | --- |
| Wrong argument or assignment type | 1,023 |
| Stale or partial fixture objects | 525 |
| Property that the type does not have | 317 |
| Missing narrowing of null or unknown | 101 |
| Implicit any | 60 |
| Missing name or module | 16 |
| Other | 16 |

### What the type errors hid

Most errors were stale fixtures and loose mocks. These errors hid real
test problems, and this pull request fixes them:

- **A test that never ran.** `instrumentation.test.ts` required
`sdk-trace-base`, which is not installed. So 3 span tests were skipped.
They now run and pass.
- **Assertions that could not fail.**
- `issue-thread-interactions-service` used a company ID as an issue ID.
- `status-card-evaluation-work` compared `[]` with `[]` in a rollback
check.
- `slack-conversation-lifecycle` read `item.issueId`, which does not
exist.
  - `email-channels` used a permission key that does not exist.
- `heartbeat-project-env` imported `LOW_TRUST_REVIEW_PRESET`, which is
not exported. The value was undefined.
- **Postgres processes that did not stop.** 11 test files called `stop`
on the test database helper. That method does not exist, and the helper
method is `cleanup`.
- **Arguments that the service ignored.**
- `methodKey` is now `connectionMethodKey` in the Daytona, Unikraft,
1Password, and Railway tests.
- 108 calls passed `"owner-user"` to a parameter that expects an options
object.
- 9 chat wizard fixtures passed `managementContext` as `source`, so they
ran `existing_app` and not `manifest`.
  - 2 tests passed a `{ userId }` actor that the function ignores.
- Inserts into `environments` passed a `companyId` column that the table
does not have.
- **Problems in tests that master added during this work.**
- `sandbox-creation-operations` read `database.connectionString` when an
external test database was set. In that mode `database` is undefined, so
the fixture would stop with a TypeError. It now uses the external URL.
- `idle-completed-history` set a Dot operation to `dispatched`. That is
a Muse status, and the Dot type does not have it. The fixture now uses
`admitted`, which is a real in-flight Dot status.

### Possible product problems, not changed

These may be real problems in production code or types. I did not change
them, because this pull request does not change production behavior:

- `decisions-service` `service.create` does not validate the lenient
`cancel_issue_tree` input.
- `createConnection` ignores `input.connectionPurpose`.
- The `createConnection` route schema default stores `{}` for
`transportConfig`.
- `prepareManagedAiRuntime` accepted the invalid value `mode:
"connection"`.
- `createBinding` accepts invalid `projectionClass` strings outside
class 3.
- `ensureManagedProjectWorkspace` forwards an untyped `repoRef` by
spread.
- `routineVariableSchema.label` is optional, but `RoutineVariable.label`
is required.
- `ToolRunContext.projectId` may be too strict.
- `withdrawInteraction` reads `issue.status`, which its type omits.
- `issueService.list` and `reconcileNativeFinalizations` omit fields
that they return at runtime.
- `createGitHubExternalObjectProvider` handles `tokenProvider: null`,
but its type forbids this value.

## What Changed

- Fixed the 2,168 type errors. The diff changes 322 test and helper
files.
- Corrected `server/src/__tests__/tsconfig.json`. Editors and the
typecheck now read the same options and report the same errors.
- Added three `test-tree` layers to
`server/scripts/typecheck-layers.mjs`. They read the server layers as
declarations, and any error fails them. A hash of the path selects the
shard, so a new file does not move other files.
- Added `server/scripts/typecheck-stubs/daytona-sdk.d.ts`. Server tests
reach Daytona plugin source, and the root install does not have
`@daytonaio/sdk`.
- Changed two imports in `ui/src/lib/issue-execution-policy.ts` to use
`.js` extensions, because server tests import this file.
- Made `declarationsConfig` and `--declarations-only` skip the
`test-tree` layers, because these layers emit nothing. Other projects
read only the source layers. Added a test for this.
- Updated `doc/DEVELOPING.md`.

## Verification

Run these commands:

```sh
pnpm --filter @paperclipai/server typecheck
pnpm exec vitest run server/scripts/typecheck-layers.test.mjs
```

Results on macOS (arm64), Node 24, 16 cores. Each check ran after the
merge of paperclipai/paperclip#18738 unless the row says otherwise:

| Check | Commit | Result |
| --- | --- | --- |
| Server typecheck, `PAPERCLIP_TYPECHECK_LOW_MEMORY=1`, all 7 layers |
`6e45a08573` | Exit 0, 0 errors, 62 seconds, peak 3.52 GiB |
| `node scripts/typecheck-test-projects.mjs --low-memory` | `a3306bd13e`
| Exit 0, 0 errors, 42 seconds, peak 3.25 GiB |
| The same script with `--reuse-declarations` | `1b878aabc0` | Exit 0, 0
errors |
| `typecheck-layers.test.mjs` and `live-recovery-work.test.ts` |
`01db5634e4` | 90 passed. These include real compiler runs for a pass, a
type error, and an invalid tsconfig. |
| `tsconfig.declarations.json` after a full server typecheck |
`0fb1e4fb0a` | It references only `below`, `cycle`, and `above`. No
generated config names a `tsconfig.layers.json` file. |
| Owned runtime test in `idle-completed-history` | `e8f2f448ac` |
Passed, with the fix that master later replaced |
| `idle-incoming-wake`, `plugin-idle-manager`, and the changed
`chat-channels` test | `6e45a08573` | 30 passed |
| Runner `native-execution.test.ts` | `eab4dcc1f4` | 114 passed |
| The 19 server test files that changed since `eab4dcc1f4`, and
`typecheck-layers.test.mjs` | `259737b700` | 4,275 of 4,277 passed. The
2 failures are in `chat-channels` and are in the list of 7 below. |

The peak is the largest single process, from `/usr/bin/time -l`. Peaks
for the server typecheck were between 3.42 GiB and 3.56 GiB across 8
runs. Peaks for the test projects were 3.25 GiB and 3.37 GiB across 2
runs. I did not measure a cgroup.

**Runtime check of the fixes.** Types do not prove that a test still
works. So I ran all 309 changed server test files, 11,929 tests, before
the rebase onto paperclipai/paperclip#18737:

| Result | Tests | Detail |
| --- | --- | --- |
| Passed | 11,913 | Includes the 2 tests and the 54 `dot-runner` tests
that passed in a later run, as described below. |
| Failed | 7 | The same 7 tests also fail on the commit before the
fixes. |
| Skipped | 9 | These tests have their own skip conditions: `sentry` 5,
and 1 each in `bundled-plugin-registration`, `customer-success-cloud`,
`onepassword-connection`, and `workspace-runtime-https-live-exercise`. |

The 7 tests that fail with and without this change, on my machine:

- 3 tests in `chat-channels` and `email-channels` stop with `ENOENT` on
a `SKILL.md` file. The path is in the parent checkout, above the git
worktree that I used, so I expect that the worktree is the cause. I did
not prove this.
- `workspace-instance-cleanup` compares `/private/var/...` with
`/var/...`. This is a macOS symlink difference.
- 2 tests in `git-reproducible-managed-checkouts` get
`unknown_base_git_files` and expect `unpushed_managed_checkout`. I did
not find the cause.
- 1 more test in `chat-channels`, `materializes direct external-chat
finals once`, gets `undefined`. I did not find the cause.

CI is the check for these 7 tests. `ci / verify` passed on `eab4dcc1f4`.

Failures during this work:

- My fix to `agent-runtime-connector-access` changed an invalid
permission key in the setup, but not in the assertion. The runtime check
found this. I corrected the assertion, and the file passes.
- `heartbeat-plugin-environment` failed one wait in the full run. It
passed three times alone, so I think that load caused the failure. It
can fail again under load.
- `dot-runner` skipped all 54 tests in the full run because `cargo` was
not on my `PATH`. It then passed 54 of 54 with the toolchain on the
`PATH`.
- My first `lib` value removed the default DOM types, and the error
count went up by 375. I added the DOM libraries.
- My Daytona stub with bare `any` left 48 errors, because generic
helpers then inferred `unknown`. I added shapes that return promises.
- One fix to `agent-secrets-routes` used `class_3_static_lease`, and the
test failed. That class allows only specific paths. I reverted to
`unclassified`.
- `ci / General tests (server (8/12))` failed on `259737b700` because of
the flaky port in `idle-completed-history`. paperclipai/paperclip#18853
fixed this test on master, so this pull request keeps that fix.

**Audit of the diff.** I counted these patterns in added and removed
lines, to find fixes that only hide an error:

| Pattern | Added | Removed |
| --- | --- | --- |
| `@ts-ignore` | 0 | 0 |
| `@ts-expect-error` | 0 | 1 |
| `.skip` | 0 | 0 |
| `as any` | 9 | 9 |
| `: any` | 11 | 2 |
| `as never` | 8 | 2 |
| `as unknown as` | 35 | 4 |
| `Promise<unknown>` | 16 | 5 |
| `expect(` | 128 | 113 |

No hunk removes more `expect(` calls than it adds. Three removals of
test content were intentional, and I checked each one:

- `muse-control` removed `signalToken`. Line 1012 already asserts that
it is absent.
- `merged-pr-confirmation-sweep` removed legacy aliases. Other tests
cover them.
- `heartbeat-workspace-branch-containment` removed a `finalize` branch
that no test row can reach.

Some partial fixtures stay unchecked through `as unknown as` and
`Promise<unknown>`, mostly in `issue-agent-mutation-ownership-routes`
and `issue-comment-reopen-routes`.

**Accuracy of the check.** One program over the tree and the three
shards reported the same errors at the same positions. Memory, as the
peak of the largest process on one thread, was 3.93 GiB for one program
and 2.43 GiB for the largest shard. I measured these two values before
the fixes.

Not run or not proven:

- I did not run the full `pnpm test:run`, or a root `pnpm build`. I
expect CI to run the full suites.
- I did not run the 4 GiB container check, or the full
`scripts/typecheck-low-memory.mjs`. The peaks above come from macOS, so
they are not a Linux cgroup measurement.
- I did not run the UI typecheck after the merges.
- `workspace-runtime-https-live-exercise` is skipped, so its `cleanup`
fix did not run.

## Risks

- **A large diff in test files.** 328 files change. A pull request that
edits the same tests can get merge conflicts. New tests on master can
also add type errors before this merges. Any such error fails this check
and needs a fix here.
- **A higher cost for changes to source types.** A change to a type can
add errors in test files that the author did not touch. The author must
then fix them. This is the purpose of the check, but it is new work.
- **Changed test behavior.** Some tests now run paths that they did not
run before, such as the 9 chat wizard fixtures and the 3 span tests.
They pass here, but they can be more sensitive to timing or to the
environment.
- **The Daytona stub can go stale.** The stub is written by hand. If the
plugin uses a new SDK member, the typecheck reports an error until
someone updates the stub.
- **The release path.** `release-verify.yml` and `scripts/release.sh`
run `pnpm -r typecheck`, so they now run this check.
- **The tsconfig change.** The test transform reads
`server/src/__tests__/tsconfig.json`. The options that I changed are for
type checks, and the runs above passed.
- **A gap that remains.** Tsconfigs in `packages/paperclip-runner` and
in most sandbox provider plugins exclude `*.test.ts`. This check does
not read most of those test files, so they can still drift. That work is
separate from this pull request.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

Anthropic Claude Opus 5.5 (`claude-opus-5-5`) through Claude Code, with
reasoning, tool use, code execution, and subagents. The runtime does not
show the context window size.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [ ] I have run tests locally and they pass (7 tests fail locally, with
and without this change. See Verification.)
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 15:27:38 -08:00

650 lines
41 KiB
TypeScript

import { createServer } from "node:http";
import { randomUUID } from "node:crypto";
import { setTimeout as delay } from "node:timers/promises";
import { afterAll, afterEach, beforeAll, describe, expect, it, vi } from "vitest";
import { and, eq, inArray, sql } from "drizzle-orm";
import { activityLog, approvals, applyPendingMigrations, databaseWorkPending, budgetIncidents, budgetPolicies, companies, costEvents, createDb, externalObjects, externalObjectMentions, issues, issueComments, plugins } from "@paperclipai/db";
import { externalObjectService, type ExternalObjectResolveResult } from "../services/external-objects.js";
import type { PaperclipPluginManifestV1 } from "@paperclipai/shared";
import type { PluginWorkerManager } from "../services/plugin-worker-manager.js";
import { issueService } from "../services/issues.js";
import { documentService } from "../services/documents.js";
import { budgetService } from "../services/budgets.js";
import { pluginRegistryService } from "../services/plugin-registry.js";
import { companyService } from "../services/companies.js";
import { instanceSettingsService } from "../services/instance-settings.js";
import { notifyExternalObjectRefresh } from "../services/external-object-refresh-notifications.js";
import { DELIVERY_QUEUES } from "../services/delivery-work-notifications.js";
import { createDeliveryWorkCoordinator } from "../services/delivery-work-coordinator.js";
import { idleWorkSnapshot } from "../services/task-admission.js";
import { resolveExternalTestDatabaseUrl } from "./helpers/external-test-database.js";
import { getEmbeddedPostgresTestSupport, startEmbeddedPostgresTestDatabase } from "./helpers/embedded-postgres.js";
const url = resolveExternalTestDatabaseUrl("PAPERCLIP_EXTERNAL_OBJECT_REFRESH_TEST_DATABASE_URL");
const support = url ? { supported: true } : await getEmbeddedPostgresTestSupport();
const terminal: ExternalObjectResolveResult = { ok: true, snapshot: {
statusKey: "done", statusCategory: "succeeded", statusTone: "success", isTerminal: true,
} };
const active: ExternalObjectResolveResult = { ok: true, snapshot: {
statusKey: "open", statusCategory: "open", statusTone: "neutral", isTerminal: false, ttlSeconds: 60,
} };
(support.supported ? describe : describe.skip)("external object refresh work (real PostgreSQL, simulated provider)", () => {
let db: ReturnType<typeof createDb>;
let temp: Awaited<ReturnType<typeof startEmbeddedPostgresTestDatabase>> | undefined;
let coordinator: ReturnType<typeof createDeliveryWorkCoordinator> | undefined;
let admitted = true;
let reconcile = true;
let enabled = true;
const provider = vi.fn(async (): Promise<ExternalObjectResolveResult> => terminal);
const errors = vi.fn();
const companyIds: string[] = [];
beforeAll(async () => {
if (url) await applyPendingMigrations(url);
if (!url) temp = await startEmbeddedPostgresTestDatabase("external-refresh-work-");
db = createDb(url ?? temp!.connectionString, { maxConnections: 6 });
await db.execute(sql`truncate table ${companies} cascade`);
}, 90_000);
afterEach(async () => {
await coordinator?.stop(); coordinator = undefined;
vi.useRealTimers(); vi.restoreAllMocks();
for (const id of companyIds.splice(0)) {
await db.delete(budgetIncidents).where(eq(budgetIncidents.companyId, id));
await db.delete(budgetPolicies).where(eq(budgetPolicies.companyId, id));
await db.delete(approvals).where(eq(approvals.companyId, id));
await db.delete(costEvents).where(eq(costEvents.companyId, id));
await db.delete(activityLog).where(eq(activityLog.companyId, id));
await db.delete(issues).where(eq(issues.companyId, id));
await db.delete(externalObjects).where(eq(externalObjects.companyId, id));
await db.delete(companies).where(eq(companies.id, id));
}
await db.delete(plugins);
admitted = true; reconcile = true; enabled = true; errors.mockClear();
provider.mockReset().mockResolvedValue(terminal);
});
afterAll(async () => { await db?.$client.end({ timeout: 1 }); await temp?.cleanup(); });
function service() {
return externalObjectService(db, { github: false, enabled: () => enabled,
resolvers: [{ providerKey: "url", resolve: provider }] });
}
async function start(svc = service()) {
coordinator = createDeliveryWorkCoordinator({ owner: db, canRun: () => admitted,
canReconcile: () => reconcile, onError: errors });
const worker = svc.registerRefreshWork(coordinator, () => admitted);
await worker.ready;
return worker;
}
async function fixture(status = "active") {
const id = randomUUID(); companyIds.push(id);
await db.insert(companies).values({ id, name: "Refresh test", status,
issuePrefix: `E${id.replaceAll("-", "").slice(0, 8)}` });
const [issue] = await db.insert(issues).values({ companyId: id, title: "Reference",
description: `https://example.com/${id}`, status: "todo" }).returning();
return { companyId: id, issueId: issue!.id };
}
async function row(companyId: string) {
return (await db.select().from(externalObjects).where(eq(externalObjects.companyId, companyId)))[0]!;
}
async function settle(predicate: () => Promise<boolean> | boolean) {
for (let i = 0; i < 200; i++) {
await vi.advanceTimersByTimeAsync(0); await delay(5);
if (await predicate()) return;
}
throw new Error("refresh worker did not settle");
}
async function quiet() { await settle(() => coordinator!.nextWakeAt() === null && idleWorkSnapshot().active === 0); }
function clock() { vi.useFakeTimers({ toFake: ["Date", "setTimeout", "clearTimeout", "setInterval", "clearInterval"], shouldAdvanceTime: true }); }
async function change(companyId: string, patch: Partial<typeof externalObjects.$inferInsert>) {
await db.transaction(async tx => {
await notifyExternalObjectRefresh(tx, companyId);
await tx.update(externalObjects).set(patch).where(eq(externalObjects.companyId, companyId));
});
}
it("activates saved work when the ordinary feature and company settings enable it", async () => {
clock(); const settings = instanceSettingsService(db);
await settings.updateExperimental({ enableExternalObjects: true });
const svc = externalObjectService(db, { github: false,
enabled: async () => (await settings.getExperimental()).enableExternalObjects,
resolvers: [{ providerKey: "url", resolve: provider }] });
const f = await fixture("paused"); await svc.syncIssue(f.issueId);
await settings.updateExperimental({ enableExternalObjects: false });
await start(svc); await quiet();
await companyService(db).update(f.companyId, { status: "active" }); await quiet();
expect(provider).not.toHaveBeenCalled();
await settings.updateExperimental({ enableExternalObjects: true });
await settle(async () => (await row(f.companyId)).isTerminal); await quiet();
expect(provider).toHaveBeenCalledOnce();
});
it("settles empty, configured-idle and retained terminal history without recurring SQL or provider calls", async () => {
clock();
const svc = service(); await start(svc); await quiet();
const selects = vi.spyOn(db, "select");
await vi.advanceTimersByTimeAsync(15 * 60_000);
expect(selects).not.toHaveBeenCalled(); expect(provider).not.toHaveBeenCalled();
const f = await fixture(); await svc.syncIssue(f.issueId);
await settle(async () => (await row(f.companyId))?.isTerminal === true); await quiet();
expect((await row(f.companyId)).statusKey).toBe("done");
selects.mockClear(); provider.mockClear();
await vi.advanceTimersByTimeAsync(15 * 60_000);
expect(selects).not.toHaveBeenCalled(); expect(provider).not.toHaveBeenCalled();
expect(errors).not.toHaveBeenCalled();
});
it("registers exact future deadlines, preempts them on earlier writes and cancels terminal work", async () => {
clock(); provider.mockResolvedValue(active);
const svc = service(); await start(svc);
const f = await fixture(); await svc.syncIssue(f.issueId);
await settle(() => provider.mock.calls.length === 1);
await settle(async () => (await row(f.companyId)).lastResolvedAt !== null);
const saved = await row(f.companyId);
await settle(() => coordinator!.nextWakeAt() === saved.nextRefreshAt!.getTime());
const earlier = new Date(Date.now() + 1000); await change(f.companyId, { nextRefreshAt: earlier });
await settle(() => coordinator!.nextWakeAt() === earlier.getTime());
await vi.advanceTimersByTimeAsync(999); expect(provider).toHaveBeenCalledTimes(1);
provider.mockResolvedValue(terminal); await vi.advanceTimersByTimeAsync(1);
await settle(async () => (await row(f.companyId)).isTerminal); await quiet();
await vi.advanceTimersByTimeAsync(120_000); expect(provider).toHaveBeenCalledTimes(2);
});
it("keeps disabled and paused company work passive and reconstructs on eligibility mutation", async () => {
clock(); enabled = false;
const svc = service(); await start(svc); await quiet();
const f = await fixture("paused");
enabled = true; await svc.syncIssue(f.issueId); await quiet();
await vi.advanceTimersByTimeAsync(600_000); expect(provider).not.toHaveBeenCalled();
await db.transaction(async tx => {
await notifyExternalObjectRefresh(tx, f.companyId);
await tx.update(companies).set({ status: "active" }).where(eq(companies.id, f.companyId));
});
await settle(async () => (await row(f.companyId)).isTerminal); await quiet();
expect(provider).toHaveBeenCalledOnce();
});
it("waits for the outer commit and leaves rolled-back ingestion quiet", async () => {
clock(); const svc = service(); await start(svc); await quiet();
const f = await fixture();
await expect(db.transaction(async tx => {
await svc.syncIssue(f.issueId, tx); throw new Error("rollback");
})).rejects.toThrow("rollback");
await quiet(); expect(await row(f.companyId)).toBeUndefined(); expect(provider).not.toHaveBeenCalled();
let release!: () => void; const held = new Promise<void>(resolve => { release = resolve; });
let nestedDone = false;
const commit = db.transaction(async tx => {
await tx.transaction(async nested => { await svc.syncIssue(f.issueId, nested); });
nestedDone = true; await held;
});
await settle(() => nestedDone); await vi.advanceTimersByTimeAsync(60_000);
expect(provider).not.toHaveBeenCalled(); release(); await commit;
await settle(async () => (await row(f.companyId))?.isTerminal); await quiet();
expect(provider).toHaveBeenCalledOnce();
});
it("retains first work during drain and recovers a provider failure after restart", async () => {
clock(); const svc = service(); await start(svc); await quiet();
admitted = false; const f = await fixture(); await svc.syncIssue(f.issueId);
const selects = vi.spyOn(db, "select");
await vi.advanceTimersByTimeAsync(90_000); expect(provider).not.toHaveBeenCalled();
selects.mockClear(); await vi.advanceTimersByTimeAsync(90_000); expect(selects).not.toHaveBeenCalled();
admitted = true; provider.mockRejectedValueOnce(new Error("simulated transport failure"));
await vi.advanceTimersByTimeAsync(30_000); await settle(() => errors.mock.calls.length === 1);
const claimed = await row(f.companyId); expect(claimed.refreshToken).not.toBeNull();
await coordinator!.stop(); coordinator = undefined; await start(svc);
const due = claimed.refreshStartedAt!.getTime() + 300_000;
expect(coordinator!.nextWakeAt()).toBe(due);
await vi.advanceTimersByTimeAsync(due - Date.now() - 1); expect(provider).toHaveBeenCalledTimes(1);
await vi.advanceTimersByTimeAsync(1);
await settle(async () => (await row(f.companyId)).isTerminal); await quiet();
expect(provider).toHaveBeenCalledTimes(2);
});
it("leaves unsupported URLs passive and cancels orphan work until ordinary reattachment", async () => {
clock(); const unsupported = externalObjectService(db, { github: false });
await start(unsupported); const f = await fixture(); await unsupported.syncIssue(f.issueId); await quiet();
const selects = vi.spyOn(db, "select");
await vi.advanceTimersByTimeAsync(900_000); expect(selects).not.toHaveBeenCalled();
expect((await row(f.companyId)).lastResolvedAt).toBeNull();
await coordinator!.stop(); coordinator = undefined;
provider.mockResolvedValue(active); const svc = service(); await start(svc);
await settle(async () => (await row(f.companyId)).lastResolvedAt !== null);
await db.update(issues).set({ description: null }).where(eq(issues.id, f.issueId));
await svc.syncIssue(f.issueId); await quiet();
selects.mockClear(); provider.mockClear();
await vi.advanceTimersByTimeAsync(900_000);
expect(selects).not.toHaveBeenCalled(); expect(provider).not.toHaveBeenCalled();
provider.mockResolvedValue(terminal);
await db.update(issues).set({ description: `https://example.com/${f.companyId}` }).where(eq(issues.id, f.issueId));
await svc.syncIssue(f.issueId);
await settle(async () => (await row(f.companyId)).isTerminal); await quiet();
expect(provider).toHaveBeenCalledOnce();
});
it("activates a newly ready plugin and fences a result after company permission is withdrawn", async () => {
clock(); const registry = pluginRegistryService(db);
const manifest: PaperclipPluginManifestV1 = {
id: `paperclip.refresh-${randomUUID()}`, apiVersion: 1, version: "1.0.0", displayName: "Refresh fixture",
description: "Simulated external object provider", author: "Paperclip", categories: ["connector"],
capabilities: ["external.objects.detect", "external.objects.read"], entrypoints: { worker: "worker.js" },
objectReferences: [{ providerKey: "tracker", displayName: "Tracker", objectTypes: ["ticket"], urlPatterns: ["https://example.com/:id"] }],
};
const plugin = await registry.install({ packageName: "refresh-fixture" }, manifest);
let finish!: (result: ExternalObjectResolveResult) => void;
const calls = vi.fn(async (_id: string, method: string) => {
if (method === "detectExternalObjects") return { detections: [] };
if (calls.mock.calls.filter(call => call[1] === "resolveExternalObject").length === 1)
return new Promise<ExternalObjectResolveResult>(resolve => { finish = resolve; });
return terminal;
});
const svc = externalObjectService(db, { github: false,
pluginWorkerManager: { call: calls } as unknown as PluginWorkerManager,
detectors: [{ key: "fixture", detect: ({ urls }) => urls.map(canonical => ({ canonical,
detectorKey: "fixture", providerKey: "tracker", objectType: "ticket", externalId: canonical.canonicalIdentityHash })) }],
});
await start(svc); const f = await fixture(); await svc.syncIssue(f.issueId); await quiet();
const selects = vi.spyOn(db, "select");
await vi.advanceTimersByTimeAsync(900_000); expect(selects).not.toHaveBeenCalled(); expect(calls).not.toHaveBeenCalled();
await registry.updateStatus(plugin!.id, { status: "ready" });
await settle(() => typeof finish === "function");
await registry.upsertCompanySettings(plugin!.id, f.companyId, { enabled: false, settingsJson: {} });
finish(terminal);
await settle(async () => (await row(f.companyId)).refreshToken === null); await quiet();
expect((await row(f.companyId)).isTerminal).toBe(false);
selects.mockClear(); calls.mockClear();
await vi.advanceTimersByTimeAsync(900_000); expect(selects).not.toHaveBeenCalled(); expect(calls).not.toHaveBeenCalled();
calls.mockImplementation(async () => terminal);
await registry.upsertCompanySettings(plugin!.id, f.companyId, { enabled: true, settingsJson: {} });
await settle(async () => (await row(f.companyId)).isTerminal); await quiet();
expect(calls).toHaveBeenCalledOnce();
});
it.each(["company setting", "status", "uninstall", "manifest", "other company"] as const)(
"revalidates the selected plugin after %s changes even while the built-in fallback remains available", async change => {
clock(); const registry = pluginRegistryService(db);
const manifest: PaperclipPluginManifestV1 = {
id: `paperclip.selected-${randomUUID()}`, apiVersion: 1, version: "1.0.0", displayName: "Selected provider",
description: "Selected resolver fixture", author: "Paperclip", categories: ["connector"],
capabilities: ["external.objects.detect", "external.objects.read"], entrypoints: { worker: "worker.js" },
objectReferences: [{ providerKey: "github", displayName: "GitHub", objectTypes: ["pull_request"], urlPatterns: ["https://github.com/:owner/:repo/pull/:id"] }],
};
const plugin = await registry.install({ packageName: "selected-provider-fixture" }, manifest);
await registry.updateStatus(plugin!.id, { status: "ready" });
let finishPlugin!: (result: ExternalObjectResolveResult) => void;
const pluginResult = new Promise<ExternalObjectResolveResult>(resolve => { finishPlugin = resolve; });
let selected = false;
const calls = vi.fn(async (_id: string, method: string) => {
if (method === "detectExternalObjects") return { detections: [] };
selected = true; return pluginResult;
});
let finishFallback!: () => void;
const fallbackResult = new Promise<void>(resolve => { finishFallback = resolve; });
const fallback = vi.fn(async () => {
await fallbackResult;
return new Response(JSON.stringify({ state: "closed", merged: true, title: "Allowed fallback" }), { status: 200 });
});
const svc = externalObjectService(db, { pluginWorkerManager: { call: calls } as unknown as PluginWorkerManager,
github: { fetch: fallback, credentialProvider: () => ({ token: "simulated-company-token", source: "company_secret", secretName: "GITHUB_TOKEN" }) } });
try {
await start(svc); const f = await fixture();
await db.update(issues).set({ description: "https://github.com/acme/app/pull/42" }).where(eq(issues.id, f.issueId));
await svc.syncIssue(f.issueId); await settle(() => selected);
if (change === "company setting") await registry.upsertCompanySettings(plugin!.id, f.companyId, { enabled: false, settingsJson: {} });
else if (change === "status") await registry.updateStatus(plugin!.id, { status: "error" });
else if (change === "uninstall") await registry.uninstall(plugin!.id, true);
else if (change === "manifest") await registry.update(plugin!.id, { manifest: { ...manifest, capabilities: [], objectReferences: [] } });
else {
const other = await fixture();
await registry.upsertCompanySettings(plugin!.id, other.companyId, { enabled: false, settingsJson: {} });
}
finishPlugin({ ok: true, snapshot: { statusKey: "plugin_result", statusCategory: "succeeded", statusTone: "success", isTerminal: true } });
if (change === "other company") {
await settle(async () => (await row(f.companyId))?.statusKey === "plugin_result"); await quiet();
expect(fallback).not.toHaveBeenCalled();
} else {
await settle(async () => fallback.mock.calls.length > 0 || Boolean((await row(f.companyId))?.lastResolvedAt));
const beforeFallback = await row(f.companyId);
expect(beforeFallback.isTerminal).toBe(false); expect(beforeFallback.statusKey).toBeNull(); expect(beforeFallback.lastResolvedAt).toBeNull();
expect(fallback).toHaveBeenCalledOnce();
finishFallback();
await settle(async () => (await row(f.companyId))?.statusKey === "merged"); await quiet();
expect((await row(f.companyId)).displayTitle).toBe("acme/app#42: Allowed fallback");
}
} finally { finishPlugin(terminal); finishFallback(); }
});
it("reactivates refresh after ordinary budget pause and budget raise", async () => {
clock(); const svc = service(); provider.mockResolvedValue(active); await start(svc);
const f = await fixture(); await svc.syncIssue(f.issueId);
await settle(async () => (await row(f.companyId))?.lastResolvedAt !== null);
await db.insert(costEvents).values({ companyId: f.companyId, usageKind: "decision", provider: "fixture",
biller: "fixture", billingType: "metered_api", model: "simulated", costCents: 200, occurredAt: new Date() });
const budgets = budgetService(db);
await budgets.upsertPolicy(f.companyId, { scopeType: "company", scopeId: f.companyId,
amount: 100, hardStopEnabled: true }, null);
expect((await db.select().from(companies).where(eq(companies.id, f.companyId)))[0]!.status).toBe("paused");
await quiet();
const reads = vi.spyOn(db, "select"); provider.mockClear();
await vi.advanceTimersByTimeAsync(900_000); expect(reads).not.toHaveBeenCalled(); expect(provider).not.toHaveBeenCalled();
provider.mockResolvedValue(terminal);
await budgets.upsertPolicy(f.companyId, { scopeType: "company", scopeId: f.companyId, amount: 300 }, null);
await settle(async () => (await row(f.companyId)).isTerminal); await quiet();
expect(provider).toHaveBeenCalledOnce();
});
it.each(["comment", "document"] as const)("keeps hard-deleted %s activation scoped to its retained mention owner", async kind => {
clock(); const svc = service(); provider.mockResolvedValue(active); await start(svc);
const a = await fixture(); const b = await fixture(); await svc.syncIssue(b.issueId);
let id: string;
if (kind === "comment") {
const [comment] = await db.insert(issueComments).values({ companyId: a.companyId, issueId: a.issueId,
body: `https://example.com/${a.companyId}` }).returning();
id = comment!.id; await svc.syncComment(id);
} else {
const result = await documentService(db).upsertIssueDocument({ issueId: a.issueId,
key: "notes", format: "markdown", body: `https://example.com/${a.companyId}` });
id = result.document.id; await svc.syncDocument(id);
}
await settle(async () => {
const left = await row(a.companyId), right = await row(b.companyId);
return Boolean(left?.lastResolvedAt && right?.lastResolvedAt);
});
const expectedDeadline = Math.min((await row(a.companyId)).nextRefreshAt!.getTime(), (await row(b.companyId)).nextRefreshAt!.getTime());
await settle(() => coordinator!.nextWakeAt() === expectedDeadline && !databaseWorkPending(db, DELIVERY_QUEUES.externalObjectRefresh));
const reads: Array<{ query: string; params: unknown[] }> = [];
const debug = db.$client.options.debug;
db.$client.options.debug = (_connection, query, params) => {
if (/^select/i.test(query) && query.includes('from "external_objects"') && query.includes('inner join "companies"'))
reads.push({ query, params: [...params] });
};
try {
if (kind === "comment") { await db.delete(issueComments).where(eq(issueComments.id, id)); await svc.syncComment(id); }
else { await documentService(db).deleteIssueDocument(a.issueId, "notes"); await svc.syncDocument(id); }
await settle(() => reads.length > 0);
for (const read of reads) {
expect(read.query).toContain('"external_objects"."company_id" =');
expect(read.params).toContain(a.companyId); expect(read.params).not.toContain(b.companyId);
}
} finally { db.$client.options.debug = debug; }
expect(provider).toHaveBeenCalledTimes(2);
});
it("coalesces repeated company status writes without rebuilding every future object", async () => {
clock(); const svc = service(); const own = await fixture(), foreign = await fixture();
const future = new Date(Date.now() + 86_400_000);
for (let offset = 0; offset < 1100; offset += 250) {
const ids = Array.from({ length: Math.min(250, 1100 - offset) }, () => randomUUID());
await db.insert(externalObjects).values(ids.map(id => ({ id, companyId: own.companyId,
providerKey: "url", objectType: "link", externalId: id, nextRefreshAt: future })));
await db.insert(externalObjectMentions).values(ids.map(objectId => ({ companyId: own.companyId,
sourceIssueId: own.issueId, sourceKind: "description" as const, objectId })));
}
await svc.syncIssue(foreign.issueId);
await db.update(externalObjects).set({ nextRefreshAt: future });
await start(svc);
await settle(() => coordinator!.nextWakeAt() === future.getTime());
const reads: Array<{ query: string; params: unknown[] }> = [];
const debug = db.$client.options.debug;
db.$client.options.debug = (_connection, query, params) => {
if (/^select/i.test(query) && query.includes('from "external_objects"') && query.includes('inner join "companies"'))
reads.push({ query, params: [...params] });
};
try {
const companiesSvc = companyService(db);
await companiesSvc.update(own.companyId, { status: "paused" });
await settle(() => reads.length === 1 && coordinator!.nextWakeAt() === future.getTime()
&& !databaseWorkPending(db, DELIVERY_QUEUES.externalObjectRefresh));
for (const status of ["active", "paused", "active", "paused", "active"] as const) {
await companiesSvc.update(own.companyId, { status });
await settle(() => !databaseWorkPending(db, DELIVERY_QUEUES.externalObjectRefresh)
&& (coordinator!.nextWakeAt() ?? 0) > Date.now());
expect(reads).toHaveLength(1);
}
const rebuildAt = coordinator!.nextWakeAt()!;
expect(rebuildAt - Date.now()).toBeGreaterThan(20_000);
expect(rebuildAt - Date.now()).toBeLessThanOrEqual(30_000);
await vi.advanceTimersByTimeAsync(rebuildAt - Date.now());
await settle(() => coordinator!.nextWakeAt() === future.getTime() && reads.length === 6);
for (const read of reads) {
expect(read.query).toContain('"external_objects"."company_id" =');
expect(read.params).toContain(own.companyId);
expect(read.params).not.toContain(foreign.companyId);
expect(read.params.at(-1)).toBe(250);
}
const count = reads.length;
await vi.advanceTimersByTimeAsync(20 * 60_000);
expect(reads).toHaveLength(count); expect(provider).not.toHaveBeenCalled();
expect(coordinator!.nextWakeAt()).toBe(future.getTime());
expect(errors).not.toHaveBeenCalled();
} finally { db.$client.options.debug = debug; }
});
it("scopes repeated issue deletions to cascaded source objects and cancels their last future mention", async () => {
clock(); const svc = service();
const own = await fixture(), foreign = await fixture();
const future = new Date(Date.now() + 86_400_000), removedDeadline = new Date(Date.now() + 1_800_000);
const sharedUrl = "https://example.com/shared-issue-object";
const [retained] = await db.insert(issues).values({ companyId: own.companyId, title: "Retained",
description: sharedUrl }).returning();
await svc.syncIssue(retained!.id);
await db.update(issues).set({ description: sharedUrl }).where(eq(issues.id, foreign.issueId));
await svc.syncIssue(foreign.issueId);
const deletions: Array<{ id: string; affected: string[]; orphaned: string[] }> = [];
for (let index = 0; index < 3; index++) {
const [issue] = await db.insert(issues).values({ companyId: own.companyId,
title: sharedUrl, description: `https://example.com/deleted-${index}` }).returning();
await svc.syncIssue(issue!.id);
const [comment] = await db.insert(issueComments).values({ companyId: own.companyId, issueId: issue!.id,
body: `https://example.com/comment-${index}` }).returning();
await svc.syncComment(comment!.id);
const doc = await documentService(db).upsertIssueDocument({ issueId: issue!.id, key: "notes", format: "markdown",
body: `https://example.com/document-${index}` });
await svc.syncDocument(doc.document.id);
const mentions = await db.select().from(externalObjectMentions).where(and(
eq(externalObjectMentions.companyId, own.companyId), eq(externalObjectMentions.sourceIssueId, issue!.id)));
expect(new Set(mentions.map(mention => mention.sourceKind))).toEqual(new Set(["title", "description", "comment", "document"]));
deletions.push({ id: issue!.id, affected: [...new Set(mentions.map(mention => mention.objectId!))],
orphaned: mentions.filter(mention => mention.sourceKind !== "title").map(mention => mention.objectId!) });
}
const shared = (await db.select().from(externalObjectMentions).where(eq(externalObjectMentions.sourceIssueId, retained!.id)))[0]!.objectId!;
for (let offset = 0; offset < 1100; offset += 250) {
const ids = Array.from({ length: Math.min(250, 1100 - offset) }, () => randomUUID());
await db.insert(externalObjects).values(ids.map(id => ({ id, companyId: own.companyId,
providerKey: "url", objectType: "link", externalId: id, nextRefreshAt: future })));
await db.insert(externalObjectMentions).values(ids.map(objectId => ({ companyId: own.companyId,
sourceIssueId: own.issueId, sourceKind: "description" as const, objectId })));
}
await db.update(externalObjects).set({ nextRefreshAt: future });
for (const entry of deletions) for (const id of entry.orphaned)
await db.update(externalObjects).set({ nextRefreshAt: removedDeadline }).where(eq(externalObjects.id, id));
await start(svc);
await settle(() => coordinator!.nextWakeAt() === removedDeadline.getTime() && !databaseWorkPending(db, DELIVERY_QUEUES.externalObjectRefresh));
expect(provider).not.toHaveBeenCalled();
const reads: Array<{ query: string; params: unknown[] }> = [];
const selections: Array<{ query: string; params: unknown[] }> = [];
const debug = db.$client.options.debug;
db.$client.options.debug = (_connection, query, params) => {
if (/^select/i.test(query) && query.includes('from "external_objects"') && query.includes('inner join "companies"'))
reads.push({ query, params: [...params] });
if (/^select distinct/i.test(query) && query.includes('from "external_object_mentions"'))
selections.push({ query, params: [...params] });
};
try {
for (let index = 0; index < deletions.length; index++) {
const entry = deletions[index], first = reads.length;
const result = await issueService(db).remove(entry.id);
expect(result?.id).toBe(entry.id);
const next = index === deletions.length - 1 ? future : removedDeadline;
await settle(() => reads.length > first && coordinator!.nextWakeAt() === next.getTime()
&& !databaseWorkPending(db, DELIVERY_QUEUES.externalObjectRefresh));
const deletionReads = reads.slice(first);
expect(deletionReads.length).toBeLessThanOrEqual(entry.affected.length);
for (const read of deletionReads) {
expect(read.query).toContain('"external_objects"."id" =');
expect(read.params).toContain(own.companyId); expect(read.params).not.toContain(foreign.companyId);
expect(read.params.some(value => entry.affected.includes(String(value)))).toBe(true);
}
}
expect(selections).toHaveLength(deletions.length);
for (let index = 0; index < selections.length; index++) {
expect(selections[index]!.query).toContain('"external_object_mentions"."company_id" =');
expect(selections[index]!.query).toContain('"external_object_mentions"."source_issue_id" =');
expect(selections[index]!.params).toContain(own.companyId); expect(selections[index]!.params).toContain(deletions[index]!.id);
}
const lastMentions = await db.select().from(externalObjectMentions).where(eq(externalObjectMentions.objectId, shared));
expect(lastMentions).toHaveLength(1); expect(lastMentions[0]!.sourceIssueId).toBe(retained!.id);
const orphanIds = deletions.flatMap(entry => entry.orphaned);
const orphanRows = await db.select().from(externalObjects).where(inArray(externalObjects.id, orphanIds));
expect(orphanRows).toHaveLength(orphanIds.length);
for (const orphan of orphanRows) expect(orphan.nextRefreshAt).toEqual(removedDeadline);
expect(await db.select().from(externalObjectMentions).where(inArray(externalObjectMentions.objectId, orphanIds))).toEqual([]);
const foreignRows = await db.select().from(externalObjects).where(eq(externalObjects.companyId, foreign.companyId));
expect(foreignRows).toHaveLength(1); expect(foreignRows[0]!.nextRefreshAt).toEqual(future);
const count = reads.length;
await vi.advanceTimersByTimeAsync(removedDeadline.getTime() - Date.now() + 1);
expect(reads).toHaveLength(count); expect(provider).not.toHaveBeenCalled();
expect(coordinator!.nextWakeAt()).toBe(future.getTime());
} finally { db.$client.options.debug = debug; }
});
it("keeps warm standby startup SQL-free and resumes a first committed producer", async () => {
clock(); admitted = false; reconcile = false;
const svc = service(); const selects = vi.spyOn(db, "select");
await start(svc); await vi.advanceTimersByTimeAsync(90_000);
expect(selects).not.toHaveBeenCalled();
const f = await fixture(); await svc.syncIssue(f.issueId);
selects.mockClear(); await vi.advanceTimersByTimeAsync(90_000);
expect(selects).not.toHaveBeenCalled(); expect(provider).not.toHaveBeenCalled();
admitted = true; reconcile = true;
await vi.advanceTimersByTimeAsync(30_000);
await settle(async () => (await row(f.companyId))?.isTerminal); await quiet();
expect(provider).toHaveBeenCalledOnce();
});
it("renews an active provider lease so another service cannot duplicate its action", async () => {
clock(); const svc = service(); await start(svc);
let finish!: (result: ExternalObjectResolveResult) => void;
provider.mockImplementationOnce(() => new Promise(resolve => { finish = resolve; }));
const f = await fixture(); await svc.syncIssue(f.issueId);
await settle(() => provider.mock.calls.length === 1);
const claimed = await row(f.companyId);
await vi.advanceTimersByTimeAsync(60_000);
await settle(async () => (await row(f.companyId)).refreshStartedAt!.getTime() > claimed.refreshStartedAt!.getTime());
const competing = await service().refreshObject(claimed.id, { companyId: f.companyId,
force: true, now: new Date(claimed.refreshStartedAt!.getTime() + 301_000) });
expect(competing.reason).toBe("refresh_in_progress"); expect(provider).toHaveBeenCalledOnce();
finish(terminal); await settle(async () => (await row(f.companyId)).isTerminal); await quiet();
});
it("uses durable provider retry deadlines and cancels the observed result on shutdown without overlap", async () => {
clock(); const svc = service(); await start(svc);
provider.mockResolvedValueOnce({ ok: false, liveness: "rate_limited", errorCode: "slow_down", retryAfterSeconds: 5 });
const f = await fixture(); await svc.syncIssue(f.issueId);
await settle(async () => (await row(f.companyId))?.lastErrorCode === "slow_down");
const saved = await row(f.companyId);
await settle(() => coordinator!.nextWakeAt() === saved.nextRefreshAt!.getTime());
expect(saved.refreshToken).toBeNull();
await vi.advanceTimersByTimeAsync(saved.nextRefreshAt!.getTime() - Date.now() - 1);
expect(provider).toHaveBeenCalledOnce();
let finish!: (result: ExternalObjectResolveResult) => void;
provider.mockImplementationOnce(() => new Promise(resolve => { finish = resolve; }));
await vi.advanceTimersByTimeAsync(1); await settle(() => provider.mock.calls.length === 2);
await svc.syncIssue(f.issueId); await vi.advanceTimersByTimeAsync(0);
expect(provider).toHaveBeenCalledTimes(2);
let stopped = false; const stop = coordinator!.stop().then(() => { stopped = true; });
await stop; expect(stopped).toBe(true); coordinator = undefined;
const cancelled = await row(f.companyId); expect(cancelled.refreshToken).toBeNull(); expect(cancelled.isTerminal).toBe(false);
finish(terminal); await delay(10);
expect((await row(f.companyId)).isTerminal).toBe(false);
const selects = vi.spyOn(db, "select");
await vi.advanceTimersByTimeAsync(600_000);
expect(selects).not.toHaveBeenCalled(); expect(provider).toHaveBeenCalledTimes(2);
});
it("cancels an actual stalled GitHub HTTP body, retains due debt and resumes after restart", async () => {
clock(); let stall = true, started = false, closed = false;
const server = createServer((request, response) => {
if (request.url?.includes("/pulls/")) {
if (stall) {
started = true; response.on("close", () => { closed = true; });
response.writeHead(200, { "content-type": "application/json" }); response.write('{"state":');
} else response.end(JSON.stringify({ state: "closed", merged: true, title: "Done" }));
} else response.end(JSON.stringify({ private: false }));
});
await new Promise<void>(resolve => server.listen(0, "127.0.0.1", resolve));
const address = server.address(); if (!address || typeof address === "string") throw new Error("Missing HTTP test port");
const svc = externalObjectService(db, { github: {
fetch: (url, init) => fetch(`http://127.0.0.1:${address.port}${new URL(url).pathname}`, init),
credentialProvider: () => ({ token: "simulated-company-token", source: "company_secret", secretName: "GITHUB_TOKEN" }),
} });
try {
await start(svc); const f = await fixture();
await db.update(issues).set({ description: "https://github.com/acme/app/pull/42" }).where(eq(issues.id, f.issueId));
await svc.syncIssue(f.issueId); await settle(() => started);
await coordinator!.stop(); coordinator = undefined;
await settle(() => closed);
const cancelled = await row(f.companyId);
expect(cancelled.refreshToken).toBeNull(); expect(cancelled.lastResolvedAt).toBeNull();
expect(cancelled.nextRefreshAt!.getTime()).toBeLessThanOrEqual(Date.now());
stall = false; await start(svc);
await settle(async () => Boolean((await row(f.companyId))?.isTerminal)); await quiet();
} finally { await coordinator?.stop(); coordinator = undefined; server.closeAllConnections(); await new Promise<void>(resolve => server.close(() => resolve())); }
});
it("loads only the changed identity and objects after ingestion into ten thousand future objects", async () => {
clock(); const svc = service(); const f = await fixture();
const future = new Date(Date.now() + 86_400_000);
const ids = Array.from({ length: 10_000 }, () => randomUUID());
for (let offset = 0; offset < ids.length; offset += 500) {
const batch = ids.slice(offset, offset + 500);
await db.insert(externalObjects).values(batch.map(id => ({ id, companyId: f.companyId,
providerKey: "url", objectType: "link", externalId: id, nextRefreshAt: future })));
await db.insert(externalObjectMentions).values(batch.map(objectId => ({ companyId: f.companyId,
sourceIssueId: f.issueId, sourceKind: "description" as const, objectId })));
}
await start(svc);
await vi.waitFor(() => {
expect(coordinator!.nextWakeAt()).toBe(future.getTime());
}, { timeout: 10_000, interval: 5 });
const [incoming] = await db.insert(issues).values({ companyId: f.companyId, title: "Incoming",
description: "https://example.com/new-object" }).returning();
const reads: Array<{ query: string; params: unknown[] }> = [];
const debug = db.$client.options.debug;
db.$client.options.debug = (_connection, query, params) => {
if (/^select/i.test(query) && query.includes('from "external_objects"') && query.includes('inner join "companies"'))
reads.push({ query, params: [...params] });
};
try {
await svc.syncIssue(incoming!.id);
await settle(() => provider.mock.calls.length === 1);
await settle(() => coordinator!.nextWakeAt() === future.getTime() && !databaseWorkPending(db, DELIVERY_QUEUES.externalObjectRefresh));
expect(reads.length).toBeGreaterThan(0); expect(reads.length).toBeLessThanOrEqual(6);
for (const read of reads) expect(read.query).toMatch(/"external_objects"\."(?:id|external_id)" =/);
} finally { db.$client.options.debug = debug; }
});
it("reconstructs paginated multi-company work and never invokes inactive or never-refresh objects", async () => {
clock(); const svc = service(); const a = await fixture(); const b = await fixture(); const inactive = await fixture("paused");
for (const companyId of [b.companyId, inactive.companyId]) {
await db.insert(externalObjects).values(Array.from({ length: 255 }, (_, index) => ({
companyId, providerKey: "url", objectType: "link", externalId: String(index),
sanitizedCanonicalUrl: `https://example.com/${companyId}/${index}`, canonicalIdentityHash: `${companyId}-${index}`,
nextRefreshAt: null,
})));
}
await db.update(issues).set({ description: Array.from({ length: 255 }, (_, index) =>
`https://example.com/${a.companyId}/${index}`).join(" ") }).where(eq(issues.id, a.issueId));
await svc.syncIssue(a.issueId);
const future = new Date(Date.now() + 60_000);
await db.update(externalObjects).set({ nextRefreshAt: future }).where(eq(externalObjects.companyId, a.companyId));
await svc.syncIssue(b.issueId);
await start(svc); await settle(() => provider.mock.calls.length === 1);
await settle(() => coordinator!.nextWakeAt() === future.getTime());
expect((await row(a.companyId)).nextRefreshAt).toEqual(future);
const companiesSeen = provider.mock.calls.map(call => (call as unknown as [{ companyId: string }])[0].companyId);
expect(companiesSeen).toEqual([b.companyId]);
await change(a.companyId, { isTerminal: true }); await quiet();
await vi.advanceTimersByTimeAsync(600_000); expect(provider).toHaveBeenCalledOnce();
});
});