mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-23 00:53:38 +02:00
## Thinking Path > - Paperclip runs agents through local adapters and the native runner. > - Both paths must use the same installed provider CLI. > - New models require current harness releases. > - The runner still pins Codex 0.153.4, Claude SDK 0.3.263, and OpenCode 1.18.29. > - Changing the image alone would fail the runner's exact version and executable checks. > - This pull request updates those dependencies, integrity checks, controller checks, and image pins together. > - Shared installations can then run the current models without a task-time download. ## Linked Issues or Issue Description Refs #13829, which updates model choices and reasoning controls. Searches found no open PR that updates these runtime pins. **Current behavior** The shared provider pack ships old CLIs. Claude Code 2.1.263 cannot run Opus 5.5, which requires 2.1.280. Remote controllers reject provider packs whose versions differ from their declared pins. **Proposed behavior** Use Codex 0.156.0, Claude Agent SDK 0.3.280 / Claude Code 2.1.280, and OpenCode 1.18.32 throughout the runner. Keep the reviewed ACP bridge patches and one shared CLI installation per provider. **Reason and benefit** Current harnesses support the new model IDs while preserving executable verification and remote provider-pack compatibility checks. ## What Changed - Update dependency overrides, the Codex ACP package patch, runtime profiles, and remote controller pins. - Verify the new Claude Linux x64 and macOS arm64/x64 executables and Codex Linux x64 executable against integrity-verified npm archives. - Refresh OpenCode version checks, fixtures, and the runner configuration label. - Refresh the eval image's Grok, Gemini, Kimi, Cursor, and GitHub CLI pins and archive hashes. Hermes remains current at 0.19.0. - Refresh the build-time lock digest from clean pnpm 9.15.4 resolution. Leave lockfile commits to repository automation. - Document model compatibility and the separation between CLI runtimes and patched ACP bridges. ## Verification - `pnpm -r typecheck` and `pnpm build` passed. - Rust workspace release tests passed. - Package/patch and OpenCode binary-materialization contract tests: 11 passed. - Real Codex 0.156.0 startup-ownership and paginated session-resume probes passed with isolated synthetic homes and no model turn. - Codex app-server `thread/start` preserved `gpt-6-sol` and `gpt-6-luna`; no `turn/start` was sent. An unauthenticated built-in catalog does not include those account-served entries. - Installed Claude integrity probes passed for `claude-opus-5-5` and `claude-fable-5-1`. - `pnpm --filter @paperclipai/paperclip-runner test:opencode:qualification` passed with the actual OpenCode 1.18.32 executable under Node 24 and Node 25. The loopback provider exercise covers health/version, session creation/read/delete, SSE, and a completed async prompt. - `pnpm check:token-gates` passed. - The targeted runner suite passed 130 tests. Three macOS failures in snapshot module lookup and OpenCode final-message selection also reproduce on the unchanged base; Linux CI will provide the platform check. - [Final Linux CI](https://github.com/paperclipai/paperclip/actions/runs/35798076399): all gates passed. Four jobs needed one retry after their CI workers received shutdown signals. The PR has 55 successful checks, two skipped checks, Greptile 5/5, and no unresolved review threads. - Changed runner configuration UI tests: 5 passed. - Full macOS `pnpm test:run` reached 13,094 passing server tests, 84 skipped, and 18 failures before the wrapper stopped. Failures involved skill-cache publication permissions, missing bundled connector skills in the worktree, and a conversation-reset timing case. The 10 cache permission failures reproduce on the unchanged base; both conversation-reset cases passed on a targeted retry. The wrapper did not reach its later workspace/serialized groups locally; Linux CI covers those groups. - The local Docker daemon did not respond, so no local Docker build was run. No billable model requests were made. ## Risks - Deploy the matching controller and provider pack together. Older controllers enforce their previous exact pins. - Current upstream CLIs can change behavior. Existing protocol tests and isolated real Codex probes cover the integration boundaries; authenticated model inference is not part of these checks. - ACP bridge package versions and executable digests stay unchanged because their executable bytes are unchanged. Only the underlying CLI/SDK dependencies move. - No schema migration. Revert the runtime and image pins together to roll back. ## Model Used OpenAI GPT-6 via Codex, with repository tools, code execution, and web research. The exact serving model ID and context window were not exposed by this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass for the changed surfaces and real-executable probes; full macOS-suite limitations are listed above - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
215 lines
7.0 KiB
JavaScript
215 lines
7.0 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import { createHash } from "node:crypto";
|
|
import { readFile } from "node:fs/promises";
|
|
import { createRequire } from "node:module";
|
|
import { dirname, resolve } from "node:path";
|
|
import test from "node:test";
|
|
|
|
const runnerPackage = JSON.parse(
|
|
await readFile(new URL("../package.json", import.meta.url), "utf8"),
|
|
);
|
|
const rootPackage = JSON.parse(
|
|
await readFile(new URL("../../../package.json", import.meta.url), "utf8"),
|
|
);
|
|
const workspace = await readFile(
|
|
new URL("../../../pnpm-workspace.yaml", import.meta.url),
|
|
"utf8",
|
|
);
|
|
const acpxPatch = await readFile(
|
|
new URL("../../../patches/acpx@0.13.1.patch", import.meta.url),
|
|
"utf8",
|
|
);
|
|
const codexPatch = await readFile(
|
|
new URL(
|
|
"../../../patches/@agentclientprotocol__codex-acp@1.6.2.patch",
|
|
import.meta.url,
|
|
),
|
|
"utf8",
|
|
);
|
|
const claudePatch = await readFile(
|
|
new URL(
|
|
"../../../patches/@agentclientprotocol__claude-agent-acp@0.73.0.patch",
|
|
import.meta.url,
|
|
),
|
|
"utf8",
|
|
);
|
|
const qualifiedProfiles = await readFile(
|
|
new URL("../src/drivers/acpx/qualified-profiles.ts", import.meta.url),
|
|
"utf8",
|
|
);
|
|
const runnerdAcpxBackend = await readFile(
|
|
new URL(
|
|
"../runner/crates/runner-core/src/acpx_provider_backend.rs",
|
|
import.meta.url,
|
|
),
|
|
"utf8",
|
|
);
|
|
const providerPackBuilder = await readFile(
|
|
new URL("../scripts/build-provider-pack.mjs", import.meta.url),
|
|
"utf8",
|
|
);
|
|
const nativeSessionExecutor = await readFile(
|
|
new URL(
|
|
"../../../server/src/services/native-runtime/native-session-executor.ts",
|
|
import.meta.url,
|
|
),
|
|
"utf8",
|
|
);
|
|
|
|
test("the runner pins every qualified ACPX production dependency", () => {
|
|
assert.equal(runnerPackage.dependencies["@openai/codex"], "0.156.0");
|
|
assert.equal(runnerPackage.dependencies["@anthropic-ai/claude-agent-sdk"], undefined);
|
|
assert.equal(rootPackage.pnpm.overrides["@agentclientprotocol/codex-acp@1.6.2>@openai/codex"], runnerPackage.dependencies["@openai/codex"]);
|
|
assert.equal(rootPackage.pnpm.overrides["@agentclientprotocol/claude-agent-acp@0.73.0>@anthropic-ai/claude-agent-sdk"], "0.3.280");
|
|
assert.equal(runnerPackage.optionalDependencies, undefined);
|
|
assert.equal(runnerPackage.dependencies.node, undefined);
|
|
assert.equal(runnerPackage.dependencies.acpx, "0.13.1");
|
|
assert.equal(
|
|
runnerPackage.dependencies["@agentclientprotocol/codex-acp"],
|
|
"1.6.2",
|
|
);
|
|
assert.equal(
|
|
runnerPackage.dependencies["@agentclientprotocol/claude-agent-acp"],
|
|
"0.73.0",
|
|
);
|
|
});
|
|
|
|
test("the patched Codex ACP executable digest stays aligned across launch boundaries", async () => {
|
|
const profileMatch =
|
|
/agent: "codex"[\s\S]*?commandDigest:\s*"(sha256:[a-f0-9]{64})"/.exec(
|
|
qualifiedProfiles,
|
|
);
|
|
assert.ok(profileMatch, "qualified Codex ACPX profile digest");
|
|
const digest = profileMatch[1];
|
|
const packagePath = createRequire(import.meta.url).resolve("@agentclientprotocol/codex-acp/package.json");
|
|
const installed = JSON.parse(await readFile(packagePath, "utf8"));
|
|
const executable = await readFile(resolve(dirname(packagePath), installed.bin["codex-acp"]));
|
|
assert.equal(digest, `sha256:${createHash("sha256").update(executable).digest("hex")}`,
|
|
"the identity binds installed executable bytes, not the patch file");
|
|
|
|
assert.match(runnerdAcpxBackend, new RegExp(`"codex"[\\s\\S]*?${digest}`));
|
|
assert.match(
|
|
providerPackBuilder,
|
|
new RegExp(`acpxProfileDigests:[\\s\\S]*?codex:[\\s\\S]*?${digest}`),
|
|
);
|
|
assert.match(
|
|
nativeSessionExecutor,
|
|
new RegExp(
|
|
`REMOTE_PROVIDER_PACK_PROFILE_DIGESTS[\\s\\S]*?codex:[\\s\\S]*?${digest}`,
|
|
),
|
|
);
|
|
});
|
|
|
|
test("the package exposes only the reviewed runner CLI binaries", () => {
|
|
assert.deepEqual(runnerPackage.bin, {
|
|
"paperclip-runner-eval-session": "./dist/cli/eval-session.js",
|
|
"paperclip-runner-codex-proxy": "./dist/cli/codex-app-server-unix-proxy.js",
|
|
"paperclip-runner-acpx-sidecar": "./dist/cli/acpx-runtime-sidecar.js",
|
|
"paperclip-runner-opencode-proxy":
|
|
"./dist/cli/opencode-app-server-proxy.js",
|
|
});
|
|
});
|
|
|
|
test("old and new pnpm configuration both apply the exact runtime patches", () => {
|
|
assert.equal(
|
|
rootPackage.pnpm.patchedDependencies["acpx@0.13.1"],
|
|
"patches/acpx@0.13.1.patch",
|
|
);
|
|
assert.equal(
|
|
rootPackage.pnpm.patchedDependencies[
|
|
"@agentclientprotocol/claude-agent-acp@0.73.0"
|
|
],
|
|
"patches/@agentclientprotocol__claude-agent-acp@0.73.0.patch",
|
|
);
|
|
assert.equal(
|
|
rootPackage.pnpm.patchedDependencies[
|
|
"@agentclientprotocol/codex-acp@1.6.2"
|
|
],
|
|
"patches/@agentclientprotocol__codex-acp@1.6.2.patch",
|
|
);
|
|
assert.match(workspace, /acpx@0\.13\.1: patches\/acpx@0\.13\.1\.patch/);
|
|
assert.match(
|
|
workspace,
|
|
/codex-acp@1\.6\.2["']: patches\/@agentclientprotocol__codex-acp@1\.6\.2\.patch/,
|
|
);
|
|
assert.match(
|
|
workspace,
|
|
/claude-agent-acp@0\.73\.0["']: patches\/@agentclientprotocol__claude-agent-acp@0\.73\.0\.patch/,
|
|
);
|
|
assert.equal(rootPackage.pnpm.patchedDependencies["node@24.11.0"], undefined);
|
|
assert.doesNotMatch(workspace, /node@24\.11\.0:/);
|
|
assert.match(
|
|
providerPackBuilder,
|
|
/copyFileSync\(process\.execPath, stableNodeCommand\)/,
|
|
);
|
|
assert.match(codexPatch, /\+ "@openai\/codex": "0\.156\.0"/);
|
|
});
|
|
|
|
test("the ACPX patch preserves launch-only state and verified spawning", () => {
|
|
for (const token of [
|
|
"spawnEnvironment",
|
|
"spawnCwd",
|
|
"spawnAgent",
|
|
"SpawnOptionsWithoutStdio",
|
|
"this.options.spawnAgent",
|
|
]) {
|
|
assert.match(acpxPatch, new RegExp(token));
|
|
}
|
|
});
|
|
|
|
test("the ACPX patch fails closed on an invalid spawn environment", () => {
|
|
for (const token of [
|
|
"isPlainStringEnvironment",
|
|
"Object.getPrototypeOf(value)",
|
|
'Object.values(value).every((entry) => typeof entry === "string")',
|
|
"spawnEnvironment !== void 0",
|
|
"sourceEnvironment = spawnEnvironment()",
|
|
"ACPX spawn environment must be a plain record of string values",
|
|
]) {
|
|
assert.match(
|
|
acpxPatch,
|
|
new RegExp(token.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")),
|
|
);
|
|
}
|
|
assert.doesNotMatch(acpxPatch, /spawnEnvironment\?\.\(\)/);
|
|
assert.doesNotMatch(
|
|
acpxPatch,
|
|
/spawnEnvironment \? \{ \.\.\.spawnEnvironment \} : \{ \.\.\.process\.env \}/,
|
|
);
|
|
});
|
|
|
|
test("the Codex patch enforces isolated instructions, tools, and skills", () => {
|
|
for (const token of [
|
|
"PAPERCLIP_ACPX_ISOLATED_CONTEXT",
|
|
"baseInstructions",
|
|
"rawInput: { serverName: params.serverName }",
|
|
'"features.apps": false',
|
|
"process.env.CODEX_HOME",
|
|
]) {
|
|
assert.match(
|
|
codexPatch,
|
|
new RegExp(token.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")),
|
|
);
|
|
}
|
|
});
|
|
|
|
test("the Codex patch keeps MCP tool approvals on the governed permission channel", () => {
|
|
assert.match(
|
|
codexPatch,
|
|
/!context\.isToolApproval && this\.shouldUseAcpElicitation\(params\)/,
|
|
);
|
|
});
|
|
|
|
test("the Claude patch removes ambient project and local configuration", () => {
|
|
for (const token of [
|
|
"PAPERCLIP_ACPX_ISOLATED_CONTEXT",
|
|
'settingSources: ["user"]',
|
|
"userProvidedOptions?.mcpServers",
|
|
]) {
|
|
assert.match(
|
|
claudePatch,
|
|
new RegExp(token.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")),
|
|
);
|
|
}
|
|
});
|